Paths

Table of Contentst

Differential D116865

[OpenMP][FIX] Emit debug declares only if debug info is available
ClosedPublic
Actions

Authored by jdoerfert on Jan 8 2022, 11:56 AM.

Details

Reviewers

ye-luo
JonChesterfield
jhuber6

Commits

rG37639b72a17b: [OpenMP][FIX] Emit debug declares only if debug info is available

Summary

The EmitDeclareOfAutoVariable introduced in D114504 and D115510 has a
precondition that cannot be violated. It is unclear if we should call it
directly given the sparse usage in clang but for now we should at least
not crash if the debug info kind is too low.

Fixes #52938.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jdoerfert created this revision.Jan 8 2022, 11:56 AM

Herald added subscribers: guansong, bollu, yaxunl. · View Herald TranscriptJan 8 2022, 11:56 AM

jdoerfert requested review of this revision.Jan 8 2022, 11:56 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2022, 11:56 AM

Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript

Clang format

Harbormaster completed remote builds in B142238: Diff 398358.Jan 8 2022, 1:02 PM

Confirm that #52938 is fixed by this patch.

ye-luo accepted this revision.Jan 8 2022, 1:59 PM

This revision is now accepted and ready to land.Jan 8 2022, 1:59 PM

Closed by commit rG37639b72a17b: [OpenMP][FIX] Emit debug declares only if debug info is available (authored by jdoerfert). · Explain WhyJan 8 2022, 4:13 PM

This revision was automatically updated to reflect the committed changes.

jdoerfert added a commit: rG37639b72a17b: [OpenMP][FIX] Emit debug declares only if debug info is available.

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

CGStmtOpenMP.cpp

10 lines

test/

OpenMP/

debug_private.c

4 lines

debug_task_shared.c

3 lines

Diff 398357

clang/lib/CodeGen/CGStmtOpenMP.cpp

Loading...

clang/test/OpenMP/debug_private.c

Loading...

clang/test/OpenMP/debug_task_shared.c

Loading...