This is an archive of the discontinued LLVM Phabricator instance.

[mlir][linalg] Replace LinalgOps.h and LinalgTypes.h by a single header.
ClosedPublic

Authored by gysit on Dec 14 2021, 6:37 AM.

Details

Summary

After removing the range type, Linalg does not define any type. The revision thus consolidates the LinalgOps.h and LinalgTypes.h into a single Linalg.h header. Additionally, LinalgTypes.cpp is renamed to LinalgDialect.cpp to follow the convention adopted by other dialects such as the tensor dialect.

Depends On D115727

Diff Detail

Event Timeline

gysit created this revision.Dec 14 2021, 6:37 AM
gysit requested review of this revision.Dec 14 2021, 6:37 AM
gysit added a comment.Dec 14 2021, 6:39 AM

After removing the last Linalg Type in https://reviews.llvm.org/D115727, I think it would make sense to merge the LinalgTypes.h and LinalgOp.h headers. However, this causes quite of header fixes in downstream projects. We can also abandon this revision if preferred.

nicolasvasilache accepted this revision.Dec 14 2021, 9:56 AM
This revision is now accepted and ready to land.Dec 14 2021, 9:56 AM
This revision was landed with ongoing or failed builds.Dec 15 2021, 4:24 AM
This revision was automatically updated to reflect the committed changes.
mlir/include/mlir/Dialect/Linalg/IR/Linalg.h