Page MenuHomePhabricator

mib (Med Ismail Bennani)
Compiler Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2019, 8:24 PM (180 w, 3 d)

Recent Activity

Yesterday

mib committed rGea8b811bf800: [lldb/Core] Fix finite progress event reporting (authored by mib).
[lldb/Core] Fix finite progress event reporting
Tue, Jul 5, 4:26 PM · Restricted Project
mib closed D128768: [lldb/Core] Fix finite progress event reporting.
Tue, Jul 5, 4:26 PM · Restricted Project, Restricted Project
mib updated the summary of D128768: [lldb/Core] Fix finite progress event reporting.
Tue, Jul 5, 4:24 PM · Restricted Project, Restricted Project
mib updated the diff for D128768: [lldb/Core] Fix finite progress event reporting.

Address @JDevlieghere comment

Tue, Jul 5, 2:16 PM · Restricted Project, Restricted Project

Wed, Jun 29

mib added a comment to D128638: [lldb] [llgs] Add base nonstop fork/vfork tests.

Not sure if this is related to this patch but TestGdbRemote_vContThreads.py is still timing out on the macOS bot:

Wed, Jun 29, 4:35 PM · Restricted Project, Restricted Project
mib updated the diff for D128768: [lldb/Core] Fix finite progress event reporting.

Refactor logging code

Wed, Jun 29, 4:04 PM · Restricted Project, Restricted Project
mib added inline comments to D128768: [lldb/Core] Fix finite progress event reporting.
Wed, Jun 29, 3:58 PM · Restricted Project, Restricted Project
mib updated the diff for D128768: [lldb/Core] Fix finite progress event reporting.

Log only when verbose mode is enabled

Wed, Jun 29, 11:44 AM · Restricted Project, Restricted Project
mib added a comment to D128768: [lldb/Core] Fix finite progress event reporting.

The fix looks good but I'm torn about the added logging. On the one hand it'll make finding issues like this easier in the future, but on the other hand, while this code isn't "hot", it is something where performance matters. My concern is that this will potentially cause progress events to get queued. If the progress updates aren't real time they are pretty much useless.

If it were up to me I'd probably remove the logging altogether, but maybe there's a middle ground where we have one log message that we only print in verbose mode? Then the (default) penalty is just checking if the log is enabled and verbose.

What do you think?

Wed, Jun 29, 10:55 AM · Restricted Project, Restricted Project

Tue, Jun 28

mib added a comment to D128638: [lldb] [llgs] Add base nonstop fork/vfork tests.

There are some random test failures following this patch on lldb-debian-x86_64: https://lab.llvm.org/buildbot/#/builders/68/builds/34883

Tue, Jun 28, 3:48 PM · Restricted Project, Restricted Project
mib committed rG44a114fec715: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285 (authored by mib).
[lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285
Tue, Jun 28, 3:34 PM · Restricted Project
mib closed D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285.
Tue, Jun 28, 3:34 PM · Restricted Project, Restricted Project
mib requested review of D128768: [lldb/Core] Fix finite progress event reporting.
Tue, Jun 28, 3:31 PM · Restricted Project, Restricted Project

Mon, Jun 27

mib updated the diff for D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285.

Use field identifiers instead of indices and add long-mode support.

Mon, Jun 27, 6:31 PM · Restricted Project, Restricted Project
mib added inline comments to D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285.
Mon, Jun 27, 6:10 PM · Restricted Project, Restricted Project
mib added a comment to D126983: [lldb] [llgs] Support "t" vCont action.

This patch is causing a test to fail on the macOS bot:
https://green.lab.llvm.org/green/job/lldb-cmake/44921/consoleText

Mon, Jun 27, 6:08 PM · Restricted Project, Restricted Project
mib updated subscribers of D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285.
Mon, Jun 27, 6:02 PM · Restricted Project, Restricted Project
mib requested review of D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285.
Mon, Jun 27, 5:40 PM · Restricted Project, Restricted Project

Fri, Jun 24

mib accepted D128557: [lldb] Add a log dump command to dump the circular log buffer.

LGTM!

Fri, Jun 24, 2:10 PM · Restricted Project, Restricted Project
mib added inline comments to D128323: [lldb] Add support for specifying a log handler.
Fri, Jun 24, 1:53 PM · Restricted Project, Restricted Project

Thu, Jun 23

mib added inline comments to D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error,Warning}.
Thu, Jun 23, 4:59 PM · Restricted Project, Restricted Project
mib added inline comments to D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error,Warning}.
Thu, Jun 23, 4:57 PM · Restricted Project, Restricted Project
mib accepted D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory.

This looks way better :) !

Thu, Jun 23, 1:41 PM · Restricted Project, Restricted Project
mib added a comment to D128213: [IR] Export ConstantFold.h header (NFC).

@nikic this broke the lldb macOS bot because you didn't update the module map. 148071fbae3f9a1015969376a75a47d433c49a13 should fix that.

Thu, Jun 23, 11:59 AM · Restricted Project, Restricted Project
mib committed rG148071fbae3f: [llvm] Update module map to include the `IR/ConstantFold` header (authored by mib).
[llvm] Update module map to include the `IR/ConstantFold` header
Thu, Jun 23, 11:55 AM · Restricted Project, Restricted Project
mib added a comment to D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory.

@cassanova You probably also want to implement this for the command-interpreter-fuzzer target

Thu, Jun 23, 9:41 AM · Restricted Project, Restricted Project

Wed, Jun 22

mib accepted D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB.

Ship it!

Wed, Jun 22, 2:41 PM · Restricted Project, Restricted Project
mib added inline comments to D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB.
Wed, Jun 22, 2:00 PM · Restricted Project, Restricted Project
mib added inline comments to D128323: [lldb] Add support for specifying a log handler.
Wed, Jun 22, 11:23 AM · Restricted Project, Restricted Project
mib added inline comments to D128323: [lldb] Add support for specifying a log handler.
Wed, Jun 22, 11:21 AM · Restricted Project, Restricted Project
mib accepted D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB.

LGTM!

Wed, Jun 22, 10:57 AM · Restricted Project, Restricted Project

Tue, Jun 21

mib added a comment to D125575: [lldb] [llgs] Implement non-stop style stop notification packets.

Hi @mgorny ! TestNonStop.py is also failing on the macOS bots: https://green.lab.llvm.org/green/job/lldb-cmake/44743/

Tue, Jun 21, 5:54 PM · Restricted Project, Restricted Project
mib added inline comments to D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB.
Tue, Jun 21, 1:44 PM · Restricted Project, Restricted Project
mib added inline comments to D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB.
Tue, Jun 21, 1:34 PM · Restricted Project, Restricted Project
mib added inline comments to D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB.
Tue, Jun 21, 1:33 PM · Restricted Project, Restricted Project

Fri, Jun 17

mib accepted D128077: [lldb][tests] Automatically call compute_mydir (NFC).

Great! LGTM!

Fri, Jun 17, 11:40 AM · Restricted Project, Restricted Project

Thu, Jun 16

mib added inline comments to D127922: [lldb] Introduce the concept of a log handler (NFC).
Thu, Jun 16, 10:54 AM · Restricted Project, Restricted Project

Wed, Jun 15

mib added a comment to D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.

A bit late to this ... thanks for your fix!

Wed, Jun 15, 10:47 PM · Restricted Project, Restricted Project
mib added inline comments to D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter.
Wed, Jun 15, 1:33 PM · Restricted Project, Restricted Project
mib accepted D127882: [lldb/Fuzzer] Create ninja target for target fuzzer .

LGTM!

Wed, Jun 15, 11:45 AM · Restricted Project, Restricted Project
mib added a comment to D127882: [lldb/Fuzzer] Create ninja target for target fuzzer .

How is this any different from running ninja lldb-target-fuzzer ? I might be missing something ...

Wed, Jun 15, 11:42 AM · Restricted Project, Restricted Project
mib added a comment to D127882: [lldb/Fuzzer] Create ninja target for target fuzzer .

How is this any different from running ninja lldb-target-fuzzer ? I might be missing something ...

Wed, Jun 15, 11:37 AM · Restricted Project, Restricted Project

Fri, Jun 10

mib committed rG5a9fa21ce82f: [lldb/crashlog] Show help when the command is called without any argument (authored by mib).
[lldb/crashlog] Show help when the command is called without any argument
Fri, Jun 10, 1:48 PM · Restricted Project
mib closed D127362: [lldb/crashlog] Show help when the command is called without any argument.
Fri, Jun 10, 1:47 PM · Restricted Project, Restricted Project
mib accepted D127458: [lldb][bindings] Implement __repr__ instead of __str__.

Thanks @kastiglione !

Fri, Jun 10, 10:57 AM · Restricted Project, Restricted Project
mib accepted D127038: Add some documentation for the "breakpoint name" feature.

Thanks Jim!

Fri, Jun 10, 10:05 AM · Restricted Project, Restricted Project
mib accepted D127458: [lldb][bindings] Implement __repr__ instead of __str__.

Thanks for clarifying! LGTM with a test!

Fri, Jun 10, 9:37 AM · Restricted Project, Restricted Project

Thu, Jun 9

mib added a comment to D127458: [lldb][bindings] Implement __repr__ instead of __str__.

What happens if you try to call str after your change ? I have no objection with this change, I think rather it will greatly improve manipulating SBTypes in the interpreter ! Just making sure this passes the test suite and doesn't break the previous behavior

Thu, Jun 9, 6:20 PM · Restricted Project, Restricted Project

Wed, Jun 8

mib updated the diff for D127362: [lldb/crashlog] Show help when the command is called without any argument.

Add test

Wed, Jun 8, 4:21 PM · Restricted Project, Restricted Project
mib requested review of D127362: [lldb/crashlog] Show help when the command is called without any argument.
Wed, Jun 8, 4:00 PM · Restricted Project, Restricted Project
mib accepted D127355: [lldb] Add assertState function.

Awesome! Thanks!

Wed, Jun 8, 3:57 PM · Restricted Project, Restricted Project
mib added a comment to D127355: [lldb] Add assertState function.

Pretty cool but it would be nice to have the following formatting: "AssertionError: stopped (5) != exited (10) : message" ... I feel like it's easier to read this way

Wed, Jun 8, 3:41 PM · Restricted Project, Restricted Project

Tue, Jun 7

mib accepted D127258: [lldb] Parse the dotest output to determine the most appropriate result code.

Even better! LGTM!

Tue, Jun 7, 4:13 PM · Restricted Project, Restricted Project
mib accepted D127258: [lldb] Parse the dotest output to determine the most appropriate result code.

Makes more sense. LGTM!

Tue, Jun 7, 3:35 PM · Restricted Project, Restricted Project

Jun 3 2022

mib added a comment to D127038: Add some documentation for the "breakpoint name" feature.

Thanks for writing that! I'm sure many users will find it very useful.

Jun 3 2022, 5:37 PM · Restricted Project, Restricted Project
mib accepted D127016: [lldb] Prevent crash due to reading memory from page zero..

LGTM with some minor feedbacks :) !

Jun 3 2022, 4:23 PM · Restricted Project, Restricted Project

May 23 2022

mib requested review of D126260: [lldb/crashlog] Add support for Application Specific Backtraces.
May 23 2022, 5:25 PM · Restricted Project, Restricted Project

May 20 2022

mib accepted D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput.
May 20 2022, 2:02 PM · Restricted Project, Restricted Project

May 19 2022

mib committed rG027499a82434: [lldb/test] Fix PExpect.launch issue when disabling color support (authored by mib).
[lldb/test] Fix PExpect.launch issue when disabling color support
May 19 2022, 2:47 PM · Restricted Project
mib closed D126021: [lldb/test] Fix PExpect.launch issue when disabling color support.
May 19 2022, 2:47 PM · Restricted Project, Restricted Project
mib requested review of D126021: [lldb/test] Fix PExpect.launch issue when disabling color support.
May 19 2022, 2:46 PM · Restricted Project, Restricted Project
mib accepted D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer .

LGTM

May 19 2022, 11:42 AM · Restricted Project, Restricted Project

May 18 2022

mib committed rG1351a9b19ecf: [lldb/test] Fix failures caused by a previous PExpect.launch change (authored by mib).
[lldb/test] Fix failures caused by a previous PExpect.launch change
May 18 2022, 9:13 PM · Restricted Project
mib added a reverting change for rG80589f272c20: [lldb/test] Make some tests as XFAIL while I investigate the issue: rGfbf0c4229410: Revert "[lldb/test] Make some tests as XFAIL while I investigate the issue".
May 18 2022, 9:13 PM · Restricted Project
mib committed rGfbf0c4229410: Revert "[lldb/test] Make some tests as XFAIL while I investigate the issue" (authored by mib).
Revert "[lldb/test] Make some tests as XFAIL while I investigate the issue"
May 18 2022, 9:13 PM · Restricted Project
mib added a reverting change for rG821ee172cdcd: dyld patch: rGfd25ad51224e: Revert 821ee172cdcd7196b6130321b53b6cc66bf1222b.
May 18 2022, 7:10 PM · Restricted Project
mib committed rGfd25ad51224e: Revert 821ee172cdcd7196b6130321b53b6cc66bf1222b (authored by mib).
Revert 821ee172cdcd7196b6130321b53b6cc66bf1222b
May 18 2022, 7:10 PM · Restricted Project
mib committed rG80589f272c20: [lldb/test] Make some tests as XFAIL while I investigate the issue (authored by mib).
[lldb/test] Make some tests as XFAIL while I investigate the issue
May 18 2022, 6:54 PM · Restricted Project
mib committed rG821ee172cdcd: dyld patch (authored by mib).
dyld patch
May 18 2022, 6:54 PM · Restricted Project
mib committed rG051a5ae99824: [lldb/Core] Fix "sticky" long progress messages (authored by mib).
[lldb/Core] Fix "sticky" long progress messages
May 18 2022, 6:23 PM · Restricted Project
mib committed rG3e54ea0cfa30: [lldb/crashlog] Fix line entries resolution in interactive mode (authored by mib).
[lldb/crashlog] Fix line entries resolution in interactive mode
May 18 2022, 6:23 PM · Restricted Project
mib committed rGd71d1a947bee: [lldb/Test] Add `use_colors` argument to the PExpect.launch wrapper (authored by mib).
[lldb/Test] Add `use_colors` argument to the PExpect.launch wrapper
May 18 2022, 6:23 PM · Restricted Project
mib committed rGb3718bc4672b: [llvm/Support] Fallback to $TERM if terminfo has no "colors" capability (authored by mib).
[llvm/Support] Fallback to $TERM if terminfo has no "colors" capability
May 18 2022, 6:23 PM · Restricted Project, Restricted Project
mib closed D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
May 18 2022, 6:23 PM · Restricted Project, Restricted Project
mib closed D124785: [lldb/Core] Fix "sticky" long progress messages.
May 18 2022, 6:23 PM · Restricted Project, Restricted Project
mib closed D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper.
May 18 2022, 6:23 PM · Restricted Project, Restricted Project
mib closed D125914: [llvm/Support] Fallback to $TERM if terminfo has no "colors" capability.
May 18 2022, 6:23 PM · Restricted Project, Restricted Project
mib updated the diff for D124785: [lldb/Core] Fix "sticky" long progress messages.

Only run test on Darwin platforms

May 18 2022, 6:19 PM · Restricted Project, Restricted Project
mib added inline comments to D124785: [lldb/Core] Fix "sticky" long progress messages.
May 18 2022, 6:17 PM · Restricted Project, Restricted Project
mib updated the diff for D124785: [lldb/Core] Fix "sticky" long progress messages.

Address @JDevlieghere comments

May 18 2022, 6:11 PM · Restricted Project, Restricted Project
mib updated the diff for D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.

Updated comment

May 18 2022, 2:18 PM · Restricted Project, Restricted Project
mib updated the summary of D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
May 18 2022, 2:12 PM · Restricted Project, Restricted Project
mib updated the summary of D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
May 18 2022, 2:11 PM · Restricted Project, Restricted Project
mib updated the summary of D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
May 18 2022, 2:11 PM · Restricted Project, Restricted Project
mib updated the summary of D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
May 18 2022, 2:10 PM · Restricted Project, Restricted Project
mib requested review of D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
May 18 2022, 2:10 PM · Restricted Project, Restricted Project
mib accepted D125921: [SystemZ][z/OS] Add missing include .

LGTM! Thanks!

May 18 2022, 12:54 PM · Restricted Project, Restricted Project
mib added a comment to D125725: [SystemZ][z/OS] Add PPA1 support.

Hey @yusra.syeda ! It looks like your patch broke the macOS lldb bot: https://green.lab.llvm.org/green/job/lldb-cmake/

May 18 2022, 12:06 PM · Restricted Project, Restricted Project
mib updated the diff for D124785: [lldb/Core] Fix "sticky" long progress messages.

Add test

May 18 2022, 11:37 AM · Restricted Project, Restricted Project
mib requested review of D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper.
May 18 2022, 11:35 AM · Restricted Project, Restricted Project
mib requested review of D125914: [llvm/Support] Fallback to $TERM if terminfo has no "colors" capability.
May 18 2022, 11:33 AM · Restricted Project, Restricted Project

May 16 2022

mib accepted D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py.

LGTM

May 16 2022, 2:42 PM · Restricted Project, Restricted Project

May 13 2022

mib committed rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex… (authored by mib).
[lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex…
May 13 2022, 6:33 PM · Restricted Project
mib closed D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC).
May 13 2022, 6:33 PM · Restricted Project, Restricted Project
mib requested review of D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC).
May 13 2022, 4:50 PM · Restricted Project, Restricted Project
mib accepted D125589: [lldb] Don't swallow crashlog exceptions.
May 13 2022, 3:56 PM · Restricted Project, Restricted Project
mib added inline comments to D125589: [lldb] Don't swallow crashlog exceptions.
May 13 2022, 3:50 PM · Restricted Project, Restricted Project
mib closed D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.

Actually, landed this yesterday in a6926d576131c9ad849fef6f1d43134caab5025e

May 13 2022, 11:27 AM · Restricted Project, Restricted Project

May 12 2022

mib committed rG2d7b49f38978: [lldb/test] Skip TestCppIncompleteTypeMembers.py for -gmodules on macOS (authored by mib).
[lldb/test] Skip TestCppIncompleteTypeMembers.py for -gmodules on macOS
May 12 2022, 5:12 PM · Restricted Project
mib committed rG8b9caad8eb44: [lldb/test] Skip TestCppIncompleteTypeMembers.py on Darwin (NFC) (authored by mib).
[lldb/test] Skip TestCppIncompleteTypeMembers.py on Darwin (NFC)
May 12 2022, 4:56 PM · Restricted Project