Page MenuHomePhabricator

mib (Med Ismail Bennani)
Compiler Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2019, 8:24 PM (125 w, 6 d)

Recent Activity

Tue, Jun 8

mib added a comment to D103500: [trace][intel-pt] Create basic SB API.

Took a look at the SBAPI changes and left few comments but overall, that part looked good to me. It would be nice if you could delete the depreciated method/class.

Tue, Jun 8, 12:09 PM · Restricted Project

Fri, Jun 4

mib accepted D103675: [LLDB/API] Expose args and env from SBProcessInfo..

LGTM!

Fri, Jun 4, 2:02 AM · Restricted Project

Tue, Jun 1

mib accepted D103454: [lldb][docs] Document SBType.

Left few comments regarding the phrasing but LGTM! Thanks for doing it!

Tue, Jun 1, 9:37 AM · Restricted Project
mib accepted D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit.

LGTM!

Tue, Jun 1, 6:27 AM · Restricted Project

Thu, May 27

mib requested changes to D103271: [lldb/Target] Select most relevant frame only in case of signal.

At first sight, this looks like a fair addition, but this feature is also used to report Swift Runtime Failure in the debugger (and Xcode) ...

Thu, May 27, 11:43 AM · Restricted Project

May 17 2021

mib committed rG1b4d5b3bf306: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex (authored by mib).
[lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex
May 17 2021, 5:29 PM
mib closed D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex.
May 17 2021, 5:29 PM · Restricted Project
mib updated the diff for D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex.

Add test.

May 17 2021, 5:28 PM · Restricted Project
mib requested review of D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex.
May 17 2021, 4:29 PM · Restricted Project

May 4 2021

mib committed rG9775582e347c: [lldb/Test] Disable testBreakpointByLineAndColumnNearestCode on Windows (authored by mib).
[lldb/Test] Disable testBreakpointByLineAndColumnNearestCode on Windows
May 4 2021, 11:04 PM
mib committed rG35ecfda01ccd: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match (authored by mib).
[lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match
May 4 2021, 10:08 PM
mib closed D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.
May 4 2021, 10:08 PM · Restricted Project
mib updated the diff for D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.

Address @JDevlieghere comments.

May 4 2021, 9:27 PM · Restricted Project
mib added inline comments to D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.
May 4 2021, 9:24 PM · Restricted Project
mib committed rGd5069dace7c2: [lldb/Symbol] Fix typo in SymbolFilePDBTests (NFC) (authored by mib).
[lldb/Symbol] Fix typo in SymbolFilePDBTests (NFC)
May 4 2021, 5:39 PM
mib committed rG30fcdf0b1966: [lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec (authored by mib).
[lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec
May 4 2021, 5:35 PM
mib committed rG3e2ed7440569: [lldb] Refactor argument group by SourceLocationSpec (NFCI) (authored by mib).
[lldb] Refactor argument group by SourceLocationSpec (NFCI)
May 4 2021, 4:05 PM
mib closed D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
May 4 2021, 4:05 PM · Restricted Project
mib committed rGadfffebec6d6: [lldb/Core] Add SourceLocationSpec class (NFC) (authored by mib).
[lldb/Core] Add SourceLocationSpec class (NFC)
May 4 2021, 9:35 AM
mib committed rG1435f6b00be7: [lldb] Move and clean-up the Declaration class (NFC) (authored by mib).
[lldb] Move and clean-up the Declaration class (NFC)
May 4 2021, 9:35 AM
mib committed rG0c3f762c8fd1: [lldb/Utility] Update path in FileSpec documentation (NFC) (authored by mib).
[lldb/Utility] Update path in FileSpec documentation (NFC)
May 4 2021, 9:35 AM
mib closed D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
May 4 2021, 9:35 AM · Restricted Project
mib closed D101556: [lldb] Move and clean-up the Declaration class (NFC).
May 4 2021, 9:35 AM · Restricted Project

Apr 30 2021

mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 30 2021, 4:21 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 30 2021, 3:46 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 30 2021, 3:32 PM · Restricted Project
mib updated the diff for D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.
Apr 30 2021, 2:34 AM · Restricted Project

Apr 29 2021

mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 29 2021, 10:50 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 29 2021, 9:35 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

Address @JDevlieghere comments.

Apr 29 2021, 9:06 PM · Restricted Project
mib updated the diff for D101556: [lldb] Move and clean-up the Declaration class (NFC).

Addressed @JDevlieghere comments.

Apr 29 2021, 8:37 PM · Restricted Project
mib added a comment to D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

The points that @teemperor brought up have been implemented in D101556 and D100962.

Apr 29 2021, 8:18 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

As discussed with @JDevlieghere offline, at the moment SearchFilter and Searcher (from which many class inherit) are not designed for error handling so I removed the SourceLocationSpec::Create factory method and added an IsValid method to check the state optionally.

Apr 29 2021, 8:16 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

Wrap SourceLocationSpec column argument into an llvm::Optional

Apr 29 2021, 8:07 PM · Restricted Project
mib requested review of D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 29 2021, 7:15 PM · Restricted Project
mib retitled D100962: [lldb/Core] Add SourceLocationSpec class (NFC) from [lldb/Utility] Add SourceLocationSpec class (NFC) to [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 29 2021, 7:14 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 29 2021, 7:13 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 29 2021, 7:12 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

Group the FileSpec, the Line and Column number into a Declaration.
Remove factory function to use constructor and added an IsValid method (and boolean operator)

Apr 29 2021, 7:11 PM · Restricted Project
mib updated the diff for D101556: [lldb] Move and clean-up the Declaration class (NFC).

Addressed @JDevlieghere comments.

Apr 29 2021, 6:11 PM · Restricted Project
mib added a comment to D101556: [lldb] Move and clean-up the Declaration class (NFC).

IIRC they were #ifdef's out because of memory concerns. Did you have a chance to benchmark this quickly (e.g., trying to attach to a debug Clang and see how much it increases memory)

Otherwise this LGTM.

FWIW, we also need this for the SourceLocation in Clang Decls feature I was working on some time ago.

Apr 29 2021, 6:09 PM · Restricted Project
mib requested review of D101556: [lldb] Move and clean-up the Declaration class (NFC).
Apr 29 2021, 11:18 AM · Restricted Project

Apr 26 2021

mib added a comment to D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

I am wondering how SourceLocationSpec is related to lldb's Declaration class (which is FileSpec + line + column and describes a location in source code)? It seems like the current SourceLocationSpec is just a Declaration with the two additional search variables (and the first iteration was exactly the same as Declaration).
Could we maybe turn SourceLocationSpec to store a lldb::Declaration instead of file/line/column? I'm aware that the Declaration class first needs some cleanup (and a removal of that #ifdef around column....), but right now we are already using Declarations in a bunch of places to describe source locations.

Apr 26 2021, 6:14 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Use llvm::Expected error when possible.

Apr 26 2021, 6:05 PM · Restricted Project

Apr 23 2021

mib requested review of D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.
Apr 23 2021, 7:38 PM · Restricted Project
mib added inline comments to D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 23 2021, 6:29 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Fix test failures.

Apr 23 2021, 5:30 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 23 2021, 5:27 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

Fix unit test failure.

Apr 23 2021, 4:35 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Addressed @JDevlieghere comments.

Apr 23 2021, 3:30 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Addressed @JDevlieghere @shafik feedbacks.

Apr 23 2021, 11:54 AM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

Address @JDevlieghere comments.

Apr 23 2021, 11:18 AM · Restricted Project
mib added inline comments to D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 23 2021, 9:28 AM · Restricted Project

Apr 22 2021

mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Update BreakpointResolver column default value and fix typo

Apr 22 2021, 10:23 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Update LineEntry unit test.

Apr 22 2021, 10:16 PM · Restricted Project
mib retitled D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI) from [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI) to [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 22 2021, 10:07 PM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Address @JDevlieghere & @jingham feedbacks.

Apr 22 2021, 10:06 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
  • Move boolean attributes to the end of the class.
  • Fix deleted default constructor issue.
Apr 22 2021, 9:30 PM · Restricted Project
mib updated the diff for D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

Addressed @JDevlieghere comments.

Apr 22 2021, 11:45 AM · Restricted Project
mib added inline comments to D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 22 2021, 11:44 AM · Restricted Project

Apr 21 2021

mib added inline comments to D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 21 2021, 8:45 AM · Restricted Project
mib updated the diff for D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 21 2021, 8:40 AM · Restricted Project
mib requested review of D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 21 2021, 8:38 AM · Restricted Project
mib requested review of D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 21 2021, 8:18 AM · Restricted Project

Apr 14 2021

mib updated the diff for D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin.

Use Doxygen group comment for ScriptedProcess members.

Apr 14 2021, 1:59 PM · Restricted Project

Apr 13 2021

mib updated the diff for D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin.

Address @JDevlieghere feedbacks

Apr 13 2021, 12:09 PM · Restricted Project
mib updated the diff for D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin.

Dead-code removal

Apr 13 2021, 9:13 AM · Restricted Project
mib requested review of D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin.
Apr 13 2021, 6:59 AM · Restricted Project

Mar 31 2021

mib accepted D99652: [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by initializing LLVM's command line parser.

It's unfortunate the first 2 options are not feasible at the moment. Your implementation looks like a good compromise. Thanks for the thorough explanation.
LGTM!

Mar 31 2021, 10:51 AM · Restricted Project

Mar 25 2021

mib added inline comments to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.
Mar 25 2021, 7:43 AM · Restricted Project

Mar 24 2021

mib updated the diff for D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

Addressing @stella.stamenova feedback.

Mar 24 2021, 1:51 PM · Restricted Project
mib added inline comments to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.
Mar 24 2021, 1:47 PM · Restricted Project
mib committed rGfad34da7fdcd: Revert "[lldb/Plugins] Add ScriptedProcess Process Plugin" (authored by mib).
Revert "[lldb/Plugins] Add ScriptedProcess Process Plugin"
Mar 24 2021, 1:31 PM
mib committed rG13bb39aad347: [NFC][LLDB] Removing extra semicolons to silence -Wc++98-compat-extra-semi… (authored by shafik).
[NFC][LLDB] Removing extra semicolons to silence -Wc++98-compat-extra-semi…
Mar 24 2021, 11:11 AM
mib committed rGb09d44b6ae09: [lldb/Plugins] Add ScriptedProcess Process Plugin (authored by mib).
[lldb/Plugins] Add ScriptedProcess Process Plugin
Mar 24 2021, 11:11 AM
mib added a comment to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

With the help of @teemperor, I was able to test that my latest changes work on Linux with and without enabling python for lldb. I'll re-land the patch and monitor the bots to make sure there is no other issues.

Mar 24 2021, 11:10 AM · Restricted Project
mib updated the diff for D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

Enable ScriptedProcess process plugin only when LLDB_ENABLE_PYTHON is true.

Mar 24 2021, 11:02 AM · Restricted Project
mib added a comment to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

I've reverted this. If you need help debugging this, please let me know. Also, as a reminder, please see the attached build log from earlier in the conversation. Thanks!

Mar 24 2021, 6:40 AM · Restricted Project
mib closed D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch.

Landed in 3e0ad115439622b9c3e6ca9fd64c7fb07a679f1a

Mar 24 2021, 6:34 AM · Restricted Project

Mar 23 2021

mib committed rGdd391e1ef762: [lldb/Plugins] Add ScriptedProcess Process Plugin (authored by mib).
[lldb/Plugins] Add ScriptedProcess Process Plugin
Mar 23 2021, 10:25 AM
mib committed rGf3176f5fede2: [lldb/bindings] Add Python ScriptedProcess base class to lldb module (authored by mib).
[lldb/bindings] Add Python ScriptedProcess base class to lldb module
Mar 23 2021, 10:25 AM
mib committed rG1f6a57c1a0fa: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess (authored by mib).
[lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess
Mar 23 2021, 10:25 AM
mib committed rG3e0ad1154396: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch (authored by mib).
[lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch
Mar 23 2021, 10:25 AM

Mar 5 2021

mib committed rGc964741996bc: [lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC) (authored by mib).
[lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC)
Mar 5 2021, 10:34 AM
mib committed rG36eab4634f4c: [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting (authored by mib).
[lldb/Interpreter] Add `interpreter.repeat-previous-command` setting
Mar 5 2021, 10:34 AM
mib closed D98001: [lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC).
Mar 5 2021, 10:34 AM · Restricted Project
mib closed D97999: [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting.
Mar 5 2021, 10:33 AM · Restricted Project
mib updated the diff for D98001: [lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC).

Add test.

Mar 5 2021, 10:01 AM · Restricted Project

Mar 4 2021

mib requested review of D98001: [lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC).
Mar 4 2021, 7:28 PM · Restricted Project
mib added a reviewer for D97999: [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting: teemperor.
Mar 4 2021, 6:46 PM · Restricted Project
mib requested review of D97999: [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting.
Mar 4 2021, 6:45 PM · Restricted Project
mib committed rGc16fef19f6b0: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required (authored by mib).
[lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required
Mar 4 2021, 11:25 AM
mib closed D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required.
Mar 4 2021, 11:25 AM · Restricted Project
mib updated the diff for D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required.
Mar 4 2021, 10:16 AM · Restricted Project
mib updated the diff for D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required.

Replace std::bitset by lldb_private::Flags as suggested by @JDevlieghere

Mar 4 2021, 9:34 AM · Restricted Project

Mar 3 2021

mib closed D95100: [lldb/Commands] Fix short option collision for `process launch`.

Landed in 103ad3f90

Mar 3 2021, 10:02 PM · Restricted Project
mib updated the diff for D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required.

Fix header guard length.

Mar 3 2021, 10:00 PM · Restricted Project
mib requested review of D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required.
Mar 3 2021, 9:43 PM · Restricted Project

Mar 2 2021

mib accepted D97778: [lldb] Extend Python convenience variable table with equivalent APIs.

Cool! LGTM!

Mar 2 2021, 9:37 AM · Restricted Project
mib added a comment to D97486: [lldb/Core] Change large function threshold variable into a setting..

As the author of this logic, I want to note that the original limit I chose was very arbitrary, and 32k (or any other small-ish number would work equally well). The main objective was to disable accidental multi-megabyte disassemblies (which can happen when the object file has no symbol information).

I'm not actually opposed to the, just wanting to make sure you're not adding it on my account.

Mar 2 2021, 1:33 AM · Restricted Project