- User Since
- Jan 19 2019, 8:24 PM (97 w, 4 d)
Oct 27 2020
Oct 23 2020
Add negative test for -debugger-tune=sce.
It seems that the HWASAN pre-check test is also failing in D89844 (https://buildkite.com/llvm-project/premerge-checks/builds/14519) ... I also tested on Linux and the test passes so I guess this is an issue with the bot.
Fix pre-check test failures
Oct 22 2020
Change shell test for unit test.
Oct 20 2020
Oct 19 2020
What if we tested each substring individually with self.assertIn to avoid checking the order of the substrings as it seems to change depending on the target ?
Oct 16 2020
LGTM provided that you address my last comments :)
Oct 15 2020
Could you please follow PEP8 style guide regarding variable names :
Oct 6 2020
LGTM! Have you considered also adding an option to the expression command object ? May be some people would like to change the error limit for a specific expression...
Sep 29 2020
Spotted some little things here and there ... This patch lacks a test and would need some reformatting (git clang-format HEAD~) but other than that, looks ok to me.
Sep 28 2020
Sep 11 2020
Add invalid breakpoint test case.
Sep 10 2020
Sep 8 2020
Some nitpicking but this looks fine to me.
Sep 3 2020
Sep 2 2020
@max-kudr Looking, thanks!
Sep 1 2020
Aug 28 2020
Replaced all the interpreter occurrences with shell in the code.
Removed bool run_in_shell argument from Platform classes.
- Changed CommandObject option from -i|--interpreter to -s|--shell.
- Updated test program build settings.
Aug 27 2020
Address most comments:
- Passed down the shell interpreter path down to Host::RunShellCommand to be "assembled" with the rest of the command.
- Wrote a custom test program to simplify testing on multiple platforms.
- Updated code by using llvm::StringRef instead of CString when possible.
Aug 26 2020
Aug 19 2020
Updated man page to reflect current implementation.
Addressed @JDevlieghere comments.
Aug 4 2020
Jul 24 2020
Just a little nit, but as we already discussed offline, I have some doubts about adding a --dummy option.
It sounds unnecessary to me, so I'd like to hear @jingham take on this.
Jul 23 2020
Looks good to me.
Jul 22 2020
I find the macro cleaner than my changes in D84305. LGTM!
Abandoning this revision in favour of D84336
Address @labath comments
Jul 21 2020
Address @JDevlieghere comments.
Thanks for the changes. LGTM!
- Address previous comments
- Add test
Jul 20 2020
The patch looks fine to me. May be it could have a unittest to check the TypeMatcher in an isolated manner ?
Jul 16 2020
Jul 15 2020
Looks good to me, beside a little nit.