- User Since
- Jan 19 2019, 8:24 PM (71 w, 3 d)
Fri, May 15
Merged the shell and platform shell test as @JDevlieghere suggested it.
Thu, May 14
Instead of creating a new empty struct type, this new implementation will use the opaque pointer's pointee type to create the new ValueObjectChild.
This makes the previously introduced helper function in TypeSystem and TypeSystemClang useless, so I got rid of them.
Mon, May 11
Sat, May 9
It looks like command options are not supported on aliases that already have options:
With the first implementation, I thought it'd be a good idea to have separate Command Objects for platform shell and shell because I was imagining the latter could be more "powerful": shell could have an interactive mode like the script command, which might not be as relevant for platform shell when debugging a remote target.
Fri, May 8
- Added a virtual method to create an empty struct type TypeSystem::GetEmptyStructType (if someone can think of a better name, I'm open to suggestions)
- Refactored ValueObject::Dereference
- Reverted the NFC changes in ValueObject::CreateChildAtIndex
- Added test for C++ incomplete type with data-formatter (WIP)
Thu, May 7
Wed, May 6
May 4 2020
Landed in 015117411e11
As agreed on IRC with @labath, the changes done to PlatformPOSIX::ResolveExecutable will be removed from this patch and submitted separately.
Add error "consumption" following @labath comment.
Apr 30 2020
Removed redundant test.
Refactored PlatformPOSIX following Jonas and Pavel's comments.
Apr 28 2020
Removed the introduced FileSystem::ReadableByCurrentUser to rely only FileSystem::Open as Pavel suggested.
Updated the tests to reflect the changes introduced.
Apr 27 2020
Apr 24 2020
After playing with llvm::sys::swapByteOrder and the DataExtractor getters (GetU8, GetU16, GetU32 ....), it looks like neither of these supports bitfields.
Apr 23 2020
Address Shafik's comment.
Apr 21 2020
Address Pavel's comments:
- Fix eventual UB by using the struct type in sizeof instead of dereferencing the pointer.
- Remove empty destructors.
- Fix dangling reference.
Apr 20 2020
Address Davide's & Shafik's comments.
Address Pavel's comments.
Apr 17 2020
Address Davide's comments.
Apr 15 2020
It looks like there's no more regression. LGTM, thanks!
Apr 14 2020
Apr 9 2020
Mar 31 2020
Addressed Pavel's request.
Mar 30 2020
Mar 25 2020
Mar 20 2020
Mar 19 2020
Note that this diff is more a quick draft than a “finished” patch, I’m not expecting to submit this until the DW_OP_bit_piece support is done.
Mar 18 2020
Mar 17 2020
Updated frame recognizer add help description.
Added error when passing multiple symbols with --regex flag.
Mar 16 2020
@labath Do you object if I land this patch to revert our CIs to green and work on matching the symbol by address instead of name on a separate one ?
Addressed Pavel's comment.
I'll investigate matching the symbol by address instead of name, but I still think having the ability to register a recognizer with multiple symbols can be useful.
Mar 15 2020
Refactored test to use lldbutil.run_to_name_breakpoint.
Add missing test annotation.
Addressed Fred's comments.
Added testing for multi-symbol frame recognizers.
Mar 14 2020
Feb 24 2020
Addressed Pavel's request in D75049
Feb 21 2020
Removed old revision artifacts
Renamed test_on_launch to test_before_launch
Addressed Pavel's comments.
Add "negative" tests.
Feb 20 2020
Moved invocation to process status --verbose.
Removed macOS' CrashReporterClient header.