Page MenuHomePhabricator

mib (Med Ismail Bennani)
Compiler Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2019, 8:24 PM (97 w, 4 d)

Recent Activity

Oct 27 2020

mib committed rGa3aea0193d8c: [llvm/DebugInfo] Simplify DW_OP_implicit_value condition (NFC) (authored by mib).
[llvm/DebugInfo] Simplify DW_OP_implicit_value condition (NFC)
Oct 27 2020, 3:25 AM

Oct 23 2020

mib committed rG64c4dac60e3a: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB (authored by mib).
[llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB
Oct 23 2020, 9:46 PM
mib closed D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB.
Oct 23 2020, 9:46 PM · debug-info, Restricted Project
mib updated the diff for D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB.

Add negative test for -debugger-tune=sce.

Oct 23 2020, 9:44 PM · debug-info, Restricted Project
mib added a comment to D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB.

It seems that the HWASAN pre-check test is also failing in D89844 (https://buildkite.com/llvm-project/premerge-checks/builds/14519) ... I also tested on Linux and the test passes so I guess this is an issue with the bot.

Oct 23 2020, 9:11 PM · debug-info, Restricted Project
mib updated the diff for D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB.

Fix pre-check test failures

Oct 23 2020, 5:12 PM · debug-info, Restricted Project
mib updated the diff for D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB.
Oct 23 2020, 4:07 PM · debug-info, Restricted Project

Oct 22 2020

mib requested review of D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB.
Oct 22 2020, 7:26 PM · debug-info, Restricted Project
mib committed rGefe62b637d51: [lldb/DWARF] Add support for DW_OP_implicit_value (authored by mib).
[lldb/DWARF] Add support for DW_OP_implicit_value
Oct 22 2020, 9:03 AM
mib closed D89842: [lldb/DWARF] Add support for DW_OP_implicit_value.
Oct 22 2020, 9:03 AM · debug-info, Restricted Project
mib updated the diff for D89842: [lldb/DWARF] Add support for DW_OP_implicit_value.

Change shell test for unit test.

Oct 22 2020, 6:05 AM · debug-info, Restricted Project

Oct 20 2020

mib updated the diff for D89842: [lldb/DWARF] Add support for DW_OP_implicit_value.

Add test.

Oct 20 2020, 7:24 PM · debug-info, Restricted Project
mib updated the diff for D89842: [lldb/DWARF] Add support for DW_OP_implicit_value.
Oct 20 2020, 7:22 PM · debug-info, Restricted Project
mib requested review of D89842: [lldb/DWARF] Add support for DW_OP_implicit_value.
Oct 20 2020, 7:19 PM · debug-info, Restricted Project

Oct 19 2020

mib added a comment to D89698: [lldb] Fix TestTargetAPI.py on Apple simulators.

What if we tested each substring individually with self.assertIn to avoid checking the order of the substrings as it seems to change depending on the target ?

Oct 19 2020, 7:09 AM · Restricted Project
mib accepted D89695: [lldb] Skip TestChangeProcessGroup on watchOS/tvOS.

LGTM!

Oct 19 2020, 7:01 AM · Restricted Project

Oct 16 2020

mib accepted D88483: Add possibility to get module from SBType.

LGTM provided that you address my last comments :)

Oct 16 2020, 6:46 AM · Restricted Project

Oct 15 2020

mib requested changes to D88483: Add possibility to get module from SBType.

Could you please follow PEP8 style guide regarding variable names :

Oct 15 2020, 6:26 PM · Restricted Project

Oct 6 2020

mib added inline comments to D88889: [lldb] Allow limiting the number of error diagnostics when parsing an expression.
Oct 6 2020, 5:51 AM · Restricted Project
mib accepted D88889: [lldb] Allow limiting the number of error diagnostics when parsing an expression.

LGTM! Have you considered also adding an option to the expression command object ? May be some people would like to change the error limit for a specific expression...

Oct 6 2020, 5:50 AM · Restricted Project

Sep 29 2020

mib added a comment to D88483: Add possibility to get module from SBType.

Spotted some little things here and there ... This patch lacks a test and would need some reformatting (git clang-format HEAD~) but other than that, looks ok to me.

Sep 29 2020, 7:21 AM · Restricted Project

Sep 28 2020

mib added inline comments to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.
Sep 28 2020, 5:27 AM · Restricted Project

Sep 11 2020

mib committed rG4da8fa45a096: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI (authored by mib).
[lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI
Sep 11 2020, 11:10 AM
mib closed D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.
Sep 11 2020, 11:10 AM · Restricted Project
mib updated the diff for D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.

Add invalid breakpoint test case.

Sep 11 2020, 7:10 AM · Restricted Project
mib added inline comments to D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.
Sep 11 2020, 7:09 AM · Restricted Project

Sep 10 2020

mib updated the summary of D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.
Sep 10 2020, 9:47 PM · Restricted Project
mib requested review of D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.
Sep 10 2020, 9:44 PM · Restricted Project

Sep 8 2020

mib added a reviewer for D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure: jingham.
Sep 8 2020, 7:32 AM · Restricted Project
mib added inline comments to D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure.
Sep 8 2020, 6:54 AM · Restricted Project
mib added a comment to D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure.

Some nitpicking but this looks fine to me.

Sep 8 2020, 6:53 AM · Restricted Project

Sep 3 2020

mib committed rGbf8f6e89c8d6: [lldb/Interpreter] Fix language detection for the REPL InitFile (authored by mib).
[lldb/Interpreter] Fix language detection for the REPL InitFile
Sep 3 2020, 2:00 AM
mib closed D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile.
Sep 3 2020, 2:00 AM · Restricted Project
mib requested review of D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile.
Sep 3 2020, 1:31 AM · Restricted Project

Sep 2 2020

mib added a comment to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.

Should be fixed with 0e86f390457a2b4dd1f2d1770db912963a36f240. @max-kudr I'll keep an eye on the Windows bot to make sure it worked :)

Sep 2 2020, 12:43 PM · Restricted Project
mib committed rG0e86f390457a: [lldb/test] Fix TestPlatform*.py Windows failures (NFC) (authored by mib).
[lldb/test] Fix TestPlatform*.py Windows failures (NFC)
Sep 2 2020, 12:42 PM
mib added inline comments to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Sep 2 2020, 12:26 PM · Restricted Project
mib added a comment to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.

@max-kudr Looking, thanks!

Sep 2 2020, 11:12 AM · Restricted Project
mib committed rGaddb5148f58d: [lldb/Target] Add custom interpreter option to `platform shell` (authored by mib).
[lldb/Target] Add custom interpreter option to `platform shell`
Sep 2 2020, 7:38 AM
mib closed D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Sep 2 2020, 7:37 AM · Restricted Project

Sep 1 2020

mib committed rG0224738c1abd: [lldb/interpreter] Improve REPL init file compatibility (authored by mib).
[lldb/interpreter] Improve REPL init file compatibility
Sep 1 2020, 4:22 PM
mib closed D86987: [lldb/interpreter] Improve REPL init file compatibility.
Sep 1 2020, 4:22 PM · Restricted Project
mib updated the diff for D86987: [lldb/interpreter] Improve REPL init file compatibility.
Sep 1 2020, 4:15 PM · Restricted Project
mib requested review of D86987: [lldb/interpreter] Improve REPL init file compatibility.
Sep 1 2020, 3:59 PM · Restricted Project

Aug 28 2020

mib updated the diff for D86667: [lldb/Target] Add custom interpreter option to `platform shell`.

Replaced all the interpreter occurrences with shell in the code.

Aug 28 2020, 9:29 AM · Restricted Project
mib updated the diff for D86667: [lldb/Target] Add custom interpreter option to `platform shell`.

Removed bool run_in_shell argument from Platform classes.

Aug 28 2020, 6:58 AM · Restricted Project
mib updated the diff for D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
  • Changed CommandObject option from -i|--interpreter to -s|--shell.
  • Updated test program build settings.
Aug 28 2020, 6:42 AM · Restricted Project
mib added inline comments to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Aug 28 2020, 6:38 AM · Restricted Project

Aug 27 2020

mib updated the diff for D86667: [lldb/Target] Add custom interpreter option to `platform shell`.

Address most comments:

  • Passed down the shell interpreter path down to Host::RunShellCommand to be "assembled" with the rest of the command.
  • Wrote a custom test program to simplify testing on multiple platforms.
  • Updated code by using llvm::StringRef instead of CString when possible.
Aug 27 2020, 10:40 PM · Restricted Project
mib added a comment to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.

Do people really call command-line shells interpreters? I would have thought --shell would be a better name. lldb already has its own command interpreter which is orthogonal to the shells, so it seems confusing to use the same term for both.

Aug 27 2020, 9:52 PM · Restricted Project

Aug 26 2020

mib updated the diff for D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Aug 26 2020, 6:15 PM · Restricted Project
mib requested review of D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Aug 26 2020, 6:13 PM · Restricted Project

Aug 19 2020

mib committed rG868b45b5b31d: [lldb/interpreter] Add REPL-specific init file (authored by mib).
[lldb/interpreter] Add REPL-specific init file
Aug 19 2020, 3:37 PM
mib closed D86242: [lldb/interpreter] Add REPL-specific init file.
Aug 19 2020, 3:37 PM · Restricted Project
mib updated the diff for D86242: [lldb/interpreter] Add REPL-specific init file.
Aug 19 2020, 3:25 PM · Restricted Project
mib updated the diff for D86242: [lldb/interpreter] Add REPL-specific init file.

Updated man page to reflect current implementation.

Aug 19 2020, 3:23 PM · Restricted Project
mib added inline comments to D86242: [lldb/interpreter] Add REPL-specific init file.
Aug 19 2020, 2:51 PM · Restricted Project
mib updated the diff for D86242: [lldb/interpreter] Add REPL-specific init file.

Addressed @JDevlieghere comments.

Aug 19 2020, 2:01 PM · Restricted Project
mib added inline comments to D86242: [lldb/interpreter] Add REPL-specific init file.
Aug 19 2020, 1:37 PM · Restricted Project
mib updated the diff for D86242: [lldb/interpreter] Add REPL-specific init file.

Fixed typo.

Aug 19 2020, 1:15 PM · Restricted Project
mib requested review of D86242: [lldb/interpreter] Add REPL-specific init file.
Aug 19 2020, 1:13 PM · Restricted Project

Aug 4 2020

mib accepted D85217: [lldb] Upstream macOS TCC code .

LGTM!

Aug 4 2020, 9:15 AM · Restricted Project

Jul 24 2020

mib added a comment to D84498: [lldb] Add a --dummy option to the frame recognizer commands.

Just a little nit, but as we already discussed offline, I have some doubts about adding a --dummy option.
It sounds unnecessary to me, so I'd like to hear @jingham take on this.

Jul 24 2020, 9:06 AM

Jul 23 2020

mib accepted D84404: [lldb] Make deleting frame recognizers actually work.

Looks good to me.

Jul 23 2020, 7:17 AM · Restricted Project
mib committed rGe605994bb306: [lldb/test] Fix TestHistoryRecall failure (NFC) (authored by mib).
[lldb/test] Fix TestHistoryRecall failure (NFC)
Jul 23 2020, 4:27 AM
mib committed rG85fbb08fa2ac: [lldb/interpreter] Move the history subcommand to session (NFCI) (authored by mib).
[lldb/interpreter] Move the history subcommand to session (NFCI)
Jul 23 2020, 4:06 AM
mib closed D84307: [lldb/interpreter] Move the history subcommand to session (NFCI).
Jul 23 2020, 4:05 AM · Restricted Project

Jul 22 2020

mib updated the summary of D84307: [lldb/interpreter] Move the history subcommand to session (NFCI).
Jul 22 2020, 12:28 PM · Restricted Project
mib accepted D84336: [lldb] Cleanup CommandObject registration (NFC).

I find the macro cleaner than my changes in D84305. LGTM!

Jul 22 2020, 9:46 AM · Restricted Project
mib abandoned D84305: [lldb/interpreter] Update CommandObject instanciation to use make_shared (NFC).

Abandoning this revision in favour of D84336

Jul 22 2020, 9:36 AM · Restricted Project
mib updated the summary of D84307: [lldb/interpreter] Move the history subcommand to session (NFCI).
Jul 22 2020, 4:34 AM · Restricted Project
mib created D84307: [lldb/interpreter] Move the history subcommand to session (NFCI).
Jul 22 2020, 4:23 AM · Restricted Project
mib created D84305: [lldb/interpreter] Update CommandObject instanciation to use make_shared (NFC).
Jul 22 2020, 4:02 AM · Restricted Project
mib committed rG33981c672405: [lldb/interpreter] Fix formatting in CommandInterpreter.cpp (NFC) (authored by mib).
[lldb/interpreter] Fix formatting in CommandInterpreter.cpp (NFC)
Jul 22 2020, 2:48 AM
mib committed rG5bb742b10daf: [lldb/interpreter] Add ability to save lldb session to a file (authored by mib).
[lldb/interpreter] Add ability to save lldb session to a file
Jul 22 2020, 2:43 AM
mib closed D82155: [lldb/interpreter] Add ability to save lldb session to a file.
Jul 22 2020, 2:43 AM · Restricted Project
mib updated the diff for D82155: [lldb/interpreter] Add ability to save lldb session to a file.

Address @labath comments

Jul 22 2020, 2:41 AM · Restricted Project

Jul 21 2020

mib updated the diff for D82155: [lldb/interpreter] Add ability to save lldb session to a file.

Reformat patch.

Jul 21 2020, 3:02 PM · Restricted Project
mib updated the diff for D82155: [lldb/interpreter] Add ability to save lldb session to a file.

Address @JDevlieghere comments.

Jul 21 2020, 2:59 PM · Restricted Project
mib accepted D84151: [lldb] Unify type name matching in FormattersContainer.

Thanks for the changes. LGTM!

Jul 21 2020, 9:02 AM · Restricted Project
mib updated the diff for D82155: [lldb/interpreter] Add ability to save lldb session to a file.

Reformat.

Jul 21 2020, 7:29 AM · Restricted Project
mib updated the diff for D82155: [lldb/interpreter] Add ability to save lldb session to a file.
  • Address previous comments
  • Add test
Jul 21 2020, 6:42 AM · Restricted Project

Jul 20 2020

mib accepted D84154: [lldb] Remove FormattersContainer's name member.

LGTM!

Jul 20 2020, 6:34 AM · Restricted Project
mib added a comment to D84151: [lldb] Unify type name matching in FormattersContainer.

The patch looks fine to me. May be it could have a unittest to check the TypeMatcher in an isolated manner ?

Jul 20 2020, 6:03 AM · Restricted Project

Jul 16 2020

mib accepted D83757: [lldb] Store StackFrameRecognizers in the target instead of a global list.
Jul 16 2020, 3:57 AM · Restricted Project

Jul 15 2020

mib accepted D83757: [lldb] Store StackFrameRecognizers in the target instead of a global list.

Looks good to me, beside a little nit.

Jul 15 2020, 5:43 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rGac83e27cddd4: Merge pull request #1427 from medismailben/apple/stable/20200108 (authored by mib).
Merge pull request #1427 from medismailben/apple/stable/20200108
Jul 14 2020, 4:56 PM
mib committed rG4547c8830be4: [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC) (authored by mib).
[lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC)
Jul 14 2020, 4:56 PM
GitHub <noreply@github.com> committed rG8c5c6611ac2e: Merge pull request #1402 from medismailben/apple/stable/20200108 (authored by mib).
Merge pull request #1402 from medismailben/apple/stable/20200108
Jul 14 2020, 4:56 PM
mib committed rG291f3896fb4e: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI) (authored by mib).
[lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)
Jul 14 2020, 4:56 PM
mib committed rGc875c8636584: [lldb/Commands] Add ability to run shell command on the host. (authored by mib).
[lldb/Commands] Add ability to run shell command on the host.
Jul 14 2020, 4:51 PM
GitHub <noreply@github.com> committed rG9bf90791d5c0: Merge pull request #1172 from medismailben/apple/stable/20200108 (authored by mib).
Merge pull request #1172 from medismailben/apple/stable/20200108
Jul 14 2020, 4:49 PM
mib committed rG8277dad5895f: [lldb/test] Fix wrong target command failure message on Windows (authored by mib).
[lldb/test] Fix wrong target command failure message on Windows
Jul 14 2020, 4:49 PM
mib committed rG74f2a9a37278: [lldb/Host] Improve error messages on unowned read files (authored by mib).
[lldb/Host] Improve error messages on unowned read files
Jul 14 2020, 4:49 PM
GitHub <noreply@github.com> committed rGa4f539cc373c: Merge pull request #1126 from medismailben/apple/stable/20200108 (authored by mib).
Merge pull request #1126 from medismailben/apple/stable/20200108
Jul 14 2020, 4:47 PM
mib committed rG0194523e3bd7: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets. (authored by mib).
[lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Jul 14 2020, 4:47 PM
mib committed rGb3c8ec228ef0: [lldb/DWARF] Fix evaluator crash when accessing empty stack. (authored by mib).
[lldb/DWARF] Fix evaluator crash when accessing empty stack.
Jul 14 2020, 4:38 PM
GitHub <noreply@github.com> committed rG236d023a2be6: Merge pull request #1005 from medismailben/apple/stable/20200108 (authored by mib).
Merge pull request #1005 from medismailben/apple/stable/20200108
Jul 14 2020, 4:38 PM
GitHub <noreply@github.com> committed rG9fdd05159da0: Merge pull request #928 from medismailben/apple/stable/20200108 (authored by mib).
Merge pull request #928 from medismailben/apple/stable/20200108
Jul 14 2020, 4:34 PM
mib committed rG526554f71a56: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer (authored by mib).
[lldb/Target] Support more than 2 symbols in StackFrameRecognizer
Jul 14 2020, 4:34 PM