- User Since
- Jan 19 2019, 8:24 PM (125 w, 6 d)
Tue, Jun 8
Took a look at the SBAPI changes and left few comments but overall, that part looked good to me. It would be nice if you could delete the depreciated method/class.
Fri, Jun 4
Tue, Jun 1
Left few comments regarding the phrasing but LGTM! Thanks for doing it!
Thu, May 27
At first sight, this looks like a fair addition, but this feature is also used to report Swift Runtime Failure in the debugger (and Xcode) ...
May 17 2021
May 4 2021
Apr 30 2021
Apr 29 2021
As discussed with @JDevlieghere offline, at the moment SearchFilter and Searcher (from which many class inherit) are not designed for error handling so I removed the SourceLocationSpec::Create factory method and added an IsValid method to check the state optionally.
Wrap SourceLocationSpec column argument into an llvm::Optional
Group the FileSpec, the Line and Column number into a Declaration.
Remove factory function to use constructor and added an IsValid method (and boolean operator)
Apr 26 2021
Use llvm::Expected error when possible.
Apr 23 2021
Fix test failures.
Fix unit test failure.
Apr 22 2021
Update BreakpointResolver column default value and fix typo
Update LineEntry unit test.
- Move boolean attributes to the end of the class.
- Fix deleted default constructor issue.
Apr 21 2021
Apr 14 2021
Use Doxygen group comment for ScriptedProcess members.
Apr 13 2021
Address @JDevlieghere feedbacks
Mar 31 2021
It's unfortunate the first 2 options are not feasible at the moment. Your implementation looks like a good compromise. Thanks for the thorough explanation.
Mar 25 2021
Mar 24 2021
Addressing @stella.stamenova feedback.
With the help of @teemperor, I was able to test that my latest changes work on Linux with and without enabling python for lldb. I'll re-land the patch and monitor the bots to make sure there is no other issues.
Enable ScriptedProcess process plugin only when LLDB_ENABLE_PYTHON is true.
Landed in 3e0ad115439622b9c3e6ca9fd64c7fb07a679f1a
Mar 23 2021
Mar 5 2021
Mar 4 2021
Replace std::bitset by lldb_private::Flags as suggested by @JDevlieghere
Mar 3 2021
Landed in 103ad3f90
Fix header guard length.
Mar 2 2021