Page MenuHomePhabricator

mib (Med Ismail Bennani)
Compiler Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2019, 8:24 PM (71 w, 3 d)

Recent Activity

Fri, May 15

mib committed rG4e9e0488ab67: [lldb/Commands] Add ability to run shell command on the host. (authored by mib).
[lldb/Commands] Add ability to run shell command on the host.
Fri, May 15, 1:37 PM
mib committed rG0eba9de71e2a: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types (authored by mib).
[lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types
Fri, May 15, 1:37 PM
mib closed D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.
Fri, May 15, 1:37 PM · Restricted Project
mib closed D79659: [lldb/Commands] Add ability to run shell command on the host..
Fri, May 15, 1:37 PM · Restricted Project
mib updated the diff for D79659: [lldb/Commands] Add ability to run shell command on the host..

Merged the shell and platform shell test as @JDevlieghere suggested it.

Fri, May 15, 10:18 AM · Restricted Project

Thu, May 14

mib updated the diff for D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.

Instead of creating a new empty struct type, this new implementation will use the opaque pointer's pointee type to create the new ValueObjectChild.
This makes the previously introduced helper function in TypeSystem and TypeSystemClang useless, so I got rid of them.

Thu, May 14, 11:23 AM · Restricted Project

Mon, May 11

mib added inline comments to D79659: [lldb/Commands] Add ability to run shell command on the host..
Mon, May 11, 9:07 AM · Restricted Project

Sat, May 9

mib updated the diff for D79659: [lldb/Commands] Add ability to run shell command on the host..

It looks like command options are not supported on aliases that already have options:

Sat, May 9, 2:37 AM · Restricted Project
mib updated the diff for D79659: [lldb/Commands] Add ability to run shell command on the host..

With the first implementation, I thought it'd be a good idea to have separate Command Objects for platform shell and shell because I was imagining the latter could be more "powerful": shell could have an interactive mode like the script command, which might not be as relevant for platform shell when debugging a remote target.

Sat, May 9, 2:05 AM · Restricted Project
mib updated the summary of D79659: [lldb/Commands] Add ability to run shell command on the host..
Sat, May 9, 2:05 AM · Restricted Project

Fri, May 8

mib updated the summary of D79659: [lldb/Commands] Add ability to run shell command on the host..
Fri, May 8, 7:21 PM · Restricted Project
mib created D79659: [lldb/Commands] Add ability to run shell command on the host..
Fri, May 8, 6:49 PM · Restricted Project
mib updated the diff for D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.
  • Added a virtual method to create an empty struct type TypeSystem::GetEmptyStructType (if someone can think of a better name, I'm open to suggestions)
  • Refactored ValueObject::Dereference
  • Reverted the NFC changes in ValueObject::CreateChildAtIndex
  • Added test for C++ incomplete type with data-formatter (WIP)
Fri, May 8, 12:29 AM · Restricted Project

Thu, May 7

mib added inline comments to D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.
Thu, May 7, 2:08 PM · Restricted Project
mib added inline comments to D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.
Thu, May 7, 9:04 AM · Restricted Project

Wed, May 6

mib created D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.
Wed, May 6, 10:42 PM · Restricted Project
mib committed rGf058d397ff8e: [lldb/test] Reformat Objective-C data-formatter source file (NFC) (authored by mib).
[lldb/test] Reformat Objective-C data-formatter source file (NFC)
Wed, May 6, 9:02 PM
mib accepted D79519: [lldb/Test] Run dotest.py with the Python LLDB was built with.

LGTM!

Wed, May 6, 2:44 PM · Restricted Project

May 4 2020

mib committed rG6b8d6f44592c: [lldb/test] Fix wrong target command failure message on Windows (authored by mib).
[lldb/test] Fix wrong target command failure message on Windows
May 4 2020, 10:44 AM
mib closed D78712: [lldb/Host] Improve error messages on unowned read files.

Landed in 015117411e11

May 4 2020, 9:37 AM · Restricted Project
mib committed rG015117411e11: [lldb/Host] Improve error messages on unowned read files (authored by mib).
[lldb/Host] Improve error messages on unowned read files
May 4 2020, 9:06 AM
mib updated the diff for D78712: [lldb/Host] Improve error messages on unowned read files.

As agreed on IRC with @labath, the changes done to PlatformPOSIX::ResolveExecutable will be removed from this patch and submitted separately.

May 4 2020, 7:59 AM · Restricted Project
mib updated the diff for D78712: [lldb/Host] Improve error messages on unowned read files.

Add error "consumption" following @labath comment.

May 4 2020, 3:42 AM · Restricted Project

Apr 30 2020

mib updated the diff for D78712: [lldb/Host] Improve error messages on unowned read files.

Removed redundant test.
Refactored PlatformPOSIX following Jonas and Pavel's comments.

Apr 30 2020, 4:12 PM · Restricted Project

Apr 28 2020

mib updated the diff for D78712: [lldb/Host] Improve error messages on unowned read files.

Removed the introduced FileSystem::ReadableByCurrentUser to rely only FileSystem::Open as Pavel suggested.
Updated the tests to reflect the changes introduced.

Apr 28 2020, 2:03 PM · Restricted Project

Apr 27 2020

mib committed rG8f5beb4c4b11: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets. (authored by mib).
[lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 27 2020, 1:30 PM
mib closed D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 27 2020, 1:30 PM · Restricted Project

Apr 24 2020

mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

After playing with llvm::sys::swapByteOrder and the DataExtractor getters (GetU8, GetU16, GetU32 ....), it looks like neither of these supports bitfields.

Apr 24 2020, 4:16 PM · Restricted Project

Apr 23 2020

mib updated the diff for D78712: [lldb/Host] Improve error messages on unowned read files.
Apr 23 2020, 9:43 AM · Restricted Project
mib updated the diff for D78712: [lldb/Host] Improve error messages on unowned read files.

Address Shafik's comment.

Apr 23 2020, 9:43 AM · Restricted Project
mib added inline comments to D78712: [lldb/Host] Improve error messages on unowned read files.
Apr 23 2020, 9:43 AM · Restricted Project
mib updated the summary of D78712: [lldb/Host] Improve error messages on unowned read files.
Apr 23 2020, 7:32 AM · Restricted Project
mib added inline comments to D78712: [lldb/Host] Improve error messages on unowned read files.
Apr 23 2020, 7:32 AM · Restricted Project
mib created D78712: [lldb/Host] Improve error messages on unowned read files.
Apr 23 2020, 7:31 AM · Restricted Project

Apr 21 2020

mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Address Pavel's comments:

  • Fix eventual UB by using the struct type in sizeof instead of dereferencing the pointer.
  • Remove empty destructors.
  • Fix dangling reference.
Apr 21 2020, 12:59 PM · Restricted Project
mib added inline comments to D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 21 2020, 12:59 PM · Restricted Project

Apr 20 2020

mib added a comment to D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

This looks fine to me but please give Pavel another chance to look before committing.

Apr 20 2020, 3:13 PM · Restricted Project
mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Fix typo.

Apr 20 2020, 1:33 PM · Restricted Project
mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Address Davide's & Shafik's comments.

Apr 20 2020, 1:33 PM · Restricted Project
mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Address Pavel's comments.

Apr 20 2020, 5:53 AM · Restricted Project
mib added inline comments to D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 20 2020, 5:20 AM · Restricted Project

Apr 17 2020

mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Address Davide's comments.

Apr 17 2020, 3:10 PM · Restricted Project
mib added inline comments to D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 17 2020, 3:10 PM · Restricted Project
mib updated the summary of D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 17 2020, 12:58 PM · Restricted Project
mib updated the diff for D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Reformat patch.

Apr 17 2020, 12:58 PM · Restricted Project
mib created D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.
Apr 17 2020, 12:58 PM · Restricted Project

Apr 15 2020

mib accepted D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

It looks like there's no more regression. LGTM, thanks!

Apr 15 2020, 2:19 PM · Restricted Project
mib added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 2:18 PM · Restricted Project

Apr 14 2020

mib created D78094: [lldb/test] Fix TestLoadUnload.
Apr 14 2020, 3:40 AM · Restricted Project

Apr 9 2020

mib committed rGa4da4e329283: [lldb/Reproducers] Fix typo introduced when disabling register failing tests (authored by mib).
[lldb/Reproducers] Fix typo introduced when disabling register failing tests
Apr 9 2020, 11:58 PM
mib committed rG6612b826d05c: [lldb] Reformat 'Fix breakage introduced by llvm::LoadInst api change' (NFC) (authored by mib).
[lldb] Reformat 'Fix breakage introduced by llvm::LoadInst api change' (NFC)
Apr 9 2020, 3:49 PM
mib committed rG0d525ce068c9: [lldb] Fix breakeage introduced by llvm::LoadInst api change (authored by mib).
[lldb] Fix breakeage introduced by llvm::LoadInst api change
Apr 9 2020, 3:16 PM
mib committed rG98b47f447c93: [lldb/test] Fix typo to disable reproducer's test phase (authored by mib).
[lldb/test] Fix typo to disable reproducer's test phase
Apr 9 2020, 1:16 PM
mib committed rG68c04a4f73ac: [lldb] Disable failing register tests for reproducers (authored by mib).
[lldb] Disable failing register tests for reproducers
Apr 9 2020, 1:15 PM

Mar 31 2020

mib committed rGf3a7d790df33: [lldb/DWARF] Fix evaluator crash when accessing empty stack. (authored by mib).
[lldb/DWARF] Fix evaluator crash when accessing empty stack.
Mar 31 2020, 8:53 AM
mib closed D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.
Mar 31 2020, 8:53 AM · debug-info, Restricted Project
mib committed rGe4a778052e98: Revert "[lldb/DWARF] Fix evaluator crash when accessing empty stack." (authored by mib).
Revert "[lldb/DWARF] Fix evaluator crash when accessing empty stack."
Mar 31 2020, 8:53 AM
mib added a reverting change for rGe26eece1e2e7: [lldb/DWARF] Fix evaluator crash when accessing empty stack.: rGe4a778052e98: Revert "[lldb/DWARF] Fix evaluator crash when accessing empty stack.".
Mar 31 2020, 8:53 AM
mib committed rGe26eece1e2e7: [lldb/DWARF] Fix evaluator crash when accessing empty stack. (authored by mib).
[lldb/DWARF] Fix evaluator crash when accessing empty stack.
Mar 31 2020, 8:52 AM
mib added a comment to D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.

This is obviously good! Do you think that a similar error handling bug might exist in other cases that depend top-of-stack?

Mar 31 2020, 8:49 AM · debug-info, Restricted Project
mib updated the diff for D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.

Addressed Pavel's request.

Mar 31 2020, 8:49 AM · debug-info, Restricted Project

Mar 30 2020

mib created D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.
Mar 30 2020, 6:02 PM · debug-info, Restricted Project

Mar 25 2020

mib planned changes to D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).
Mar 25 2020, 5:21 PM · Restricted Project

Mar 20 2020

mib committed rG4e5d04da4990: [lldb/Dwarf] Improve DW_OP_bit_piece support (WIP) (authored by mib).
[lldb/Dwarf] Improve DW_OP_bit_piece support (WIP)
Mar 20 2020, 1:35 PM
mib committed rG903f2a2dbb30: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (authored by mib).
[lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector
Mar 20 2020, 1:35 PM
mib committed rGaf8f6c7ae9fa: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer (authored by mib).
[lldb/Target] Support more than 2 symbols in StackFrameRecognizer
Mar 20 2020, 1:35 PM

Mar 19 2020

mib retitled D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP) from [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector to [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).
Mar 19 2020, 3:54 PM · Restricted Project
mib added inline comments to D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).
Mar 19 2020, 3:22 PM · Restricted Project
mib added a comment to D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).

Note that this diff is more a quick draft than a “finished” patch, I’m not expecting to submit this until the DW_OP_bit_piece support is done.

Mar 19 2020, 3:22 PM · Restricted Project
mib added inline comments to D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).
Mar 19 2020, 3:22 PM · Restricted Project
mib created D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).
Mar 19 2020, 1:09 PM · Restricted Project
mib added inline comments to D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py.
Mar 19 2020, 3:11 AM · Restricted Project

Mar 18 2020

mib committed rGdb31e2e1e6ca: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer (authored by mib).
[lldb/Target] Support more than 2 symbols in StackFrameRecognizer
Mar 18 2020, 6:30 AM
mib closed D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 18 2020, 6:30 AM · Restricted Project

Mar 17 2020

mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 17 2020, 12:57 PM · Restricted Project
mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

Updated frame recognizer add help description.

Mar 17 2020, 12:56 PM · Restricted Project
mib added inline comments to D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 17 2020, 12:23 PM · Restricted Project
mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

Added error when passing multiple symbols with --regex flag.

Mar 17 2020, 11:49 AM · Restricted Project
mib added inline comments to D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 17 2020, 11:16 AM · Restricted Project
mib added inline comments to D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 17 2020, 4:27 AM · Restricted Project

Mar 16 2020

mib added a comment to D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

@labath Do you object if I land this patch to revert our CIs to green and work on matching the symbol by address instead of name on a separate one ?

Mar 16 2020, 10:20 AM · Restricted Project
mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

Addressed Pavel's comment.

Mar 16 2020, 9:14 AM · Restricted Project
mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 16 2020, 7:35 AM · Restricted Project
mib added a comment to D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

I'll investigate matching the symbol by address instead of name, but I still think having the ability to register a recognizer with multiple symbols can be useful.

Being able to match multiple symbols sounds useful in its own right, but the motivating case is a bit shady. raise, __GI_raise and gsignal are all aliases to one another (they have the same address). The reason you're sometimes getting gsignal here is not because some glibcs really call this function from their assert macro. It's because we happen to pick that symbol (maybe because it comes first in the symtab, depending on how the library was linked) when doing address resolution.

I'm wondering if that doesn't signal a flaw in the recognizer infrastructure. If we changed the matching logic so that it resolves the name it is supposed to search for, and then does a match by address, then only one name would be sufficient here.

Mar 16 2020, 7:35 AM · Restricted Project

Mar 15 2020

mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

Refactored test to use lldbutil.run_to_name_breakpoint.

Mar 15 2020, 4:05 PM · Restricted Project
mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

Add missing test annotation.

Mar 15 2020, 4:48 AM · Restricted Project
mib updated the diff for D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.

Addressed Fred's comments.
Added testing for multi-symbol frame recognizers.

Mar 15 2020, 12:30 AM · Restricted Project
mib added inline comments to D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 15 2020, 12:30 AM · Restricted Project

Mar 14 2020

mib created D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer.
Mar 14 2020, 6:48 PM · Restricted Project

Feb 24 2020

mib committed rGeefda18227a2: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess (authored by mib).
[lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess
Feb 24 2020, 2:39 PM
mib closed D75049: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess.
Feb 24 2020, 2:38 PM · Restricted Project
mib added a comment to D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes.

Addressed Pavel's request in D75049

Feb 24 2020, 7:17 AM · Restricted Project
mib created D75049: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess.
Feb 24 2020, 7:17 AM · Restricted Project

Feb 21 2020

mib committed rGd7c403e64043: [lldb/Plugins] Add ability to fetch crash information on crashed processes (authored by mib).
[lldb/Plugins] Add ability to fetch crash information on crashed processes
Feb 21 2020, 1:53 PM
mib committed rG1f04d1b7069b: [lldb/test] Move `platform process list` tests to its own directory (NFC) (authored by mib).
[lldb/test] Move `platform process list` tests to its own directory (NFC)
Feb 21 2020, 1:53 PM
mib closed D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes.
Feb 21 2020, 1:53 PM · Restricted Project
mib closed D74836: [lldb/test] Move `platform process list` tests to its own directory (NFC).
Feb 21 2020, 1:53 PM · Restricted Project
mib updated the diff for D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes.

Removed old revision artifacts
Renamed test_on_launch to test_before_launch

Feb 21 2020, 12:08 PM · Restricted Project
mib updated the diff for D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes.

Addressed Pavel's comments.
Add "negative" tests.

Feb 21 2020, 11:48 AM · Restricted Project

Feb 20 2020

mib updated the diff for D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes.

Moved invocation to process status --verbose.
Removed macOS' CrashReporterClient header.

Feb 20 2020, 12:38 PM · Restricted Project