Page MenuHomePhabricator

[TLI] Add memset_pattern4, memset_pattern8 lib functions.
ClosedPublic

Authored by fhahn on Dec 1 2021, 8:30 AM.

Diff Detail

Event Timeline

fhahn created this revision.Dec 1 2021, 8:30 AM
fhahn requested review of this revision.Dec 1 2021, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2021, 8:30 AM
ab accepted this revision.Dec 1 2021, 10:22 AM

Makes sense, LGTM!

llvm/include/llvm/Analysis/TargetLibraryInfo.def
1051

nit: maybe keep it 4,8,16? (same in TargetLibraryInfoTest.cpp)

llvm/lib/Analysis/TargetLibraryInfo.cpp
192

+1 to the lint check ;)

This revision is now accepted and ready to land.Dec 1 2021, 10:22 AM
fhahn marked an inline comment as done.Dec 1 2021, 12:17 PM
fhahn added inline comments.
llvm/include/llvm/Analysis/TargetLibraryInfo.def
1051

Unfortunately there is a check that assert that the values here are ordered lexigraphical and it seems to expect memset_pattern16 before memset_pattern4 :(

fhahn updated this revision to Diff 391113.Dec 1 2021, 12:41 PM
fhahn marked an inline comment as done.

fix formatting and /llvm-tli-checker::ps4-tli-check.s test failure

This revision was landed with ongoing or failed builds.Dec 1 2021, 1:19 PM
This revision was automatically updated to reflect the committed changes.