Page MenuHomePhabricator

msebor (Martin Sebor)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2014, 9:15 AM (439 w, 12 h)

Recent Activity

Sep 30 2022

msebor added a comment to D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr.

Thanks for the heads up! My only general comment is that unless this change has no externally observable effect I'd suggest adding tests. (Otherwise, noting it has no such effect would be helpful.) When I'm not familiar with the code (and often even what I am) I usually look for tests to understand the impact of a change.

Sep 30 2022, 10:57 AM · Restricted Project, Restricted Project

Sep 28 2022

msebor committed rGa181de452df3: [clang] handle extended integer constant expressions in _Static_assert (PR… (authored by msebor).
[clang] handle extended integer constant expressions in _Static_assert (PR…
Sep 28 2022, 12:28 PM · Restricted Project, Restricted Project
msebor closed D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687).
Sep 28 2022, 12:28 PM · Restricted Project, Restricted Project
msebor added inline comments to D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687).
Sep 28 2022, 10:26 AM · Restricted Project, Restricted Project
msebor updated the diff for D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687).

Changes from previous version:

  • Replace loop with Expr::IgnoreImpCasts().
  • Use a multiline comment in a test to improve readability.
Sep 28 2022, 10:26 AM · Restricted Project, Restricted Project

Sep 27 2022

msebor added inline comments to D130922: [InstCombine] Add support for stpncpy folding.
Sep 27 2022, 1:45 PM · Restricted Project, Restricted Project
msebor committed rGe80e134c77bb: [InstCombine] Add support for stpncpy folding (authored by msebor).
[InstCombine] Add support for stpncpy folding
Sep 27 2022, 1:45 PM · Restricted Project, Restricted Project
msebor closed D130922: [InstCombine] Add support for stpncpy folding.
Sep 27 2022, 1:44 PM · Restricted Project, Restricted Project

Sep 23 2022

msebor added inline comments to D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.
Sep 23 2022, 1:07 PM · Restricted Project, Restricted Project
msebor updated the diff for D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.

Changes in revision 3 of the patch addressing review comments:

  • Add missing return statement.
  • Remove test for argument bit width >= 16.
  • Use isa instead of dyn_cast.
Sep 23 2022, 1:06 PM · Restricted Project, Restricted Project

Sep 21 2022

msebor added a comment to D130922: [InstCombine] Add support for stpncpy folding.

Ping: @efriedma do you (or anyone else) have any other questions or suggestions or is everyone okay with the last revision?

Sep 21 2022, 8:30 AM · Restricted Project, Restricted Project

Sep 20 2022

msebor updated the diff for D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687).

Update to the latest diff that didn't get picked up in the first submission.

Sep 20 2022, 3:57 PM · Restricted Project, Restricted Project
msebor added inline comments to D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr.
Sep 20 2022, 3:37 PM · Restricted Project, Restricted Project
msebor added inline comments to D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr.
Sep 20 2022, 2:20 PM · Restricted Project, Restricted Project
msebor requested review of D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687).
Sep 20 2022, 1:46 PM · Restricted Project, Restricted Project

Sep 14 2022

msebor added inline comments to D130922: [InstCombine] Add support for stpncpy folding.
Sep 14 2022, 10:35 AM · Restricted Project, Restricted Project
msebor updated the diff for D130922: [InstCombine] Add support for stpncpy folding.

Restore early return when GetStringLength returns zero.

Sep 14 2022, 10:35 AM · Restricted Project, Restricted Project

Sep 13 2022

msebor added inline comments to D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr.
Sep 13 2022, 9:39 AM · Restricted Project, Restricted Project

Sep 12 2022

msebor added inline comments to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.
Sep 12 2022, 8:34 AM · Restricted Project, Restricted Project

Aug 31 2022

msebor added a comment to D130666: [InstCombine] Add support for strlcpy folding.

This might break the following opensource lib https://git.kernel.org/pub/scm/network/iproute2/iproute2.git

In https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/configure#n445

The compilation for the following code no longer fails when setting -Wno-error-implicit-function-declaration

#include <string.h>
int main(int argc, char **argv) {
	char dst[10];
	strlcpy(dst, "test", sizeof(dst));
	return 0;
}

The behaviour difference between clang 14.0, clang trunk and gcc: https://godbolt.org/z/hKETMoEd6

Aug 31 2022, 10:36 AM · Restricted Project, Restricted Project
msebor added a comment to D132960: [InstCombine] Transform small unaligned memcmp calls used in zero equality tests.

The point here is that these loads are going to be expanded into 16 byte-sized loads by the backend, if the target has strict alignment. See https://llvm.godbolt.org/z/MdqoEEv1P for an example.

Aug 31 2022, 9:43 AM · Restricted Project, Restricted Project
msebor added a comment to D132960: [InstCombine] Transform small unaligned memcmp calls used in zero equality tests.

To be clear, this is proposing to replace a memcmp of 8 bytes with up to 16 byte-sized loads on targets with strict alignment? That seems excessive to me.

Aug 31 2022, 8:51 AM · Restricted Project, Restricted Project

Aug 30 2022

msebor requested review of D132960: [InstCombine] Transform small unaligned memcmp calls used in zero equality tests.
Aug 30 2022, 11:00 AM · Restricted Project, Restricted Project

Aug 25 2022

msebor added a comment to D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.

Ping: Are there any comments on the substance of this change?

Aug 25 2022, 8:06 AM · Restricted Project, Restricted Project
msebor added inline comments to D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.
Aug 25 2022, 8:06 AM · Restricted Project, Restricted Project

Aug 24 2022

msebor added a comment to D130922: [InstCombine] Add support for stpncpy folding.

Ping: Is someone available to review this?

Aug 24 2022, 9:35 AM · Restricted Project, Restricted Project

Aug 18 2022

msebor updated the diff for D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.

Revision 2 with the following changes:

  • Enhance the signature validation to cover known forms for all supported targets.
  • Likewise, enhance the folder code to handle all known forms of the function signatures.
  • Add tests.
  • Adjust TargetLibraryInfoTest.cpp to cover the functions.
Aug 18 2022, 1:04 PM · Restricted Project, Restricted Project

Aug 16 2022

msebor added a comment to D130666: [InstCombine] Add support for strlcpy folding.
Aug 16 2022, 4:36 PM · Restricted Project, Restricted Project
msebor committed rGa7a1be11e69d: [InstCombine] convert second std::min argument to same type as first (authored by msebor).
[InstCombine] convert second std::min argument to same type as first
Aug 16 2022, 4:36 PM · Restricted Project, Restricted Project
msebor committed rG345514e991ae: [InstCombine] Add support for strlcpy folding (authored by msebor).
[InstCombine] Add support for strlcpy folding
Aug 16 2022, 3:44 PM · Restricted Project, Restricted Project
msebor closed D130666: [InstCombine] Add support for strlcpy folding.
Aug 16 2022, 3:44 PM · Restricted Project, Restricted Project
msebor committed rGe858f5120da7: [InstCombine] Remove assumptions about int having 32 bits (authored by msebor).
[InstCombine] Remove assumptions about int having 32 bits
Aug 16 2022, 2:36 PM · Restricted Project, Restricted Project
msebor closed D131731: [InstCombine] Remove assumptions about int having 32 bits.
Aug 16 2022, 2:36 PM · Restricted Project, Restricted Project
msebor added inline comments to D131731: [InstCombine] Remove assumptions about int having 32 bits.
Aug 16 2022, 2:36 PM · Restricted Project, Restricted Project
msebor added inline comments to D130666: [InstCombine] Add support for strlcpy folding.
Aug 16 2022, 1:45 PM · Restricted Project, Restricted Project
msebor updated the diff for D130666: [InstCombine] Add support for strlcpy folding.

Revision 1 of the patch with the following changes:

  • Annotate source argument dereferenceable regardless of the bound.
  • Use getConstantStringInfo instead of GetStringLength to detect unterminated arrays.
  • Add tests.
Aug 16 2022, 1:44 PM · Restricted Project, Restricted Project

Aug 15 2022

msebor committed rG65967708d22b: [InstCombine] Adjust snprintf folding of constant strings (PR #56598) (authored by msebor).
[InstCombine] Adjust snprintf folding of constant strings (PR #56598)
Aug 15 2022, 3:01 PM · Restricted Project, Restricted Project
msebor closed D130494: [InstCombine] Adjust snprintf folding of constant strings (PR #56598).
Aug 15 2022, 3:00 PM · Restricted Project, Restricted Project
msebor updated the diff for D130922: [InstCombine] Add support for stpncpy folding.

Changes in revision 1 of the patch include:

  • Avoid annotating destination argument when bound is not known to be nonzero.
  • Correct stpncpy return value to strnlen(S, N) rather than strlen(S).
  • Simplify common logic .
  • Add tests.
Aug 15 2022, 2:29 PM · Restricted Project, Restricted Project
msebor closed D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).

Patch committed in rG0dcfe7aa35cd.

Aug 15 2022, 9:07 AM · Restricted Project, Restricted Project
msebor added a comment to D131731: [InstCombine] Remove assumptions about int having 32 bits.

Thanks for the confirmation! I've CC'd @efriedma who has reviewed changes in this in this area before. If there are no other comments I'll plan on installing the patch later this week to resolve the ffs abort.

Aug 15 2022, 8:54 AM · Restricted Project, Restricted Project
msebor added a reviewer for D131731: [InstCombine] Remove assumptions about int having 32 bits: efriedma.
Aug 15 2022, 8:52 AM · Restricted Project, Restricted Project

Aug 11 2022

msebor added inline comments to rG0dcfe7aa35cd: [InstCombine] Tighten up known library function signature tests (PR #56463).
Aug 11 2022, 3:32 PM · Restricted Project, Restricted Project
msebor requested review of D131731: [InstCombine] Remove assumptions about int having 32 bits.
Aug 11 2022, 3:25 PM · Restricted Project, Restricted Project

Aug 10 2022

msebor planned changes to D130922: [InstCombine] Add support for stpncpy folding.
Aug 10 2022, 4:37 PM · Restricted Project, Restricted Project
msebor added inline comments to D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).
Aug 10 2022, 1:44 PM · Restricted Project, Restricted Project
msebor committed rG0dcfe7aa35cd: [InstCombine] Tighten up known library function signature tests (PR #56463) (authored by msebor).
[InstCombine] Tighten up known library function signature tests (PR #56463)
Aug 10 2022, 1:43 PM · Restricted Project, Restricted Project
msebor added a comment to D130666: [InstCombine] Add support for strlcpy folding.

Ping: Does anyone have any comments on this enhancement?

Aug 10 2022, 8:28 AM · Restricted Project, Restricted Project
msebor added a comment to D130494: [InstCombine] Adjust snprintf folding of constant strings (PR #56598).

Ping: @efriedma, do you (or anyone else) have any other questions/comments or is everyone happy with the last revision?

Aug 10 2022, 8:14 AM · Restricted Project, Restricted Project

Aug 2 2022

msebor added inline comments to D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).
Aug 2 2022, 2:38 PM · Restricted Project, Restricted Project
msebor updated the diff for D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).

Revision 4 of the patch addressing style nits.

Aug 2 2022, 2:37 PM · Restricted Project, Restricted Project

Aug 1 2022

msebor committed rGbcef4d238d11: [InstCombine] Correct strtol folding with nonnull endptr (authored by msebor).
[InstCombine] Correct strtol folding with nonnull endptr
Aug 1 2022, 3:48 PM · Restricted Project, Restricted Project
msebor closed D130912: [InstCombine] Correct strtol folding with nonnull endptr.
Aug 1 2022, 3:47 PM · Restricted Project, Restricted Project
msebor requested review of D130922: [InstCombine] Add support for stpncpy folding.
Aug 1 2022, 11:42 AM · Restricted Project, Restricted Project
msebor requested review of D130912: [InstCombine] Correct strtol folding with nonnull endptr.
Aug 1 2022, 9:00 AM · Restricted Project, Restricted Project
msebor added a comment to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.

Thanks for the test case! The bug is in skipping over the leading part of the string up to the first digit and not accounting for it in the end pointer. It should be straightforward to fix. I'll take care of it today.

Aug 1 2022, 8:08 AM · Restricted Project, Restricted Project

Jul 29 2022

msebor updated the diff for D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).

I like the idea of defining the signatures using the TLI_ macros in TargetLibraryInfo.def. It keeps most of the related bits together in the same place.

Jul 29 2022, 12:17 PM · Restricted Project, Restricted Project

Jul 28 2022

msebor updated the diff for D130494: [InstCombine] Adjust snprintf folding of constant strings (PR #56598).

I think I just equated the 32-bit StringRef limit with INT_MAX. Thanks for pointing that out!

Jul 28 2022, 10:46 AM · Restricted Project, Restricted Project

Jul 27 2022

msebor requested review of D130666: [InstCombine] Add support for strlcpy folding.
Jul 27 2022, 2:54 PM · Restricted Project, Restricted Project

Jul 26 2022

msebor added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 26 2022, 3:08 PM · Restricted Project, Restricted Project
msebor added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 26 2022, 1:14 PM · Restricted Project, Restricted Project
msebor committed rG4447603616bb: [InstCombine] Fold strtoul and strtoull and avoid PR #56293 (authored by msebor).
[InstCombine] Fold strtoul and strtoull and avoid PR #56293
Jul 26 2022, 1:13 PM · Restricted Project, Restricted Project
msebor closed D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 26 2022, 1:12 PM · Restricted Project, Restricted Project

Jul 25 2022

msebor added inline comments to D130494: [InstCombine] Adjust snprintf folding of constant strings (PR #56598).
Jul 25 2022, 1:43 PM · Restricted Project, Restricted Project
msebor updated the diff for D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).

Revision 2 of the patch modifies TargetLibraryInfoImpl::isValidProtoForLibFunc to use the same consistent approach to validate the vast majority of known library functions. It replaces the repetitive (verbose and error-prone) argument checking used for groups of functions with a single "table-driven" algorithm. For better organization it also rearranges the functions by the header they're declared in. (A further improvement here, to avoid duplication, might be also to arrange them within each header by their number of arguments.) Finally, this revision is parameterized on the result of getIntSize() to correctly validate int arguments in 16-bit environments rather than assuming the type is 32 bits everywhere.

Jul 25 2022, 9:58 AM · Restricted Project, Restricted Project
msebor requested review of D130494: [InstCombine] Adjust snprintf folding of constant strings (PR #56598).
Jul 25 2022, 8:54 AM · Restricted Project, Restricted Project

Jul 18 2022

msebor added a comment to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.

Ping: @efriedma, please let me know if you have any further comments or suggestions, or if the last revisions is good enough to commit. Thanks!

Jul 18 2022, 2:58 PM · Restricted Project, Restricted Project
msebor added a reviewer for D129915: [InstCombine] Tighten up known library function signature tests (PR #56463): spatel.
Jul 18 2022, 9:09 AM · Restricted Project, Restricted Project
msebor updated the summary of D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).
Jul 18 2022, 9:08 AM · Restricted Project, Restricted Project
msebor updated the summary of D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).
Jul 18 2022, 9:07 AM · Restricted Project, Restricted Project
msebor added inline comments to D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).
Jul 18 2022, 8:36 AM · Restricted Project, Restricted Project
msebor added a comment to D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).

Thanks for the comments. I actually wasn't quite sure the patch was ready for review because there are more functions where the checking should be tightened up. But since you've already gone through it let me ask a few questions:

  1. Should I submit one patch with all of them or two or more smaller patches?
  2. The functions are not in any particular order, which tends to lead to repetitive checks in different places, and is also more error-prone. I've already moved some of them together (grouped by the header they're declared in) but I wonder: should I do it for all of them? (I.e., have groups by header with no repetitive checks in each group.)
  3. The argument checking is also exceedingly verbose with the differences often being just the argument number or type. These differences would be easier to see (and harder to miss when adding new checks) if we cut down on the amount of superfluous text (e.g., avoided calling getParamType(N) for each argument and instead provided an accessor, like operator[]). Would you support this change?
Jul 18 2022, 8:33 AM · Restricted Project, Restricted Project

Jul 15 2022

msebor requested review of D129915: [InstCombine] Tighten up known library function signature tests (PR #56463).
Jul 15 2022, 7:03 PM · Restricted Project, Restricted Project

Jul 13 2022

msebor committed rGab7ee3c9911f: [InstCombine] Enable strtol folding with nonnull endptr (authored by msebor).
[InstCombine] Enable strtol folding with nonnull endptr
Jul 13 2022, 8:28 AM · Restricted Project, Restricted Project
msebor closed D129593: [InstCombine] Enable strtol folding with nonnull endptr.
Jul 13 2022, 8:27 AM · Restricted Project, Restricted Project
msebor retitled D129593: [InstCombine] Enable strtol folding with nonnull endptr from [InstCombine] Enable strtol folding with nonnull enptr to [InstCombine] Enable strtol folding with nonnull endptr.
Jul 13 2022, 8:25 AM · Restricted Project, Restricted Project

Jul 12 2022

msebor requested review of D129593: [InstCombine] Enable strtol folding with nonnull endptr.
Jul 12 2022, 2:04 PM · Restricted Project, Restricted Project
msebor added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 12 2022, 11:53 AM · Restricted Project, Restricted Project
msebor updated the diff for D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.

Revision 5 with an expanded comment explaining why sequences that end parsing prior to the terminating nul are not accepted.

Jul 12 2022, 11:53 AM · Restricted Project, Restricted Project
msebor added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 12 2022, 9:59 AM · Restricted Project, Restricted Project
msebor updated the diff for D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.

Revision 4 with the following changes:

  • correct base autodetection to consume the 0x prefix also in base 16,
  • reject more variants of empty subject sequences including sole "+" and "0x",
  • add tests for the above.
Jul 12 2022, 9:58 AM · Restricted Project, Restricted Project

Jul 11 2022

msebor added a comment to D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.

I see. It's valid, for example, to declare { i32, i32 } @div(i32, i32) like the test does but that's not necessarily the same as the div declaration that Clang might emit for div_t div(int, int) on some targets. This lets the test pass even on the same target as with an incompatible div and even though the corresponding C test would not (Clang would presumably issue -Wincompatible-library-redeclaration). To catch these problems tests that exercise the C interface to a library would need to be written in C and ideally run for all supported targets.

Jul 11 2022, 9:57 AM · Restricted Project, Restricted Project

Jul 8 2022

msebor added a comment to D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.

Thanks for the pointer to D65457!

Jul 8 2022, 3:27 PM · Restricted Project, Restricted Project
msebor updated the diff for D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.

Revision 3 with one change from previous:

  • Use maxUIntN(unsigned) instead of a case/switch statement.
Jul 8 2022, 2:11 PM · Restricted Project, Restricted Project
msebor added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 8 2022, 2:11 PM · Restricted Project, Restricted Project
msebor requested review of D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding.
Jul 8 2022, 1:22 PM · Restricted Project, Restricted Project

Jul 7 2022

msebor committed rG516915beb5ee: [InstCombine] Fold memchr and strchr equality with first argument (authored by msebor).
[InstCombine] Fold memchr and strchr equality with first argument
Jul 7 2022, 2:16 PM · Restricted Project, Restricted Project
msebor closed D128939: [InstCombine] Fold memchr and strchr equality with first argument.
Jul 7 2022, 2:16 PM · Restricted Project, Restricted Project
msebor updated the diff for D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.

Revision 2 of the patch addressing reviewer suggestions:

  • Use a conditional instead of conversion from bool.
  • Avoid assuming atoi etc. argument is a nul-terminated string.
  • Use llvm::isDigit et al. instead of the C standard functions.
  • Use SaturatingMultiplyAdd to detect overflow.
  • Update getConstantStringInfo to make it clear it need not return a nul-terminated string.
  • Add tests.
Jul 7 2022, 8:32 AM · Restricted Project, Restricted Project
msebor added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 7 2022, 8:27 AM · Restricted Project, Restricted Project

Jul 6 2022

msebor requested review of D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 6 2022, 1:31 PM · Restricted Project, Restricted Project

Jul 1 2022

msebor updated the diff for D128939: [InstCombine] Fold memchr and strchr equality with first argument.

Changes in revision 2 of the patch:

  • Fix spelling/typos.
  • Rebase on top of latest trunk with tests precommitted in rGd8b22243c8e9.
Jul 1 2022, 10:43 AM · Restricted Project, Restricted Project
msebor committed rG0d68ff87d2b0: [InstCombine] Transform strrchr to memrchr for constant strings (authored by msebor).
[InstCombine] Transform strrchr to memrchr for constant strings
Jul 1 2022, 10:13 AM · Restricted Project, Restricted Project
msebor committed rGd8b22243c8e9: [InstCombine] Add tests in anticipation of D128939 (NFC) (authored by msebor).
[InstCombine] Add tests in anticipation of D128939 (NFC)
Jul 1 2022, 10:13 AM · Restricted Project, Restricted Project
msebor closed D128954: [InstCombine] Transform strrchr to memrchr for constant strings.
Jul 1 2022, 10:12 AM · Restricted Project, Restricted Project
msebor added inline comments to D128954: [InstCombine] Transform strrchr to memrchr for constant strings.
Jul 1 2022, 8:19 AM · Restricted Project, Restricted Project

Jun 30 2022

msebor requested review of D128954: [InstCombine] Transform strrchr to memrchr for constant strings.
Jun 30 2022, 3:13 PM · Restricted Project, Restricted Project
msebor requested review of D128939: [InstCombine] Fold memchr and strchr equality with first argument.
Jun 30 2022, 12:51 PM · Restricted Project, Restricted Project
msebor committed rG3a743a589244: [InstCombine] Fix memrchr logic error that prevents folding (authored by msebor).
[InstCombine] Fix memrchr logic error that prevents folding
Jun 30 2022, 10:36 AM · Restricted Project, Restricted Project
msebor closed D128856: [InstCombine] Fix memrchr logic error that prevents folding.
Jun 30 2022, 10:36 AM · Restricted Project, Restricted Project