Page MenuHomePhabricator

[lldb][NFC] Move non-clang specific method to the generic DWARF Parser
AcceptedPublic

Authored by ljmf00 on Nov 29 2021, 9:41 AM.

Details

Summary
This patch renames DW_ACCESS_to_AccessType function and move it to the abstract
DWARFASTParser, since there is no clang-specific code there. This is useful for
plugins other than Clang.

Diff Detail

Event Timeline

ljmf00 created this revision.Nov 29 2021, 9:41 AM
ljmf00 requested review of this revision.Nov 29 2021, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2021, 9:41 AM
ljmf00 updated this revision to Diff 390412.Nov 29 2021, 10:43 AM
bulbazord accepted this revision.Nov 29 2021, 2:44 PM

This makes sense to me. Out of curiosity, do you have plans to use this for non-clang-based languages?

This revision is now accepted and ready to land.Nov 29 2021, 2:44 PM

This makes sense to me. Out of curiosity, do you have plans to use this for non-clang-based languages?

Yes. I'm currently working on a D language plugin. You can see my fork, until I upstream it https://github.com/ljmf00/lldb-d .

ljmf00 retitled this revision from [lldb] Move non-clang specific method to the generic DWARF Parser to [lldb][NFC] Move non-clang specific method to the generic DWARF Parser.
shafik accepted this revision.Nov 30 2021, 7:52 AM

LGTM