Page MenuHomePhabricator

ljmf00 (Luís Ferreira)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2021, 12:54 PM (10 w, 2 d)

Recent Activity

Today

ljmf00 updated subscribers of D114746: [lldb] Generalize ParsedDWARFTypeAttributes.
Mon, Nov 29, 8:13 PM · Restricted Project
ljmf00 added a comment to D114746: [lldb] Generalize ParsedDWARFTypeAttributes.

I'm not sure if this falls into NFC category since I'm changing how flags are stored.

Mon, Nov 29, 8:12 PM · Restricted Project
ljmf00 retitled D114746: [lldb] Generalize ParsedDWARFTypeAttributes from [lldb][NFC] Generalize ParsedDWARFTypeAttributes to [lldb] Generalize ParsedDWARFTypeAttributes.
Mon, Nov 29, 8:11 PM · Restricted Project
ljmf00 added inline comments to D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code.
Mon, Nov 29, 6:38 PM · Restricted Project
ljmf00 reopened D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Mon, Nov 29, 4:54 PM · Restricted Project
ljmf00 added a reverting change for D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h: rG2e5c47eda14a: Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h".
Mon, Nov 29, 4:54 PM · Restricted Project
ljmf00 added a reverting change for rG6f99e1aa58e3: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h: rG2e5c47eda14a: Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h".
Mon, Nov 29, 4:54 PM
ljmf00 committed rG2e5c47eda14a: Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h" (authored by ljmf00).
Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h"
Mon, Nov 29, 4:53 PM
ljmf00 added inline comments to D114305: [Demangle] Add support for multiple identifiers in D qualified names.
Mon, Nov 29, 4:50 PM · Restricted Project
ljmf00 committed rG6f99e1aa58e3: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00).
[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h
Mon, Nov 29, 3:56 PM
ljmf00 closed D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Mon, Nov 29, 3:56 PM · Restricted Project
ljmf00 retitled D113605: [lldb][NFC] Fix documentation for EncodingDataType from [lldb] Fix documentation for EncodingDataType to [lldb][NFC] Fix documentation for EncodingDataType.
Mon, Nov 29, 3:42 PM · Restricted Project
ljmf00 retitled D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h from [lldb] Format lldb/include/lldb/Symbol/Type.h to [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Mon, Nov 29, 3:41 PM · Restricted Project
ljmf00 retitled D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code from [lldb] Move generic DWARFASTParser code out of Clang-specific code to [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code.
Mon, Nov 29, 3:18 PM · Restricted Project
ljmf00 retitled D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser from [lldb] Move non-clang specific method to the generic DWARF Parser to [lldb][NFC] Move non-clang specific method to the generic DWARF Parser.
Mon, Nov 29, 3:17 PM · Restricted Project
ljmf00 updated the diff for D114746: [lldb] Generalize ParsedDWARFTypeAttributes.
Mon, Nov 29, 3:16 PM · Restricted Project
ljmf00 added a comment to D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser.

This makes sense to me. Out of curiosity, do you have plans to use this for non-clang-based languages?

Mon, Nov 29, 3:15 PM · Restricted Project
ljmf00 updated the diff for D114746: [lldb] Generalize ParsedDWARFTypeAttributes.
Mon, Nov 29, 3:11 PM · Restricted Project
ljmf00 retitled D114746: [lldb] Generalize ParsedDWARFTypeAttributes from [lldb] Generalize ParsedDWARFTypeAttributes to [lldb][NFC] Generalize ParsedDWARFTypeAttributes.
Mon, Nov 29, 3:07 PM · Restricted Project
ljmf00 requested review of D114746: [lldb] Generalize ParsedDWARFTypeAttributes.
Mon, Nov 29, 3:06 PM · Restricted Project
ljmf00 updated the diff for D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser.
Mon, Nov 29, 10:43 AM · Restricted Project
ljmf00 updated the diff for D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser.
Mon, Nov 29, 9:43 AM · Restricted Project
ljmf00 added reviewers for D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser: teemperor, bulbazord.
Mon, Nov 29, 9:42 AM · Restricted Project
ljmf00 requested review of D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser.
Mon, Nov 29, 9:41 AM · Restricted Project
ljmf00 added a reviewer for D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code: teemperor.
Mon, Nov 29, 8:10 AM · Restricted Project

Yesterday

ljmf00 added a comment to D112564: [lldb] Add support for custom char8_t types with different name.

What exactly do you need the test to do? Is printing a global variable (char8_t_ish foo[] = "my string") sufficient?
If so, you can take a look at the tests in test/Shell/SymbolFile/DWARF for inspiration. There are .s and .ll tests there.
The pattern would roughly be:

# RUN: llvm-mc (or llc) -o %t %s
# RUN: %lldb %t -o "target variable foo" | FileCheck %s

# CHECK: (char8_t_ish[]) foo = "my string"

your code here
Sun, Nov 28, 6:39 PM · Restricted Project, Restricted Project
ljmf00 added inline comments to D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code.
Sun, Nov 28, 2:43 PM · Restricted Project
ljmf00 retitled D114674: [MLIR] Move Presburger Math from FlatAffineConstraints to Presburger/PresburgerBasicSet from MLIR] Move Presburger Math from FlatAffineConstraints to Presburger/PresburgerBasicSet to [MLIR] Move Presburger Math from FlatAffineConstraints to Presburger/PresburgerBasicSet.
Sun, Nov 28, 5:45 AM · Restricted Project

Sat, Nov 27

ljmf00 updated subscribers of D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code.
Sat, Nov 27, 4:37 PM · Restricted Project
ljmf00 requested review of D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code.
Sat, Nov 27, 4:36 PM · Restricted Project

Fri, Nov 26

ljmf00 added a comment to D114305: [Demangle] Add support for multiple identifiers in D qualified names.

Done @dblaikie, can you review?

Oh, generally if something's "Approved with suggestions" it's fine to submit it if you think you've applied the suggestions. So, this is fine, but I'll mark it as approved again.

Fri, Nov 26, 7:05 AM · Restricted Project

Thu, Nov 25

ljmf00 added a comment to D114307: [Demangle] Add support for D anonymous symbols.

Looks OK, though the "anonymous" in the mangled name tests seems misleading - the "anonymous" isn't itself, anonymous, right? IT's followed by anonymous symbol (0), yeah? So maybe change that text/name - might be clearer.

Thu, Nov 25, 1:41 PM · Restricted Project
ljmf00 updated the diff for D114307: [Demangle] Add support for D anonymous symbols.
Thu, Nov 25, 1:20 PM · Restricted Project
ljmf00 added a comment to D114305: [Demangle] Add support for multiple identifiers in D qualified names.

Done @dblaikie, can you review?

Thu, Nov 25, 1:18 PM · Restricted Project
ljmf00 updated the diff for D114305: [Demangle] Add support for multiple identifiers in D qualified names.
Thu, Nov 25, 1:14 PM · Restricted Project
ljmf00 abandoned D113631: [docs] Fix trailing whitespaces.

Seem to be already fixed on the upstream default branch

Thu, Nov 25, 11:03 AM · Restricted Project
ljmf00 added a comment to D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.

LGTM modulo the inline comment.

Thu, Nov 25, 10:14 AM · Restricted Project
ljmf00 updated the diff for D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Thu, Nov 25, 10:13 AM · Restricted Project

Sat, Nov 20

ljmf00 added inline comments to D114305: [Demangle] Add support for multiple identifiers in D qualified names.
Sat, Nov 20, 1:38 PM · Restricted Project

Fri, Nov 19

ljmf00 added a comment to D111415: [Demangle] Add support for D simple single qualified names.

https://reviews.llvm.org/D114305
https://reviews.llvm.org/D114307
https://reviews.llvm.org/D114308
https://reviews.llvm.org/D114309

Fri, Nov 19, 7:19 PM · Restricted Project
ljmf00 requested review of D114309: [Demangle] Add support for D fake parent symbols.
Fri, Nov 19, 7:18 PM · Restricted Project
ljmf00 requested review of D114308: [Demangle] Add support for D special identifiers.
Fri, Nov 19, 7:16 PM · Restricted Project
ljmf00 requested review of D114307: [Demangle] Add support for D anonymous symbols.
Fri, Nov 19, 7:14 PM · Restricted Project
ljmf00 updated the diff for D114305: [Demangle] Add support for multiple identifiers in D qualified names.
Fri, Nov 19, 7:12 PM · Restricted Project
ljmf00 requested review of D114305: [Demangle] Add support for multiple identifiers in D qualified names.
Fri, Nov 19, 7:10 PM · Restricted Project
ljmf00 retitled D111415: [Demangle] Add support for D simple single qualified names from [Demangle] Add support for D simple qualified names to [Demangle] Add support for D simple single qualified names.
Fri, Nov 19, 7:08 PM · Restricted Project
ljmf00 added a comment to D111415: [Demangle] Add support for D simple single qualified names.

Still seems a bit long in one patch/hard to verify that all the cases are covered by tests, etc. Could you break this up further - maybe implementing only the most basic, single 'parseIdentifier' case, then the iteration, then the anonymous symbols, then the lnames?

Fri, Nov 19, 7:08 PM · Restricted Project
ljmf00 updated the diff for D111415: [Demangle] Add support for D simple single qualified names.
Fri, Nov 19, 7:07 PM · Restricted Project

Thu, Nov 18

ljmf00 added a comment to D111415: [Demangle] Add support for D simple single qualified names.

I changed the patch to avoid else-after-return, use // comment style, remove untested code, use ++i over i++ when possible, and use the OutputBuffer.

Thu, Nov 18, 10:54 AM · Restricted Project
ljmf00 updated the summary of D111415: [Demangle] Add support for D simple single qualified names.
Thu, Nov 18, 10:51 AM · Restricted Project
ljmf00 updated the diff for D111415: [Demangle] Add support for D simple single qualified names.
Thu, Nov 18, 10:51 AM · Restricted Project

Wed, Nov 17

ljmf00 added a comment to D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.

Friendly ping, maybe you forgot this, can you check it now @teemperor ? :)

Wed, Nov 17, 10:09 AM · Restricted Project

Sun, Nov 14

ljmf00 added a comment to D30774: [SimplifyCFG] Merging duplicated basic blocks.

Originally, this patch is for helping another optimization (https://reviews.llvm.org/D30900). But potentially, removing duplication may affect other optimizations in general.
If you have a strong example to push this optimization, I think it is reasonable to submit a new patch with the description on how it improve the code with a large switch.

Sun, Nov 14, 9:27 AM

Fri, Nov 12

ljmf00 added a comment to D113633: [llvm] Add support for DW_TAG_immutable_type.

Also, take the example of https://reviews.llvm.org/D113634 , which may be split into two patches for further discussion. Anyway, I tend to agree with you, I can join everything together in D113634.

Fri, Nov 12, 9:57 AM · debug-info, Restricted Project
ljmf00 added a comment to D113633: [llvm] Add support for DW_TAG_immutable_type.

Typically I've done "support" for a tag or other DWARF feature in several phases, each usually (not necessarily) with its own patch. Each phase builds on the previous one, which is the project's preferred incremental-development model.

  • First, do enough so that llvm-dwarfdump can correctly handle an object file with a DW_TAG_immutable_type in it; this generally means tweaking lib/DebugInfo/DWARF a little bit, as I see you have done. The test can be an assembler file with the raw bytes listed; there are many examples of this.
  • Next, make it so textual IR can describe an immutable type, which can be emitted into an object file. The IR part might involve round-tripping through textual and bitcode formats to show that all works. For the object-file part you use llvm-dwarfdump, because your previous work verified that llvm-dwarfdump handles the tag correctly.
  • Next, if you need to fiddle with DIBuilder to get the IR API to handle immutable types, you do that, probably with a unittest (not a Clang test, because LLVM has other frontend clients and LLVM testing should not depend on any of them).
  • Finally, if this is a C/C++ language feature, you plumb it into Clang to emit the tag when appropriate, with a test that uses -emit-llvm and verify that the IR comes out right. I'm not aware that "immutable" is a C/C++ feature, but I find it hard to keep up with the C++ standard.

If the whole thing is trivial enough--which it might be, because this is a type qualifier like many others--you can do multiple phases in one patch, but we still want to see that each step has the proper testing.

Fri, Nov 12, 9:49 AM · debug-info, Restricted Project

Thu, Nov 11

ljmf00 added a comment to D113572: [DebugInfo] run clang-format on some unformatted files.

@probinson Can you check now? If it looks good, can you land it, please?

Sure. It looks like your email address is <contact@lsferreira.net> is that correct? We do want to be careful about attributions.

Thu, Nov 11, 5:45 PM · Restricted Project
ljmf00 added a comment to D113634: [lldb] Add support for DW_TAG_immutable_type.

Are the DWARFASTParserClang changes meant as a step towards making it parse D?

Yes, not only D but any language that currently falls here (https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L106-L112). AFAIK, rust have immutable variables too. Since I'm working on a DWARFFASTParser for D this won't affect it in the future, but for languages like Rust that uses the Python API and rely on Clang DWARFParser, this could be beneficial.

I know the change is well intended, but the Rust support is 100% untested and completely broken (it can't deal with pretty much any non-trivial program from my recollections). So I would split out the Clang changes (which probably require some longer discussion) and just keep the Type/DWARFDIe changes (which look good to me).

Thu, Nov 11, 11:05 AM · Restricted Project
ljmf00 updated subscribers of D113634: [lldb] Add support for DW_TAG_immutable_type.
Thu, Nov 11, 6:22 AM · Restricted Project
ljmf00 updated subscribers of D113633: [llvm] Add support for DW_TAG_immutable_type.
Thu, Nov 11, 6:22 AM · debug-info, Restricted Project
ljmf00 updated subscribers of D113632: [docs] Add DW_TAG_immutable_type tag.
Thu, Nov 11, 6:22 AM · Restricted Project
ljmf00 added a comment to D113634: [lldb] Add support for DW_TAG_immutable_type.

Are the DWARFASTParserClang changes meant as a step towards making it parse D?

Thu, Nov 11, 6:20 AM · Restricted Project

Wed, Nov 10

ljmf00 planned changes to D113634: [lldb] Add support for DW_TAG_immutable_type.

I still need to add tests.

Wed, Nov 10, 5:30 PM · Restricted Project
ljmf00 requested review of D113634: [lldb] Add support for DW_TAG_immutable_type.
Wed, Nov 10, 5:29 PM · Restricted Project
ljmf00 planned changes to D113633: [llvm] Add support for DW_TAG_immutable_type.

I still need to add tests

Wed, Nov 10, 5:24 PM · debug-info, Restricted Project
ljmf00 requested review of D113633: [llvm] Add support for DW_TAG_immutable_type.
Wed, Nov 10, 5:23 PM · debug-info, Restricted Project
ljmf00 requested review of D113632: [docs] Add DW_TAG_immutable_type tag.
Wed, Nov 10, 5:21 PM · Restricted Project
ljmf00 requested review of D113631: [docs] Fix trailing whitespaces.
Wed, Nov 10, 5:13 PM · Restricted Project
ljmf00 added a reviewer for D113605: [lldb][NFC] Fix documentation for EncodingDataType: teemperor.
Wed, Nov 10, 5:04 PM · Restricted Project
ljmf00 updated the diff for D113605: [lldb][NFC] Fix documentation for EncodingDataType.
Wed, Nov 10, 5:03 PM · Restricted Project
ljmf00 added a comment to D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.

Can you check now? If looks good, can you land it please?

Wed, Nov 10, 5:02 PM · Restricted Project
ljmf00 updated the diff for D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Wed, Nov 10, 5:02 PM · Restricted Project
ljmf00 updated subscribers of D110578: [lldb] Add support for D programming language.

@dblaikie Maybe you can land this?

Wed, Nov 10, 4:37 PM · Restricted Project, Restricted Project
ljmf00 added a comment to D113572: [DebugInfo] run clang-format on some unformatted files.

@probinson Can you check now? If it looks good, can you land it, please?

Wed, Nov 10, 1:16 PM · Restricted Project
ljmf00 updated the diff for D113572: [DebugInfo] run clang-format on some unformatted files.
Wed, Nov 10, 1:15 PM · Restricted Project
ljmf00 requested review of D113605: [lldb][NFC] Fix documentation for EncodingDataType.
Wed, Nov 10, 12:53 PM · Restricted Project
ljmf00 requested review of D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Wed, Nov 10, 12:52 PM · Restricted Project
ljmf00 added a comment to D113572: [DebugInfo] run clang-format on some unformatted files.

In general doing a clang-format before extensive work on some files is an obvious NFC, but I can see why you might have wanted some review on this.

LGTM, although the one thing I'd really like you to try is reflowing that one awkward function description. All the other trivial spacing stuff is purely optional.

Wed, Nov 10, 12:26 PM · Restricted Project
ljmf00 requested review of D113572: [DebugInfo] run clang-format on some unformatted files.
Wed, Nov 10, 8:25 AM · Restricted Project

Tue, Nov 9

ljmf00 added a comment to D111432: [Tools] Add a fuzzing tool to help fuzzing D demangler.

Since D111414 got merged, @dblaikie can you land this too?

Tue, Nov 9, 12:22 PM · Restricted Project
ljmf00 added a comment to D110578: [lldb] Add support for D programming language.

Since D111414 got merged, @teemperor can you land this?

Tue, Nov 9, 12:21 PM · Restricted Project, Restricted Project
ljmf00 added a comment to D111414: [Demangle] Add minimal support for D programming language.

@dblaikie Can you land this?

Tue, Nov 9, 7:48 AM · Restricted Project

Mon, Nov 8

ljmf00 updated the diff for D111414: [Demangle] Add minimal support for D programming language.
Mon, Nov 8, 6:35 PM · Restricted Project
ljmf00 updated the summary of D111414: [Demangle] Add minimal support for D programming language.
Mon, Nov 8, 6:33 PM · Restricted Project

Wed, Nov 3

ljmf00 added a comment to D113098: [lldb] (Partially) enable formatting of utf strings before the program is started.

bug reported in PR45856.

Wed, Nov 3, 6:53 AM · Restricted Project
ljmf00 updated subscribers of D113098: [lldb] (Partially) enable formatting of utf strings before the program is started.
Wed, Nov 3, 6:46 AM · Restricted Project
ljmf00 added a comment to D111414: [Demangle] Add minimal support for D programming language.

LGTM, modulo the previously-discussed licensing question - have you heard anything from the LLVM foundation board yet?

Wed, Nov 3, 6:18 AM · Restricted Project
ljmf00 updated the diff for D111414: [Demangle] Add minimal support for D programming language.
Wed, Nov 3, 6:04 AM · Restricted Project
ljmf00 added inline comments to D111414: [Demangle] Add minimal support for D programming language.
Wed, Nov 3, 3:16 AM · Restricted Project
ljmf00 updated the diff for D111414: [Demangle] Add minimal support for D programming language.
Wed, Nov 3, 3:12 AM · Restricted Project

Tue, Nov 2

ljmf00 added inline comments to D111414: [Demangle] Add minimal support for D programming language.
Tue, Nov 2, 7:51 PM · Restricted Project
ljmf00 updated the summary of D111414: [Demangle] Add minimal support for D programming language.
Tue, Nov 2, 7:51 PM · Restricted Project
ljmf00 updated the diff for D111414: [Demangle] Add minimal support for D programming language.
Tue, Nov 2, 7:51 PM · Restricted Project

Mon, Nov 1

ljmf00 added a comment to D111414: [Demangle] Add minimal support for D programming language.

@jhenderson @dblaikie can you re-review?

Mon, Nov 1, 11:17 AM · Restricted Project
ljmf00 updated the diff for D111414: [Demangle] Add minimal support for D programming language.
Mon, Nov 1, 11:16 AM · Restricted Project

Oct 28 2021

ljmf00 added a comment to D112658: [lldb] Refactor C/C++ string and char summary providers.

Thanks for doing this. Just a couple of small remarks.

Oct 28 2021, 12:38 PM · Restricted Project, Restricted Project
ljmf00 updated the diff for D112658: [lldb] Refactor C/C++ string and char summary providers.
Oct 28 2021, 12:36 PM · Restricted Project, Restricted Project
ljmf00 added a comment to D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters.

LGTM, thanks.

Oct 28 2021, 12:35 PM · Restricted Project

Oct 27 2021

ljmf00 updated the summary of D112658: [lldb] Refactor C/C++ string and char summary providers.
Oct 27 2021, 1:24 PM · Restricted Project, Restricted Project
ljmf00 requested review of D112658: [lldb] Refactor C/C++ string and char summary providers.
Oct 27 2021, 1:24 PM · Restricted Project, Restricted Project
ljmf00 added a comment to D95284: utils/release: Add script for building release documentation.

I left some comments :)

Oct 27 2021, 1:12 PM · Restricted Project