- User Since
- Sep 18 2021, 12:54 PM (116 w, 1 d)
Jun 13 2022
Jun 6 2022
@labath In the meantime, a lot of time passed and someone patched it in D120690, but the order on the documentation is wrong and the Python bindings need swig definitions. This patch introduces those, after rebasing with main.
Jun 2 2022
Sorry for leaving this hanging for a long time. Feel free to leave feedback if I'm missing something, in the meantime.
Mar 6 2022
Thanks for adding this, I ended up forgoting, since I don't use PDB.
Feb 28 2022
Meanwhile, a commit will land Linux stable branches soon to fix this issue: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=44cad52cc14ae10062f142ec16ede489bccf4469 . Do we have an alternative way to fix this, e.g. a custom XFAIL flag for specific linux versions?
Feb 10 2022
Jan 24 2022
Jan 23 2022
Jan 22 2022
Jan 21 2022
Jan 14 2022
Jan 13 2022
I had to look into the documentation to understand how comdat works. Compared to the diffs I generated early this seems fine. I also did a full bootstrap multi-stage build of clang with this patch and the patches and flags used by my host clang. I can't reproduce the issue I described on D102453, so it seems fixed. Thanks!
Looks good. Isn't this supposed to stack with D117190? I often use the Phabricator related patches feature to stack patches and avoid merging them in the wrong order :)
Jan 12 2022
Ok, digging a bit more, I found out that this is a downstream issue and somehow the patch to enforce stack protection and fPIE is probably triggering this. See https://github.com/archlinux/svntogit-packages/blob/packages/clang/trunk/enable-SSP-and-PIE-by-default.patch and https://bugs.llvm.org/show_bug.cgi?id=13410 . I'm going to add a bug report on the Arch Linux bug tracker. Do you have any idea to correctly handle this when sanitization is on?
This patch makes compilation fail when running with sanitization and debug mode, it seems. Brief log here:
Jan 11 2022
I also added another test to include invalid back reference position with _D8demangle3fooQXXXx.
Added final dots on unit test comments.
I added comments to the test cases and fixed C like comments, ++I instead of I++ and other requested changes on previous patches. Can you please re-review it?
I simplified the symbol back referencing. I thought that referencing a back reference was permitted by the ABI spec, but it was pointing to the same position, so it is redundant to add two back-references. I also added a comment on the nullptr tests to describe what it is testing. In the case of Qa, it references itself and hangs.
Jan 10 2022
Jan 5 2022
Added comment on nullptr testcases.
@dblaikie I removed all the uncovered types and added just minimal support just to prove type parsing functionality. I change the name of the patch to reflect the changes. I still have Demangled << "int"; and Demangled << "void"; that are covered but with untested behaviour. I can add a comment explaining why or remove it completely if you prefer.
Jan 4 2022
Dec 30 2021
I finally reproduced this locally. The buildbot is configured with BUILD_SHARED_LIBS and my builds are built without it and use LLVM_LINK_LLVM_DYLIB and CLANG_LINK_CLANG_DYLIB respectively. Since I made lld::demangle symbol inline, Demangle LLVM component was missing on MachO. I added that component to the link list on CMakeLists.txt.
I reverted this to not congestionante other builds and described the reason on the revert commit. I will do a clean build with all targets and try to reproduce this. I only tested this on x86 and WebAssembly targets since I haven't seen target specific code here. Additionally, I've tested this on an x86_64 environment.
Added tests and squashed documentation as requested.
Dec 25 2021
I built and checked with x86 and experimental WASM target locally on a Linux environment.