Page MenuHomePhabricator
Differential D114218

[mlir][linalg][bufferize][NFC] Move vector interface impl to new build target
ClosedPublic
Actions

Authored by springerm on Nov 18 2021, 9:40 PM.

Details

Reviewers
nicolasvasilache
aartbik
Commits
rGca9d149e0755: [mlir][linalg][bufferize][NFC] Move vector interface impl to new build target
Summary

This makes ComprehensiveBufferize entirely independent of the vector dialect.

Depends On D114217

Diff Detail

Event Timeline

springerm created this revision.Nov 18 2021, 9:40 PM
Herald added a reviewer: aartbik. · View Herald TranscriptNov 18 2021, 9:40 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 22 others. · View Herald Transcript
springerm requested review of this revision.Nov 18 2021, 9:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2021, 9:40 PM
Herald added subscribers: limo1996, stephenneuendorffer. · View Herald Transcript
springerm added a child revision: D114219: [mlir][linalg][bufferize][NFC] Move arith interface impl to new build target.Nov 18 2021, 9:41 PM
Harbormaster completed remote builds in B135032: Diff 388378.Nov 18 2021, 9:48 PM
springerm updated this revision to Diff 388400.Nov 18 2021, 11:34 PM

update

Harbormaster completed remote builds in B135048: Diff 388400.Nov 18 2021, 11:45 PM
aartbik accepted this revision.Nov 22 2021, 12:13 PM
aartbik added inline comments.
mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/VectorInterfaceImpl.h
2

header of?

This revision is now accepted and ready to land.Nov 22 2021, 12:13 PM
springerm added inline comments.Nov 23 2021, 4:43 AM
mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/VectorInterfaceImpl.h
2

The Impl. here means "Interface Implementation" (via external model). Not to be confused with "source" (impl) vs. "header" (decl). Not sure how to describe it more precisely. It's actually pretty difficult to compress it in 80 characters...

springerm updated this revision to Diff 389170.Nov 23 2021, 4:44 AM

update

Harbormaster completed remote builds in B135610: Diff 389170.Nov 23 2021, 8:43 AM
Closed by commit rGca9d149e0755: [mlir][linalg][bufferize][NFC] Move vector interface impl to new build target (authored by springerm). · Explain WhyNov 24 2021, 2:36 AM
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rGca9d149e0755: [mlir][linalg][bufferize][NFC] Move vector interface impl to new build target.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Linalg/
ComprehensiveBufferize/
27 lines
lib/
Dialect/
Linalg/
ComprehensiveBufferize/
11 lines
101 lines
123 lines
Transforms/
1 line
2 lines
utils/
bazel/
llvm-project-overlay/
mlir/
20 lines

Diff 389440

View Options

mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/VectorInterfaceImpl.h

Loading...
View Options

mlir/lib/Dialect/Linalg/ComprehensiveBufferize/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ComprehensiveBufferize.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/ComprehensiveBufferize/VectorInterfaceImpl.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp

Loading...
View Options

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Loading...