This is an archive of the discontinued LLVM Phabricator instance.

[mlir][linalg][bufferize] Op interface implementation for Bufferization dialect ops

Authored by springerm on Nov 26 2021, 12:15 AM.



This change provides BufferizableOpInterface implementations for ops from the Bufferization dialects. These ops are needed at the bufferization boundaries for partial bufferization.

Depends On D114617

Diff Detail

Event Timeline

springerm created this revision.Nov 26 2021, 12:15 AM
springerm requested review of this revision.Nov 26 2021, 12:15 AM
nicolasvasilache accepted this revision.Dec 1 2021, 12:19 AM
nicolasvasilache added inline comments.

These ops are not a good abstraction in general and are really implementation detail leaking in the IR due to multi-pass bufferization.
We should have very strong documentation on the fact that they alias with the world and we should not make any non-conservative assumption on them.


typo hae


Can we make this message more descriptive and signal this is a hard error (with maybe a suggestion on what the user would have to do to get to a reasonable form?).

This revision is now accepted and ready to land.Dec 1 2021, 12:19 AM
springerm updated this revision to Diff 391198.Dec 1 2021, 9:39 PM
springerm marked an inline comment as done.


This revision was landed with ongoing or failed builds.Dec 2 2021, 11:31 PM
This revision was automatically updated to reflect the committed changes.