Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D114056

[mlir][linalg][bufferize][NFC] Call `bufferize` on all bufferizable ops
AbandonedPublic
Actions

Authored by springerm on Nov 16 2021, 9:54 PM.

Details

Reviewers

nicolasvasilache

Summary

Call this function even on ops that do not have tensor OpOperands/OpResults.

Depends On D114055

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

springerm created this revision.Nov 16 2021, 9:54 PM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptNov 16 2021, 9:54 PM

springerm requested review of this revision.Nov 16 2021, 9:54 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 9:54 PM

Herald added subscribers: limo1996, stephenneuendorffer. · View Herald Transcript

springerm added a child revision: D114057: [mlir][linalg][bufferize][NFC] Specify bufferize traversal in `bufferize`.Nov 16 2021, 9:55 PM

Harbormaster completed remote builds in B134658: Diff 387826.Nov 16 2021, 10:19 PM

nicolasvasilache accepted this revision.Nov 17 2021, 12:21 AM

This revision is now accepted and ready to land.Nov 17 2021, 12:21 AM

It isn't obvious to me that this is NFC?

In D114056#3138984, @mehdi_amini wrote:

It isn't obvious to me that this is NFC?

For the current interface implementations, this change is NFC. Before this change, it was guaranteed that the bufferize method was never called on ops that do not need bufferization (because they have no tensor results/operands). After this change, bufferize is called for every bufferizable op. If there is no work to do, the interface method simply returns success. This is in preparation of changing the way that operations are traversed in one of the subsequent commits.

I'll update the commit message when landing this change.

Note, I may change this back to the original behavior again later. This change is mostly to keep the commits small during an overall larger refactoring.

springerm abandoned this revision.Nov 23 2021, 4:27 AM

springerm removed a child revision: D114057: [mlir][linalg][bufferize][NFC] Specify bufferize traversal in `bufferize`.