This is an archive of the discontinued LLVM Phabricator instance.

[fir] Add !fir.len type conversion
ClosedPublic

Authored by clementval on Nov 11 2021, 2:12 AM.

Details

Summary

This patch adds the !fir.len type conversion. The type is converted
to the a 32 bits integer.

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Nov 11 2021, 2:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2021, 2:12 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Nov 11 2021, 2:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2021, 2:12 AM
kiranchandramohan added inline comments.
flang/lib/Optimizer/CodeGen/TypeConverter.h
73

Nit: A comment on why this is 32 bits while some others like character len is 64 or platform-dependent will be good.

This revision is now accepted and ready to land.Nov 11 2021, 2:22 AM

Get size from the descriptor + rebase

This revision was automatically updated to reflect the committed changes.