This is an archive of the discontinued LLVM Phabricator instance.

Officially deprecate LLVM_ENABLE_PROJECTS for libc++, libc++abi and libunwind

Authored by ldionne on Oct 28 2021, 8:23 AM.



This updates the LLVM wide documentation for building LLVM and the runtimes
and adds a CMake warning when folks specify libcxx, libcxxabi or libunwind
in LLVM_ENABLE_PROJECTS, pointing them to the updated instructions for
building the runtimes.

Diff Detail

Event Timeline

ldionne created this revision.Oct 28 2021, 8:23 AM
ldionne requested review of this revision.Oct 28 2021, 8:23 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski accepted this revision.Oct 29 2021, 4:09 AM

This has been a source of confusion for many people - many thanks for clarifying this!


This revision is now accepted and ready to land.Oct 29 2021, 4:09 AM
This revision was landed with ongoing or failed builds.Oct 29 2021, 5:53 AM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Feb 7 2022, 10:05 AM
thakis added inline comments.

libcxx libcxxabi libunwind are still part of LLVM_ALL_PROJECTS and...


...this is below the warning you added. So if you say LLVM_ALL_PROJECTS=all you still get the old behavior, without a warning. Is that intentional?

(Doesn't affect us, just happened to notice it while reading this file.)

ldionne added inline comments.Feb 7 2022, 11:23 AM

I think it was intentional -- I didn't intend to issue a warning for folks who use all if they are not using libcxx, libcxxabi or libunwind explicitly. I think the next step would be to remove libcxx, libcxxabi` and libunwind from all, and to make this warning into an error since we don't support this anymore as of the branch point.