Update .clang-tidy file with the value used in fir-dev.
This patch is part of the upstreaming effort from fir-dev branch.
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Differential D111525
[fir] Update clang-tidy for the Optimizer directory clementval on Oct 11 2021, 1:28 AM. Authored by
Details Update .clang-tidy file with the value used in fir-dev. This patch is part of the upstreaming effort from fir-dev branch. Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Diff Detail
Event TimelineComment Actions I'm a bit puzzled, many of the values are already defined at the top-level and I don't see an override on the path there. What's the effect of this? Please provide correct commit description, just saying Update .clang-tidy file with the value used in fir-dev. isn't helpful. Comment Actions Actually, they aren't. flang/.clang-tidy has a number of deltas to {mlir,llvm}/.clang-tidy, as the front end uses its own style. The files under Optimizer use the MLIR style since the code makes very heavy use of MLIR (obviously). Comment Actions I looked before commenting, I didn't spot it, can you link more precisely? For example here is what I see at HEAD: $ cat flang/.clang-tidy Checks: '-llvm-include-order,readability-braces-around-statements,-readability-identifier-naming,-clang-diagnostic-*' InheritParentConfig: true And at the top level the values are matching what is added in this revision. Comment Actions I guess you mean llvm-project/.clang-tidy if so you are right the key/value are the same. If this is a problem to ensure those value at this level we can probably remove them. For the commit message I'm not sure we can be more helpful. The changes are self-explanatory so it would help much to describe it in the commit message in my opinion. Comment Actions What we want to achieve is to have the same clang-tidy behavior than MLIR in these directories since the code here uses a lot of MLIR. We might need to double check whether it is still wise to inherit the config from the parent since the flang/.clang-tidy has a differnt style. Comment Actions
Right now this patch has no effect basically as far as I can tell, so it does not seem like self explanatory in itself. |