Page MenuHomePhabricator

[RISCV][test] Precommit tests for D108129.

Authored by jacquesguan on Sep 28 2021, 7:07 PM.

Diff Detail

Event Timeline

jacquesguan created this revision.Sep 28 2021, 7:07 PM
jacquesguan requested review of this revision.Sep 28 2021, 7:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2021, 7:07 PM
RKSimon added inline comments.Sep 29 2021, 1:56 AM
306 ↗(On Diff #375764)

you can probably get rid of cfi noise bv adding a nounwind attribute?

Is there a reason we're only testing on RV32?

Add rv64 tests.

RKSimon accepted this revision.Oct 28 2021, 1:26 AM


This revision is now accepted and ready to land.Oct 28 2021, 1:26 AM
frasercrmck requested changes to this revision.Oct 28 2021, 2:11 AM

LGTM if that issue is fixed.


Missing checks here and in other functions. Unless the file wasn't generated correctly, this is probably because the codegen differs between RV32 and RV64. You likely need --check-prefixes=RV32,CHECK and --check-prefixes=RV64,CHECK

This revision now requires changes to proceed.Oct 28 2021, 2:11 AM

Nice catch!


As per @frasercrmck request:

; RUN: llc -mtriple=riscv32 -mattr=+experimental-v -verify-machineinstrs < %s | FileCheck %s --check-prefixes=CHECK,RV32
; RUN: llc -mtriple=riscv64 -mattr=+experimental-v -verify-machineinstrs < %s | FileCheck %s --check-prefixes=CHECK,RV64

Add check prefix for difference between RV32 and RV64.

LGTM if that issue is fixed.

Done, thanks a lot.

jacquesguan added inline comments.Oct 28 2021, 8:24 PM

Done, thanks a lot.

frasercrmck accepted this revision.Oct 29 2021, 3:35 AM


This revision is now accepted and ready to land.Oct 29 2021, 3:35 AM
This revision was landed with ongoing or failed builds.Mon, Nov 1, 7:38 PM
This revision was automatically updated to reflect the committed changes.