Page MenuHomePhabricator

[Clang] Enable _Complex __ibm128 type
ClosedPublic

Authored by qiucf on Sep 16 2021, 11:04 PM.

Details

Summary

As a follow-up to fae0dfa.

Diff Detail

Event Timeline

qiucf created this revision.Sep 16 2021, 11:04 PM
qiucf requested review of this revision.Sep 16 2021, 11:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2021, 11:04 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rjmccall added inline comments.Mon, Sep 27, 9:03 PM
clang/include/clang/AST/ASTContext.h
1095 ↗(On Diff #373146)

Huh. I don't know why we precompute these. I mean, it's not a huge start-up overhead for the compiler, but it's not nothing, and the use in getFloatingTypeOfSizeWithinDomain is not at all worth optimizing.

Would you mind writing up a patch that rips all of these out and makes the use-sites just build the appropriate complex type as needed? And then we can land a patch for this that just does the one-liner to allow _Complex __ibm128.

clang/lib/Sema/Sema.cpp
1898 ↗(On Diff #373146)

Why is this change in this patch?

qiucf updated this revision to Diff 378112.Fri, Oct 8, 12:35 AM
qiucf marked 2 inline comments as done.

Based on another patch to remove pre-computed complex CanQualType.

This revision is now accepted and ready to land.Fri, Oct 8, 12:20 PM
This revision was landed with ongoing or failed builds.Fri, Oct 8, 7:54 PM
This revision was automatically updated to reflect the committed changes.