This is an archive of the discontinued LLVM Phabricator instance.

Differential D109340

[lld] Add bitcode->e_machine mapping for hexagon
AbandonedPublic

Authored by bcain on Sep 6 2021, 5:17 PM.

Details

Reviewers
sidneym
MaskRay

Diff Detail

Event Timeline

bcain created this revision.Sep 6 2021, 5:17 PM
Herald added subscribers: arichardson, emaste. · View Herald TranscriptSep 6 2021, 5:17 PM
bcain requested review of this revision.Sep 6 2021, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2021, 5:17 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B122810: Diff 370974.Sep 6 2021, 5:54 PM
MaskRay added a comment.Sep 7 2021, 11:16 AM

Add a test like test/ELF/lto/riscv64.ll

MaskRay added a comment.Sep 7 2021, 11:17 AM

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

bcain added a comment.Sep 7 2021, 11:22 AM
In D109340#2987453, @MaskRay wrote:

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

ok, will do.

bcain abandoned this revision.Sep 7 2021, 7:42 PM
In D109340#2987464, @bcain wrote:
In D109340#2987453, @MaskRay wrote:

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

ok, will do.

Hmm, created a simple test case modeled after aarch64.ll, but it was failing. After a very brief investigation I couldn't uncover a trivial solution. I'm not very experienced in this area so I am going to retire this for now until I have time to revisit LTO.

MaskRay added a comment.Sep 7 2021, 8:47 PM

Added EM_HEXAGON in aa4dfba522538019740268bd0c018e1674adb1c9

Revision Contents

PathSize
lld/
ELF/
2 lines

Diff 370974

lld/ELF/InputFiles.cpp

Show First 20 Lines • Show All 1,643 Lines • ▼ Show 20 Lines case Triple::ppc64le:
return EM_PPC64; return EM_PPC64;
case Triple::riscv32: case Triple::riscv32:
case Triple::riscv64: case Triple::riscv64:
return EM_RISCV; return EM_RISCV;
case Triple::x86: case Triple::x86:
return t.isOSIAMCU() ? EM_IAMCU : EM_386; return t.isOSIAMCU() ? EM_IAMCU : EM_386;
case Triple::x86_64: case Triple::x86_64:
return EM_X86_64; return EM_X86_64;
case Triple::hexagon:
return EM_HEXAGON;
default: default:
error(path + ": could not infer e_machine from bitcode target triple " + error(path + ": could not infer e_machine from bitcode target triple " +
t.str()); t.str());
return EM_NONE; return EM_NONE;
} }
} }
static uint8_t getOsAbi(const Triple &t) { static uint8_t getOsAbi(const Triple &t) {
▲ Show 20 Lines • Show All 251 Lines • Show Last 20 Lines