In D97625#3337018, @dmgreen wrote:

Hello. I noticed this was applied to the base /test directory in the llvm repo: https://github.com/llvm/llvm-project/tree/main/test
Was it intended be in clang-tools-extra: https://github.com/llvm/llvm-project/tree/main/clang-tools-extra/test? I'm not sure it will do much where it is.

In D70631#3340840, @Mordante wrote:

Yes please provide a patch, can you supply one to libc++ and one to MSVC STL? Thanks.

This test libcxx/test/std/utilities/charconv/charconv.msvc/test.cpp fails downstream for us w/Hexagon SDK. It's a subtle nit from the compiler regarding format specifiers.

In D118391#3277519, @ldionne wrote:

This kooks sensible to me. I assume this is based on compiling for a funky target and it not working (and this is the fix).

Is this configuration (target, etc.) something we could run in our CI? Like is it possible to run this configuration in a Docker image or something? It would be awesome to have tests for it.

In D111356#3064401, @ldionne wrote:

I haven't seen a lot of discussion on this, either here or on the lists where I posted my RFC. Does this sounds reasonable to you all?

Pinging @tstellar and @bcain in particular because I think they are using standalone builds at the moment, and I want to have their blessing that this is going to work for them. Actually folks, you could move to the new "default" build right away to try it out if you wanted.

Previous upload was a stale patch, sorry!

Updated to address further PRM mismatches.

Updated to remove discrepancies with PRM.

Thanks a lot, Fangrui!

In D109340#2987464, @bcain wrote:

In D109340#2987453, @MaskRay wrote:

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

ok, will do.

In D109340#2987453, @MaskRay wrote:

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

@kparzysz any concerns?

The change LGTM, we may want to fix the error message.

Changed to suggested fix

fixed iserror()

applied clang-format-diff, s/long/u32/ for syscall funcs.

added context

reduced scope to CFI only

Line-wrap update

In D108174#2949827, @vitalybuka wrote:

please drop [PATCH *]

In D108083#2949815, @vitalybuka wrote:

We can help create a bot for hexagon-unknown-linux-musl. What's the process?

Thank you. https://llvm.org/docs/HowToAddABuilder.html

Decomposed to just the sanitizer-common portion. Now it's an 8 patch series, this is number 1.

In D108083#2947914, @vitalybuka wrote:

Do we have public bot for hexagon?

In D108083#2947907, @vitalybuka wrote:

Can you cut this into separate peaces, at least patch per sanitizer for "asan lsan ubsan scudo scudo_standalone cfi safestack"?

Suggestions from Fangrui: override the resource-dir with an explicit arg, disable for windows.

Test case updates per suggestion.

Add a test case, address failing test.

This patch is so far just for discussion, still needs tests, etc. The motivation for this patch is to be able to include the intrinsic header files installed in the resource dir.

In D105218#2867598, @MaskRay wrote:

In D105218#2854082, @MaskRay wrote:

@bcain , could you check whether this addresses the performance issue for you?

@bcain Ping?

LGTM

Removed some unavailable instructions.

Should I clang format the headers? I prefer keeping the historical formatting intact. But if the submission should conform then I suppose I'll just accept the wrapped text suggested by clang-format.

Add hexagon_types.h and additional test cases. Updated existing test case to use types defined in hexagon_types.h.

It occurs to me now that some of these are not very useful in the absence of hexagon_types.h. So I will add that one too and change the tests to use those definitions instead.

In D101068#2718612, @MaskRay wrote:

Yeah, I kinda feel like we are not making good use of the 50 lines of code. .size is too minor a feature that I'd waste 50 lines, adding MCAssembler &Asm, in various places to make this work.
To make good use of the 50 lines, this should be something generic (think as a utility similar to evaluateAsRelocatable), so that every other directive which has similar usage to .size can benefit from this.

In D101068#2714208, @MaskRay wrote:

Is it overkill to add a spell corrector? .size is usually generated by the compiler, so this can only be useful for hand-written assembly. Though I wonder how many times this can be useful.

LGTM. @kparzysz ?

In D84896#2188558, @hgreving wrote:

Tending to push this rel. small fix w/o an explicit Hexagon sign-off. Objections?

I'm troubleshooting a build failure that happens when this commit lands on a downstream builder. The symptom looks similar to the one reported by @aeubanks where the includes aren't present but I've ruled out the EXPERIMENTAL_LIBRARY (explicitly set OFF in the failing build).

updated diff w/context

I created this to make it easier to run builds on systems that have python3 but don't have virtualenv installed. python3 comes with venv.

In D82263#2122860, @bcain wrote:

These tests all seem to fail with

clang-11: error: invalid linker name in argument '-fuse-ld=lld'

AFAICT these tests are all using x86_64 and shouldn't be in scope for this change.

These tests all seem to fail with