User Details
- User Since
- Nov 16 2016, 9:22 PM (357 w, 2 d)
Mon, Sep 18
Aug 20 2023
Aug 18 2023
Aug 3 2023
ping? any concerns about this change?
Aug 1 2023
Changed test to use -Werror -### instead of -fdriver-only -v -Werror.
Jul 31 2023
Jul 26 2023
Too hasty w/the last update - forgot to remove the -###.
I misunderstood the previous suggestion about -fdriver-only -Werror -v and thought I needed to separate the test into two invocations. Combined these back into a single RUN now.
Fixed target: --target=hexagon-unknown-linux was not correct for testing this bug, it should have been --target=hexagon-unknown-linux-musl.
Jun 28 2023
Apr 25 2023
...
But in any case, it seems like that feature is no longer present because stdlib=llvm-libc++ can't distinguish between the one from the build toolchain and the just-built library, right? What's an appropriate/recommended way to make this sort of change?
IIRC, before this change we could use use_system_cxx_lib with LLVM_LIT_ARGS to indicate "do not test the just-built libc++, instead test the libc++ build toolchain's libc++". Perhaps this is what is meant by "back deployment"?
Apr 17 2023
Can you depend on cstdio in an LLVM toolchain test case like this? clang doesn't install cstdio -- does it? This is a c or c++ library file, so I think it should be out of scope for a clang test, right? AFAICT no other clang test uses this header file.
Mar 1 2023
Feb 7 2023
Jan 31 2023
It seems extremely unlikely that this change to target-dependent flags caused this libc++ test failure w/an error referring to partial specialization.
Jan 30 2023
Jan 8 2023
Jan 4 2023
Thanks, Fangrui!
Oct 5 2022
Aug 31 2022
Aug 30 2022
@ldionne do you have an idea when you plan to land this change? I'm pretty sure it won't break our usage but I'd like to test it out to be sure.
Apr 12 2022
Mar 19 2022
Feb 28 2022
Feb 25 2022
Feb 24 2022
Feb 22 2022
This test libcxx/test/std/utilities/charconv/charconv.msvc/test.cpp fails downstream for us w/Hexagon SDK. It's a subtle nit from the compiler regarding format specifiers.
Jan 27 2022
Oct 14 2021
Oct 13 2021
Previous upload was a stale patch, sorry!
Oct 12 2021
Updated to address further PRM mismatches.
Oct 1 2021
Updated to remove discrepancies with PRM.
Sep 8 2021
Thanks a lot, Fangrui!
Sep 7 2021
Sep 6 2021
Sep 3 2021
@kparzysz any concerns?
Sep 1 2021
Aug 26 2021
The change LGTM, we may want to fix the error message.
Aug 19 2021
Changed to suggested fix
Aug 18 2021
Aug 17 2021
fixed iserror()
applied clang-format-diff, s/long/u32/ for syscall funcs.
added context
reduced scope to CFI only
Line-wrap update
Aug 16 2021
Decomposed to just the sanitizer-common portion. Now it's an 8 patch series, this is number 1.
Aug 15 2021
Aug 14 2021
Aug 10 2021
Suggestions from Fangrui: override the resource-dir with an explicit arg, disable for windows.
Aug 9 2021
Test case updates per suggestion.
Aug 5 2021
Add a test case, address failing test.
Jul 26 2021
Jul 23 2021
This patch is so far just for discussion, still needs tests, etc. The motivation for this patch is to be able to include the intrinsic header files installed in the resource dir.
Jul 12 2021
Jul 6 2021
LGTM
Jun 29 2021
Removed some unavailable instructions.
Jun 28 2021
Jun 27 2021
Should I clang format the headers? I prefer keeping the historical formatting intact. But if the submission should conform then I suppose I'll just accept the wrapped text suggested by clang-format.
Add hexagon_types.h and additional test cases. Updated existing test case to use types defined in hexagon_types.h.
Jun 25 2021
It occurs to me now that some of these are not very useful in the absence of hexagon_types.h. So I will add that one too and change the tests to use those definitions instead.