- User Since
- Nov 16 2016, 9:22 PM (229 w, 6 d)
Mar 11 2021
LGTM. @kparzysz ?
Dec 9 2020
Sep 12 2020
Aug 19 2020
I'm troubleshooting a build failure that happens when this commit lands on a downstream builder. The symptom looks similar to the one reported by @aeubanks where the includes aren't present but I've ruled out the EXPERIMENTAL_LIBRARY (explicitly set OFF in the failing build).
Jul 20 2020
Jul 17 2020
Jul 16 2020
updated diff w/context
I created this to make it easier to run builds on systems that have python3 but don't have virtualenv installed. python3 comes with venv.
Jun 30 2020
These tests all seem to fail with
Jun 24 2020
Jun 3 2020
Where can I learn more about the model itself and how it gets feedback? Does this mostly impact target dependent or target independent optimizations? (Sorry for hijacking the review)
May 16 2020
Apr 30 2020
simplified test case
Apr 28 2020
add -march=hexagon to test case
Apr 27 2020
Apr 25 2020
If I apply this patch I am still able to encounter this unreachable during a build. I can share repro details.
Apr 21 2020
Apr 20 2020
LGTM. Tested with Hexagon.
Apr 16 2020
Fixed the expressions in getSectionFlagString() - strings instead of chars, the nulls were the wrong choice.
Apr 15 2020
Apr 13 2020
fix indentation in getSectionFlagString per git-clang-format
Added a getSectionFlagString() function.
Changed section name delimiters in diagnostic to single-quotes
Fixed per review comments: removed superfluous parens around return expression, changed 0x0 to just 0.
Apr 10 2020
removed obsolete/commented-out getIP() implementation
Apr 9 2020
Fix WEAK_ALIAS() definition for hexagon
- Corrected WEAK_ALIAS definition for hexagon
- Removed .size directive from UnwindRegistersRestore.S
Apr 8 2020
- Remove encoding == DW_EH_PE_omit guard from getEncodedP()
- Remove hexagon changes from findFDE()
- Fix hexagon unw_getcontext definition, declaration in UnwindRegistersSave.S
Apr 7 2020
Apr 6 2020
Apr 2 2020
Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?
Apr 1 2020
Omitted out-of-scope change to benchmark's cycleclock.h
Mar 31 2020
This is my first change to the test-suite, let me know if I'm doing this right. :)
Accidentally omitted context lines w/previous patch
Mar 30 2020
Mar 27 2020
Mar 26 2020
Mar 25 2020
Mar 24 2020
Seems like we might want a new test case for this?
Mar 23 2020
Mar 18 2020
Mar 13 2020
This change seemed inocent enough. Were the false values here the right defaults?
Mar 12 2020
Mar 11 2020
@kparzysz do you have any thoughts about those review comments?
Mar 9 2020
In general, I recommend qualifying metric and threshold values with their associated units: bits, bytes, pages, etc. That way it's easy to see where the unit conversions are happening and easy to see whether the logic is correct without reasoning about how the value changes among lines.
Mar 6 2020
Mar 5 2020
Feb 27 2020
Feb 25 2020
I believe this test failure is unrelated to the change in question and brought it up on llvm-dev/libcxx-dev.
Feb 24 2020
Feb 18 2020
Feb 14 2020
Add ## for the comments in the new test cases.
Feb 13 2020
Ping - any questions/suggestions about this patch?