Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

bcain (Brian Cain)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 16 2016, 9:22 PM (357 w, 2 d)

Recent Activity

Mon, Sep 18

bcain added inline comments to D100005: [libc++] Use the default initializer for char_type in std::num_get::do_get..
Mon, Sep 18, 7:39 AM · Restricted Project, Restricted Project

Aug 20 2023

bcain added inline comments to D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX.
Aug 20 2023, 6:01 PM · Restricted Project, Restricted Project

Aug 18 2023

bcain added inline comments to D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX.
Aug 18 2023, 12:43 PM · Restricted Project, Restricted Project
bcain added inline comments to D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX.
Aug 18 2023, 12:12 PM · Restricted Project, Restricted Project

Aug 3 2023

bcain added a comment to D156771: [clang][hexagon] Handle library path arguments earlier.

ping? any concerns about this change?

Aug 3 2023, 7:21 PM · Restricted Project, Restricted Project

Aug 1 2023

bcain updated the diff for D156771: [clang][hexagon] Handle library path arguments earlier.

Changed test to use -Werror -### instead of -fdriver-only -v -Werror.

Aug 1 2023, 9:53 PM · Restricted Project, Restricted Project
bcain added a reviewer for D156771: [clang][hexagon] Handle library path arguments earlier: steplong.
Aug 1 2023, 3:46 PM · Restricted Project, Restricted Project

Jul 31 2023

bcain requested review of D156771: [clang][hexagon] Handle library path arguments earlier.
Jul 31 2023, 7:54 PM · Restricted Project, Restricted Project

Jul 26 2023

bcain updated the diff for D156330: [hexagon] restore library path arguments.

Too hasty w/the last update - forgot to remove the -###.

Jul 26 2023, 3:01 PM · Restricted Project, Restricted Project
bcain updated the diff for D156330: [hexagon] restore library path arguments.

I misunderstood the previous suggestion about -fdriver-only -Werror -v and thought I needed to separate the test into two invocations. Combined these back into a single RUN now.

Jul 26 2023, 2:59 PM · Restricted Project, Restricted Project
bcain updated the diff for D156330: [hexagon] restore library path arguments.

Fixed target: --target=hexagon-unknown-linux was not correct for testing this bug, it should have been --target=hexagon-unknown-linux-musl.

Jul 26 2023, 2:52 PM · Restricted Project, Restricted Project
bcain added a comment to D156330: [hexagon] restore library path arguments.

Tip: use %clang -fdriver-only -Werror -v to test that a command produces no warning or error and has an exit code of 0. Without it your Args.ClaimAllArgs(options::OPT_L); change is untested.

Jul 26 2023, 2:20 PM · Restricted Project, Restricted Project
bcain requested review of D156330: [hexagon] restore library path arguments.
Jul 26 2023, 6:42 AM · Restricted Project, Restricted Project

Jun 28 2023

bcain accepted D150287: [Hexagon] Flip subreg bit for reverse pairs hvx .new.
Jun 28 2023, 12:25 PM · Restricted Project, Restricted Project

Apr 25 2023

bcain added a comment to D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.

...

But in any case, it seems like that feature is no longer present because stdlib=llvm-libc++ can't distinguish between the one from the build toolchain and the just-built library, right? What's an appropriate/recommended way to make this sort of change?

Apr 25 2023, 10:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bcain added a comment to D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.

IIRC, before this change we could use use_system_cxx_lib with LLVM_LIT_ARGS to indicate "do not test the just-built libc++, instead test the libc++ build toolchain's libc++". Perhaps this is what is meant by "back deployment"?

Apr 25 2023, 10:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 17 2023

bcain added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

Can you depend on cstdio in an LLVM toolchain test case like this? clang doesn't install cstdio -- does it? This is a c or c++ library file, so I think it should be out of scope for a clang test, right? AFAICT no other clang test uses this header file.

Apr 17 2023, 9:14 AM · Restricted Project, Restricted Project

Mar 1 2023

bcain accepted D145050: [NFC] Fix incorrect comment in VLIW packetizer.
Mar 1 2023, 4:59 AM · Restricted Project, Restricted Project

Feb 7 2023

bcain requested review of D143531: [hexagon] Turning off sign mismatch warning by default..
Feb 7 2023, 3:43 PM · Restricted Project, Restricted Project

Jan 31 2023

bcain accepted D142251: [Hexagon] Disallow using the same register for Vy/Vx in vdeal/vshuff.
Jan 31 2023, 4:57 PM · Restricted Project, Restricted Project
bcain updated subscribers of D142947: [hexagon] add a -mcabac flag.

It seems extremely unlikely that this change to target-dependent flags caused this libc++ test failure w/an error referring to partial specialization.

Jan 31 2023, 9:00 AM · Restricted Project, Restricted Project

Jan 30 2023

bcain requested review of D142947: [hexagon] add a -mcabac flag.
Jan 30 2023, 6:31 PM · Restricted Project, Restricted Project

Jan 8 2023

bcain added a comment to rGc172726f6f14: [compiler-rt] Add hexagon support to CFI.

Does check-cfi actually work on Hexagon? If no, this change is not appropriate...

Jan 8 2023, 5:21 PM

Jan 4 2023

bcain added a comment to rG27751bed60bc: [XRay] Fix Hexagon sled version.

Thanks, Fangrui!

Jan 4 2023, 2:01 PM · Restricted Project, Restricted Project

Oct 5 2022

bcain requested review of D135325: [CMake] cmake cache for hexagon libc++{,abi} + libunwind.
Oct 5 2022, 3:08 PM · Restricted Project, Restricted Project

Aug 31 2022

bcain added a comment to D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.

@ldionne do you have an idea when you plan to land this change? I'm pretty sure it won't break our usage but I'd like to test it out to be sure.

I don't see any LLVM_ENABLE_PROJECTS (beyond clang+lld) - only LLVM_ENABLE_RUNTIMES so I think we're ok.

https://github.com/quic/toolchain_for_hexagon/blob/29a926ac283a4afb9dc4d5ae4a0f2c18b6649243/build-toolchain.sh

Aug 31 2022, 5:48 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

bcain added a comment to D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.

@ldionne do you have an idea when you plan to land this change? I'm pretty sure it won't break our usage but I'd like to test it out to be sure.

Aug 30 2022, 9:14 PM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

bcain added a reviewer for D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC: sidneym.
Apr 12 2022, 7:53 PM · Restricted Project, Restricted Project

Mar 19 2022

Herald added a project to D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings: Restricted Project.

Hello. I noticed this was applied to the base /test directory in the llvm repo: https://github.com/llvm/llvm-project/tree/main/test
Was it intended be in clang-tools-extra: https://github.com/llvm/llvm-project/tree/main/clang-tools-extra/test? I'm not sure it will do much where it is.

Mar 19 2022, 9:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

bcain updated the diff for D120532: [libcxx] Make format specifiers more portable.
Feb 28 2022, 10:52 AM · Restricted Project

Feb 25 2022

bcain updated subscribers of D120532: [libcxx] Make format specifiers more portable.
Feb 25 2022, 1:38 PM · Restricted Project

Feb 24 2022

bcain requested review of D120532: [libcxx] Make format specifiers more portable.
Feb 24 2022, 8:21 PM · Restricted Project
bcain added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

Yes please provide a patch, can you supply one to libc++ and one to MSVC STL? Thanks.

Feb 24 2022, 10:04 AM · Restricted Project

Feb 22 2022

bcain added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

This test libcxx/test/std/utilities/charconv/charconv.msvc/test.cpp fails downstream for us w/Hexagon SDK. It's a subtle nit from the compiler regarding format specifiers.

Feb 22 2022, 7:34 AM · Restricted Project

Jan 27 2022

bcain added a comment to D118391: Omit atomic_{,un}signed_lock_free if unsupported.

This kooks sensible to me. I assume this is based on compiling for a funky target and it not working (and this is the fix).

Is this configuration (target, etc.) something we could run in our CI? Like is it possible to run this configuration in a Docker image or something? It would be awesome to have tests for it.

Jan 27 2022, 2:27 PM · Restricted Project
bcain requested review of D118391: Omit atomic_{,un}signed_lock_free if unsupported.
Jan 27 2022, 9:20 AM · Restricted Project

Oct 14 2021

bcain added a comment to D111356: [runtimes] Use the new "runtimes" build by default and deprecate other builds.

I haven't seen a lot of discussion on this, either here or on the lists where I posted my RFC. Does this sounds reasonable to you all?

Pinging @tstellar and @bcain in particular because I think they are using standalone builds at the moment, and I want to have their blessing that this is going to work for them. Actually folks, you could move to the new "default" build right away to try it out if you wanted.

Oct 14 2021, 2:25 PM · Restricted Project, Restricted Project

Oct 13 2021

bcain updated the diff for D109117: [hexagon] Add system register, transfer support.

Previous upload was a stale patch, sorry!

Oct 13 2021, 9:39 AM · Restricted Project

Oct 12 2021

bcain updated the diff for D109117: [hexagon] Add system register, transfer support.

Updated to address further PRM mismatches.

Oct 12 2021, 7:37 PM · Restricted Project

Oct 1 2021

bcain updated the diff for D109117: [hexagon] Add system register, transfer support.

Updated to remove discrepancies with PRM.

Oct 1 2021, 7:50 PM · Restricted Project

Sep 8 2021

bcain added a comment to rGaa4dfba52253: [ELF] Infer EM_HEXAGON in getBitcodeMachineKind.

Thanks a lot, Fangrui!

Sep 8 2021, 7:05 AM

Sep 7 2021

bcain abandoned D109340: [lld] Add bitcode->e_machine mapping for hexagon.

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

ok, will do.

Sep 7 2021, 7:42 PM · Restricted Project, lld
bcain added a comment to D109340: [lld] Add bitcode->e_machine mapping for hexagon.

Sorry, lto/aarch64.ll is a better one.

I'll fix riscv64.ll

Sep 7 2021, 11:22 AM · Restricted Project, lld

Sep 6 2021

bcain requested review of D109340: [lld] Add bitcode->e_machine mapping for hexagon.
Sep 6 2021, 5:17 PM · Restricted Project, lld

Sep 3 2021

bcain added a comment to D109117: [hexagon] Add system register, transfer support.

@kparzysz any concerns?

Sep 3 2021, 2:29 PM · Restricted Project

Sep 1 2021

bcain requested review of D109117: [hexagon] Add system register, transfer support.
Sep 1 2021, 5:56 PM · Restricted Project

Aug 26 2021

bcain accepted D108769: [lld][Hexagon] Add checks for instructions that can have TLS relocations.
Aug 26 2021, 8:13 PM · Restricted Project
bcain added a comment to D108769: [lld][Hexagon] Add checks for instructions that can have TLS relocations.

The change LGTM, we may want to fix the error message.

Aug 26 2021, 9:48 AM · Restricted Project

Aug 19 2021

bcain updated the diff for D108175: [sanitizer] Fix for CMAKE_CXX_FLAGS update.

Changed to suggested fix

Aug 19 2021, 6:28 AM · Restricted Project

Aug 18 2021

bcain retitled D108175: [sanitizer] Fix for CMAKE_CXX_FLAGS update from [PATCH 5/8] [sanitizer] Fix for CMAKE_CXX_FLAGS update to [sanitizer] Fix for CMAKE_CXX_FLAGS update.
Aug 18 2021, 4:05 PM · Restricted Project
bcain reclaimed D108175: [sanitizer] Fix for CMAKE_CXX_FLAGS update.
Aug 18 2021, 6:13 AM · Restricted Project

Aug 17 2021

bcain added inline comments to D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 17 2021, 3:00 PM · Restricted Project, Restricted Project
bcain updated the diff for D108083: [sanitizer] Add hexagon support to sanitizer-common.

fixed iserror()

Aug 17 2021, 3:00 PM · Restricted Project, Restricted Project
bcain updated the diff for D108083: [sanitizer] Add hexagon support to sanitizer-common.

applied clang-format-diff, s/long/u32/ for syscall funcs.

Aug 17 2021, 2:42 PM · Restricted Project, Restricted Project
bcain added inline comments to D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 17 2021, 2:27 PM · Restricted Project, Restricted Project
bcain updated the diff for D108083: [sanitizer] Add hexagon support to sanitizer-common.

added context

Aug 17 2021, 2:10 PM · Restricted Project, Restricted Project
bcain retitled D108172: [sanitizer] Add hexagon support to asan from [PATCH 3/8] [sanitizer] Add hexagon support to asan to [sanitizer] Add hexagon support to asan.
Aug 17 2021, 1:15 PM · Restricted Project
bcain retitled D108176: [sanitizer] Add hexagon support to scudo from [PATCH 6/8] [sanitizer] Add hexagon support to scudo to [sanitizer] Add hexagon support to scudo.
Aug 17 2021, 1:15 PM · Restricted Project
bcain retitled D108174: [sanitizer] Add hexagon support to ubsan from [PATCH 4/8] [sanitizer] Add hexagon support to ubsan to [sanitizer] Add hexagon support to ubsan.
Aug 17 2021, 1:01 PM · Restricted Project
bcain updated the diff for D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 17 2021, 12:59 PM · Restricted Project, Restricted Project
bcain requested review of D108236: [compiler-rt] Add hexagon support to profile.
Aug 17 2021, 12:58 PM · Restricted Project
bcain requested review of D108234: [compiler-rt] Add hexagon support to safestack.
Aug 17 2021, 12:57 PM · Restricted Project
bcain updated the diff for D108177: [compiler-rt] Add hexagon support to CFI.

reduced scope to CFI only

Aug 17 2021, 12:55 PM · Restricted Project
bcain updated the diff for D108171: [sanitizer] Add hexagon support to lsan.

Line-wrap update

Aug 17 2021, 12:52 PM · Restricted Project
bcain abandoned D108175: [sanitizer] Fix for CMAKE_CXX_FLAGS update.
Aug 17 2021, 11:58 AM · Restricted Project
bcain retitled D108177: [compiler-rt] Add hexagon support to CFI from [PATCH 7/8] [compiler-rt] Add cfi, safestack, profile to hexagon to [compiler-rt] Add cfi, safestack, profile to hexagon.
Aug 17 2021, 11:13 AM · Restricted Project
bcain retitled D108083: [sanitizer] Add hexagon support to sanitizer-common from [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common to [sanitizer] Add hexagon support to sanitizer-common.
Aug 17 2021, 11:12 AM · Restricted Project, Restricted Project
bcain added inline comments to D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 17 2021, 10:48 AM · Restricted Project, Restricted Project
bcain added a comment to D108174: [sanitizer] Add hexagon support to ubsan.

please drop [PATCH *]

Aug 17 2021, 10:41 AM · Restricted Project
bcain added a comment to D108083: [sanitizer] Add hexagon support to sanitizer-common.

We can help create a bot for hexagon-unknown-linux-musl. What's the process?

Thank you. https://llvm.org/docs/HowToAddABuilder.html

Aug 17 2021, 10:39 AM · Restricted Project, Restricted Project

Aug 16 2021

bcain requested review of D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon.
Aug 16 2021, 5:58 PM · Restricted Project
bcain requested review of D108177: [compiler-rt] Add hexagon support to CFI.
Aug 16 2021, 5:56 PM · Restricted Project
bcain requested review of D108176: [sanitizer] Add hexagon support to scudo.
Aug 16 2021, 5:55 PM · Restricted Project
bcain retitled D108172: [sanitizer] Add hexagon support to asan from [sanitizer] Add hexagon support to asan to [PATCH 3/8] [sanitizer] Add hexagon support to asan.
Aug 16 2021, 5:50 PM · Restricted Project
bcain retitled D108171: [sanitizer] Add hexagon support to lsan from [sanitizer] Add hexagon support to lsan to [PATCH 2/8] [sanitizer] Add hexagon support to lsan.
Aug 16 2021, 5:50 PM · Restricted Project
bcain retitled D108083: [sanitizer] Add hexagon support to sanitizer-common from [PATCH 5/8] [sanitizer] Add hexagon support to sanitizer-common to [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common.
Aug 16 2021, 5:48 PM · Restricted Project, Restricted Project
bcain retitled D108083: [sanitizer] Add hexagon support to sanitizer-common from [sanitizer] Add hexagon support to sanitizer-common (1/8) to [PATCH 5/8] [sanitizer] Add hexagon support to sanitizer-common.
Aug 16 2021, 5:48 PM · Restricted Project, Restricted Project
bcain requested review of D108175: [sanitizer] Fix for CMAKE_CXX_FLAGS update.
Aug 16 2021, 5:42 PM · Restricted Project
bcain requested review of D108174: [sanitizer] Add hexagon support to ubsan.
Aug 16 2021, 5:37 PM · Restricted Project
bcain requested review of D108172: [sanitizer] Add hexagon support to asan.
Aug 16 2021, 5:10 PM · Restricted Project
bcain requested review of D108171: [sanitizer] Add hexagon support to lsan.
Aug 16 2021, 5:08 PM · Restricted Project
bcain updated the diff for D108083: [sanitizer] Add hexagon support to sanitizer-common.

Decomposed to just the sanitizer-common portion. Now it's an 8 patch series, this is number 1.

Aug 16 2021, 5:07 PM · Restricted Project, Restricted Project
bcain added a comment to D108083: [sanitizer] Add hexagon support to sanitizer-common.

Do we have public bot for hexagon?

Aug 16 2021, 3:36 PM · Restricted Project, Restricted Project
bcain added a comment to D108083: [sanitizer] Add hexagon support to sanitizer-common.

Can you cut this into separate peaces, at least patch per sanitizer for "asan lsan ubsan scudo scudo_standalone cfi safestack"?

Aug 16 2021, 3:33 PM · Restricted Project, Restricted Project

Aug 15 2021

bcain added inline comments to D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 15 2021, 3:00 PM · Restricted Project, Restricted Project
bcain retitled D108083: [sanitizer] Add hexagon support to sanitizer-common from [DRAFT] add sanitizer support to hexagon to add sanitizer support to hexagon.
Aug 15 2021, 2:56 PM · Restricted Project, Restricted Project

Aug 14 2021

bcain requested review of D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 14 2021, 11:39 PM · Restricted Project, Restricted Project

Aug 10 2021

bcain updated the diff for D106737: [clang] [hexagon] Add resource include dir.

Suggestions from Fangrui: override the resource-dir with an explicit arg, disable for windows.

Aug 10 2021, 6:37 AM · Restricted Project

Aug 9 2021

bcain updated the diff for D106737: [clang] [hexagon] Add resource include dir.

Test case updates per suggestion.

Aug 9 2021, 9:27 PM · Restricted Project

Aug 5 2021

bcain updated the diff for D106737: [clang] [hexagon] Add resource include dir.

Add a test case, address failing test.

Aug 5 2021, 5:41 PM · Restricted Project

Jul 26 2021

bcain added inline comments to D106737: [clang] [hexagon] Add resource include dir.
Jul 26 2021, 9:59 PM · Restricted Project

Jul 23 2021

bcain added a comment to D106737: [clang] [hexagon] Add resource include dir.

This patch is so far just for discussion, still needs tests, etc. The motivation for this patch is to be able to include the intrinsic header files installed in the resource dir.

Jul 23 2021, 9:03 PM · Restricted Project
bcain requested review of D106737: [clang] [hexagon] Add resource include dir.
Jul 23 2021, 9:00 PM · Restricted Project

Jul 12 2021

bcain added a comment to D105218: [llvm-objcopy] Improve performance of long pattern lists.

@bcain , could you check whether this addresses the performance issue for you?

@bcain Ping?

Jul 12 2021, 8:05 AM · Restricted Project

Jul 6 2021

bcain accepted D50524: [Hexagon] Generate trap/undef if misaligned access is detected.

LGTM

Jul 6 2021, 8:40 AM · Restricted Project

Jun 29 2021

bcain updated the diff for D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}.

Removed some unavailable instructions.

Jun 29 2021, 7:39 AM · Restricted Project

Jun 28 2021

bcain added inline comments to D50524: [Hexagon] Generate trap/undef if misaligned access is detected.
Jun 28 2021, 7:43 PM · Restricted Project

Jun 27 2021

bcain added a comment to D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}.

Should I clang format the headers? I prefer keeping the historical formatting intact. But if the submission should conform then I suppose I'll just accept the wrapped text suggested by clang-format.

Jun 27 2021, 10:20 PM · Restricted Project
bcain updated the diff for D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}.

Add hexagon_types.h and additional test cases. Updated existing test case to use types defined in hexagon_types.h.

Jun 27 2021, 10:21 AM · Restricted Project

Jun 25 2021

bcain added a comment to D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}.

It occurs to me now that some of these are not very useful in the absence of hexagon_types.h. So I will add that one too and change the tests to use those definitions instead.

Jun 25 2021, 3:41 PM · Restricted Project