Page MenuHomePhabricator

sidneym (Sid Manning)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2014, 1:57 PM (252 w, 3 d)

Recent Activity

May 8 2019

sidneym accepted D61130: [llvm-mc] Add reportWarning() to MCContext.

LGTM

May 8 2019, 8:11 AM · Restricted Project, Restricted Project

May 3 2019

sidneym committed rG5ad18a7d5941: Let --discard-all imply --strip-debug. (authored by sidneym).
Let --discard-all imply --strip-debug.
May 3 2019, 7:12 AM
sidneym committed rL359887: Let --discard-all imply --strip-debug..
Let --discard-all imply --strip-debug.
May 3 2019, 7:12 AM
sidneym closed D61092: [llvm-strip] Have --discard-all imply --strip-debug.
May 3 2019, 7:12 AM · Restricted Project

May 1 2019

sidneym accepted D61309: [clang] Add no-warn support for Wa.
May 1 2019, 12:18 PM · Restricted Project

Apr 26 2019

sidneym updated the diff for D61092: [llvm-strip] Have --discard-all imply --strip-debug.

Make llvm-objcopy behave the same way strip does wrt --discard-all. Update testcase

Apr 26 2019, 12:26 PM · Restricted Project
sidneym added inline comments to D61092: [llvm-strip] Have --discard-all imply --strip-debug.
Apr 26 2019, 12:21 PM · Restricted Project

Apr 25 2019

sidneym updated the diff for D61092: [llvm-strip] Have --discard-all imply --strip-debug.

Update testcase.

Apr 25 2019, 9:45 AM · Restricted Project
sidneym added inline comments to D61092: [llvm-strip] Have --discard-all imply --strip-debug.
Apr 25 2019, 7:32 AM · Restricted Project

Apr 24 2019

sidneym added a reviewer for D61092: [llvm-strip] Have --discard-all imply --strip-debug: bcain.
Apr 24 2019, 2:06 PM · Restricted Project
sidneym created D61092: [llvm-strip] Have --discard-all imply --strip-debug.
Apr 24 2019, 2:04 PM · Restricted Project

Apr 16 2019

sidneym added inline comments to D60376: [llvm-objdump] Align instructions to a tab stop in disassembly output.
Apr 16 2019, 9:07 AM · Restricted Project

Apr 10 2019

sidneym added a comment to D50254: [RFC] Add GDB remote packet reproducer..

I'm having some trouble with the test case. Based on the initialization code I assume I'm not supposed to destroy the SBDebugger singleton shared by the LLDB test suite. If I do it anyway the test crashes with the an exception:

libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: recursive_mutex lock failed: Invalid argument
Apr 10 2019, 9:23 AM

Feb 1 2019

sidneym committed rL352900: [llvm-objdump] - llvm-objdump can skip bytes at the end of a section..
[llvm-objdump] - llvm-objdump can skip bytes at the end of a section.
Feb 1 2019, 11:11 AM
sidneym closed D57549: [llvm-objdump] - llvm-objdump can miss printing bytes at the end of a section..
Feb 1 2019, 11:11 AM · Restricted Project
sidneym updated the diff for D57549: [llvm-objdump] - llvm-objdump can miss printing bytes at the end of a section..

Updated the testcase.

Feb 1 2019, 7:42 AM · Restricted Project

Jan 31 2019

sidneym created D57549: [llvm-objdump] - llvm-objdump can miss printing bytes at the end of a section..
Jan 31 2019, 2:49 PM · Restricted Project

Jan 16 2019

sidneym accepted D56808: [llvm-readobj] Fix hexdump test.
Jan 16 2019, 4:07 PM
sidneym added a comment to D56369: [SanitizerCoverage][NFC] Use appendToUsed instead of include.

Unrelated to this change, I made an error in my commit message for: r351356
referring to this review instead of https://reviews.llvm.org/D56726. Sorry for any confusion this may cause.

Jan 16 2019, 8:32 AM
sidneym closed D56726: Include section start address when dumping hexadecimal output of a section, -x option.q.

I made an error in the commit message, referring to: https://reviews.llvm.org/D56369 instead of this URL: https://reviews.llvm.org/D56726

Jan 16 2019, 8:30 AM
sidneym committed rL351356: [llvm-readobj] Set correct offset when dumping hex section output..
[llvm-readobj] Set correct offset when dumping hex section output.
Jan 16 2019, 8:21 AM
sidneym added a comment to D56726: Include section start address when dumping hexadecimal output of a section, -x option.q.

Yes, Section.getAddress() returns zero for object files.

Jan 16 2019, 8:18 AM

Jan 15 2019

sidneym updated the diff for D56726: Include section start address when dumping hexadecimal output of a section, -x option.q.

Include full context

Jan 15 2019, 9:13 AM
sidneym added reviewers for D56726: Include section start address when dumping hexadecimal output of a section, -x option.q: bcain, kparzysz.
Jan 15 2019, 8:27 AM
sidneym created D56726: Include section start address when dumping hexadecimal output of a section, -x option.q.
Jan 15 2019, 8:09 AM

Dec 12 2018

sidneym added a comment to D55329: [llvm-readobj] Little clean up inside `parseDynamicTable`.

FWIW: The check you mention in ELF.cpp is triggered by the following test script. This causes llvm-readelf to generate an unexpected error message, LLVM ERROR: Virtual address is not in any segment

Dec 12 2018, 3:06 PM

Dec 11 2018

sidneym committed rL348859: [llvm-readelf] Add -e/--headers support to readobj/elf.
[llvm-readelf] Add -e/--headers support to readobj/elf
Dec 11 2018, 8:18 AM
sidneym closed D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.
Dec 11 2018, 8:18 AM

Dec 7 2018

sidneym updated the diff for D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.

Output each option test result to different files and verify that each of the files contains identical content.

Dec 7 2018, 9:24 AM

Dec 6 2018

sidneym updated the diff for D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.

Updated the patch to include full context.

Dec 6 2018, 8:12 AM
sidneym added a comment to D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.

Full context? I use git format-patch -1 and upload the file it produces.

Dec 6 2018, 5:57 AM

Dec 5 2018

sidneym updated the diff for D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.
Dec 5 2018, 8:55 AM
sidneym added inline comments to D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.
Dec 5 2018, 8:41 AM

Dec 4 2018

sidneym updated the diff for D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.

Change JustHeaders to AllHeaders

Dec 4 2018, 3:39 PM
sidneym created D55298: [llvm-readelf] Add -e/--headers support to readobj/elf.
Dec 4 2018, 2:53 PM

Oct 16 2018

sidneym created D53327: [Hexagon] Use -fuse-ld update checks..
Oct 16 2018, 9:13 AM

Oct 15 2018

sidneym committed rL344518: [ELF][HEXAGON] Let input determine e_flag..
[ELF][HEXAGON] Let input determine e_flag.
Oct 15 2018, 7:47 AM
sidneym committed rLLD344518: [ELF][HEXAGON] Let input determine e_flag..
[ELF][HEXAGON] Let input determine e_flag.
Oct 15 2018, 7:46 AM
sidneym closed D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.
Oct 15 2018, 7:46 AM

Oct 14 2018

sidneym updated the diff for D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.

Add testcase

Oct 14 2018, 6:35 PM
sidneym added a comment to D53249: Force Hexagon to use default (hexagon-link) linker.

https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I merged that change earlier today. I can change the test to pass -fuse-ld, let me know. Thanks,

Oct 14 2018, 6:12 PM
sidneym committed rC344482: [Hexagon] Update tests account for non-hardcoded linker name..
[Hexagon] Update tests account for non-hardcoded linker name.
Oct 14 2018, 10:54 AM
sidneym committed rL344482: [Hexagon] Update tests account for non-hardcoded linker name..
[Hexagon] Update tests account for non-hardcoded linker name.
Oct 14 2018, 10:53 AM
sidneym closed D53219: Update hexagon driver tests.
Oct 14 2018, 10:53 AM

Oct 12 2018

sidneym updated the diff for D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.

Update following Rui's suggestions.

Oct 12 2018, 2:50 PM
sidneym added a comment to D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name..

I updated the tests: https://reviews.llvm.org/D53219

Oct 12 2018, 2:29 PM
sidneym created D53219: Update hexagon driver tests.
Oct 12 2018, 2:28 PM
sidneym added a comment to D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name..

Seems like the test cases do not consider the possibility of CLANG_DEFAULT_LINKER being set. If CLANG_DEFAULT_LINKER was set to "hexagon-link" these tests would probably pass.

Oct 12 2018, 10:34 AM
sidneym added reviewers for D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags: ruiu, shankare, kparzysz, bcain.
Oct 12 2018, 9:46 AM
sidneym created D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.
Oct 12 2018, 9:45 AM

Oct 10 2018

sidneym committed rL344147: [Hexagon] Use GetLinkerPath instead of hard-coded string..
[Hexagon] Use GetLinkerPath instead of hard-coded string.
Oct 10 2018, 8:41 AM
sidneym committed rC344147: [Hexagon] Use GetLinkerPath instead of hard-coded string..
[Hexagon] Use GetLinkerPath instead of hard-coded string.
Oct 10 2018, 8:41 AM
sidneym closed D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name..
Oct 10 2018, 8:41 AM

Oct 9 2018

sidneym created D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name..
Oct 9 2018, 1:21 PM

Oct 8 2018

sidneym added a comment to D52909: Add R_HEX_GOT_16_X support.

No this isn't, I'd like to add TLS support. I'm also sure some additional relocations will be required (beyond the TLS ones).

Oct 8 2018, 11:32 AM
sidneym committed rLLD343972: [ELF][HEXAGON] Add R_HEX_GOT_16_X support.
[ELF][HEXAGON] Add R_HEX_GOT_16_X support
Oct 8 2018, 8:38 AM
sidneym committed rL343972: [ELF][HEXAGON] Add R_HEX_GOT_16_X support.
[ELF][HEXAGON] Add R_HEX_GOT_16_X support
Oct 8 2018, 8:34 AM
sidneym closed D52909: Add R_HEX_GOT_16_X support.
Oct 8 2018, 8:34 AM

Oct 4 2018

sidneym created D52909: Add R_HEX_GOT_16_X support.
Oct 4 2018, 3:25 PM
sidneym committed rLLD343784: [ELF][HEXAGON] Add support for GOT relocations..
[ELF][HEXAGON] Add support for GOT relocations.
Oct 4 2018, 7:56 AM
sidneym committed rL343784: [ELF][HEXAGON] Add support for GOT relocations..
[ELF][HEXAGON] Add support for GOT relocations.
Oct 4 2018, 7:56 AM
sidneym closed D52744: Add support for GOT relocation support to Hexagon.
Oct 4 2018, 7:56 AM

Oct 2 2018

sidneym added a comment to D52744: Add support for GOT relocation support to Hexagon.

This is the link:
https://developer.qualcomm.com/download/hexagon/hexagon-application-binary-interface-specification.zip

Oct 2 2018, 9:48 AM
sidneym added inline comments to D52744: Add support for GOT relocation support to Hexagon.
Oct 2 2018, 8:06 AM

Oct 1 2018

sidneym created D52744: Add support for GOT relocation support to Hexagon.
Oct 1 2018, 1:32 PM
sidneym committed rL343515: [ELF] [HEXAGON] Add support for PLT_B22_PCREL and HEX_32_PCREL.
[ELF] [HEXAGON] Add support for PLT_B22_PCREL and HEX_32_PCREL
Oct 1 2018, 11:29 AM
sidneym committed rLLD343515: [ELF] [HEXAGON] Add support for PLT_B22_PCREL and HEX_32_PCREL.
[ELF] [HEXAGON] Add support for PLT_B22_PCREL and HEX_32_PCREL
Oct 1 2018, 11:29 AM
sidneym closed D52734: Add R_HEX_PLT_B22_PCREL and R_HEX_32_PCREL relocation support.
Oct 1 2018, 11:29 AM
sidneym created D52734: Add R_HEX_PLT_B22_PCREL and R_HEX_32_PCREL relocation support.
Oct 1 2018, 10:11 AM

Sep 28 2018

sidneym committed rLLD343320: [ELF][HEXAGON] Add support for dynamic libraries.
[ELF][HEXAGON] Add support for dynamic libraries
Sep 28 2018, 7:11 AM
sidneym committed rL343320: [ELF][HEXAGON] Add support for dynamic libraries.
[ELF][HEXAGON] Add support for dynamic libraries
Sep 28 2018, 7:11 AM
sidneym closed D52317: Add support for dynamic libraries on Hexagon.
Sep 28 2018, 7:10 AM

Sep 27 2018

sidneym added inline comments to D52317: Add support for dynamic libraries on Hexagon.
Sep 27 2018, 2:21 PM
sidneym added inline comments to D52317: Add support for dynamic libraries on Hexagon.
Sep 27 2018, 12:57 PM
sidneym updated the diff for D52317: Add support for dynamic libraries on Hexagon.

Remove the blank line
Put a trap into the gap between the PLT header and plt0.
Update testcase

Sep 27 2018, 12:47 PM
sidneym added inline comments to D52317: Add support for dynamic libraries on Hexagon.
Sep 27 2018, 12:39 PM
sidneym added inline comments to D52317: Add support for dynamic libraries on Hexagon.
Sep 27 2018, 12:38 PM
sidneym updated the diff for D52317: Add support for dynamic libraries on Hexagon.

Swap zero pad with nop insn pad.
Reduce the padding but still bring plt0 to a 16byte alignment. There was no obvious reason for the additional padding and it is not part of the ABI.

Sep 27 2018, 12:34 PM

Sep 26 2018

sidneym updated the diff for D52317: Add support for dynamic libraries on Hexagon.

Adds a PLT header.
Fixes formatting issue.

Sep 26 2018, 4:30 PM

Sep 20 2018

sidneym added inline comments to D52317: Add support for dynamic libraries on Hexagon.
Sep 20 2018, 7:19 PM
sidneym added inline comments to D52317: Add support for dynamic libraries on Hexagon.
Sep 20 2018, 7:00 PM
sidneym closed D52309: Set Hexagon's DefaultMaxPageSize to 64K.
Sep 20 2018, 1:23 PM
sidneym created D52317: Add support for dynamic libraries on Hexagon.
Sep 20 2018, 11:26 AM
sidneym committed rLLD342662: [ELF][HEXAGON] Set DefaultMaxPageSize to 64K.
[ELF][HEXAGON] Set DefaultMaxPageSize to 64K
Sep 20 2018, 9:37 AM
sidneym committed rL342662: [ELF][HEXAGON] Set DefaultMaxPageSize to 64K.
[ELF][HEXAGON] Set DefaultMaxPageSize to 64K
Sep 20 2018, 9:37 AM
sidneym created D52309: Set Hexagon's DefaultMaxPageSize to 64K.
Sep 20 2018, 8:38 AM

Sep 7 2018

sidneym committed rL341658: Add support for getRegisterByName..
Add support for getRegisterByName.
Sep 7 2018, 6:37 AM
sidneym closed D51363: Add support for getRegisterByName..
Sep 7 2018, 6:37 AM

Sep 4 2018

sidneym accepted D51363: Add support for getRegisterByName..
Sep 4 2018, 9:15 AM
sidneym updated the diff for D51363: Add support for getRegisterByName..
Sep 4 2018, 9:12 AM
sidneym reopened D51363: Add support for getRegisterByName..

Hexagon only supports named register, r19.

Sep 4 2018, 8:44 AM

Sep 3 2018

sidneym committed rL341331: Revert [Hexagon] Add support for getRegisterByName..
Revert [Hexagon] Add support for getRegisterByName.
Sep 3 2018, 11:00 AM
sidneym added a comment to rL341238: [Hexagon] Add support for getRegisterByName..

OK I will temporarily disable the test and tack down the cause.

Sep 3 2018, 10:44 AM

Aug 31 2018

sidneym committed rL341238: [Hexagon] Add support for getRegisterByName..
[Hexagon] Add support for getRegisterByName.
Aug 31 2018, 12:09 PM
sidneym closed D51363: Add support for getRegisterByName..
Aug 31 2018, 12:09 PM

Aug 28 2018

sidneym created D51363: Add support for getRegisterByName..
Aug 28 2018, 9:10 AM

Aug 27 2018

sidneym committed rLLD340739: [ELF][HEXAGON] Add R_HEX_11/10/9_X support.
[ELF][HEXAGON] Add R_HEX_11/10/9_X support
Aug 27 2018, 5:56 AM
sidneym committed rL340739: [ELF][HEXAGON] Add R_HEX_11/10/9_X support.
[ELF][HEXAGON] Add R_HEX_11/10/9_X support
Aug 27 2018, 5:56 AM
sidneym closed D51225: Add R_HEX_11/10/9 support .
Aug 27 2018, 5:56 AM · lld

Aug 25 2018

sidneym committed rL340693: [ELF][HEXAGON] Add R_HEX_B13_PCREL relocation support.
[ELF][HEXAGON] Add R_HEX_B13_PCREL relocation support
Aug 25 2018, 4:17 PM