Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

sidneym (Sid Manning)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2014, 1:57 PM (473 w, 6 d)

Recent Activity

Aug 7 2023

sidneym added a comment to D156771: [clang][hexagon] Handle library path arguments earlier.

LGTM

Aug 7 2023, 10:20 AM · Restricted Project, Restricted Project

Dec 2 2021

sidneym added a comment to D113638: [xray] Add support for hexagon architecture .

LGTM.

Dec 2 2021, 6:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 2 2021

sidneym added a comment to D109117: [hexagon] Add system register, transfer support.

LGTM

Sep 2 2021, 9:21 AM · Restricted Project

Sep 1 2021

sidneym closed D108769: [lld][Hexagon] Add checks for instructions that can have TLS relocations.
Sep 1 2021, 1:18 PM · Restricted Project
sidneym committed rG0d7e5daedcc6: [lld][Hexagon] Add checks for instructions that can have TLS relocations (authored by sidneym).
[lld][Hexagon] Add checks for instructions that can have TLS relocations
Sep 1 2021, 1:17 PM
sidneym updated the diff for D108769: [lld][Hexagon] Add checks for instructions that can have TLS relocations.
Sep 1 2021, 10:06 AM · Restricted Project

Aug 26 2021

sidneym added inline comments to D108769: [lld][Hexagon] Add checks for instructions that can have TLS relocations.
Aug 26 2021, 3:08 PM · Restricted Project
sidneym requested review of D108769: [lld][Hexagon] Add checks for instructions that can have TLS relocations.
Aug 26 2021, 8:30 AM · Restricted Project

Aug 17 2021

sidneym added a comment to D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon.

LGTM

Aug 17 2021, 5:56 PM · Restricted Project
sidneym added a comment to D108174: [sanitizer] Add hexagon support to ubsan.

LGTM

Aug 17 2021, 5:56 PM · Restricted Project

Aug 16 2021

sidneym added inline comments to D108083: [sanitizer] Add hexagon support to sanitizer-common.
Aug 16 2021, 11:31 AM · Restricted Project, Restricted Project

Jul 27 2021

sidneym added inline comments to D106737: [clang] [hexagon] Add resource include dir.
Jul 27 2021, 11:15 AM · Restricted Project

Mar 18 2021

sidneym closed D98436: [Hexagon] Support inlined use of cs0 and cs1.
Mar 18 2021, 10:01 AM · Restricted Project, Restricted Project
sidneym committed rGc539be1dcbcf: [Hexagon] Add support for named registers cs0 and cs1 (authored by sidneym).
[Hexagon] Add support for named registers cs0 and cs1
Mar 18 2021, 7:54 AM

Mar 11 2021

sidneym updated the diff for D98436: [Hexagon] Support inlined use of cs0 and cs1.

Same patch, just added full context.

Mar 11 2021, 11:09 AM · Restricted Project, Restricted Project
sidneym requested review of D98436: [Hexagon] Support inlined use of cs0 and cs1.
Mar 11 2021, 9:49 AM · Restricted Project, Restricted Project

Jul 7 2020

sidneym committed rGbaca8f977edc: [compiler-rt][Hexagon] Remove fma/fmin/max code (authored by sidneym).
[compiler-rt][Hexagon] Remove fma/fmin/max code
Jul 7 2020, 5:50 PM
sidneym closed D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.
Jul 7 2020, 5:50 PM · Restricted Project
sidneym updated the diff for D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.

Rebase

Jul 7 2020, 12:06 PM · Restricted Project
sidneym abandoned D83318: nothing .
Jul 7 2020, 10:42 AM · Restricted Project
Herald added a project to D83318: nothing : Restricted Project.
Jul 7 2020, 9:07 AM · Restricted Project

Jun 30 2020

sidneym updated the diff for D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.
Jun 30 2020, 11:57 AM · Restricted Project

Jun 24 2020

sidneym committed rGe5911de37722: [Hexagon][llvm-objcopy] Add missing check for SHN_HEXAGON_SCOMMON_1 (authored by sidneym).
[Hexagon][llvm-objcopy] Add missing check for SHN_HEXAGON_SCOMMON_1
Jun 24 2020, 5:57 PM
sidneym closed D82484: [Hexagon] llvm-objcopy check for SHN_HEXAGON_SCOMMON_1.
Jun 24 2020, 5:57 PM · Restricted Project
sidneym created D82484: [Hexagon] llvm-objcopy check for SHN_HEXAGON_SCOMMON_1.
Jun 24 2020, 10:50 AM · Restricted Project

Jun 20 2020

sidneym updated the diff for D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.

missed fabs.S

Jun 20 2020, 5:29 PM · Restricted Project
sidneym created D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.
Jun 20 2020, 12:10 PM · Restricted Project

May 18 2020

sidneym accepted D80073: [Hexagon] pX.new cannot be used with p3:0 as producer.

LGTM

May 18 2020, 9:07 AM · Restricted Project

May 5 2020

sidneym committed rG0e6536fd97f9: [Hexagon] Add R_HEX_GD_PLT_B22/32_PCREL relocations (authored by sidneym).
[Hexagon] Add R_HEX_GD_PLT_B22/32_PCREL relocations
May 5 2020, 10:15 AM
sidneym closed D79191: [Hexagon] Add Extended GD_PLT relocations.
May 5 2020, 10:14 AM · Restricted Project

May 4 2020

sidneym updated the diff for D79191: [Hexagon] Add Extended GD_PLT relocations.

Address comments, --check-prefix, alignment of checks.

May 4 2020, 8:32 AM · Restricted Project

Apr 30 2020

sidneym created D79191: [Hexagon] Add Extended GD_PLT relocations.
Apr 30 2020, 11:47 AM · Restricted Project

Apr 20 2020

sidneym added a comment to D77919: [MC][ELF] Add section flags to diagnostic.

LGTM

Apr 20 2020, 7:00 PM · Restricted Project

Apr 10 2020

sidneym added a comment to D77879: [ELF][Hexagon] Add duplex to R_HEX_GOT_16_X.

LGTM

Apr 10 2020, 8:54 AM · Restricted Project

Apr 9 2020

sidneym accepted D76958: [test-suite] Add support for Hexagon.

Missing context but otherwise looks ok to me.

Apr 9 2020, 8:40 AM
sidneym committed rG9bda29ab0fdf: [Hexagon] Default linker tests can fail if CLANG_DEFAULT_LINKER is used. (authored by sidneym).
[Hexagon] Default linker tests can fail if CLANG_DEFAULT_LINKER is used.
Apr 9 2020, 7:02 AM
sidneym closed D77684: [Hexagon] Remove testcases that check for default linker..
Apr 9 2020, 7:01 AM · Restricted Project

Apr 7 2020

sidneym created D77684: [Hexagon] Remove testcases that check for default linker..
Apr 7 2020, 3:49 PM · Restricted Project
sidneym added a comment to D77498: [Hexagon] Select lld as the default linker for linux-musl target.

Since this isn't something that can be always known in advance I think the testcase should just be removed.

Apr 7 2020, 3:49 PM · Restricted Project
sidneym added a comment to D77498: [Hexagon] Select lld as the default linker for linux-musl target.

These are new tests how do you get the generic lld driver to work? When I invoke it using just "lld" I need to add -flavor gnu or I get this error:
Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-ld (WebAssembly) instead

Apr 7 2020, 3:49 PM · Restricted Project
sidneym committed rGaed2fdb1671c: [Hexagon] Update paths for linux/musl (authored by sidneym).
[Hexagon] Update paths for linux/musl
Apr 7 2020, 11:59 AM
sidneym closed D77440: [Hexagon] Update include paths for linux/musl.
Apr 7 2020, 11:58 AM · Restricted Project
sidneym updated the diff for D77440: [Hexagon] Update include paths for linux/musl.

Fix formatting issues.

Apr 7 2020, 8:08 AM · Restricted Project
sidneym updated the diff for D77440: [Hexagon] Update include paths for linux/musl.

Break out linux parts of hexagon-toolchain-elf.c into hexagon-toolchain-linux.c

Apr 7 2020, 6:28 AM · Restricted Project

Apr 6 2020

sidneym committed rG5002863ab0d6: Support bfdname "elf32-hexagon". (authored by sidneym).
Support bfdname "elf32-hexagon".
Apr 6 2020, 3:50 PM
sidneym closed D77579: [llvm-objcopy] Support bfdname "elf32-hexagon".
Apr 6 2020, 3:49 PM · Restricted Project
sidneym created D77579: [llvm-objcopy] Support bfdname "elf32-hexagon".
Apr 6 2020, 1:04 PM · Restricted Project
sidneym committed rG2c5d6dfda98e: [Hexagon] Make lld be the default linker for linux/musl (authored by sidneym).
[Hexagon] Make lld be the default linker for linux/musl
Apr 6 2020, 11:26 AM
sidneym closed D77498: [Hexagon] Select lld as the default linker for linux-musl target.
Apr 6 2020, 11:26 AM · Restricted Project

Apr 5 2020

sidneym created D77498: [Hexagon] Select lld as the default linker for linux-musl target.
Apr 5 2020, 7:27 AM · Restricted Project

Apr 3 2020

sidneym created D77440: [Hexagon] Update include paths for linux/musl.
Apr 3 2020, 4:49 PM · Restricted Project
sidneym abandoned D76582: [Hexagon] Don't clear libpath when target is linux-musl.
Apr 3 2020, 4:49 PM · Restricted Project
sidneym committed rGc484b3e334d3: [Hexagon] Fix issue with non-preemptible STT_TLS symbols (authored by sidneym).
[Hexagon] Fix issue with non-preemptible STT_TLS symbols
Apr 3 2020, 6:59 AM
sidneym closed D77021: [Hexagon] R_HEX_GD_PLT_B22_PCREL cannot be relaxed..
Apr 3 2020, 6:58 AM · Restricted Project

Apr 1 2020

sidneym updated the diff for D77021: [Hexagon] R_HEX_GD_PLT_B22_PCREL cannot be relaxed..

Use Fangrui's updated version of the testcase and rename it to hexagon-tls-gd-nonpreemptible.s. Appreciate the changes and added content it helps clarify the scenario being tested.

Apr 1 2020, 2:38 PM · Restricted Project

Mar 30 2020

sidneym committed rG81194bfeea7b: [Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set. (authored by sidneym).
[Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set.
Mar 30 2020, 10:51 AM
sidneym closed D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set..
Mar 30 2020, 10:50 AM · Restricted Project
sidneym updated the diff for D77021: [Hexagon] R_HEX_GD_PLT_B22_PCREL cannot be relaxed..

Update and add more context to the testcase.

Mar 30 2020, 10:16 AM · Restricted Project

Mar 29 2020

sidneym created D77021: [Hexagon] R_HEX_GD_PLT_B22_PCREL cannot be relaxed..
Mar 29 2020, 10:41 AM · Restricted Project

Mar 27 2020

sidneym resigned from D53249: Force Hexagon to use default (hexagon-link) linker.
Mar 27 2020, 6:12 PM
sidneym resigned from D19924: Representing bundle locked groups as fragments in MCAssembler.
Mar 27 2020, 6:12 PM
sidneym resigned from D5050: Added encoding bits to mpy instructions.
Mar 27 2020, 6:12 PM

Mar 26 2020

sidneym committed rGb0da09498394: [Hexagon] Add support for Linux/Musl ABI (part 2) (authored by sidneym).
[Hexagon] Add support for Linux/Musl ABI (part 2)
Mar 26 2020, 3:47 PM
sidneym closed D75638: [Hexagon] Support for Linux/Musl ABI..
Mar 26 2020, 3:47 PM · Restricted Project
sidneym updated the diff for D75638: [Hexagon] Support for Linux/Musl ABI..

update for new tidy checks.

Mar 26 2020, 1:02 PM · Restricted Project
sidneym added a reviewer for D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.: bcahoon.
Mar 26 2020, 8:06 AM · Restricted Project

Mar 22 2020

sidneym created D76582: [Hexagon] Don't clear libpath when target is linux-musl.
Mar 22 2020, 6:47 PM · Restricted Project
sidneym updated the diff for D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set..

remove extra line break.

Mar 22 2020, 9:36 AM · Restricted Project

Mar 21 2020

sidneym added inline comments to D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set..
Mar 21 2020, 7:14 PM · Restricted Project
sidneym created D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set..
Mar 21 2020, 11:12 AM · Restricted Project

Mar 19 2020

sidneym abandoned D72528: [Hexagon] Have GetDynamicTLSAddr call __tls_get_addr directly..
Mar 19 2020, 1:10 PM · Restricted Project
sidneym committed rG430c9a80c17b: [Hexagon] Enable linux #defines (authored by sidneym).
[Hexagon] Enable linux #defines
Mar 19 2020, 12:36 PM
sidneym closed D76310: [Hexagon] Add linux #defines when linux triple is selected.
Mar 19 2020, 12:36 PM · Restricted Project

Mar 18 2020

sidneym abandoned D76328: [ELF] Allow uppercase section directives.

OK, I will drop it. Thanks

Mar 18 2020, 10:20 AM · Restricted Project
sidneym added a comment to D76328: [ELF] Allow uppercase section directives.

Seems I do not understand the current behavior.

GNU as shows the following errors for this test:

test.s:6: Error: unknown pseudo-op: `.data.rel.ro'
test.s:9: Error: unknown pseudo-op: `.data.rel'
test.s:12: Error: unknown pseudo-op: `.eh_frame'
test.s:15: Error: unknown pseudo-op: `.rodata'
test.s:18: Error: unknown pseudo-op: `.tbss'
test.s:21: Error: unknown pseudo-op: `.tdata'
test.s:27: Error: unknown pseudo-op: `.data.rel.ro'
test.s:30: Error: unknown pseudo-op: `.data.rel'
test.s:33: Error: unknown pseudo-op: `.eh_frame'
test.s:36: Error: unknown pseudo-op: `.rodata'
test.s:39: Error: unknown pseudo-op: `.tbss'
test.s:42: Error: unknown pseudo-op: `.tdata'
Mar 18 2020, 6:30 AM · Restricted Project

Mar 17 2020

sidneym created D76328: [ELF] Allow uppercase section directives.
Mar 17 2020, 3:07 PM · Restricted Project
sidneym created D76310: [Hexagon] Add linux #defines when linux triple is selected.
Mar 17 2020, 12:23 PM · Restricted Project

Mar 13 2020

sidneym committed rG5a5a075c5b19: [LLD][ELF][Hexagon] Support GDPLT transforms (authored by sidneym).
[LLD][ELF][Hexagon] Support GDPLT transforms
Mar 13 2020, 9:07 AM
sidneym closed D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.
Mar 13 2020, 9:07 AM · Restricted Project
sidneym updated the diff for D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.
Mar 13 2020, 8:00 AM · Restricted Project

Mar 12 2020

sidneym updated the diff for D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.

Fix variable name noted by: https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-4524/clang-tidy.txt

Mar 12 2020, 3:45 PM · Restricted Project
sidneym committed rG6174fddbe3d4: [Hexagon] Enable init_arrays when target is linux-musl (authored by sidneym).
[Hexagon] Enable init_arrays when target is linux-musl
Mar 12 2020, 1:02 PM
sidneym closed D76079: [Hexagon] Enable init_arrays when target is linux-musl.
Mar 12 2020, 1:02 PM · Restricted Project
sidneym updated the diff for D76079: [Hexagon] Enable init_arrays when target is linux-musl.

Drop ternary.

Mar 12 2020, 11:56 AM · Restricted Project
sidneym created D76079: [Hexagon] Enable init_arrays when target is linux-musl.
Mar 12 2020, 10:51 AM · Restricted Project

Mar 9 2020

sidneym updated the diff for D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.
  • Add the missing colon's that kept the part of the testcase from running.
  • Move the find of __tls_get_addr outside of the loop and return if it is not found.
  • Make __tls_get_addr preemptible. If isPreemptible is not set that symbol's symbol index is 0, since part of the testcase wasn't running, the missing colon's, I missed this.
  • Change the case of the variables.
Mar 9 2020, 2:03 PM · Restricted Project

Mar 6 2020

sidneym added a comment to D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.

Many variable names are still not fixed.

Mar 6 2020, 8:46 AM · Restricted Project
sidneym added inline comments to D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.
Mar 6 2020, 7:09 AM · Restricted Project

Mar 4 2020

sidneym created D75638: [Hexagon] Support for Linux/Musl ABI..
Mar 4 2020, 12:57 PM · Restricted Project

Mar 3 2020

sidneym committed rGd481e59863ac: [hexagon] Add default paths to support musl target (authored by sidneym).
[hexagon] Add default paths to support musl target
Mar 3 2020, 6:58 AM
sidneym closed D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.
Mar 3 2020, 6:57 AM · Restricted Project

Mar 2 2020

sidneym updated the diff for D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.

address clang-tidy issues

Mar 2 2020, 1:45 PM · Restricted Project
sidneym reopened D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.
Mar 2 2020, 12:55 PM · Restricted Project
sidneym updated the diff for D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.

Update testcase.

Mar 2 2020, 12:55 PM · Restricted Project
sidneym committed rG0858eebd2a48: Revert "Add default paths to support musl target" (authored by sidneym).
Revert "Add default paths to support musl target"
Mar 2 2020, 12:29 PM
sidneym added a reverting change for rG637767665141: Add default paths to support musl target: rG0858eebd2a48: Revert "Add default paths to support musl target".
Mar 2 2020, 12:29 PM
sidneym committed rG637767665141: Add default paths to support musl target (authored by sidneym).
Add default paths to support musl target
Mar 2 2020, 11:40 AM
sidneym closed D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.
Mar 2 2020, 11:40 AM · Restricted Project

Feb 28 2020

sidneym updated the diff for D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.

fix formatting concerns from clang-tidy

Feb 28 2020, 12:30 PM · Restricted Project
sidneym updated the diff for D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.

Move selection of the dynamic linker before user args are added.

Feb 28 2020, 6:40 AM · Restricted Project