Page MenuHomePhabricator

[MLIR] PresburgerSet: support divisions in subtract, intersect, and equality checks
AbandonedPublic

Authored by arjunp on Sep 3 2021, 9:01 AM.

Details

Summary

Depends on D106662.

Diff Detail

Unit TestsFailed

TimeTest
250 msx64 debian > MLIR.Dialect/Affine::affine-data-copy.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/affine-data-copy.mlir -split-input-file -affine-data-copy-generate="generate-dma=false fast-mem-space=0 skip-non-unit-stride-loops" | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/affine-data-copy.mlir
390 msx64 debian > MLIR.Dialect/Affine::dma-generate.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt -allow-unregistered-dialect /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/dma-generate.mlir -split-input-file -affine-data-copy-generate="generate-dma fast-mem-space=2 skip-non-unit-stride-loops" -verify-diagnostics | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/dma-generate.mlir
100 msx64 debian > MLIR.Dialect/Affine::loop-tiling-validity.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/loop-tiling-validity.mlir -split-input-file -affine-loop-tile="tile-size=32" -verify-diagnostics | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/loop-tiling-validity.mlir
570 msx64 debian > MLIR.Dialect/Affine::loop-tiling.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/loop-tiling.mlir -split-input-file -affine-loop-tile="tile-size=32" | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Affine/loop-tiling.mlir
260 msx64 debian > MLIR.Dialect/Linalg::hoist-padding.mlir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Linalg/hoist-padding.mlir -split-input-file -test-linalg-transform-patterns=test-hoist-padding=2 -canonicalize | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Linalg/hoist-padding.mlir
View Full Test Results (28 Failed)

Event Timeline

arjunp created this revision.Sep 3 2021, 9:01 AM
arjunp requested review of this revision.Sep 3 2021, 9:01 AM
grosser added inline comments.Sep 3 2021, 9:31 AM
mlir/include/mlir/Analysis/AffineStructures.h
138

Typo.

arjunp updated this revision to Diff 370624.Sep 3 2021, 10:33 AM

Fixed typo.

arjunp updated this revision to Diff 370741.Sep 4 2021, 7:50 AM

Fix build by making removeId overload with unspecified kind public.

arjunp added a comment.EditedSep 4 2021, 7:55 AM

Personally, I believe that the removeId overload where the identifier kind is not specified should not be public. I think the interface should only be on a per-kind basis rather than exposing the implementation detail of the ordering among kinds.

The build failure occurs in LoopUtils.cpp. I would be happy to change it to instead call the removeId overload that takes the kind to be used as an argument. But I don't understand why these lines mark all but one variable as a symbol but comment that it marks all variables as symbols.

Please add a commit summary. Is this rebased on the current master? A lot of the relevant files have changed I think.

mlir/include/mlir/Analysis/AffineStructures.h
402

Missing doc comments.

mlir/include/mlir/Analysis/Presburger/Simplex.h
165

Triple /// comments please - here and elsewhere.

arjunp abandoned this revision.Sep 16 2021, 8:32 AM

Splitting this into mutliple patches.