Page MenuHomePhabricator

Groverkss (Kunwar Shaanjeet Singh Grover)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2021, 7:47 PM (65 w, 6 d)

Recent Activity

Thu, Sep 15

Groverkss committed rG8c867f7827f6: [MLIR][Presburger] Improve unittest parsing (authored by Groverkss).
[MLIR][Presburger] Improve unittest parsing
Thu, Sep 15, 11:30 AM · Restricted Project, Restricted Project
Groverkss closed D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 11:29 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133654: [MLIR][Presburger] Improve unittest parsing.

Fix bazel build

Thu, Sep 15, 11:16 AM · Restricted Project, Restricted Project
Groverkss added a comment to D133937: [mlir] Remove the unused source file..

Included this change in the original revision since I had to revert things because of a compilation issue with gcc8 anyway.

Thu, Sep 15, 10:56 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133654: [MLIR][Presburger] Improve unittest parsing.

Fix build issues with gcc8 and remove unused file

Thu, Sep 15, 10:55 AM · Restricted Project, Restricted Project
Groverkss reopened D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 10:54 AM · Restricted Project, Restricted Project
Groverkss added a reverting change for rG84d07d021333: [MLIR][Presburger] Improve unittest parsing: rG644dfbac648e: Revert "[MLIR][Presburger] Improve unittest parsing".
Thu, Sep 15, 10:43 AM · Restricted Project, Restricted Project
Groverkss committed rG644dfbac648e: Revert "[MLIR][Presburger] Improve unittest parsing" (authored by Groverkss).
Revert "[MLIR][Presburger] Improve unittest parsing"
Thu, Sep 15, 10:43 AM · Restricted Project, Restricted Project
Groverkss added a reverting change for rGe488ce29ec5e: [mlir] Remove the unused source file.: rGa53b56e4c4de: Revert "[mlir] Remove the unused source file.".
Thu, Sep 15, 10:43 AM · Restricted Project, Restricted Project
Groverkss committed rGa53b56e4c4de: Revert "[mlir] Remove the unused source file." (authored by Groverkss).
Revert "[mlir] Remove the unused source file."
Thu, Sep 15, 10:43 AM · Restricted Project, Restricted Project
Groverkss added a reverting change for D133654: [MLIR][Presburger] Improve unittest parsing: rG644dfbac648e: Revert "[MLIR][Presburger] Improve unittest parsing".
Thu, Sep 15, 10:43 AM · Restricted Project, Restricted Project
Groverkss added a reverting change for D133937: [mlir] Remove the unused source file.: rGa53b56e4c4de: Revert "[mlir] Remove the unused source file.".
Thu, Sep 15, 10:43 AM · Restricted Project, Restricted Project
Groverkss committed rG84d07d021333: [MLIR][Presburger] Improve unittest parsing (authored by Groverkss).
[MLIR][Presburger] Improve unittest parsing
Thu, Sep 15, 4:09 AM · Restricted Project, Restricted Project
Groverkss closed D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 4:09 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 4:03 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D133654: [MLIR][Presburger] Improve unittest parsing.
Thu, Sep 15, 3:43 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133654: [MLIR][Presburger] Improve unittest parsing.

Address Arjun's comment and rebase

Thu, Sep 15, 3:36 AM · Restricted Project, Restricted Project

Wed, Sep 14

Groverkss added a comment to D133233: [MLIR][Presburger] Add the related methods to support computing Matrix inverse.

The patch was landed. You can use Hermite decomp to do inverse here.

Wed, Sep 14, 9:19 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133654: [MLIR][Presburger] Improve unittest parsing.

Address comments and rebase

Wed, Sep 14, 9:08 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D133654: [MLIR][Presburger] Improve unittest parsing.
Wed, Sep 14, 9:07 AM · Restricted Project, Restricted Project
Groverkss committed rGb696e25a7a26: [MLIR][Presburger] Add hermite normal form computation to Matrix (authored by Groverkss).
[MLIR][Presburger] Add hermite normal form computation to Matrix
Wed, Sep 14, 8:39 AM · Restricted Project, Restricted Project
Groverkss closed D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.
Wed, Sep 14, 8:39 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.

Rebase

Wed, Sep 14, 7:59 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.

Address Arjun's comment

Wed, Sep 14, 7:40 AM · Restricted Project, Restricted Project

Sat, Sep 10

Groverkss updated the summary of D133654: [MLIR][Presburger] Improve unittest parsing.
Sat, Sep 10, 6:03 PM · Restricted Project, Restricted Project
Groverkss added a reviewer for D133654: [MLIR][Presburger] Improve unittest parsing: rriddle.
Sat, Sep 10, 6:03 PM · Restricted Project, Restricted Project
Groverkss requested review of D133654: [MLIR][Presburger] Improve unittest parsing.
Sat, Sep 10, 6:02 PM · Restricted Project, Restricted Project
Groverkss committed rGbb2226ac53aa: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe (authored by Groverkss).
[MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe
Sat, Sep 10, 5:13 PM · Restricted Project, Restricted Project
Groverkss closed D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.
Sat, Sep 10, 5:12 PM · Restricted Project, Restricted Project
Groverkss updated the diff for D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.

Write better docs for MutliAffineFunction::getAsRelation

Sat, Sep 10, 11:53 AM · Restricted Project, Restricted Project

Fri, Sep 9

Groverkss updated the diff for D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.

Rebase

Fri, Sep 9, 9:50 AM · Restricted Project, Restricted Project
Groverkss added a comment to D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.

Address more comments.

Fri, Sep 9, 9:30 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.
Fri, Sep 9, 9:30 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.

Address Arjun's comments

Fri, Sep 9, 9:28 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.
Fri, Sep 9, 7:57 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.

Address Arjun's comments

Fri, Sep 9, 7:56 AM · Restricted Project, Restricted Project
Groverkss added a comment to D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.

Thanks @Groverkss ! Any performance numbers to share?

Fri, Sep 9, 3:11 AM · Restricted Project, Restricted Project

Thu, Sep 8

Groverkss added a comment to D133233: [MLIR][Presburger] Add the related methods to support computing Matrix inverse.

I sent the refactor here: https://reviews.llvm.org/D133510

Thu, Sep 8, 11:17 AM · Restricted Project, Restricted Project
Groverkss requested review of D133510: [MLIR][Presburger] Add hermite normal form computation to Matrix.
Thu, Sep 8, 11:14 AM · Restricted Project, Restricted Project
Groverkss added a comment to D133233: [MLIR][Presburger] Add the related methods to support computing Matrix inverse.

From what I understand, you only need the integer inverse of a unimodular matrix. This is better accomplished by Hermite normal form.

Thu, Sep 8, 7:24 AM · Restricted Project, Restricted Project

Wed, Sep 7

Groverkss added a comment to D133233: [MLIR][Presburger] Add the related methods to support computing Matrix inverse.

@Groverkss Thanks for the detailed review. gtest does show the algorithm is tending on the expensive side. There was a reason that we went the route of computing the determinant/cofactor as suppose to a method such as LU decomposition. I can find out the precise reason from our scheduler person and update the MR tomorrow. Hope the style better matches your expectation and thanks for catching the zero-row vector bug.

[ RUN      ] MatrixTest.determinant
[       OK ] MatrixTest.determinant (106 ms)
[ RUN      ] MatrixTest.transpose
[       OK ] MatrixTest.transpose (0 ms)
[ RUN      ] MatrixTest.cofactor
[       OK ] MatrixTest.cofactor (107 ms)
[ RUN      ] MatrixTest.inverse
[       OK ] MatrixTest.inverse (111 ms)
[ RUN      ] MatrixTest.toVector
[       OK ] MatrixTest.toVector (0 ms)
[ RUN      ] MatrixTest.Matrix
[       OK ] MatrixTest.Matrix (108 ms)
[----------] 13 tests from MatrixTest (432 ms total)
Wed, Sep 7, 3:33 AM · Restricted Project, Restricted Project

Mon, Sep 5

Groverkss requested changes to D133233: [MLIR][Presburger] Add the related methods to support computing Matrix inverse.

Thank you for the patch!

Mon, Sep 5, 4:08 PM · Restricted Project, Restricted Project

Aug 21 2022

Groverkss added inline comments to D132326: [MLIR] Generalize/complete getEnclosingAffineForIfOps utility.
Aug 21 2022, 8:47 AM · Restricted Project, Restricted Project

Aug 19 2022

Groverkss accepted D132201: [NFC][mlir][affine] Typo in Affine Analysis test.

LGTM

Aug 19 2022, 7:01 AM · Restricted Project, Restricted Project
Groverkss retitled D132201: [NFC][mlir][affine] Typo in Affine Analysis test from [mlir][affine] Typo in Affine Analysis test to [NFC][mlir][affine] Typo in Affine Analysis test.
Aug 19 2022, 7:01 AM · Restricted Project, Restricted Project

Aug 17 2022

Groverkss added inline comments to D132021: [mlir][SCF] Loop lb/ub are symbols during Affine Min/Max canonicalization.
Aug 17 2022, 6:03 AM · Restricted Project, Restricted Project

Aug 15 2022

Groverkss added a comment to D129171: [mlir][affine] Option to unroll cleanup loop if smaller trip count..

@Groverkss Sorry if I'm pinging the wrong person. But could you review this PR when you get a chance or tell me who I should ask to take a look at this type of change?

Aug 15 2022, 8:01 AM · Restricted Project, Restricted Project

Aug 14 2022

Groverkss requested review of D131864: [MLIR][Presburger] Refactor MultiAffineFunction to be defined over universe.
Aug 14 2022, 10:47 AM · Restricted Project, Restricted Project

Aug 4 2022

Groverkss accepted D131186: [MLIR][Presburger] SlowMPInt::gcd: fix crash when sizes differ.

LGTM.

Aug 4 2022, 11:11 AM · Restricted Project, Restricted Project
Groverkss accepted D131184: [MLIR][Presburger] fourier-motzkin: check if all LCMs are 1 using a bool instead of by multiplying them.

LGTM.

Aug 4 2022, 10:57 AM · Restricted Project, Restricted Project

Jul 19 2022

Groverkss added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

Could you add some int64_t overflow tests for major algorithms like point sampling, lexmin, subtraction, etc.?

Jul 19 2022, 11:41 AM · Restricted Project, Restricted Project

Jul 18 2022

Groverkss accepted D129816: [MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't harmonized.

LGTM.

Jul 18 2022, 3:40 AM · Restricted Project, Restricted Project
Groverkss accepted D129509: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and int64_t.

Accidently requested changes instead of accepting.

Jul 18 2022, 3:39 AM · Restricted Project, Restricted Project
Groverkss requested changes to D129509: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and int64_t.

LGTM.

Jul 18 2022, 3:39 AM · Restricted Project, Restricted Project

Jul 15 2022

Groverkss added inline comments to D129816: [MLIR][Presburger] SlowMPInt: fix bug in ceilDiv, floorDiv where widths weren't harmonized.
Jul 15 2022, 8:53 AM · Restricted Project, Restricted Project
Groverkss accepted D129820: [MLIR][Presburger] reintroduce int64_t versions of floorDiv, ceilDiv in mlir::presburger namespace.

LGTM.

Jul 15 2022, 8:49 AM · Restricted Project, Restricted Project
Groverkss accepted D129815: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv.

LGTM

Jul 15 2022, 8:43 AM · Restricted Project, Restricted Project

Jul 13 2022

Groverkss added a comment to D129510: [MLIR][Presburger] use arbitrary-precision arithmetic with MPInt instead of int64_t.

For classes other than IntegerRelation, I don't think the public API should have int64_t methods. They should be MPInt only. Can you please change this?

Jul 13 2022, 8:41 AM · Restricted Project, Restricted Project
Groverkss added a comment to D129509: [MLIR][Presburger] Provide functions to convert between arrays of MPInt and int64_t.

Can you fix the failing build, please? It looks like you cannot include MPInt.h and MathExtras.h together and use mod, ceilDiv, etc.

Jul 13 2022, 7:09 AM · Restricted Project, Restricted Project

Jul 7 2022

Groverkss committed rG479c4f648a02: [MLIR][Presburger] Refactor division representation to DivisionRepr (authored by Groverkss).
[MLIR][Presburger] Refactor division representation to DivisionRepr
Jul 7 2022, 7:07 AM · Restricted Project, Restricted Project
Groverkss closed D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
Jul 7 2022, 7:06 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
  • Address Arjun's comments
Jul 7 2022, 6:46 AM · Restricted Project, Restricted Project

Jul 6 2022

Groverkss updated the diff for D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
  • Address Arjun's comments
Jul 6 2022, 8:50 AM · Restricted Project, Restricted Project
Groverkss committed rGa18f843f075f: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction (authored by Groverkss).
[MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction
Jul 6 2022, 8:09 AM · Restricted Project, Restricted Project
Groverkss closed D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 6 2022, 8:09 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
  • Fix doc
Jul 6 2022, 8:07 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
  • Fix doc in tests
Jul 6 2022, 8:05 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 6 2022, 7:58 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
  • Add more docs for tests
Jul 6 2022, 7:57 AM · Restricted Project, Restricted Project

Jul 5 2022

Groverkss accepted D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

LGTM.

Jul 5 2022, 8:59 AM · Restricted Project, Restricted Project
Groverkss committed rGed3b040b54f4: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace (authored by Groverkss).
[MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace
Jul 5 2022, 8:31 AM · Restricted Project, Restricted Project
Groverkss closed D128751: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace.
Jul 5 2022, 8:30 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128751: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace.
  • Update PresburgerSpace doc
Jul 5 2022, 8:24 AM · Restricted Project, Restricted Project
Groverkss requested review of D129146: [MLIR][Presburger] Refactor division representation to DivisionRepr.
Jul 5 2022, 8:15 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
  • Address Arjun's comments
  • Address Uday's comments
Jul 5 2022, 6:28 AM · Restricted Project, Restricted Project
Groverkss updated the summary of D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 5 2022, 6:26 AM · Restricted Project, Restricted Project
Groverkss updated the summary of D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 5 2022, 6:24 AM · Restricted Project, Restricted Project
Groverkss committed rG3c043ab007a1: [MLIR][Affine] Allow `<=` in IntegerSet constraints (authored by Groverkss).
[MLIR][Affine] Allow `<=` in IntegerSet constraints
Jul 5 2022, 4:25 AM · Restricted Project, Restricted Project
Groverkss closed D129046: [MLIR][Affine] Allow `<=` in IntegerSet constraints.
Jul 5 2022, 4:25 AM · Restricted Project, Restricted Project

Jul 4 2022

Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.

Fix bug and add regression tests for tiebreakLex

Jul 4 2022, 6:57 AM · Restricted Project, Restricted Project

Jul 3 2022

Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.

Address Arjun's comments

Jul 3 2022, 9:42 AM · Restricted Project, Restricted Project
Groverkss requested review of D129046: [MLIR][Affine] Allow `<=` in IntegerSet constraints.
Jul 3 2022, 9:00 AM · Restricted Project, Restricted Project
Groverkss committed rGd71a8bb157ea: [MLIR][Affine] Allow affine-expr on RHS in IntegerSet (authored by Groverkss).
[MLIR][Affine] Allow affine-expr on RHS in IntegerSet
Jul 3 2022, 8:27 AM · Restricted Project, Restricted Project
Groverkss closed D128915: [MLIR][Affine] Allow affine-expr on RHS in IntegerSet.
Jul 3 2022, 8:27 AM · Restricted Project, Restricted Project

Jul 2 2022

Groverkss added inline comments to D128915: [MLIR][Affine] Allow affine-expr on RHS in IntegerSet.
Jul 2 2022, 11:31 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128915: [MLIR][Affine] Allow affine-expr on RHS in IntegerSet.

Address Uday's comments

Jul 2 2022, 11:31 AM · Restricted Project, Restricted Project

Jul 1 2022

Groverkss added a comment to D128931: [MLIR][Presburger] Simplex: refactor (symbolic)lex to support specifying multiple varKinds as symbols.

LGTM.

Jul 1 2022, 9:45 AM · Restricted Project, Restricted Project
Groverkss accepted D128931: [MLIR][Presburger] Simplex: refactor (symbolic)lex to support specifying multiple varKinds as symbols.
Jul 1 2022, 9:44 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128931: [MLIR][Presburger] Simplex: refactor (symbolic)lex to support specifying multiple varKinds as symbols.
Jul 1 2022, 9:41 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
Jul 1 2022, 9:04 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128931: [MLIR][Presburger] Simplex: refactor (symbolic)lex to support specifying multiple varKinds as symbols.
Jul 1 2022, 8:38 AM · Restricted Project, Restricted Project
Groverkss accepted D128933: [MLIR][Presburger] support symbolicLexMin for IntegerRelation.

LGTM.

Jul 1 2022, 7:44 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128933: [MLIR][Presburger] support symbolicLexMin for IntegerRelation.
Jul 1 2022, 7:43 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.

Address Arjun's comments

Jul 1 2022, 6:30 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jul 1 2022, 6:30 AM · Restricted Project, Restricted Project

Jun 30 2022

Groverkss updated the summary of D128915: [MLIR][Affine] Allow affine-expr on RHS in IntegerSet.
Jun 30 2022, 7:39 AM · Restricted Project, Restricted Project
Groverkss requested review of D128915: [MLIR][Affine] Allow affine-expr on RHS in IntegerSet.
Jun 30 2022, 7:35 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.
Jun 30 2022, 5:43 AM · Restricted Project, Restricted Project

Jun 29 2022

Groverkss requested review of D128829: [MLIR][Presburger] Support lexicographic max/min union of two PWMAFunction.
Jun 29 2022, 8:08 AM · Restricted Project, Restricted Project

Jun 28 2022

Groverkss requested review of D128751: [MLIR][Presburger] Rename attachments to identifiers in PresburgerSpace.
Jun 28 2022, 12:19 PM · Restricted Project, Restricted Project