Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People Groverkss

Groverkss (Kunwar Shaanjeet Singh Grover)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2021, 7:47 PM (116 w, 4 d)

Recent Activity
View All

Wed, Sep 20

Groverkss abandoned D156469: [mlir][tools] Introduce tblgen-to-irdl tool.

Sent on github instead.

Wed, Sep 20, 12:04 AM · Restricted Project, Restricted Project

Fri, Sep 15

Groverkss added a comment to D158238: Implement __builtin_fmaximum/fminimum*.

LGTM, the fmaximum/fminimum fallback support backends has been blocking us for a while in IREE. This patch is a welcome addition to start the support for this. I will let @fhahn accept the patch, since I'm not an expert in this part of code.

Fri, Sep 15, 8:50 PM · Restricted Project, Restricted Project

Tue, Sep 5

Groverkss requested changes to D156906: Template Matrix to allow both MPInt and Fraction.

This patch was sent as a pull request instead: https://github.com/llvm/llvm-project/pull/65272. Please abandon this revision to reduce the number of open revisions we have.

Tue, Sep 5, 12:21 AM · Restricted Project, Restricted Project
Groverkss requested changes to D159334: [MLIR][Presburger] Implement convertVarKind for PresburgerSpace.

This was already added as part of https://reviews.llvm.org/rGd222b69093d69e034b7f01d9ceedce28d48fbb0c.

Tue, Sep 5, 12:19 AM · Restricted Project, Restricted Project
Groverkss committed rGd222b69093d6: [MLIR][Presburger] Add Identifier class to store identifiers and their type (authored by Groverkss).
[MLIR][Presburger] Add Identifier class to store identifiers and their type
Tue, Sep 5, 12:17 AM · Restricted Project, Restricted Project
Groverkss closed D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
Tue, Sep 5, 12:16 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Fix tests
  • Fix warning in unittests
Tue, Sep 5, 12:13 AM · Restricted Project, Restricted Project

Mon, Sep 4

Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Documentation
Mon, Sep 4, 11:46 PM · Restricted Project, Restricted Project

Sun, Sep 3

Groverkss accepted D159413: [MLIR][Presburger] Minor bug-fix in PresburgerRelation::intersectRange from 3dd9931.

LGTM

Sun, Sep 3, 10:36 PM · Restricted Project, Restricted Project
Groverkss added inline comments to D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
Sun, Sep 3, 3:54 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Address comments
Sun, Sep 3, 3:53 AM · Restricted Project, Restricted Project

Tue, Aug 29

Groverkss accepted D158478: [mlir][linalg] Enable parallel partial reduction tiling with multiple dims.

LGTM

Tue, Aug 29, 8:59 AM · Restricted Project, Restricted Project

Fri, Aug 25

Groverkss added reviewers for D158921: [MLIR][Tensor] Add ValueBoundsOpInterface for tensor::CollapseShapeOp: qedawkins, mravishankar.
Fri, Aug 25, 9:33 PM · Restricted Project, Restricted Project
Groverkss added reviewers for D158921: [MLIR][Tensor] Add ValueBoundsOpInterface for tensor::CollapseShapeOp: springerm, ftynse.
Fri, Aug 25, 9:24 PM · Restricted Project, Restricted Project
Groverkss requested review of D158921: [MLIR][Tensor] Add ValueBoundsOpInterface for tensor::CollapseShapeOp.
Fri, Aug 25, 9:24 PM · Restricted Project, Restricted Project

Aug 23 2023

Groverkss added inline comments to D158424: [MLIR][Presburger] Implement getAsRelation for PWMAFunction.
Aug 23 2023, 10:29 PM · Restricted Project, Restricted Project
Groverkss added inline comments to D158478: [mlir][linalg] Enable parallel partial reduction tiling with multiple dims.
Aug 23 2023, 10:13 PM · Restricted Project, Restricted Project

Aug 21 2023

Groverkss added inline comments to D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
Aug 21 2023, 4:56 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Address comments
  • Address comments
  • Fix convertVarKind test
Aug 21 2023, 4:55 AM · Restricted Project, Restricted Project
Groverkss committed rG189f4aca6893: [mlir][Presburger] Remove slow applyDomainAndRange test (authored by Groverkss).
[mlir][Presburger] Remove slow applyDomainAndRange test
Aug 21 2023, 4:41 AM · Restricted Project, Restricted Project
Groverkss closed D158406: [mlir][Presburger] Remove slow applyDomainAndRange test.
Aug 21 2023, 4:40 AM · Restricted Project, Restricted Project
Groverkss retitled D158406: [mlir][Presburger] Remove slow applyDomainAndRange test from [mlir][Presburger] Disable applyDomainAndRange test to [mlir][Presburger] Remove slow applyDomainAndRange test.
Aug 21 2023, 4:09 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D158406: [mlir][Presburger] Remove slow applyDomainAndRange test.

Remove the slow test, keep the other test

Aug 21 2023, 4:08 AM · Restricted Project, Restricted Project
Groverkss requested review of D158406: [mlir][Presburger] Remove slow applyDomainAndRange test.
Aug 21 2023, 4:03 AM · Restricted Project, Restricted Project

Aug 19 2023

Groverkss committed rGb448fe0c126d: [mlir][NFC] Split OpBase.td into multiple smaller units (authored by Groverkss).
[mlir][NFC] Split OpBase.td into multiple smaller units
Aug 19 2023, 9:57 AM · Restricted Project, Restricted Project
Groverkss closed D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
Aug 19 2023, 9:57 AM · Restricted Project, Restricted Project
Groverkss added a comment to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
In D156067#4601075, @math-fehr wrote:

@Groverkss, my understanding is that since River accepted the patch, you should be able to land it as long as you fixed his comments (which I feel you did).

Aug 19 2023, 9:26 AM · Restricted Project, Restricted Project
Groverkss committed rG866391580b90: [MLIR][Presburger] Implement getDomainSet and getRangeSet for PresburgerRelation (authored by iambrj).
[MLIR][Presburger] Implement getDomainSet and getRangeSet for PresburgerRelation
Aug 19 2023, 3:43 AM · Restricted Project, Restricted Project
Groverkss closed D158263: [MLIR][Presburger] Implement getDomainSet and getRangeSet for PresburgerRelation.
Aug 19 2023, 3:43 AM · Restricted Project, Restricted Project
Groverkss committed rGa67072eeeede: [MLIR][Presburger] Fix incorrect doc comment and add const (authored by iambrj).
[MLIR][Presburger] Fix incorrect doc comment and add const
Aug 19 2023, 3:13 AM · Restricted Project, Restricted Project
Groverkss committed rG9aaf007a982a: [SCF][Transform] Add transform.loop.fuse_sibling (authored by Groverkss).
[SCF][Transform] Add transform.loop.fuse_sibling
Aug 19 2023, 3:03 AM · Restricted Project, Restricted Project
Groverkss closed D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
Aug 19 2023, 3:03 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
Aug 19 2023, 2:49 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
  • Change method name
Aug 19 2023, 2:47 AM · Restricted Project, Restricted Project
Groverkss accepted D158263: [MLIR][Presburger] Implement getDomainSet and getRangeSet for PresburgerRelation.
Aug 19 2023, 2:27 AM · Restricted Project, Restricted Project

Aug 18 2023

Groverkss added a comment to D156906: Template Matrix to allow both MPInt and Fraction.

Looks like you forgot some commits. Could you check?

Aug 18 2023, 9:32 PM · Restricted Project, Restricted Project
Groverkss added inline comments to D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
Aug 18 2023, 9:15 PM · Restricted Project, Restricted Project
Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Address comments
Aug 18 2023, 9:15 PM · Restricted Project, Restricted Project

Aug 16 2023

Groverkss committed rG2cc5f5d43c20: [mlir][Linalg] Implement tileReductionUsingScf for multiple reductions (authored by Groverkss).
[mlir][Linalg] Implement tileReductionUsingScf for multiple reductions
Aug 16 2023, 1:47 PM · Restricted Project, Restricted Project
Groverkss closed D158005: [mlir][Linalg] Implement tileReductionUsingScf for multiple reductions.
Aug 16 2023, 1:47 PM · Restricted Project, Restricted Project
Groverkss updated the diff for D158005: [mlir][Linalg] Implement tileReductionUsingScf for multiple reductions.
  • Extend if tile size vector is not of right size.
  • Update test
Aug 16 2023, 1:33 PM · Restricted Project, Restricted Project

Aug 15 2023

Groverkss added reviewers for D158005: [mlir][Linalg] Implement tileReductionUsingScf for multiple reductions: mravishankar, antiagainst, ftynse.
Aug 15 2023, 11:00 AM · Restricted Project, Restricted Project
Groverkss requested review of D158005: [mlir][Linalg] Implement tileReductionUsingScf for multiple reductions.
Aug 15 2023, 10:59 AM · Restricted Project, Restricted Project

Aug 10 2023

Groverkss added a comment to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.

@rriddle Ping :)

Aug 10 2023, 12:11 PM · Restricted Project, Restricted Project

Aug 8 2023

Groverkss updated the diff for D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
  • Add comment to explain context of isOpSibling
Aug 8 2023, 11:59 PM · Restricted Project, Restricted Project
Groverkss added inline comments to D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
Aug 8 2023, 11:54 PM · Restricted Project, Restricted Project
Groverkss updated the diff for D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
  • Add better dominance checking startergy, add more tests, address comments
Aug 8 2023, 11:51 PM · Restricted Project, Restricted Project

Aug 7 2023

Groverkss committed rGca213983ccab: [MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for… (authored by iambrj).
[MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for…
Aug 7 2023, 11:24 PM · Restricted Project, Restricted Project
Groverkss closed D156623: [MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for PresburgerRelation.
Aug 7 2023, 11:24 PM · Restricted Project, Restricted Project
Groverkss added inline comments to D156623: [MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for PresburgerRelation.
Aug 7 2023, 9:46 PM · Restricted Project, Restricted Project
Groverkss accepted D156623: [MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for PresburgerRelation.

LGTM, one small change.

Aug 7 2023, 9:44 PM · Restricted Project, Restricted Project
Groverkss added a reviewer for D156885: [MLIR][Presburger] Add simplify function: arjunp.
Aug 7 2023, 10:09 AM · Restricted Project, Restricted Project
Groverkss added a comment to D156885: [MLIR][Presburger] Add simplify function.

Some initial comments.

Aug 7 2023, 10:09 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D156623: [MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for PresburgerRelation.
Aug 7 2023, 9:57 AM · Restricted Project, Restricted Project

Aug 4 2023

Groverkss added inline comments to D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
Aug 4 2023, 7:29 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
  • Address comments
Aug 4 2023, 7:28 AM · Restricted Project, Restricted Project
Groverkss updated the summary of D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
Aug 4 2023, 7:19 AM · Restricted Project, Restricted Project

Aug 3 2023

Groverkss added a reviewer for D157069: [SCF][Transform] Add transform.loop.fuse_sibling: springerm.
Aug 3 2023, 10:53 PM · Restricted Project, Restricted Project
Groverkss added reviewers for D157069: [SCF][Transform] Add transform.loop.fuse_sibling: ftynse, dcaballe.
Aug 3 2023, 10:46 PM · Restricted Project, Restricted Project
Groverkss requested review of D157069: [SCF][Transform] Add transform.loop.fuse_sibling.
Aug 3 2023, 10:46 PM · Restricted Project, Restricted Project
Groverkss added a comment to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.

@rriddle I am now waiting for you to accept/request changes on this patch :) (Wanted to make it clear since I did not make it clear last time).

Aug 3 2023, 2:07 AM · Restricted Project, Restricted Project

Aug 2 2023

Groverkss committed rGf40af3b351a9: [MLIR][Presburger] Optimize for union & subtract (authored by gilsaia).
[MLIR][Presburger] Optimize for union & subtract
Aug 2 2023, 3:03 AM · Restricted Project, Restricted Project
Groverkss closed D156241: [MLIR][Presburger] Optimize for union & subtract.
Aug 2 2023, 3:03 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
Aug 2 2023, 2:59 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
  • Move successor/region marker to OpBase.td
Aug 2 2023, 2:58 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D156623: [MLIR][Presburger] Implement findSymbolicIntegerLexMin/Max for PresburgerRelation.
Aug 2 2023, 2:40 AM · Restricted Project, Restricted Project
Groverkss added a comment to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.

@rriddle Ping :)

Aug 2 2023, 2:39 AM · Restricted Project, Restricted Project

Jul 28 2023

Groverkss committed rG0ff1048409da: [mlir][vector] Add transform.apply_patterns.vector.fold_arith_extension (authored by Groverkss).
[mlir][vector] Add transform.apply_patterns.vector.fold_arith_extension
Jul 28 2023, 6:11 AM · Restricted Project, Restricted Project
Groverkss closed D156484: [mlir][vector] Add transform.apply_patterns.vector.fold_arith_extension.
Jul 28 2023, 6:10 AM · Restricted Project, Restricted Project

Jul 27 2023

Groverkss requested review of D156484: [mlir][vector] Add transform.apply_patterns.vector.fold_arith_extension.
Jul 27 2023, 1:51 PM · Restricted Project, Restricted Project
Groverkss added a reviewer for D156469: [mlir][tools] Introduce tblgen-to-irdl tool: jpienaar.
Jul 27 2023, 11:20 AM · Restricted Project, Restricted Project
Groverkss updated the summary of D156469: [mlir][tools] Introduce tblgen-to-irdl tool.
Jul 27 2023, 11:17 AM · Restricted Project, Restricted Project
Groverkss added reviewers for D156469: [mlir][tools] Introduce tblgen-to-irdl tool: rriddle, Mogball, mehdi_amini, math-fehr.
Jul 27 2023, 11:14 AM · Restricted Project, Restricted Project
Groverkss requested review of D156469: [mlir][tools] Introduce tblgen-to-irdl tool.
Jul 27 2023, 11:14 AM · Restricted Project, Restricted Project
Groverkss accepted D156241: [MLIR][Presburger] Optimize for union & subtract.

Nice! LGTM.

Jul 27 2023, 8:05 AM · Restricted Project, Restricted Project

Jul 26 2023

Groverkss added inline comments to D156241: [MLIR][Presburger] Optimize for union & subtract.
Jul 26 2023, 7:24 AM · Restricted Project, Restricted Project
Groverkss committed rG56863adf8eec: [MLIR][Presburger] Implement findSymbolicIntegerLexMax for IntegerRelation (authored by iambrj).
[MLIR][Presburger] Implement findSymbolicIntegerLexMax for IntegerRelation
Jul 26 2023, 7:17 AM · Restricted Project, Restricted Project
Groverkss closed D156023: [MLIR][Presburger] Implement findSymbolicIntegerLexMax for IntegerRelation.
Jul 26 2023, 7:17 AM · Restricted Project, Restricted Project

Jul 25 2023

Groverkss updated subscribers of D156241: [MLIR][Presburger] Optimize for union & subtract.
Jul 25 2023, 10:46 AM · Restricted Project, Restricted Project
Groverkss added a reviewer for D156241: [MLIR][Presburger] Optimize for union & subtract: arjunp.
Jul 25 2023, 10:46 AM · Restricted Project, Restricted Project
Groverkss accepted D156023: [MLIR][Presburger] Implement findSymbolicIntegerLexMax for IntegerRelation.

LGTM.

Jul 25 2023, 10:45 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
Jul 25 2023, 12:51 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
  • Address comments
Jul 25 2023, 12:51 AM · Restricted Project, Restricted Project

Jul 24 2023

Groverkss added a reviewer for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units: mehdi_amini.
Jul 24 2023, 1:15 AM · Restricted Project, Restricted Project
Groverkss added a comment to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.

Some other decisions that could use input:

Jul 24 2023, 1:13 AM · Restricted Project, Restricted Project

Jul 23 2023

Groverkss added a comment to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.

@rriddle I think I was able to address your comments. Could you have a look again to see if you find anything that needs to be changed? Changes again, are mostly mechanical, with the commit messages explaining each small change.

Jul 23 2023, 5:29 PM · Restricted Project, Restricted Project
Groverkss updated the diff for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
  • Move OpTraits back to OpBase
  • Move specialized type constraints and attr constraints to a seperate file
Jul 23 2023, 5:27 PM · Restricted Project, Restricted Project
Groverkss updated the diff for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
  • Move Region definations to OpBase.td
  • Move Primitive Properties to Properties.td
Jul 23 2023, 5:06 PM · Restricted Project, Restricted Project
Groverkss added inline comments to D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
Jul 23 2023, 4:34 PM · Restricted Project, Restricted Project
Groverkss added a reviewer for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units: jpienaar.
Jul 23 2023, 4:30 PM · Restricted Project, Restricted Project
Groverkss added reviewers for D156067: [mlir][NFC] Split OpBase.td into multiple smaller units: Mogball, math-fehr, ftynse.
Jul 23 2023, 4:17 PM · Restricted Project, Restricted Project
Groverkss requested review of D156067: [mlir][NFC] Split OpBase.td into multiple smaller units.
Jul 23 2023, 4:16 PM · Restricted Project, Restricted Project

Jul 22 2023

Groverkss added inline comments to D156023: [MLIR][Presburger] Implement findSymbolicIntegerLexMax for IntegerRelation.
Jul 22 2023, 1:01 PM · Restricted Project, Restricted Project

Jul 18 2023

Groverkss added inline comments to D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
Jul 18 2023, 9:49 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Address more comments
Jul 18 2023, 9:44 AM · Restricted Project, Restricted Project
Groverkss added inline comments to D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
Jul 18 2023, 7:26 AM · Restricted Project, Restricted Project
Groverkss updated the diff for D146909: [MLIR][Presburger] Add Identifier class to store identifiers and their type.
  • Address more comments
  • Address mroe comments
  • isEqual type assert
Jul 18 2023, 7:26 AM · Restricted Project, Restricted Project
Groverkss committed rG3dd9931c0f6f: [MLIR][Presburger] Implement domain and range restriction for PresburgerRelation (authored by iambrj).
[MLIR][Presburger] Implement domain and range restriction for PresburgerRelation
Jul 18 2023, 6:43 AM · Restricted Project, Restricted Project
Groverkss closed D154798: [MLIR][Presburger] Implement domain and range restriction for PresburgerRelation.
Jul 18 2023, 6:42 AM · Restricted Project, Restricted Project
Groverkss accepted D154830: [mlir] Remove dead code in Analysis/FlatLinearValueConstraints..

LGTM.

Jul 18 2023, 5:40 AM · Restricted Project, Restricted Project