Page MenuHomePhabricator

Groverkss (Kunwar Shaanjeet Singh Grover)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2021, 7:47 PM (12 w, 1 d)

Recent Activity

Yesterday

Groverkss added a comment to D110056: [MLIR] Add functionality to remove redundant local variables.

Addressed comments.

Wed, Sep 22, 3:27 AM · Restricted Project
Groverkss updated the diff for D110056: [MLIR] Add functionality to remove redundant local variables.
  • Addressed bondhugula's comments
Wed, Sep 22, 3:26 AM · Restricted Project

Tue, Sep 21

Groverkss added a comment to D110056: [MLIR] Add functionality to remove redundant local variables.

Addressed comments.

Tue, Sep 21, 1:48 PM · Restricted Project
Groverkss updated the diff for D110056: [MLIR] Add functionality to remove redundant local variables.
  • Simplified loop in removeRedundantLocalVars
Tue, Sep 21, 1:48 PM · Restricted Project
Groverkss added a comment to D110138: [MLIR] PresburgerSet: support divisions in operations.

LGTM, but please wait for others.

Tue, Sep 21, 7:06 AM · Restricted Project
Groverkss added a comment to D110056: [MLIR] Add functionality to remove redundant local variables.

Addressed comments

Tue, Sep 21, 5:23 AM · Restricted Project
Groverkss updated the diff for D110056: [MLIR] Add functionality to remove redundant local variables.
  • Addressed bondhugula's comments
Tue, Sep 21, 5:22 AM · Restricted Project
Groverkss added a comment to D110138: [MLIR] PresburgerSet: support divisions in operations.

Added some commentsG

Tue, Sep 21, 4:05 AM · Restricted Project

Mon, Sep 20

Groverkss updated the summary of D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds.
Mon, Sep 20, 2:41 AM · Restricted Project
Groverkss requested review of D110056: [MLIR] Add functionality to remove redundant local variables.
Mon, Sep 20, 2:40 AM · Restricted Project

Sun, Sep 19

Groverkss retitled D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds from Add mergeLocalIds and mergeSymbolIds to [MLIR] Add mergeLocalIds and mergeSymbolIds.
Sun, Sep 19, 11:59 PM · Restricted Project
Groverkss retitled D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds from Add toCommonLocalSpace and toCommonSymbolSpace to Add mergeLocalIds and mergeSymbolIds.
Sun, Sep 19, 11:59 PM · Restricted Project
Groverkss added a comment to D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds.

@bondhugula Thank you for the review!

Sun, Sep 19, 9:15 PM · Restricted Project
Groverkss updated the diff for D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds.
  • Addressed bondhugula's comments
Sun, Sep 19, 9:14 PM · Restricted Project
Groverkss requested review of D110045: [MLIR] Add mergeLocalIds and mergeSymbolIds.
Sun, Sep 19, 3:19 PM · Restricted Project
Groverkss abandoned D109955: [MLIR] Generalize Affine dependence analysis using Affine Relations.

As per @arjunp's suggestion, splitting this patch into separate patches.

Sun, Sep 19, 3:02 PM · Restricted Project

Sat, Sep 18

Groverkss accepted D109962: [MLIR] Simplex: support adding new variables dynamically.

LGTM

Sat, Sep 18, 8:58 AM · Restricted Project
Groverkss added a comment to D109962: [MLIR] Simplex: support adding new variables dynamically.

Added some comments.

Sat, Sep 18, 2:32 AM · Restricted Project

Fri, Sep 17

Groverkss updated the diff for D109955: [MLIR] Generalize Affine dependence analysis using Affine Relations.
  • Fixed formatting issues
Fri, Sep 17, 3:12 AM · Restricted Project
Groverkss retitled D109955: [MLIR] Generalize Affine dependence analysis using Affine Relations from Generalize Affine dependence analysis using Affine Relations to [MLIR] Generalize Affine dependence analysis using Affine Relations.
Fri, Sep 17, 1:42 AM · Restricted Project
Groverkss requested review of D109955: [MLIR] Generalize Affine dependence analysis using Affine Relations.
Fri, Sep 17, 1:29 AM · Restricted Project
Groverkss accepted D109897: [MLIR] Matrix: support resizing horizontally.

LGTM.

Fri, Sep 17, 12:46 AM · Restricted Project
Groverkss added a comment to D109897: [MLIR] Matrix: support resizing horizontally.

Added some comments.

Fri, Sep 17, 12:28 AM · Restricted Project
Groverkss accepted D109896: [MLIR] AffineStructures::removeIdRange: support specifying a range within an IdKind.

LGTM.

Fri, Sep 17, 12:18 AM · Restricted Project
Groverkss accepted D109892: [MLIR] AffineStructures: support removing a range of constraints at once.

LGTM

Fri, Sep 17, 12:01 AM · Restricted Project

Thu, Sep 16

Groverkss added a comment to D109896: [MLIR] AffineStructures::removeIdRange: support specifying a range within an IdKind.

Added some comments.

Thu, Sep 16, 12:07 PM · Restricted Project
Groverkss added a comment to D109892: [MLIR] AffineStructures: support removing a range of constraints at once.

Added some comments.

Thu, Sep 16, 11:47 AM · Restricted Project

Mon, Sep 6

Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Rebase

Mon, Sep 6, 11:58 AM · Restricted Project

Thu, Sep 2

Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
  • Addressed comments
Thu, Sep 2, 12:27 PM · Restricted Project

Aug 19 2021

Groverkss added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Hi @bondhugula , @vinayaka-polymage , gentle reminder 🙂 Are there any other changes to be made?

Aug 19 2021, 6:27 AM · Restricted Project

Aug 12 2021

Groverkss added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Hi @bondhugula, @vinayaka-polymage, I think I've addressed all the comments. Can you please check if there are any more changes to be made?

Aug 12 2021, 8:32 AM · Restricted Project

Aug 5 2021

Groverkss abandoned D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
Aug 5 2021, 12:29 AM · Restricted Project

Aug 4 2021

Groverkss updated the summary of D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Aug 4 2021, 1:55 PM · Restricted Project
Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
  • Fixed clang-format issues
Aug 4 2021, 11:09 AM · Restricted Project

Aug 3 2021

Groverkss added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Addressed Comments.

Aug 3 2021, 5:39 PM · Restricted Project
Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
  • Addressed comments
Aug 3 2021, 5:38 PM · Restricted Project
Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Rebased to latest main branch

Aug 3 2021, 4:20 PM · Restricted Project

Aug 2 2021

Groverkss added a comment to D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.

Addressed comments.

Aug 2 2021, 3:14 AM · Restricted Project
Groverkss updated the diff for D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
  • Updated exaxmples in detectAsFloorDiv docs
Aug 2 2021, 3:08 AM · Restricted Project
Groverkss updated the summary of D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
Aug 2 2021, 1:42 AM · Restricted Project
Groverkss added inline comments to D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
Aug 2 2021, 1:40 AM · Restricted Project

Aug 1 2021

Groverkss added a comment to D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.

Addressed comments.

Aug 1 2021, 3:24 AM · Restricted Project
Groverkss updated the summary of D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
Aug 1 2021, 3:24 AM · Restricted Project
Groverkss updated the diff for D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
  • Fixed clang-tidy errors and add punctuation in some comments
Aug 1 2021, 3:18 AM · Restricted Project

Jul 31 2021

Groverkss added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Moved the bugfix to a separate patch: https://reviews.llvm.org/D107214

Jul 31 2021, 3:06 AM · Restricted Project
Groverkss updated the diff for D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
  • Added test for bugfix
Jul 31 2021, 1:52 AM · Restricted Project
Groverkss requested review of D107214: [MLIR] FlatAffineConstraints: Fixed bug where some divisions were not being detected.
Jul 31 2021, 12:54 AM · Restricted Project

Jul 29 2021

Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
  • Added punctuation in comments
Jul 29 2021, 6:22 AM · Restricted Project
Groverkss added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Addressed more review comments.

Jul 29 2021, 6:16 AM · Restricted Project
Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
  • Improved testing for computing divisions and fixed some bugs
Jul 29 2021, 6:16 AM · Restricted Project

Jul 26 2021

Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Fixed accidently removed commits

Jul 26 2021, 6:11 AM · Restricted Project

Jul 25 2021

Groverkss updated the diff for D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Addressed review comments

Jul 25 2021, 3:57 PM · Restricted Project
Groverkss added a comment to D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.

Thank you for the review!

Jul 25 2021, 3:56 PM · Restricted Project

Jul 23 2021

Groverkss requested review of D106662: [MLIR] FlatAffineConstraints: Refactored computation of explicit representation for identifiers.
Jul 23 2021, 7:04 AM · Restricted Project

Jul 17 2021

Groverkss updated the diff for D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
  • Fixed formatting issues
Jul 17 2021, 1:04 AM · Restricted Project
Groverkss updated the diff for D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
  • Fixed failing tests
Jul 17 2021, 12:26 AM · Restricted Project

Jul 16 2021

Groverkss updated the diff for D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.

Restored accidently deleted previous commits

Jul 16 2021, 2:16 PM · Restricted Project
Groverkss updated the diff for D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
  • Addressed arjunp's comments
  • Fixed punctuation in comments
Jul 16 2021, 12:06 PM · Restricted Project
Groverkss added inline comments to D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
Jul 16 2021, 12:04 PM · Restricted Project
Groverkss updated the summary of D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
Jul 16 2021, 5:48 AM · Restricted Project
Groverkss added reviewers for D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers: arjunp, bondhugula, ftynse, andydavis1.
Jul 16 2021, 5:47 AM · Restricted Project
Groverkss requested review of D106145: [MLIR] FlatAffineConstraints : Store explicit division representation for local identifiers.
Jul 16 2021, 5:45 AM · Restricted Project