grosser (Tobias Grosser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2014, 11:40 AM (207 w, 4 d)

Recent Activity

Fri, Jul 20

grosser accepted D49021: [Polly][isl] Simplify iterator implementation by building on top of list accessors.

LGTM

Fri, Jul 20, 6:09 AM

Tue, Jul 17

grosser abandoned D47604: [Polly] Add isl C++ list iterators.

This has become obsolete, after Philip Pfaffe committed a better variant of this feature.

Tue, Jul 17, 9:17 PM
grosser committed rL337248: [DependenceInfo] Use isl++ to replace foreach_set with for loop.
[DependenceInfo] Use isl++ to replace foreach_set with for loop
Tue, Jul 17, 12:13 AM
grosser committed rL337247: [IslNodeBuilder] Use isl++ to replace foreach_set with for loop.
[IslNodeBuilder] Use isl++ to replace foreach_set with for loop
Tue, Jul 17, 12:13 AM

Mon, Jul 16

grosser committed rL337246: [ScopInfo] Replace isl foreach calls with for loops.
[ScopInfo] Replace isl foreach calls with for loops
Mon, Jul 16, 11:46 PM
grosser committed rL337245: [ZoneAlgo] Replace isl foreach calls with for loops.
[ZoneAlgo] Replace isl foreach calls with for loops
Mon, Jul 16, 11:39 PM
grosser committed rL337244: [FlattenSchedule] Replace isl foreach calls with for loops.
[FlattenSchedule] Replace isl foreach calls with for loops
Mon, Jul 16, 11:38 PM
grosser committed rL337243: [MaximalStaticExpansion] Replace isl foreach calls with for loops.
[MaximalStaticExpansion] Replace isl foreach calls with for loops
Mon, Jul 16, 11:38 PM
grosser committed rL337242: [ForwardOpTree] Replace isl foreach calls with for loops.
[ForwardOpTree] Replace isl foreach calls with for loops
Mon, Jul 16, 11:38 PM
grosser committed rL337241: [Simplify] Replace isl foreach calls with for loops.
[Simplify] Replace isl foreach calls with for loops
Mon, Jul 16, 11:38 PM
grosser committed rL337239: [FlattenAlgo] Replace more isl foreach calls with for loops.
[FlattenAlgo] Replace more isl foreach calls with for loops
Mon, Jul 16, 11:22 PM
grosser committed rL337238: [FlattenAlgo] Replace some isl foreach calls with for loops.
[FlattenAlgo] Replace some isl foreach calls with for loops
Mon, Jul 16, 11:17 PM
grosser committed rL337237: [unittest/DeLICM] Replace isl foreach calls with for loops.
[unittest/DeLICM] Replace isl foreach calls with for loops
Mon, Jul 16, 11:13 PM
grosser committed rL337201: [ScopInfo] Replace isl foreach calls with for loops.
[ScopInfo] Replace isl foreach calls with for loops
Mon, Jul 16, 12:09 PM

Fri, Jul 13

grosser added a comment to D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

You can commit this. It will just be covered in the next update.

Fri, Jul 13, 6:37 AM

Tue, Jul 10

grosser added a comment to D49130: Fix OpenCL Work-Item function arguments in Polly.

Sorry guys. Alain just started to look into this last week and we wanted to get him up-to-speed before getting in touch with you. I should have helped to coordinate better. I asked Alain to discuss with you which / what patches are still needed.

Tue, Jul 10, 7:35 AM · Restricted Project
grosser added a comment to D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

I have a patched version of the generator (very hacky) on top of the isl bindings. Not sure if this (happens to) be the right one: https://github.com/tobig/isl/tree/polly-bindings-andrei

Tue, Jul 10, 7:34 AM
grosser added a comment to D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

Right. I am busy today, but can do a normal update thursday afternoon. I will then also push the current generator to github.

Tue, Jul 10, 5:50 AM

Fri, Jul 6

grosser accepted D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

LGTM

Fri, Jul 6, 7:27 AM
grosser committed rL336425: Update isl to isl-0.19-224-gce84a511.
Update isl to isl-0.19-224-gce84a511
Fri, Jul 6, 2:05 AM

Thu, Jul 5

grosser committed rL336362: [ScopInfo] Move foldSizeConstantsToRight() to isl++.
[ScopInfo] Move foldSizeConstantsToRight() to isl++
Thu, Jul 5, 8:28 AM
grosser closed D48965: [ScopInfo] Move foldSizeConstantsToRight() to isl++.
Thu, Jul 5, 8:28 AM
grosser accepted D48965: [ScopInfo] Move foldSizeConstantsToRight() to isl++.

LGTM.

Thu, Jul 5, 8:10 AM

Wed, Jul 4

grosser committed rL336281: ScopInfo: simplify equivalence classes before storing them [NFCI].
ScopInfo: simplify equivalence classes before storing them [NFCI]
Wed, Jul 4, 7:58 AM

Tue, Jul 3

grosser added a comment to D48883: [Polly-ACC] Add isl_space.h to gpu_tree.c.

Yes, raise we should raise the version. Also, please add a propoer commit message explaining what the underlying error was here. We should also make sure that this bug has been fixed in the latest ppcg, such that we do not re-import it again.

Tue, Jul 3, 8:56 AM

Fri, Jun 29

grosser accepted D48774: [polly-acc] change cl_get_* return types to 32/64bit.

Also looks good from me except the minor changes. Please update the patch if you agree.

Fri, Jun 29, 2:20 PM
grosser committed rL335971: Use range for in normalizeValInst [NFCI].
Use range for in normalizeValInst [NFCI]
Fri, Jun 29, 6:11 AM
grosser committed rL335970: Translate a couple of foreach callbacks into range-based iterator loops.
Translate a couple of foreach callbacks into range-based iterator loops
Fri, Jun 29, 5:28 AM
grosser committed rL335966: Add missing namespace specifier.
Add missing namespace specifier
Fri, Jun 29, 4:54 AM

Thu, Jun 28

grosser added a comment to D48651: [RFC] Pattern matching on schedule trees..

@ftynse, the source is referenced in the patch summary. If we commit such a patch to Polly, we must make we have your permission to contribute it under the LLVM license and obviously need to acknowledge the source. For now, I asked Lorenzo to push the code as RFC to allow others to see how it would be used. This already sparked a comment from Philip and will likely spark further discussions on how to extend the interface. Thanks for commenting.

Thu, Jun 28, 2:33 AM · Restricted Project
grosser committed rL335813: test: use regex matchers to make test-case robust against register renumberings.
test: use regex matchers to make test-case robust against register renumberings
Thu, Jun 28, 12:16 AM

Tue, Jun 26

grosser accepted D48579: [Polly][ZoneAlgo] Use getDefToTarget in makeValInst. NFC..

Nice!

Tue, Jun 26, 4:54 AM · Restricted Project

Jun 19 2018

grosser committed rL335029: Move ScopInfo to isl++.
Move ScopInfo to isl++
Jun 19 2018, 1:18 AM

Jun 18 2018

grosser committed rL334941: Adjust for clang-format changes.
Adjust for clang-format changes
Jun 18 2018, 6:09 AM
grosser committed rL334940: [ScopInfo] Move splitAliasGroupsByDomain and getAccessDomain to isl++ [NFCI].
[ScopInfo] Move splitAliasGroupsByDomain and getAccessDomain to isl++ [NFCI]
Jun 18 2018, 5:57 AM
grosser committed rL334939: [ScopInfo] Move more functions to isl++ [NFCI].
[ScopInfo] Move more functions to isl++ [NFCI]
Jun 18 2018, 5:54 AM
grosser committed rL334938: [ScopInfo] Move addNonEmptyDomainConstraints to isl++ [NFCI].
[ScopInfo] Move addNonEmptyDomainConstraints to isl++ [NFCI]
Jun 18 2018, 5:46 AM
grosser committed rL334937: Move buildConditionSet to C++.
Move buildConditionSet to C++
Jun 18 2018, 5:40 AM

Jun 16 2018

grosser added a comment to D48136: [Polly] Implement an iterator for isl maps, basic_maps, sets, basic_sets.

Thank you Philip. This clearly looks a lot better than my patch. From my perspective this looks good after Michael's comments are addressed. Thanks a lot.

Jun 16 2018, 10:53 AM
grosser committed rL334893: Adjust to recent LLVM changes to fix buildbots.
Adjust to recent LLVM changes to fix buildbots
Jun 16 2018, 10:42 AM

Jun 13 2018

grosser committed rL334661: [test] Fix a typo in a test case [NFCI].
[test] Fix a typo in a test case [NFCI]
Jun 13 2018, 2:50 PM

Jun 11 2018

grosser committed rL334413: Drop unnecessary whitespace [NFCI].
Drop unnecessary whitespace [NFCI]
Jun 11 2018, 8:16 AM
grosser committed rL334412: [ScopBuilder] Slightly improve code structure [NFCI].
[ScopBuilder] Slightly improve code structure [NFCI]
Jun 11 2018, 8:03 AM
grosser committed rL334406: Update isl to isl-0.19-185-g8e9f55ce.
Update isl to isl-0.19-185-g8e9f55ce
Jun 11 2018, 7:30 AM

Jun 6 2018

grosser accepted D47752: [Polly][OpTree] Introduce shortcut for computing the def->target mapping. NFCI..

Cool.

Jun 6 2018, 9:55 AM · Restricted Project
grosser committed rL334092: getDependences to new C++ interface.
getDependences to new C++ interface
Jun 6 2018, 6:15 AM
grosser closed D47786: getDependences to new C++ interface.
Jun 6 2018, 6:14 AM · Restricted Project

Jun 5 2018

grosser accepted D47786: getDependences to new C++ interface.

LGTM.

Jun 5 2018, 8:35 AM · Restricted Project
grosser committed rL333988: Fix formatting.
Fix formatting
Jun 5 2018, 2:08 AM

Jun 1 2018

grosser retitled D47604: [Polly] Add isl C++ list iterators from Add isl C++ list iterators to [Polly] Add isl C++ list iterators.
Jun 1 2018, 12:18 PM
grosser added a comment to D47252: partitionSetParts from C to C++ interface..

Done. Thanks Lorenzo!

Jun 1 2018, 12:16 PM · Restricted Project
grosser committed rL333780: partitionSetParts from C to C++ interface..
partitionSetParts from C to C++ interface.
Jun 1 2018, 12:16 PM
grosser closed D47252: partitionSetParts from C to C++ interface..
Jun 1 2018, 12:16 PM · Restricted Project
grosser accepted D47252: partitionSetParts from C to C++ interface..

LGTM.

Jun 1 2018, 11:33 AM · Restricted Project
grosser abandoned D46227: [islpp] Do not abuse isl::stat::error as early-abort.

Dropping this in favor of D47604. Thanks for the suggestions!

Jun 1 2018, 11:03 AM
grosser added a comment to D47252: partitionSetParts from C to C++ interface..

@chelini : any plans to update this patch?

Jun 1 2018, 11:02 AM · Restricted Project

May 31 2018

grosser added reviewers for D47604: [Polly] Add isl C++ list iterators: philip.pfaffe, alexandre.isoard.
May 31 2018, 1:25 PM
grosser created D47604: [Polly] Add isl C++ list iterators.
May 31 2018, 1:10 PM
grosser committed rL333688: Update isl C++ bindings.
Update isl C++ bindings
May 31 2018, 12:52 PM

May 30 2018

grosser committed rL333621: Update isl to isl-0.19-173-g77fe2538.
Update isl to isl-0.19-173-g77fe2538
May 30 2018, 9:03 PM

May 28 2018

grosser added a comment to D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.

Committed. These changes are very useful. Thanks!

May 28 2018, 12:51 AM
grosser committed rL333366: [ScopInfo] Update Scop::addUserContext() to C++ interface.
[ScopInfo] Update Scop::addUserContext() to C++ interface
May 28 2018, 12:49 AM
grosser closed D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.
May 28 2018, 12:49 AM
grosser accepted D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.

This LGTM.

May 28 2018, 12:37 AM

May 27 2018

grosser requested changes to D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.

This looks good. Please also update the summary / commit message.

May 27 2018, 11:32 PM
grosser accepted D47385: [Polly][ForwardOpTree] Use less computationally expensive method to compute def-to-target map. NFCI..

LGTM

May 27 2018, 11:22 PM · Restricted Project
grosser added a comment to D47385: [Polly][ForwardOpTree] Use less computationally expensive method to compute def-to-target map. NFCI..

Hi Michael,

May 27 2018, 11:22 PM · Restricted Project
grosser requested changes to D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.

Very nice!

May 27 2018, 11:03 PM

May 26 2018

grosser added a comment to D47385: [Polly][ForwardOpTree] Use less computationally expensive method to compute def-to-target map. NFCI..

This is a very good idea. I am out of office, but will review this Sunday night.

May 26 2018, 2:53 AM · Restricted Project

May 23 2018

grosser committed rL333118: Update isl to isl-0.19-152-g437e6ab0.
Update isl to isl-0.19-152-g437e6ab0
May 23 2018, 1:23 PM
grosser committed rL333113: createNextIterationMap from C to C++ interface.
createNextIterationMap from C to C++ interface
May 23 2018, 11:45 AM
grosser closed D47102: createNextIterationMap from C to C++ interface.
May 23 2018, 11:45 AM · Restricted Project
grosser added a comment to D47252: partitionSetParts from C to C++ interface..

@cs15btech11044, would you like to review this patch? (Be careful, there are a couple of things that should be fixed)

May 23 2018, 5:39 AM · Restricted Project

May 19 2018

grosser added a comment to D47102: createNextIterationMap from C to C++ interface.

@cs15btech11044, I try to get you involved in the code review process. Would you like to review this patch?

May 19 2018, 3:58 AM · Restricted Project

May 16 2018

grosser added a comment to D46227: [islpp] Do not abuse isl::stat::error as early-abort.

Thanks. I am currently upstreaming a set of functions to isl which allow us to get basic_map_lists from a map and map_lists from a union_map. For isl_*_list types it should be easy to write an iterator that allows foreach loops. I plan to write such iterators and will then use these to simplify this code.

May 16 2018, 8:00 AM
grosser added a comment to D46935: [ScopInfo] Remove usage of isl_set_n_basic_set().

Very cool. Thanks for moving this forward.

May 16 2018, 5:16 AM

May 15 2018

grosser accepted D46868: [Polly] Create Scop name lazily.

LGTM. Can you potentially include the old SVN revisions in your commit message?

May 15 2018, 5:18 AM
grosser accepted D46869: [Polly][arc] Remove unittesting from arcconfig.

LGTM.

May 15 2018, 5:18 AM

May 10 2018

grosser added a comment to D46696: [IRTests] Verify PDT instead of DT.

Looks good to me as well. Let's see what Kuba says.

May 10 2018, 8:31 AM

May 9 2018

grosser accepted D46445: [SCEVAffinator] Fix handling of pwaff complexity limit..

LGTM.

May 9 2018, 10:03 PM
grosser accepted D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

That's fine with me.

May 9 2018, 2:25 AM

May 8 2018

grosser committed rL331744: [test] Replace undef with true/false to make test case less fragile.
[test] Replace undef with true/false to make test case less fragile
May 8 2018, 12:28 AM

May 7 2018

grosser added a comment to D46445: [SCEVAffinator] Fix handling of pwaff complexity limit..

This generally looks good, but I agree we should move the code to a separate function.

May 7 2018, 1:34 AM

Apr 29 2018

grosser added a comment to D46227: [islpp] Do not abuse isl::stat::error as early-abort.

Thanks @philip.pfaffe . Is this fine from your side, otherwise?

Apr 29 2018, 6:37 AM
grosser added a reviewer for D46231: Move to new C++ binding interface that requires isl::quota annotations [RFC]: philip.pfaffe.
Apr 29 2018, 12:48 AM
grosser created D46231: Move to new C++ binding interface that requires isl::quota annotations [RFC].
Apr 29 2018, 12:48 AM
grosser updated the diff for D46227: [islpp] Do not abuse isl::stat::error as early-abort.

Address some of Philips comments

Apr 29 2018, 12:29 AM
grosser added inline comments to D46227: [islpp] Do not abuse isl::stat::error as early-abort.
Apr 29 2018, 12:27 AM

Apr 28 2018

grosser committed rL331129: Remove another set or release() calls.
Remove another set or release() calls
Apr 28 2018, 6:01 PM
grosser committed rL331130: Remove keep/take/give from isl C++ bindings.
Remove keep/take/give from isl C++ bindings
Apr 28 2018, 6:01 PM
grosser committed rL331126: Remove the last uses of isl::give and isl::take.
Remove the last uses of isl::give and isl::take
Apr 28 2018, 5:34 PM
grosser committed rL331125: Fix one unit test.
Fix one unit test
Apr 28 2018, 5:34 PM
grosser committed rL331122: [DeLICM] Remove uses of isl::give.
[DeLICM] Remove uses of isl::give
Apr 28 2018, 3:15 PM
grosser committed rL331121: [ZoneAlgo] Remove uses of isl::give - II.
[ZoneAlgo] Remove uses of isl::give - II
Apr 28 2018, 3:15 PM
grosser committed rL331120: [ZoneAlgo] Remove uses of isl::give.
[ZoneAlgo] Remove uses of isl::give
Apr 28 2018, 2:25 PM
grosser committed rL331119: [islpp] Remove use of isl::give from unittests.
[islpp] Remove use of isl::give from unittests
Apr 28 2018, 2:09 PM
grosser committed rL331118: [MaximalStaticExpansion] Replace copied function with version from ISLTools.
[MaximalStaticExpansion] Replace copied function with version from ISLTools
Apr 28 2018, 1:47 PM
grosser updated the diff for D46227: [islpp] Do not abuse isl::stat::error as early-abort.

Convert two more functions

Apr 28 2018, 11:28 AM
grosser added reviewers for D46227: [islpp] Do not abuse isl::stat::error as early-abort: philip.pfaffe, Meinersbur, sebpop, fhahn.
Apr 28 2018, 11:15 AM
grosser created D46227: [islpp] Do not abuse isl::stat::error as early-abort.
Apr 28 2018, 11:14 AM