grosser (Tobias Grosser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2014, 11:40 AM (155 w, 2 d)

Recent Activity

Yesterday

grosser added a comment to D35754: [ForwardOpTree] Introduce the -polly-optree pass..

One more typo.

Fri, Jul 21, 11:04 PM · Restricted Project
grosser accepted D35754: [ForwardOpTree] Introduce the -polly-optree pass..
Fri, Jul 21, 10:43 PM · Restricted Project
grosser committed rL308801: Move ScopArrayInfo to isl++.
Move ScopArrayInfo to isl++
Fri, Jul 21, 4:08 PM
grosser abandoned D35731: [Polly] Introduce isl_conv:: isl++ classes that automatically convert to old C classes.

OK, you are probably right that this is not needed. Overall, there are around 200 calls to change. I will just class by class directly to the new interface.

Fri, Jul 21, 3:21 PM · Restricted Project
grosser updated the diff for D35731: [Polly] Introduce isl_conv:: isl++ classes that automatically convert to old C classes.

Add missing conversion class.

Fri, Jul 21, 1:03 PM · Restricted Project
grosser created D35731: [Polly] Introduce isl_conv:: isl++ classes that automatically convert to old C classes.
Fri, Jul 21, 12:59 PM · Restricted Project
grosser added a comment to D35721: [Polly] [PPCGCodeGeneration] Handle 1-d pointers to scalars in array size..

Yes, this is a total hack. The underlying bugs are:

Fri, Jul 21, 11:14 AM
grosser added a comment to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Can you add -fno-vectorize and try again?

Fri, Jul 21, 10:52 AM · Restricted Project
grosser added a comment to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Or even better use test/create_ll.sh?

Fri, Jul 21, 10:52 AM · Restricted Project
grosser requested changes to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.
Fri, Jul 21, 10:52 AM · Restricted Project
grosser requested changes to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Thanks for the test case. I have one additional comment. Otherwise, i agree with Siddharth's comments.

Fri, Jul 21, 10:21 AM · Restricted Project
grosser added a comment to D35728: [Polly] [NFC] [ScopDetection] Make `polly-only-func` perform regex scop name match..

Thanks Michael!

Fri, Jul 21, 9:11 AM
grosser accepted D35727: [Polly] Untangle ScopInfo lit-testcases from specifics of the legacy-PM.

LGTM! Very nice!

Fri, Jul 21, 8:56 AM · Restricted Project
grosser accepted D35728: [Polly] [NFC] [ScopDetection] Make `polly-only-func` perform regex scop name match..

Cool!

Fri, Jul 21, 8:55 AM

Thu, Jul 20

grosser committed rL308715: Fix typo in function name Bllock -> Block.
Fix typo in function name Bllock -> Block
Thu, Jul 20, 11:01 PM
grosser created D35703: [GPGPU] Add support for NVIDIA libdevice.
Thu, Jul 20, 3:44 PM · Restricted Project
grosser committed rL308649: Support fabs and copysign in Polly-ACC.
Support fabs and copysign in Polly-ACC
Thu, Jul 20, 11:27 AM
grosser accepted D35676: [Polly] [PPCG] [2/3] Collect all changes to `lib/External/*` due to PPCG update..
Thu, Jul 20, 7:19 AM
grosser accepted D35677: [WIP] [Polly] [PPCGCodeGeneration + PPCG] [3/3] Collect changes to PPCGCodeGen because of PPCG upgrade..
Thu, Jul 20, 7:18 AM

Wed, Jul 19

grosser added a comment to D35653: [WIP] [Polly] [PPCG] Bump up PPCG to v0.07.

Nice. Is there any reason this is still marked as WIP? Sould I already have a look.

Wed, Jul 19, 9:40 PM
grosser requested changes to D35653: [WIP] [Polly] [PPCG] Bump up PPCG to v0.07.
Wed, Jul 19, 9:40 PM
grosser requested changes to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Also mark this as requesting changes to make sure this is not in my review queue any more.

Wed, Jul 19, 9:38 PM · Restricted Project
grosser accepted D35656: [Polly][Simplify] Remove unused instructions and accesses..
Wed, Jul 19, 9:37 PM · Restricted Project
grosser accepted D35636: [Dominators] Change Roots type to SmallVector.

LGTM

Wed, Jul 19, 10:52 AM
grosser accepted D35631: [Polly][ScopInfo] Integrate ScalarDefUseChain into polly::Scop. NFC..

LGTM.

Wed, Jul 19, 9:58 AM · Restricted Project
grosser added a comment to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Amazing. Can you add a test case?

Wed, Jul 19, 9:55 AM · Restricted Project
grosser accepted D33138: [Polly][WIP] Make the pattern matching work with modified memory accesses.

Nice!

Wed, Jul 19, 9:33 AM
grosser committed rL308491: [ScopInfo] Do not create entries in map if non exists.
[ScopInfo] Do not create entries in map if non exists
Wed, Jul 19, 9:31 AM
grosser added a comment to D35471: [Polly] [RFC] Calculate AST expression type.

More comments:

  • Can you check if the constructors miss some isl cleanups.
  • There are more isl print output changes
Wed, Jul 19, 7:19 AM
grosser abandoned D35403: Phabricator Test.

@grosser-test

Wed, Jul 19, 7:19 AM
grosser added a comment to D35471: [Polly] [RFC] Calculate AST expression type.

Hi Maximilian,

Wed, Jul 19, 6:05 AM
grosser committed rL308440: [ScopInfo] Use AnyPHINode in tryGetValueStored().
[ScopInfo] Use AnyPHINode in tryGetValueStored()
Wed, Jul 19, 4:31 AM
grosser committed rL308435: [ScopInfo] Introduce tryGetValueStored.
[ScopInfo] Introduce tryGetValueStored
Wed, Jul 19, 4:09 AM
grosser closed D35585: [ScopInfo] Introduce tryGetValueStored by committing rL308435: [ScopInfo] Introduce tryGetValueStored.
Wed, Jul 19, 4:09 AM · Restricted Project

Tue, Jul 18

grosser committed rL308403: [Polly][docs][Release Notes] Adding Information about Remarks to Release Notes….
[Polly][docs][Release Notes] Adding Information about Remarks to Release Notes…
Tue, Jul 18, 6:19 PM
grosser closed D35596: [Polly][docs][Release Notes] Adding Information about Remarks to Release Notes and Documentation by committing rL308403: [Polly][docs][Release Notes] Adding Information about Remarks to Release Notes….
Tue, Jul 18, 6:18 PM · Restricted Project
grosser accepted D35596: [Polly][docs][Release Notes] Adding Information about Remarks to Release Notes and Documentation.

Great! Thanks for working on this!

Tue, Jul 18, 6:08 PM · Restricted Project
grosser added a comment to D35471: [Polly] [RFC] Calculate AST expression type.

Nice. I will have a look immediately. I am also at ETH tomorrow in case you wanna chat.

Tue, Jul 18, 3:27 PM
grosser added a comment to D35478: Support sext and trunc instructions in SCEV delinearization algorithm.

Hi Manuel,

Tue, Jul 18, 3:25 PM · Restricted Project
grosser created D35585: [ScopInfo] Introduce tryGetValueStored.
Tue, Jul 18, 3:18 PM · Restricted Project
grosser added a comment to D35571: [Dominators] Improve error checking in deleteEdge.

Can you maybe document that splitEdge is supposed to only be called on nodes that are part of the dominator tree.

Tue, Jul 18, 11:26 AM
grosser committed rL308320: Fix: Invalid value for "--commit": --sandbox is not a valid integer.
Fix: Invalid value for "--commit": --sandbox is not a valid integer
Tue, Jul 18, 8:44 AM
grosser added a comment to D35060: [Polly] [PPCGCodegen] [Crash] [WIP] PPCG + invariant load hoisting.
[PPCGCodeGeneration] Generate invariant loads before trying to generate IR.
Tue, Jul 18, 8:24 AM
grosser added a comment to D35486: [Polly] [PPCGCodeGeneration] [WIP] Do not consider writes to killable scalars as scalar stores.

Seems inconsistent, I get for the following input:

Tue, Jul 18, 3:56 AM

Mon, Jul 17

grosser added a reviewer for D35478: Support sext and trunc instructions in SCEV delinearization algorithm: sebpop.

Add Sebastian as reviewer.

Mon, Jul 17, 8:46 PM · Restricted Project
grosser accepted D35528: [Dominators] Teach LoopUnswitch to use the incremental API.

This looks good to me! Thank you.

Mon, Jul 17, 8:31 PM
grosser accepted D35430: DA: remove uses of GEP, only ask SCEV.

LGTM. Thank you Sebastian!

Mon, Jul 17, 8:18 PM
grosser added a comment to D35471: [Polly] [RFC] Calculate AST expression type.
In D35471#812102, @maxf wrote:

Hello Tobias,

as for (1): Hmm, I can do that, at least for now. I'd rather have them in in the final version so that we also test this feature whenever possible, but I guess it makes sense to differ between tests that fail and tests that only fail due to format changes now. I'd disable printing bounds in ISL_C format for now and put it back in the final version, along with fixed testcases, if that's okay with you?

Mon, Jul 17, 8:03 PM
grosser added a comment to D35458: [Polly][PM][WIP] Polly pass registration.

That looks great so far.

Mon, Jul 17, 2:02 PM · Restricted Project
grosser added a comment to D35301: [Polly] Introduce list of statements in Scop::StmtMap. NFC.

@Meinersbur: If you find time, would be great to check if the unit tests are still broken under windows.

Mon, Jul 17, 2:00 PM · Restricted Project
grosser committed rL308220: [Polly] Avoid use of `getStmtFor(BB)` in PolyhedralInfo. NFC.
[Polly] Avoid use of `getStmtFor(BB)` in PolyhedralInfo. NFC
Mon, Jul 17, 1:58 PM
grosser closed D35300: [Polly] Avoid use of `getStmtFor(BB)` in PolyhedralInfo. NFC by committing rL308220: [Polly] Avoid use of `getStmtFor(BB)` in PolyhedralInfo. NFC.
Mon, Jul 17, 1:58 PM · Restricted Project
grosser added a comment to D35399: [Polly] [OptDiag] Updating Polly Diagnostics Remarks.

@tarunr : Do you plan to commit this patch or do you need somebody to commit this patch for you?

Mon, Jul 17, 1:57 PM · Restricted Project
grosser closed D35237: [ScopInfo] Simplify new access functions under domain context by committing rL308215: [ScopInfo] Simplify new access functions under domain context.
Mon, Jul 17, 1:47 PM · Restricted Project
grosser added a comment to D35486: [Polly] [PPCGCodeGeneration] [WIP] Do not consider writes to killable scalars as scalar stores.

Thanks for pushing forward here. One thing I would like to check if the scalars that are private are passed into the kernel or not. AFAIU ppcg is not passing such "private" scalars to the kernel, but Polly-ACC still does this today. Can you check if/what is going on here?

Mon, Jul 17, 8:57 AM
grosser accepted D35410: [Polly] [PPCGCodeGeneration] Make sure invariant loads are generated before trying to generate LLVM from GPUNodeBuilder. [NFC].

LGTM

Mon, Jul 17, 8:32 AM

Sun, Jul 16

grosser added a comment to D35471: [Polly] [RFC] Calculate AST expression type.

Hi Maximilian,

Sun, Jul 16, 11:00 PM
grosser requested changes to D35460: [Polly] [WIP] Move Scop::DomainMap to a local scope.
Sun, Jul 16, 5:09 PM · Restricted Project
grosser added a comment to D35460: [Polly] [WIP] Move Scop::DomainMap to a local scope.

And one more:

Sun, Jul 16, 5:09 PM · Restricted Project
grosser added a comment to D35460: [Polly] [WIP] Move Scop::DomainMap to a local scope.

Hi Nandini,

Sun, Jul 16, 5:08 PM · Restricted Project
grosser committed rL308152: ScopInfo: Remove not-in-DomainMap statements in separate function.
ScopInfo: Remove not-in-DomainMap statements in separate function
Sun, Jul 16, 4:56 PM
grosser committed rL308149: Fix typo in comment [NFC].
Fix typo in comment [NFC]
Sun, Jul 16, 3:44 PM
grosser accepted D35458: [Polly][PM][WIP] Polly pass registration.

It seems adding an "early" EP is not so easy. In this case, let's just leave it and start testing with DeLICM and co enabled. If they are not yet up-to what we need, we anyhow should report bugs. Feel free to commit this as soon as the prerequsites are in.

Sun, Jul 16, 2:48 PM · Restricted Project
grosser added a comment to D35458: [Polly][PM][WIP] Polly pass registration.

Hi Philip,

Sun, Jul 16, 1:21 PM · Restricted Project
grosser added a comment to D35258: [Plugins] Add a slim plugin API to work together with the new PM.

Very cool to see this working!

Sun, Jul 16, 1:21 PM
grosser requested changes to D35458: [Polly][PM][WIP] Polly pass registration.

Mark this as "request changes" to move this out of my "to-review" queue.

Sun, Jul 16, 6:56 AM · Restricted Project
grosser committed rL308134: [Polly] Fix a typo [NFC].
[Polly] Fix a typo [NFC]
Sun, Jul 16, 6:55 AM
grosser closed D35459: [Polly] Fix a typo by committing rL308134: [Polly] Fix a typo [NFC].
Sun, Jul 16, 6:55 AM · Restricted Project
grosser requested changes to D33138: [Polly][WIP] Make the pattern matching work with modified memory accesses.
Sun, Jul 16, 2:51 AM
grosser added a comment to D33138: [Polly][WIP] Make the pattern matching work with modified memory accesses.

Hi Roman,

Sun, Jul 16, 2:51 AM
grosser requested changes to D35457: [Polly] [Docs] Update islpp documentation.

Instead of adding more content to the Release notes, we can then directly link to the isl-documentation section. By not being part of the release notes, this information will also be preserved for the future.

Sun, Jul 16, 12:45 AM · Restricted Project
grosser added a comment to D35457: [Polly] [Docs] Update islpp documentation.

Hi Nandini,

Sun, Jul 16, 12:44 AM · Restricted Project
grosser added a comment to D35458: [Polly][PM][WIP] Polly pass registration.

Hi Philip,

Sun, Jul 16, 12:41 AM · Restricted Project

Sat, Jul 15

grosser accepted D35300: [Polly] Avoid use of `getStmtFor(BB)` in PolyhedralInfo. NFC.

This looks good to me

Sat, Jul 15, 3:45 PM · Restricted Project
grosser added a comment to D35453: [Polly] Translate Scop::DomainMap to islpp.

Amazing. I just pushed this out! Good work.

Sat, Jul 15, 5:42 AM · Restricted Project
grosser committed rL308093: [Polly] Translate Scop::DomainMap to islpp.
[Polly] Translate Scop::DomainMap to islpp
Sat, Jul 15, 5:42 AM
grosser closed D35453: [Polly] Translate Scop::DomainMap to islpp by committing rL308093: [Polly] Translate Scop::DomainMap to islpp.
Sat, Jul 15, 5:42 AM · Restricted Project
grosser added a comment to D35308: [Polly] Use Isl c++ for InvalidDomainMap.

OK. Then we should highlight this in *bold* at an obvious place of our documentation.

Sat, Jul 15, 2:31 AM · Restricted Project
grosser added a comment to D35308: [Polly] Use Isl c++ for InvalidDomainMap.

OK, can you share (and maybe document) what you misunderstood? Others likely make similar mistakes, so it is good to have this documented and explained.

Sat, Jul 15, 2:26 AM · Restricted Project
grosser added a comment to D35308: [Polly] Use Isl c++ for InvalidDomainMap.

Hi Nandini,

Sat, Jul 15, 2:05 AM · Restricted Project
grosser committed rL308089: [Polly] Use Isl c++ for InvalidDomainMap.
[Polly] Use Isl c++ for InvalidDomainMap
Sat, Jul 15, 2:02 AM
grosser closed D35308: [Polly] Use Isl c++ for InvalidDomainMap by committing rL308089: [Polly] Use Isl c++ for InvalidDomainMap.
Sat, Jul 15, 2:02 AM · Restricted Project
grosser added a comment to D35308: [Polly] Use Isl c++ for InvalidDomainMap.

Right, now the InvalidDomain is indeed consumed. Which is why using get() is not right. Does this make sense? Is there something specific we can or should explain better?

Sat, Jul 15, 1:50 AM · Restricted Project
grosser added a comment to D35308: [Polly] Use Isl c++ for InvalidDomainMap.

Hi Nandini,

Sat, Jul 15, 1:36 AM · Restricted Project

Fri, Jul 14

grosser added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

@singam-sanjay can you have a final look and commit it if you are OK with this patch.

Fri, Jul 14, 11:56 AM · Restricted Project
grosser accepted D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

LGTM from my side.

Fri, Jul 14, 11:55 AM · Restricted Project
grosser added inline comments to D35410: [Polly] [PPCGCodeGeneration] Make sure invariant loads are generated before trying to generate LLVM from GPUNodeBuilder. [NFC].
Fri, Jul 14, 6:19 AM
grosser resigned from D35403: Phabricator Test.
Fri, Jul 14, 4:20 AM
grosser resigned from D35404: Email Test 2.
Fri, Jul 14, 4:20 AM
grosser committed rL308013: update isl to: isl-0.18-791-ga22eb92.
update isl to: isl-0.18-791-ga22eb92
Fri, Jul 14, 3:36 AM
grosser requested changes to D35353: [WIP] [Polly] [PPCGCodeGeneration] [NFC] Fix runtime check adjustments since they make assumptions about BB layout..

Nice. I mark this as requesting changes, to make sure it pops up again after the test case has been updated!

Fri, Jul 14, 3:05 AM
grosser added a comment to D35403: Phabricator Test.

Test

Fri, Jul 14, 2:15 AM
grosser added a comment to D35403: Phabricator Test.

Test

Fri, Jul 14, 2:07 AM
grosser added a comment to D35237: [ScopInfo] Simplify new access functions under domain context.

Yes, I can change this.

Fri, Jul 14, 1:58 AM · Restricted Project
grosser added a comment to D35403: Phabricator Test.

Switch to phabricator@grosser.es

Fri, Jul 14, 1:57 AM
grosser added a comment to D35404: Email Test 2.

@grosser-test: Another comment, this time with grosser-test's primary email address set to my gmail account.

Fri, Jul 14, 1:38 AM
grosser added a reviewer for D35404: Email Test 2: klimek.

Added Manuel as reviewer to see if he gets notified.

Fri, Jul 14, 1:30 AM
grosser accepted D35404: Email Test 2.
Fri, Jul 14, 1:28 AM
grosser added a comment to D35404: Email Test 2.

Test

Fri, Jul 14, 1:27 AM
grosser added a comment to D35403: Phabricator Test.

Commenting myself.

Fri, Jul 14, 1:21 AM