- User Since
- Jul 30 2014, 11:40 AM (164 w, 4 d)
Tue, Sep 19
No worries. Thank you for reviewing!
This is a run-time library, we do not (yet) link with LLVM libraries.
Mon, Sep 18
LGTM. Thank you!
Mon, Sep 11
Fri, Sep 8
Thu, Sep 7
Mon, Sep 4
Sun, Sep 3
This seems to work, but my commit message is not very good yet. Can you suggest a commit message that describes the reason you prefer this solution?
Use Michael's suggested change
Add failing test case
Sat, Sep 2
Fri, Sep 1
I think this is not needed any more!
Thu, Aug 31
I agree with Kristof. Even though I did not write DB code since a while, the reasoning sounds very good. Hope this fixes some of the errors we see!
Thanks Dani. Then we should certainly go for the new GVN.
in the commit message
Addressed Michael's comment
It seems the change in collectIncompatibleElts is not even needed. I also have
a hard time to reproduce a test case where the forwarding is refused due to
incompatible statements. Michael, do you have an idea?
Wed, Aug 30
This was committed in 312211.
Thank you. Looking into it.
Mon, Aug 28
Sun, Aug 27
Aug 26 2017
Aug 25 2017
LGTM, thank you!
Aug 24 2017
Mark this as requesting changes.
@fhahn, I just addressed your comments.
Addressed Alex comments.
Use C++ class enum
Aug 23 2017
OK. Let me know when this is worth an official LGTM.
Very nice. This looks good from my perspective!
Thanks for the useful comments. I now use optional. I am not convinced regarding the cache size in multiples of cache lines. This seems to always require conversions in case we want the actual size in bytes. At least for us, this is the more common value, I believe.
Make return values optional to be able to distinguish between unknown cache
size and no cache.
A lot better, some comments.
Add a newline between two functions
Hi Alex, hi Roman,
Incorporate asb's comments.
Hi Florian, hi Sebastian, Eli,
Aug 22 2017
Thanks. The LGTM is the green light. Go ahead and commit. Thanks for asking, but for now this change is almost obvious.
Forgot the LGTM. Thanks for cleaning Polly as well.
OK for now. I would like to get these back at some point, but should do this later.
Aug 21 2017
It seems this diff is corrupted in some way. However, your changes look good.
Aug 19 2017
Add the invariant loads to the test case and copy some more comments from
Siddharth's earlier test case over
Add the TODO requested by Siddharth
Add another test case to avoid us loosing test coverage