- User Since
- Jul 30 2014, 11:40 AM (251 w, 3 d)
Fri, May 10
Apr 23 2019
Feb 1 2019
Oct 8 2018
Marcin, let us know if you agree with the comment fix. I can then commit the patch, when it's ready.
Oct 7 2018
Thanks Marcin for improving the commit message. We all seem to agree that this is the right correction. Hence, I feel this is ready to upstream from my side. As there have been quite some opinions, it would be great to hear if there are any open concerns that should be adressed or if others also feel this LGT(them). We especially still need feedback from @kristina!
Thank you @kristina for the review. I must admit I do not fully understand in which way this is broken, but the attached test case clearly shows there is some memory issue. My (limited) understanding is that Twine(Weight->getZExtValue()) will be destroyed at the end of line 175 which means that already in line 176 we may potentially reference invalid memory.
http://llvm.org/docs/ProgrammersManual.html#dss-twine has a similar example and explicitly warns of such uses:
Sep 13 2018
Thank you guys for taking care of some of the cmake system. @Meinersbur, I am fine with renaming Polly modules according to LLVM conventions if this makes things more consistent.
Sep 11 2018
This is a good idea.
Sep 4 2018
Aug 8 2018
Aug 6 2018
Aug 1 2018
Jul 31 2018
Interesting. Any idea what is going wrong here?
Jul 28 2018
If this was not clear. I am very OK with this change.
This is a straightforward, but very nice infrastructure change. Thank you both for pushing JSON support ahead in LLVM!
Jul 25 2018
I used the std::any variant as an easy way to showcase how the bindings generator could be modified to do what we want (and also to show how an ideal interface could look like). I feel we should bring this up on the isl mailing list first to see what would be a good way to add this feature. We potentially could replace std::any with a simpler C++11 compatible solution:
Jul 20 2018
Jul 17 2018
This has become obsolete, after Philip Pfaffe committed a better variant of this feature.
Jul 16 2018
Jul 13 2018
You can commit this. It will just be covered in the next update.
Jul 10 2018
Sorry guys. Alain just started to look into this last week and we wanted to get him up-to-speed before getting in touch with you. I should have helped to coordinate better. I asked Alain to discuss with you which / what patches are still needed.
I have a patched version of the generator (very hacky) on top of the isl bindings. Not sure if this (happens to) be the right one: https://github.com/tobig/isl/tree/polly-bindings-andrei
Right. I am busy today, but can do a normal update thursday afternoon. I will then also push the current generator to github.
Jul 6 2018
Jul 5 2018
Jul 4 2018
Jul 3 2018
Yes, raise we should raise the version. Also, please add a propoer commit message explaining what the underlying error was here. We should also make sure that this bug has been fixed in the latest ppcg, such that we do not re-import it again.
Jun 29 2018
Also looks good from me except the minor changes. Please update the patch if you agree.
Jun 28 2018
@ftynse, the source is referenced in the patch summary. If we commit such a patch to Polly, we must make we have your permission to contribute it under the LLVM license and obviously need to acknowledge the source. For now, I asked Lorenzo to push the code as RFC to allow others to see how it would be used. This already sparked a comment from Philip and will likely spark further discussions on how to extend the interface. Thanks for commenting.
Jun 26 2018
Jun 19 2018
Jun 18 2018
Jun 16 2018
Thank you Philip. This clearly looks a lot better than my patch. From my perspective this looks good after Michael's comments are addressed. Thanks a lot.
Jun 13 2018
Jun 11 2018
Jun 6 2018
Jun 5 2018
Jun 1 2018
Done. Thanks Lorenzo!
Dropping this in favor of D47604. Thanks for the suggestions!
@chelini : any plans to update this patch?
May 31 2018
May 30 2018
May 28 2018
Committed. These changes are very useful. Thanks!
May 27 2018
This looks good. Please also update the summary / commit message.
May 26 2018
This is a very good idea. I am out of office, but will review this Sunday night.
May 23 2018
@cs15btech11044, would you like to review this patch? (Be careful, there are a couple of things that should be fixed)
May 19 2018
@cs15btech11044, I try to get you involved in the code review process. Would you like to review this patch?
May 16 2018
Thanks. I am currently upstreaming a set of functions to isl which allow us to get basic_map_lists from a map and map_lists from a union_map. For isl_*_list types it should be easy to write an iterator that allows foreach loops. I plan to write such iterators and will then use these to simplify this code.