grosser (Tobias Grosser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2014, 11:40 AM (164 w, 4 d)

Recent Activity

Tue, Sep 19

grosser requested changes to D37061: [Polly] Third Updated translating the function Scop::foldSizeConstantsToRight() to isl C++.

Hi Siddharth,

Tue, Sep 19, 5:40 AM
grosser added a comment to D37691: [GPUJIT] Improved temporary file handling..

No worries. Thank you for reviewing!

Tue, Sep 19, 2:38 AM
grosser added a comment to D37691: [GPUJIT] Improved temporary file handling..

This is a run-time library, we do not (yet) link with LLVM libraries.

Tue, Sep 19, 2:09 AM

Mon, Sep 18

grosser accepted D37691: [GPUJIT] Improved temporary file handling..

Typo: "improve"

Mon, Sep 18, 11:42 PM
grosser accepted D37984: [Polly][ForwardOpTree] Allow out-of-quota in examination part of forwardTree..

LGTM. Thank you!

Mon, Sep 18, 11:25 PM · Restricted Project
grosser accepted D37969: [Polly][test] Enable -polly-codegen-verify for regression tests..
Mon, Sep 18, 5:11 AM · Restricted Project
grosser added a comment to D37969: [Polly][test] Enable -polly-codegen-verify for regression tests..

LGTM.

Mon, Sep 18, 5:11 AM · Restricted Project

Mon, Sep 11

grosser accepted D37692: [Polly] Unroll and separate the remaining parts of isolation.

LGTM.

Mon, Sep 11, 8:47 AM

Fri, Sep 8

grosser accepted D37641: [zorg] Reduce the number of concurrent jobs for AOSP build.

LGTM

Fri, Sep 8, 2:35 PM

Thu, Sep 7

grosser accepted D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
Thu, Sep 7, 8:16 AM

Mon, Sep 4

grosser committed rL312480: [CodegenCleanup] Use old GVN pass instead of NewGVN.
[CodegenCleanup] Use old GVN pass instead of NewGVN
Mon, Sep 4, 4:05 AM
grosser committed rL312476: [ISLTools]: Move singleton to isl++.
[ISLTools]: Move singleton to isl++
Mon, Sep 4, 3:06 AM
grosser committed rL312475: [DeLICM] Move some functions to isl++ [NFC].
[DeLICM] Move some functions to isl++ [NFC]
Mon, Sep 4, 3:06 AM

Sun, Sep 3

grosser committed rL312456: [ForwardOp] Remove read accesses for all instructions that have been moved.
[ForwardOp] Remove read accesses for all instructions that have been moved
Sun, Sep 3, 12:53 PM
grosser closed D37424: [ForwardOp] Remove read accesses for all instructions that have been moved by committing rL312456: [ForwardOp] Remove read accesses for all instructions that have been moved.
Sun, Sep 3, 12:53 PM · Restricted Project
grosser committed rL312455: [IslAst] Do not assert in case of empty min/max alias locations.
[IslAst] Do not assert in case of empty min/max alias locations
Sun, Sep 3, 12:48 PM
grosser committed rL312452: [IslAst] Move buildCondition to isl++.
[IslAst] Move buildCondition to isl++
Sun, Sep 3, 11:33 AM
grosser committed rL312451: [ScopHelper] Do not crash on unreachable blocks.
[ScopHelper] Do not crash on unreachable blocks
Sun, Sep 3, 11:02 AM
grosser requested changes to D37061: [Polly] Third Updated translating the function Scop::foldSizeConstantsToRight() to isl C++.

Hi Siddharth,

Sun, Sep 3, 10:18 AM
grosser added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

This seems to work, but my commit message is not very good yet. Can you suggest a commit message that describes the reason you prefer this solution?

Sun, Sep 3, 9:54 AM · Restricted Project
grosser updated the diff for D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

Use Michael's suggested change

Sun, Sep 3, 9:52 AM · Restricted Project
grosser added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

Hi Michael,

Sun, Sep 3, 7:01 AM · Restricted Project
grosser updated the diff for D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

Add failing test case

Sun, Sep 3, 7:00 AM · Restricted Project
grosser created D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.
Sun, Sep 3, 6:29 AM · Restricted Project

Sat, Sep 2

grosser committed rL312410: [ScopDetect/Info] Look through PHIs that follow an error block.
[ScopDetect/Info] Look through PHIs that follow an error block
Sat, Sep 2, 1:27 AM
grosser added a comment to D37337: [Polly] Split statements on encountering store instructions..

Hi Nandini,

Sat, Sep 2, 12:10 AM · Restricted Project

Fri, Sep 1

grosser abandoned D36425: [ZoneAlgo] Allow two writes that write identical values into same array slot.

I think this is not needed any more!

Fri, Sep 1, 10:56 PM · Restricted Project
grosser accepted D37379: [Polly] [ISLNodeBuilder] [Fortran Arrays] Materialize Fortran array sizes of arrays without memory accesses..
Fri, Sep 1, 9:17 AM

Thu, Aug 31

grosser added a comment to D37360: Keep sqlalchemy session separate from database objects.

I agree with Kristof. Even though I did not write DB code since a while, the reasoning sounds very good. Hope this fixes some of the errors we see!

Thu, Aug 31, 11:50 PM
grosser added a comment to D37340: [Polly] Run GVN during the cleanup.

Thanks Dani. Then we should certainly go for the new GVN.

Thu, Aug 31, 11:20 PM
grosser committed rL312304: Drop unused statistic counter.
Drop unused statistic counter
Thu, Aug 31, 7:18 PM
grosser accepted D37362: [Polly][ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset..

in the commit message

Thu, Aug 31, 7:02 PM
grosser accepted D37349: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
Thu, Aug 31, 1:09 PM
grosser added inline comments to D37349: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
Thu, Aug 31, 12:43 PM
grosser accepted D37340: [Polly] Run GVN during the cleanup.

LGTM

Thu, Aug 31, 10:28 AM
grosser committed rL312249: [ForwardOpTree] Allow forwarding in the presence of region statements.
[ForwardOpTree] Allow forwarding in the presence of region statements
Thu, Aug 31, 9:07 AM
grosser closed D37298: [ForwardOpTree] Allow forwarding in the presence of region statements by committing rL312249: [ForwardOpTree] Allow forwarding in the presence of region statements.
Thu, Aug 31, 9:07 AM · Restricted Project
grosser updated the diff for D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.

Addressed Michael's comment

Thu, Aug 31, 6:40 AM · Restricted Project
grosser updated the diff for D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.

It seems the change in collectIncompatibleElts is not even needed. I also have
a hard time to reproduce a test case where the forwarding is refused due to
incompatible statements. Michael, do you have an idea?

Thu, Aug 31, 2:06 AM · Restricted Project

Wed, Aug 30

grosser closed D37296: [ScopInfo] Use statement lists for entry blocks of region statements.

This was committed in 312211.

Wed, Aug 30, 9:52 PM · Restricted Project
grosser committed rL312210: [ScopInfo] Use statement lists for entry blocks of region statements.
[ScopInfo] Use statement lists for entry blocks of region statements
Wed, Aug 30, 8:17 PM
grosser committed rL312209: Revert "[ScopInfo] Use statement lists for entry blocks of region statements".
Revert "[ScopInfo] Use statement lists for entry blocks of region statements"
Wed, Aug 30, 7:45 PM
grosser added a comment to D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.

Thank you. Looking into it.

Wed, Aug 30, 8:46 AM · Restricted Project
grosser created D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.
Wed, Aug 30, 8:13 AM · Restricted Project
grosser committed rL312128: [ScopInfo] Use statement lists for entry blocks of region statements.
[ScopInfo] Use statement lists for entry blocks of region statements
Wed, Aug 30, 8:10 AM
grosser added inline comments to D37296: [ScopInfo] Use statement lists for entry blocks of region statements.
Wed, Aug 30, 8:06 AM · Restricted Project
grosser created D37296: [ScopInfo] Use statement lists for entry blocks of region statements.
Wed, Aug 30, 6:17 AM · Restricted Project

Mon, Aug 28

grosser committed rL311920: [IslAst] Do not compare arrays in alias check which are known to be identical.
[IslAst] Do not compare arrays in alias check which are known to be identical
Mon, Aug 28, 1:18 PM
grosser accepted D37219: [Polly][ZoneAlgo] More fine-grained bail-out..

Very nice!

Mon, Aug 28, 12:00 PM
grosser accepted D37178: [Polly] Use the information about the target cache provided by the TargetTransformInfo.

Nice!

Mon, Aug 28, 11:44 AM

Sun, Aug 27

grosser committed rL311863: [Detect] Consider nested loop profitable if entry block is not in loop.
[Detect] Consider nested loop profitable if entry block is not in loop
Sun, Aug 27, 2:40 PM

Aug 26 2017

grosser updated subscribers of D37064: [InstCombine] Fold insert sequence if first ins has multiple users..
Aug 26 2017, 12:52 AM
grosser accepted D37169: [zorg] Increase AOSP build timeout to 240s.
Aug 26 2017, 12:50 AM

Aug 25 2017

grosser added a comment to D37169: [zorg] Increase AOSP build timeout to 240s.

LGTM, thank you!

Aug 25 2017, 11:46 PM
grosser accepted D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..

Hi Eli,

Aug 25 2017, 9:36 AM

Aug 24 2017

grosser requested changes to D37061: [Polly] Third Updated translating the function Scop::foldSizeConstantsToRight() to isl C++.

Mark this as requesting changes.

Aug 24 2017, 1:11 PM
grosser committed rL311692: Revert "[polly] Fix ScopDetectionDiagnostic test failure caused by r310940".
Revert "[polly] Fix ScopDetectionDiagnostic test failure caused by r310940"
Aug 24 2017, 12:48 PM
grosser committed rL311647: Model cache size and associativity in TargetTransformInfo.
Model cache size and associativity in TargetTransformInfo
Aug 24 2017, 2:47 AM
grosser closed D37051: Model cache size and associativity in TargetTransformInfo by committing rL311647: Model cache size and associativity in TargetTransformInfo.
Aug 24 2017, 2:47 AM
grosser added a comment to D37051: Model cache size and associativity in TargetTransformInfo.

@fhahn, I just addressed your comments.

Aug 24 2017, 1:46 AM
grosser updated the diff for D37051: Model cache size and associativity in TargetTransformInfo.

Use LLVM_FALLTHROUGH

Aug 24 2017, 1:43 AM
grosser added inline comments to D37051: Model cache size and associativity in TargetTransformInfo.
Aug 24 2017, 12:50 AM
grosser added a comment to D37051: Model cache size and associativity in TargetTransformInfo.

Addressed Alex comments.

Aug 24 2017, 12:41 AM
grosser updated the diff for D37051: Model cache size and associativity in TargetTransformInfo.

Use C++ class enum

Aug 24 2017, 12:41 AM

Aug 23 2017

grosser accepted D37058: [Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions in a kernel..

LGTM

Aug 23 2017, 9:04 PM
grosser added a comment to D37051: Model cache size and associativity in TargetTransformInfo.

OK. Let me know when this is worth an official LGTM.

Aug 23 2017, 8:38 PM
grosser added a comment to D37064: [InstCombine] Fold insert sequence if first ins has multiple users..

Very nice. This looks good from my perspective!

Aug 23 2017, 10:44 AM
grosser added a comment to D37051: Model cache size and associativity in TargetTransformInfo.

Thanks for the useful comments. I now use optional. I am not convinced regarding the cache size in multiples of cache lines. This seems to always require conversions in case we want the actual size in bytes. At least for us, this is the more common value, I believe.

Aug 23 2017, 9:50 AM
grosser added a comment to D37051: Model cache size and associativity in TargetTransformInfo.

I think throughput and latency of vector fma instructions are pretty constant across micro-architectures too. Can we also add them?

Sorry, probably, it’d require to specify it for each architecture.

Aug 23 2017, 9:47 AM
grosser updated the diff for D37051: Model cache size and associativity in TargetTransformInfo.

Make return values optional to be able to distinguish between unknown cache
size and no cache.

Aug 23 2017, 9:45 AM
grosser added a comment to D37061: [Polly] Third Updated translating the function Scop::foldSizeConstantsToRight() to isl C++.

A lot better, some comments.

Aug 23 2017, 7:15 AM
grosser updated the diff for D37051: Model cache size and associativity in TargetTransformInfo.

Add a newline between two functions

Aug 23 2017, 1:33 AM
grosser updated the summary of D37051: Model cache size and associativity in TargetTransformInfo.
Aug 23 2017, 1:32 AM
grosser added a comment to D37051: Model cache size and associativity in TargetTransformInfo.

Hi Alex, hi Roman,

Aug 23 2017, 1:32 AM
grosser updated the diff for D37051: Model cache size and associativity in TargetTransformInfo.

Incorporate asb's comments.

Aug 23 2017, 1:28 AM
grosser added reviewers for D37051: Model cache size and associativity in TargetTransformInfo: fhahn, sebpop, eli.friedman.

Hi Florian, hi Sebastian, Eli,

Aug 23 2017, 12:49 AM
grosser closed D36920: [GPGPU] Collect parameter dimension used in MemoryAccesses.
Aug 23 2017, 12:47 AM · Restricted Project
grosser created D37051: Model cache size and associativity in TargetTransformInfo.
Aug 23 2017, 12:44 AM

Aug 22 2017

grosser accepted D37049: [Polly] Add various statistics..
Aug 22 2017, 9:35 PM · Restricted Project
grosser committed rL311504: Move include/isl-noexceptions.h to include/isl/isl-noexceptions.h.
Move include/isl-noexceptions.h to include/isl/isl-noexceptions.h
Aug 22 2017, 3:05 PM
grosser closed D37028: [IRBuilder] Only emit alias scop metadata for arrays, but not scalars by committing rL311498: [IRBuilder] Only emit alias scop metadata for arrays, but not scalars.
Aug 22 2017, 3:01 PM · Restricted Project
grosser created D37028: [IRBuilder] Only emit alias scop metadata for arrays, but not scalars.
Aug 22 2017, 2:43 PM · Restricted Project
grosser added a comment to D36776: [polly] Fix ScopDetectionDiagnostic test failure caused by r310940.

Thanks. The LGTM is the green light. Go ahead and commit. Thanks for asking, but for now this change is almost obvious.

Aug 22 2017, 2:01 PM · Restricted Project
grosser accepted D36776: [polly] Fix ScopDetectionDiagnostic test failure caused by r310940.

Forgot the LGTM. Thanks for cleaning Polly as well.

Aug 22 2017, 1:48 PM · Restricted Project
grosser added a comment to D36776: [polly] Fix ScopDetectionDiagnostic test failure caused by r310940.

OK for now. I would like to get these back at some point, but should do this later.

Aug 22 2017, 1:47 PM · Restricted Project
grosser requested changes to D36843: [Polly] Second Updated translating the function Scop::foldSizeConstantsToRight() to isl C++ .

Hey Siddharth,

Aug 22 2017, 1:20 PM
grosser accepted D35992: [Polly] [PPCGCodeGeneration] [NFC] [WIP] Add option to fail if a store to a scalar occursin a kernel..

Otherwise, LGTM.

Aug 22 2017, 6:42 AM
grosser added inline comments to D35992: [Polly] [PPCGCodeGeneration] [NFC] [WIP] Add option to fail if a store to a scalar occursin a kernel..
Aug 22 2017, 6:40 AM
grosser accepted D37012: [GPUJIT] Make max managed pointers an environment variable.

LGTM.

Aug 22 2017, 6:39 AM

Aug 21 2017

grosser committed rL311336: [ZoneAlgorithm] Move computeScalarReachingDefinition to c++.
[ZoneAlgorithm] Move computeScalarReachingDefinition to c++
Aug 21 2017, 7:20 AM
grosser added a comment to D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.

It seems this diff is corrupted in some way. However, your changes look good.

Aug 21 2017, 4:50 AM
grosser added a comment to D36928: [Polly][MatMul][WIP] Disable the Loop Vectorizer.

Hi Hal,

Aug 21 2017, 4:48 AM
grosser accepted D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.

Hi Siddharth,

Aug 21 2017, 4:39 AM
grosser accepted D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
Aug 21 2017, 4:07 AM
grosser added a comment to D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..

Hi Siddharth,

Aug 21 2017, 4:05 AM

Aug 19 2017

grosser committed rL311264: [ManagedMemoryRewrite] Make pass more robust and fix memory issue.
[ManagedMemoryRewrite] Make pass more robust and fix memory issue
Aug 19 2017, 4:04 PM
grosser closed D36929: [GPGPU] Correctly initialize array order and fixed_element information by committing rL311259: [GPGPU] Correctly initialize array order and fixed_element information.
Aug 19 2017, 1:22 PM · Restricted Project
grosser updated the diff for D36929: [GPGPU] Correctly initialize array order and fixed_element information.

Add the invariant loads to the test case and copy some more comments from
Siddharth's earlier test case over

Aug 19 2017, 1:18 PM · Restricted Project
grosser updated the diff for D36929: [GPGPU] Correctly initialize array order and fixed_element information.

Add the TODO requested by Siddharth

Aug 19 2017, 1:15 PM · Restricted Project
grosser updated the diff for D36929: [GPGPU] Correctly initialize array order and fixed_element information.

Add another test case to avoid us loosing test coverage

Aug 19 2017, 1:09 PM · Restricted Project