grosser (Tobias Grosser)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2014, 11:40 AM (142 w, 5 d)

Recent Activity

Today

grosser accepted D32026: [Polly][DeLICM] Use Known information when comparing Occupied and Written..

Nice, this LGTM.

Tue, Apr 25, 7:22 AM · Restricted Project

Yesterday

grosser accepted D32025: [Polly][DeLICM] Use Known information when comparing Existing.Occupied and Proposed.Occupied..

lgtm

Mon, Apr 24, 9:10 PM · Restricted Project
grosser accepted D32215: Updated PPCG Code Generation for OpenCL compatibility.

LGTM.

Mon, Apr 24, 3:29 AM · Restricted Project
grosser added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

Hi Philippe,

Mon, Apr 24, 2:36 AM · Restricted Project

Sun, Apr 23

grosser committed rL301108: [isl C++ bindings] Add explicit const casts for *foreach* bindings.
[isl C++ bindings] Add explicit const casts for *foreach* bindings
Sun, Apr 23, 1:07 AM
grosser accepted D32392: [Polly][CMake] Allow Polly to transitively pull in its dependencies into host programs..

Hi Michael,

Sun, Apr 23, 12:12 AM · Restricted Project

Fri, Apr 21

grosser committed rL300965: GICHelper: remove forgotten isl foreach declarations.
GICHelper: remove forgotten isl foreach declarations
Fri, Apr 21, 4:03 AM

Thu, Apr 20

grosser added a comment to D32226: [Polly] [PPCGCodeGeneration] Add managed memory support to GPU code generation..

Hey guys,

Thu, Apr 20, 4:11 AM

Wed, Apr 19

grosser added a reviewer for D32215: Updated PPCG Code Generation for OpenCL compatibility: bollu.

Add Siddharth, as another review. Siddharth, could you take a look?

Wed, Apr 19, 2:06 AM · Restricted Project

Tue, Apr 18

grosser added a comment to D32003: Linking NVPTX backend for Polly-ACC.

The following patch works for me:

Tue, Apr 18, 11:53 AM · Restricted Project
grosser added a comment to D32157: [Polly] [DependenceInfo] Less restrictive matrix-multiplication pattern match.

Great. Can you add a RUN line that enables memory based dependences to show that this actually works. Also please mention in the commit log that the pattern matching does currently not work for memory based dependence.

Tue, Apr 18, 2:49 AM

Mon, Apr 17

grosser added inline comments to D31719: [RegionInfo] Fix dangling references created by moving RegionInfo objects.
Mon, Apr 17, 7:25 PM

Sat, Apr 15

grosser added a comment to D32027: [Polly][DeLICM] Use Known information when comparing Existing.Written and Proposed.Written. NFC..

The definition of NFC is a little blurry in general, I assume.

Sat, Apr 15, 7:18 AM · Restricted Project
grosser committed rL300398: Update isl bindings to latest version (+ Polly extensions).
Update isl bindings to latest version (+ Polly extensions)
Sat, Apr 15, 1:28 AM

Fri, Apr 14

grosser accepted D32027: [Polly][DeLICM] Use Known information when comparing Existing.Written and Proposed.Written. NFC..

Hi Michael,

Fri, Apr 14, 6:45 PM · Restricted Project
grosser added a comment to D32026: [Polly][DeLICM] Use Known information when comparing Occupied and Written..

Hi Michael,

Fri, Apr 14, 10:21 AM · Restricted Project
grosser added a comment to D32025: [Polly][DeLICM] Use Known information when comparing Existing.Occupied and Proposed.Occupied..

Hi Michael,

Fri, Apr 14, 6:59 AM · Restricted Project
grosser committed rL300323: Use isl C++ foreach implementation.
Use isl C++ foreach implementation
Fri, Apr 14, 6:52 AM
grosser closed D30620: [Polly] Use isl C++ foreach implementation by committing rL300323: Use isl C++ foreach implementation.
Fri, Apr 14, 6:52 AM · Restricted Project
grosser added a comment to D32025: [Polly][DeLICM] Use Known information when comparing Existing.Occupied and Proposed.Occupied..

Hi Michael,

Fri, Apr 14, 6:34 AM · Restricted Project
grosser added a comment to D32003: Linking NVPTX backend for Polly-ACC.

Wow, this still looks very complicated. I think we just want something like:

Fri, Apr 14, 2:36 AM · Restricted Project
grosser added a comment to D30620: [Polly] Use isl C++ foreach implementation.

Hi Michael,

Fri, Apr 14, 2:30 AM · Restricted Project

Thu, Apr 13

grosser added a comment to D32003: Linking NVPTX backend for Polly-ACC.

I think for consistency we should add ${LLVM_TARGETS_TO_BUILD} to LLVM_LINK_COMPONENTS. This should not be about Polly. For modules in general the same libraries should be available in opt and bugpoint.

Thu, Apr 13, 5:17 AM · Restricted Project

Mon, Apr 10

grosser committed rL299914: Exploit BasicBlock::getModule to shorten code.
Exploit BasicBlock::getModule to shorten code
Mon, Apr 10, 10:12 PM
grosser committed rL299913: SAdjust to recent change in constructor definition of AllocaInst.
SAdjust to recent change in constructor definition of AllocaInst
Mon, Apr 10, 9:36 PM
grosser accepted D31536: [SelectionDAG] Check CALLSEQ_BEGIN nodes in DelayForLiveRegs.

Very nice. I think this is good to go.

Mon, Apr 10, 11:32 AM

Wed, Apr 5

grosser committed rL299617: Update to isl-0.18-417-gb9e7334.
Update to isl-0.18-417-gb9e7334
Wed, Apr 5, 8:54 PM
grosser accepted D31719: [RegionInfo] Fix dangling references created by moving RegionInfo objects.
Wed, Apr 5, 12:04 PM
grosser added a comment to D31719: [RegionInfo] Fix dangling references created by moving RegionInfo objects.

LGTM.

Wed, Apr 5, 12:03 PM
grosser accepted D31708: [Polly] [ScheduleOptimizer] Prevent incorrect tile size computation.
Wed, Apr 5, 8:16 AM
grosser added a comment to D31459: [Polly][NewPM] Port ScopDetection to the new PassManager.

Polly is one (but not the only) user of the region infrastructure. So yes, a portion of the bugs is resolved by us. Would be great if this could be fixed, though. If the change is noisy, but simple, the review should be easy.

Wed, Apr 5, 6:26 AM · Restricted Project
grosser added a comment to D31459: [Polly][NewPM] Port ScopDetection to the new PassManager.

Out of interest: What is the RegionInfo bug you are talking about?

Wed, Apr 5, 5:59 AM · Restricted Project
grosser committed rL299534: Add two Polly images.
Add two Polly images
Wed, Apr 5, 5:03 AM

Tue, Apr 4

grosser accepted D31653: [Polly][NewPM] Pull references to the legacy PM interface from utilities and helpers.

This is a great cleanup! Very nice! Please commit!

Tue, Apr 4, 3:01 AM · Restricted Project

Mon, Apr 3

grosser committed rL299360: [PerfMonitor] Use Intrinsics::getDeclaration.
[PerfMonitor] Use Intrinsics::getDeclaration
Mon, Apr 3, 8:35 AM
grosser committed rL299359: [CodeGen] Add Performance Monitor.
[CodeGen] Add Performance Monitor
Mon, Apr 3, 8:08 AM
grosser closed D31599: [CodeGen] Add Performance Monitor by committing rL299359: [CodeGen] Add Performance Monitor.
Mon, Apr 3, 8:08 AM · Restricted Project
grosser added a comment to D31599: [CodeGen] Add Performance Monitor.

We now do not perform performance monitoring on other architectures, but just print that runtime information generation is not supported.

Mon, Apr 3, 7:25 AM · Restricted Project
grosser updated the diff for D31599: [CodeGen] Add Performance Monitor.

Add check for X86_64 target sugggested by Sebastian.

Mon, Apr 3, 7:24 AM · Restricted Project
grosser added a comment to D31599: [CodeGen] Add Performance Monitor.

Yes, until know this works only on X86. I intended this as a basic debugging facility. If there is interest (and instructions) it would be nice to generalize this. For ARM we could emit "MRC" instructions, but they do not seem to be accessible by default: http://blog.regehr.org/archives/794

Mon, Apr 3, 7:00 AM · Restricted Project
grosser created D31599: [CodeGen] Add Performance Monitor.
Mon, Apr 3, 6:20 AM · Restricted Project
grosser added a comment to D31596: [Polly] Fix two testcases.

Thank you Philipp! This is really useful.

Mon, Apr 3, 5:34 AM · Restricted Project
grosser committed rL299352: [PollyIRBuilder] Bound size of alias metadata.
[PollyIRBuilder] Bound size of alias metadata
Mon, Apr 3, 1:14 AM
grosser committed rL299353: Add test case for r299352..
Add test case for r299352.
Mon, Apr 3, 1:07 AM

Sun, Apr 2

grosser committed rL299350: Update to isl-0.18-410-gc253447.
Update to isl-0.18-410-gc253447
Sun, Apr 2, 11:59 PM

Fri, Mar 31

grosser added a comment to D31536: [SelectionDAG] Check CALLSEQ_BEGIN nodes in DelayForLiveRegs.

Thanks Sam, you are fast! This patch fixes the crash for me and all test cases still pass. Very nice!

Fri, Mar 31, 9:25 AM

Wed, Mar 29

grosser added a comment to D31488: [SimplifyIndvar] Replace the sdiv used by IV if we can prove both of its operands are non-negative.

The relevant function is visitSDiv in InstCombineMulDivRem.cpp. Maybe we have indeed insufficient information in instcombine.

Wed, Mar 29, 11:40 PM
grosser added a comment to D31488: [SimplifyIndvar] Replace the sdiv used by IV if we can prove both of its operands are non-negative.

Hi Hongbin,

Wed, Mar 29, 11:12 PM

Tue, Mar 28

grosser added a comment to D31032: [LoadCombine] Avoid analysing dead basic blocks.

This looks pretty straightforward to me. I think if there are no other concerns, I think this should go in.

Tue, Mar 28, 8:16 AM

Mon, Mar 27

grosser added a comment to D31386: [Polly] [DependenceInfo] change WAR, WAW generation to correct semantics..

Cool. This looks good from my side. Maybe Michael has a comment.

Mon, Mar 27, 11:03 PM

Mar 23 2017

grosser committed rL298595: Update to isl-0.18-402-ga30c537.
Update to isl-0.18-402-ga30c537
Mar 23 2017, 6:50 AM
grosser added a comment to D31247: [Polly][DeLICM] Known knowledge..

Hi Michael,

Mar 23 2017, 5:38 AM · Restricted Project
grosser accepted D31244: [DependenceInfo] Remove access to WAW and WAR: Expose both as False [NFC].

This looks good to me. As this is a rather large change, I would like to get an explicit OK from Michael and Roman.

Mar 23 2017, 3:03 AM

Mar 22 2017

grosser committed rL298533: Add missing subsection in GSoC section.
Add missing subsection in GSoC section
Mar 22 2017, 11:26 AM
grosser added a comment to D30605: [Polly] Map the new load to the base pointer of the invariant load hoisted load.

Hi Roman,

Mar 22 2017, 4:04 AM

Mar 21 2017

grosser added a comment to D31181: [DependenceInfo] change name Write to MustWrite to remove ambiguity [NFC].

Hi Siddharth,

Mar 21 2017, 5:10 AM
grosser accepted D31181: [DependenceInfo] change name Write to MustWrite to remove ambiguity [NFC].

LGTM!

Mar 21 2017, 4:55 AM
grosser committed rL298352: Update isl to isl-0.18-395-g77701b3.
Update isl to isl-0.18-395-g77701b3
Mar 21 2017, 2:24 AM

Mar 20 2017

grosser committed rL298297: Make (sub)projects visible in GSoC toc.
Make (sub)projects visible in GSoC toc
Mar 20 2017, 1:22 PM
grosser committed rL298296: Add missing '<li>' tags.
Add missing '<li>' tags
Mar 20 2017, 1:22 PM
grosser committed rL298295: Add two Polly GSoC ideas.
Add two Polly GSoC ideas
Mar 20 2017, 1:15 PM

Mar 18 2017

grosser committed rL298197: [CodeGen] Remove need for all parameters to be in scop context for load….
[CodeGen] Remove need for all parameters to be in scop context for load…
Mar 18 2017, 4:25 PM
grosser committed rL298194: [IslExprBuilder] Print accessed memory locations with RuntimeDebugBuilder.
[IslExprBuilder] Print accessed memory locations with RuntimeDebugBuilder
Mar 18 2017, 2:07 PM
grosser committed rL298192: [OpenMP] Do not emit lifetime markers for context.
[OpenMP] Do not emit lifetime markers for context
Mar 18 2017, 1:22 PM

Mar 17 2017

grosser committed rL298077: [ScopInfo] Add option to not add parameter bounds to context [NFC].
[ScopInfo] Add option to not add parameter bounds to context [NFC]
Mar 17 2017, 6:13 AM
grosser committed rL298073: [ScopInfo] Do not take inbounds assumptions [NFC].
[ScopInfo] Do not take inbounds assumptions [NFC]
Mar 17 2017, 5:39 AM
grosser accepted D31075: [DependenceInfo] Track may-writes and build flow information in Dependences::calculateDependences..

LGTM.

Mar 17 2017, 5:30 AM
grosser committed rL298054: [ScopInfo] Do not try to eliminate parameter dimensions that do not exist.
[ScopInfo] Do not try to eliminate parameter dimensions that do not exist
Mar 17 2017, 2:15 AM
grosser committed rL298053: [ScopInfo] Do not expand getDomains() to full parameter space..
[ScopInfo] Do not expand getDomains() to full parameter space.
Mar 17 2017, 2:15 AM

Mar 16 2017

grosser committed rL297999: Update to isl-0.18-387-g3fa6191.
Update to isl-0.18-387-g3fa6191
Mar 16 2017, 2:45 PM
grosser accepted D31036: [DependenceInfo] Set Dependences::RED to be non-null once Dependences::calculateDependences() occurs. [NFC] We need to do this even if there is no actual reduction. This ensures correctness with isl operations..

LGTM

Mar 16 2017, 10:00 AM
grosser added a comment to D31033: [Polly] Add -polly-prune-unprofitable pass..

Maybe not useful, but there is also no cost involved, right? This would make sure we get LNT test coverage on the before-position=before-vectorizer bot.

Mar 16 2017, 9:44 AM · Restricted Project
grosser accepted D31033: [Polly] Add -polly-prune-unprofitable pass..

LGTM. Any reason this is not enbled by default? Seems simple enough to enable and then we get immediately wider testing.

Mar 16 2017, 9:21 AM · Restricted Project

Mar 15 2017

grosser committed rL297929: [ADCE] Remove redundent code [NFC].
[ADCE] Remove redundent code [NFC]
Mar 15 2017, 9:11 PM
grosser closed D31023: [ADCE] Remove redundent code [NFC] by committing rL297929: [ADCE] Remove redundent code [NFC].
Mar 15 2017, 9:11 PM
grosser added a comment to D31023: [ADCE] Remove redundent code [NFC].

Hi Daniel,

Mar 15 2017, 9:03 PM
grosser created D31023: [ADCE] Remove redundent code [NFC].
Mar 15 2017, 8:42 PM
grosser accepted D30985: [Polly][ScopInfo] Introduce ScopStmt::getSurroundingLoop(). NFC..

LGTM, if you drop the surrounding loop stuff from copystmt.

Mar 15 2017, 11:33 AM · Restricted Project

Mar 14 2017

grosser committed rL297726: Fix typos in ADCE comments.
Fix typos in ADCE comments
Mar 14 2017, 3:30 AM
grosser accepted D30606: [Polly] Introduce another level of metadata to distinguish non-aliasing accesses.

Hi Roman,

Mar 14 2017, 2:24 AM
grosser committed rL297710: Preserve the isl-noexceptions.h C++ bindings when updating isl.
Preserve the isl-noexceptions.h C++ bindings when updating isl
Mar 14 2017, 12:58 AM
grosser committed rL297709: Add back header file that was accidentally dropped in previous update.
Add back header file that was accidentally dropped in previous update
Mar 14 2017, 12:51 AM
grosser committed rL297708: Update to isl-0.18-369-g5e613c6.
Update to isl-0.18-369-g5e613c6
Mar 14 2017, 12:45 AM

Mar 13 2017

grosser added a comment to D30890: Post-dom fix - connect virtual edges to last reverse-reachable BB.

Hi Daniel, hi Eli,

Mar 13 2017, 3:56 PM
grosser added a comment to D30890: Post-dom fix - connect virtual edges to last reverse-reachable BB.

Here an example that illustrates the difference between the original patch Daniel proposed in https://reviews.llvm.org/D29705 and the slightly modified one we prose her:

Mar 13 2017, 6:51 AM
grosser updated the summary of D30890: Post-dom fix - connect virtual edges to last reverse-reachable BB.
Mar 13 2017, 6:44 AM
grosser created D30890: Post-dom fix - connect virtual edges to last reverse-reachable BB.
Mar 13 2017, 6:40 AM

Mar 12 2017

grosser committed rL297587: [ScheduleOptimizer] Allow tiling after fusion.
[ScheduleOptimizer] Allow tiling after fusion
Mar 12 2017, 12:14 PM
grosser closed D30815: [Polly][ScheduleOptimizer] Allow tiling after fusion by committing rL297587: [ScheduleOptimizer] Allow tiling after fusion.
Mar 12 2017, 12:14 PM · Restricted Project
grosser added a comment to D30815: [Polly][ScheduleOptimizer] Allow tiling after fusion.

Very nice. I added a larger set of comments, but most are really minor. Can you update the patch accordingly, such that we can commit it?

Mar 12 2017, 12:58 AM · Restricted Project
grosser accepted D30605: [Polly] Map the new load to the base pointer of the invariant load hoisted load.

Perfect. This looks a lot better! Thanks for the cleanup!

Mar 12 2017, 12:49 AM
grosser added a comment to D30864: Possible error in doc comment.

Very cool. Thanks for fixing. I just pushed this upstream. It is great that you pro-actively push patches yourself.

Mar 12 2017, 12:31 AM · Restricted Project
grosser committed rL297578: Possible error in doc comment.
Possible error in doc comment
Mar 12 2017, 12:31 AM
grosser closed D30864: Possible error in doc comment by committing rL297578: Possible error in doc comment.
Mar 12 2017, 12:31 AM · Restricted Project
grosser committed rL297577: [isl++] Add missing /* implicit */ marker.
[isl++] Add missing /* implicit */ marker
Mar 12 2017, 12:30 AM

Mar 11 2017

grosser committed rL297558: [isl++] Add last set of missing isl:: prefixes to increase consistency [NFC].
[isl++] Add last set of missing isl:: prefixes to increase consistency [NFC]
Mar 11 2017, 12:10 AM

Mar 10 2017

grosser committed rL297522: [unittest] Do not convert large unsigned long to isl::val.
[unittest] Do not convert large unsigned long to isl::val
Mar 10 2017, 2:37 PM
grosser committed rL297520: [isl++] Add namespace prefixes to isl::ctx and isl::stat.
[isl++] Add namespace prefixes to isl::ctx and isl::stat
Mar 10 2017, 2:22 PM
grosser committed rL297519: [isl++] Drop warning about experimental status.
[isl++] Drop warning about experimental status
Mar 10 2017, 2:22 PM
grosser committed rL297478: [isl++] Do not use enum prefix.
[isl++] Do not use enum prefix
Mar 10 2017, 9:13 AM