- User Since
- Jul 30 2014, 11:40 AM (207 w, 4 d)
Fri, Jul 20
Tue, Jul 17
This has become obsolete, after Philip Pfaffe committed a better variant of this feature.
Mon, Jul 16
Fri, Jul 13
You can commit this. It will just be covered in the next update.
Tue, Jul 10
Sorry guys. Alain just started to look into this last week and we wanted to get him up-to-speed before getting in touch with you. I should have helped to coordinate better. I asked Alain to discuss with you which / what patches are still needed.
I have a patched version of the generator (very hacky) on top of the isl bindings. Not sure if this (happens to) be the right one: https://github.com/tobig/isl/tree/polly-bindings-andrei
Right. I am busy today, but can do a normal update thursday afternoon. I will then also push the current generator to github.
Fri, Jul 6
Thu, Jul 5
Wed, Jul 4
Tue, Jul 3
Yes, raise we should raise the version. Also, please add a propoer commit message explaining what the underlying error was here. We should also make sure that this bug has been fixed in the latest ppcg, such that we do not re-import it again.
Fri, Jun 29
Also looks good from me except the minor changes. Please update the patch if you agree.
Thu, Jun 28
@ftynse, the source is referenced in the patch summary. If we commit such a patch to Polly, we must make we have your permission to contribute it under the LLVM license and obviously need to acknowledge the source. For now, I asked Lorenzo to push the code as RFC to allow others to see how it would be used. This already sparked a comment from Philip and will likely spark further discussions on how to extend the interface. Thanks for commenting.
Tue, Jun 26
Jun 19 2018
Jun 18 2018
Jun 16 2018
Thank you Philip. This clearly looks a lot better than my patch. From my perspective this looks good after Michael's comments are addressed. Thanks a lot.
Jun 13 2018
Jun 11 2018
Jun 6 2018
Jun 5 2018
Jun 1 2018
Done. Thanks Lorenzo!
Dropping this in favor of D47604. Thanks for the suggestions!
@chelini : any plans to update this patch?
May 31 2018
May 30 2018
May 28 2018
Committed. These changes are very useful. Thanks!
May 27 2018
This looks good. Please also update the summary / commit message.
May 26 2018
This is a very good idea. I am out of office, but will review this Sunday night.
May 23 2018
@cs15btech11044, would you like to review this patch? (Be careful, there are a couple of things that should be fixed)
May 19 2018
@cs15btech11044, I try to get you involved in the code review process. Would you like to review this patch?
May 16 2018
Thanks. I am currently upstreaming a set of functions to isl which allow us to get basic_map_lists from a map and map_lists from a union_map. For isl_*_list types it should be easy to write an iterator that allows foreach loops. I plan to write such iterators and will then use these to simplify this code.
Very cool. Thanks for moving this forward.
May 15 2018
LGTM. Can you potentially include the old SVN revisions in your commit message?
May 10 2018
Looks good to me as well. Let's see what Kuba says.
May 9 2018
That's fine with me.
May 8 2018
May 7 2018
This generally looks good, but I agree we should move the code to a separate function.
Apr 29 2018
Thanks @philip.pfaffe . Is this fine from your side, otherwise?
Address some of Philips comments
Apr 28 2018
Convert two more functions