Page MenuHomePhabricator

vinayaka-polymage (Vinayaka Bandishti)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2021, 8:51 PM (11 w, 6 d)

Recent Activity

Sat, May 8

vinayaka-polymage updated the diff for D102104: [MLIR] Add memref dialect dependency for affine fusion pass.

Adding why the issue was not discovered till now

Sat, May 8, 7:06 AM · Restricted Project
vinayaka-polymage updated the diff for D102104: [MLIR] Add memref dialect dependency for affine fusion pass.

Better commit summary and message

Sat, May 8, 7:01 AM · Restricted Project
vinayaka-polymage added a reviewer for D102104: [MLIR] Add memref dialect dependency for affine fusion pass: ayzhuang.
Sat, May 8, 6:28 AM · Restricted Project
vinayaka-polymage requested review of D102104: [MLIR] Add memref dialect dependency for affine fusion pass.
Sat, May 8, 6:22 AM · Restricted Project

Wed, May 5

vinayaka-polymage accepted D101794: [mlir] Update dstNode after DenseMap insertion in loop fusion pass..

Looks great, thanks for fixing this hard and non-trivial bug !

Wed, May 5, 10:06 AM · Restricted Project

Apr 12 2021

vinayaka-polymage accepted D99761: [mlir] Prevent operations with users from being hoisted.

Please change the commit title to a more relevant one, I am approving this.

Apr 12 2021, 9:52 AM · Restricted Project
vinayaka-polymage added a comment to D99761: [mlir] Prevent operations with users from being hoisted.

@sumesh13 Thanks for addressing all the comments, the change looks good now. Can you please check these last two comments before I approve this ?

Apr 12 2021, 9:25 AM · Restricted Project

Apr 11 2021

vinayaka-polymage requested changes to D99761: [mlir] Prevent operations with users from being hoisted.

@sumesh13 This new generic fix looks good, it handles more cases that were previously not handled. Thanks for this. I have added some comments related to code organization, please check them. Logic looks good to me.

Apr 11 2021, 10:04 PM · Restricted Project

Apr 7 2021

vinayaka-polymage added a comment to D99761: [mlir] Prevent operations with users from being hoisted.

Minor suggestion.

Apr 7 2021, 11:41 PM · Restricted Project
vinayaka-polymage requested changes to D99761: [mlir] Prevent operations with users from being hoisted.

Thank you for bringing up this issue in LICM, it is an important one. I have a few comments on the fix:

  1. Inherent issue is definedOps ( going to be renamed to opsWithUsers) is being populated only under some conditions, and does not actually do the job of collecting all ops that define an SSA value in that block.
  2. Even after this fix, only AffineForOps will be added to the list, but there are other cases like AffineDma... ops, AffineIfOps that are actually NOT code invariant etc. which will still cause similar problems.
Apr 7 2021, 11:01 PM · Restricted Project

Mar 31 2021

vinayaka-polymage added a comment to D98239: [MLIR][Affine] Add utility to check if the slice is valid.

Recent suggestions incorporated. I have asked for clarification on one comment.

Mar 31 2021, 2:51 AM · Restricted Project
vinayaka-polymage updated the diff for D98239: [MLIR][Affine] Add utility to check if the slice is valid.

Addressing minor comments.

Mar 31 2021, 2:45 AM · Restricted Project
vinayaka-polymage updated the diff for D98239: [MLIR][Affine] Add utility to check if the slice is valid.

Addressing recent comments, minor.

Mar 31 2021, 2:25 AM · Restricted Project

Mar 27 2021

vinayaka-polymage added a comment to D98239: [MLIR][Affine] Add utility to check if the slice is valid.

I have addressed the remaining comments:

  1. Instead of not printing the slice at all if it is incorrect, this change prints them but with a remark : "Incorrect slice" during testing.
  2. Fast check is being done, and is reusing the bounds checking utility function isSliceMaximalFastCheck. I have verified that with today's test file loop-fusion.mlir, of 156 calls to isSliceValid, 107 calls are returned after the this fast check itself.
Mar 27 2021, 3:43 AM · Restricted Project
vinayaka-polymage updated the diff for D98239: [MLIR][Affine] Add utility to check if the slice is valid.

Added back the slice computation remarks in tests, marked them incorrect slices.
Added a fast check, reused the utility - isSliceMaximalFastCheck.

Mar 27 2021, 3:32 AM · Restricted Project

Mar 11 2021

vinayaka-polymage added inline comments to D98239: [MLIR][Affine] Add utility to check if the slice is valid.
Mar 11 2021, 12:26 PM · Restricted Project
vinayaka-polymage added a comment to D98239: [MLIR][Affine] Add utility to check if the slice is valid.

Thanks for the review and suggestions !! I have completed the easy ones, and I will continue exploring the pending ones.

Mar 11 2021, 1:31 AM · Restricted Project
vinayaka-polymage updated the diff for D98239: [MLIR][Affine] Add utility to check if the slice is valid.

Addressing easy comments and suggestions, some important ones
still pending.

Mar 11 2021, 1:20 AM · Restricted Project

Mar 9 2021

vinayaka-polymage added a comment to D98239: [MLIR][Affine] Add utility to check if the slice is valid.

If this change/approach is acceptable, we can also change ComputationSliceState::isMaximal() to use the set difference the other way (source - slice), reusing these computations.

Mar 9 2021, 12:43 AM · Restricted Project
vinayaka-polymage requested review of D98239: [MLIR][Affine] Add utility to check if the slice is valid.
Mar 9 2021, 12:39 AM · Restricted Project

Feb 25 2021

vinayaka-polymage added inline comments to D97252: [MLIR][affine] Certain Call Ops to prevent fusion.
Feb 25 2021, 10:12 PM · Restricted Project
vinayaka-polymage updated the diff for D97252: [MLIR][affine] Certain Call Ops to prevent fusion.

Addressing the getOperandTypes comment

Feb 25 2021, 10:11 PM · Restricted Project
vinayaka-polymage added a comment to D97252: [MLIR][affine] Certain Call Ops to prevent fusion.

Thanks a lot for the insights @bondhugula and @dcaballe ! No more changes needed for this patch then.

Feb 25 2021, 3:31 AM · Restricted Project

Feb 24 2021

vinayaka-polymage accepted D97347: [mlir] Check 'iter_args' in 'isLoopParallel' utility.

Looks good, thanks !

Feb 24 2021, 9:36 AM · Restricted Project

Feb 22 2021

vinayaka-polymage added inline comments to D97252: [MLIR][affine] Certain Call Ops to prevent fusion.
Feb 22 2021, 11:57 PM · Restricted Project
vinayaka-polymage added a comment to D97032: [MLIR][affine] Prevent fusion when ops with memory effect free are present between producer and consumer.

Suggested additional checks and test-cases submitted at https://reviews.llvm.org/D97252

Feb 22 2021, 9:16 PM · Restricted Project
vinayaka-polymage requested review of D97252: [MLIR][affine] Certain Call Ops to prevent fusion.
Feb 22 2021, 9:14 PM · Restricted Project
vinayaka-polymage added inline comments to D97032: [MLIR][affine] Prevent fusion when ops with memory effect free are present between producer and consumer.
Feb 22 2021, 5:47 AM · Restricted Project
vinayaka-polymage updated the diff for D97032: [MLIR][affine] Prevent fusion when ops with memory effect free are present between producer and consumer.

Test case fix.

Feb 22 2021, 5:35 AM · Restricted Project

Feb 18 2021

vinayaka-polymage requested review of D97032: [MLIR][affine] Prevent fusion when ops with memory effect free are present between producer and consumer.
Feb 18 2021, 9:49 PM · Restricted Project