This is an archive of the discontinued LLVM Phabricator instance.

Differential D109223

[mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code
ClosedPublic

Authored by vinograd47 on Sep 3 2021, 4:03 AM.

Details

Reviewers
lattner
ftynse
mehdi_amini
rriddle
antiagainst
Commits
rG9a2255dfa012: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code

Diff Detail

Unit TestsFailed

TimeTest
0 msx64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1b.c
20 msx64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1h.c
0 msx64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1w.c

Event Timeline

vinograd47 created this revision.Sep 3 2021, 4:03 AM
Herald added a reviewer: rriddle. · View Herald TranscriptSep 3 2021, 4:03 AM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 17 others. · View Herald Transcript
vinograd47 requested review of this revision.Sep 3 2021, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 4:03 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ftynse accepted this revision.Sep 3 2021, 4:05 AM
This revision is now accepted and ready to land.Sep 3 2021, 4:05 AM
Harbormaster completed remote builds in B122483: Diff 370535.Sep 3 2021, 4:29 AM
lattner accepted this revision.Sep 3 2021, 8:25 AM
• hafixo added a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:44 AM
• hafixo added a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:47 AM
thopre removed a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:47 AM
thopre removed a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:51 AM
vinograd47 updated this revision to Diff 373492.Sep 19 2021, 11:49 PM

Rebased

Herald added a subscriber: wenzhicui. · View Herald TranscriptSep 19 2021, 11:49 PM
Harbormaster completed remote builds in B124598: Diff 373492.Sep 20 2021, 12:26 AM
Closed by commit rG9a2255dfa012: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code (authored by vinograd47). · Explain WhySep 20 2021, 12:36 AM
This revision was automatically updated to reflect the committed changes.
vinograd47 added a commit: rG9a2255dfa012: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code.

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
6 lines

Diff 370535

mlir/include/mlir/IR/OpBase.td

Show First 20 Lines • Show All 1,576 Lines • ▼ Show 20 Lines
} }
// Attributes containing symbol references. // Attributes containing symbol references.
def SymbolRefAttr : Attr<CPred<"$_self.isa<::mlir::SymbolRefAttr>()">, def SymbolRefAttr : Attr<CPred<"$_self.isa<::mlir::SymbolRefAttr>()">,
"symbol reference attribute"> { "symbol reference attribute"> {
let storageType = [{ ::mlir::SymbolRefAttr }]; let storageType = [{ ::mlir::SymbolRefAttr }];
let returnType = [{ ::mlir::SymbolRefAttr }]; let returnType = [{ ::mlir::SymbolRefAttr }];
let valueType = NoneType; let valueType = NoneType;
let constBuilderCall = "SymbolRefAttr::get($_builder.getContext(), $0)"; let constBuilderCall =
"::mlir::SymbolRefAttr::get($_builder.getContext(), $0)";
let convertFromStorage = "$_self"; let convertFromStorage = "$_self";
} }
def FlatSymbolRefAttr : Attr<CPred<"$_self.isa<::mlir::FlatSymbolRefAttr>()">, def FlatSymbolRefAttr : Attr<CPred<"$_self.isa<::mlir::FlatSymbolRefAttr>()">,
"flat symbol reference attribute"> { "flat symbol reference attribute"> {
let storageType = [{ ::mlir::FlatSymbolRefAttr }]; let storageType = [{ ::mlir::FlatSymbolRefAttr }];
let returnType = [{ ::llvm::StringRef }]; let returnType = [{ ::llvm::StringRef }];
let valueType = NoneType; let valueType = NoneType;
let constBuilderCall = "SymbolRefAttr::get($_builder.getContext(), $0)"; let constBuilderCall =
"::mlir::SymbolRefAttr::get($_builder.getContext(), $0)";
let convertFromStorage = "$_self.getValue()"; let convertFromStorage = "$_self.getValue()";
} }
def SymbolRefArrayAttr : def SymbolRefArrayAttr :
TypedArrayAttrBase<SymbolRefAttr, "symbol ref array attribute"> { TypedArrayAttrBase<SymbolRefAttr, "symbol ref array attribute"> {
let constBuilderCall = ?; let constBuilderCall = ?;
} }
▲ Show 20 Lines • Show All 1,299 Lines • Show Last 20 Lines