- User Since
- Feb 26 2020, 10:38 PM (59 w, 3 d)
Fri, Apr 2
Why it is located in MLIRStandardOpsTransforms, while operating in MemRef dialect? I would expect it to be a part of MLIRMemRefTransforms.
Fri, Mar 26
Added a test for the issue
Thu, Mar 25
Wed, Mar 24
Nice feature! I have one small question. Can this fallback OpInterface be represented as DialectInterface itself? In that case it can be registered in the Dialect via addInterfaces method without manual memory management (destructor overload or unique_ptr).
Tue, Mar 23
Moved get_errc_messages call prior to all add_subdirectory commands.
Mon, Mar 22
Merged two patch variants.
Mar 19 2021
@zero9178 Applied your suggestion.
Mar 18 2021
@zero9178 I've extended the condition to check only the problematic case
Mar 17 2021
Can we have several validate methods for different builders? Or the validation hook is generated only based on parameters? In that case we might have to perform the same checks in custom builders.
Python bindings call getChecked method. If I understand correctly, this method should report error instead of assertion. Right now it asserts in Debug and calls method on NULL object in Release.
Mar 16 2021
@mehdi_amini I've added a test for the change.
Mar 15 2021
Mar 10 2021
Mar 9 2021
Rebased and adjusted to latest changes in upstream.
@jpienaar I've fixed your remark.
Rebased and fixed review remarks.
@rriddle I've fixed your remarks in EnumsGen.cpp.
Rebased and fixed review comments.
Fixed clang-tidy issues
Mar 8 2021
Mar 5 2021
Mar 4 2021
Mar 3 2021
Fixed clang-format issues.
Fixed clang-tidy issues.
Mar 2 2021
@mehdi_amini What if we just add mlir/lib/Bindings/Python to https://github.com/google/llvm-premerge-checks/blob/main/scripts/clang-tidy.ignore? At least it will avoid pre-commit CI failures in changes until the python bindings is fully covered in the CI.
@ftynse @rriddle I've applied your review remarks except deprecated attribute. I didn't add it intentionally, since the main code base was not updated to the new method, this attribute will generate dozen of warnings during the build.
Applied review remarks
Mark old comments as done.
OK, But is there any chance to have the python bindings validation in CI? Right now they are not checked (at least in pre-commit) and this, for example, breaks clang-tidy checks, since it relies on compiler configuration regarding include paths, etc.
Revert move from HPP to CPP.
Rebased to latest main
@antiagainst Could you please take a look? Will this version work with current StringLiteral limitations?
Use explicit StringLiteral ctor call.
Mar 1 2021
@ftynse I saw the proposal about data layout and custom elements. How it assume to perform the validity check? I thought it will extend the existing isValidElementType method with more advanced checks. IMHO, in that case it will be simpler to do this in CPP file, otherwise it might bring extra dependencies to header file or make the method to complex to be inline. That's why I've moved its implementation to CPP.
Feb 27 2021
Feb 26 2021
Update TypeDef - getMnemonic method.
Update related section in LangRef documentation.
Use getMemorySpaceAsInt instead of getMemorySpaceInteger.
Fixed clang-tidy issues in new tests.
@courbet I saw in git history that you have had similar commit, which was reverted. Could you please take a look at this change?
Feb 25 2021
Re-implemented the feature on top of separate "renaming" change.