Page MenuHomePhabricator

vinograd47 (Vladislav Vinogradov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2020, 10:38 PM (117 w, 1 d)

Recent Activity

Oct 29 2021

vinograd47 added inline comments to D111547: [mlir] Allow to use vformat utility with MLIR classes.
Oct 29 2021, 5:24 AM · Restricted Project
vinograd47 committed rG17664a256f5f: [mlir][NFC] Fix leak in unit test (authored by vinograd47).
[mlir][NFC] Fix leak in unit test
Oct 29 2021, 5:24 AM

Oct 19 2021

vinograd47 committed rGe41ebbecf97a: [mlir][RFC] Refactor layout representation in MemRefType (authored by vinograd47).
[mlir][RFC] Refactor layout representation in MemRefType
Oct 19 2021, 2:43 AM
vinograd47 closed D111553: [mlir][RFC] Refactor layout representation in MemRefType.
Oct 19 2021, 2:43 AM · Restricted Project
vinograd47 added a comment to D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.

I don't think that is really what I was saying though: this does not provide a feature to elide the type only if the producer is in the same block. Right now you just poked a hole through the declarative assembly syntax which allows to make it unsafe.

Oct 19 2021, 2:28 AM · Restricted Project
vinograd47 updated the diff for D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.

Add more checks to OperationParser::resolveSSAUse to handle the misuse of the feature.

Oct 19 2021, 2:26 AM · Restricted Project

Oct 18 2021

vinograd47 updated the diff for D111553: [mlir][RFC] Refactor layout representation in MemRefType.

@ftynse @rriddle Addressed your comments.

Oct 18 2021, 7:35 AM · Restricted Project
vinograd47 added a comment to D111553: [mlir][RFC] Refactor layout representation in MemRefType.

@ftynse I've addressed your comments.

Oct 18 2021, 6:55 AM · Restricted Project
vinograd47 updated the diff for D111553: [mlir][RFC] Refactor layout representation in MemRefType.

Addressed review comments

Oct 18 2021, 6:49 AM · Restricted Project
vinograd47 added a comment to D111553: [mlir][RFC] Refactor layout representation in MemRefType.

@bondhugula I've addressed your comments, please take a look one more time.

Oct 18 2021, 5:48 AM · Restricted Project
vinograd47 updated the diff for D111553: [mlir][RFC] Refactor layout representation in MemRefType.

Addressed review comments

Oct 18 2021, 5:42 AM · Restricted Project
vinograd47 added a comment to D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.

Maybe you missed my last answer on Discourse, can you take another look there?

Oct 18 2021, 12:12 AM · Restricted Project

Oct 15 2021

vinograd47 added a comment to D111553: [mlir][RFC] Refactor layout representation in MemRefType.

@ftynse @bondhugula I've addressed your comments.

Oct 15 2021, 8:47 AM · Restricted Project
vinograd47 updated the diff for D111553: [mlir][RFC] Refactor layout representation in MemRefType.

Updated according to review remarks

Oct 15 2021, 7:03 AM · Restricted Project
vinograd47 updated the diff for D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.

I've redone the change. Now it doesn't touch the ODS generation logic,
instead I've used Custom Directives in assembly format to implement the desired behavior.
The only change in the core part - relaxed check in the OperationParser.

Oct 15 2021, 3:31 AM · Restricted Project

Oct 13 2021

vinograd47 added a comment to D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.

(Marking as general -1 for now)

Oct 13 2021, 2:21 AM · Restricted Project
vinograd47 added a comment to D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.

Leaving aside your syntax issue, I don't understand a use-case where it makes sense in MLIR to have the verifyUsedOnlyInTrivialSSACFG restriction applied on the parent regions transitively. Can you elaborate on this?

Oct 13 2021, 1:35 AM · Restricted Project

Oct 12 2021

vinograd47 requested review of D111650: [mlir][RFC] Allow to skip operands type specification in ASM form.
Oct 12 2021, 8:31 AM · Restricted Project
vinograd47 committed rGd6296c3b0088: [mlir] Allow to use vformat utility with MLIR classes (authored by vinograd47).
[mlir] Allow to use vformat utility with MLIR classes
Oct 12 2021, 3:27 AM
vinograd47 closed D111547: [mlir] Allow to use vformat utility with MLIR classes.
Oct 12 2021, 3:27 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Rebased to re-run pre-commit CI

Oct 12 2021, 3:20 AM · Restricted Project
vinograd47 updated the diff for D111547: [mlir] Allow to use vformat utility with MLIR classes.

Applied review remark and reverted unnecessary format changes

Oct 12 2021, 3:05 AM · Restricted Project
vinograd47 committed rGc6390f19f20c: [mlir] Fix AsmPrinter for types with sub elements (authored by vinograd47).
[mlir] Fix AsmPrinter for types with sub elements
Oct 12 2021, 2:18 AM
vinograd47 closed D111536: [mlir] Fix AsmPrinter for types with sub elements.
Oct 12 2021, 2:18 AM · Restricted Project
vinograd47 committed rG505afd1e6483: [mlir] Clean up boolean flags usage in LIT tests (authored by vinograd47).
[mlir] Clean up boolean flags usage in LIT tests
Oct 12 2021, 2:05 AM
vinograd47 closed D110073: [mlir] Clean up boolean flags usage in LIT tests.
Oct 12 2021, 2:05 AM · Restricted Project

Oct 11 2021

vinograd47 requested review of D111553: [mlir][RFC] Refactor layout representation in MemRefType.
Oct 11 2021, 8:32 AM · Restricted Project
vinograd47 requested review of D111547: [mlir] Allow to use vformat utility with MLIR classes.
Oct 11 2021, 7:10 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

I've excluded questionable part (non-const references support) from the patch.
Could you please take a look one more time?

Oct 11 2021, 5:49 AM · Restricted Project
vinograd47 requested review of D111536: [mlir] Fix AsmPrinter for types with sub elements.
Oct 11 2021, 4:59 AM · Restricted Project
vinograd47 added a comment to D110073: [mlir] Clean up boolean flags usage in LIT tests.

@mehdi_amini @rriddle @ftynse @aartbik @nicolasvasilache @herhut Gentle reminder, could you please take a look at this patch?

Oct 11 2021, 2:41 AM · Restricted Project

Oct 1 2021

vinograd47 accepted D110921: [mlir] Tighten strided layout specification..
Oct 1 2021, 5:06 AM · Restricted Project
vinograd47 abandoned D106869: [mlir] Allow to use Quant types as elements of MemRef type.
Oct 1 2021, 1:18 AM · Restricted Project
vinograd47 abandoned D106877: [mlir] Allow composed affine maps in memref.subview.
Oct 1 2021, 1:17 AM · Restricted Project

Sep 20 2021

vinograd47 updated the diff for D110073: [mlir] Clean up boolean flags usage in LIT tests.

Fix llvm_canonicalize_cmake_booleans usage

Sep 20 2021, 8:31 AM · Restricted Project
vinograd47 requested review of D110073: [mlir] Clean up boolean flags usage in LIT tests.
Sep 20 2021, 7:36 AM · Restricted Project
vinograd47 added a comment to D108505: [mlir] Fix bug in partial dialect conversion.

@akuegel @ftynse I've just pushed a fix to upstream.

Sep 20 2021, 1:48 AM · Restricted Project
vinograd47 committed rG798e4bfbeda8: [mlir] Fix integration tests failures introduced in D108505 (authored by vinograd47).
[mlir] Fix integration tests failures introduced in D108505
Sep 20 2021, 1:47 AM
vinograd47 added a comment to D108505: [mlir] Fix bug in partial dialect conversion.

@akuegel Yes, I'm currently investigating them.

Sep 20 2021, 1:24 AM · Restricted Project
vinograd47 committed rGec03bbe8a74a: [mlir] Fix bug in partial dialect conversion (authored by vinograd47).
[mlir] Fix bug in partial dialect conversion
Sep 20 2021, 12:38 AM
vinograd47 closed D108505: [mlir] Fix bug in partial dialect conversion.
Sep 20 2021, 12:38 AM · Restricted Project
vinograd47 committed rG9a2255dfa012: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code (authored by vinograd47).
[mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code
Sep 20 2021, 12:37 AM
vinograd47 closed D109223: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code.
Sep 20 2021, 12:36 AM · Restricted Project
vinograd47 added a comment to D108505: [mlir] Fix bug in partial dialect conversion.

Are there cases (e.g., tests) where we expect the parallel loops with unsupported mapping to persist in the IR or are we always erroring out? In the latter case, just keeping the unlowered op as illegal would still error out but with a different message (conversion failed), we can just update the message in tests in that case.

Sep 20 2021, 12:17 AM · Restricted Project
vinograd47 updated the diff for D108505: [mlir] Fix bug in partial dialect conversion.

Rebased and extend NOTE/TODO comment

Sep 20 2021, 12:05 AM · Restricted Project

Sep 19 2021

vinograd47 updated the diff for D109223: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code.

Rebased

Sep 19 2021, 11:49 PM · Restricted Project

Sep 3 2021

vinograd47 requested review of D109223: [mlir][NFC] Add explicit "::mlir" namespace to tblgen generated code.
Sep 3 2021, 4:03 AM · Restricted Project

Aug 26 2021

vinograd47 added a comment to D108505: [mlir] Fix bug in partial dialect conversion.

@ftynse @herhut Please take a look into GPU related part.

Aug 26 2021, 1:36 AM · Restricted Project

Aug 23 2021

vinograd47 added a comment to D108505: [mlir] Fix bug in partial dialect conversion.

@rriddle I've fixed your remarks

Aug 23 2021, 8:17 AM · Restricted Project
vinograd47 updated the diff for D108505: [mlir] Fix bug in partial dialect conversion.

Fix review remarks

Aug 23 2021, 8:16 AM · Restricted Project
vinograd47 added inline comments to D108505: [mlir] Fix bug in partial dialect conversion.
Aug 23 2021, 8:09 AM · Restricted Project
vinograd47 updated the diff for D108505: [mlir] Fix bug in partial dialect conversion.

Fixed review remarks

Aug 23 2021, 8:06 AM · Restricted Project
vinograd47 added a comment to D108505: [mlir] Fix bug in partial dialect conversion.

@bondhugula I've fixed your remarks.

Aug 23 2021, 1:02 AM · Restricted Project
vinograd47 updated the diff for D108505: [mlir] Fix bug in partial dialect conversion.

Applied review remarks.

Aug 23 2021, 1:00 AM · Restricted Project

Aug 21 2021

vinograd47 requested review of D108505: [mlir] Fix bug in partial dialect conversion.
Aug 21 2021, 12:18 AM · Restricted Project

Aug 20 2021

vinograd47 committed rG9775c0c9f0bb: [mlir] Fix ControlFlowInterfaces implementation for Async dialect (authored by vinograd47).
[mlir] Fix ControlFlowInterfaces implementation for Async dialect
Aug 20 2021, 2:14 AM
vinograd47 closed D108373: [mlir] Fix ControlFlowInterfaces implementation for Async dialect.
Aug 20 2021, 2:13 AM · Restricted Project
vinograd47 committed rGd1883bc3220d: [mlir][NFC] Use explicit ::mlir namespace in mlir-tblgen generated code (authored by vinograd47).
[mlir][NFC] Use explicit ::mlir namespace in mlir-tblgen generated code
Aug 20 2021, 1:51 AM
vinograd47 closed D108376: [mlir][NFC] Use explicit ::mlir namespace in mlir-tblgen generated code.
Aug 20 2021, 1:51 AM · Restricted Project

Aug 19 2021

vinograd47 abandoned D104638: [omp] Fix build without ITT after D103121 changes.
Aug 19 2021, 9:40 AM · Restricted Project
vinograd47 requested review of D108376: [mlir][NFC] Use explicit ::mlir namespace in mlir-tblgen generated code.
Aug 19 2021, 7:48 AM · Restricted Project
vinograd47 requested review of D108373: [mlir] Fix ControlFlowInterfaces implementation for Async dialect.
Aug 19 2021, 6:39 AM · Restricted Project

Aug 6 2021

vinograd47 committed rG59f59d1c621c: [mlir] Allow to override type/attr aliases from various hooks (authored by vinograd47).
[mlir] Allow to override type/attr aliases from various hooks
Aug 6 2021, 2:05 AM
vinograd47 closed D107437: [mlir] Allow to override type/attr aliases from various hooks.
Aug 6 2021, 2:04 AM · Restricted Project
vinograd47 added a comment to D107437: [mlir] Allow to override type/attr aliases from various hooks.

@rriddle I've applied your suggestions.

Aug 6 2021, 1:06 AM · Restricted Project
vinograd47 updated the diff for D107437: [mlir] Allow to override type/attr aliases from various hooks.

Apply review remarks

Aug 6 2021, 1:04 AM · Restricted Project

Aug 5 2021

vinograd47 added a comment to D107437: [mlir] Allow to override type/attr aliases from various hooks.

If this is just to avoid the generic alias in the "parent" dialect (in this case, the builtin dialect), can we just flip the iteration order of the dialect interfaces when building the alias set? I'm not sure when Optional would ever really be used outside of that use case.

Aug 5 2021, 12:10 AM · Restricted Project

Aug 4 2021

vinograd47 requested review of D107437: [mlir] Allow to override type/attr aliases from various hooks.
Aug 4 2021, 2:42 AM · Restricted Project

Aug 3 2021

vinograd47 committed rG9b50844fd798: [mlir] Fix delayed object interfaces registration (authored by vinograd47).
[mlir] Fix delayed object interfaces registration
Aug 3 2021, 2:21 AM
vinograd47 closed D107274: [mlir] Fix delayed object interfaces registration.
Aug 3 2021, 2:21 AM · Restricted Project
vinograd47 added a comment to D107274: [mlir] Fix delayed object interfaces registration.

Or in other words, current implementation doesn't allow to attach the same interface implementation to several objects from one dialect. And it doesn't matter if it is a single interface model for all objects or it is different model classes.

Aug 3 2021, 1:50 AM · Restricted Project
vinograd47 added a comment to D107274: [mlir] Fix delayed object interfaces registration.

I wouldn't call this a fix. Having the same class implement the interface for different objects actually sounds like a new functionality.

Aug 3 2021, 1:32 AM · Restricted Project

Aug 2 2021

vinograd47 requested review of D107274: [mlir] Fix delayed object interfaces registration.
Aug 2 2021, 6:50 AM · Restricted Project

Jul 28 2021

vinograd47 added a comment to D106877: [mlir] Allow composed affine maps in memref.subview.

Actually it is shown in the test) We decompose virtual index permutation and strided form:

Jul 28 2021, 9:09 AM · Restricted Project
vinograd47 added a comment to D106877: [mlir] Allow composed affine maps in memref.subview.

@nicolasvasilache I've started a discussion on discourse with this topic - https://llvm.discourse.group/t/rfc-memreftype-affine-maps-list-vs-single-item/3968

Jul 28 2021, 8:34 AM · Restricted Project
vinograd47 added a comment to D106877: [mlir] Allow composed affine maps in memref.subview.

The thing is - MemRefType API allows to use lists of affine maps. But in various places there are assumption, that it contains single item (or it is empty). And sometimes those assumption is not even checked and just the first/last item is used without any check/assertion. IMHO, this makes the code base fragile.

Jul 28 2021, 7:16 AM · Restricted Project
vinograd47 added a comment to D106877: [mlir] Allow composed affine maps in memref.subview.

@ftynse Thanks for clarification! Actually in our internal project we use decomposed list of affine maps exactly as in your example (separate virtual indexing permutation and strided form to get physical indexing). At least this approach doesn't contradict original MemRef design.

Jul 28 2021, 4:02 AM · Restricted Project
vinograd47 added a comment to D106877: [mlir] Allow composed affine maps in memref.subview.

I have a question about affine maps list in MemRef type in general. Just this is the second place on my memory, where only the first element of the list is used. Which brings a question, why MemRef uses list of affine maps and not a single affine map? I was under impression, that the list allows to store a composition of affine maps to make it simpler for some cases. Is this true or its wrong interpretation?

Jul 28 2021, 2:21 AM · Restricted Project

Jul 27 2021

vinograd47 requested review of D106877: [mlir] Allow composed affine maps in memref.subview.
Jul 27 2021, 7:50 AM · Restricted Project
vinograd47 requested review of D106869: [mlir] Allow to use Quant types as elements of MemRef type.
Jul 27 2021, 5:54 AM · Restricted Project

Jul 26 2021

vinograd47 committed rGeb6c63cb0b6e: [mlir] Fix RankedTensorType::walkImmediateSubElements method (authored by vinograd47).
[mlir] Fix RankedTensorType::walkImmediateSubElements method
Jul 26 2021, 1:49 AM
vinograd47 closed D105554: [mlir] Fix RankedTensorType::walkImmediateSubElements method.
Jul 26 2021, 1:49 AM · Restricted Project

Jul 17 2021

vinograd47 added a comment to D105554: [mlir] Fix RankedTensorType::walkImmediateSubElements method.

@rriddle I've fixed your remarks.

Jul 17 2021, 5:19 AM · Restricted Project
vinograd47 updated the diff for D105554: [mlir] Fix RankedTensorType::walkImmediateSubElements method.

Fixed review remarks.

Jul 17 2021, 5:18 AM · Restricted Project

Jul 7 2021

vinograd47 requested review of D105554: [mlir] Fix RankedTensorType::walkImmediateSubElements method.
Jul 7 2021, 8:08 AM · Restricted Project

Jun 21 2021

vinograd47 committed rGeab1fd389b61: [omp] Fix build without ITT after D103121 changes (authored by vinograd47).
[omp] Fix build without ITT after D103121 changes
Jun 21 2021, 8:17 AM
vinograd47 closed D104638: [omp] Fix build without ITT after D103121 changes.
Jun 21 2021, 8:17 AM · Restricted Project
vinograd47 requested review of D104638: [omp] Fix build without ITT after D103121 changes.
Jun 21 2021, 6:03 AM · Restricted Project
vinograd47 committed rG628e13673882: [mlir][ODS] Fix copy ctor for generate Pass classes (authored by vinograd47).
[mlir][ODS] Fix copy ctor for generate Pass classes
Jun 21 2021, 4:07 AM
vinograd47 closed D104302: [mlir][ODS] Fix copy ctor for generate Pass classes.
Jun 21 2021, 4:07 AM · Restricted Project

Jun 18 2021

vinograd47 added a comment to D104302: [mlir][ODS] Fix copy ctor for generate Pass classes.

@lattner Sorry, my comment about Canonicalization pass was wrong and confusing (removed it).

Jun 18 2021, 2:27 AM · Restricted Project
vinograd47 updated the diff for D104302: [mlir][ODS] Fix copy ctor for generate Pass classes.

Removed confusing comment about Canonicalization pass.

Jun 18 2021, 2:21 AM · Restricted Project

Jun 17 2021

vinograd47 added a comment to D104302: [mlir][ODS] Fix copy ctor for generate Pass classes.

Only request: please merge the unit test into the existing test/lib/Pass stuff.

Jun 17 2021, 1:11 AM · Restricted Project

Jun 15 2021

vinograd47 requested review of D104302: [mlir][ODS] Fix copy ctor for generate Pass classes.
Jun 15 2021, 8:13 AM · Restricted Project

May 5 2021

vinograd47 added inline comments to D101859: [MLIR] Introduce join/meet type interface..
May 5 2021, 12:25 AM · Restricted Project

Apr 2 2021

vinograd47 added a comment to D99229: Add a pattern to combine composed subview ops.

Why it is located in MLIRStandardOpsTransforms, while operating in MemRef dialect? I would expect it to be a part of MLIRMemRefTransforms.

Apr 2 2021, 12:09 AM · Restricted Project

Mar 26 2021

vinograd47 committed rG15b76e6ca0a0: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops (authored by vinograd47).
[mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops
Mar 26 2021, 4:26 AM
vinograd47 closed D99332: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops.
Mar 26 2021, 4:26 AM · Restricted Project
vinograd47 updated the diff for D99332: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops.

Added a test for the issue

Mar 26 2021, 2:14 AM · Restricted Project

Mar 25 2021

vinograd47 requested review of D99332: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops.
Mar 25 2021, 5:10 AM · Restricted Project