Page MenuHomePhabricator

vinograd47 (Vladislav Vinogradov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2020, 10:38 PM (59 w, 3 d)

Recent Activity

Fri, Apr 2

vinograd47 added a comment to D99229: Add a pattern to combine composed subview ops.

Why it is located in MLIRStandardOpsTransforms, while operating in MemRef dialect? I would expect it to be a part of MLIRMemRefTransforms.

Fri, Apr 2, 12:09 AM · Restricted Project

Fri, Mar 26

vinograd47 committed rG15b76e6ca0a0: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops (authored by vinograd47).
[mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops
Fri, Mar 26, 4:26 AM
vinograd47 closed D99332: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops.
Fri, Mar 26, 4:26 AM · Restricted Project
vinograd47 updated the diff for D99332: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops.

Added a test for the issue

Fri, Mar 26, 2:14 AM · Restricted Project

Thu, Mar 25

vinograd47 requested review of D99332: [mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops.
Thu, Mar 25, 5:10 AM · Restricted Project
vinograd47 committed rG70b6f16e07f7: [mlir] Support MemRefType with multiple AffineMaps in getStridesAndOffset (authored by vinograd47).
[mlir] Support MemRefType with multiple AffineMaps in getStridesAndOffset
Thu, Mar 25, 2:24 AM
vinograd47 closed D99166: [mlir] Support MemRefType with multiple AffineMaps in getStridesAndOffset.
Thu, Mar 25, 2:24 AM · Restricted Project

Wed, Mar 24

vinograd47 committed rG18a2f479bf47: [mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible (authored by vinograd47).
[mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible
Wed, Mar 24, 3:24 AM
vinograd47 closed D99154: [mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible.
Wed, Mar 24, 3:24 AM · Restricted Project
vinograd47 added a comment to D93085: Add a mechanism for Dialects to provide a fallback for OpInterface.

Nice feature! I have one small question. Can this fallback OpInterface be represented as DialectInterface itself? In that case it can be registered in the Dialect via addInterfaces method without manual memory management (destructor overload or unique_ptr).

Wed, Mar 24, 2:57 AM · Restricted Project

Tue, Mar 23

vinograd47 requested review of D99166: [mlir] Support MemRefType with multiple AffineMaps in getStridesAndOffset.
Tue, Mar 23, 3:35 AM · Restricted Project
vinograd47 committed rG94470777af8b: [CMAKE] Fix cross-compilation build (authored by vinograd47).
[CMAKE] Fix cross-compilation build
Tue, Mar 23, 3:24 AM
vinograd47 closed D98861: [CMAKE] Fix cross-compilation build.
Tue, Mar 23, 3:23 AM · Restricted Project
vinograd47 requested review of D99154: [mlir][NFC] Replace `getMemorySpaceAsInt` with `getMemorySpace` where possible.
Tue, Mar 23, 1:47 AM · Restricted Project
vinograd47 added inline comments to D98861: [CMAKE] Fix cross-compilation build.
Tue, Mar 23, 1:39 AM · Restricted Project
vinograd47 updated the diff for D98861: [CMAKE] Fix cross-compilation build.

@jhenderson Done

Tue, Mar 23, 1:26 AM · Restricted Project
vinograd47 updated the diff for D98861: [CMAKE] Fix cross-compilation build.

Moved get_errc_messages call prior to all add_subdirectory commands.

Tue, Mar 23, 1:22 AM · Restricted Project

Mon, Mar 22

vinograd47 updated the diff for D98861: [CMAKE] Fix cross-compilation build.

Merged two patch variants.

Mon, Mar 22, 2:29 AM · Restricted Project

Mar 19 2021

vinograd47 updated the diff for D98861: [CMAKE] Fix cross-compilation build.

@zero9178 Applied your suggestion.

Mar 19 2021, 1:32 AM · Restricted Project

Mar 18 2021

vinograd47 updated the diff for D98861: [CMAKE] Fix cross-compilation build.

@zero9178 I've extended the condition to check only the problematic case

Mar 18 2021, 6:59 AM · Restricted Project
vinograd47 added a comment to D98861: [CMAKE] Fix cross-compilation build.

According to https://cmake.org/cmake/help/latest/command/try_run.html#behavior-when-cross-compiling:

Mar 18 2021, 6:01 AM · Restricted Project
vinograd47 requested review of D98861: [CMAKE] Fix cross-compilation build.
Mar 18 2021, 5:49 AM · Restricted Project
vinograd47 committed rG02834e1bd946: [mlir][ODS] Get rid of limitations in rewriters generator (authored by vinograd47).
[mlir][ODS] Get rid of limitations in rewriters generator
Mar 18 2021, 2:23 AM
vinograd47 closed D97839: [mlir][ODS] Get rid of limitations in rewriters generator.
Mar 18 2021, 2:23 AM · Restricted Project
vinograd47 added a reviewer for D98764: [mlir] Fix Python bindings tests failure in Debug mode after D98474: mehdi_amini.

@rriddle @ftynse @mehdi_amini Could you please clarify the desired behavior?

Mar 18 2021, 1:48 AM · Restricted Project

Mar 17 2021

vinograd47 updated the diff for D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

Rebased

Mar 17 2021, 7:09 AM · Restricted Project
vinograd47 committed rGfee90542326b: [mlir][ODS] Support specialized Attribute class for Enums (authored by vinograd47).
[mlir][ODS] Support specialized Attribute class for Enums
Mar 17 2021, 6:53 AM
vinograd47 closed D97836: [mlir][ODS] Support specialized Attribute class for Enums.
Mar 17 2021, 6:52 AM · Restricted Project
vinograd47 added a comment to D98764: [mlir] Fix Python bindings tests failure in Debug mode after D98474.

Can we have several validate methods for different builders? Or the validation hook is generated only based on parameters? In that case we might have to perform the same checks in custom builders.

Mar 17 2021, 3:37 AM · Restricted Project
vinograd47 added a comment to D98764: [mlir] Fix Python bindings tests failure in Debug mode after D98474.

Python bindings call getChecked method. If I understand correctly, this method should report error instead of assertion. Right now it asserts in Debug and calls method on NULL object in Release.

Mar 17 2021, 3:36 AM · Restricted Project
vinograd47 added reviewers for D98764: [mlir] Fix Python bindings tests failure in Debug mode after D98474: antiagainst, ftynse.
Mar 17 2021, 2:13 AM · Restricted Project
vinograd47 requested review of D98764: [mlir] Fix Python bindings tests failure in Debug mode after D98474.
Mar 17 2021, 1:58 AM · Restricted Project

Mar 16 2021

vinograd47 updated the diff for D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

@mehdi_amini I've added a test for the change.

Mar 16 2021, 3:30 AM · Restricted Project

Mar 15 2021

vinograd47 updated the diff for D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

Rebased

Mar 15 2021, 5:05 AM · Restricted Project
vinograd47 updated the diff for D97836: [mlir][ODS] Support specialized Attribute class for Enums.

Rebased

Mar 15 2021, 2:34 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Rebased

Mar 15 2021, 2:07 AM · Restricted Project

Mar 10 2021

vinograd47 added a comment to D98336: [mlir][CMAKE] Fix build with BUILD_SHARED_LIBS=ON.

@ftynse I believe the issue was caused by D98328

Mar 10 2021, 5:19 AM · Restricted Project
vinograd47 requested review of D98336: [mlir][CMAKE] Fix build with BUILD_SHARED_LIBS=ON.
Mar 10 2021, 5:17 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

Can you file individual bugs against each of these components to update to richer attributes?

Mar 10 2021, 2:12 AM · Restricted Project
vinograd47 committed rGf3bf5c053b06: [mlir] Model MemRef memory space as Attribute (authored by vinograd47).
[mlir] Model MemRef memory space as Attribute
Mar 10 2021, 2:02 AM
vinograd47 closed D96145: [mlir] Model MemRef memory space as Attribute.
Mar 10 2021, 2:01 AM · Restricted Project
vinograd47 committed rGdc8446c2a088: [ADT][NFC] Use `size_t` type for index in `indexed_accessor_range` (authored by vinograd47).
[ADT][NFC] Use `size_t` type for index in `indexed_accessor_range`
Mar 10 2021, 12:42 AM
vinograd47 closed D97921: [ADT][NFC] Use `size_t` type for index in `indexed_accessor_range`.
Mar 10 2021, 12:42 AM · Restricted Project

Mar 9 2021

vinograd47 updated the diff for D97921: [ADT][NFC] Use `size_t` type for index in `indexed_accessor_range`.

Rebased

Mar 9 2021, 7:05 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@ftynse @rriddle @mehdi_amini Do you have any more comments for this change?

Mar 9 2021, 6:52 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Rebased and adjusted to latest changes in upstream.

Mar 9 2021, 6:44 AM · Restricted Project
vinograd47 added a comment to D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

@jpienaar I've fixed your remark.

Mar 9 2021, 2:35 AM · Restricted Project
vinograd47 updated the diff for D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

Rebased and fixed review remarks.

Mar 9 2021, 2:32 AM · Restricted Project
vinograd47 added a comment to D97836: [mlir][ODS] Support specialized Attribute class for Enums.

@rriddle I've fixed your remarks in EnumsGen.cpp.

Mar 9 2021, 2:08 AM · Restricted Project
vinograd47 updated the diff for D97836: [mlir][ODS] Support specialized Attribute class for Enums.

Rebased and fixed review comments.

Mar 9 2021, 2:07 AM · Restricted Project
vinograd47 updated the diff for D97921: [ADT][NFC] Use `size_t` type for index in `indexed_accessor_range`.

Fixed clang-tidy issues

Mar 9 2021, 12:14 AM · Restricted Project

Mar 8 2021

vinograd47 committed rG2241b3986cd5: [mlir][CMAKE] Fix cross-compilation build (authored by vinograd47).
[mlir][CMAKE] Fix cross-compilation build
Mar 8 2021, 11:52 PM
vinograd47 closed D98025: [mlir][CMAKE] Fix cross-compilation build.
Mar 8 2021, 11:52 PM · Restricted Project

Mar 5 2021

vinograd47 added inline comments to D97836: [mlir][ODS] Support specialized Attribute class for Enums.
Mar 5 2021, 8:57 AM · Restricted Project
vinograd47 requested review of D98025: [mlir][CMAKE] Fix cross-compilation build.
Mar 5 2021, 2:47 AM · Restricted Project

Mar 4 2021

vinograd47 requested review of D97921: [ADT][NFC] Use `size_t` type for index in `indexed_accessor_range`.
Mar 4 2021, 1:42 AM · Restricted Project

Mar 3 2021

vinograd47 updated the diff for D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

Fixed clang-format issues.

Mar 3 2021, 6:34 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Rebased

Mar 3 2021, 6:26 AM · Restricted Project
vinograd47 updated the diff for D97836: [mlir][ODS] Support specialized Attribute class for Enums.

Fixed clang-tidy issues.

Mar 3 2021, 5:46 AM · Restricted Project
vinograd47 committed rG5d613e42d376: [mlir][ODS] Use StringLiteral instead of StringRef when applicable (authored by vinograd47).
[mlir][ODS] Use StringLiteral instead of StringRef when applicable
Mar 3 2021, 5:16 AM
vinograd47 closed D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.
Mar 3 2021, 5:16 AM · Restricted Project
vinograd47 committed rGe3b350ce83a0: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser (authored by vinograd47).
[mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser
Mar 3 2021, 5:04 AM
vinograd47 closed D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.
Mar 3 2021, 5:03 AM · Restricted Project
vinograd47 requested review of D97839: [mlir][ODS] Get rid of limitations in rewriters generator.
Mar 3 2021, 1:09 AM · Restricted Project
vinograd47 updated the diff for D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Rebased

Mar 3 2021, 12:51 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Rebased

Mar 3 2021, 12:17 AM · Restricted Project
vinograd47 requested review of D97836: [mlir][ODS] Support specialized Attribute class for Enums.
Mar 3 2021, 12:09 AM · Restricted Project

Mar 2 2021

vinograd47 updated the diff for D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.

Rebased

Mar 2 2021, 11:42 PM · Restricted Project
vinograd47 added a comment to D97613: [mlir][CMAKE] Detect and enable python binding automatically.

@mehdi_amini What if we just add mlir/lib/Bindings/Python to https://github.com/google/llvm-premerge-checks/blob/main/scripts/clang-tidy.ignore? At least it will avoid pre-commit CI failures in changes until the python bindings is fully covered in the CI.

Mar 2 2021, 10:47 PM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@ftynse @rriddle I've applied your review remarks except deprecated attribute. I didn't add it intentionally, since the main code base was not updated to the new method, this attribute will generate dozen of warnings during the build.

Mar 2 2021, 9:48 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Applied review remarks

Mar 2 2021, 9:40 AM · Restricted Project
vinograd47 added a comment to D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Is this something that we want to make a convention, then we'd want to then capture in https://mlir.llvm.org/getting_started/DeveloperGuide/ (I don't believe it is a LLVM convention)

Mar 2 2021, 9:37 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

Mark old comments as done.

Mar 2 2021, 9:29 AM · Restricted Project
vinograd47 updated the diff for D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Rebased

Mar 2 2021, 9:14 AM · Restricted Project
vinograd47 updated the diff for D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.

Rebased

Mar 2 2021, 9:01 AM · Restricted Project
vinograd47 abandoned D97613: [mlir][CMAKE] Detect and enable python binding automatically.

OK, But is there any chance to have the python bindings validation in CI? Right now they are not checked (at least in pre-commit) and this, for example, breaks clang-tidy checks, since it relies on compiler configuration regarding include paths, etc.

Mar 2 2021, 12:41 AM · Restricted Project
vinograd47 added a comment to D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.

@ftynse @rriddle I've reverted the method move to CPP file. Are you OK with its usage in Parser instead of duplicating check code?

Mar 2 2021, 12:38 AM · Restricted Project
vinograd47 updated the diff for D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.

Revert move from HPP to CPP.

Mar 2 2021, 12:36 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@ftynse @rriddle @mehdi_amini The dependency for this change (old method renaming) was landed. Could you please take a look at this change one more time?

Mar 2 2021, 12:29 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Rebased to latest main

Mar 2 2021, 12:28 AM · Restricted Project
vinograd47 committed rG37eca08e5bcf: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt` (authored by vinograd47).
[mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`
Mar 2 2021, 12:20 AM
vinograd47 closed D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.
Mar 2 2021, 12:20 AM · Restricted Project
vinograd47 added a comment to D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

@antiagainst Could you please take a look? Will this version work with current StringLiteral limitations?

Mar 2 2021, 12:04 AM · Restricted Project
vinograd47 updated the diff for D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Use explicit StringLiteral ctor call.

Mar 2 2021, 12:03 AM · Restricted Project

Mar 1 2021

vinograd47 added a comment to D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.

@ftynse I saw the proposal about data layout and custom elements. How it assume to perform the validity check? I thought it will extend the existing isValidElementType method with more advanced checks. IMHO, in that case it will be simpler to do this in CPP file, otherwise it might bring extra dependencies to header file or make the method to complex to be inline. That's why I've moved its implementation to CPP.

Mar 1 2021, 9:33 AM · Restricted Project

Feb 27 2021

vinograd47 requested review of D97613: [mlir][CMAKE] Detect and enable python binding automatically.
Feb 27 2021, 3:29 AM · Restricted Project
vinograd47 requested review of D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.
Feb 27 2021, 3:20 AM · Restricted Project
vinograd47 added a comment to D94769: [Support] Format provider improvements.

@sammccall @zturner ping

Feb 27 2021, 2:58 AM · Restricted Project

Feb 26 2021

vinograd47 updated the diff for D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Update TypeDef - getMnemonic method.

Feb 26 2021, 8:54 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Update related section in LangRef documentation.

Feb 26 2021, 8:33 AM · Restricted Project
vinograd47 added inline comments to D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.
Feb 26 2021, 8:18 AM · Restricted Project
vinograd47 updated the diff for D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.

Use getMemorySpaceAsInt instead of getMemorySpaceInteger.

Feb 26 2021, 8:17 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Fixed clang-tidy issues in new tests.

Feb 26 2021, 8:04 AM · Restricted Project
vinograd47 committed rG9909237d9920: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef` (authored by vinograd47).
[ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`
Feb 26 2021, 7:37 AM
vinograd47 closed D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.
Feb 26 2021, 7:37 AM · Restricted Project
vinograd47 added a comment to D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

@courbet I saw in git history that you have had similar commit, which was reverted. Could you please take a look at this change?

Feb 26 2021, 5:25 AM · Restricted Project
vinograd47 added a reviewer for D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`: courbet.
Feb 26 2021, 5:23 AM · Restricted Project

Feb 25 2021

vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Re-implemented the feature on top of separate "renaming" change.

Feb 25 2021, 9:16 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@mehdi_amini Submitted separate change for the first part (method renaming) : https://reviews.llvm.org/D97476

Feb 25 2021, 8:08 AM · Restricted Project
vinograd47 requested review of D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.
Feb 25 2021, 8:07 AM · Restricted Project