This is an archive of the discontinued LLVM Phabricator instance.

Differential D109062

Revert "Disable ReplaceLDS pass, patch up tests to match"
ClosedPublic

Authored by hsmhsm on Sep 1 2021, 7:23 AM.

Details

Reviewers
JonChesterfield
arsenm
rampitec
ronlieb
Commits
rG5ae6804d179e: Revert "Disable ReplaceLDS pass, patch up tests to match"
Summary

This reverts commit 50ad3478bdd3f0643ee94f6663293af5b3c27afe.

Diff Detail

Event Timeline

hsmhsm created this revision.Sep 1 2021, 7:23 AM
Herald added subscribers: foad, kerbowa, hiraditya and 2 others. · View Herald TranscriptSep 1 2021, 7:23 AM
hsmhsm requested review of this revision.Sep 1 2021, 7:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 7:23 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B122078: Diff 369920.Sep 1 2021, 7:24 AM
JonChesterfield added a comment.EditedSep 1 2021, 7:30 AM

Do we have reason to believe that it won't break openmp this time around?

hsmhsm added a comment.EditedSep 1 2021, 7:43 AM
In D109062#2976792, @JonChesterfield wrote:

Do we have reason to believe that it won't break openmp this time around?

JonChesterfield accepted this revision.Sep 1 2021, 8:19 AM

Let's try it. There's a buildbot at https://lab.llvm.org/staging/#/builders/183 which is green, we can revert this if that fails.

It would be useful for the llvm-13 release branch for D108971 to be a fix as that will cherry pick cleanly and the revert that this reverts does not.

This revision is now accepted and ready to land.Sep 1 2021, 8:19 AM
This revision was landed with ongoing or failed builds.Sep 1 2021, 8:50 AM
Closed by commit rG5ae6804d179e: Revert "Disable ReplaceLDS pass, patch up tests to match" (authored by hsmhsm). · Explain Why
This revision was automatically updated to reflect the committed changes.
hsmhsm added a commit: rG5ae6804d179e: Revert "Disable ReplaceLDS pass, patch up tests to match".
JonChesterfield mentioned this in D108971: [AMDGPU] Split entry basic block after alloca instructions..Sep 1 2021, 8:53 AM
hsmhsm added a reverting change: rG97688bfd3d06: Revert "Revert "Disable ReplaceLDS pass, patch up tests to match"".Sep 1 2021, 9:23 AM
JonChesterfield added a comment.Sep 9 2021, 1:48 AM

@hsmhsm this pass is currently live on the 13 release branch (disabling it missed the cutoff by ~ a day). If you have capacity to write a patch disabling it that applies to llvm-13 and post it to https://bugs.llvm.org/show_bug.cgi?id=51562 please do so.

hsmhsm added a comment.EditedSep 9 2021, 2:46 AM
In D109062#2991115, @JonChesterfield wrote:

@hsmhsm this pass is currently live on the 13 release branch (disabling it missed the cutoff by ~ a day). If you have capacity to write a patch disabling it that applies to llvm-13 and post it to https://bugs.llvm.org/show_bug.cgi?id=51562 please do so.

As I confirmed you offline , this patch is not live on the 13 release branch.

hsmhsm mentioned this in D109594: [AMDGPU] Initialize LDS pointers after alloca, but before call..Sep 13 2021, 8:28 PM

Revision Contents

Diff 369945

llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

Show First 20 Lines • Show All 287 Lines • ▼ Show 20 Lines
static cl::opt<bool> EnableStructurizerWorkarounds( static cl::opt<bool> EnableStructurizerWorkarounds(
"amdgpu-enable-structurizer-workarounds", "amdgpu-enable-structurizer-workarounds",
cl::desc("Enable workarounds for the StructurizeCFG pass"), cl::init(true), cl::desc("Enable workarounds for the StructurizeCFG pass"), cl::init(true),
cl::Hidden); cl::Hidden);
static cl::opt<bool> EnableLDSReplaceWithPointer( static cl::opt<bool> EnableLDSReplaceWithPointer(
"amdgpu-enable-lds-replace-with-pointer", "amdgpu-enable-lds-replace-with-pointer",
cl::desc("Enable LDS replace with pointer pass"), cl::init(false), cl::desc("Enable LDS replace with pointer pass"), cl::init(true),
cl::Hidden); cl::Hidden);
static cl::opt<bool, true> EnableLowerModuleLDS( static cl::opt<bool, true> EnableLowerModuleLDS(
"amdgpu-enable-lower-module-lds", cl::desc("Enable lower module lds pass"), "amdgpu-enable-lower-module-lds", cl::desc("Enable lower module lds pass"),
cl::location(AMDGPUTargetMachine::EnableLowerModuleLDS), cl::init(true), cl::location(AMDGPUTargetMachine::EnableLowerModuleLDS), cl::init(true),
cl::Hidden); cl::Hidden);
static cl::opt<bool> EnablePreRAOptimizations( static cl::opt<bool> EnablePreRAOptimizations(
▲ Show 20 Lines • Show All 1,178 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/llc-pipeline.ll

Show All 36 Lines
; GCN-O0-NEXT: Early propagate attributes from kernels to functions ; GCN-O0-NEXT: Early propagate attributes from kernels to functions
; GCN-O0-NEXT: AMDGPU Lower Intrinsics ; GCN-O0-NEXT: AMDGPU Lower Intrinsics
; GCN-O0-NEXT: AMDGPU Inline All Functions ; GCN-O0-NEXT: AMDGPU Inline All Functions
; GCN-O0-NEXT: CallGraph Construction ; GCN-O0-NEXT: CallGraph Construction
; GCN-O0-NEXT: Call Graph SCC Pass Manager ; GCN-O0-NEXT: Call Graph SCC Pass Manager
; GCN-O0-NEXT: Inliner for always_inline functions ; GCN-O0-NEXT: Inliner for always_inline functions
; GCN-O0-NEXT: A No-Op Barrier Pass ; GCN-O0-NEXT: A No-Op Barrier Pass
; GCN-O0-NEXT: Lower OpenCL enqueued blocks ; GCN-O0-NEXT: Lower OpenCL enqueued blocks
; GCN-O0-NEXT: Replace within non-kernel function use of LDS with pointer
; GCN-O0-NEXT: Lower uses of LDS variables from non-kernel functions ; GCN-O0-NEXT: Lower uses of LDS variables from non-kernel functions
; GCN-O0-NEXT: FunctionPass Manager ; GCN-O0-NEXT: FunctionPass Manager
; GCN-O0-NEXT: Expand Atomic instructions ; GCN-O0-NEXT: Expand Atomic instructions
; GCN-O0-NEXT: Lower constant intrinsics ; GCN-O0-NEXT: Lower constant intrinsics
; GCN-O0-NEXT: Remove unreachable blocks from the CFG ; GCN-O0-NEXT: Remove unreachable blocks from the CFG
; GCN-O0-NEXT: Expand vector predication intrinsics ; GCN-O0-NEXT: Expand vector predication intrinsics
; GCN-O0-NEXT: Scalarize Masked Memory Intrinsics ; GCN-O0-NEXT: Scalarize Masked Memory Intrinsics
; GCN-O0-NEXT: Expand reduction intrinsics ; GCN-O0-NEXT: Expand reduction intrinsics
▲ Show 20 Lines • Show All 119 Lines • ▼ Show 20 Lines
; GCN-O1-NEXT: Early propagate attributes from kernels to functions ; GCN-O1-NEXT: Early propagate attributes from kernels to functions
; GCN-O1-NEXT: AMDGPU Lower Intrinsics ; GCN-O1-NEXT: AMDGPU Lower Intrinsics
; GCN-O1-NEXT: AMDGPU Inline All Functions ; GCN-O1-NEXT: AMDGPU Inline All Functions
; GCN-O1-NEXT: CallGraph Construction ; GCN-O1-NEXT: CallGraph Construction
; GCN-O1-NEXT: Call Graph SCC Pass Manager ; GCN-O1-NEXT: Call Graph SCC Pass Manager
; GCN-O1-NEXT: Inliner for always_inline functions ; GCN-O1-NEXT: Inliner for always_inline functions
; GCN-O1-NEXT: A No-Op Barrier Pass ; GCN-O1-NEXT: A No-Op Barrier Pass
; GCN-O1-NEXT: Lower OpenCL enqueued blocks ; GCN-O1-NEXT: Lower OpenCL enqueued blocks
; GCN-O1-NEXT: Replace within non-kernel function use of LDS with pointer
; GCN-O1-NEXT: Lower uses of LDS variables from non-kernel functions ; GCN-O1-NEXT: Lower uses of LDS variables from non-kernel functions
; GCN-O1-NEXT: FunctionPass Manager ; GCN-O1-NEXT: FunctionPass Manager
; GCN-O1-NEXT: Infer address spaces ; GCN-O1-NEXT: Infer address spaces
; GCN-O1-NEXT: Expand Atomic instructions ; GCN-O1-NEXT: Expand Atomic instructions
; GCN-O1-NEXT: AMDGPU Promote Alloca ; GCN-O1-NEXT: AMDGPU Promote Alloca
; GCN-O1-NEXT: Dominator Tree Construction ; GCN-O1-NEXT: Dominator Tree Construction
; GCN-O1-NEXT: SROA ; GCN-O1-NEXT: SROA
; GCN-O1-NEXT: Post-Dominator Tree Construction ; GCN-O1-NEXT: Post-Dominator Tree Construction
▲ Show 20 Lines • Show All 235 Lines • ▼ Show 20 Lines
; GCN-O1-OPTS-NEXT: Early propagate attributes from kernels to functions ; GCN-O1-OPTS-NEXT: Early propagate attributes from kernels to functions
; GCN-O1-OPTS-NEXT: AMDGPU Lower Intrinsics ; GCN-O1-OPTS-NEXT: AMDGPU Lower Intrinsics
; GCN-O1-OPTS-NEXT: AMDGPU Inline All Functions ; GCN-O1-OPTS-NEXT: AMDGPU Inline All Functions
; GCN-O1-OPTS-NEXT: CallGraph Construction ; GCN-O1-OPTS-NEXT: CallGraph Construction
; GCN-O1-OPTS-NEXT: Call Graph SCC Pass Manager ; GCN-O1-OPTS-NEXT: Call Graph SCC Pass Manager
; GCN-O1-OPTS-NEXT: Inliner for always_inline functions ; GCN-O1-OPTS-NEXT: Inliner for always_inline functions
; GCN-O1-OPTS-NEXT: A No-Op Barrier Pass ; GCN-O1-OPTS-NEXT: A No-Op Barrier Pass
; GCN-O1-OPTS-NEXT: Lower OpenCL enqueued blocks ; GCN-O1-OPTS-NEXT: Lower OpenCL enqueued blocks
; GCN-O1-OPTS-NEXT: Replace within non-kernel function use of LDS with pointer
; GCN-O1-OPTS-NEXT: Lower uses of LDS variables from non-kernel functions ; GCN-O1-OPTS-NEXT: Lower uses of LDS variables from non-kernel functions
; GCN-O1-OPTS-NEXT: FunctionPass Manager ; GCN-O1-OPTS-NEXT: FunctionPass Manager
; GCN-O1-OPTS-NEXT: Infer address spaces ; GCN-O1-OPTS-NEXT: Infer address spaces
; GCN-O1-OPTS-NEXT: Expand Atomic instructions ; GCN-O1-OPTS-NEXT: Expand Atomic instructions
; GCN-O1-OPTS-NEXT: AMDGPU Promote Alloca ; GCN-O1-OPTS-NEXT: AMDGPU Promote Alloca
; GCN-O1-OPTS-NEXT: Dominator Tree Construction ; GCN-O1-OPTS-NEXT: Dominator Tree Construction
; GCN-O1-OPTS-NEXT: SROA ; GCN-O1-OPTS-NEXT: SROA
; GCN-O1-OPTS-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O1-OPTS-NEXT: Basic Alias Analysis (stateless AA impl)
▲ Show 20 Lines • Show All 268 Lines • ▼ Show 20 Lines
; GCN-O2-NEXT: Early propagate attributes from kernels to functions ; GCN-O2-NEXT: Early propagate attributes from kernels to functions
; GCN-O2-NEXT: AMDGPU Lower Intrinsics ; GCN-O2-NEXT: AMDGPU Lower Intrinsics
; GCN-O2-NEXT: AMDGPU Inline All Functions ; GCN-O2-NEXT: AMDGPU Inline All Functions
; GCN-O2-NEXT: CallGraph Construction ; GCN-O2-NEXT: CallGraph Construction
; GCN-O2-NEXT: Call Graph SCC Pass Manager ; GCN-O2-NEXT: Call Graph SCC Pass Manager
; GCN-O2-NEXT: Inliner for always_inline functions ; GCN-O2-NEXT: Inliner for always_inline functions
; GCN-O2-NEXT: A No-Op Barrier Pass ; GCN-O2-NEXT: A No-Op Barrier Pass
; GCN-O2-NEXT: Lower OpenCL enqueued blocks ; GCN-O2-NEXT: Lower OpenCL enqueued blocks
; GCN-O2-NEXT: Replace within non-kernel function use of LDS with pointer
; GCN-O2-NEXT: Lower uses of LDS variables from non-kernel functions ; GCN-O2-NEXT: Lower uses of LDS variables from non-kernel functions
; GCN-O2-NEXT: FunctionPass Manager ; GCN-O2-NEXT: FunctionPass Manager
; GCN-O2-NEXT: Infer address spaces ; GCN-O2-NEXT: Infer address spaces
; GCN-O2-NEXT: Expand Atomic instructions ; GCN-O2-NEXT: Expand Atomic instructions
; GCN-O2-NEXT: AMDGPU Promote Alloca ; GCN-O2-NEXT: AMDGPU Promote Alloca
; GCN-O2-NEXT: Dominator Tree Construction ; GCN-O2-NEXT: Dominator Tree Construction
; GCN-O2-NEXT: SROA ; GCN-O2-NEXT: SROA
; GCN-O2-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O2-NEXT: Basic Alias Analysis (stateless AA impl)
▲ Show 20 Lines • Show All 270 Lines • ▼ Show 20 Lines
; GCN-O3-NEXT: Early propagate attributes from kernels to functions ; GCN-O3-NEXT: Early propagate attributes from kernels to functions
; GCN-O3-NEXT: AMDGPU Lower Intrinsics ; GCN-O3-NEXT: AMDGPU Lower Intrinsics
; GCN-O3-NEXT: AMDGPU Inline All Functions ; GCN-O3-NEXT: AMDGPU Inline All Functions
; GCN-O3-NEXT: CallGraph Construction ; GCN-O3-NEXT: CallGraph Construction
; GCN-O3-NEXT: Call Graph SCC Pass Manager ; GCN-O3-NEXT: Call Graph SCC Pass Manager
; GCN-O3-NEXT: Inliner for always_inline functions ; GCN-O3-NEXT: Inliner for always_inline functions
; GCN-O3-NEXT: A No-Op Barrier Pass ; GCN-O3-NEXT: A No-Op Barrier Pass
; GCN-O3-NEXT: Lower OpenCL enqueued blocks ; GCN-O3-NEXT: Lower OpenCL enqueued blocks
; GCN-O3-NEXT: Replace within non-kernel function use of LDS with pointer
; GCN-O3-NEXT: Lower uses of LDS variables from non-kernel functions ; GCN-O3-NEXT: Lower uses of LDS variables from non-kernel functions
; GCN-O3-NEXT: FunctionPass Manager ; GCN-O3-NEXT: FunctionPass Manager
; GCN-O3-NEXT: Infer address spaces ; GCN-O3-NEXT: Infer address spaces
; GCN-O3-NEXT: Expand Atomic instructions ; GCN-O3-NEXT: Expand Atomic instructions
; GCN-O3-NEXT: AMDGPU Promote Alloca ; GCN-O3-NEXT: AMDGPU Promote Alloca
; GCN-O3-NEXT: Dominator Tree Construction ; GCN-O3-NEXT: Dominator Tree Construction
; GCN-O3-NEXT: SROA ; GCN-O3-NEXT: SROA
; GCN-O3-NEXT: Basic Alias Analysis (stateless AA impl) ; GCN-O3-NEXT: Basic Alias Analysis (stateless AA impl)
▲ Show 20 Lines • Show All 264 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-diamond-shape.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; The lds global @lds_used_within_func is used within non-kernel function @func_uses_lds ; The lds global @lds_used_within_func is used within non-kernel function @func_uses_lds
; which is recheable from kernel @kernel_reaches_lds, hence pointer replacement takes place ; which is recheable from kernel @kernel_reaches_lds, hence pointer replacement takes place
; for @lds_used_within_func. ; for @lds_used_within_func.
; ;
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-selected_functions.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There are three lds globals defined here, and these three lds are used respectively within ; There are three lds globals defined here, and these three lds are used respectively within
; three non-kernel functions. There are three kernels, which call two of the non-kernel functions. ; three non-kernel functions. There are three kernels, which call two of the non-kernel functions.
; Hence pointer replacement should take place for all three lds, and pointer initialization within ; Hence pointer replacement should take place for all three lds, and pointer initialization within
; kernel should selectively happen depending on which lds is reachable from the kernel. ; kernel should selectively happen depending on which lds is reachable from the kernel.
; ;
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-to-declare-only-func.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; The kernel 'kern' makes a call to declared only function `foo`, hence `foo` ; The kernel 'kern' makes a call to declared only function `foo`, hence `foo`
; is not considered as reachable callee, and is ignored. The function `goo` ; is not considered as reachable callee, and is ignored. The function `goo`
; which uses LDS is not called from kernel 'kern', hence it is also ignored. ; which uses LDS is not called from kernel 'kern', hence it is also ignored.
; ;
Show All 29 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-global-scope-use.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; None of lds are pointer-replaced since they are all used in global scope in one or the other way. ; None of lds are pointer-replaced since they are all used in global scope in one or the other way.
; ;
; CHECK: @lds = internal addrspace(3) global [4 x i32] undef, align 4 ; CHECK: @lds = internal addrspace(3) global [4 x i32] undef, align 4
; CHECK: @lds.1 = addrspace(3) global i16 undef, align 2 ; CHECK: @lds.1 = addrspace(3) global i16 undef, align 2
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-inline-asm-call.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; We do not know what to do with inline asm call, we ignore it, hence pointer replacement for ; We do not know what to do with inline asm call, we ignore it, hence pointer replacement for
; @used_only_within_func does not take place. ; @used_only_within_func does not take place.
; ;
; CHECK: @used_only_within_func = addrspace(3) global [4 x i32] undef, align 4 ; CHECK: @used_only_within_func = addrspace(3) global [4 x i32] undef, align 4
Show All 21 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-kernel-only-used-lds.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION ; ; DESCRIPTION ;
; ;
; LDS global @used_only_within_kern is used only within kernel @k0, hence pointer replacement ; LDS global @used_only_within_kern is used only within kernel @k0, hence pointer replacement
; does not take place for @used_only_within_kern. ; does not take place for @used_only_within_kern.
; ;
; CHECK: @used_only_within_kern = addrspace(3) global [4 x i32] undef, align 4 ; CHECK: @used_only_within_kern = addrspace(3) global [4 x i32] undef, align 4
Show All 16 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-not-reachable-lds.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION ; ; DESCRIPTION ;
; ;
; LDS global @not-reachable-lds is used within non-kernel function @f0, but @f0 is *not* ; LDS global @not-reachable-lds is used within non-kernel function @f0, but @f0 is *not*
; reachable from kernel @k, hence pointer replacement does not take place. ; reachable from kernel @k, hence pointer replacement does not take place.
; ;
; CHECK: @not-reachable-lds = internal addrspace(3) global [4 x i32] undef, align 4 ; CHECK: @not-reachable-lds = internal addrspace(3) global [4 x i32] undef, align 4
Show All 19 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-small-lds.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION ; ; DESCRIPTION ;
; ;
; LDS global @small_lds is used within non-kernel function @f0, and @f0 is reachable ; LDS global @small_lds is used within non-kernel function @f0, and @f0 is reachable
; from kernel @k0, but since @small_lds too small for pointer replacement, pointer ; from kernel @k0, but since @small_lds too small for pointer replacement, pointer
; replacement does not take place. ; replacement does not take place.
; ;
Show All 22 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-diamond-shape.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; The lds global @lds_used_within_func is used within non-kernel function @func_uses_lds ; The lds global @lds_used_within_func is used within non-kernel function @func_uses_lds
; which is *indirectly* recheable from kernel @kernel_reaches_lds, hence pointer replacement ; which is *indirectly* recheable from kernel @kernel_reaches_lds, hence pointer replacement
; takes place for @lds_used_within_func. ; takes place for @lds_used_within_func.
; Original LDS should exit. ; Original LDS should exit.
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-selected_functions.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There are three lds globals defined here, and these three lds are used respectively within ; There are three lds globals defined here, and these three lds are used respectively within
; three non-kernel functions. There are three kernels, which *indirectly* call two of the ; three non-kernel functions. There are three kernels, which *indirectly* call two of the
; non-kernel functions. Hence pointer replacement should take place for all three lds, and ; non-kernel functions. Hence pointer replacement should take place for all three lds, and
; pointer initialization within kernel should selectively happen depending on which lds is ; pointer initialization within kernel should selectively happen depending on which lds is
; reachable from the kernel. ; reachable from the kernel.
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-signature-match.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There are three lds globals defined here, and these three lds are used respectively within ; There are three lds globals defined here, and these three lds are used respectively within
; three non-kernel functions. There is one kernel which *indirectly* calls one of the non-kernel ; three non-kernel functions. There is one kernel which *indirectly* calls one of the non-kernel
; functions. But since all the three non-kernel functions have same signature, all three ; functions. But since all the three non-kernel functions have same signature, all three
; non-kernel functions are resolved as potential callees for indirect call-site. Hence we land-up ; non-kernel functions are resolved as potential callees for indirect call-site. Hence we land-up
; pointer replacement for three lds globals. ; pointer replacement for three lds globals.
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-split-entry-bb-after-alloca.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There is one lds global defined here, and this lds is used within a single non-kernel ; There is one lds global defined here, and this lds is used within a single non-kernel
; function, as an operand of nested constant expression, and this non-kernel function is ; function, as an operand of nested constant expression, and this non-kernel function is
; reachable from kernel. Hence nested constant expression should to be converted into a ; reachable from kernel. Hence nested constant expression should to be converted into a
; series of instructons and pointer replacement should take place. ; series of instructons and pointer replacement should take place.
; ;
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-multiple-lds.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There are three lds globals defined here, and these three lds are used within a single ; There are three lds globals defined here, and these three lds are used within a single
; non-kernel function, and this non-kernel function is reachable from kernel. Hence pointer ; non-kernel function, and this non-kernel function is reachable from kernel. Hence pointer
; replacement is required for all three lds globals. ; replacement is required for all three lds globals.
; ;
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-same-lds.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There is one lds global defined here, and this lds is used within a single non-kernel ; There is one lds global defined here, and this lds is used within a single non-kernel
; function multiple times, and this non-kernel function is reachable from kernel. Hence ; function multiple times, and this non-kernel function is reachable from kernel. Hence
; pointer takes place. But important note is - store-to/load-from pointer should happen ; pointer takes place. But important note is - store-to/load-from pointer should happen
; only once irrespective of number of uses. ; only once irrespective of number of uses.
; ;
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr1.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; There is one lds global defined here, and this lds is used within a single non-kernel ; There is one lds global defined here, and this lds is used within a single non-kernel
; function, as an operand of nested constant expression, and this non-kernel function is ; function, as an operand of nested constant expression, and this non-kernel function is
; reachable from kernel. Hence nested constant expression should to be converted into a ; reachable from kernel. Hence nested constant expression should to be converted into a
; series of instructons and pointer replacement should take place. ; series of instructons and pointer replacement should take place.
; ;
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr2.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; There is one lds global defined here, and this lds is used within a single non-kernel ; There is one lds global defined here, and this lds is used within a single non-kernel
; function, as an operand of nested constant expression, and this non-kernel function is ; function, as an operand of nested constant expression, and this non-kernel function is
; reachable from kernel. Hence nested constant expression should to be converted into a ; reachable from kernel. Hence nested constant expression should to be converted into a
; series of instructons and pointer replacement should take place. But, important note ; series of instructons and pointer replacement should take place. But, important note
; is - only constant expression operands which uses lds should be converted into ; is - only constant expression operands which uses lds should be converted into
; instructions, other constant expression operands which do not use lds should be left ; instructions, other constant expression operands which do not use lds should be left
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines

llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-phi-inst.ll

; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer -amdgpu-enable-lds-replace-with-pointer=true < %s | FileCheck %s ; RUN: opt -S -mtriple=amdgcn-- -amdgpu-replace-lds-use-with-pointer < %s | FileCheck %s
; DESCRIPTION: ; DESCRIPTION:
; ;
; Replace lds globals used within phi instruction. ; Replace lds globals used within phi instruction.
; ;
; Original LDS should exist. ; Original LDS should exist.
; CHECK: @lds.1 = addrspace(3) global i32 undef, align 4 ; CHECK: @lds.1 = addrspace(3) global i32 undef, align 4
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines