Page MenuHomePhabricator

Disable ReplaceLDS pass, patch up tests to match
ClosedPublic

Authored by JonChesterfield on Jun 25 2021, 5:22 PM.

Details

Summary

Most tests passed with an extra argument to explicitly enable the pass.
One does not, deleted it as part of this change. I can't see why the codegen
would be different between default on and default off but switched on. It
can be retrieved from the project history.

This would be a revert, but git revert was not clean. Disabling the pass
and leaving it in tree is less likely to cause breakage elsewhere than
patching up the git revert conflicts on unfamiliar code. It'll be landed
without review, as @hsmhsm is believed unavailable at present.

Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Jun 25 2021, 5:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2021, 5:22 PM
JonChesterfield edited the summary of this revision. (Show Details)Jun 25 2021, 5:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2021, 5:36 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.