Page MenuHomePhabricator

Revert "Disable ReplaceLDS pass, patch up tests to match"
ClosedPublic

Authored by hsmhsm on Sep 1 2021, 7:23 AM.

Diff Detail

Event Timeline

hsmhsm created this revision.Sep 1 2021, 7:23 AM
hsmhsm requested review of this revision.Sep 1 2021, 7:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 7:23 AM
JonChesterfield added a comment.EditedSep 1 2021, 7:30 AM

Do we have reason to believe that it won't break openmp this time around?

hsmhsm added a comment.EditedSep 1 2021, 7:43 AM

Do we have reason to believe that it won't break openmp this time around?

JonChesterfield accepted this revision.Sep 1 2021, 8:19 AM

Let's try it. There's a buildbot at https://lab.llvm.org/staging/#/builders/183 which is green, we can revert this if that fails.

It would be useful for the llvm-13 release branch for D108971 to be a fix as that will cherry pick cleanly and the revert that this reverts does not.

This revision is now accepted and ready to land.Sep 1 2021, 8:19 AM
This revision was landed with ongoing or failed builds.Sep 1 2021, 8:50 AM
This revision was automatically updated to reflect the committed changes.

@hsmhsm this pass is currently live on the 13 release branch (disabling it missed the cutoff by ~ a day). If you have capacity to write a patch disabling it that applies to llvm-13 and post it to https://bugs.llvm.org/show_bug.cgi?id=51562 please do so.

hsmhsm added a comment.EditedSep 9 2021, 2:46 AM

@hsmhsm this pass is currently live on the 13 release branch (disabling it missed the cutoff by ~ a day). If you have capacity to write a patch disabling it that applies to llvm-13 and post it to https://bugs.llvm.org/show_bug.cgi?id=51562 please do so.

As I confirmed you offline , this patch is not live on the 13 release branch.