Page MenuHomePhabricator

[LV] Fix crash for reverse masked interleaved groups
ClosedPublic

Authored by Ayal on Aug 29 2021, 3:38 PM.

Details

Summary

This patch fixes another crash revealed by PR51614, following D108891:
when *deciding* to vectorize with masked interleave groups, check if the access
is reverse - which is currently not supported; rather than (only) asserting it is so
when computing cost and generating code.

Diff Detail

Event Timeline

Ayal created this revision.Aug 29 2021, 3:38 PM
Ayal requested review of this revision.Aug 29 2021, 3:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2021, 3:38 PM
bjope added a subscriber: bjope.Sep 13 2021, 12:44 AM
fhahn added a comment.Sep 13 2021, 3:53 AM

(Currently includes D108891; the two can be committed separately or together.)

Could you rebase the patch once D108891 landed?

Ayal updated this revision to Diff 373988.Tue, Sep 21, 10:58 AM
Ayal edited the summary of this revision. (Show Details)

rebased after pushing D108891

fhahn accepted this revision.Tue, Oct 12, 3:11 AM

LGTM, thanks!

This revision is now accepted and ready to land.Tue, Oct 12, 3:11 AM
Ayal updated this revision to Diff 379127.EditedTue, Oct 12, 11:42 AM

Updated test to ignore the runtime checks in the entry block, as these have changed since previous upload of patch, and are immaterial to the patch itself. Plus rebase.

This revision was landed with ongoing or failed builds.Tue, Oct 12, 12:15 PM
This revision was automatically updated to reflect the committed changes.