This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add test showing the current extern_weak lowering
ClosedPublic

Authored by jrtc27 on Aug 2 2021, 7:44 AM.

Diff Detail

Event Timeline

jrtc27 created this revision.Aug 2 2021, 7:44 AM
jrtc27 requested review of this revision.Aug 2 2021, 7:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 7:44 AM
MaskRay accepted this revision.Aug 2 2021, 9:31 AM

LGTM.

This revision is now accepted and ready to land.Aug 2 2021, 9:31 AM
MaskRay accepted this revision.May 15 2023, 9:01 PM
MaskRay added inline comments.
llvm/test/CodeGen/RISCV/codemodel-lowering.ll
167
jrtc27 updated this revision to Diff 522423.May 15 2023, 9:06 PM

Switch to opaque pointer in test

jrtc27 marked an inline comment as done.May 15 2023, 9:07 PM
jrtc27 added inline comments.
llvm/test/CodeGen/RISCV/codemodel-lowering.ll
167

Huh, surprised that doesn't hit an error in the IR parser

MaskRay accepted this revision.May 15 2023, 10:10 PM

Thanks!

asb accepted this revision.May 16 2023, 6:03 AM

LGTM.

evandro removed a subscriber: evandro.May 17 2023, 3:55 PM
This revision was landed with ongoing or failed builds.May 31 2023, 10:48 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 marked an inline comment as done.