Page MenuHomePhabricator

[VPlan] Use vector version of GEP if result is used as vector.
Needs ReviewPublic

Authored by fhahn on Jul 11 2021, 12:29 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Event Timeline

fhahn created this revision.Jul 11 2021, 12:29 PM
fhahn requested review of this revision.Jul 11 2021, 12:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2021, 12:29 PM

Hi @fhahn, at first glance this change makes sense to me. Do you plan to run with this yourself or are you happy for me to push this solution further? The reason I ask is because we're hoping to get this important fix in as soon as possible for LNT. It looks with your change we may need a few explicit negative tests too to cover some of the logic in IsUsedAsVector. I also still have to fix the other remaining cases in D105199.

fhahn added a comment.Jul 12 2021, 1:38 PM

Hi @fhahn, at first glance this change makes sense to me. Do you plan to run with this yourself or are you happy for me to push this solution further? The reason I ask is because we're hoping to get this important fix in as soon as possible for LNT. It looks with your change we may need a few explicit negative tests too to cover some of the logic in IsUsedAsVector. I also still have to fix the other remaining cases in D105199.

I plan to wrap up the patch tomorrow and also handle the other cases. If there is an issue blocking your LNT, it might be good to revert the commit that exposed/enabled the code that is causing the issue until it is resolved.