This is an archive of the discontinued LLVM Phabricator instance.

Differential D105566

[AArch64][SME] Support .arch and .arch_extension assembler directives
ClosedPublic

Authored by c-rhodes on Jul 7 2021, 11:09 AM.

Details

Reviewers
sdesmalen
david-arm
kmclaughlin
CarolineConcatto
Commits
rG008c755d76c9: [AArch64][SME] Support .arch and .arch_extension assembler directives

Diff Detail

Event Timeline

c-rhodes created this revision.Jul 7 2021, 11:09 AM
Herald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald TranscriptJul 7 2021, 11:09 AM
c-rhodes requested review of this revision.Jul 7 2021, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 11:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B112818: Diff 357005.Jul 7 2021, 11:15 AM
c-rhodes added a parent revision: D105577: [AArch64][SME] Add SVE2 instructions added in SME.Jul 7 2021, 11:41 AM
Matt added a subscriber: Matt.Jul 7 2021, 3:01 PM
tschuett added a subscriber: tschuett.Jul 7 2021, 11:59 PM
c-rhodes updated this revision to Diff 358961.Jul 15 2021, 7:43 AM
c-rhodes added reviewers: sdesmalen, david-arm, kmclaughlin, CarolineConcatto.

Add support for f64/i64 features.

c-rhodes edited parent revisions, added: D105576: [AArch64][SME] Add system registers and related instructions; removed: D105577: [AArch64][SME] Add SVE2 instructions added in SME.Jul 15 2021, 7:43 AM
Harbormaster completed remote builds in B114234: Diff 358961.Jul 15 2021, 7:44 AM
david-arm accepted this revision.Jul 16 2021, 7:03 AM

LGTM!

This revision is now accepted and ready to land.Jul 16 2021, 7:03 AM
This revision was landed with ongoing or failed builds.Jul 21 2021, 1:40 AM
Closed by commit rG008c755d76c9: [AArch64][SME] Support .arch and .arch_extension assembler directives (authored by c-rhodes). · Explain Why
This revision was automatically updated to reflect the committed changes.
c-rhodes added a commit: rG008c755d76c9: [AArch64][SME] Support .arch and .arch_extension assembler directives.

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
AsmParser/
3 lines
test/
MC/
AArch64/
SME/
37 lines
35 lines

Diff 360382

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Show First 20 Lines • Show All 3,205 Lines • ▼ Show 20 Lines const FeatureBitset Features;
{"sve2-sm4", {AArch64::FeatureSVE2SM4}}, {"sve2-sm4", {AArch64::FeatureSVE2SM4}},
{"sve2-sha3", {AArch64::FeatureSVE2SHA3}}, {"sve2-sha3", {AArch64::FeatureSVE2SHA3}},
{"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}}, {"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}},
{"ls64", {AArch64::FeatureLS64}}, {"ls64", {AArch64::FeatureLS64}},
{"xs", {AArch64::FeatureXS}}, {"xs", {AArch64::FeatureXS}},
{"pauth", {AArch64::FeaturePAuth}}, {"pauth", {AArch64::FeaturePAuth}},
{"flagm", {AArch64::FeatureFlagM}}, {"flagm", {AArch64::FeatureFlagM}},
{"rme", {AArch64::FeatureRME}}, {"rme", {AArch64::FeatureRME}},
{"sme", {AArch64::FeatureSME}},
{"sme-f64", {AArch64::FeatureSMEF64}},
{"sme-i64", {AArch64::FeatureSMEI64}},
// FIXME: Unsupported extensions // FIXME: Unsupported extensions
{"lor", {}}, {"lor", {}},
{"rdma", {}}, {"rdma", {}},
{"profile", {}}, {"profile", {}},
}; };
static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) { static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) {
if (FBS[AArch64::HasV8_1aOps]) if (FBS[AArch64::HasV8_1aOps])
▲ Show 20 Lines • Show All 3,509 Lines • Show Last 20 Lines

llvm/test/MC/AArch64/SME/directives-negative.s

  • This file was added.
// RUN: not llvm-mc -triple aarch64 -o - %s 2>&1 | FileCheck %s
.arch_extension sme
.arch_extension nosme
smstart
// CHECK: error: instruction requires: sme
// CHECK-NEXT: smstart
.arch_extension sme-f64
.arch_extension nosme-f64
fmopa za0.d, p0/m, p0/m, z0.d, z0.d
// CHECK: error: instruction requires: sme-f64
// CHECK-NEXT: fmopa za0.d, p0/m, p0/m, z0.d, z0.d
.arch_extension sme-i64
.arch_extension nosme-i64
addha za0.d, p0/m, p0/m, z0.d
// CHECK: error: instruction requires: sme-i64
// CHECK-NEXT: addha za0.d, p0/m, p0/m, z0.d
.arch armv8-a+sme
.arch armv8-a+nosme
smstart
// CHECK: error: instruction requires: sme
// CHECK-NEXT: smstart
.arch armv8-a+sme-f64
.arch armv8-a+nosme-f64
fmopa za0.d, p0/m, p0/m, z0.d, z0.d
// CHECK: error: instruction requires: sme-f64
// CHECK-NEXT: fmopa za0.d, p0/m, p0/m, z0.d, z0.d
.arch armv8-a+sme-i64
.arch armv8-a+nosme-i64
addha za0.d, p0/m, p0/m, z0.d
// CHECK: error: instruction requires: sme-i64
// CHECK-NEXT: addha za0.d, p0/m, p0/m, z0.d

llvm/test/MC/AArch64/SME/directives.s

  • This file was added.
// RUN: llvm-mc -triple aarch64 -o - %s 2>&1 | FileCheck %s
.arch_extension sme
smstart
// CHECK: smstart
.arch_extension nosme
.arch_extension sme-f64
fmopa za0.d, p0/m, p0/m, z0.d, z0.d
// CHECK: fmopa za0.d, p0/m, p0/m, z0.d, z0.d
.arch_extension nosme-f64
.arch_extension sme-i64
addha za0.d, p0/m, p0/m, z0.d
// CHECK: addha za0.d, p0/m, p0/m, z0.d
.arch_extension nosme-i64
.arch armv8-a+sme
smstart
// CHECK: smstart
.arch armv8-a+nosme
.arch armv8-a+sme-f64
fmopa za0.d, p0/m, p0/m, z0.d, z0.d
// CHECK: fmopa za0.d, p0/m, p0/m, z0.d, z0.d
.arch armv8-a+nosme-f64
.arch armv8-a+sme-i64
addha za0.d, p0/m, p0/m, z0.d
// CHECK: addha za0.d, p0/m, p0/m, z0.d