This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME] Add SVE2 instructions added in SME
ClosedPublic

Authored by c-rhodes on Jul 7 2021, 11:41 AM.

Details

Summary

This patch adds support for the following instructions:

SCLAMP, UCLAMP, REV, DUP (predicate)

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2021-06

Diff Detail

Event Timeline

c-rhodes created this revision.Jul 7 2021, 11:41 AM
c-rhodes requested review of this revision.Jul 7 2021, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 11:41 AM
Matt added a subscriber: Matt.Jul 7 2021, 3:02 PM
c-rhodes updated this revision to Diff 358958.Jul 15 2021, 7:41 AM

Update sed line in tests to fix Windows precommit.

kmclaughlin added inline comments.Jul 15 2021, 10:24 AM
llvm/test/MC/AArch64/SME/dup-diagnostics.s
38

Can you add some invalid predicate tests for the dup & revd instructions too, e.g. p8/z, p0/m?

llvm/test/MC/AArch64/SME/dup.s
122

Do we need tests with movprfx for the dup instruction also?

c-rhodes updated this revision to Diff 359290.Jul 16 2021, 5:17 AM

Address comments

c-rhodes marked an inline comment as done.Jul 16 2021, 5:19 AM
c-rhodes added inline comments.
llvm/test/MC/AArch64/SME/dup.s
122

Do we need tests with movprfx for the dup instruction also?

it's operating on predicates so it can't be prefixed with movprfx

kmclaughlin accepted this revision.Jul 16 2021, 5:55 AM

Thanks for adding the new tests, LGTM!

This revision is now accepted and ready to land.Jul 16 2021, 5:55 AM
This revision was landed with ongoing or failed builds.Jul 19 2021, 1:03 AM
This revision was automatically updated to reflect the committed changes.