Page MenuHomePhabricator

[RISCV] Use X0 as destination of inserted vsetvli when possible.
ClosedPublic

Authored by craig.topper on May 6 2021, 4:05 PM.

Details

Summary

We aren't going to connect the result to anything so we might
as well avoid allocating a register.

Diff Detail

Event Timeline

craig.topper created this revision.May 6 2021, 4:05 PM
craig.topper requested review of this revision.May 6 2021, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2021, 4:05 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
craig.topper edited the summary of this revision. (Show Details)May 6 2021, 4:06 PM
HsiangKai accepted this revision.May 6 2021, 5:22 PM

LGTM.

This revision is now accepted and ready to land.May 6 2021, 5:22 PM

To separate it from D101938, is it because the modification changes lots of test files?

To separate it from D101938, is it because the modification changes lots of test files?

Yes. I was trying to make the test changes from D101938 easy to see.

frasercrmck accepted this revision.May 7 2021, 4:38 AM

LGTM too. What a lot of changes.

Rebase on new insertion pass

jrtc27 added inline comments.Mon, May 24, 2:14 PM
llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
361

Use the existing AVLReg variable rather than repeating the call?

Address review comment.

This revision was landed with ongoing or failed builds.Wed, May 26, 1:10 PM
This revision was automatically updated to reflect the committed changes.