Serialize ScavengeFI from SIMachineFunctionInfo into yaml.
ScavengeFI is not used outside of the PrologEpilogInserter,
so this shouldn't change anything.
Paths
| Differential D101367
[AMDGPU] Serialize MFInfo::ScavengeFI ClosedPublic Authored by sebastian-ne on Apr 27 2021, 7:43 AM.
Details
Summary Serialize ScavengeFI from SIMachineFunctionInfo into yaml. ScavengeFI is not used outside of the PrologEpilogInserter,
Diff Detail
Event TimelineHerald added subscribers: kerbowa, hiraditya, t-tye and 6 others. · View Herald TranscriptApr 27 2021, 7:43 AM Comment Actions The point that this is only used in PEI is interesting. That almost suggests it doesn't belong here at all but I'm not sure where else you would track it.
sebastian-ne marked an inline comment as done. Comment Actions
Ah, I was already wondering why it felt so easy. sebastian-ne marked 2 inline comments as done. Comment ActionsAdd two tests to check invalid frame indices. arsenm added inline comments. This revision now requires changes to proceed.May 5 2021, 2:10 PM sebastian-ne marked 2 inline comments as done. Comment ActionsReturn error instead of failing assert for non-existing frame index. I’m not quite sure how to create the SMDiagnostic. The resulting error message looks fine, so I hope this is ok. This revision is now accepted and ready to land.May 6 2021, 11:27 AM Closed by commit rG98e5ede60499: [AMDGPU] Serialize MFInfo::ScavengeFI (authored by sebastian-ne). · Explain WhyMay 7 2021, 2:15 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 343617 llvm/include/llvm/CodeGen/MIRYamlMapping.h
llvm/lib/CodeGen/CMakeLists.txt
llvm/lib/CodeGen/MIRYamlMapping.cpp
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index-invalid-fixed-stack.mir
llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index-invalid-stack.mir
llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index-no-stack.mir
llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index.mir
llvm/test/CodeGen/MIR/AMDGPU/invalid-frame-index2.mir
llvm/test/CodeGen/MIR/AMDGPU/machine-function-info-after-pei.ll
llvm/test/CodeGen/MIR/AMDGPU/machine-function-info-no-ir.mir
|
This should emit a proper error, not just assert.