Page MenuHomePhabricator

[yaml2obj/obj2yaml/llvm-readobj] Support printing and parsing AVR-specific e_flags
ClosedPublic

Authored by LemonBoy on Apr 10 2021, 12:30 PM.

Details

Summary

The e_flags contains a mixture of bitfields and regular ones, ensure all of them can be serialized and deserialized.

Diff Detail

Event Timeline

LemonBoy created this revision.Apr 10 2021, 12:30 PM
LemonBoy requested review of this revision.Apr 10 2021, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2021, 12:30 PM
LemonBoy updated this revision to Diff 336649.Apr 11 2021, 2:43 AM

Fix one more test case.

MaskRay accepted this revision.Wed, Apr 14, 4:48 PM

LGTM.

llvm/test/tools/llvm-readobj/ELF/avr-elf-headers.test
2

Too many invocations can slow down testsuite execution.

When there is a long list of values, we usually just test one invocation or test on invocation with one group of flags.
See D98818. See section-arch-flags.test for another example.
You may consider grouping at least EF_AVR_ARCH_AVR* together.

This revision is now accepted and ready to land.Wed, Apr 14, 4:48 PM
LemonBoy updated this revision to Diff 337743.Thu, Apr 15, 6:50 AM

Reduce the number of invocations to reduce the test runtime.

This revision was landed with ongoing or failed builds.Thu, Apr 15, 6:54 AM
This revision was automatically updated to reflect the committed changes.