This is an archive of the discontinued LLVM Phabricator instance.

Differential D99285

[SystemZ][z/OS] csv files should be text files
ClosedPublic

Authored by abhina.sreeskantharajan on Mar 24 2021, 11:15 AM.

Details

Reviewers
rnk
amccarth
anirudhp
zibi
yusra.syeda
Commits
rGea61708c6d07: [SystemZ][z/OS] csv files should be text files
Summary

This patch sets the OF_Text flag correctly for the csv file.

Diff Detail

Event Timeline

abhina.sreeskantharajan requested review of this revision.Mar 24 2021, 11:15 AM
abhina.sreeskantharajan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 11:15 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B95541: Diff 333059.Mar 24 2021, 7:38 PM
abhina.sreeskantharajan added reviewers: rnk, amccarth, anirudhp, zibi, yusra.syeda.Mar 25 2021, 5:24 AM
anirudhp accepted this revision.Mar 25 2021, 6:04 AM
This revision is now accepted and ready to land.Mar 25 2021, 6:04 AM
Closed by commit rGea61708c6d07: [SystemZ][z/OS] csv files should be text files (authored by abhina.sreeskantharajan). · Explain WhyMar 25 2021, 6:19 AM
This revision was automatically updated to reflect the committed changes.
abhina.sreeskantharajan added a commit: rGea61708c6d07: [SystemZ][z/OS] csv files should be text files.

Revision Contents

PathSize
clang/
lib/
Driver/
3 lines

Diff 333281

clang/lib/Driver/Driver.cpp

Show First 20 Lines • Show All 4,075 Lines • ▼ Show 20 Lines C.setPostCallback([=](const Command &Cmd, int Res) {
Out << ','; Out << ',';
llvm::sys::printArg(Out, LinkingOutput, true); llvm::sys::printArg(Out, LinkingOutput, true);
Out << ',' << ProcStat->TotalTime.count() << ',' Out << ',' << ProcStat->TotalTime.count() << ','
<< ProcStat->UserTime.count() << ',' << ProcStat->PeakMemory << ProcStat->UserTime.count() << ',' << ProcStat->PeakMemory
<< '\n'; << '\n';
Out.flush(); Out.flush();
std::error_code EC; std::error_code EC;
llvm::raw_fd_ostream OS(CCPrintStatReportFilename, EC, llvm::raw_fd_ostream OS(CCPrintStatReportFilename, EC,
llvm::sys::fs::OF_Append); llvm::sys::fs::OF_Append |
llvm::sys::fs::OF_Text);
if (EC) if (EC)
return; return;
auto L = OS.lock(); auto L = OS.lock();
if (!L) { if (!L) {
llvm::errs() << "ERROR: Cannot lock file " llvm::errs() << "ERROR: Cannot lock file "
<< CCPrintStatReportFilename << ": " << CCPrintStatReportFilename << ": "
<< toString(L.takeError()) << "\n"; << toString(L.takeError()) << "\n";
return; return;
▲ Show 20 Lines • Show All 1,404 Lines • Show Last 20 Lines