User Details
- User Since
- Sep 14 2017, 10:33 AM (289 w, 10 h)
Feb 24 2023
Can I go ahead and land this revision or need to wait for libc++abi group approval?
This is a very small non-functional revision.
Feb 22 2023
Feb 13 2023
LGTM
Jan 17 2023
FYI, the failures reported are unrelated.
They are either timeouts or taking unexpectedly too long (assertion in std/thread/futures/futures.async/async.pass.cpp at line 102).
- Revert "[SystemZ][z/OS] Fix cityhash lit for EBCDIC"
Change to use an array of integers instead of strings.
Jan 16 2023
FYI, the failure ia the timeout on Apple, unrelated to this patch, so consider CI checks as green.
Jan 13 2023
- fix typo
- Fix cityhash lit for EBCDIC
- Switch to array of strings with hard coded values
Addressing comments ...
The above pre-merge checks failures are timeout and not related to this patch. Submitting again to get clean build status.
Jan 12 2023
Jan 9 2023
Jan 7 2023
Jan 5 2023
Dec 13 2022
- Revert 47b49b5f6d40 and 57b747c55d15
Dec 5 2022
- Keep _LIBCPP_EXCEPTION_ABI for classes in experimental namespace.
Nov 30 2022
- Move several exception derived classes to c++abi library
- Remove _LIBCPP_EXCEPTION_ABI from classes those symbols are moved to c++abi.
Nov 29 2022
@fanbo-meng Can you close this review?
I'm going to continue in D138951.
Nov 28 2022
- fix formatting
- trying to fix CI.
Moving several exception derived classes c++abi to address review comments.
Nov 15 2022
@EricWF Thank you for the review.
Nov 7 2022
- correct typo
Addressing comments...
- Remove _LIBCPP_BEGIN_NAMESPACE_EXCEPTION and _LIBCPP_END_NAMESPACE_EXCEPTION
ping
Oct 28 2022
ping @ldionne
LGTM,
ideally we should have macro for __thread which would define to nothing for z/OS.
LGTM
Oct 25 2022
Oct 21 2022
Louis, this has been reviewed by others including yourself and is waiting for your stamp of approval, @ldionne
Oct 14 2022
ping @ldionne
Oct 11 2022
LGTM
Thank you for all reviews which are not addressed.
@ldionne Can you have a look? I just need your stamp of approval.
Oct 7 2022
- consolidate multiple exceptions files into a single file
Oct 6 2022
- use system notation for #include directive
Oct 5 2022
- switch to use override in place of virtual
more formating
- formating changes and make set_target_properties for cxx_exception be consistent with cxx_shared
- config.py should not be part of this change
- Rebase and move recipe to build c++_exception to separate cmake.
Oct 3 2022
Fix CI - Documentation
Fix CI build.
Sep 29 2022
Ready for another round. FYI @ldionne
Add LIBCXXABI_ADDITIONAL_COMPILE_FLAGS and other changes requested by Louis.
ping @ldionne
Sep 23 2022
@ldionne I think I addressed all your comments.
Please review it.
Fix just one typo. @dionne I think I addressed all your comments. Please review it.
Sep 21 2022
Looks like my last commit was skipped. I'm adding it now.
- Add the following options to documentation:
- Make cxx_shared library common for EBCDIC and ASCII build variations.
- Use LIBCXX_CXX_ABI=system-libcxxabi to pick up abi headers and library from previous build.
Sep 20 2022
LGTM
Sep 16 2022
LGTM
Sep 15 2022
Putting rational why I opted out for LIBCXX_CXX_ABI=built-libcxxabi.
Sep 12 2022
- Make cxx_shared library common for EBCDIC and ASCII build variations.
- Introducing built-libcxxabi to pick up abi headers from previous build.
- Adding the following macros:
Sep 8 2022
answering comments and some questions
Sep 7 2022
Addressing Louis's comments to hide z/OS changes as much as possible in cache.
Aug 30 2022
LGTM
LGTM
Aug 17 2022
Louis, thank you for the review and providing some suggestions. However, I'm still not sure how to proceed see my inline comments.
Aug 3 2022
ping, still waiting for the review ...
Jul 22 2022
@ldionne Louis, all comments have been addressed CI is green, can you look at it again? Thx.
Jul 14 2022
LGTM, thank you.
Jul 13 2022
Rebase to pick up 0d7859765260e1dddfdc3490c1fe35537775bb41 which hopefully will fix CL.
Jul 12 2022
The CI is clean now, Can I have the approval or more request, Thx.
- Rebasing and resolving conflicts
No functional changes are introduced since the last patch.
Jul 11 2022
Looking good, I wonder if we can incorporating a small change to set PATH, see inline comment in ibm-zos-libc++-shared.cfg.in.
Apr 21 2022
Apr 20 2022
I'm seeing this error: