Page MenuHomePhabricator

zibi (Zibi Sarbino)
Operations

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2017, 10:33 AM (244 w, 4 d)

Recent Activity

Apr 21 2022

zibi added inline comments to D124039: [OpenMP] Add better testing for the linker wrapper.
Apr 21 2022, 5:17 AM · Restricted Project, Restricted Project

Apr 20 2022

zibi added a comment to D123241: Add -Wno-implicit-function-declaration to a few places to work w D122983.

Have you missed MultiSource/Benchmarks/Prolangs-C/bison/CMakeLists.txt to turn off the warning?

@erichkeane Erich, will you be able to provide the fix for this? Please let me know ETA so I can plan accordingly.

Apr 20 2022, 5:47 PM · Restricted Project
zibi added inline comments to D124039: [OpenMP] Add better testing for the linker wrapper.
Apr 20 2022, 2:55 PM · Restricted Project, Restricted Project
zibi added a comment to D123241: Add -Wno-implicit-function-declaration to a few places to work w D122983.

Have you missed MultiSource/Benchmarks/Prolangs-C/bison/CMakeLists.txt to turn off the warning?

Apr 20 2022, 2:28 PM · Restricted Project
zibi added a comment to D123241: Add -Wno-implicit-function-declaration to a few places to work w D122983.

I'm seeing this error:

Apr 20 2022, 1:57 PM · Restricted Project

Mar 28 2022

zibi added a comment to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

@ldionne Louis, this is one of the reviews I DM you about.

Mar 28 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

zibi added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 18 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

This revision reduced wrapper functions in internal_threading_support.h to just
__libcpp_mutex_lock_wrapper() and __libcpp_mutex_unlock_wrapper() with the new suffix.
This is a bare minimum needed for POSIX(OFF) on z/OS.

Mar 17 2022, 8:03 PM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

This revision updates __libcpp_execute_once() according to the comments.

Mar 16 2022, 10:42 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Fix a typo.

Mar 11 2022, 8:11 AM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

The __libcpp_is_threading_api_enabled() checks if threading is enabled (POSIX ON) or not (POSIX OFF) as its name clearly indicates. It cannot be changed throughout the
live of the application but it can be set at the start of the application via env. var. _CEE_RUNOPTS=POSIX(OFF).

Mar 11 2022, 8:10 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

zibi added inline comments to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Mar 10 2022, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

The side deck was created in ASCII mode which is not desired. This revision corrects that.

Mar 10 2022, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Rebase and undo changes for reverted commit 5aaefa51.

Mar 9 2022, 5:56 PM · Restricted Project, Restricted Project, Restricted Project
zibi added inline comments to D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.
Mar 9 2022, 7:58 AM · Restricted Project, Restricted Project
zibi accepted D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

LGTM

Mar 9 2022, 7:47 AM · Restricted Project, Restricted Project

Mar 8 2022

zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

This patch addresses the comments from Sean and Muiez. It reduces the original patch and makes it up-to-date.

Mar 8 2022, 2:17 PM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

Herald added a project to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS: Restricted Project.

waiting for the review...

Mar 7 2022, 10:14 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2022

zibi added a comment to D106124: [libcxx][modules] protects users from relying on detail headers.

I don't know of anything broken by this, i was just curious :)

Feb 27 2022, 3:20 PM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Attempt to fix Generated output in CI

Feb 26 2022, 9:57 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

formatting

Feb 26 2022, 9:31 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Move threading_support.h to libcxx/include to be together with __threading_support.

Feb 26 2022, 7:31 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Switched to new header <threading_support.h> introduced in https://reviews.llvm.org/D106124?id=411574.

Feb 26 2022, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

NFC to pick up the fix for std_format_spec_string_unicode.pass.cp and make CI clean.

Feb 26 2022, 11:41 AM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

rebase to fix CI

Feb 25 2022, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Trying to fix CI with static inline and addressing Daniel's comments.

Feb 25 2022, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

another attempt to fix CI

Feb 24 2022, 9:31 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Attempt to fix CI with _LIBCXXABI_HAS_NO_THREADS guard.

Feb 24 2022, 7:45 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Rebase to fix CI documentation error

Feb 23 2022, 5:02 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Formatting and fixing MAC/WIN/AIX builds.

Feb 23 2022, 2:30 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

zibi updated the diff for D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Change _VSTD to std and formatting changes to fix CI.

Feb 22 2022, 6:07 PM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.

Does this mean that D110349 and/or D117375 could be closed/abandoned at this point?

Feb 22 2022, 5:44 PM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.

LGTM with minor suggestions.

Feb 22 2022, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
zibi accepted D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

LGTM

Feb 22 2022, 4:47 PM · Restricted Project, Restricted Project
zibi added a comment to D117375: [libcxx][SystemZ][z/OS] added internal_threading_support.h.

Please see the new version in D120348.

Feb 22 2022, 12:39 PM · Restricted Project, Restricted Project
zibi added a comment to D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.

Please see the new version in D120348.

Feb 22 2022, 12:38 PM · Restricted Project, Restricted Project
zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Feb 22 2022, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the summary of D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Feb 22 2022, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
zibi requested review of D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS.
Feb 22 2022, 12:34 PM · Restricted Project, Restricted Project, Restricted Project
zibi added a reviewer for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++.: Quuxplusone.

ping

Feb 22 2022, 6:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2022

zibi accepted D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call.

LGTM

Feb 17 2022, 5:22 AM · Restricted Project

Feb 16 2022

zibi accepted D119966: [SystemZ][z/OS] Add OPEN_THREAD version of pthread function call.

LGTM, with format suggestion.

Feb 16 2022, 6:54 PM · Restricted Project
zibi accepted D119982: [libc++][AIX] Add AIX error message as expected output.

LGTM

Feb 16 2022, 6:49 PM · Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

NFC: just trying to clean CI status

Feb 16 2022, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Rebase with latest and removing conflicts.

Feb 15 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2022

zibi added a comment to D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.

Clarifying my previous in-line comment...

Feb 11 2022, 1:53 PM · Restricted Project, Restricted Project
zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

@libc++ ping

Feb 11 2022, 5:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 4 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

ping

Feb 4 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2022

zibi added inline comments to D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.
Feb 3 2022, 8:53 AM · Restricted Project, Restricted Project

Feb 1 2022

zibi abandoned D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics.

After switching to a shared build we don't need these changes anymore.

Feb 1 2022, 10:30 AM · Restricted Project, Restricted Project
zibi added a comment to D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.

Louis, I want to pick up the discussion on POSIX(OFF) left few months ago.

Feb 1 2022, 10:24 AM · Restricted Project, Restricted Project

Jan 28 2022

zibi requested review of D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Jan 28 2022, 11:43 AM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2022

zibi accepted D118129: [SystemZ][z/OS] Add AutoConvert.h header to MemoryBuffer.cpp.

LGTM

Jan 25 2022, 6:26 AM · Restricted Project

Jan 12 2022

zibi accepted D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

LGTM

Jan 12 2022, 12:34 PM · Restricted Project, Restricted Project

Jan 5 2022

zibi added a comment to D116603: [AIX][z/OS][Support] Provide no-op mapped_file_region::dontNeedImpl implementation.

LGTM

Jan 5 2022, 6:53 AM · Restricted Project

Jan 4 2022

zibi added a comment to D116603: [AIX][z/OS][Support] Provide no-op mapped_file_region::dontNeedImpl implementation.

LGTM, but I would prefer if we could use ::posix_madvise() not just on AIX. This will remove the unnecessary directive path.
However, we need to buy-in from the originator which introduced this call.

Jan 4 2022, 11:01 AM · Restricted Project
zibi added inline comments to D116603: [AIX][z/OS][Support] Provide no-op mapped_file_region::dontNeedImpl implementation.
Jan 4 2022, 10:56 AM · Restricted Project

Dec 31 2021

zibi added a comment to D116366: [Support] Add MemoryBuffer::dontNeedIfMmap.

@zibi @daltenty Is madvise not available on AIX, or is it a specific version of the OS that doesn't have it? The doc suggests it is available: https://www.ibm.com/docs/en/aix/7.1?topic=m-madvise-subroutine
Is that specific machine missing a header? Perhaps HAVE_SYS_MMAN_H isn't defined? @simon_tatham

Unless any of you have a way to quickly test a solution, short term should we just #ifndef _AIX the call to madvise?

Dec 31 2021, 10:26 AM · Restricted Project
zibi added inline comments to D116366: [Support] Add MemoryBuffer::dontNeedIfMmap.
Dec 31 2021, 6:02 AM · Restricted Project

Dec 24 2021

zibi added a comment to D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

We need to pass "-fzos-le-char-mode=ebcdic for libcxx same as we do for libcxxabi

Dec 24 2021, 9:18 AM · Restricted Project, Restricted Project
zibi added a comment to D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence.

LGTM

Dec 24 2021, 9:15 AM · Restricted Project, Restricted Project

Nov 25 2021

zibi added inline comments to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Nov 25 2021, 6:38 AM · Restricted Project

Nov 16 2021

zibi committed rG422cf2b506c1: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode (authored by zibi).
[SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode
Nov 16 2021, 5:51 AM
zibi closed D112837: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode.
Nov 16 2021, 5:51 AM · Restricted Project

Nov 15 2021

zibi added a comment to D112837: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode.

ping

Nov 15 2021, 5:42 AM · Restricted Project

Nov 8 2021

zibi added a comment to D112837: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode.

Thank you Quuxplusone for your review and approval. Following is the rational of this patch.

Nov 8 2021, 2:28 PM · Restricted Project
zibi added a comment to D112837: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode.

@ldionne Can you have a look at this patch?

Nov 8 2021, 7:11 AM · Restricted Project

Oct 29 2021

zibi updated the summary of D112837: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode.
Oct 29 2021, 11:49 AM · Restricted Project
zibi requested review of D112837: [SystemZ][z/OS] Fix warnings from unsigned int to long in 32-bit mode.
Oct 29 2021, 11:39 AM · Restricted Project

Oct 19 2021

zibi added a comment to D110647: [libc++] Resolve missing table_size symbol.

LGTM

Oct 19 2021, 2:17 PM · Restricted Project

Jun 9 2021

zibi added inline comments to D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.
Jun 9 2021, 11:15 AM · Restricted Project

May 5 2021

zibi added inline comments to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
May 5 2021, 6:50 AM · Restricted Project

Apr 26 2021

zibi added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

LGTM, just wait for libc++ approval.

Apr 26 2021, 12:27 PM · Restricted Project
zibi added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Sorry for the nit picking and I know this is coming from existing Windows implementation but we have the opportunity to clean it up.
Most comments refer to both functions.

Apr 26 2021, 9:28 AM · Restricted Project

Apr 23 2021

zibi added a comment to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

It looks like there are few test cases failing in Windows. Was that investigated to see if it is related to this patch?

Apr 23 2021, 8:12 AM · Restricted Project

Apr 9 2021

zibi added a comment to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

@zibi Please do *not* commit patches when the libcxx review group is not green. The policy for committing to libc++ is clear - you have to wait for the libcxx group to be green, or you will get reverted.

This is OK for now and I'm sure you did not intend to do wrong, but please follow the process in the future.

Apr 9 2021, 5:27 AM · Restricted Project

Apr 6 2021

zibi committed rG916093f49faf: [SystemZ][z/OS] correct rc and errno within nanosleep() (authored by zibi).
[SystemZ][z/OS] correct rc and errno within nanosleep()
Apr 6 2021, 8:37 AM
zibi closed D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Apr 6 2021, 8:37 AM · Restricted Project
zibi added inline comments to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Apr 6 2021, 8:35 AM · Restricted Project

Apr 1 2021

zibi added inline comments to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Apr 1 2021, 10:43 AM · Restricted Project
zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

adding short comments about implementation

Apr 1 2021, 10:41 AM · Restricted Project
zibi updated the summary of D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Apr 1 2021, 8:08 AM · Restricted Project
zibi retitled D99373: [SystemZ][z/OS] correct rc and errno within nanosleep() from [SystemZ][z/OS] tune down warning about unused parameter on nanosleep() to [SystemZ][z/OS] correct rc and errno within nanosleep().
Apr 1 2021, 8:03 AM · Restricted Project
zibi added a comment to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

This commit message is highly misleading.

Sorry about that, I fixed the description so it should be clear now.

Apr 1 2021, 7:57 AM · Restricted Project
zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

addressing comments

Apr 1 2021, 7:53 AM · Restricted Project

Mar 26 2021

zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

fixing CI failure

Mar 26 2021, 11:09 AM · Restricted Project
zibi updated the summary of D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Mar 26 2021, 11:07 AM · Restricted Project
zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

Fix issues with rc and errno as well adding cast for conversion warrnings.

Mar 26 2021, 9:02 AM · Restricted Project
zibi committed rG4d478121f3bf: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx (authored by zibi).
[SystemZ][z/OS] exclude nasty_macros.h from check-cxx
Mar 26 2021, 8:09 AM
zibi closed D99378: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx.
Mar 26 2021, 8:08 AM · Restricted Project
zibi updated the summary of D99378: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx.
Mar 26 2021, 6:23 AM · Restricted Project

Mar 25 2021

zibi requested review of D99378: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx.
Mar 25 2021, 1:47 PM · Restricted Project
zibi requested review of D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Mar 25 2021, 1:16 PM · Restricted Project

Mar 16 2021

zibi accepted D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

LTGM, thx for an extra mile, Abhina.

Mar 16 2021, 6:35 AM · Restricted Project, Restricted Project

Mar 15 2021

zibi added inline comments to D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.
Mar 15 2021, 12:20 PM · Restricted Project, Restricted Project
zibi added a comment to D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it.

Mar 15 2021, 9:30 AM · Restricted Project, Restricted Project

Mar 8 2021

zibi committed rGebe6161c54b9: [SystemZ][z/OS] Missing locale functions libc++ (authored by muiez).
[SystemZ][z/OS] Missing locale functions libc++
Mar 8 2021, 11:33 AM
zibi closed D98044: [SystemZ][z/OS] Missing locale functions libc++.
Mar 8 2021, 11:32 AM · Restricted Project

Mar 4 2021

zibi committed rG53c8587dcdbc: [SystemZ][z/OS] Missing non-posix functions libc++ (authored by muiez).
[SystemZ][z/OS] Missing non-posix functions libc++
Mar 4 2021, 7:25 AM
zibi closed D97051: [SystemZ][z/OS] Missing non-posix functions libc++.
Mar 4 2021, 7:25 AM · Restricted Project