Page MenuHomePhabricator

zibi (Zibi Sarbino)
Operations

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2017, 10:33 AM (289 w, 10 h)

Recent Activity

Feb 24 2023

zibi committed rGbe4aca6475fe: [z/OS][NFC] Remove obsolete code. (authored by zibi).
[z/OS][NFC] Remove obsolete code.
Feb 24 2023, 1:05 PM · Restricted Project
zibi closed D144573: [z/OS][NFC] Remove obsolete code..
Feb 24 2023, 1:04 PM · Restricted Project, Restricted Project
zibi added a comment to D144573: [z/OS][NFC] Remove obsolete code..

Can I go ahead and land this revision or need to wait for libc++abi group approval?
This is a very small non-functional revision.

Feb 24 2023, 11:12 AM · Restricted Project, Restricted Project

Feb 22 2023

zibi retitled D144573: [z/OS][NFC] Remove obsolete code. from Remove obsolete code. to [z/OS][NFC] Remove obsolete code..
Feb 22 2023, 10:15 AM · Restricted Project, Restricted Project
zibi requested review of D144573: [z/OS][NFC] Remove obsolete code..
Feb 22 2023, 10:07 AM · Restricted Project, Restricted Project
zibi accepted D144509: [CMake] Bumps minimum version to 3.20.0..
Feb 22 2023, 5:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

zibi accepted D143916: [runtimes] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default to ON for OS390.

LGTM

Feb 13 2023, 8:07 AM · Restricted Project, Restricted Project

Jan 17 2023

zibi committed rG4c3d7bc210f0: [SystemZ][z/OS] Fix cityhash lit for EBCDIC (authored by zibi).
[SystemZ][z/OS] Fix cityhash lit for EBCDIC
Jan 17 2023, 2:44 PM · Restricted Project, Restricted Project
zibi closed D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 17 2023, 2:43 PM · Restricted Project, Restricted Project
zibi added a comment to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.

FYI, the failures reported are unrelated.
They are either timeouts or taking unexpectedly too long (assertion in std/thread/futures/futures.async/async.pass.cpp at line 102).

Jan 17 2023, 2:11 PM · Restricted Project, Restricted Project
zibi updated the diff for D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
  • Revert "[SystemZ][z/OS] Fix cityhash lit for EBCDIC"
Jan 17 2023, 10:13 AM · Restricted Project, Restricted Project
zibi added inline comments to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 17 2023, 9:42 AM · Restricted Project, Restricted Project
zibi added inline comments to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 17 2023, 7:38 AM · Restricted Project, Restricted Project
zibi updated the diff for D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.

Change to use an array of integers instead of strings.

Jan 17 2023, 7:36 AM · Restricted Project, Restricted Project

Jan 16 2023

zibi added a comment to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.

FYI, the failure ia the timeout on Apple, unrelated to this patch, so consider CI checks as green.

Jan 16 2023, 6:19 AM · Restricted Project, Restricted Project

Jan 13 2023

zibi added inline comments to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 13 2023, 3:42 PM · Restricted Project, Restricted Project
zibi updated the diff for D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
  • fix typo
Jan 13 2023, 3:41 PM · Restricted Project, Restricted Project
zibi updated the diff for D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
  • Fix cityhash lit for EBCDIC
  • Switch to array of strings with hard coded values
Jan 13 2023, 1:04 PM · Restricted Project, Restricted Project
zibi added inline comments to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 13 2023, 12:27 PM · Restricted Project, Restricted Project
zibi updated the diff for D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.

Addressing comments ...

Jan 13 2023, 12:21 PM · Restricted Project, Restricted Project
zibi added a comment to D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.

The above pre-merge checks failures are timeout and not related to this patch. Submitting again to get clean build status.

Jan 13 2023, 11:35 AM · Restricted Project, Restricted Project

Jan 12 2023

zibi added reviewers for D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC: oToToT, ldionne.
Jan 12 2023, 11:08 AM · Restricted Project, Restricted Project
zibi updated subscribers of D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 12 2023, 10:58 AM · Restricted Project, Restricted Project
zibi retitled D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC from [PHABRICATOR][z/OS] Fix cityhash lit for EBCDIC to [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 12 2023, 10:55 AM · Restricted Project, Restricted Project
zibi requested review of D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC.
Jan 12 2023, 10:54 AM · Restricted Project, Restricted Project

Jan 9 2023

zibi added inline comments to rG7c327c2fbb8a: AMDGPU: Fix broken opaque pointer handling in printf pass.
Jan 9 2023, 6:27 AM · Restricted Project, Restricted Project

Jan 7 2023

zibi added inline comments to rG7c327c2fbb8a: AMDGPU: Fix broken opaque pointer handling in printf pass.
Jan 7 2023, 9:17 AM · Restricted Project, Restricted Project

Jan 5 2023

zibi committed rG3acb2553b9bf: Disable a part of the unit test CommandLineTest/BadResponseFile for z/OS. (authored by zibi).
Disable a part of the unit test CommandLineTest/BadResponseFile for z/OS.
Jan 5 2023, 1:58 PM · Restricted Project, Restricted Project
zibi closed D141084: Disable a part of the unit test CommandLineTest/BadResponseFile for z/OS..
Jan 5 2023, 1:58 PM · Restricted Project, Restricted Project
zibi updated the summary of D141084: Disable a part of the unit test CommandLineTest/BadResponseFile for z/OS..
Jan 5 2023, 1:26 PM · Restricted Project, Restricted Project
zibi requested review of D141084: Disable a part of the unit test CommandLineTest/BadResponseFile for z/OS..
Jan 5 2023, 1:21 PM · Restricted Project, Restricted Project

Dec 13 2022

zibi added inline comments to D138951: Move several exception derived classes to c++abi library.
Dec 13 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D138951: Move several exception derived classes to c++abi library.
  • Revert 47b49b5f6d40 and 57b747c55d15
Dec 13 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Dec 5 2022

zibi updated the diff for D138951: Move several exception derived classes to c++abi library.
  • Keep _LIBCPP_EXCEPTION_ABI for classes in experimental namespace.
Dec 5 2022, 2:11 PM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2022

zibi updated the diff for D138951: Move several exception derived classes to c++abi library.
  • Move several exception derived classes to c++abi library
  • Remove _LIBCPP_EXCEPTION_ABI from classes those symbols are moved to c++abi.
Nov 30 2022, 9:25 PM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

@fanbo-meng Can you close this review?
I'm going to continue in D138951.

Nov 29 2022, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
zibi added reviewers for D138951: Move several exception derived classes to c++abi library: SeanP, muiez, EricWF, ldionne, daltenty, philnik.
Nov 29 2022, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
zibi requested review of D138951: Move several exception derived classes to c++abi library.
Nov 29 2022, 2:08 PM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2022

zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • fix formatting
Nov 28 2022, 5:16 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • trying to fix CI.
Nov 28 2022, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
zibi retitled D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library from [SystemZ][z/OS] Move several exception derived classes c++abi library to [SystemZ][z/OS] Move several exception derived classes to c++abi library.
Nov 28 2022, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

Moving several exception derived classes c++abi to address review comments.

Nov 28 2022, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
zibi retitled D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library from [SystemZ][z/OS] Build several exception derived classes as a separate library to [SystemZ][z/OS] Move several exception derived classes c++abi library.
Nov 28 2022, 12:02 PM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

@EricWF Thank you for the review.

Nov 15 2022, 5:46 PM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2022

zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • correct typo
Nov 7 2022, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

Addressing comments...

Nov 7 2022, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • Remove _LIBCPP_BEGIN_NAMESPACE_EXCEPTION and _LIBCPP_END_NAMESPACE_EXCEPTION
Nov 7 2022, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

ping

Nov 7 2022, 6:16 AM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

ping @ldionne

Oct 28 2022, 7:08 AM · Restricted Project, Restricted Project, Restricted Project
zibi added inline comments to D134216: [SystemZ][z/OS] add code for hardware_concurrency().
Oct 28 2022, 7:04 AM · Restricted Project, Restricted Project
zibi added a comment to D135464: [SystemZ][z/OS] Account for no __cxa_thread_atexit_impl on z/OS.

LGTM,
ideally we should have macro for __thread which would define to nothing for z/OS.

Oct 28 2022, 6:52 AM · Restricted Project, Restricted Project
zibi added a comment to D134216: [SystemZ][z/OS] add code for hardware_concurrency().

LGTM

Oct 28 2022, 6:48 AM · Restricted Project, Restricted Project

Oct 25 2022

zibi added inline comments to D134216: [SystemZ][z/OS] add code for hardware_concurrency().
Oct 25 2022, 12:53 PM · Restricted Project, Restricted Project

Oct 21 2022

zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

Louis, this has been reviewed by others including yourself and is waiting for your stamp of approval, @ldionne

Oct 21 2022, 6:22 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

ping @ldionne

Oct 14 2022, 11:46 AM · Restricted Project, Restricted Project, Restricted Project

Oct 11 2022

zibi accepted D133517: [SystemZ][z/OS] Add scripts for building libc++/abi.

LGTM

Oct 11 2022, 9:54 AM · Restricted Project, Restricted Project
zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

Thank you for all reviews which are not addressed.
@ldionne Can you have a look? I just need your stamp of approval.

Oct 11 2022, 7:01 AM · Restricted Project, Restricted Project, Restricted Project

Oct 7 2022

zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • consolidate multiple exceptions files into a single file
Oct 7 2022, 6:52 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2022

zibi added a comment to D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.

@ldionne @philnik Please have a look again and let me know if you want to change anything.

Oct 6 2022, 6:42 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • use system notation for #include directive
Oct 6 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project

Oct 5 2022

zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • switch to use override in place of virtual
Oct 5 2022, 2:54 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
more formating
Oct 5 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • formating changes and make set_target_properties for cxx_exception be consistent with cxx_shared
Oct 5 2022, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • config.py should not be part of this change
Oct 5 2022, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118620: [SystemZ][z/OS] Move several exception derived classes to c++abi library.
  • Rebase and move recipe to build c++_exception to separate cmake.
Oct 5 2022, 11:32 AM · Restricted Project, Restricted Project, Restricted Project

Oct 3 2022

zibi committed rG36dde913b0ff: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++. (authored by zibi).
[SystemZ][z/OS] Add ASCII and 32-bit variants for libc++.
Oct 3 2022, 3:24 PM · Restricted Project, Restricted Project
zibi closed D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Oct 3 2022, 3:24 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the summary of D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Oct 3 2022, 12:19 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Fix CI - Documentation

Oct 3 2022, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Fix CI build.

Oct 3 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Sep 29 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Ready for another round. FYI @ldionne

Sep 29 2022, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Add LIBCXXABI_ADDITIONAL_COMPILE_FLAGS and other changes requested by Louis.
Sep 29 2022, 4:23 PM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

ping @ldionne

Sep 29 2022, 6:00 AM · Restricted Project, Restricted Project, Restricted Project

Sep 23 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

@ldionne I think I addressed all your comments.
Please review it.

Sep 23 2022, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Fix just one typo. @dionne I think I addressed all your comments. Please review it.
Sep 23 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2022

zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Looks like my last commit was skipped. I'm adding it now.

Sep 21 2022, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the summary of D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Sep 21 2022, 12:10 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
  • Add the following options to documentation:
Sep 21 2022, 11:52 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
  • Make cxx_shared library common for EBCDIC and ASCII build variations.
  • Use LIBCXX_CXX_ABI=system-libcxxabi to pick up abi headers and library from previous build.
Sep 21 2022, 10:39 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

zibi accepted D134216: [SystemZ][z/OS] add code for hardware_concurrency().

LGTM

Sep 20 2022, 1:08 PM · Restricted Project, Restricted Project

Sep 16 2022

zibi accepted D134034: [test] Use host platform specific error message substitution.

LGTM

Sep 16 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Putting rational why I opted out for LIBCXX_CXX_ABI=built-libcxxabi.

Sep 15 2022, 7:04 AM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2022

zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
  • Make cxx_shared library common for EBCDIC and ASCII build variations.
  • Introducing built-libcxxabi to pick up abi headers from previous build.
  • Adding the following macros:
Sep 12 2022, 5:07 PM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

answering comments and some questions

Sep 8 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Addressing Louis's comments to hide z/OS changes as much as possible in cache.

Sep 7 2022, 1:37 PM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

zibi accepted D132948: [SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR (libc++).

LGTM

Aug 30 2022, 8:31 AM · Restricted Project, Restricted Project
zibi accepted D132946: [SystemZ][z/OS] Account for renamed parameter name (libc++).

LGTM

Aug 30 2022, 8:29 AM · Restricted Project, Restricted Project

Aug 17 2022

zibi requested review of D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Louis, thank you for the review and providing some suggestions. However, I'm still not sure how to proceed see my inline comments.

Aug 17 2022, 9:56 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

ping, still waiting for the review ...

Aug 3 2022, 12:09 PM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

@ldionne Louis, all comments have been addressed CI is green, can you look at it again? Thx.

Jul 22 2022, 7:21 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2022

zibi accepted D129312: [SystemZ][z/OS] Add custom config file for libc++/abi testing.

LGTM, thank you.

Jul 14 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2022

zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

Rebase to pick up 0d7859765260e1dddfdc3490c1fe35537775bb41 which hopefully will fix CL.

Jul 13 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

zibi added a comment to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

The CI is clean now, Can I have the approval or more request, Thx.

Jul 12 2022, 1:34 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
  • Rebasing and resolving conflicts

No functional changes are introduced since the last patch.

Jul 12 2022, 1:13 PM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

zibi requested changes to D129312: [SystemZ][z/OS] Add custom config file for libc++/abi testing.

Looking good, I wonder if we can incorporating a small change to set PATH, see inline comment in ibm-zos-libc++-shared.cfg.in.

Jul 11 2022, 2:59 PM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

zibi added inline comments to D124039: [OpenMP] Add better testing for the linker wrapper.
Apr 21 2022, 5:17 AM · Restricted Project, Restricted Project

Apr 20 2022

zibi added a comment to D123241: Add -Wno-implicit-function-declaration to a few places to work w D122983.

Have you missed MultiSource/Benchmarks/Prolangs-C/bison/CMakeLists.txt to turn off the warning?

@erichkeane Erich, will you be able to provide the fix for this? Please let me know ETA so I can plan accordingly.

Apr 20 2022, 5:47 PM · Restricted Project
zibi added inline comments to D124039: [OpenMP] Add better testing for the linker wrapper.
Apr 20 2022, 2:55 PM · Restricted Project, Restricted Project
zibi added a comment to D123241: Add -Wno-implicit-function-declaration to a few places to work w D122983.

Have you missed MultiSource/Benchmarks/Prolangs-C/bison/CMakeLists.txt to turn off the warning?

Apr 20 2022, 2:28 PM · Restricted Project
zibi added a comment to D123241: Add -Wno-implicit-function-declaration to a few places to work w D122983.

I'm seeing this error:

Apr 20 2022, 1:57 PM · Restricted Project