Page MenuHomePhabricator

zibi (Zibi Sarbino)
Operations

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2017, 10:33 AM (187 w, 5 d)

Recent Activity

Fri, Apr 9

zibi added a comment to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

@zibi Please do *not* commit patches when the libcxx review group is not green. The policy for committing to libc++ is clear - you have to wait for the libcxx group to be green, or you will get reverted.

This is OK for now and I'm sure you did not intend to do wrong, but please follow the process in the future.

Fri, Apr 9, 5:27 AM · Restricted Project

Tue, Apr 6

zibi committed rG916093f49faf: [SystemZ][z/OS] correct rc and errno within nanosleep() (authored by zibi).
[SystemZ][z/OS] correct rc and errno within nanosleep()
Tue, Apr 6, 8:37 AM
zibi closed D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Tue, Apr 6, 8:37 AM · Restricted Project
zibi added inline comments to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Tue, Apr 6, 8:35 AM · Restricted Project

Thu, Apr 1

zibi added inline comments to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Thu, Apr 1, 10:43 AM · Restricted Project
zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

adding short comments about implementation

Thu, Apr 1, 10:41 AM · Restricted Project
zibi updated the summary of D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Thu, Apr 1, 8:08 AM · Restricted Project
zibi retitled D99373: [SystemZ][z/OS] correct rc and errno within nanosleep() from [SystemZ][z/OS] tune down warning about unused parameter on nanosleep() to [SystemZ][z/OS] correct rc and errno within nanosleep().
Thu, Apr 1, 8:03 AM · Restricted Project
zibi added a comment to D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

This commit message is highly misleading.

Sorry about that, I fixed the description so it should be clear now.

Thu, Apr 1, 7:57 AM · Restricted Project
zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

addressing comments

Thu, Apr 1, 7:53 AM · Restricted Project

Fri, Mar 26

zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

fixing CI failure

Fri, Mar 26, 11:09 AM · Restricted Project
zibi updated the summary of D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Fri, Mar 26, 11:07 AM · Restricted Project
zibi updated the diff for D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().

Fix issues with rc and errno as well adding cast for conversion warrnings.

Fri, Mar 26, 9:02 AM · Restricted Project
zibi committed rG4d478121f3bf: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx (authored by zibi).
[SystemZ][z/OS] exclude nasty_macros.h from check-cxx
Fri, Mar 26, 8:09 AM
zibi closed D99378: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx.
Fri, Mar 26, 8:08 AM · Restricted Project
zibi updated the summary of D99378: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx.
Fri, Mar 26, 6:23 AM · Restricted Project

Thu, Mar 25

zibi requested review of D99378: [SystemZ][z/OS] exclude nasty_macros.h from check-cxx.
Thu, Mar 25, 1:47 PM · Restricted Project
zibi requested review of D99373: [SystemZ][z/OS] correct rc and errno within nanosleep().
Thu, Mar 25, 1:16 PM · Restricted Project

Mar 16 2021

zibi accepted D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

LTGM, thx for an extra mile, Abhina.

Mar 16 2021, 6:35 AM · Restricted Project, Restricted Project

Mar 15 2021

zibi added inline comments to D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.
Mar 15 2021, 12:20 PM · Restricted Project, Restricted Project
zibi added a comment to D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it.

Mar 15 2021, 9:30 AM · Restricted Project, Restricted Project

Mar 8 2021

zibi committed rGebe6161c54b9: [SystemZ][z/OS] Missing locale functions libc++ (authored by muiez).
[SystemZ][z/OS] Missing locale functions libc++
Mar 8 2021, 11:33 AM
zibi closed D98044: [SystemZ][z/OS] Missing locale functions libc++.
Mar 8 2021, 11:32 AM · Restricted Project

Mar 4 2021

zibi committed rG53c8587dcdbc: [SystemZ][z/OS] Missing non-posix functions libc++ (authored by muiez).
[SystemZ][z/OS] Missing non-posix functions libc++
Mar 4 2021, 7:25 AM
zibi closed D97051: [SystemZ][z/OS] Missing non-posix functions libc++.
Mar 4 2021, 7:25 AM · Restricted Project

Mar 2 2021

zibi added a comment to D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics.

ping

Mar 2 2021, 6:04 PM · Restricted Project, Restricted Project

Feb 24 2021

zibi added inline comments to D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics.
Feb 24 2021, 8:50 AM · Restricted Project, Restricted Project

Feb 23 2021

zibi retitled D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics from We need to remove both options --whole-archive and --color-diagnostics from the link step otherwise, we get link errors when building libc++ on z/OS. to [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics.
Feb 23 2021, 11:59 AM · Restricted Project, Restricted Project
zibi requested review of D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics.
Feb 23 2021, 11:58 AM · Restricted Project, Restricted Project
zibi updated subscribers of D97051: [SystemZ][z/OS] Missing non-posix functions libc++.

This LGTM from my end.
@ldionne can we get your approval?

Feb 23 2021, 9:12 AM · Restricted Project

Feb 18 2021

zibi committed rG25aa0d12445e: [SystemZ][ZOS] Guard using declaration for ::fchmodat (authored by zibi).
[SystemZ][ZOS] Guard using declaration for ::fchmodat
Feb 18 2021, 7:01 AM
zibi closed D96303: [SystemZ][ZOS] Guard using declaration for ::fchmodat.
Feb 18 2021, 7:01 AM · Restricted Project
zibi added a comment to D96303: [SystemZ][ZOS] Guard using declaration for ::fchmodat.

I'm OK with that direction. But if you ship this, be aware that I'm going to remove your workaround when I ship the _LIBCPP_USING_IF_EXISTS patch, and that means you'll have to use a Clang that implements the attribute to get your build working. Are you OK with that?

Feb 18 2021, 6:20 AM · Restricted Project

Feb 16 2021

zibi added a comment to D96303: [SystemZ][ZOS] Guard using declaration for ::fchmodat.

My preference would be to extend https://reviews.llvm.org/D90257 to handle those declarations too.

Feb 16 2021, 1:07 PM · Restricted Project
zibi committed rG5f9be2c3e37c: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building… (authored by zibi).
[SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building…
Feb 16 2021, 10:43 AM
zibi closed D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.
Feb 16 2021, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D96303: [SystemZ][ZOS] Guard using declaration for ::fchmodat.

ping - very minor change

Feb 16 2021, 6:37 AM · Restricted Project
zibi added a comment to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

ping

Feb 16 2021, 6:37 AM · Restricted Project, Restricted Project, Restricted Project

Feb 12 2021

zibi committed rG48fcce1aea9e: [SystemZ][ZOS] Fix __libcpp_thrad_isnull() (authored by zibi).
[SystemZ][ZOS] Fix __libcpp_thrad_isnull()
Feb 12 2021, 12:21 PM
zibi closed D96302: [SystemZ][ZOS] Fix __libcpp_thrad_isnull().
Feb 12 2021, 12:21 PM · Restricted Project
zibi accepted D96302: [SystemZ][ZOS] Fix __libcpp_thrad_isnull().

This has been reviewed before.

Feb 12 2021, 12:19 PM · Restricted Project
zibi committed rGcb2d2ae56ae3: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative (authored by zibi).
[SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative
Feb 12 2021, 10:41 AM
zibi closed D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Feb 12 2021, 10:40 AM · Restricted Project
zibi added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

@ldionne Can I integrate this?

Feb 12 2021, 7:25 AM · Restricted Project

Feb 8 2021

zibi requested review of D96303: [SystemZ][ZOS] Guard using declaration for ::fchmodat.
Feb 8 2021, 4:49 PM · Restricted Project
zibi retitled D96302: [SystemZ][ZOS] Fix __libcpp_thrad_isnull() from Previous pthread revision https://reviews.llvm.org/D91875 missed a small change for `__libcpp_thrad_isnull()` required for z/OS. to [SystemZ][ZOS] Fix __libcpp_thrad_isnull().
Feb 8 2021, 4:28 PM · Restricted Project
zibi requested review of D96302: [SystemZ][ZOS] Fix __libcpp_thrad_isnull().
Feb 8 2021, 4:23 PM · Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

NFC: typos

Feb 8 2021, 1:39 PM · Restricted Project, Restricted Project, Restricted Project
zibi added inline comments to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.
Feb 8 2021, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
zibi abandoned D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS.

I'm abending this since there is no interest and current implementation will work on z/OS.

Feb 8 2021, 11:44 AM · Restricted Project
zibi added a comment to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

FYI, @ldionne I'm looking for you approval.

Feb 8 2021, 11:41 AM · Restricted Project, Restricted Project, Restricted Project

Feb 5 2021

zibi added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Moving to chrono.cpp is fine, otherwise please provide the exact suggestion for target_compile_definitions() .

Feb 5 2021, 1:39 PM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Moving macro to chrono.cpp.

Feb 5 2021, 1:35 PM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Oops, thx Hubert.

Feb 5 2021, 9:34 AM · Restricted Project
zibi added a comment to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

@ldionne You might also cancel these 2 builds:
https://buildkite.com/llvm-project/libcxx-ci/builds/1246
https://buildkite.com/llvm-project/libcxx-ci/builds/1239

Feb 5 2021, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.
  • resubmitting to get clean CI, thank you Louis for finding the issue with previous builds
Feb 5 2021, 7:54 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

synch with __support rename

Feb 5 2021, 6:39 AM · Restricted Project

Feb 4 2021

zibi added a comment to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

@ldionne Can you check why the last 3 builds always hang in Apple tests?
Here is the link to the latest build.

The number of builders on mac is very limited. They're running on a few laptops sitting right beside me. You have to be a bit patient. Re-uploading patches to try and shake the CI is actually making things worse, as our BuildKite setup isn't smart enough to cancel jobs that have already been submitted when you re-upload a newer patch.

Feb 4 2021, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

@ldionne Can you check why the last 3 builds always hang in Apple tests?
Here is the link to the latest build.

Feb 4 2021, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

Hopefully this time CI will be clean, the previous one never completed.

Feb 4 2021, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2021

zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Making _LARGE_TIME_API locale, renaming header guard and removing NR asm constriants.

Feb 3 2021, 7:56 PM · Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

adding none c++ libraries back even for -nostdlib++ for libcxx/libcxxabi/libunwind to check if this will make CI clean

Feb 3 2021, 11:18 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2021

zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

reverse previous fix and try something new to test CI

Feb 2 2021, 7:29 PM · Restricted Project, Restricted Project, Restricted Project
zibi added inline comments to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Feb 2 2021, 3:15 PM · Restricted Project
zibi added inline comments to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.
Feb 2 2021, 3:10 PM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

On MINGW we need to build libunwind with -nodefaultlibs on b/c LIBUNWIND_SUPPORTS_FUNWIND_TABLES_FLAG is not set,
otherwise we issue this error:

Feb 2 2021, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

Default libunwind to be build with -nodefaultlibs on MINGW.

Feb 2 2021, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
zibi added inline comments to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Feb 2 2021, 1:27 PM · Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

typo + patch with arc diff

Feb 2 2021, 11:02 AM · Restricted Project, Restricted Project, Restricted Project
zibi updated the diff for D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.

pached created by arc diff

Feb 2 2021, 10:42 AM · Restricted Project, Restricted Project, Restricted Project
zibi abandoned D95880: typo.
Feb 2 2021, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
zibi added a comment to D95880: typo.

@zibi, you need to specify your base branch to arc.

Feb 2 2021, 9:47 AM · Restricted Project, Restricted Project, Restricted Project
zibi requested review of D95880: typo.
Feb 2 2021, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
zibi requested review of D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries.
Feb 2 2021, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2021

zibi added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Hubert, I incorporated your suggestions. Please note that currently pre-build checks fails because of unrelated issues with Apple back-deployment macosx10.9 test bucket.

Jan 26 2021, 8:46 AM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Jan 26 2021, 8:44 AM · Restricted Project

Jan 25 2021

zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

format + tidy

Jan 25 2021, 1:49 PM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

checking CI

Jan 25 2021, 12:39 PM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Please see a new patch according to the comments I received.

Jan 25 2021, 12:37 PM · Restricted Project
zibi added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Thank you louis and Hubert for review and suggestions.

Jan 25 2021, 12:32 PM · Restricted Project

Jan 23 2021

zibi committed rG92bb81aac1f1: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx (authored by zibi).
[SystemZ][ZOS] Provide PATH_MAX macro for libcxx
Jan 23 2021, 4:30 PM
zibi closed D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Jan 23 2021, 4:30 PM · Restricted Project

Jan 14 2021

zibi updated the diff for D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

rebase and resubmit to fix the build

Jan 14 2021, 6:15 PM · Restricted Project

Jan 13 2021

zibi added a comment to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

Neither.

The documentation Hubert pointed to clearly mentions that PATH_MAX can be used, so I don't understand the issue. If the issue is that you want to be able to compile libc++ on systems so old that they don't have PATH_MAX defined even though the documentation says it is provided, that doesn't sound compelling to me.

Jan 13 2021, 11:26 AM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Removing trailing character and resubmitting.

Jan 13 2021, 10:06 AM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Not sure why pre. build check failed with trailing spaces. I could not find any.
Resubmitting to check if it goes this time.

Jan 13 2021, 9:24 AM · Restricted Project
zibi added a comment to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

@ldionne which suggestion do you prefer?

Jan 13 2021, 8:42 AM · Restricted Project
zibi added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Unless I'm heavily mistaken, gettimeofday() isn't monotonic. It's not a good idea to implement a feature in a way that we know to be broken from the start.

Jan 13 2021, 8:37 AM · Restricted Project
zibi updated the diff for D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

Adding gettimeofday() equivalent for CLOCK_MONOTONIC for z/OS.

Jan 13 2021, 8:25 AM · Restricted Project

Jan 7 2021

zibi updated zibi.
Jan 7 2021, 11:51 AM
zibi updated zibi.
Jan 7 2021, 11:51 AM
zibi updated zibi.
Jan 7 2021, 11:50 AM

Jan 6 2021

zibi added inline comments to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Jan 6 2021, 7:27 AM · Restricted Project

Jan 4 2021

zibi updated the diff for D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

fixing typo

Jan 4 2021, 11:41 AM · Restricted Project
zibi updated the diff for D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

We have to use _XOPEN_PATH_MAX instead of PATH_MAX on z/OS.

Jan 4 2021, 11:36 AM · Restricted Project

Dec 18 2020

zibi added a comment to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

That being said, Libc++ has a mode which does not require a monotonic clock.
The configuration is guarded by _LIBCPP_HAS_NO_THREADS

Dec 18 2020, 8:11 AM · Restricted Project
zibi requested review of D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Dec 18 2020, 7:23 AM · Restricted Project

Dec 16 2020

zibi added a comment to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

ping

Dec 16 2020, 1:36 PM · Restricted Project

Dec 9 2020

zibi added a comment to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

On z/OS we have multiple file systems with different limits which does not allow to have just one constant for PATH_MAX. Same is true for other related limits like NAME_MAX. See the following references which justify the z/OS choice.

Dec 9 2020, 7:08 AM · Restricted Project

Dec 8 2020

zibi added inline comments to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Dec 8 2020, 11:45 AM · Restricted Project