Page MenuHomePhabricator

amccarth (Adrian McCarthy)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2015, 9:26 AM (323 w, 5 d)

Recent Activity

Thu, Apr 1

amccarth added a comment to D99580: [CLANG] [DebugInfo] Convert File name to native format.

It looks like the code change is for everyone, but the new test is specific to mingw.

For Linux like platform it does not create problem because input file path is already in POSIX style, so having a test case will not test the change because even without the change it will pass.

Thu, Apr 1, 9:01 AM · Restricted Project, Restricted Project

Tue, Mar 30

amccarth added a comment to D99580: [CLANG] [DebugInfo] Convert File name to native format.

The previous discussions (that I participated in) were centered around the redirecting virtual filesystem, which creates paths in hybrid style and there is no "correct" way to make those native without taking breaking changes and making it less useful for writing platform-agnostic tests. But it's not clear that's relevant here.

Tue, Mar 30, 2:46 PM · Restricted Project, Restricted Project
amccarth added a comment to D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text.

I like the composability enabled by making OF_Text and OF_CRLF independent. I wonder, though, if there's a chokepoint where we could/should assert if the caller uses OF_CRLF without OF_Text, which would be suspicious.

Tue, Mar 30, 9:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
amccarth accepted D99241: [libcxx] [test] Don't add dirs from the LIB env var to PATH.

LGTM.

Tue, Mar 30, 8:49 AM · Restricted Project

Mon, Mar 29

amccarth added a comment to D99241: [libcxx] [test] Don't add dirs from the LIB env var to PATH.

Adding everything in LIB to PATH is not a normal thing to do in Windows, so I would support this patch to remove that hack. If we knew what the original problem was, we could probably find a better solution.

Mon, Mar 29, 1:41 PM · Restricted Project

Thu, Mar 25

amccarth added a comment to D99357: [Support][Windows] Make sure only executables are found by sys::findProgramByName.

Just some drive-by comments.

Thu, Mar 25, 3:55 PM · Restricted Project
amccarth added a comment to D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

When changing an IO stream's mode from binary to text breaks only Windows, it's likely due to the fact that Windows uses CR+LF as the newline indicator. Not only are the CRs sometimes unexpected, they can also throw off code that tries to seek to a computed file position.

Thu, Mar 25, 10:46 AM · Restricted Project, Restricted Project

Wed, Mar 24

amccarth accepted D99212: [Support] Fix Windows 7 path handling.

This looks even better.

Wed, Mar 24, 9:11 AM · Restricted Project
amccarth accepted D99200: [SystemZ][z/OS] JSON file should be text files.

LGTM.

Wed, Mar 24, 8:33 AM · Restricted Project

Tue, Mar 23

amccarth accepted D99213: [libcxx] Avoid pulling in xlocinfo.h in public headers.

LGTM.

Tue, Mar 23, 1:57 PM · Restricted Project
amccarth accepted D99212: [Support] Fix Windows 7 path handling.

I like the solution. Has anyone actually tried it on Windows 7? I ask because some of the observations noted in second hand descriptions of the problem didn't fully add up. I think we understand the root problem, but I'm not 100% certain.

Tue, Mar 23, 1:54 PM · Restricted Project

Wed, Mar 17

amccarth added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

Minidumps should have the registers in the processor context. It seems LLDB knows about TCR_ELn for n > 0. Maybe TCR_EL0 is special?

Wed, Mar 17, 8:47 AM · Restricted Project

Tue, Mar 16

amccarth added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

This workaround seems consistent with other overrides of FixCodeAddress, my only concern is about the assumption of the number of bits that need to be preserved/stripped.

Tue, Mar 16, 11:18 AM · Restricted Project

Mar 5 2021

amccarth added a comment to D97538: [libcxx] [test] Ifdef out tests that rely on perms::none on directories for triggering errors.

Tagging @curdeius and @amccarth for input and ideas
If a process running as root can iterate over a directory even after chmod 000, I don't think changing the owner would help. Dunno about windows - on the API level we operate so far, permissions only consist of a boolean readonly flag, not much more. On some other level, windows filesystems have full ACLs for controlling access though.

Mar 5 2021, 3:34 PM · Restricted Project

Mar 4 2021

amccarth added a comment to D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS.

From a Windows point of view, this LGTM.

Mar 4 2021, 3:20 PM · Restricted Project, Restricted Project

Feb 26 2021

amccarth accepted D97539: [libcxx] Implement semaphores for windows.

Looks good enough to me. (But I'm also not a libc++ owner.)

Feb 26 2021, 4:04 PM · Restricted Project

Feb 25 2021

amccarth added a comment to D97437: Rewrite MSVC toolchain discovery with VFS.

LGTM.

Feb 25 2021, 1:31 PM · Restricted Project

Feb 24 2021

amccarth added a comment to D88220: [C++20] P1825R0: More implicit moves.

The option is used in the wild, but not as widely as I first believed. We've already fixed a couple projects that were using it. I think the Release Note is the right solution. Thanks for doing that. I withdraw my suggestion to allow and ignore.

Feb 24 2021, 8:33 AM · Restricted Project
amccarth accepted D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11.

LGTM.

Feb 24 2021, 8:29 AM · Restricted Project

Feb 19 2021

amccarth resigned from D96840: [LLDB] [docs] Update the list of supported architectures on Windows.
Feb 19 2021, 9:24 AM · Restricted Project
amccarth added a comment to D96840: [LLDB] [docs] Update the list of supported architectures on Windows.

I'm in no position to evaluate the functionality of lldb on Windows. I've spent the last few months trying to understand why 900+ tests spontaneously started failing on Windows.

Feb 19 2021, 9:24 AM · Restricted Project

Feb 18 2021

amccarth abandoned D96971: Allow but ignore `-Wreturn-std-move-in-c++11`.

Fair enough. I'm continuing the whack-a-mole game for the Chromium third-parties.

Feb 18 2021, 3:14 PM
amccarth requested review of D96971: Allow but ignore `-Wreturn-std-move-in-c++11`.
Feb 18 2021, 9:39 AM
amccarth added a comment to D88220: [C++20] P1825R0: More implicit moves.

The removal of -Wreturn-std-move-in-c++11 breaks a few projects. These projects are specifying the option, which then triggers an unknown-option warning and thus -Wx halts the build.

Feb 18 2021, 9:08 AM · Restricted Project

Feb 16 2021

amccarth added a comment to D95494: Support: Add mapped_file_region::sync(), equivalent to msync.

I think we'd just want it to sync as much say destruction a file stream or destruction a mapped_file_region.

Feb 16 2021, 3:55 PM · Restricted Project

Feb 12 2021

amccarth added a comment to D95494: Support: Add mapped_file_region::sync(), equivalent to msync.
In D95494#2534572, @rnk wrote:

@amccarth, can you confirm that these are the right APIs to use here? Do we need both FlushViewOfFile and FlushFileBuffers?

Feb 12 2021, 2:13 PM · Restricted Project

Jan 29 2021

amccarth accepted D91171: [16/N] [libcxx] Implement the permissions function for windows.

LGTM

Jan 29 2021, 3:38 PM · Restricted Project
amccarth accepted D91170: [15/N] [libcxx] Implement the canonical function for windows.

The changes to provide realpath on Windows looks right. Since it's relying on a system call, it would be difficult to create tests for the \\?\ and UNC cases. I'm assuming the more mainstream cases will be tested by existing tests. So LGTM.

Jan 29 2021, 10:45 AM · Restricted Project

Jan 22 2021

amccarth added a comment to D70701: Fix more VFS tests on Windows.

BTW, I hope I didn't come across as overly negative in my previous
response. I'd love to see the situation improved. I just don't know what
that would look like.

Jan 22 2021, 10:03 AM · Restricted Project, Restricted Project

Jan 21 2021

amccarth updated subscribers of D70701: Fix more VFS tests on Windows.

I didn't design VFS. I just fixed a bunch of portability bugs that
prevented us from running most of the VFS tests on Windows. If I were
designing it, I (hope) I wouldn't have done it this way. But the horse is
already out of the barn.

Jan 21 2021, 5:36 PM · Restricted Project, Restricted Project

Jan 13 2021

amccarth accepted D92419: [Support] On Windows, take the affinity mask into account.

Thanks for the changes!

Jan 13 2021, 3:59 PM · Restricted Project

Jan 11 2021

amccarth accepted D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.
Jan 11 2021, 2:00 PM · Restricted Project

Jan 8 2021

amccarth added a comment to D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

This looks good to me, in that I believe it will correctly parse typical native Windows path names. Only tests will tell, but I understand that there are many patches necessary to enable the tests.

Jan 8 2021, 5:10 PM · Restricted Project
amccarth accepted D91853: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows functions with large stack buffers.

LGTM, but please take the suggested edit to update a documentation URL.

Jan 8 2021, 12:11 PM · Restricted Project
amccarth accepted D91178: [22/N] [libcxx] Implement append and operator/ properly for windows.

LGTM.

Jan 8 2021, 11:44 AM · Restricted Project
amccarth accepted D91171: [16/N] [libcxx] Implement the permissions function for windows.

LGTM.

Jan 8 2021, 11:43 AM · Restricted Project

Jan 5 2021

amccarth added a comment to D91852: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets.

Ping @amccarth, do you want to follow up on the discussion before I land this?

Jan 5 2021, 1:56 PM · Restricted Project

Dec 17 2020

amccarth accepted D93456: [libcxx] Avoid overflows in the windows __libcpp_steady_clock_now().

This looks correct and straightforward, so LGTM.

Dec 17 2020, 9:08 AM · Restricted Project

Dec 11 2020

amccarth accepted D91172: [17/N] [libcxx] Implement the read_symlink function for windows.

LGTM.

Dec 11 2020, 2:36 PM · Restricted Project
amccarth accepted D91170: [15/N] [libcxx] Implement the canonical function for windows.

LGTM.

Dec 11 2020, 2:28 PM · Restricted Project
amccarth accepted D91169: [14/N] [libcxx] Implement the current_path function for windows.

Your call on using the CRT. I was under the mistaken impression that libcxx would implement both the standard C++ library as well as the CRT.

Dec 11 2020, 2:23 PM · Restricted Project
amccarth accepted D91179: [23/N] [libcxx] Have lexically_normal return the path with preferred separators.
Dec 11 2020, 11:44 AM · Restricted Project
amccarth requested changes to D91178: [22/N] [libcxx] Implement append and operator/ properly for windows.
Dec 11 2020, 11:41 AM · Restricted Project

Dec 10 2020

amccarth added inline comments to D92419: [Support] On Windows, take the affinity mask into account.
Dec 10 2020, 5:19 PM · Restricted Project
amccarth accepted D91177: [21/N] [libcxx] Implement is_absolute properly for windows.

LGTM iff this function never has to deal with paths prefixed with \\?\, as in \\?\C:\Windows or \\?\UNC\server\foo.

Dec 10 2020, 4:55 PM · Restricted Project

Dec 8 2020

amccarth accepted D91175: [19/N] [libcxx] Implement temp_directory_path using GetTempPath on windows.

LGTM.

Dec 8 2020, 1:56 PM · Restricted Project

Dec 7 2020

amccarth requested changes to D91175: [19/N] [libcxx] Implement temp_directory_path using GetTempPath on windows.
Dec 7 2020, 2:58 PM · Restricted Project
amccarth added a comment to D91173: [18/N] [libcxx] Use the posix code for directory_entry::__do_refresh.

Oh, are there tests that need to be enabled on Windows?

Dec 7 2020, 1:16 PM · Restricted Project
amccarth accepted D91173: [18/N] [libcxx] Use the posix code for directory_entry::__do_refresh.

LGTM.

Dec 7 2020, 1:16 PM · Restricted Project
amccarth accepted D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

I'm glad @gkistanova asked for this simplification. The more cautious approach added a lot of probably unnecessary noise.

Dec 7 2020, 9:33 AM

Dec 4 2020

amccarth added a comment to D91172: [17/N] [libcxx] Implement the read_symlink function for windows.

This looks like it'll work just fine, but I've added some inline questions for readability and robustness.

Dec 4 2020, 3:54 PM · Restricted Project
amccarth requested changes to D91171: [16/N] [libcxx] Implement the permissions function for windows.
Dec 4 2020, 11:18 AM · Restricted Project

Dec 3 2020

amccarth requested changes to D91170: [15/N] [libcxx] Implement the canonical function for windows.
Dec 3 2020, 2:56 PM · Restricted Project
amccarth accepted D91145: [12/N] [libcxx] Sanitize paths before creating symlinks on windows.

LGTM

Dec 3 2020, 2:25 PM · Restricted Project

Dec 2 2020

amccarth added inline comments to D91169: [14/N] [libcxx] Implement the current_path function for windows.
Dec 2 2020, 4:53 PM · Restricted Project
amccarth accepted D91168: [13/N] [libcxx] Implement the space function for windows.

LGTM.

Dec 2 2020, 3:45 PM · Restricted Project
amccarth accepted D91143: [11/N] [libcxx] Hook up a number of operation functions to their windows counterparts.

LGTM, now.

Dec 2 2020, 3:15 PM · Restricted Project
amccarth resigned from D91139: [7/N] [libcxx] Don't use __int128 for msvc targets.

I'm out of my depth on 128-bit arithmetic and ABIs.

Dec 2 2020, 3:10 PM · Restricted Project

Dec 1 2020

amccarth added inline comments to D91138: [6/N] [libcxx] Handle backslash as path separator on windows.
Dec 1 2020, 2:56 PM · Restricted Project
amccarth added inline comments to D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows.
Dec 1 2020, 1:55 PM · Restricted Project
amccarth added a comment to D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages.

These test look pretty thorough. I think these will be useful in finding portability problems.

Dec 1 2020, 1:41 PM · Restricted Project
amccarth added a comment to D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

I think this patch is a good idea, but I'm having second thoughts about whether this will solve the problem.

Dec 1 2020, 10:29 AM
amccarth accepted D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

LGTM. (I must have slipped on the Action drop-down.)

Dec 1 2020, 10:19 AM
amccarth requested changes to D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

I look forward to just switching everything to RemoveDirectory.

Dec 1 2020, 10:18 AM

Nov 30 2020

amccarth added a comment to D91853: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows functions with large stack buffers.

I prefer the relatively localized disabling of the warning with the #pragmas as you've done as opposed to building the sanitizer builds with different settings.

Nov 30 2020, 4:56 PM · Restricted Project
amccarth accepted D91852: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets.
Nov 30 2020, 4:41 PM · Restricted Project

Nov 20 2020

amccarth accepted D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.

LGTM

Nov 20 2020, 1:22 PM · Restricted Project
amccarth accepted D91142: [10/N] [libcxx] Implement _FilesystemClock::now() and __last_write_time for windows.

LGTM. I'll leave it to your discretion on the new_time range check.

Nov 20 2020, 11:18 AM · Restricted Project

Nov 19 2020

amccarth added a comment to D91142: [10/N] [libcxx] Implement _FilesystemClock::now() and __last_write_time for windows.

This looks good. I'm just confused by one point and have a small suggested edit.

Nov 19 2020, 3:32 PM · Restricted Project
amccarth added a comment to D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.

I added two suggested edits for your consideration.

Nov 19 2020, 2:49 PM · Restricted Project

Nov 18 2020

amccarth added a comment to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.

LGTM as long as the run-time calculation of the default value for set_errno is legit.

Nov 18 2020, 9:59 AM · Restricted Project
amccarth accepted D91140: [8/N] [libcxx] Fix the preexisting directory_iterator code for windows.

I'm not a libcxx owner, so I'm not sure what other hoops you should jump through for them, but this looks good to me. Thanks for the improvements!

Nov 18 2020, 9:35 AM · Restricted Project

Nov 17 2020

amccarth accepted D91137: [5/N] [libcxx] Convert paths to/from the right narrow code page for narrow strings on windows.

Excellent. Somehow I missed that AreFileApisANSI was a Win32 function. I must have mistyped it in my searches the other day. This looks good.

Nov 17 2020, 1:28 PM · Restricted Project

Nov 16 2020

amccarth added a comment to D91137: [5/N] [libcxx] Convert paths to/from the right narrow code page for narrow strings on windows.

The Windows details look correct, though I have a couple questions on the code page conversions.

Nov 16 2020, 2:38 PM · Restricted Project

Nov 12 2020

amccarth added a comment to D91143: [11/N] [libcxx] Hook up a number of operation functions to their windows counterparts.

I have a couple questions to consider inline. If those have already been thought through, then LTGM.

Nov 12 2020, 11:26 AM · Restricted Project
amccarth requested changes to D91140: [8/N] [libcxx] Fix the preexisting directory_iterator code for windows.

This is pretty close.

Nov 12 2020, 10:15 AM · Restricted Project

Oct 23 2020

amccarth added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

This looks pretty good, both the patch and Pavel's insights. I don't see much to comment on that Pavel didn't already catch.

Oct 23 2020, 5:34 PM · Restricted Project

Oct 19 2020

amccarth accepted D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt.

It seems weird that we're implicitly adding defaultlib options without checking if the user specified nodefaultlib. But given that's already the case, I don't see a big problem with also adding oldnames.lib.

Oct 19 2020, 1:30 PM · Restricted Project

Oct 15 2020

amccarth updated subscribers of D84380: [lit] Support running tests on Windows without GnuWin32..

I have no reason to suspect those patches in particular. I did a huge git
bisect, which turned up nothing. Older versions that used to work no
longer worked by the time the bisect worked that far back. That makes me
think it might be incomplete dependency checking: Something goes bad, and,
instead of rebuilding it, the bad result is re-used in each subsequent
build.

Oct 15 2020, 8:42 AM · Restricted Project

Oct 14 2020

amccarth added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

Also, worth nothing that C:\Program Files\Git\usr\bin is not enough to run the lldb tests, which need make and maybe other things.
I'm not sure if that was part of your original goal, but since clang changes can affect lldb behavior, that means developers would still need some additionnal tools along Git for Windows.

One more note: even after installing make with choco install make and adding it to %PATH%, many lldb tests still fail because we call sh F:\llvm-project\build\foo and the backslashes are escaped by sh. We end up with F:lvm-projectuildoo something like this. We could maybe insert cygpath before the calls to sh to fix that in the lldb scripts.

Oct 14 2020, 11:38 AM · Restricted Project

Oct 13 2020

amccarth updated subscribers of D88666: DirectoryWatcher: add an implementation for Windows.

If I had to guess, my money would be on a deadlock. To unblock, I'd
propose reverting this patch until we can figure it out.

Oct 13 2020, 9:22 AM · Restricted Project

Oct 12 2020

amccarth committed rGf21fcccef719: [LLDB] Fix 37 tests on Windows (authored by amccarth).
[LLDB] Fix 37 tests on Windows
Oct 12 2020, 11:15 AM
amccarth closed D89256: [LLDB] Fix 37 tests on Windows.
Oct 12 2020, 11:15 AM · Restricted Project
amccarth requested review of D89256: [LLDB] Fix 37 tests on Windows.
Oct 12 2020, 11:03 AM · Restricted Project

Oct 9 2020

amccarth accepted D88666: DirectoryWatcher: add an implementation for Windows.

LGTM. Thanks for extending this functionality to Windows!

Oct 9 2020, 8:57 AM · Restricted Project

Oct 8 2020

amccarth added a comment to D88988: [llvm-symbolizer] Add inline stack traces for Windows..

This looks pretty good.

Oct 8 2020, 4:20 PM · Restricted Project, Restricted Project

Oct 7 2020

amccarth added a comment to D88967: [lldb] Add a cmake warning about the python/swig incompatibility.

If I recall correctly, the non-debug builds still had the problem, they just didn't have the assertion that made it obvious.

Is that problem only theoretical (like, "you shouldn't be doing that") or does it have some practical consequences (crashes, incorrect operation, etc.)?

Oct 7 2020, 2:07 PM · Restricted Project
amccarth added a comment to D88967: [lldb] Add a cmake warning about the python/swig incompatibility.

If I recall correctly, the non-debug builds still had the problem, they just didn't have the assertion that made it obvious.

Oct 7 2020, 11:32 AM · Restricted Project
amccarth added a comment to D88975: [LLDB] On Windows, fix tests.

It's interesting that I haven't encountered some of these errors. There are five _other_ lldb tests that do fail for me. I have a fix in the works for some of those.

Oct 7 2020, 11:25 AM · Restricted Project

Oct 6 2020

amccarth requested changes to D88666: DirectoryWatcher: add an implementation for Windows.

Some of this is nitpicky/opinionated, but the race condition is real. We need a reliable way to signal the watcher thread when it's time to exit. Options I see are:

Oct 6 2020, 2:10 PM · Restricted Project
amccarth added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).

Oct 6 2020, 12:59 PM · Restricted Project
amccarth accepted D88906: [lldb/docs] Clarify python/swig version incompatibility.

Yes, I also (independently) discovered this problem. I probably have notes somewhere with sources for details about the incompatibility. I believe I also brought it up on the lldb-dev list.

Oct 6 2020, 10:10 AM · Restricted Project

Oct 5 2020

amccarth added a comment to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.

I don't know whether Python and our config tools use the terms consistent, but Win32 is the name of the Windows API used on both 32- and 64-bit processors, Win16 was the API used on 16-bit machines, and Win64 is a made-up term that confuses the issues.

Oct 5 2020, 3:07 PM · Restricted Project

Oct 2 2020

amccarth added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

I'm sorry. I haven't had to time to review the entire change yet, but I thought I'd share some early feedback now and take more of a look on Monday.

Oct 2 2020, 5:28 PM · Restricted Project
amccarth added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..
In D84380#2307030, @rnk wrote:

Figured it out, Python 2 vs 3 bug:
rGd12ae042e17b27ebc8d2b5ae3d8dd5f88384d093

Oct 2 2020, 9:05 AM · Restricted Project

Sep 29 2020

amccarth added a comment to D88401: [lib/Support/CommandLine][windows] - Handle "\ " as a space token..
Sep 29 2020, 4:40 PM · Restricted Project

Sep 25 2020

amccarth added a comment to D87732: [Support] Provide sys::path::guess_style.
In D87732#2296076, @rnk wrote:

Separately, I would like LLVM to move in the direction of standardizing on forward slashes in internal representations and data structures.

Sep 25 2020, 5:25 PM · Restricted Project
amccarth added a comment to D87732: [Support] Provide sys::path::guess_style.

A big portability problem with the virtual file system (VFS) is that we now have paths that can legitimately be in a hybrid Windows/Posix style. Be aware that some of the "guess-the-style" instances were modified to account for this.

Sep 25 2020, 8:45 AM · Restricted Project

Sep 21 2020

amccarth accepted D70378: [LLD][COFF] Cover usage of LLD as a library.

LGTM.

Sep 21 2020, 8:37 AM · Restricted Project, lld, Restricted Project

Sep 15 2020

amccarth accepted D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers.

I never realized rc.exe would accept having too few values for a FILEVERSION or PRODUCTVERSION. The documentation implies that you must provide four components--it is the _fixed_ portion of the VERSIONINFO after all. Not that it matters; this looks harmless.

Sep 15 2020, 8:48 AM · Restricted Project