Page MenuHomePhabricator

amccarth (Adrian McCarthy)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2015, 9:26 AM (299 w, 7 h)

Recent Activity

Today

amccarth accepted D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt.

It seems weird that we're implicitly adding defaultlib options without checking if the user specified nodefaultlib. But given that's already the case, I don't see a big problem with also adding oldnames.lib.

Mon, Oct 19, 1:30 PM · Restricted Project

Thu, Oct 15

amccarth updated subscribers of D84380: [lit] Support running tests on Windows without GnuWin32..

I have no reason to suspect those patches in particular. I did a huge git
bisect, which turned up nothing. Older versions that used to work no
longer worked by the time the bisect worked that far back. That makes me
think it might be incomplete dependency checking: Something goes bad, and,
instead of rebuilding it, the bad result is re-used in each subsequent
build.

Thu, Oct 15, 8:42 AM · Restricted Project

Wed, Oct 14

amccarth added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

Also, worth nothing that C:\Program Files\Git\usr\bin is not enough to run the lldb tests, which need make and maybe other things.
I'm not sure if that was part of your original goal, but since clang changes can affect lldb behavior, that means developers would still need some additionnal tools along Git for Windows.

One more note: even after installing make with choco install make and adding it to %PATH%, many lldb tests still fail because we call sh F:\llvm-project\build\foo and the backslashes are escaped by sh. We end up with F:lvm-projectuildoo something like this. We could maybe insert cygpath before the calls to sh to fix that in the lldb scripts.

Wed, Oct 14, 11:38 AM · Restricted Project

Tue, Oct 13

amccarth updated subscribers of D88666: DirectoryWatcher: add an implementation for Windows.

If I had to guess, my money would be on a deadlock. To unblock, I'd
propose reverting this patch until we can figure it out.

Tue, Oct 13, 9:22 AM · Restricted Project

Mon, Oct 12

amccarth committed rGf21fcccef719: [LLDB] Fix 37 tests on Windows (authored by amccarth).
[LLDB] Fix 37 tests on Windows
Mon, Oct 12, 11:15 AM
amccarth closed D89256: [LLDB] Fix 37 tests on Windows.
Mon, Oct 12, 11:15 AM · Restricted Project
amccarth requested review of D89256: [LLDB] Fix 37 tests on Windows.
Mon, Oct 12, 11:03 AM · Restricted Project

Fri, Oct 9

amccarth accepted D88666: DirectoryWatcher: add an implementation for Windows.

LGTM. Thanks for extending this functionality to Windows!

Fri, Oct 9, 8:57 AM · Restricted Project

Thu, Oct 8

amccarth added a comment to D88988: [llvm-symbolizer] Add inline stack traces for Windows..

This looks pretty good.

Thu, Oct 8, 4:20 PM · Restricted Project, Restricted Project

Wed, Oct 7

amccarth added a comment to D88967: [lldb] Add a cmake warning about the python/swig incompatibility.

If I recall correctly, the non-debug builds still had the problem, they just didn't have the assertion that made it obvious.

Is that problem only theoretical (like, "you shouldn't be doing that") or does it have some practical consequences (crashes, incorrect operation, etc.)?

Wed, Oct 7, 2:07 PM · Restricted Project
amccarth added a comment to D88967: [lldb] Add a cmake warning about the python/swig incompatibility.

If I recall correctly, the non-debug builds still had the problem, they just didn't have the assertion that made it obvious.

Wed, Oct 7, 11:32 AM · Restricted Project
amccarth added a comment to D88975: [LLDB] On Windows, fix tests.

It's interesting that I haven't encountered some of these errors. There are five _other_ lldb tests that do fail for me. I have a fix in the works for some of those.

Wed, Oct 7, 11:25 AM · Restricted Project

Tue, Oct 6

amccarth requested changes to D88666: DirectoryWatcher: add an implementation for Windows.

Some of this is nitpicky/opinionated, but the race condition is real. We need a reliable way to signal the watcher thread when it's time to exit. Options I see are:

Tue, Oct 6, 2:10 PM · Restricted Project
amccarth added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).

Tue, Oct 6, 12:59 PM · Restricted Project
amccarth accepted D88906: [lldb/docs] Clarify python/swig version incompatibility.

Yes, I also (independently) discovered this problem. I probably have notes somewhere with sources for details about the incompatibility. I believe I also brought it up on the lldb-dev list.

Tue, Oct 6, 10:10 AM · Restricted Project

Mon, Oct 5

amccarth added a comment to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.

I don't know whether Python and our config tools use the terms consistent, but Win32 is the name of the Windows API used on both 32- and 64-bit processors, Win16 was the API used on 16-bit machines, and Win64 is a made-up term that confuses the issues.

Mon, Oct 5, 3:07 PM · Restricted Project

Fri, Oct 2

amccarth added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

I'm sorry. I haven't had to time to review the entire change yet, but I thought I'd share some early feedback now and take more of a look on Monday.

Fri, Oct 2, 5:28 PM · Restricted Project
amccarth added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..
In D84380#2307030, @rnk wrote:

Figured it out, Python 2 vs 3 bug:
rGd12ae042e17b27ebc8d2b5ae3d8dd5f88384d093

Fri, Oct 2, 9:05 AM · Restricted Project

Tue, Sep 29

amccarth added a comment to D88401: [lib/Support/CommandLine][windows] - Handle "\ " as a space token..
Tue, Sep 29, 4:40 PM · Restricted Project

Fri, Sep 25

amccarth added a comment to D87732: [Support] Provide sys::path::guess_style.
In D87732#2296076, @rnk wrote:

Separately, I would like LLVM to move in the direction of standardizing on forward slashes in internal representations and data structures.

Fri, Sep 25, 5:25 PM · Restricted Project
amccarth added a comment to D87732: [Support] Provide sys::path::guess_style.

A big portability problem with the virtual file system (VFS) is that we now have paths that can legitimately be in a hybrid Windows/Posix style. Be aware that some of the "guess-the-style" instances were modified to account for this.

Fri, Sep 25, 8:45 AM · Restricted Project

Mon, Sep 21

amccarth accepted D70378: [LLD][COFF] Cover usage of LLD as a library.

LGTM.

Mon, Sep 21, 8:37 AM · Restricted Project, lld, Restricted Project

Sep 15 2020

amccarth accepted D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers.

I never realized rc.exe would accept having too few values for a FILEVERSION or PRODUCTVERSION. The documentation implies that you must provide four components--it is the _fixed_ portion of the VERSIONINFO after all. Not that it matters; this looks harmless.

Sep 15 2020, 8:48 AM · Restricted Project

Sep 2 2020

amccarth added a comment to D85993: [lldb] Set the access property on member function decls.

Dwarf parser uses TypeSystemClang::AddMethodToCXXRecordType instead of this function to create methods (which is why there are no assertions like this when using dwarf). Maybe it would be better to change the pdb parser to use that function instead (as it allows the user to specify not only accessibility, but also other potentially useful properties of the created method -- static, virtual, etc.).

Sep 2 2020, 3:46 PM

Aug 31 2020

amccarth accepted D86701: [LLD] [COFF] Error out if creating a DLL with too many exported symbols.

I like it.

Aug 31 2020, 8:57 AM · Restricted Project

Aug 28 2020

amccarth added a comment to D86762: [ELF] Add documentation for --warn-backrefs: a GNU ld compatibility checking tool (and lesser of layering detection).

Is there a more specific term than "traditional linker"?

Aug 28 2020, 9:02 AM · Restricted Project

Aug 27 2020

amccarth added a comment to D86701: [LLD] [COFF] Error out if creating a DLL with too many exported symbols.

The change looks fine.

Aug 27 2020, 9:35 AM · Restricted Project

Aug 26 2020

amccarth accepted D86659: [LLD] [COFF] Check the aux section definition size for IMAGE_COMDAT_SELECT_SAME_SIZE.

Oops, I forgot to "Accept Revision."

Aug 26 2020, 2:56 PM · Restricted Project
amccarth added a comment to D86659: [LLD] [COFF] Check the aux section definition size for IMAGE_COMDAT_SELECT_SAME_SIZE.

Not my area of expertise, but this looks good to me. Before submitting, please make sure you update the commit description since you didn't end up adding any fields to SectionChunk.

Aug 26 2020, 2:55 PM · Restricted Project
amccarth accepted D86654: [LLD] [MinGW] Enable dynamicbase by default.

LGTM.

Aug 26 2020, 2:34 PM · Restricted Project
amccarth accepted D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle().

LGTM

Aug 26 2020, 9:47 AM · Restricted Project
amccarth requested changes to D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle().

I know it's not part of this patch, but Phabricator is showing a clang-tidy lint error on the inclusion of <io.h>. While Windows does have one of these, it's only a compatibility hack, and it doesn't seem to be needed. Can you yank that #include <io.h> line before submitting?

Aug 26 2020, 8:57 AM · Restricted Project

Aug 14 2020

amccarth requested review of D85993: [lldb] Set the access property on member function decls.
Aug 14 2020, 1:24 PM

Aug 13 2020

amccarth closed D84815: [LLDB] Improve PDB discovery.

Landed on Tuesday. I must have messed up the Differential Revision: line.

Aug 13 2020, 4:17 PM

Aug 12 2020

amccarth committed rG7ddfb956e1a5: [lldb] Fix unit test parsing to handle CR+LF as well as LF (authored by amccarth).
[lldb] Fix unit test parsing to handle CR+LF as well as LF
Aug 12 2020, 1:56 PM

Aug 11 2020

amccarth committed rG479f5bfdb02b: [LLDB] Improve PDB discovery (authored by amccarth).
[LLDB] Improve PDB discovery
Aug 11 2020, 1:45 PM
amccarth added a comment to D85745: emit int32 for each version part.

If you make the second loop consistent, I'll approve, despite my concerns about the related problems.

Aug 11 2020, 11:02 AM · Restricted Project

Aug 10 2020

amccarth added a comment to D85669: Fix "last accessed time" test failing on Windows.

I'm OK with this.

In an ideal world, it would be nice to ensure stripping preserves other the Windows creation timestamp while updating the last modification timestamp.

Thanks Adrian. The "last modification time" is preserved with llvm-strip -p, see llvm\test\tools\llvm-objcopy\ELF\strip-preserve-mtime.test which works fine (if that's what you meant).

Aug 10 2020, 1:56 PM · Restricted Project
amccarth accepted D85669: Fix "last accessed time" test failing on Windows.
Aug 10 2020, 11:42 AM · Restricted Project
amccarth added a comment to D85669: Fix "last accessed time" test failing on Windows.

I'm OK with this.

Aug 10 2020, 11:42 AM · Restricted Project
amccarth accepted D85633: [lldb][NFC] Remove unused custom reimplementation of realpath for Windows.

Nice.

Aug 10 2020, 9:26 AM · Restricted Project

Aug 7 2020

amccarth added a comment to D85480: [NFC] Use value initializer for OVERLAPPED.

OK, I see. I was looking at the wrong field.

Aug 7 2020, 5:02 PM · Restricted Project
amccarth added a comment to D85480: [NFC] Use value initializer for OVERLAPPED.

Huh, I thought aggregate initialization was effectively zero-initialization for the remaining fields, so I'm surprised this changes anything. I would have expected the original line, which is idiomatic in Win32 code, to have zero-initialized all of the fields.

Aug 7 2020, 4:48 PM · Restricted Project
amccarth updated the diff for D84815: [LLDB] Improve PDB discovery.

Added test to check locating the PDB either in the original build directory or adjacent to the executable.

Aug 7 2020, 1:36 PM

Aug 4 2020

amccarth accepted D85183: [llvm-rc] Allow string table values split into multiple string literals.

OK, makes sense. I was hoping the processing could happen as you build up the concatenated string rather than at the end. But now I see the design doesn't really allow for that.

Aug 4 2020, 1:47 PM · Restricted Project
amccarth added a comment to D85183: [llvm-rc] Allow string table values split into multiple string literals.

I'll defer to @thakis, but I have a couple suggestions inline.

Aug 4 2020, 9:59 AM · Restricted Project

Aug 3 2020

amccarth added a comment to D84423: [lit] Allow lit.which() to find executables which already have an extension.

Well then, since Reid is out, this is good to go! :-)

Aug 3 2020, 10:26 AM · Restricted Project
amccarth accepted D84380: [lit] Support running tests on Windows without GnuWin32..

I have a couple responses, but nothing worth blocking this path for. LGTM, and thanks for doing this!

Aug 3 2020, 10:23 AM · Restricted Project

Jul 30 2020

amccarth added a comment to D84815: [LLDB] Improve PDB discovery.

Thanks. Working on a test.

Jul 30 2020, 8:06 AM

Jul 29 2020

amccarth accepted D84757: [compiler-rt] [profile] fix profile generate for mingw x86_64.

LGTM.

Jul 29 2020, 8:50 AM · Restricted Project

Jul 28 2020

amccarth updated the diff for D84815: [LLDB] Improve PDB discovery.

Fixed typos in comments.

Jul 28 2020, 6:32 PM
amccarth requested review of D84815: [LLDB] Improve PDB discovery.
Jul 28 2020, 6:14 PM
amccarth accepted D84701: [LLD] [MinGW] Implement the --no-seh flag.

LGTM!

Jul 28 2020, 8:22 AM · Restricted Project

Jul 27 2020

amccarth added a comment to D84701: [LLD] [MinGW] Implement the --no-seh flag.

This is probably fine, be I have an inline comment with some questions.

Jul 27 2020, 3:31 PM · Restricted Project
amccarth accepted D78896: [Support] Add file lock/unlock functions.

As I noted on April 30, I'm OK with the Windows portions of this. I didn't explicitly "Accept" because I didn't want to pre-empt the concerns of the other reviewers.

Jul 27 2020, 10:33 AM · Restricted Project

Jul 23 2020

amccarth accepted D84423: [lit] Allow lit.which() to find executables which already have an extension.

This looks fine to me. Is there a lit expert/owner who should also review?

Jul 23 2020, 11:22 AM · Restricted Project
amccarth requested changes to D84380: [lit] Support running tests on Windows without GnuWin32..

I'm okay with the idea. I haven't used GnuWin32 in long while since I already have Git's usr/bin in my PATH. See detailed comments inline.

Jul 23 2020, 10:52 AM · Restricted Project

Jul 22 2020

amccarth accepted D84286: [Symbolize][PDB] Switch llvm-symbolizer to use PDB_ReaderType::Native..

Fingers crossed...

Jul 22 2020, 8:29 AM · Restricted Project

Jul 21 2020

amccarth accepted D84208: [PDB][NativeSession] Clean up some things in NativeSession..

The naming improvements really help. And it's nice to see the symbol tag set correctly (rather than generically only to be overridden). Nice work.

Jul 21 2020, 4:00 PM · Restricted Project
amccarth added a comment to rGd4020ef7c474: [Windows] Fix limit on command line size.

It seems @sepavloff has already reverted, so I'll assume they'll fix it.

Jul 21 2020, 3:43 PM
amccarth added a comment to D83772: [Windows] Fix limit on command line size.

This commit is now failing LLDB Windows buildbot builds http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17702. Please fix or revert.

E:\build_slave\lldb-x64-windows-ninja\llvm-project\lldb\source\Host\windows\ProcessLauncherWindows.cpp(53): error C2679: binary '=': no operator found which takes a right-hand operand of type 'llvm::ErrorOr<std::wstring>' (or there is no acceptable conversion)
Jul 21 2020, 3:00 PM · Restricted Project, Restricted Project
amccarth added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Just a few days ago, I landed another single file /bigobj to get some LLDB tests running: https://reviews.llvm.org/rG14dde438d69c81ab4651157a94d32e5555e804ff

Jul 21 2020, 2:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 17 2020

amccarth accepted D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol.

LGTM. That was a nice catch on the other review.

Jul 17 2020, 1:47 PM · Restricted Project
amccarth committed rG14dde438d69c: With MSVC, file needs to be compiled with /BIGOBJ (authored by amccarth).
With MSVC, file needs to be compiled with /BIGOBJ
Jul 17 2020, 9:43 AM
amccarth closed D83991: With MSVC, file needs to be compiled with /BIGOBJ.
Jul 17 2020, 9:43 AM · Restricted Project

Jul 16 2020

amccarth created D83991: With MSVC, file needs to be compiled with /BIGOBJ.
Jul 16 2020, 3:25 PM · Restricted Project
amccarth committed rG72958c9ab1cd: [lldb] Eliminated unused local variable (authored by amccarth).
[lldb] Eliminated unused local variable
Jul 16 2020, 3:02 PM
amccarth accepted D83881: [lldb/COFF] Remove strtab zeroing hack.

Thanks @mstorsjo for clarifying for me.

Jul 16 2020, 11:46 AM · Restricted Project

Jul 15 2020

amccarth added a comment to D83881: [lldb/COFF] Remove strtab zeroing hack.

Yes, getting rid of this hack looks like a good idea. If it was actually necessary, there should have been a test on it, and the comments should have been clearer.

Jul 15 2020, 9:59 AM · Restricted Project
amccarth accepted D83772: [Windows] Fix limit on command line size.

Thanks! I know it was more work, but I think unifying the command line generation to work the same in both cases will avoid future surprises.

Jul 15 2020, 8:15 AM · Restricted Project, Restricted Project

Jul 14 2020

amccarth accepted D83720: [LLD] [MinGW] Implement the --file-alignment and --section-alignment options.

Sorry, I thought I had LGTM'ed yesterday. I guess the Submit didn't take.

Jul 14 2020, 2:03 PM · Restricted Project
amccarth added a reviewer for D83772: [Windows] Fix limit on command line size: amccarth.
Jul 14 2020, 1:39 PM · Restricted Project, Restricted Project
amccarth added a comment to D83772: [Windows] Fix limit on command line size.

I'm jumping in since rnk is on leave and (I believe) zturner is less focused on these issues than he used to be.

Jul 14 2020, 1:39 PM · Restricted Project, Restricted Project

Jul 13 2020

amccarth added a comment to D83721: [LLD] [MinGW] Ignore the --[no-]allow-shlib-undefined option.

I don't have enough background here, so I'll defer to the decision of other reviewers whether this makes sense. @ruiu ?

Jul 13 2020, 4:38 PM · Restricted Project

Jul 1 2020

amccarth accepted D81950: [NativeSession] Add column numbers to NativeLineNumber..

LGTM

Jul 1 2020, 3:09 PM · Restricted Project

Jun 30 2020

amccarth accepted D82542: [Support][Windows] Prevent 2s delay when renaming a file that does not exist.

LGTM. Thanks!

Jun 30 2020, 9:44 AM · Restricted Project

Jun 25 2020

amccarth added a comment to D82542: [Support][Windows] Prevent 2s delay when renaming a file that does not exist.

rnk is on leave, so I'll jump in.

Jun 25 2020, 11:54 AM · Restricted Project
amccarth edited reviewers for D82542: [Support][Windows] Prevent 2s delay when renaming a file that does not exist, added: amccarth; removed: rnk.
Jun 25 2020, 11:54 AM · Restricted Project

Jun 24 2020

amccarth added a comment to D81950: [NativeSession] Add column numbers to NativeLineNumber..

Very close now. It looks like the change I requested led to a bug. Once that's corrected, this'll look great.

Jun 24 2020, 5:24 PM · Restricted Project

Jun 22 2020

amccarth accepted D82265: [llvm-rc] Implement the language id option.
Jun 22 2020, 11:17 AM · Restricted Project

Jun 16 2020

amccarth added a comment to D81950: [NativeSession] Add column numbers to NativeLineNumber..

This looks right, but I'd like to see a test.

Jun 16 2020, 5:01 PM · Restricted Project

Jun 15 2020

amccarth accepted D80962: [NativeSession] Implement findLineNumbersByAddress functions for native llvm-symbolizer support..

LGTM.

Jun 15 2020, 2:54 PM · Restricted Project
amccarth added a reviewer for D81803: [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive: inglorion.
Jun 15 2020, 2:20 PM · Restricted Project
amccarth updated subscribers of D81803: [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive.

That commit (which was reviewed here https://reviews.llvm.org/D48051) suggests this wasn't about the occasional temp file not getting deleted. It was to work around surprising behavior on Windows when a temp file is mapped into memory, which, as I recall, was the underlying cause in what appeared to be cache corruption for LTO.

Jun 15 2020, 2:20 PM · Restricted Project
amccarth accepted D81794: [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally.

Thanks. This seems well-contained and the test changes look good.

Jun 15 2020, 9:45 AM · Restricted Project
amccarth added inline comments to D80962: [NativeSession] Implement findLineNumbersByAddress functions for native llvm-symbolizer support..
Jun 15 2020, 9:13 AM · Restricted Project

Jun 12 2020

amccarth added a comment to D81041: Use existing path sep style in clang::FileManager::FixupRelativePath.

After some further investigation, I have come to believe that the root cause of the issue I am seeing is on line 783 of clang/lib/Lex/HeaderSearch.cpp. A path is constructed using string concatenation (dir + '/' + file), which is obviously not robust to the various issues in path construction. A fix had been committed and reverted back in 2015.

Jun 12 2020, 3:58 PM · Restricted Project
amccarth accepted D80833: [CodeView] Add full repro to LF_BUILDINFO record.

My only real concern was about the possible reproducibility impact of introducing absolute paths into the binaries. If @thakis and @hans are satisfied this is OK, then LGTM.

Jun 12 2020, 3:58 PM · Restricted Project, Restricted Project
amccarth added a comment to D80962: [NativeSession] Implement findLineNumbersByAddress functions for native llvm-symbolizer support..

Sorry about my review latency.

Jun 12 2020, 3:58 PM · Restricted Project

Jun 3 2020

amccarth added a comment to D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output..

I'm just responding to the questions @labath raised without really looking at the details of the code.

Jun 3 2020, 9:53 AM · Restricted Project
amccarth added a comment to D81041: Use existing path sep style in clang::FileManager::FixupRelativePath.

Please make sure all of the clang VFS tests still pass before submitted this. VFS paths are inherently problematic with llvm::sys::path because they can legitimately be in a hybrid of Windows and Posix styles. Guessing the style from the first separator you see can be misleading, but I don't know whether that's ever wrong in this path.

Jun 3 2020, 8:45 AM · Restricted Project
amccarth added a comment to D80833: [CodeView] Add full repro to LF_BUILDINFO record.

The change description says something about PWD

Jun 3 2020, 8:44 AM · Restricted Project, Restricted Project

Jun 2 2020

amccarth added a comment to D80833: [CodeView] Add full repro to LF_BUILDINFO record.

Does the full path to the tool end up only in the object file, or does this make it all the way to the final executable or library? Does embedding full paths affect distributed builds or build reproducibility?

Jun 2 2020, 11:32 AM · Restricted Project, Restricted Project

Jun 1 2020

amccarth accepted D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt.

Yowza. Mingw still links against MSVCRT?!

Jun 1 2020, 11:52 AM · Restricted Project

May 27 2020

amccarth committed rG2d068e534f16: Fix Windows command line bug when last token in response file is "" (authored by amccarth).
Fix Windows command line bug when last token in response file is ""
May 27 2020, 3:17 PM
amccarth closed D78346: Fix Windows command line bug when last token in response file is "".
May 27 2020, 3:17 PM · Restricted Project
amccarth added a comment to D78346: Fix Windows command line bug when last token in response file is "".

No problem. I'll land it this afternoon (Pacific time). Thanks!

May 27 2020, 1:02 PM · Restricted Project
amccarth added inline comments to D80554: [DebugInfo] Use SplitTemplateClosers (foo<bar<baz> >) in DWARF too.
May 27 2020, 1:02 PM · Restricted Project
amccarth accepted D78346: Fix Windows command line bug when last token in response file is "".

Ah, I guess the diff was based off the old head rather than the rebased one. Phabricator highlighted all that code as part of this patch.

May 27 2020, 9:11 AM · Restricted Project

May 26 2020

amccarth added inline comments to D80554: [DebugInfo] Use SplitTemplateClosers (foo<bar<baz> >) in DWARF too.
May 26 2020, 11:58 AM · Restricted Project