This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add scheduler classes to Zfh instructions.
ClosedPublic

Authored by craig.topper on Mar 21 2021, 11:28 PM.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 21 2021, 11:28 PM
craig.topper requested review of this revision.Mar 21 2021, 11:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2021, 11:28 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
craig.topper added inline comments.Mar 22 2021, 3:57 PM
llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td
89

Does anyone know why we have different classes for FMADD and FMSUB? It doesn't seem like they are likely to be different.

HsiangKai added inline comments.Mar 22 2021, 7:01 PM
llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td
89

I agree. We should combine them into something like WriteFMulAddSub.

HsiangKai accepted this revision.Mar 22 2021, 7:21 PM

We could have another patch to simplify WriteFMulSubxx and WriteFMulAddxx. This patch is LGTM.

This revision is now accepted and ready to land.Mar 22 2021, 7:21 PM
This revision was landed with ongoing or failed builds.Mar 22 2021, 8:42 PM
This revision was automatically updated to reflect the committed changes.