Page MenuHomePhabricator

[AMDGPU] Split dot2-insts feature
ClosedPublic

Authored by foad on Mar 16 2021, 9:10 AM.

Details

Summary

Split out some of the instructions predicated on the dot2-insts target
feature into a new dot7-insts, in preparation for subtargets that have
some but not all of these instructions. NFCI.

Diff Detail

Event Timeline

foad created this revision.Mar 16 2021, 9:10 AM
foad requested review of this revision.Mar 16 2021, 9:10 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 16 2021, 9:10 AM
arsenm added inline comments.Mar 16 2021, 9:43 AM
llvm/lib/Target/AMDGPU/AMDGPU.td
511

I'm not sure where the "7" is coming from

foad added inline comments.Mar 16 2021, 9:48 AM
llvm/lib/Target/AMDGPU/AMDGPU.td
511

It's the next number after 6. I don't think any of the dotN-insts numbers have any real meaning.

rampitec accepted this revision.Mar 16 2021, 9:49 AM

LGTM. Thanks Jay!

llvm/lib/Target/AMDGPU/AMDGPU.td
511

Just the next number.

This revision is now accepted and ready to land.Mar 16 2021, 9:49 AM
This revision was landed with ongoing or failed builds.Mar 17 2021, 2:42 AM
This revision was automatically updated to reflect the committed changes.