This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Finalize SIMD names and opcodes
ClosedPublic

Authored by tlively on Mar 15 2021, 7:14 PM.

Details

Summary

Updates the names (e.g. widen => extend, saturate => sat) and opcodes of all
SIMD instructions to match the finalized SIMD spec. Deliberately does not change
the public interface in wasm_simd128.h yet; that will require more care.

Depends on D98466.

Diff Detail

Event Timeline

tlively created this revision.Mar 15 2021, 7:14 PM
tlively requested review of this revision.Mar 15 2021, 7:14 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 15 2021, 7:14 PM
aheejin accepted this revision.Mar 16 2021, 5:15 PM
aheejin added inline comments.
llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
1243–1244

If they are finalized, can we delete these "prototype" comments here and elsewhere? (not necessarily in this CL)

This revision is now accepted and ready to land.Mar 16 2021, 5:15 PM
tlively added inline comments.Mar 16 2021, 6:45 PM
llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
1243–1244

Yes, this definitely makes sense. I think I will leave it for future patches that also replace the intrinsics with proper patterns where applicable, though.

This revision was landed with ongoing or failed builds.Mar 18 2021, 11:22 AM
This revision was automatically updated to reflect the committed changes.