Page MenuHomePhabricator

tlively (Thomas Lively)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:54 AM (242 w, 5 d)

Recent Activity

Wed, Mar 22

tlively added a comment to D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll.

Yeah, I agree that many tests are better with smaller, manually written expectations. For these particular tests, the generated expectations aren't that long and are easy to scan for the expected instructions. Using the full output also helps show that the arguments, epilogues, and other surrounding code looks good as well.

Wed, Mar 22, 9:33 AM · Restricted Project, Restricted Project
tlively committed rGdd0bbae5efa4: [WebAssembly] Fix epilogue insertion for indirect tail calls (authored by tlively).
[WebAssembly] Fix epilogue insertion for indirect tail calls
Wed, Mar 22, 9:29 AM · Restricted Project, Restricted Project
tlively closed D146569: [WebAssembly] Fix epilogue insertion for indirect tail calls.
Wed, Mar 22, 9:28 AM · Restricted Project, Restricted Project
tlively added a comment to D146569: [WebAssembly] Fix epilogue insertion for indirect tail calls.

Someone uploaded a CL fixing this a while ago (D142615), and not sure why they didn't land it. Anyway LGTM.

Wed, Mar 22, 9:25 AM · Restricted Project, Restricted Project
tlively committed rG0528087663f1: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll (authored by tlively).
[NFC][WebAssembly] Autogenerate test expectations for tailcall.ll
Wed, Mar 22, 9:21 AM · Restricted Project, Restricted Project
tlively closed D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll.
Wed, Mar 22, 9:21 AM · Restricted Project, Restricted Project

Tue, Mar 21

tlively added inline comments to D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll.
Tue, Mar 21, 2:51 PM · Restricted Project, Restricted Project
tlively accepted D146533: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue feature is enabled.
Tue, Mar 21, 2:48 PM · Restricted Project, Restricted Project
tlively requested review of D146569: [WebAssembly] Fix epilogue insertion for indirect tail calls.
Tue, Mar 21, 2:47 PM · Restricted Project, Restricted Project
tlively requested review of D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll.
Tue, Mar 21, 2:43 PM · Restricted Project, Restricted Project
tlively accepted D146499: [Webassembly][multivalue] update libcall signature for f128 when multivalue feature enabled.
Tue, Mar 21, 8:08 AM · Restricted Project, Restricted Project

Mon, Mar 20

tlively added a comment to D146424: [WebAssembly] Add auto-upgrade for renamed intrinsics.

Got it, thanks.

Mon, Mar 20, 9:18 AM · Restricted Project, Restricted Project
tlively added a comment to D146084: [WebAssembly] Add comments on local.tee transformation.

Oh oops, I had written a response but then I never clicked "submit." Sorry about that.

Mon, Mar 20, 8:57 AM · Restricted Project, Restricted Project
tlively accepted D146424: [WebAssembly] Add auto-upgrade for renamed intrinsics.

Thanks! I didn't know about this functionality. Is there a generally accepted mechanism to mark intrinsics as experimental so that there is no expectation that they will be auto-upgraded like this?

Mon, Mar 20, 8:42 AM · Restricted Project, Restricted Project
tlively added a comment to D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.

Code LGTM, although it looks like there may be some missing cases reported in https://github.com/llvm/llvm-project/issues/59095. Testing the end-to-end integration here might be a good thing to do in cross-project-tests.

Mon, Mar 20, 8:39 AM · Restricted Project, Restricted Project
tlively accepted D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.
Mon, Mar 20, 8:32 AM · Restricted Project, Restricted Project

Fri, Mar 17

tlively added a comment to D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.

LGTM besides using the test update script.

Fri, Mar 17, 11:10 AM · Restricted Project, Restricted Project
tlively added a comment to D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.

For the description, here's some possible clearer wording:

Fri, Mar 17, 8:06 AM · Restricted Project, Restricted Project

Wed, Mar 15

tlively accepted D146084: [WebAssembly] Add comments on local.tee transformation.

LGTM % language tweaks!

Wed, Mar 15, 8:10 AM · Restricted Project, Restricted Project

Wed, Mar 1

tlively accepted D144619: [WebAssembly] Skip implied bitmask operation in LowerShift.

Great, thank you!

Wed, Mar 1, 8:32 AM · Restricted Project, Restricted Project

Tue, Feb 28

tlively added a comment to D139010: [clang][WebAssembly] Implement support for table types and builtins.

Roping in @jfb because I know he's been heavily involve in WebAssembly in the past and he may have ideas/opinions.

High-level question: are externref, funcref, and table types all part of the WebAssembly standard, or are these extensions? (I wasn't aware that WebAssembly was a W3C standard or I'd have been asking this question much earlier -- sorry for that! I'm asking in regards to #4 in https://clang.llvm.org/get_involved.html#criteria)

Tue, Feb 28, 11:27 AM · Restricted Project, Restricted Project, Restricted Project
tlively added a comment to D144619: [WebAssembly] Skip implied bitmask operation in LowerShift.

Thanks for the ping! Sorry this fell through the cracks.

Tue, Feb 28, 7:03 AM · Restricted Project, Restricted Project

Feb 21 2023

tlively added a comment to D141926: [WebAssembly] Add passes for GEP lowering.

The clang driver will automatically call wasm-opt if it finds it in your PATH, so it's worth checking whether wasm-opt is being run or not.

Feb 21 2023, 8:40 AM · Restricted Project, Restricted Project
tlively accepted D144466: [WebAssembly] Revert result operand ordering for pmin/pmax.

Yes, pmin is rhs < lhs ? rhs : lhs and pmax is lhs < rhs ? rhs : lhs, so if either input is NaN, the result for either operation should be lhs. IIUC, before this patch NaN inputs would result in rhs instead.

Feb 21 2023, 8:28 AM · Restricted Project, Restricted Project
tlively accepted D144360: [WebAssembly] Add more combine pattern for vector shift.

Great, thank you!

Feb 21 2023, 7:57 AM · Restricted Project, Restricted Project

Feb 17 2023

tlively added a comment to D143581: [WebAssembly] Additional patterns for pmin/pax.

I don't think this is correct with respect to NaN vector elements. SIMDe is getting test failures starting with this commit, reported here: https://github.com/emscripten-core/emscripten/issues/18759

Feb 17 2023, 2:43 PM · Restricted Project, Restricted Project

Feb 16 2023

tlively accepted D144169: [WebAssembly] Fix simd bit shift intrinsics codegen.

LGTM, thanks!

Feb 16 2023, 7:50 AM · Restricted Project, Restricted Project

Feb 6 2023

tlively added a comment to D141926: [WebAssembly] Add passes for GEP lowering.

Impressive performance wins! How is code size affected?

Feb 6 2023, 7:25 AM · Restricted Project, Restricted Project

Jan 13 2023

tlively added a comment to D133574: [C2x] reject type definitions in offsetof.

FWIW I had to patch the musl used by Emscripten to work around this: https://github.com/emscripten-core/emscripten/pull/18510

Jan 13 2023, 9:34 AM · Restricted Project, Restricted Project

Jan 5 2023

tlively added a comment to D141079: [DAGCombine] Fold constants across (extract_vector_elt (bitcast (splat_vector))).

Could you add a test showing the regression in a preliminary patch so that we can see the improvement in this patch?

Jan 5 2023, 12:19 PM · Restricted Project, Restricted Project
tlively accepted D140773: [WebAssembly] Use `shufflevector` for shuffle.
Jan 5 2023, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

tlively accepted D140773: [WebAssembly] Use `shufflevector` for shuffle.

LGTM % comment. Thanks for taking this!

Jan 3 2023, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
tlively accepted D140916: [WebAssembly] Explicitly add {z,s}ext so extends are selected.

Nice!

Jan 3 2023, 12:44 PM · Restricted Project, Restricted Project
tlively accepted D139871: [WebAssembly] Replace LOAD_SPLAT with SPLAT_VECTOR.

LGTM

Jan 3 2023, 12:39 PM · Restricted Project, Restricted Project
tlively added inline comments to D139871: [WebAssembly] Replace LOAD_SPLAT with SPLAT_VECTOR.
Jan 3 2023, 12:35 PM · Restricted Project, Restricted Project

Dec 12 2022

tlively added a comment to D139871: [WebAssembly] Replace LOAD_SPLAT with SPLAT_VECTOR.

Nice, it's good to use the builtin nodes where possible. I think we had intentionally selected splats of constants into constant vectors for performance reasons. Would you be able to preserve that behavior and make this a non-functional change?

Dec 12 2022, 12:12 PM · Restricted Project, Restricted Project

Dec 9 2022

tlively accepted D139631: [WebAssembly][NFC] Add ComplexPattern for loads.

LGTM. It definitely makes the tablegen simpler, and I think the C++ isn't that complicated.

Dec 9 2022, 7:59 AM · Restricted Project, Restricted Project
tlively added inline comments to D139415: [RFC][WebAssembly] Optimize GEPs.
Dec 9 2022, 7:44 AM · Restricted Project, Restricted Project

Dec 7 2022

tlively added inline comments to D139530: [WebAssembly] Add ComplexPattern for loads.
Dec 7 2022, 10:46 AM · Restricted Project, Restricted Project
tlively added inline comments to D139415: [RFC][WebAssembly] Optimize GEPs.
Dec 7 2022, 10:18 AM · Restricted Project, Restricted Project

Dec 6 2022

tlively added a reviewer for D139415: [RFC][WebAssembly] Optimize GEPs: aheejin.
Dec 6 2022, 8:12 AM · Restricted Project, Restricted Project

Nov 23 2022

tlively accepted D138569: [WebAssembly] Remove unnecessary GEP insts from table tests.
Nov 23 2022, 6:30 AM · Restricted Project, Restricted Project

Nov 21 2022

tlively committed rGae96b5bd2dd0: [WebAssembly] Update relaxed-simd instruction names (authored by tlively).
[WebAssembly] Update relaxed-simd instruction names
Nov 21 2022, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
tlively closed D138249: [WebAssembly] Update relaxed-simd instruction names.
Nov 21 2022, 12:40 PM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2022

tlively updated the diff for D138249: [WebAssembly] Update relaxed-simd instruction names.
  • Fix type
Nov 18 2022, 8:24 AM · Restricted Project, Restricted Project, Restricted Project
tlively added inline comments to D138249: [WebAssembly] Update relaxed-simd instruction names.
Nov 18 2022, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2022

tlively requested review of D138249: [WebAssembly] Update relaxed-simd instruction names.
Nov 17 2022, 5:17 PM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

tlively accepted D137824: [WebAssembly] multivalue stackify fix.

LGTM, thanks!

Nov 15 2022, 2:18 PM · Restricted Project, Restricted Project

Nov 14 2022

tlively added a comment to D137824: [WebAssembly] multivalue stackify fix.

I don't know if you've seen it, but we have a multivalue-stackify.py script that tries to exhaustively enumerate multivalue sequences up to a certain size then filter out the uninteresting ones.

Cool! My python isn't great tbh... but looking through the generated test, I would have thought that f141 may have triggered this bug:

%t0 = call {i32, i32} @op_0_to_2()
%t1 = extractvalue {i32, i32} %t0, 1
call void @op_1_to_0(i32 %t1)
%t2 = extractvalue {i32, i32} %t0, 0
call void @op_1_to_0(i32 %t2)
ret void
%0:i32, %1:i32 = CALL @op_0_to_2, implicit-def dead $arguments, implicit $sp32, implicit $sp64, implicit-def dead $arguments, implicit $sp32, implicit $sp64
CALL @op_1_to_0, %1, implicit-def dead $arguments, implicit $sp32, implicit $sp64, implicit-def dead $arguments, implicit $sp32, implicit $sp64
CALL @op_1_to_0, %0, implicit-def dead $arguments, implicit $sp32, implicit $sp64, implicit-def dead $arguments, implicit $sp32, implicit $sp64
RETURN implicit-def dead $arguments

Is it the fact that the users are calls and this prevents a move from being attempted..?

Nov 14 2022, 5:39 PM · Restricted Project, Restricted Project

Nov 11 2022

tlively added a comment to D137824: [WebAssembly] multivalue stackify fix.

I don't know if you've seen it, but we have a multivalue-stackify.py script that tries to exhaustively enumerate multivalue sequences up to a certain size then filter out the uninteresting ones. The output is checked in as the multivalue-stackify.ll test. It may be worth playing around with that script so that it generates programs that exhibit this problem.

Nov 11 2022, 9:56 AM · Restricted Project, Restricted Project
tlively added inline comments to D137824: [WebAssembly] multivalue stackify fix.
Nov 11 2022, 9:32 AM · Restricted Project, Restricted Project

Nov 7 2022

tlively accepted D137551: [WebAssembly] Use default attributes for intrinsics.
Nov 7 2022, 7:44 AM · Restricted Project, Restricted Project
tlively accepted D137551: [WebAssembly] Use default attributes for intrinsics.

LGTM % comment. Thanks!

Nov 7 2022, 7:15 AM · Restricted Project, Restricted Project

Oct 13 2022

tlively added a comment to D135831: [lld][WebAssembly] Add `--extra-features` flag to add addional features.

It seems kind of strange to have features be free form strings rather than a set of flags, but maybe that's appropriate at this stage. It's certainly more flexible.

But that direction was already taken with the existing --features= flag right? I'm not adding that concept here.

Oct 13 2022, 9:40 AM · Restricted Project, Restricted Project
tlively accepted D135831: [lld][WebAssembly] Add `--extra-features` flag to add addional features.

It seems kind of strange to have features be free form strings rather than a set of flags, but maybe that's appropriate at this stage. It's certainly more flexible.

Oct 13 2022, 9:10 AM · Restricted Project, Restricted Project

Oct 3 2022

tlively accepted D135005: [WebAssembly] Fix return type of __builtin_return_address under wasm64.
Oct 3 2022, 8:19 AM · Restricted Project, Restricted Project

Sep 26 2022

tlively accepted D134436: [WebAssembly] Use intrinsics for table.get/set instructions.

LGTM!

Sep 26 2022, 11:39 AM · Restricted Project, Restricted Project

Sep 21 2022

tlively committed rG8a2729fea719: [WebAssembly] Improve codegen for loading scalars from memory to v128 (authored by fanchenkong1).
[WebAssembly] Improve codegen for loading scalars from memory to v128
Sep 21 2022, 9:06 PM · Restricted Project, Restricted Project
tlively closed D134257: [WebAssembly] Improve codegen for loading scalars from memory to v128.
Sep 21 2022, 9:05 PM · Restricted Project, Restricted Project
tlively added inline comments to D134257: [WebAssembly] Improve codegen for loading scalars from memory to v128.
Sep 21 2022, 8:56 PM · Restricted Project, Restricted Project
tlively accepted D134257: [WebAssembly] Improve codegen for loading scalars from memory to v128.

Thanks! Do you need me to land this?

Sep 21 2022, 7:44 AM · Restricted Project, Restricted Project

Sep 20 2022

tlively added inline comments to D134257: [WebAssembly] Improve codegen for loading scalars from memory to v128.
Sep 20 2022, 11:18 AM · Restricted Project, Restricted Project

Sep 13 2022

tlively committed rG28557e8c9872: [WebAssembly] Improve codegen for shuffles with undefined lane indices (authored by fanchenkong1).
[WebAssembly] Improve codegen for shuffles with undefined lane indices
Sep 13 2022, 4:03 PM · Restricted Project, Restricted Project
tlively closed D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.
Sep 13 2022, 4:03 PM · Restricted Project, Restricted Project
tlively added a comment to D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

Yeah the unrelated test failures can be ignored. Good point about our shuffle combine workaround, @penzn. Would you have time and resources to investigate whether we can remove the workaround now?

Sep 13 2022, 4:02 PM · Restricted Project, Restricted Project

Sep 12 2022

tlively added a comment to D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

Sounds good. @fanchenkong1, it would be great if you could expand the comment as @penzn suggested. After that, do you have commit access or would you like me to merge this for you? If you would like me to commit it, what author email should I use for you?

Sep 12 2022, 12:32 PM · Restricted Project, Restricted Project

Sep 9 2022

tlively accepted D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

The code looks good, but I don't know much about native SIMD. Is this strictly better for engine-side codegen on all platforms? LGTM if so.

Sep 9 2022, 6:44 PM · Restricted Project, Restricted Project

Sep 8 2022

tlively committed rGac3b8df8f2f4: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32` (authored by tlively).
[WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`
Sep 8 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project
tlively closed D133428: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`.
Sep 8 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

tlively requested review of D133428: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`.
Sep 7 2022, 8:38 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

tlively added a comment to D128440: [WebAssembly] Initial support for reference type funcref in clang.

It would be good to add tests for more error conditions like in the externref patch and also additional errors like trying to apply __funcref to types that aren't function pointers.

Aug 16 2022, 6:18 PM · Restricted Project, Restricted Project, Restricted Project
tlively added a comment to D122215: [WebAssembly] Initial support for reference type externref in clang.

Very nice! This LGTM with all these small comments addressed. Sorry for the long delay in reviewing.

Aug 16 2022, 5:50 PM · Restricted Project, Restricted Project, Restricted Project
tlively added a comment to D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default.

For reference, the existing error from the backend is something like this:

Aug 16 2022, 3:37 PM · Restricted Project, Restricted Project
tlively added a comment to D128440: [WebAssembly] Initial support for reference type funcref in clang.

Oops, sorry about that. Will take a look.

Aug 16 2022, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
tlively requested review of D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default.
Aug 16 2022, 12:59 PM · Restricted Project, Restricted Project

Aug 3 2022

tlively committed rGb19de814add2: [WebAssembly] Improve codegen for v128.bitselect (authored by tlively).
[WebAssembly] Improve codegen for v128.bitselect
Aug 3 2022, 11:29 PM · Restricted Project, Restricted Project
tlively closed D131131: [WebAssembly] Improve codegen for v128.bitselect.
Aug 3 2022, 11:28 PM · Restricted Project, Restricted Project
tlively requested review of D131131: [WebAssembly] Improve codegen for v128.bitselect.
Aug 3 2022, 5:11 PM · Restricted Project, Restricted Project

Jun 29 2022

tlively accepted D128794: [WebAssembly] Don't set musttail for coroutines is tail call is not enabled.

Nice! LGTM with those comments.

Jun 29 2022, 10:36 AM · Restricted Project, Restricted Project

Jun 27 2022

tlively accepted D128515: [lld][WebAssembly] Don't apply data relocations at static constructor time.
Jun 27 2022, 12:27 PM · Restricted Project, Restricted Project
tlively added a comment to D128163: [Coroutines] Don't add musttail call if WebAssembly are enabled.

I think it would make sense to add a new method to TTI for this, since hardcoding an exception for Wasm is not going to be future-proof at all. The tail-call target feature, while not standard yet, is very close to being standardized and shipped in browsers. It's already available behind a flag in Chrome and Node. Also, if possible, it would be good to perform a different transformation that can still do symmetric transfer without tail calls if the prevailing view is that symmetric transfer is guaranteed by the spec (but simply omitting musttail for now seems like a reasonable stopgap measure).

Jun 27 2022, 12:23 PM · Restricted Project, Restricted Project

Jun 22 2022

tlively added a comment to D128282: [WebAssembly] Update test to run it in opaque pointers mode.

I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different).

Yeah, but the convention used elsewhere in this test file is to use WEBASSEMBLY: (which is a common check prefix for both wasm32 and wasm64 run lines) in the cases where the output is the same.

Jun 22 2022, 9:35 AM · Restricted Project, Restricted Project

Jun 21 2022

tlively accepted D128282: [WebAssembly] Update test to run it in opaque pointers mode.

I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different).

Jun 21 2022, 3:10 PM · Restricted Project, Restricted Project
tlively added a comment to D128163: [Coroutines] Don't add musttail call if WebAssembly are enabled.

Thanks for taking a look at this!

Jun 21 2022, 10:40 AM · Restricted Project, Restricted Project

Jun 8 2022

tlively committed rGaff679a48c43: [WebAssembly] Implement remaining relaxed SIMD instructions (authored by tlively).
[WebAssembly] Implement remaining relaxed SIMD instructions
Jun 8 2022, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
tlively closed D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Jun 8 2022, 10:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2022

tlively updated the diff for D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
  • dot_add takes three operands
Jun 7 2022, 3:25 PM · Restricted Project, Restricted Project, Restricted Project
tlively planned changes to D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Jun 7 2022, 2:16 PM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2022

tlively committed rG576b8245c838: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD (authored by tlively).
[WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD
Jun 6 2022, 5:57 PM · Restricted Project, Restricted Project
tlively closed D127157: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD.
Jun 6 2022, 5:56 PM · Restricted Project, Restricted Project
tlively requested review of D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Jun 6 2022, 5:49 PM · Restricted Project, Restricted Project, Restricted Project
tlively requested review of D127157: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD.
Jun 6 2022, 2:45 PM · Restricted Project, Restricted Project

May 23 2022

tlively accepted D126107: [lld][WebAssembly] Allow first thread to use static TLS region.

Thanks, this makes more sense now. LGTM with fixes and extra information in that comment.

May 23 2022, 2:56 PM · Restricted Project, Restricted Project

May 20 2022

tlively accepted D126104: [lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC.
May 20 2022, 5:37 PM · Restricted Project, Restricted Project
tlively added inline comments to D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
May 20 2022, 5:36 PM · Restricted Project, Restricted Project

May 16 2022

tlively committed rG82a13d05ab71: [WebAssembly] Update relaxed SIMD opcodes and names (authored by tlively).
[WebAssembly] Update relaxed SIMD opcodes and names
May 16 2022, 5:52 PM · Restricted Project, Restricted Project
tlively closed D125726: [WebAssembly] Update relaxed SIMD opcodes and names.
May 16 2022, 5:51 PM · Restricted Project, Restricted Project
tlively accepted D125714: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string.
May 16 2022, 5:47 PM · Restricted Project, Restricted Project
tlively accepted D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string.
May 16 2022, 5:46 PM · Restricted Project, Restricted Project
tlively requested review of D125726: [WebAssembly] Update relaxed SIMD opcodes and names.
May 16 2022, 2:17 PM · Restricted Project, Restricted Project