Page MenuHomePhabricator

tlively (Thomas Lively)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:54 AM (87 w, 5 h)

Recent Activity

Yesterday

tlively committed rG5074776de478: [WebAssembly] Import wasm_simd128.h from Emscripten (authored by tlively).
[WebAssembly] Import wasm_simd128.h from Emscripten
Mon, Mar 30, 5:30 PM
tlively closed D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
Mon, Mar 30, 5:30 PM · Restricted Project
tlively added inline comments to D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
Mon, Mar 30, 5:29 PM · Restricted Project
tlively added a comment to D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.

I believe all the feedback has now been addressed.

Mon, Mar 30, 4:24 PM · Restricted Project
tlively updated the diff for D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
  • Use header guard macro instead of pragma
Mon, Mar 30, 3:17 PM · Restricted Project
tlively updated the diff for D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
  • Prefix identifiers with __
  • Use specific bit-widths where possible
  • Do not change semantics under -funsigned-char
Mon, Mar 30, 2:44 PM · Restricted Project

Fri, Mar 27

tlively added inline comments to D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
Fri, Mar 27, 6:12 PM · Restricted Project
tlively created D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
Fri, Mar 27, 5:05 PM · Restricted Project
tlively updated the diff for D76959: [WebAssembly] Import wasm_simd128.h from Emscripten.
  • Update license to match xmmintrin.h format
Fri, Mar 27, 5:05 PM · Restricted Project

Wed, Mar 25

tlively accepted D76823: [WebAssembly] Add test for event section order change.

Maybe add a comment saying why the new line is important.

Wed, Mar 25, 11:25 PM · Restricted Project
tlively added a comment to D76752: [WebAssembly] Move event section before global section.

Even without running V8 or some other external validator, I agree it's surprising that the change in section order did not cause any tests to change. I guess most of our tests just look at a single section rather than a sequence of sections? And most don't have an events section at all.

Wed, Mar 25, 3:43 PM · Restricted Project
tlively accepted D76752: [WebAssembly] Move event section before global section.

LGTM!

Wed, Mar 25, 11:21 AM · Restricted Project

Sat, Mar 21

tlively committed rGde6cd3e836e1: [WebAssembly] Add SIMD integer abs builtins (authored by tlively).
[WebAssembly] Add SIMD integer abs builtins
Sat, Mar 21, 12:29 AM
tlively closed D76538: [WebAssembly] Add SIMD integer abs builtins.
Sat, Mar 21, 12:29 AM · Restricted Project

Fri, Mar 20

tlively created D76538: [WebAssembly] Add SIMD integer abs builtins.
Fri, Mar 20, 8:03 PM · Restricted Project

Thu, Mar 19

tlively committed rG34db3c3a1847: [WebAssembly] SIMD integer abs instructions (authored by tlively).
[WebAssembly] SIMD integer abs instructions
Thu, Mar 19, 5:35 PM
tlively closed D76399: [WebAssembly] SIMD integer abs instructions.
Thu, Mar 19, 5:35 PM · Restricted Project
tlively committed rGa3f974f3c332: [WebAssembly] SIMD bitmask intrinsics and builtin functions (authored by tlively).
[WebAssembly] SIMD bitmask intrinsics and builtin functions
Thu, Mar 19, 5:35 PM
tlively closed D76397: [WebAssembly] SIMD bitmask intrinsics and builtin functions.
Thu, Mar 19, 5:34 PM · Restricted Project
tlively added inline comments to D76399: [WebAssembly] SIMD integer abs instructions.
Thu, Mar 19, 5:33 PM · Restricted Project

Wed, Mar 18

tlively created D76399: [WebAssembly] SIMD integer abs instructions.
Wed, Mar 18, 6:28 PM · Restricted Project
tlively added a child revision for D76397: [WebAssembly] SIMD bitmask intrinsics and builtin functions: D76399: [WebAssembly] SIMD integer abs instructions.
Wed, Mar 18, 6:28 PM · Restricted Project
tlively created D76397: [WebAssembly] SIMD bitmask intrinsics and builtin functions.
Wed, Mar 18, 5:24 PM · Restricted Project

Thu, Mar 12

tlively committed rG4e589e6c26e3: [WebAssembly] Fix SIMD shift unrolling to avoid assertion failure (authored by tlively).
[WebAssembly] Fix SIMD shift unrolling to avoid assertion failure
Thu, Mar 12, 1:02 PM
tlively closed D76043: [WebAssembly] Fix SIMD shift unrolling to avoid assertion failure.
Thu, Mar 12, 1:01 PM · Restricted Project

Wed, Mar 11

tlively created D76043: [WebAssembly] Fix SIMD shift unrolling to avoid assertion failure.
Wed, Mar 11, 9:50 PM · Restricted Project

Fri, Mar 6

tlively committed rGd43fcd0c0410: [WebAssembly] Add SIMD integer min/max builtins (authored by tlively).
[WebAssembly] Add SIMD integer min/max builtins
Fri, Mar 6, 2:57 PM
tlively closed D75770: [WebAssembly] Add SIMD integer min/max builtins.
Fri, Mar 6, 2:55 PM · Restricted Project
tlively created D75770: [WebAssembly] Add SIMD integer min/max builtins.
Fri, Mar 6, 1:15 PM · Restricted Project

Feb 25 2020

tlively committed rG0906dca493b3: [WebAssembly] Simplify extract_vector lowering (authored by tlively).
[WebAssembly] Simplify extract_vector lowering
Feb 25 2020, 1:58 PM
tlively closed D75005: [WebAssembly] Simplify extract_vector lowering.
Feb 25 2020, 1:58 PM · Restricted Project

Feb 24 2020

tlively added a comment to D75005: [WebAssembly] Simplify extract_vector lowering.

@aheejin I more or less rewrote this, so if you could take another look that would be great.

Feb 24 2020, 5:12 PM · Restricted Project
tlively updated the diff for D75005: [WebAssembly] Simplify extract_vector lowering.
  • Refactor and add better tests
Feb 24 2020, 5:12 PM · Restricted Project
tlively retitled D75005: [WebAssembly] Simplify extract_vector lowering from [WebAssembly] Fix ISel failure with sext_inreg of i32 vector lanes to [WebAssembly] Simplify extract_vector lowering.
Feb 24 2020, 5:12 PM · Restricted Project

Feb 21 2020

tlively created D75005: [WebAssembly] Simplify extract_vector lowering.
Feb 21 2020, 6:00 PM · Restricted Project

Feb 19 2020

tlively committed rG16aabc86e0ab: [WebAssembly] Fix memory bug introduced in 52861809994c (authored by tlively).
[WebAssembly] Fix memory bug introduced in 52861809994c
Feb 19 2020, 3:08 PM
tlively closed D74875: [WebAssembly] Fix memory bug introduced in 52861809994c.
Feb 19 2020, 3:08 PM · Restricted Project
tlively created D74875: [WebAssembly] Fix memory bug introduced in 52861809994c.
Feb 19 2020, 3:06 PM · Restricted Project

Feb 18 2020

tlively committed rGca9ba76481f1: [WebAssembly] Replace all calls with generalized multivalue calls (authored by tlively).
[WebAssembly] Replace all calls with generalized multivalue calls
Feb 18 2020, 4:03 PM
tlively closed D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
Feb 18 2020, 4:03 PM · Restricted Project
tlively added inline comments to D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
Feb 18 2020, 3:20 PM · Restricted Project
tlively committed rG52861809994c: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue (authored by tlively).
[WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue
Feb 18 2020, 2:56 PM
tlively closed D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
Feb 18 2020, 2:56 PM · Restricted Project
tlively added inline comments to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
Feb 18 2020, 2:53 PM · Restricted Project
tlively committed rG9d37f5afac4a: [WebAssembly] Implement multivalue call_indirects (authored by tlively).
[WebAssembly] Implement multivalue call_indirects
Feb 18 2020, 1:51 PM
tlively closed D74191: [WebAssembly] Implement multivalue call_indirects.
Feb 18 2020, 1:51 PM · Restricted Project
tlively committed rGd51910967fd3: Reland "[WebAssembly] Split and recombine multivalue calls for ISel" (authored by tlively).
Reland "[WebAssembly] Split and recombine multivalue calls for ISel"
Feb 18 2020, 1:51 PM
tlively added a reverting change for rG8acedb595d03: Revert "[WebAssembly] Split and recombine multivalue calls for ISel": rGd51910967fd3: Reland "[WebAssembly] Split and recombine multivalue calls for ISel".
Feb 18 2020, 1:50 PM
tlively committed rG7b64a5906006: Reland "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering" (authored by tlively).
Reland "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering"
Feb 18 2020, 1:50 PM
tlively added a reverting change for rG649aba93a271: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering": rG7b64a5906006: Reland "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 18 2020, 1:50 PM
tlively added inline comments to D74191: [WebAssembly] Implement multivalue call_indirects.
Feb 18 2020, 12:54 PM · Restricted Project

Feb 14 2020

tlively added inline comments to D74191: [WebAssembly] Implement multivalue call_indirects.
Feb 14 2020, 1:07 PM · Restricted Project
tlively updated the diff for D74191: [WebAssembly] Implement multivalue call_indirects.
  • Address comments
Feb 14 2020, 1:07 PM · Restricted Project

Feb 13 2020

tlively committed rG918e90559b08: [WebAssembly] Make stack pointer args inhibit tail calls (authored by tlively).
[WebAssembly] Make stack pointer args inhibit tail calls
Feb 13 2020, 4:58 PM
tlively closed D73943: [WebAssembly] Make stack pointer args inhibit tail calls.
Feb 13 2020, 4:57 PM · Restricted Project
tlively added inline comments to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
Feb 13 2020, 4:13 PM · Restricted Project
tlively updated the diff for D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
  • Address comments
Feb 13 2020, 4:12 PM · Restricted Project
tlively added a comment to D73943: [WebAssembly] Make stack pointer args inhibit tail calls.

The langref says (https://llvm.org/docs/LangRef.html#call-instruction) that the tail call marker implies that the callee does not access allocas from the caller. So it seems like it *should* mean that the backend can depend on this property (that you're checking for here). It also means that the frontend should guarantee it as best it knows how, and optimizations should not introduce it (or remove the attribute if they do?)

Feb 13 2020, 3:18 PM · Restricted Project
tlively accepted D74263: [ValueTracking] Improve isKnownNonNaN() to recognize zero splats..

Looks good to me! I don't have enough context to know of any other locations where this could be missed, so I'm not sure whether a helper function would be useful. It could always be added later, anyways.

Feb 13 2020, 1:56 PM · Restricted Project
tlively committed rGe252293d0629: [WebAssembly] Add cbrt function signatures (authored by tlively).
[WebAssembly] Add cbrt function signatures
Feb 13 2020, 1:20 PM
tlively closed D74259: [WebAssembly] Add cbrt function signatures.
Feb 13 2020, 1:20 PM · Restricted Project

Feb 9 2020

tlively added a comment to D74191: [WebAssembly] Implement multivalue call_indirects.

It looks this assumes D71484 and D71496 have not been reverted, right?

Feb 9 2020, 7:33 PM · Restricted Project

Feb 7 2020

tlively added a comment to D74192: [WebAssembly] Replace all calls with generalized multivalue calls.

The Emscripten test suite passes with this change as well.

Feb 7 2020, 3:11 PM · Restricted Project
tlively created D74259: [WebAssembly] Add cbrt function signatures.
Feb 7 2020, 3:11 PM · Restricted Project
tlively updated the diff for D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
  • Update whitespace in tests
Feb 7 2020, 1:57 PM · Restricted Project

Feb 6 2020

tlively added a comment to D74192: [WebAssembly] Replace all calls with generalized multivalue calls.

I want to go through this and fix obvious white space errors in the tests, but the code should be good to go.

Feb 6 2020, 8:55 PM · Restricted Project
tlively added a child revision for D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue: D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
Feb 6 2020, 8:51 PM · Restricted Project
tlively updated the diff for D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
  • Resolve small TODO
Feb 6 2020, 8:51 PM · Restricted Project
tlively created D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
Feb 6 2020, 8:51 PM · Restricted Project
tlively added a parent revision for D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue: D74191: [WebAssembly] Implement multivalue call_indirects.
Feb 6 2020, 8:46 PM · Restricted Project
tlively updated the diff for D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
Feb 6 2020, 8:46 PM · Restricted Project
tlively added a child revision for D74191: [WebAssembly] Implement multivalue call_indirects: D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
Feb 6 2020, 8:46 PM · Restricted Project
tlively created D74191: [WebAssembly] Implement multivalue call_indirects.
Feb 6 2020, 8:42 PM · Restricted Project

Feb 4 2020

tlively committed rG8c3e6af71b8e: [WebAssembly] Add experimental multivalue calling ABI (authored by tlively).
[WebAssembly] Add experimental multivalue calling ABI
Feb 4 2020, 9:23 PM
tlively closed D72972: [WebAssembly] Add experimental multivalue calling ABI.
Feb 4 2020, 9:23 PM · Restricted Project
tlively added inline comments to D72972: [WebAssembly] Add experimental multivalue calling ABI.
Feb 4 2020, 8:47 PM · Restricted Project
tlively committed rG649aba93a271: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering" (authored by tlively).
Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering"
Feb 4 2020, 8:21 PM
tlively added a reverting change for rG3ef169e586f4: [WebAssembly][InstrEmitter] Foundation for multivalue call lowering: rG649aba93a271: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 4 2020, 8:21 PM
tlively closed D73928: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 4 2020, 8:20 PM · Restricted Project
tlively committed rG8acedb595d03: Revert "[WebAssembly] Split and recombine multivalue calls for ISel" (authored by tlively).
Revert "[WebAssembly] Split and recombine multivalue calls for ISel"
Feb 4 2020, 6:49 PM
tlively added a reverting change for rG28857d14a86b: [WebAssembly] Split and recombine multivalue calls for ISel: rG8acedb595d03: Revert "[WebAssembly] Split and recombine multivalue calls for ISel".
Feb 4 2020, 6:49 PM
tlively closed D73927: Revert "[WebAssembly] Split and recombine multivalue calls for ISel".
Feb 4 2020, 6:49 PM · Restricted Project
tlively committed rG27748363da8d: [WebAssembly] Enable recently implemented SIMD operations (authored by tlively).
[WebAssembly] Enable recently implemented SIMD operations
Feb 4 2020, 6:40 PM
tlively closed D73926: [WebAssembly] Enable recently implemented SIMD operations.
Feb 4 2020, 6:40 PM · Restricted Project, Restricted Project
tlively added a comment to D73943: [WebAssembly] Make stack pointer args inhibit tail calls.

It doesn't look like there's anything wasm-specific here. Surely this also inhibits tail calling in other backends too? Are frontends suppost to avoid putting 'tail call' in the IR in this case?

Feb 4 2020, 3:45 PM · Restricted Project

Feb 3 2020

tlively created D73943: [WebAssembly] Make stack pointer args inhibit tail calls.
Feb 3 2020, 9:52 PM · Restricted Project
tlively added inline comments to D72972: [WebAssembly] Add experimental multivalue calling ABI.
Feb 3 2020, 2:54 PM · Restricted Project
tlively planned changes to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.

This patch is still mostly good, but it will have to be rebased on a different approach to supporting multivalue.

Feb 3 2020, 2:43 PM · Restricted Project
tlively created D73928: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 3 2020, 2:43 PM · Restricted Project
tlively added a reverting change for rG3ef169e586f4: [WebAssembly][InstrEmitter] Foundation for multivalue call lowering: D73928: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 3 2020, 2:43 PM
tlively added a child revision for D73927: Revert "[WebAssembly] Split and recombine multivalue calls for ISel": D73928: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 3 2020, 2:43 PM · Restricted Project
tlively created D73927: Revert "[WebAssembly] Split and recombine multivalue calls for ISel".
Feb 3 2020, 2:33 PM · Restricted Project
tlively added a reverting change for rG28857d14a86b: [WebAssembly] Split and recombine multivalue calls for ISel: D73927: Revert "[WebAssembly] Split and recombine multivalue calls for ISel".
Feb 3 2020, 2:33 PM
tlively created D73926: [WebAssembly] Enable recently implemented SIMD operations.
Feb 3 2020, 2:19 PM · Restricted Project, Restricted Project

Jan 24 2020

tlively accepted D73322: [WebAssembly] Update bleeding-edge CPU features.

Sounds good to me!

Jan 24 2020, 9:55 AM · Restricted Project, Restricted Project
tlively accepted D73320: [WebAssembly] Add reference types target feature.
Jan 24 2020, 9:55 AM · Restricted Project, Restricted Project

Jan 23 2020

tlively accepted D73308: [WebAssembly] Fix resume-only case in Emscripten EH.

LGTM! Tested locally and this fixes the problem.

Jan 23 2020, 5:56 PM · Restricted Project

Jan 21 2020

tlively added a comment to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.

@aheejin This should be properly rebased and ready for review as well. Sorry for all the messed up diffs!

Jan 21 2020, 6:20 PM · Restricted Project
tlively updated the diff for D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
  • rebase
Jan 21 2020, 12:32 PM · Restricted Project
tlively committed rG28857d14a86b: [WebAssembly] Split and recombine multivalue calls for ISel (authored by tlively).
[WebAssembly] Split and recombine multivalue calls for ISel
Jan 21 2020, 11:37 AM