Page MenuHomePhabricator

tlively (Thomas Lively)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:54 AM (50 w, 5 d)

Recent Activity

Fri, Jul 19

tlively accepted D65028: [WebAssembly] Compute and export TLS block alignment.

Nice

Fri, Jul 19, 4:32 PM · Restricted Project, Restricted Project

Thu, Jul 18

tlively committed rG6a6f28f7b720: [WebAssembly] Use passive segments by default when memory is shared (authored by tlively).
[WebAssembly] Use passive segments by default when memory is shared
Thu, Jul 18, 2:51 PM
tlively committed rL366504: [WebAssembly] Use passive segments by default when memory is shared.
[WebAssembly] Use passive segments by default when memory is shared
Thu, Jul 18, 2:51 PM
tlively closed D64950: [WebAssembly] Use passive segments by default when memory is shared.
Thu, Jul 18, 2:50 PM · Restricted Project
tlively added inline comments to D64950: [WebAssembly] Use passive segments by default when memory is shared.
Thu, Jul 18, 2:39 PM · Restricted Project
tlively updated the diff for D64950: [WebAssembly] Use passive segments by default when memory is shared.
  • Simplify flags logic
Thu, Jul 18, 2:39 PM · Restricted Project
tlively created D64950: [WebAssembly] Use passive segments by default when memory is shared.
Thu, Jul 18, 2:10 PM · Restricted Project
tlively accepted D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic.

LGTM modulo a test!

Thu, Jul 18, 2:08 PM · Restricted Project, Restricted Project

Tue, Jul 16

tlively accepted D64537: [WebAssembly] Implement thread-local storage (local-exec model).

Nice work!

Tue, Jul 16, 3:00 PM · Restricted Project, Restricted Project
tlively added a comment to D64537: [WebAssembly] Implement thread-local storage (local-exec model).

LGTM apart from one last comment

Tue, Jul 16, 1:08 PM · Restricted Project, Restricted Project

Mon, Jul 15

tlively accepted D64705: [WebAssembly] Add missing utility methods for exnref type.
Mon, Jul 15, 2:53 PM · Restricted Project
tlively accepted D64704: [WebAssembly] Simplify regcopy.mir.
Mon, Jul 15, 2:07 PM · Restricted Project

Fri, Jul 12

tlively added inline comments to D64537: [WebAssembly] Implement thread-local storage (local-exec model).
Fri, Jul 12, 8:30 PM · Restricted Project, Restricted Project
tlively committed rGdb8e36481a21: [WebAssembly] Make pthread imply bulk-memory, mutable-globals (authored by tlively).
[WebAssembly] Make pthread imply bulk-memory, mutable-globals
Fri, Jul 12, 11:24 AM
tlively committed rL365935: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
[WebAssembly] Make pthread imply bulk-memory, mutable-globals
Fri, Jul 12, 11:23 AM
tlively closed D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
Fri, Jul 12, 11:23 AM · Restricted Project, Restricted Project
tlively committed rG26a6b95da9ba: [WebAssembly] i32.const operands should be signed (authored by tlively).
[WebAssembly] i32.const operands should be signed
Fri, Jul 12, 10:57 AM
tlively committed rL365930: [WebAssembly] i32.const operands should be signed.
[WebAssembly] i32.const operands should be signed
Fri, Jul 12, 10:57 AM
tlively closed D64612: [WebAssembly] i32.const operands should be signed.
Fri, Jul 12, 10:56 AM · Restricted Project
tlively added inline comments to D64612: [WebAssembly] i32.const operands should be signed.
Fri, Jul 12, 10:56 AM · Restricted Project

Thu, Jul 11

tlively created D64612: [WebAssembly] i32.const operands should be signed.
Thu, Jul 11, 6:13 PM · Restricted Project
tlively updated the diff for D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
  • and other comment
Thu, Jul 11, 4:07 PM · Restricted Project, Restricted Project
tlively updated the diff for D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
  • Update comment
Thu, Jul 11, 4:07 PM · Restricted Project, Restricted Project
tlively updated the diff for D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
  • Add mutable-globals
Thu, Jul 11, 4:07 PM · Restricted Project, Restricted Project
tlively retitled D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals from [WebAssembly] Make -pthread imply -bulk-memory to [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
Thu, Jul 11, 4:07 PM · Restricted Project, Restricted Project
tlively added inline comments to D64537: [WebAssembly] Implement thread-local storage (local-exec model).
Thu, Jul 11, 3:30 PM · Restricted Project, Restricted Project
tlively created D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals.
Thu, Jul 11, 1:19 PM · Restricted Project, Restricted Project

Mon, Jul 8

tlively accepted D64372: [LLD] NFC: Fixed GCC warning in wasm/OutputSections.cpp.

Thanks!

Mon, Jul 8, 3:26 PM · Restricted Project

Wed, Jul 3

tlively committed rG6004d9a13d1f: [WebAssembly] Add option to emit passive segments (authored by tlively).
[WebAssembly] Add option to emit passive segments
Wed, Jul 3, 3:06 PM
tlively committed rL365088: [WebAssembly] Add option to emit passive segments.
[WebAssembly] Add option to emit passive segments
Wed, Jul 3, 3:05 PM
tlively closed D59343: [WebAssembly] Add option to emit passive segments.
Wed, Jul 3, 3:05 PM · Restricted Project
tlively accepted rGed13fef47741: [SelectionDAG] Do minnum->minimum at legalization time instead of building time.

Yeah this looks great. Thanks!

Wed, Jul 3, 11:30 AM

Tue, Jul 2

tlively added inline comments to D64115: [WebAssembly] Prevent inline assembly from being mangled by SjLj.
Tue, Jul 2, 5:33 PM · Restricted Project
tlively accepted D64115: [WebAssembly] Prevent inline assembly from being mangled by SjLj.

LGTM with a quick explanatory comment!

Tue, Jul 2, 5:29 PM · Restricted Project

Fri, Jun 28

tlively added a comment to D59343: [WebAssembly] Add option to emit passive segments.

@sbc100 it's been a long time but there is nothing blocking this change any more, so PTAL!

Fri, Jun 28, 5:11 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Add option to emit passive segments.
  • Remove extraneous braces
Fri, Jun 28, 5:09 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Add option to emit passive segments.

Change to use explicit flags instead of depending on shared
memory. This means this change is a nop in existing
toolchains. Emscripten can be taught to use the new flags explicitly
without requiring a manual double roll.

Fri, Jun 28, 5:00 PM · Restricted Project
tlively updated the summary of D59343: [WebAssembly] Add option to emit passive segments.
Fri, Jun 28, 4:45 PM · Restricted Project
tlively retitled D59343: [WebAssembly] Add option to emit passive segments from [WebAssembly] Use passive segments when memory is shared to [WebAssembly] Add option to emit passive segments.
Fri, Jun 28, 4:43 PM · Restricted Project

Wed, Jun 26

tlively committed rG7663e0cd7dbb: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible (authored by tlively).
[WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible
Wed, Jun 26, 9:23 AM
tlively committed rL364446: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible.
[WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible
Wed, Jun 26, 9:20 AM
tlively closed D63615: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible.
Wed, Jun 26, 9:20 AM · Restricted Project
tlively committed rGa1d97a960e62: [WebAssembly] Implement tail calls and unify tablegen call classes (authored by tlively).
[WebAssembly] Implement tail calls and unify tablegen call classes
Wed, Jun 26, 9:19 AM
tlively committed rL364445: [WebAssembly] Implement tail calls and unify tablegen call classes.
[WebAssembly] Implement tail calls and unify tablegen call classes
Wed, Jun 26, 9:19 AM
tlively closed D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Wed, Jun 26, 9:19 AM · Restricted Project

Jun 20 2019

tlively abandoned D63575: [WebAssembly] Add builtin functions for creating vector constants.
Jun 20 2019, 11:15 AM · Restricted Project
tlively created D63615: [WebAssembly] Omit wrap on i64x2.{shl,shr*} ISel when possible.
Jun 20 2019, 10:19 AM · Restricted Project

Jun 19 2019

tlively added a comment to D63575: [WebAssembly] Add builtin functions for creating vector constants.

This CL does not provide a mechanism for enforcing that the lanes of a floating point vector are constant, and it doesn't look like clang supports that kind of check. That makes this CL a half-baked solution, so I'm not sure we should actually go in this direction.

Jun 19 2019, 4:18 PM · Restricted Project
tlively created D63575: [WebAssembly] Add builtin functions for creating vector constants.
Jun 19 2019, 2:44 PM · Restricted Project

Jun 18 2019

tlively committed rG1885747498c2: [WebAssembly] Optimize ISel for SIMD Boolean reductions (authored by tlively).
[WebAssembly] Optimize ISel for SIMD Boolean reductions
Jun 18 2019, 5:00 PM
tlively committed rL363756: [WebAssembly] Optimize ISel for SIMD Boolean reductions.
[WebAssembly] Optimize ISel for SIMD Boolean reductions
Jun 18 2019, 5:00 PM
tlively closed D63529: [WebAssembly] Optimize ISel for SIMD Boolean reductions.
Jun 18 2019, 5:00 PM · Restricted Project
tlively created D63529: [WebAssembly] Optimize ISel for SIMD Boolean reductions.
Jun 18 2019, 4:32 PM · Restricted Project
tlively accepted D63509: DAG: Use getStoreSize when expanding dynamic vector indexing.

That was simple! Thank you!

Jun 18 2019, 12:46 PM

Jun 12 2019

tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Address comments
Jun 12 2019, 1:26 AM · Restricted Project

Jun 9 2019

tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 9 2019, 1:11 PM · Restricted Project

Jun 7 2019

tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Restore previous logic, add tests for strange ABIs and prototype mismatches
Jun 7 2019, 5:39 PM · Restricted Project
tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 7 2019, 12:26 PM · Restricted Project
tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 7 2019, 10:18 AM · Restricted Project

Jun 6 2019

tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 6 2019, 6:08 PM · Restricted Project
tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Add TODO in FastISel, add isReturn attribute, integrate into existing logic flow
Jun 6 2019, 6:06 PM · Restricted Project

Jun 5 2019

tlively committed rG5e7ca755d8c7: [WebAssembly] Support Leak Sanitizer on Emscripten (authored by tlively).
[WebAssembly] Support Leak Sanitizer on Emscripten
Jun 5 2019, 6:37 PM
tlively committed rL362667: [WebAssembly] Support Leak Sanitizer on Emscripten.
[WebAssembly] Support Leak Sanitizer on Emscripten
Jun 5 2019, 6:37 PM
tlively closed D62830: [WebAssembly] Support Leak Sanitizer on Emscripten.
Jun 5 2019, 6:37 PM · Restricted Project, Restricted Project
tlively added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 5 2019, 1:28 PM · Restricted Project
tlively updated the diff for D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Fix formatting and error message, add documentation and notail tests
Jun 5 2019, 1:28 PM · Restricted Project

Jun 4 2019

tlively committed rGb98025a2f75d: [WebAssembly] make wasm-ld --verbose show data section startVA and name (authored by tlively).
[WebAssembly] make wasm-ld --verbose show data section startVA and name
Jun 4 2019, 2:13 PM
tlively committed rL362548: [WebAssembly] make wasm-ld --verbose show data section startVA and name.
[WebAssembly] make wasm-ld --verbose show data section startVA and name
Jun 4 2019, 2:13 PM
tlively closed D62834: [WebAssembly] make wasm-ld --verbose show data section startVA and name.
Jun 4 2019, 2:13 PM · Restricted Project
tlively committed rG3d9ca00e74e2: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch (authored by tlively).
[WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch
Jun 4 2019, 2:06 PM
tlively committed rL362547: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.
[WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch
Jun 4 2019, 2:06 PM
tlively closed D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.
Jun 4 2019, 2:06 PM · Restricted Project
tlively updated the summary of D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 4 2019, 1:43 PM · Restricted Project
tlively created D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Jun 4 2019, 1:32 PM · Restricted Project

Jun 3 2019

tlively added a comment to D62832: [WebAssembly] add memory map file support for wasm-ld.

This would require a test before it is merged.

Jun 3 2019, 5:54 PM · Restricted Project
tlively added a comment to D62811: [SelectionDAG] Add fpto[us]i(undef) --> undef constant fold.

WebAssembly change LGTM

Jun 3 2019, 8:54 AM · Restricted Project

May 31 2019

tlively added a comment to D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.

@aheejin, this should be good to go now. Changing the test to use a real pointer instead of undef seems to have made it do the correct number of loads (32 bits, where before it was only loading 8 bits). Now that the test is very straightforward I am confident in the correctness of the code, so hopefully this should be good to land.

May 31 2019, 8:48 PM · Restricted Project
tlively updated the diff for D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.
  • Fix Bitcast and update test to be more convincing of correctness
May 31 2019, 8:43 PM · Restricted Project

May 30 2019

tlively committed rG86e73f51d77d: [WebAssembly] Improve feature validation error messages (authored by tlively).
[WebAssembly] Improve feature validation error messages
May 30 2019, 2:55 PM
tlively committed rL362162: [WebAssembly] Improve feature validation error messages.
[WebAssembly] Improve feature validation error messages
May 30 2019, 2:54 PM
tlively added inline comments to D62704: [WebAssembly] Improve feature validation error messages.
May 30 2019, 2:54 PM · Restricted Project
tlively closed D62704: [WebAssembly] Improve feature validation error messages.
May 30 2019, 2:54 PM · Restricted Project
tlively updated the diff for D62704: [WebAssembly] Improve feature validation error messages.
  • Use StringRefs
May 30 2019, 2:54 PM · Restricted Project
tlively created D62704: [WebAssembly] Improve feature validation error messages.
May 30 2019, 2:21 PM · Restricted Project
tlively updated the diff for D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.
  • Add assert that the index adjustment is reasonable
May 30 2019, 11:42 AM · Restricted Project

May 29 2019

tlively created D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.
May 29 2019, 10:11 PM · Restricted Project
tlively committed rG5458cd4027f5: [WebAssembly] Support VPtr sanitizer for Emscripten (authored by tlively).
[WebAssembly] Support VPtr sanitizer for Emscripten
May 29 2019, 11:30 AM
tlively committed rC362004: [WebAssembly] Support VPtr sanitizer for Emscripten.
[WebAssembly] Support VPtr sanitizer for Emscripten
May 29 2019, 11:30 AM
tlively committed rL362004: [WebAssembly] Support VPtr sanitizer for Emscripten.
[WebAssembly] Support VPtr sanitizer for Emscripten
May 29 2019, 11:30 AM
tlively closed D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.
May 29 2019, 11:30 AM · Restricted Project, Restricted Project

May 28 2019

tlively committed rG26d711be6e8e: [WebAssembly] Add signatures for RINT builtins (authored by tlively).
[WebAssembly] Add signatures for RINT builtins
May 28 2019, 6:05 PM
tlively committed rL361904: [WebAssembly] Add signatures for RINT builtins.
[WebAssembly] Add signatures for RINT builtins
May 28 2019, 6:05 PM
tlively closed D62564: [WebAssembly] Add signatures for RINT builtins.
May 28 2019, 6:05 PM · Restricted Project
tlively created D62564: [WebAssembly] Add signatures for RINT builtins.
May 28 2019, 6:05 PM · Restricted Project
tlively added a comment to D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.

Please add a test!

May 28 2019, 5:42 PM · Restricted Project, Restricted Project
tlively added inline comments to D50277: [WebAssembly] Support for atomic fences.
May 28 2019, 11:21 AM · Restricted Project

May 24 2019

tlively accepted D50277: [WebAssembly] Support for atomic fences.

LGTM ship it! (behind emscripten flag)

May 24 2019, 5:55 PM · Restricted Project

May 23 2019

tlively committed rG55229f6b1027: [WebAssembly] Expand more SIMD float ops (authored by tlively).
[WebAssembly] Expand more SIMD float ops
May 23 2019, 5:14 PM
tlively committed rL361577: [WebAssembly] Expand more SIMD float ops.
[WebAssembly] Expand more SIMD float ops
May 23 2019, 5:12 PM
tlively closed D62354: [WebAssembly] Expand more SIMD float ops.
May 23 2019, 5:12 PM · Restricted Project