Page MenuHomePhabricator

tlively (Thomas Lively)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:54 AM (41 w, 5 d)

Recent Activity

Thu, May 16

tlively created D62047: [WebAssembly] Add multivalue and tail-call target features.
Thu, May 16, 5:11 PM · Restricted Project, Restricted Project

Mon, May 13

tlively added a comment to D61823: [WebAssembly] Don't assume that zext/sext result is i32/i64 in fast isel (PR41841).

Looks good. Feel free to commit yourself or lmk if you want me to commit it for you.

Mon, May 13, 9:38 AM · Restricted Project

Sun, May 12

tlively accepted D61823: [WebAssembly] Don't assume that zext/sext result is i32/i64 in fast isel (PR41841).

Thanks for fixing this! I have a few comments on the test style, but otherwise LGTM.

Sun, May 12, 4:56 PM · Restricted Project

Thu, May 2

tlively updated the diff for D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash.
  • Remove hanging metadata tag in test
Thu, May 2, 6:19 PM · Restricted Project
tlively added a comment to D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash.

DAGTypeLegalizer calls ReplaceNodeResults whenever CustomLowerNode is called and its parameter LegalizeResult is true or when CustomWidenLowerNode is called. So basically it is the same as LowerOperation except that it is meant to focus on legalizing the result type rather than simply transforming the operation. There is even a TODO on LowerOperationWrapper, /// TODO: Consider merging with ReplaceNodeResults..

Thu, May 2, 6:08 PM · Restricted Project

Wed, Apr 24

tlively planned changes to D59343: [WebAssembly] Use passive segments when memory is shared.

This CL should not be merged until Chrome 75 releases to stable on June 4.

Wed, Apr 24, 11:19 AM · Restricted Project

Tue, Apr 23

tlively accepted D60929: [WebAssembly] Make LBB markers not affected by test order.

Looks good!

Tue, Apr 23, 1:45 PM · Restricted Project
tlively created D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash.
Tue, Apr 23, 1:37 PM · Restricted Project

Mon, Apr 22

tlively updated the diff for D59343: [WebAssembly] Use passive segments when memory is shared.
  • Address comments
Mon, Apr 22, 3:42 PM · Restricted Project

Fri, Apr 19

tlively committed rG84771e2d21e8: [WebAssembly] Emit the DataCount section when bulk memory is enabled (authored by tlively).
[WebAssembly] Emit the DataCount section when bulk memory is enabled
Fri, Apr 19, 4:42 PM
tlively committed rLLD358798: [WebAssembly] Emit the DataCount section when bulk memory is enabled.
[WebAssembly] Emit the DataCount section when bulk memory is enabled
Fri, Apr 19, 4:39 PM
tlively committed rL358798: [WebAssembly] Emit the DataCount section when bulk memory is enabled.
[WebAssembly] Emit the DataCount section when bulk memory is enabled
Fri, Apr 19, 4:38 PM
tlively closed D60637: [WebAssembly] Emit the DataCount section when bulk memory is enabled.
Fri, Apr 19, 4:38 PM · Restricted Project
tlively added a comment to D60637: [WebAssembly] Emit the DataCount section when bulk memory is enabled.

ping, I think this should be ready to go.

Fri, Apr 19, 4:01 PM · Restricted Project

Apr 19 2019

tlively accepted D60908: [WebAssembly] FastISel: Don't fallback to SelectionDAG after BuildMI in selectCall.
Apr 19 2019, 2:56 PM · Restricted Project

Apr 17 2019

tlively accepted D60836: [WebAssembly] Object: Improve error messages on invalid section.

Might be nice to have a test, but understandable if that doesn't seem worth the effort.

Apr 17 2019, 2:52 PM · Restricted Project

Apr 15 2019

tlively added inline comments to D59343: [WebAssembly] Use passive segments when memory is shared.
Apr 15 2019, 7:02 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Use passive segments when memory is shared.
  • address comments
Apr 15 2019, 5:23 PM · Restricted Project
tlively added inline comments to D60637: [WebAssembly] Emit the DataCount section when bulk memory is enabled.
Apr 15 2019, 2:46 PM · Restricted Project
tlively updated the diff for D60637: [WebAssembly] Emit the DataCount section when bulk memory is enabled.
  • Switch to using SyntheticSection
Apr 15 2019, 2:46 PM · Restricted Project

Apr 12 2019

tlively added a reviewer for D59343: [WebAssembly] Use passive segments when memory is shared: dschuff.
Apr 12 2019, 5:36 PM · Restricted Project
tlively updated the summary of D59343: [WebAssembly] Use passive segments when memory is shared.
Apr 12 2019, 5:34 PM · Restricted Project
tlively updated the summary of D59343: [WebAssembly] Use passive segments when memory is shared.
Apr 12 2019, 5:32 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Use passive segments when memory is shared.
  • Rebase on top of D60637 and add data.drop
Apr 12 2019, 5:27 PM · Restricted Project
tlively created D60637: [WebAssembly] Emit the DataCount section when bulk memory is enabled.
Apr 12 2019, 3:29 PM · Restricted Project
tlively committed rGfef8de66a6ad: [WebAssembly] Add DataCount section to object files (authored by tlively).
[WebAssembly] Add DataCount section to object files
Apr 12 2019, 3:27 PM
tlively committed rL358315: [WebAssembly] Add DataCount section to object files.
[WebAssembly] Add DataCount section to object files
Apr 12 2019, 3:26 PM
tlively closed D60623: [WebAssembly] Add DataCount section to object files.
Apr 12 2019, 3:26 PM · Restricted Project
tlively added a comment to D60623: [WebAssembly] Add DataCount section to object files.

I assume the linker doesn't need to do anything with this, it can just regenerate it after linking?

Apr 12 2019, 2:21 PM · Restricted Project
tlively committed rG9e27514996e7: [WebAssembly] Add mutable-globals to bleeding-edge CPU (authored by tlively).
[WebAssembly] Add mutable-globals to bleeding-edge CPU
Apr 12 2019, 1:40 PM
tlively committed rL358310: [WebAssembly] Add mutable-globals to bleeding-edge CPU.
[WebAssembly] Add mutable-globals to bleeding-edge CPU
Apr 12 2019, 1:39 PM
tlively closed D60594: [WebAssembly] Add mutable-globals to bleeding-edge CPU.
Apr 12 2019, 1:39 PM · Restricted Project
tlively created D60623: [WebAssembly] Add DataCount section to object files.
Apr 12 2019, 10:11 AM · Restricted Project

Apr 11 2019

tlively created D60594: [WebAssembly] Add mutable-globals to bleeding-edge CPU.
Apr 11 2019, 5:51 PM · Restricted Project

Mar 29 2019

tlively committed rG5f0c4c67bbff: [WebAssembly] Add mutable globals feature (authored by tlively).
[WebAssembly] Add mutable globals feature
Mar 29 2019, 3:02 PM
tlively committed rC357321: [WebAssembly] Add mutable globals feature.
[WebAssembly] Add mutable globals feature
Mar 29 2019, 3:01 PM
tlively committed rL357321: [WebAssembly] Add mutable globals feature.
[WebAssembly] Add mutable globals feature
Mar 29 2019, 3:01 PM
tlively closed D60013: [WebAssembly] Add mutable globals feature.
Mar 29 2019, 3:01 PM · Restricted Project, Restricted Project
tlively created D60013: [WebAssembly] Add mutable globals feature.
Mar 29 2019, 2:34 PM · Restricted Project, Restricted Project
tlively added a comment to D57800: [WebAssembly] LTO: Set POSIX thread model when linking with -shared-memoey.

Yes, ThreadModel is no longer used anywhere in the WebAssembly backend.

Mar 29 2019, 1:45 PM · Restricted Project
tlively committed rG06391f34bd4e: [WebAssembly] "atomics" feature requires shared memory (authored by tlively).
[WebAssembly] "atomics" feature requires shared memory
Mar 29 2019, 1:43 PM
tlively committed rLLD357310: [WebAssembly] "atomics" feature requires shared memory.
[WebAssembly] "atomics" feature requires shared memory
Mar 29 2019, 1:42 PM
tlively committed rL357310: [WebAssembly] "atomics" feature requires shared memory.
[WebAssembly] "atomics" feature requires shared memory
Mar 29 2019, 1:42 PM
tlively closed D59281: [WebAssembly] "atomics" feature requires shared memory.
Mar 29 2019, 1:42 PM · Restricted Project

Mar 28 2019

tlively updated subscribers of D59343: [WebAssembly] Use passive segments when memory is shared.

@dschuff, @sbc100, @azakai we should figure out what our story is for pthreads and bulk-memory in the LLVM backend. This CL assumes that passive segments will always be available when creating multithreaded binaries, but obviously that's not true for Chrome 74. I was thinking that would be fine because using the asm2wasm path with mem files will suffice for anyone wanting to target chrome 74 with pthreads. But will we want to support mem files going forward? If so, I need to add a linker option to control that.

Mar 28 2019, 5:36 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Use passive segments when memory is shared.
  • rebase
Mar 28 2019, 5:31 PM · Restricted Project
tlively added a comment to D59281: [WebAssembly] "atomics" feature requires shared memory.

@sbc100 and @aheejin, this is unblocked and ready to land whenever you have a chance to review it.

Mar 28 2019, 5:24 PM · Restricted Project
tlively updated the diff for D59281: [WebAssembly] "atomics" feature requires shared memory.
  • rebase
Mar 28 2019, 5:22 PM · Restricted Project
tlively committed rG3f34e1b88335: [WebAssembly] Merge used feature sets, update atomics linkage policy (authored by tlively).
[WebAssembly] Merge used feature sets, update atomics linkage policy
Mar 28 2019, 5:13 PM
tlively committed rL357226: [WebAssembly] Merge used feature sets, update atomics linkage policy.
[WebAssembly] Merge used feature sets, update atomics linkage policy
Mar 28 2019, 5:13 PM
tlively closed D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 28 2019, 5:13 PM · Restricted Project
tlively added inline comments to D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 28 2019, 5:01 PM · Restricted Project
tlively updated the diff for D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
  • Address comments
  • gracefully handle invalid metadata
  • do not emit empty producers sections
Mar 28 2019, 5:01 PM · Restricted Project

Mar 27 2019

tlively added inline comments to D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 27 2019, 4:49 PM · Restricted Project
tlively updated the diff for D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
  • Switch to storing target feature information as Module metadata
Mar 27 2019, 4:46 PM · Restricted Project
tlively planned changes to D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 27 2019, 2:54 PM · Restricted Project

Mar 26 2019

tlively accepted D59855: [WebAssembly] Add some whitespace for clarity.

LGTM!

Mar 26 2019, 6:18 PM · Restricted Project
tlively added a comment to D59824: [LLD] Restore tests that use "-" as output.

I think there are more tests that should use -o - in wasm/target-feature-none.yaml, but otherwise the wasm changes lgtm.

Mar 26 2019, 9:37 AM · Restricted Project

Mar 25 2019

tlively committed rG82de51a3aefe: Reland "[WebAssembly] Add linker options to control feature checking" (authored by tlively).
Reland "[WebAssembly] Add linker options to control feature checking"
Mar 25 2019, 9:11 PM
tlively added a reverting change for rG84c8652fc308: Revert "[WebAssembly] Add linker options to control feature checking": rG82de51a3aefe: Reland "[WebAssembly] Add linker options to control feature checking".
Mar 25 2019, 9:11 PM
tlively committed rL356975: Reland "[WebAssembly] Add linker options to control feature checking".
Reland "[WebAssembly] Add linker options to control feature checking"
Mar 25 2019, 9:09 PM
tlively committed rLLD356975: Reland "[WebAssembly] Add linker options to control feature checking".
Reland "[WebAssembly] Add linker options to control feature checking"
Mar 25 2019, 9:09 PM
tlively committed rLLD356932: Revert "[WebAssembly] Add linker options to control feature checking".
Revert "[WebAssembly] Add linker options to control feature checking"
Mar 25 2019, 11:16 AM
tlively committed rL356932: Revert "[WebAssembly] Add linker options to control feature checking".
Revert "[WebAssembly] Add linker options to control feature checking"
Mar 25 2019, 11:11 AM
tlively committed rG84c8652fc308: Revert "[WebAssembly] Add linker options to control feature checking" (authored by tlively).
Revert "[WebAssembly] Add linker options to control feature checking"
Mar 25 2019, 11:10 AM
tlively added a reverting change for rG5991328c96b6: [WebAssembly] Add linker options to control feature checking: rG84c8652fc308: Revert "[WebAssembly] Add linker options to control feature checking".
Mar 25 2019, 11:10 AM

Mar 22 2019

tlively committed rG80ff58e37c96: [WebAssembly] Make driver -pthread imply linker --shared-memory (authored by tlively).
[WebAssembly] Make driver -pthread imply linker --shared-memory
Mar 22 2019, 3:29 PM
tlively committed rC356817: [WebAssembly] Make driver -pthread imply linker --shared-memory.
[WebAssembly] Make driver -pthread imply linker --shared-memory
Mar 22 2019, 3:24 PM
tlively committed rL356817: [WebAssembly] Make driver -pthread imply linker --shared-memory.
[WebAssembly] Make driver -pthread imply linker --shared-memory
Mar 22 2019, 3:24 PM
tlively closed D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory.
Mar 22 2019, 3:24 PM · Restricted Project, Restricted Project
tlively created D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory.
Mar 22 2019, 3:06 PM · Restricted Project, Restricted Project
tlively committed rG5991328c96b6: [WebAssembly] Add linker options to control feature checking (authored by tlively).
[WebAssembly] Add linker options to control feature checking
Mar 22 2019, 1:42 PM
tlively committed rLLD356805: [WebAssembly] Add linker options to control feature checking.
[WebAssembly] Add linker options to control feature checking
Mar 22 2019, 1:42 PM
tlively committed rL356805: [WebAssembly] Add linker options to control feature checking.
[WebAssembly] Add linker options to control feature checking
Mar 22 2019, 1:42 PM
tlively closed D59274: [WebAssembly] Add linker options to control feature checking.
Mar 22 2019, 1:42 PM · Restricted Project

Mar 21 2019

tlively updated the diff for D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
  • Remove unnecessary test and small cleanup
Mar 21 2019, 6:19 PM · Restricted Project
tlively retitled D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy from [WebAssembly] Set "atomics" linkage depending on stripped ops or tls to [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 21 2019, 6:07 PM · Restricted Project
tlively updated the diff for D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
  • Calculate and use union of features used in module before starting instruction selection.
Mar 21 2019, 5:48 PM · Restricted Project
tlively added a comment to D59274: [WebAssembly] Add linker options to control feature checking.

@sbc100 friendly ping! It would be great to start clearing this stack.

Mar 21 2019, 11:27 AM · Restricted Project
tlively added inline comments to D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 21 2019, 11:25 AM · Restricted Project

Mar 20 2019

tlively added inline comments to D59343: [WebAssembly] Use passive segments when memory is shared.
Mar 20 2019, 7:29 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Use passive segments when memory is shared.
  • ATOMICS -> SHARED in test
Mar 20 2019, 7:28 PM · Restricted Project
tlively updated the diff for D59343: [WebAssembly] Use passive segments when memory is shared.
  • Add --shared-memory to avoid new errors
Mar 20 2019, 7:26 PM · Restricted Project
tlively added a parent revision for D59281: [WebAssembly] "atomics" feature requires shared memory: D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 20 2019, 7:20 PM · Restricted Project
tlively added a child revision for D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy: D59281: [WebAssembly] "atomics" feature requires shared memory.
Mar 20 2019, 7:20 PM · Restricted Project
tlively updated the diff for D59281: [WebAssembly] "atomics" feature requires shared memory.
  • Make using --shared-memory when atomics are disallowed or omitting it when atomics are used an error.
Mar 20 2019, 7:19 PM · Restricted Project
tlively created D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.
Mar 20 2019, 6:57 PM · Restricted Project
tlively committed rG5098f8589de3: [WebAssembly][NFC] Fix formatting error from rL356610 (authored by tlively).
[WebAssembly][NFC] Fix formatting error from rL356610
Mar 20 2019, 3:34 PM
tlively committed rL356622: [WebAssembly][NFC] Fix formatting error from rL356610.
[WebAssembly][NFC] Fix formatting error from rL356610
Mar 20 2019, 3:33 PM
tlively added inline comments to D59281: [WebAssembly] "atomics" feature requires shared memory.
Mar 20 2019, 2:24 PM · Restricted Project
tlively retitled D59281: [WebAssembly] "atomics" feature requires shared memory from [WebAssembly] "atomics" feature implies shared memory to [WebAssembly] "atomics" feature requires shared memory.
Mar 20 2019, 1:47 PM · Restricted Project
tlively added inline comments to D59173: [WebAssembly] Target features section.
Mar 20 2019, 1:36 PM · Restricted Project
tlively committed rGf6f4f84378ea: [WebAssembly] Target features section (authored by tlively).
[WebAssembly] Target features section
Mar 20 2019, 1:26 PM
tlively committed rLLD356610: [WebAssembly] Target features section.
[WebAssembly] Target features section
Mar 20 2019, 1:26 PM
tlively committed rL356610: [WebAssembly] Target features section.
[WebAssembly] Target features section
Mar 20 2019, 1:26 PM
tlively closed D59173: [WebAssembly] Target features section.
Mar 20 2019, 1:25 PM · Restricted Project

Mar 19 2019

tlively added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

This commit breaks the following IR:

Mar 19 2019, 5:19 PM · Restricted Project

Mar 18 2019

tlively added a comment to D59274: [WebAssembly] Add linker options to control feature checking.

@sbc100 Any comments or concerns with these flags?

Mar 18 2019, 6:28 PM · Restricted Project
tlively committed rG0200d62ec7a5: [WebAssembly] Lower SIMD nnan setcc nodes (authored by tlively).
[WebAssembly] Lower SIMD nnan setcc nodes
Mar 18 2019, 5:55 PM
tlively committed rL356431: [WebAssembly] Lower SIMD nnan setcc nodes.
[WebAssembly] Lower SIMD nnan setcc nodes
Mar 18 2019, 5:55 PM