- User Since
- Jul 31 2018, 10:54 AM (76 w, 3 d)
- Add script doc comment and update string formatting
- Switch to using MVT::Glue
@aheejin, there are no changes I am currently planning to make to this, but I am happy to continue the inline discussions.
- Rebase on master
Just looking for high-level feedback right now, especially on the inclusion of the script and generated test cases. Now that multivalue is testable, I will go back and clean up the previous patches in this chain.
Wed, Jan 8
Unfortunately I do not know how multi-return.ll works. Despite its name, it is not a multivalue test (although once multivalue works it would make sense to add a multivalue-enabled run to that file). I generally don't use test-generation scripts because they tend to produce tests with unclear goals, as you observe.
Mon, Jan 6
LGTM! I checked locally and this fixes https://github.com/rust-lang/rust/issues/66308. Thanks for solving this so quickly :)
Dec 18 2019
Dec 17 2019
Dec 16 2019
- Use MVT::Other for link, rebase
- Add OpInfo check to avoid OOB when there are only variadic ops
- Check isVariadic explicitly in InstrEmitter
- Address simple comments
Dec 13 2019
This issue is still not resolved.
Nov 15 2019
Nov 13 2019
LGTM, sorry for the delay!
Nov 1 2019
Oct 31 2019
- Add second argument
Oct 30 2019
Oct 29 2019
Oct 24 2019
One other thought: Does the implementation in this diff care what type the reference type pointers are pointing to? It would be nice if we could enforce the use of an opaque pointee type to prevent the reference types from being dereferenced.
It would be great to see some test .ll files here so we can get a better understanding for what is implemented here. I would also like to see tests of what happens if you try to do a ptrtoint or some other illegal operation on a reference type.
Oct 18 2019
Oct 17 2019
I'm re-opening this revision. After discussion on https://github.com/WebAssembly/simd/issues/118, there is clear consensus that we do not want to break WebAssembly's abstraction and consider underlying platforms, so shuffles should not be merged without some sort of modification to the spec to serve as a platform-agnostic indication that the merged shuffle will be better.
Oct 16 2019
Oct 15 2019
- Address comments
Oct 14 2019
Oct 11 2019
- Explain more about multivalue types in WebAssembly::BlockType