Page MenuHomePhabricator

tlively (Thomas Lively)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:54 AM (204 w, 6 d)

Recent Activity

Wed, Jun 29

tlively accepted D128794: [WebAssembly] Don't set musttail for coroutines is tail call is not enabled.

Nice! LGTM with those comments.

Wed, Jun 29, 10:36 AM · Restricted Project, Restricted Project

Mon, Jun 27

tlively accepted D128515: [lld][WebAssembly] Don't apply data relocations at static constructor time.
Mon, Jun 27, 12:27 PM · Restricted Project, Restricted Project
tlively added a comment to D128163: [Coroutines] Don't add musttail call if WebAssembly are enabled.

I think it would make sense to add a new method to TTI for this, since hardcoding an exception for Wasm is not going to be future-proof at all. The tail-call target feature, while not standard yet, is very close to being standardized and shipped in browsers. It's already available behind a flag in Chrome and Node. Also, if possible, it would be good to perform a different transformation that can still do symmetric transfer without tail calls if the prevailing view is that symmetric transfer is guaranteed by the spec (but simply omitting musttail for now seems like a reasonable stopgap measure).

Mon, Jun 27, 12:23 PM · Restricted Project, Restricted Project

Wed, Jun 22

tlively added a comment to D128282: [WebAssembly] Update test to run it in opaque pointers mode.

I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different).

Yeah, but the convention used elsewhere in this test file is to use WEBASSEMBLY: (which is a common check prefix for both wasm32 and wasm64 run lines) in the cases where the output is the same.

Wed, Jun 22, 9:35 AM · Restricted Project, Restricted Project

Tue, Jun 21

tlively accepted D128282: [WebAssembly] Update test to run it in opaque pointers mode.

I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different).

Tue, Jun 21, 3:10 PM · Restricted Project, Restricted Project
tlively added a comment to D128163: [Coroutines] Don't add musttail call if WebAssembly are enabled.

Thanks for taking a look at this!

Tue, Jun 21, 10:40 AM · Restricted Project, Restricted Project

Wed, Jun 8

tlively committed rGaff679a48c43: [WebAssembly] Implement remaining relaxed SIMD instructions (authored by tlively).
[WebAssembly] Implement remaining relaxed SIMD instructions
Wed, Jun 8, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
tlively closed D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Wed, Jun 8, 10:32 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 7

tlively updated the diff for D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
  • dot_add takes three operands
Tue, Jun 7, 3:25 PM · Restricted Project, Restricted Project, Restricted Project
tlively planned changes to D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Tue, Jun 7, 2:16 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 6

tlively committed rG576b8245c838: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD (authored by tlively).
[WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD
Mon, Jun 6, 5:57 PM · Restricted Project, Restricted Project
tlively closed D127157: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD.
Mon, Jun 6, 5:56 PM · Restricted Project, Restricted Project
tlively requested review of D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Mon, Jun 6, 5:49 PM · Restricted Project, Restricted Project, Restricted Project
tlively requested review of D127157: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD.
Mon, Jun 6, 2:45 PM · Restricted Project, Restricted Project

May 23 2022

tlively accepted D126107: [lld][WebAssembly] Allow first thread to use static TLS region.

Thanks, this makes more sense now. LGTM with fixes and extra information in that comment.

May 23 2022, 2:56 PM · Restricted Project, Restricted Project

May 20 2022

tlively accepted D126104: [lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC.
May 20 2022, 5:37 PM · Restricted Project, Restricted Project
tlively added inline comments to D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
May 20 2022, 5:36 PM · Restricted Project, Restricted Project

May 16 2022

tlively committed rG82a13d05ab71: [WebAssembly] Update relaxed SIMD opcodes and names (authored by tlively).
[WebAssembly] Update relaxed SIMD opcodes and names
May 16 2022, 5:52 PM · Restricted Project, Restricted Project
tlively closed D125726: [WebAssembly] Update relaxed SIMD opcodes and names.
May 16 2022, 5:51 PM · Restricted Project, Restricted Project
tlively accepted D125714: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string.
May 16 2022, 5:47 PM · Restricted Project, Restricted Project
tlively accepted D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string.
May 16 2022, 5:46 PM · Restricted Project, Restricted Project
tlively requested review of D125726: [WebAssembly] Update relaxed SIMD opcodes and names.
May 16 2022, 2:17 PM · Restricted Project, Restricted Project

May 10 2022

tlively accepted D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

LGTM! (with single comment)

May 10 2022, 3:05 PM · Restricted Project, Restricted Project

Apr 22 2022

tlively added a comment to D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Nice! code looks good to me, but we'll need community signoff on an RFC as @rjmccall mentioned and it would be nice to have a clang maintainer sign off as well.

Apr 22 2022, 2:09 PM · Restricted Project

Apr 21 2022

tlively added inline comments to D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.
Apr 21 2022, 4:25 PM · Restricted Project

Apr 11 2022

tlively added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

No concerns about the WebAssembly changes. Will the default installation for folks who don't touch LLVM_DISTRIBUTION_COMPONENTS change?

Apr 11 2022, 9:59 AM · Restricted Project, Restricted Project

Mar 22 2022

tlively accepted D122127: [WebAssembly] Use location of operand for operand-based type check errors.
Mar 22 2022, 1:31 PM · Restricted Project, Restricted Project

Mar 17 2022

tlively committed rG7062094bbc68: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h (authored by tlively).
[WebAssembly] Add end-to-end codegen tests for wasm_simd128.h
Mar 17 2022, 3:22 PM · Restricted Project
tlively closed D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.
Mar 17 2022, 3:22 PM · Restricted Project, Restricted Project
tlively added a comment to D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.

Great, thanks @jhenderson!

Mar 17 2022, 1:53 PM · Restricted Project, Restricted Project

Mar 16 2022

tlively accepted D121869: [WebAssembly] Disable SimplifyDemandedVectorElts after legalization.

LGTM! This seems fairly reasonable as a solution, all things considered. Have you been able to check whether this has any broad impacts on the quality of our codegen? My guess is that it doesn't since it seems that any code that would have had the vector elements simplified previously would have ended up in that infinite loop, but we went a long time without ever seeing that bug in the wild.

Mar 16 2022, 6:39 PM · Restricted Project, Restricted Project
tlively committed rG7e8913d775ca: [WebAssembly] Fix names of SIMD instructions containing '_zero' (authored by tlively).
[WebAssembly] Fix names of SIMD instructions containing '_zero'
Mar 16 2022, 1:35 PM · Restricted Project
tlively closed D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'.
Mar 16 2022, 1:35 PM · Restricted Project, Restricted Project, Restricted Project
tlively retitled D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h from [WIP][WebAssembly] Add end-to-end codegen tests for wasm_simd128.h to [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.
Mar 16 2022, 1:25 PM · Restricted Project, Restricted Project
tlively added reviewers for D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h: dblaikie, jhenderson, aheejin.
Mar 16 2022, 1:24 PM · Restricted Project, Restricted Project
tlively added a comment to D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.

Thanks, @jhenderson! You were right on all counts and I have the test working now. This should be ready for proper review.

Mar 16 2022, 1:22 PM · Restricted Project, Restricted Project
tlively updated the diff for D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.
  • Update version check and available_features in lit.cfg.py
Mar 16 2022, 1:18 PM · Restricted Project, Restricted Project

Mar 15 2022

tlively added a comment to D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.

Right now (after trying to upgrade my gdb) I get this error

Mar 15 2022, 11:26 AM · Restricted Project, Restricted Project

Mar 14 2022

tlively added a comment to D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.

cc @Orlando and @jhenderson, who have worked on cross-project-tests. I've got ninja check-intrinsic-headers kind of working, but the test doesn't run because cross-project-tests/lit.cfg.py checks for a good gdb version (which I don't have) even though I don't want to run the debuginfo tests. Would you be able to help move that configuration code into cross-project-tests/debuginfo-tests?

Mar 14 2022, 8:55 PM · Restricted Project, Restricted Project
tlively requested review of D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.
Mar 14 2022, 8:48 PM · Restricted Project, Restricted Project
tlively requested review of D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'.
Mar 14 2022, 7:54 PM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

tlively accepted D121151: [WebAssembly] Add new target feature in support of 'extended-const' proposal.
Mar 7 2022, 4:41 PM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2022

tlively added a comment to D121014: [WebAssembly] Check bulk-memory when adjusting lang opts.

@dyung, this should be fixed by https://reviews.llvm.org/rGc01ec3083026f7e24e6c06f48a05d413e2c697d4

Mar 4 2022, 7:03 PM · Restricted Project, Restricted Project
tlively committed rGc01ec3083026: [WebAssembly] Update Preprocessor/init.c test after 3be9e0ba972c (authored by tlively).
[WebAssembly] Update Preprocessor/init.c test after 3be9e0ba972c
Mar 4 2022, 6:40 PM · Restricted Project
tlively added a comment to rG3be9e0ba972c: [WebAssembly] Check bulk-memory when adjusting lang opts.

This broke the build, working on a fix now.

Mar 4 2022, 6:07 PM · Restricted Project
tlively committed rG3be9e0ba972c: [WebAssembly] Check bulk-memory when adjusting lang opts (authored by tlively).
[WebAssembly] Check bulk-memory when adjusting lang opts
Mar 4 2022, 4:07 PM · Restricted Project
tlively closed D121014: [WebAssembly] Check bulk-memory when adjusting lang opts.
Mar 4 2022, 4:07 PM · Restricted Project, Restricted Project
tlively requested review of D121014: [WebAssembly] Check bulk-memory when adjusting lang opts.
Mar 4 2022, 11:20 AM · Restricted Project, Restricted Project

Feb 17 2022

tlively accepted D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 17 2022, 12:23 PM · Restricted Project

Feb 15 2022

tlively added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 7:39 PM · Restricted Project
tlively added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 4:11 PM · Restricted Project
tlively added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 2:59 PM · Restricted Project
tlively added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 2:07 PM · Restricted Project

Feb 7 2022

tlively added inline comments to D119171: [SelectionDAG][RISCV][ARM][PowerPC][X86][WebAssembly] Change default abs expansion to use sra (X, size(X)-1); sub (xor (X, Y), Y)..
Feb 7 2022, 12:10 PM · Restricted Project

Jan 31 2022

tlively accepted D118571: [clang][WebAssembly] Imply -fno-threadsafe-static when threading is disabled.
Jan 31 2022, 11:35 AM · Restricted Project

Jan 27 2022

tlively added inline comments to D118414: [lld][WebAssembly] Handle TLS symbols in older object file.
Jan 27 2022, 4:42 PM · Restricted Project
tlively accepted D118414: [lld][WebAssembly] Handle TLS symbols in older object file.

Should we try to get some patch backported to the 13.x.x releases to get them out of the intermediate state that was causing this bug? I guess it's not really important after this fix. Or maybe this fix should be backported?

Jan 27 2022, 4:34 PM · Restricted Project

Jan 20 2022

tlively accepted D117739: [lld][WebAssemlby] Convert test to check disassembly output. NFC.
Jan 20 2022, 9:25 AM · Restricted Project

Jan 18 2022

tlively accepted D117412: [lld][WebAssembly] Perform data relocations during start function.
Jan 18 2022, 2:04 PM · Restricted Project
tlively accepted D117594: [lld][WebAssembly] Reinstate mistakenly disabled test. NFC.
Jan 18 2022, 12:11 PM · Restricted Project

Jan 17 2022

tlively added a comment to D117412: [lld][WebAssembly] Perform data relocations during start function.

Who was previously responsible for applying the data relocs? If it was Emscripten runtime code, does that mean this change will have to land alongside the corresponding Emscripten change? Is there anyone who would be broken by this ABI break who we should notify?

Jan 17 2022, 9:41 PM · Restricted Project

Jan 12 2022

tlively added inline comments to D115327: [WebAssembly] Fix reftype load/store match with idx from call.
Jan 12 2022, 2:02 PM · Restricted Project
tlively accepted D115327: [WebAssembly] Fix reftype load/store match with idx from call.

An example situation where there might be more than one value is in a multivalue call, but Idx should only refer to whichever value is actually used as the offset and I agree that it shouldn't matter whether there are other values in the same node or not.

Jan 12 2022, 2:01 PM · Restricted Project

Dec 15 2021

tlively committed rG61521a5a3dfb: [WebAssembly] Add simd-vector-trunc.ll test missing from 2a4a229 (authored by jingbao).
[WebAssembly] Add simd-vector-trunc.ll test missing from 2a4a229
Dec 15 2021, 9:23 AM

Dec 14 2021

tlively added a comment to D115327: [WebAssembly] Fix reftype load/store match with idx from call.

Code LGTM, but I don't quite understand what the bug was, so I'm not sure about the test coverage.

Dec 14 2021, 12:38 PM · Restricted Project
tlively closed D109481: [WebAssembly] Custom optimization for truncate.

Thanks, @jingbao! I've landed this in https://github.com/llvm/llvm-project/commit/2a4a229d6dcceecbb8bab094b6880e2445a6e465.

Dec 14 2021, 8:46 AM · Restricted Project
tlively committed rG2a4a229d6dcc: [WebAssembly] Custom optimization for truncate (authored by jingbao).
[WebAssembly] Custom optimization for truncate
Dec 14 2021, 8:43 AM

Dec 9 2021

tlively added a comment to D109481: [WebAssembly] Custom optimization for truncate.

@jingbao I was working on landing this, but the CodeGen/WebAssembly/fpclamptosat_vec.ll test had to be updated. Unfortunately Phabricator won't let me attach the changes to this revision, but it looks like this change introduces some new unnecessary masking that was not there before in a couple of the test functions. (It also makes a bunch of good changes!). Would you be able to take a look at that? I'd also be ok with landing this as-is since the improvements looks more significant and more common than the regression.

Dec 9 2021, 9:22 AM · Restricted Project

Dec 6 2021

tlively accepted D113420: [WebAssembly] Implement table instruction intrinsics and ref.null.

LGTM with the extra suggested test, if possible.

Dec 6 2021, 9:07 AM · Restricted Project

Dec 3 2021

tlively accepted D109481: [WebAssembly] Custom optimization for truncate.

Thanks for doing this, @jingbao. Sorry I let it sit for so long. Do you have commit rights or would you like me to land this for you?

Dec 3 2021, 8:39 PM · Restricted Project
tlively accepted D114979: [WebAssembly] Implementation of intrinsic for ref.null and HeapType removal.

LGTM modulo comments. It's nice that we get to delete so much code this way.

Dec 3 2021, 8:31 PM · Restricted Project

Nov 30 2021

tlively added a comment to D114795: [PR52475] Ensure a correct chain in copies to/from hidden sret parameter.

WebAssembly test changes lgtm 👍

Nov 30 2021, 11:42 AM · Restricted Project

Nov 14 2021

tlively added inline comments to D113420: [WebAssembly] Implement table instruction intrinsics and ref.null.
Nov 14 2021, 10:48 PM · Restricted Project
tlively added inline comments to D111227: Implementation of new polymorphic type llvm_anyref_ty.
Nov 14 2021, 10:20 PM · Restricted Project

Nov 8 2021

tlively added inline comments to D111227: Implementation of new polymorphic type llvm_anyref_ty.
Nov 8 2021, 8:47 PM · Restricted Project
tlively accepted D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.
Nov 8 2021, 2:02 PM · Restricted Project

Nov 5 2021

tlively added a comment to D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.

Also, it would be nice to have a test for this, but if it would be too much trouble, then I guess it's fine.

Nov 5 2021, 11:41 AM · Restricted Project
tlively added inline comments to D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.
Nov 5 2021, 11:41 AM · Restricted Project

Nov 2 2021

tlively added inline comments to D112370: [BasicAA] Use index size instead of pointer size.
Nov 2 2021, 1:43 PM · Restricted Project

Oct 28 2021

tlively accepted D112769: [lld][WebAssemlby] Always enable mutable-globals feature in PIC mode.

"globala" => "globals" in the descriptions (although globala sounds like a great name for something).

Oct 28 2021, 4:20 PM · Restricted Project
tlively committed rGfb67f3d96980: [WebAssembly] Add prototype relaxed float to int trunc instructions (authored by tlively).
[WebAssembly] Add prototype relaxed float to int trunc instructions
Oct 28 2021, 2:02 PM
tlively closed D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.
Oct 28 2021, 2:01 PM · Restricted Project, Restricted Project
tlively accepted D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.

LGTM, thanks!

Oct 28 2021, 1:44 PM · Restricted Project, Restricted Project
tlively accepted D112667: [lld][WebAssembly] Initialize bss segments using memory.fill.
Oct 28 2021, 1:42 PM · Restricted Project
tlively added inline comments to D112667: [lld][WebAssembly] Initialize bss segments using memory.fill.
Oct 28 2021, 9:48 AM · Restricted Project

Oct 27 2021

tlively added a comment to D112667: [lld][WebAssembly] Initialize bss segments using memory.fill.

Oh yeah, I guess we could only do this if bulk memory is enabled.

Oct 27 2021, 4:42 PM · Restricted Project
tlively accepted D112667: [lld][WebAssembly] Initialize bss segments using memory.fill.

Code LGTM, thanks!

Oct 27 2021, 3:56 PM · Restricted Project

Oct 26 2021

tlively added inline comments to D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.
Oct 26 2021, 6:06 PM · Restricted Project, Restricted Project
tlively added inline comments to D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.
Oct 26 2021, 10:23 AM · Restricted Project, Restricted Project

Oct 24 2021

tlively accepted D112266: [WebAssembly] support Memory64 in target_features section.

Thanks!

Oct 24 2021, 10:23 PM · Restricted Project

Oct 20 2021

tlively added inline comments to D111227: Implementation of new polymorphic type llvm_anyref_ty.
Oct 20 2021, 12:01 PM · Restricted Project
tlively committed rGe1fb13401e1b: [WebAssembly] Add prototype relaxed float min max instructions (authored by ngzhian).
[WebAssembly] Add prototype relaxed float min max instructions
Oct 20 2021, 9:42 AM
tlively closed D112146: [WebAssembly] Add prototype relaxed float min max instructions.
Oct 20 2021, 9:42 AM · Restricted Project, Restricted Project
tlively accepted D112146: [WebAssembly] Add prototype relaxed float min max instructions.

LGTM!

Oct 20 2021, 9:32 AM · Restricted Project, Restricted Project

Oct 19 2021

tlively added inline comments to D111227: Implementation of new polymorphic type llvm_anyref_ty.
Oct 19 2021, 6:24 PM · Restricted Project
tlively accepted D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR.

Nice! Just a couple nits but I think this is good to go.

Oct 19 2021, 6:11 PM · Restricted Project, Restricted Project
tlively committed rG2542bfa43a97: [WebAssembly] Add prototype relaxed swizzle instructions (authored by ngzhian).
[WebAssembly] Add prototype relaxed swizzle instructions
Oct 19 2021, 5:53 PM
tlively closed D112022: [WebAssembly] Add prototype relaxed swizzle instructions.
Oct 19 2021, 5:53 PM · Restricted Project, Restricted Project
tlively accepted D112022: [WebAssembly] Add prototype relaxed swizzle instructions.

Thanks! I'll go ahead and land this.

Oct 19 2021, 5:39 PM · Restricted Project, Restricted Project
tlively added a comment to D111919: [RISCV][WebAssembly][TargetLowering] Allow expandCTLZ/expandCTTZ to rely on CTPOP expansion for vectors..

Thanks, the WebAssembly portion LGTM. The TargetLowering.cpp change LGTM as well, modulo that one comment.

Oct 19 2021, 5:08 PM · Restricted Project