Page MenuHomePhabricator

[compiler-rt][profile][RISCV]: Enable Compiler-RT profile build on RISC-V
Needs ReviewPublic

Authored by luismarques on Mar 4 2021, 9:42 AM.

Details

Summary

All of the relevant tests pass.

Diff Detail

Event Timeline

luismarques created this revision.Mar 4 2021, 9:42 AM
luismarques requested review of this revision.Mar 4 2021, 9:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2021, 9:42 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vsk added a comment.Mar 4 2021, 11:36 AM

It's great to see this. Will these tests get picked up by an existing RISCV bot?

In D97966#2604312, @vsk wrote:

It's great to see this. Will these tests get picked up by an existing RISCV bot?

There is no RISC-V bot at the moment. That's something I plan to work on once I have Linux-capable RISC-V hardware (hopefully soon). At the moment I'm just using QEMU for this kind of work, which I feel is too slow for a bot.

vsk added subscribers: ro, eugenis.Mar 4 2021, 2:09 PM

It might help to have a bot online first to avoid shipping a regressed libprofile for RISCV, but I don't want to hold up work that depends on this. I'm not sure what the right call is, cc'ing @ro and @eugenis who have past experience (D40943)