Page MenuHomePhabricator

[lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)
ClosedPublic

Authored by werat on Mar 2 2021, 5:29 AM.

Details

Summary

Apply changes from https://reviews.llvm.org/D91014 to other places where DWARF entries are being processed.

Test case is provided by @jankratochvil.
The test is marked to run only on x64 and exclude Windows and Darwin, because the assembly is not OS-independent.

(First attempt https://reviews.llvm.org/D96778 broke the build bots)

Diff Detail

Event Timeline

werat created this revision.Mar 2 2021, 5:29 AM
werat requested review of this revision.Mar 2 2021, 5:29 AM
Herald added a project: Restricted Project. · View Herald Transcript
jankratochvil accepted this revision.Mar 2 2021, 6:03 AM
jankratochvil added inline comments.
lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s
18
This revision is now accepted and ready to land.Mar 2 2021, 6:03 AM
werat updated this revision to Diff 327469.Mar 2 2021, 8:39 AM

Use clang_host instead of clang

jankratochvil accepted this revision.Mar 2 2021, 9:14 AM
This revision was landed with ongoing or failed builds.Mar 3 2021, 1:28 AM
This revision was automatically updated to reflect the committed changes.