Page MenuHomePhabricator

werat (Andy Yankovsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2020, 4:37 AM (54 w, 6 d)

Recent Activity

Thu, Jun 17

werat accepted D104444: [lldb] Fix complex integer type parsing for GCC.

Is this specific to GCC? To be on the safe side, would it make sense to check like type_name == "__unknown__" && compiler == GCC?

Thu, Jun 17, 5:22 AM · Restricted Project

Wed, Jun 2

werat accepted D103532: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references.

Thanks for fixing this!

Wed, Jun 2, 9:38 AM · Restricted Project
werat added a comment to D103454: [lldb][docs] Document SBType.

Is this code used for auto-generated docs? Could be have this documentation in C++ definitions (lldb/API/SBType.h) as well? I usually just read the C++ source code, but I can imagine having the same docs in two places might be not the best idea...

Wed, Jun 2, 4:06 AM · Restricted Project

May 19 2021

werat committed rG6c83d4a60b7d: [lldb] Enable TestCppBitfields on Windows (authored by werat).
[lldb] Enable TestCppBitfields on Windows
May 19 2021, 8:05 AM
werat closed D102769: [lldb] Enable TestCppBitfields on Windows.
May 19 2021, 8:05 AM · Restricted Project
werat added a comment to D102769: [lldb] Enable TestCppBitfields on Windows.

Accidentally included only two out of three lines in the commit :)

May 19 2021, 6:39 AM · Restricted Project
werat updated the diff for D102769: [lldb] Enable TestCppBitfields on Windows.

remove the @skip

May 19 2021, 6:37 AM · Restricted Project
werat added a reviewer for D102769: [lldb] Enable TestCppBitfields on Windows: teemperor.
May 19 2021, 6:37 AM · Restricted Project
werat updated the summary of D102769: [lldb] Enable TestCppBitfields on Windows.
May 19 2021, 6:37 AM · Restricted Project
werat requested review of D102769: [lldb] Enable TestCppBitfields on Windows.
May 19 2021, 6:36 AM · Restricted Project
werat committed rG0bab7b26f4d9: [lldb] Encode `bool` as unsigned int (authored by werat).
[lldb] Encode `bool` as unsigned int
May 19 2021, 6:33 AM
werat closed D102685: [lldb] Encode `bool` as unsigned int.
May 19 2021, 6:33 AM · Restricted Project

May 18 2021

werat added a comment to D102685: [lldb] Encode `bool` as unsigned int.

Thanks for a quick review!

May 18 2021, 6:39 AM · Restricted Project
werat updated the diff for D102685: [lldb] Encode `bool` as unsigned int.

Keep @skipIfWindows for now
Add more checks in tests

May 18 2021, 6:38 AM · Restricted Project
werat requested review of D102685: [lldb] Encode `bool` as unsigned int.
May 18 2021, 5:44 AM · Restricted Project

May 17 2021

werat committed rGb6e4bfd18571: [APInt][NFC] Fix typo vlalue->value (authored by werat).
[APInt][NFC] Fix typo vlalue->value
May 17 2021, 7:20 AM
werat closed D102618: [APInt][NFC] Fix typo vlalue->value.
May 17 2021, 7:19 AM · Restricted Project
werat added a comment to D102618: [APInt][NFC] Fix typo vlalue->value.

I see some unit tests have failed in the pre-merge checks. Are those flaky? I don't think fixing spelling in the comment should affect the tests :)

May 17 2021, 7:05 AM · Restricted Project
werat removed a reviewer for D102618: [APInt][NFC] Fix typo vlalue->value: RKSimon.
May 17 2021, 6:14 AM · Restricted Project
werat added a reviewer for D102618: [APInt][NFC] Fix typo vlalue->value: RKSimon.
May 17 2021, 6:14 AM · Restricted Project
werat retitled D102618: [APInt][NFC] Fix typo vlalue->value from Fix typo vlalue->value to [APInt][NFC] Fix typo vlalue->value.
May 17 2021, 6:13 AM · Restricted Project
werat requested review of D102618: [APInt][NFC] Fix typo vlalue->value.
May 17 2021, 6:11 AM · Restricted Project

Apr 22 2021

werat added a comment to D98370: [lldb] Fix SBValue::Persist() for constant values.

Be careful here. There are really two kinds of persistent variables: "expression results" and variables created in the expression parser. The former are by design constant. The idea is that you can use them to checkpoint the state of a value and refer to it later. You can use their values in expressions, but they aren't supposed to be modifiable. Those are the ones called $NUM.

The ones you make in an expression, like:

(lldb) expr int $myVar = 20

on the other hand are modifiable.

Apr 22 2021, 1:42 PM · Restricted Project
werat added a comment to D98370: [lldb] Fix SBValue::Persist() for constant values.

Sure. But but when I was poking around at it a little bit, it seems like the other use cases already work, and the only one that was failing was the case where you call persist on a persistent variable. If that is really true, then maybe we should fix the failing case directly.

Apr 22 2021, 7:43 AM · Restricted Project

Apr 21 2021

werat added a comment to D98370: [lldb] Fix SBValue::Persist() for constant values.

If persisting already persistent variables is indeed the only failure case, then I wonder if it wouldn't be more straightforward to just see if the ValueObject is already a persistent variable and have Persist just return the incoming variable.

Apr 21 2021, 3:41 AM · Restricted Project

Apr 13 2021

werat added a comment to D98370: [lldb] Fix SBValue::Persist() for constant values.

@jingham @teemperor ping :)

Apr 13 2021, 8:24 AM · Restricted Project

Mar 13 2021

werat added inline comments to D92643: [lldb] Lookup static const members in FindGlobalVariables.
Mar 13 2021, 5:26 AM · Restricted Project
werat updated the diff for D92643: [lldb] Lookup static const members in FindGlobalVariables.

Address review comments:

  • Don't create expensive ConstString objects
  • Merge ParseStaticConstMemberDIE into ParseVariableDIE
  • Add more test cases
Mar 13 2021, 5:14 AM · Restricted Project

Mar 10 2021

werat added a comment to D98370: [lldb] Fix SBValue::Persist() for constant values.

Hi @teemperor , here's an attempt to fix SBValue::Persist method. I've highlighted a few moments in the patch I'm not so sure about, please let me know what you think. Thanks!

Mar 10 2021, 1:50 PM · Restricted Project
werat requested review of D98370: [lldb] Fix SBValue::Persist() for constant values.
Mar 10 2021, 1:43 PM · Restricted Project

Mar 8 2021

werat committed rG1b7e5d461aee: [lldb] Fix error message in IRInterpreter (authored by werat).
[lldb] Fix error message in IRInterpreter
Mar 8 2021, 7:47 AM
werat closed D98170: [lldb] Fix error message in IRInterpreter.
Mar 8 2021, 7:47 AM · Restricted Project
werat added a comment to D98170: [lldb] Fix error message in IRInterpreter.

I was looking into the issue with SBValue::Persist (https://discord.com/channels/636084430946959380/636732809708306432/817370459284832297) and the logs and errors eventually led me here to IRInterpreter. And the incorrect error message I noticed just by accident :)

Mar 8 2021, 5:07 AM · Restricted Project
werat requested review of D98170: [lldb] Fix error message in IRInterpreter.
Mar 8 2021, 4:44 AM · Restricted Project

Mar 3 2021

werat committed rG3b47bd32f9df: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2) (authored by werat).
[lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)
Mar 3 2021, 1:28 AM
werat closed D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2).
Mar 3 2021, 1:28 AM · Restricted Project

Mar 2 2021

werat updated the diff for D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2).

Use clang_host instead of clang

Mar 2 2021, 8:39 AM · Restricted Project
werat abandoned D97696: [lldb] Enable cross CU decl file test only for x64 Linux.

The original commit was reverted, abandon in favor of https://reviews.llvm.org/D97765

Mar 2 2021, 5:30 AM · Restricted Project
werat requested review of D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2).
Mar 2 2021, 5:29 AM · Restricted Project

Mar 1 2021

werat requested review of D97696: [lldb] Enable cross CU decl file test only for x64 Linux.
Mar 1 2021, 8:51 AM · Restricted Project
werat added a comment to D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

The test was also executed on lldb-aarch64-ubuntu -- https://lab.llvm.org/buildbot/#/changes/13868
But we have REQUIRES: x86, shouldn't it exclude ARM?

Mar 1 2021, 8:49 AM · Restricted Project
werat committed rG7ec7876feda4: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (authored by werat).
[lldb] Fix handling of `DW_AT_decl_file` according to D91014
Mar 1 2021, 7:06 AM
werat closed D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.
Mar 1 2021, 7:06 AM · Restricted Project

Feb 22 2021

werat updated the diff for D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

Added the test cases provided by jankratochvil@

Feb 22 2021, 4:04 AM · Restricted Project

Feb 17 2021

werat added a comment to D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

To be honest, I'm not sure how to reproduce this kind of debug info. I've tried a few examples (e.g. force inline the function from another CU) , but it didn't work.

Feb 17 2021, 9:05 AM · Restricted Project

Feb 16 2021

werat added a comment to D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

Hi @jankratochvil, can you take a look at this, please?

Feb 16 2021, 6:20 AM · Restricted Project
werat requested review of D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.
Feb 16 2021, 6:18 AM · Restricted Project

Feb 9 2021

werat added inline comments to D92643: [lldb] Lookup static const members in FindGlobalVariables.
Feb 9 2021, 12:47 AM · Restricted Project
werat updated the diff for D92643: [lldb] Lookup static const members in FindGlobalVariables.

Change DW_AT_decl_file handling as per @jankratochvil comment.

Feb 9 2021, 12:46 AM · Restricted Project

Feb 6 2021

werat added a comment to D92643: [lldb] Lookup static const members in FindGlobalVariables.

Thanks for reviewing!

Feb 6 2021, 1:56 AM · Restricted Project
werat added a comment to D92223: [lldb] Add support for looking up static const members.

This patch may be superseded by D92643, not sure.

Feb 6 2021, 1:45 AM · Restricted Project

Feb 2 2021

werat added a comment to D92164: Make CommandInterpreter's execution context the same as debugger's one..

Removed test since the same case was added by D95761.

Feb 2 2021, 2:05 AM · Restricted Project

Feb 1 2021

werat added a comment to D95761: [lldb] Use current execution context in SBDebugger.

Thanks for the review! Can you submit it for me, since I don't have commit access?

Feb 1 2021, 3:24 AM · Restricted Project

Jan 31 2021

werat added reviewers for D95761: [lldb] Use current execution context in SBDebugger: JDevlieghere, jarin.
Jan 31 2021, 7:53 AM · Restricted Project
werat requested review of D95761: [lldb] Use current execution context in SBDebugger.
Jan 31 2021, 7:52 AM · Restricted Project

Jan 10 2021

werat added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

Thanks for the explanation, this makes sense. I've checked the mailing list archives and it seems there was already a discussion about the enumerators in the .debug_names index back in 2018 -- http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2018-April/004443.html. You were the one to bring it up and the consensus was that the enumerators should go into the index too.

Jan 10 2021, 6:25 AM · Restricted Project

Jan 8 2021

werat updated the diff for D94077: Support unscoped enumeration members in the expression evaluator..

Generate fully qualified names for enum constants.

Jan 8 2021, 4:23 AM · Restricted Project
werat added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

This suffers from the same problem as the other patch, where the other index classes (apple_names and debug_names) will essentially never be able to implement this feature. (Unless they re-index the dwarf themselves, that is, but this would defeat the purpose of having the index in the first place.)

Jan 8 2021, 2:22 AM · Restricted Project
werat added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

We can have unscoped enums in namespace and class scope and the enumerators won't leak out from those scopes. Thus we can have shadowing going on e.g.:

...

How does this change deal with those cases?

Jan 8 2021, 2:14 AM · Restricted Project
werat updated the diff for D94077: Support unscoped enumeration members in the expression evaluator..

Handle enum constants similar to global variables, support scoped lookup in the expression evaluator.
Add more test cases.

Jan 8 2021, 2:08 AM · Restricted Project

Jan 5 2021

werat added a comment to D92643: [lldb] Lookup static const members in FindGlobalVariables.

@labath @jankratochvil ping :)

Jan 5 2021, 6:02 AM · Restricted Project
werat updated subscribers of D94077: Support unscoped enumeration members in the expression evaluator..
Jan 5 2021, 3:28 AM · Restricted Project
werat added reviewers for D94077: Support unscoped enumeration members in the expression evaluator.: teemperor, labath, jingham, JDevlieghere.
Jan 5 2021, 3:27 AM · Restricted Project
werat updated the diff for D94077: Support unscoped enumeration members in the expression evaluator..

Fix formatting

Jan 5 2021, 3:24 AM · Restricted Project
werat requested review of D94077: Support unscoped enumeration members in the expression evaluator..
Jan 5 2021, 3:22 AM · Restricted Project

Dec 22 2020

werat added a comment to D93696: Add SBType::GetEnumerationIntegerType method.

Thanks for a quick review! Can you please land these changes for me since I don't have commit access.

Dec 22 2020, 10:05 AM · Restricted Project
werat added inline comments to D93696: Add SBType::GetEnumerationIntegerType method.
Dec 22 2020, 10:04 AM · Restricted Project
werat updated the diff for D93696: Add SBType::GetEnumerationIntegerType method.

Remove the test case for unscoped enum, because it's implementation defined and can break any moment.

Dec 22 2020, 10:03 AM · Restricted Project
werat updated the diff for D93696: Add SBType::GetEnumerationIntegerType method.

Register the new method using lldb-instr.

Dec 22 2020, 10:01 AM · Restricted Project
werat added inline comments to D93690: Add SBType::IsScopedEnumerationType method.
Dec 22 2020, 9:57 AM · Restricted Project
werat updated the diff for D93690: Add SBType::IsScopedEnumerationType method.

Register the new method using lldb-instr.

Dec 22 2020, 9:56 AM · Restricted Project
werat added reviewers for D93696: Add SBType::GetEnumerationIntegerType method: teemperor, JDevlieghere.
Dec 22 2020, 6:12 AM · Restricted Project
werat requested review of D93696: Add SBType::GetEnumerationIntegerType method.
Dec 22 2020, 6:07 AM · Restricted Project
werat added reviewers for D93690: Add SBType::IsScopedEnumerationType method: teemperor, JDevlieghere.
Dec 22 2020, 4:47 AM · Restricted Project
werat requested review of D93690: Add SBType::IsScopedEnumerationType method.
Dec 22 2020, 4:45 AM · Restricted Project

Dec 10 2020

werat added a comment to D92643: [lldb] Lookup static const members in FindGlobalVariables.

Thanks for your review! If there are no objections to this patch, can you accept and land it for me? :)

Dec 10 2020, 4:07 AM · Restricted Project

Dec 8 2020

werat added a comment to D92643: [lldb] Lookup static const members in FindGlobalVariables.

@labath @teemperor gentle ping :) What do you think about this approach?

Dec 8 2020, 6:51 AM · Restricted Project

Dec 4 2020

werat added a comment to D92643: [lldb] Lookup static const members in FindGlobalVariables.

I couldn't tell what you meant by this... I would expect that a Type would tell you that static members exist, and their type, etc. But I wouldn't expect a Type to be able to get a value for a static member. After all, the type comes from some Module, which could be shared amongst a bunch of processes in lldb. The actual member value could be different in each of these processes, but since the Type has no process, it has no way to get the correct value.

Dec 4 2020, 10:30 AM · Restricted Project
werat added a comment to D92643: [lldb] Lookup static const members in FindGlobalVariables.

Are the static members included in the (SB)Type object that gets created when parsing the enclosing type? If yes, we might be able to retrieve them that way. Whether that would be cleaner -- I'm not sure...

(I would expect they are included, as otherwise they would be unavailable to the expression evaluator.)

Dec 4 2020, 3:00 AM · Restricted Project
werat edited reviewers for D92643: [lldb] Lookup static const members in FindGlobalVariables, added: labath, jarin, teemperor, jankratochvil; removed: jdoerfert.

Hi, please, take a look at this patch!

Dec 4 2020, 2:28 AM · Restricted Project
werat requested review of D92643: [lldb] Lookup static const members in FindGlobalVariables.
Dec 4 2020, 2:25 AM · Restricted Project

Nov 30 2020

werat added a comment to D92223: [lldb] Add support for looking up static const members.

Pavel, thanks for review!

Nov 30 2020, 3:21 AM · Restricted Project

Nov 28 2020

werat abandoned D88247: Fix memory leak in SBValue::GetAddress.

Refactored in D88249 to avoid this problem altogether.

Nov 28 2020, 6:27 AM · Restricted Project

Nov 27 2020

werat updated the diff for D92223: [lldb] Add support for looking up static const members.

Remove unused field

Nov 27 2020, 7:36 AM · Restricted Project
werat updated the diff for D92223: [lldb] Add support for looking up static const members.

Simplified the test according to teemperor's comments.

Nov 27 2020, 7:32 AM · Restricted Project
werat added reviewers for D92223: [lldb] Add support for looking up static const members: jarin, aprantl, shafik.

Hi, please, take a look at this patch.

Nov 27 2020, 7:27 AM · Restricted Project
werat requested review of D92223: [lldb] Add support for looking up static const members.
Nov 27 2020, 5:53 AM · Restricted Project

Nov 3 2020

werat added a comment to D90318: Return actual type from SBType::GetArrayElementType.

Ping :)
@teemperor @JDevlieghere

Nov 3 2020, 5:43 AM · Restricted Project

Oct 29 2020

werat added a comment to D90318: Return actual type from SBType::GetArrayElementType.

Btw, I don't have commit access, so would be great if someone could land this for me :) (if everything is OK with this patch).

Oct 29 2020, 9:19 AM · Restricted Project

Oct 28 2020

werat requested review of D90318: Return actual type from SBType::GetArrayElementType.
Oct 28 2020, 10:11 AM · Restricted Project

Oct 26 2020

werat added a comment to D90151: Fix SBError::SetErrorToGenericError.

Thanks! Yeah, I don't have commit access, thanks for landing it for me.

Oct 26 2020, 6:44 AM · Restricted Project
werat updated the diff for D90151: Fix SBError::SetErrorToGenericError.

Add a test case.

Oct 26 2020, 6:41 AM · Restricted Project
werat requested review of D90151: Fix SBError::SetErrorToGenericError.
Oct 26 2020, 5:09 AM · Restricted Project

Sep 25 2020

werat accepted D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer..

Thanks for refactoring this!

Sep 25 2020, 6:11 AM · Restricted Project
werat added a comment to D88247: Fix memory leak in SBValue::GetAddress.

Thanks for reviewing and writing a follow-up change! Changing the ctor to accept a const reference is indeed a cleaner solution.

Sep 25 2020, 6:07 AM · Restricted Project

Sep 24 2020

werat requested review of D88247: Fix memory leak in SBValue::GetAddress.
Sep 24 2020, 10:04 AM · Restricted Project

Jun 2 2020

werat added a comment to D80995: [Scalar] Fix assignment operator for long long..

Looks good. Given the timings, I am going to assume you are coordinating with @miko.

Jun 2 2020, 6:36 AM · Restricted Project
werat created D80995: [Scalar] Fix assignment operator for long long..
Jun 2 2020, 5:31 AM · Restricted Project
werat added a reviewer for D80995: [Scalar] Fix assignment operator for long long.: teemperor.
Jun 2 2020, 5:31 AM · Restricted Project