Page MenuHomePhabricator

[lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU
ClosedPublic

Authored by jankratochvil on Nov 7 2020, 1:34 PM.

Details

Summary

This would be reproducible in future DWZ category of the testsuite as:

Failed Tests (1):
  lldb-api :: python_api/symbol-context/two-files/TestSymbolContextTwoFiles.py

Diff Detail

Event Timeline

jankratochvil created this revision.Nov 7 2020, 1:34 PM
jankratochvil requested review of this revision.Nov 7 2020, 1:34 PM
labath accepted this revision.Nov 9 2020, 12:29 AM

Looks good. Thanks for catching that.

I am particularly happy that we now have an explicit DW_FORM_ref_addr test. It's a very interesting/tricky case, but it does not happen all that often in practice.

lldb/test/Shell/SymbolFile/DWARF/DW_AT_decl_file-DW_AT_specification-crosscu.s
98

These almost-aligned comments are fairly disorienting.

146–154

the offset comments are misaligned and incorrect

This revision is now accepted and ready to land.Nov 9 2020, 12:29 AM
This revision was landed with ongoing or failed builds.Nov 9 2020, 1:53 AM
This revision was automatically updated to reflect the committed changes.
jankratochvil marked 2 inline comments as done.Nov 9 2020, 1:54 AM

Thanks; I see you check very every line even in testcases.