Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (105 w, 4 d)

Recent Activity

Mon, Jul 15

jankratochvil committed rGd0ac1888aab4: [lldb] Handle EOF from `lldb-vscode` (authored by jankratochvil).
[lldb] Handle EOF from `lldb-vscode`
Mon, Jul 15, 11:38 PM
jankratochvil committed rL366187: [lldb] Handle EOF from `lldb-vscode`.
[lldb] Handle EOF from `lldb-vscode`
Mon, Jul 15, 11:38 PM
jankratochvil closed D64698: Handle EOF from `lldb-vscode`.
Mon, Jul 15, 11:37 PM · Restricted Project, Restricted Project
jankratochvil committed rL366078: [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout.
[LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout
Mon, Jul 15, 9:21 AM
jankratochvil closed D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout.
Mon, Jul 15, 9:21 AM · Restricted Project, Restricted Project
jankratochvil updated subscribers of D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout.
Mon, Jul 15, 5:47 AM · Restricted Project, Restricted Project
jankratochvil created D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout.
Mon, Jul 15, 5:47 AM · Restricted Project, Restricted Project

Sat, Jul 13

jankratochvil created D64698: Handle EOF from `lldb-vscode`.
Sat, Jul 13, 3:51 PM · Restricted Project, Restricted Project

Wed, Jul 10

jankratochvil added a comment to D62503: Add ReadCStringFromMemory for faster string reads.

Does it sound good to you?

Wed, Jul 10, 11:17 AM · Restricted Project, Restricted Project

Mon, Jul 1

jankratochvil committed rG3f594ed1686b: Fix lookup of symbols at the same address with no size vs. size (authored by jankratochvil).
Fix lookup of symbols at the same address with no size vs. size
Mon, Jul 1, 7:33 AM
jankratochvil committed rL364773: Fix lookup of symbols at the same address with no size vs. size.
Fix lookup of symbols at the same address with no size vs. size
Mon, Jul 1, 7:32 AM
jankratochvil closed D63540: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jul 1, 7:32 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D63540: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jul 1, 7:32 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D63540: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jul 1, 3:05 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D63540: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jul 1, 3:05 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D63868: Unify+fix remote XML libraries handling with the legacy one.

Does this mean that there is a bug in lldb-server, where some memory read requests fail if they span an unreadable page. Can this also be triggered by a $m packet? Would you be interested in distilling that into a test?

Mon, Jul 1, 2:32 AM · Restricted Project

Fri, Jun 28

jankratochvil added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

When I compare the backtrace from GDB and LLDB (on x86_64, I haven't tried aarch64 as x86_64 is much faster=easier to handle):

    frame #2: 0x0000000000401195 sigtest2`handler(sig=6) at sigtest2.c:9:5
#2  0x0000000000401195 in handler (sig=6) at sigtest2.c:9
Fri, Jun 28, 9:08 AM · Restricted Project, Restricted Project

Thu, Jun 27

jankratochvil added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

Shouldn't you add also symbol __restore_rt (Fedora 30 x86_64)?

(gdb) bt
#0  handler (sig=6) at sigtest2.c:7
#1  <signal handler called>
#2  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#3  0x00007ffff7dea895 in __GI_abort () at abort.c:79
#4  0x000000000040118e in abort_caller () at sigtest2.c:12
#5  0x00000000004011c2 in main () at sigtest2.c:23
(gdb) frame 1
#1  <signal handler called>
(gdb) disas
Dump of assembler code for function __restore_rt:
=> 0x00007ffff7dfff00 <+0>:	mov    $0xf,%rax
   0x00007ffff7dfff07 <+7>:	syscall 
   0x00007ffff7dfff09 <+9>:	nopl   0x0(%rax)
End of assembler dump.
Thu, Jun 27, 1:51 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D63540: Fix lookup of symbols at the same address with no size vs. size.

I am saying to leave symbols with zero size as is _if_ there is another symbol that does have a valid size with the same start address.

Thu, Jun 27, 12:36 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D63540: Fix lookup of symbols at the same address with no size vs. size.
Thu, Jun 27, 12:29 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D63540: Fix lookup of symbols at the same address with no size vs. size.

Why was it necessary to change the iteration order here?

Thu, Jun 27, 12:25 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D63868: Unify+fix remote XML libraries handling with the legacy one.

I don't think we can stop loading/unloading the libraries in ProcessGDBRemote::LoadModules. The windows dynamic loader relies on this

Thu, Jun 27, 9:06 AM · Restricted Project
jankratochvil added a comment to D62504: Avoid calling LoadModules twice when modules change.

So it does fix the massive regression of D62503 similarly as my D63868 but it still has 2 regressions there (=Fedora 30 x86_64, after reapplication of D62503), I haven't yet investigated why:

lldb-Suite :: functionalities/load_unload/TestLoadUnload.py
lldb-Suite :: functionalities/load_using_paths/TestLoadUsingPaths.py
Thu, Jun 27, 8:31 AM · Restricted Project
jankratochvil updated the summary of D63868: Unify+fix remote XML libraries handling with the legacy one.
Thu, Jun 27, 4:32 AM · Restricted Project
jankratochvil retitled D63868: Unify+fix remote XML libraries handling with the legacy one from Unify+fix remote XML libraries handling with legacy one to Unify+fix remote XML libraries handling with the legacy one.
Thu, Jun 27, 4:06 AM · Restricted Project
jankratochvil added inline comments to D63868: Unify+fix remote XML libraries handling with the legacy one.
Thu, Jun 27, 4:06 AM · Restricted Project
jankratochvil created D63868: Unify+fix remote XML libraries handling with the legacy one.
Thu, Jun 27, 4:06 AM · Restricted Project
jankratochvil abandoned D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation).
Thu, Jun 27, 3:53 AM · Restricted Project
jankratochvil abandoned D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation).
Thu, Jun 27, 3:53 AM · Restricted Project
jankratochvil abandoned D51578: 02/03: Contiguous sections (.debug_info+.debug_types) for D54670==D32167 (.debug_types).
Thu, Jun 27, 3:53 AM · Restricted Project
jankratochvil planned changes to D49968: DWZ 02/06: Refactor DWARFUnit::ExtractDIEsScoped.
Thu, Jun 27, 3:45 AM · Restricted Project
jankratochvil planned changes to D49969: DWZ 04/06: ManualDWARFIndex::GetGlobalVariables for DIEs in PUs.
Thu, Jun 27, 3:45 AM · Restricted Project
jankratochvil planned changes to D40475: DWZ 05/06: DWZ test mode.
Thu, Jun 27, 3:45 AM · Restricted Project
jankratochvil planned changes to D43512: DWZ 06/06: Fix for symlinked .build-id/**.debug files.
Thu, Jun 27, 3:45 AM · Restricted Project
jankratochvil planned changes to D40473: DWZ 01/06: Adjust existing code for the DWZ support.
Thu, Jun 27, 3:45 AM · Restricted Project
jankratochvil planned changes to D40474: DWZ 03/06: Main functionality.
Thu, Jun 27, 3:45 AM · Restricted Project

Tue, Jun 25

jankratochvil added a comment to D62503: Add ReadCStringFromMemory for faster string reads.

I was debugging it yesterday but I have no real result yet. There is/was a problem that initially it is run with:

intern-state     ProcessGDBRemote::GetLoadedModuleList
intern-state     parsing: <library-list-svr4 version="1.0"><library name="/lib64/ld-linux-x86-64.so.2" lm="0x7ffff7ffd990" l_addr="0x7ffff7fd2000" l_ld="0x7ffff7ffcdf0" /><library name="linux-vdso.so.1" lm="0x7ffff7ffe6f0" l_addr="0x7ffff7fd1000" l_ld="0x7ffff7fd1348" /></library-list-svr4>
intern-state     found (link_map:0x7ffff7ffd990, base:0x7ffff7fd2000[offset], ld:0x7ffff7ffcdf0, name:'/lib64/ld-linux-x86-64.so.2')
intern-state     found (link_map:0x7ffff7ffe6f0, base:0x7ffff7fd1000[offset], ld:0x7ffff7fd1348, name:'linux-vdso.so.1')
intern-state     found 2 modules in total

but later the module list is not refreshed with more libraries, DynamicLoaderPOSIXDYLD::RendezvousBreakpointHit just does not happen.
PASS vs. FAIL
But there may be also some other patch involved as one regression was fixed by rL363770 but that was not everything.

Tue, Jun 25, 9:36 PM · Restricted Project, Restricted Project

Jun 19 2019

jankratochvil created D63540: Fix lookup of symbols at the same address with no size vs. size.
Jun 19 2019, 3:54 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D62502: Implement xfer:libraries-svr4:read packet.

Even after @labath's rL363772 the testcase TestGdbRemoteLibrariesSvr4Support is still FAILing on Fedora 30 x86_64, I will check it more later.

Jun 19 2019, 3:46 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D62503: Add ReadCStringFromMemory for faster string reads.

There is a regression on Fedora 30 x86_64:

Failing Tests (25):
    LLDB :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test
    lldb-Suite :: expression_command/call-function/TestCallStdStringFunction.py
    lldb-Suite :: expression_command/formatters/TestFormatters.py
    lldb-Suite :: expression_command/radar_9531204/TestPrintfAfterUp.py
    lldb-Suite :: expression_command/test/TestExprs.py
    lldb-Suite :: functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py
    lldb-Suite :: functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
    lldb-Suite :: functionalities/breakpoint/move_nearest/TestMoveNearest.py
    lldb-Suite :: functionalities/inferior-assert/TestInferiorAssert.py
    lldb-Suite :: functionalities/load_unload/TestLoadUnload.py
    lldb-Suite :: functionalities/load_using_paths/TestLoadUsingPaths.py
    lldb-Suite :: functionalities/thread/num_threads/TestNumThreads.py
    lldb-Suite :: functionalities/unwind/noreturn/TestNoreturnUnwind.py
    lldb-Suite :: lang/c/conflicting-symbol/TestConflictingSymbol.py
    lldb-Suite :: lang/c/function_types/TestFunctionTypes.py
    lldb-Suite :: lang/c/global_variables/TestGlobalVariables.py
    lldb-Suite :: lang/c/shared_lib/TestSharedLib.py
    lldb-Suite :: lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py
    lldb-Suite :: lang/cpp/auto/TestCPPAuto.py
    lldb-Suite :: lang/cpp/exceptions/TestCPPExceptionBreakpoints.py
    lldb-Suite :: lang/cpp/namespace_definitions/TestNamespaceDefinitions.py
    lldb-Suite :: python_api/thread/TestThreadAPI.py
    lldb-Suite :: tools/lldb-mi/breakpoint/TestMiBreak.py
    lldb-Suite :: tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
    lldb-Suite :: tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py

This line may is maybe a different issue:

lldb-Suite :: functionalities/unwind/noreturn/TestNoreturnUnwind.py
lldb-Suite :: tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
Jun 19 2019, 3:39 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D63467: [Reproducers] Make reproducer relocatable.
Jun 19 2019, 2:42 AM · Restricted Project, Restricted Project

Jun 17 2019

jankratochvil added a comment to D63441: [zorg] Add lldb-arm-ubuntu builder.

It ll run on staging master until tests become stable.

Jun 17 2019, 10:30 AM · Restricted Project
jankratochvil added a comment to D63441: [zorg] Add lldb-arm-ubuntu builder.

LGTM but I will leave the approval for @labath.

Jun 17 2019, 10:29 AM · Restricted Project
jankratochvil committed rG8c82c41262fa: [lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more… (authored by jankratochvil).
[lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more…
Jun 17 2019, 7:45 AM
jankratochvil committed rL363567: [lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more….
[lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more…
Jun 17 2019, 7:45 AM
jankratochvil closed D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases.
Jun 17 2019, 7:45 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases.

It looks like lldb-mi has the --source option. Could that be used to set this setting automatically via lit, as it is done with %lldb ?

Jun 17 2019, 7:06 AM · Restricted Project, Restricted Project

Jun 14 2019

jankratochvil created D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases.
Jun 14 2019, 9:23 AM · Restricted Project, Restricted Project

Jun 13 2019

jankratochvil added a comment to D62849: Moving OpenCLBuiltins.td and remove unused include.

Getting build regression on Linux (Fedora 29 x86_64):

make[2]: *** No rule to make target 'ClangOpenCLBuiltinsImpl', needed by 'tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaLookup.cpp.o'.  Stop.

Using command:

cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Release  -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld"  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ENABLE_ASSERTIONS=ON
Jun 13 2019, 12:07 PM · Restricted Project

Jun 1 2019

jankratochvil added reviewers for D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb: xiaobai, compnerd.
Jun 1 2019, 1:50 PM · Restricted Project
jankratochvil added a comment to D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames.

D62771 does address the same.

Jun 1 2019, 1:36 PM · Restricted Project, Restricted Project
jankratochvil removed reviewers for D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb: xiaobai, compnerd.
Jun 1 2019, 1:33 PM · Restricted Project
jankratochvil added a comment to D62634: Improve DWARF parsing and accessing by 1% to 2%.

On Fedora 29 x86_64 it broke:

FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: test_enable_dwo (TestBreakpointLocations.BreakpointLocationsTestCase)
FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: test_shadowed_command_options_dwo (TestBreakpointLocations.BreakpointLocationsTestCase)
FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: test_shadowed_cond_options_dwo (TestBreakpointLocations.BreakpointLocationsTestCase)
Jun 1 2019, 5:07 AM

May 23 2019

jankratochvil added a comment to D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

returning lldb::thread_result_t() is probably the best thing to do here...

May 23 2019, 6:47 AM · Restricted Project
jankratochvil committed rG19a3c307310f: Simplify `GetName`+`AppendTypeName` by `DWARFDIE` (authored by jankratochvil).
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
May 23 2019, 12:59 AM
jankratochvil committed rL361463: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
May 23 2019, 12:59 AM
jankratochvil committed rLLDB361463: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
May 23 2019, 12:59 AM
jankratochvil closed D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
May 23 2019, 12:59 AM · Restricted Project

May 22 2019

jankratochvil updated the diff for D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.

I have moved it to DWARFDIE.cpp. I agree that it is probably all irrelevant after moving to the LLVM DWARF/ part. I have also removed return type as (1) it was wrong in one case and (2) no existing caller used the return type. I also refactored the deep nesting noted by @JDevlieghere.
I can also remove all the dumping code instead upon request, @labath.

May 22 2019, 8:59 AM · Restricted Project
jankratochvil requested changes to D62243: Added a dot at the end of comment.

When committing it, there are two more comments without dot in this file.

May 22 2019, 4:19 AM · Restricted Project

May 21 2019

jankratochvil updated the diff for D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
May 21 2019, 12:20 PM · Restricted Project
jankratochvil added inline comments to D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
May 21 2019, 12:20 PM · Restricted Project
jankratochvil created D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
May 21 2019, 11:08 AM · Restricted Project
jankratochvil committed rGb7a19321442a: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *` (authored by jankratochvil).
Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
May 21 2019, 10:37 AM
jankratochvil committed rLLDB361277: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
May 21 2019, 10:37 AM
jankratochvil committed rL361277: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
May 21 2019, 10:37 AM
jankratochvil closed D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
May 21 2019, 10:36 AM · Restricted Project, Restricted Project
jankratochvil committed rL361247: builder lldb-x86_64-fedora: more verbosity.
builder lldb-x86_64-fedora: more verbosity
May 21 2019, 4:55 AM
jankratochvil closed D62182: builder lldb-x86_64-fedora: more verbosity.
May 21 2019, 4:55 AM · Restricted Project
jankratochvil accepted D62182: builder lldb-x86_64-fedora: more verbosity.

As this change is local to our lldb-x86_64-fedora (which is even still silent) it is good to go.

May 21 2019, 4:39 AM · Restricted Project

May 20 2019

jankratochvil abandoned D61505: Implement .debug_types.

It should be obsoleted by D62073 and future @labath patches.

May 20 2019, 2:21 AM · Restricted Project

May 16 2019

jankratochvil updated the diff for D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
May 16 2019, 8:29 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.

Seems like a nice cleanup. Given that code code already assumed that the DWARFUnit can't be null, I'd just delete the null checks..

May 16 2019, 8:27 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D62008: DWARF: Introduce DWARFTypeUnit class.

On Fedora 29 x86_64 I get:

May 16 2019, 7:48 AM · Restricted Project
jankratochvil added inline comments to D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
May 16 2019, 7:39 AM · Restricted Project, Restricted Project
jankratochvil created D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
May 16 2019, 7:36 AM · Restricted Project, Restricted Project

May 15 2019

jankratochvil committed rGe8a039d62c7e: Permit cross-CU references (authored by jankratochvil).
Permit cross-CU references
May 15 2019, 12:20 PM
jankratochvil committed rLLDB360795: Permit cross-CU references.
Permit cross-CU references
May 15 2019, 12:20 PM
jankratochvil committed rL360795: Permit cross-CU references.
Permit cross-CU references
May 15 2019, 12:20 PM
jankratochvil closed D61502: Permit cross-CU references.
May 15 2019, 12:20 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D61502: Permit cross-CU references.

Just a few simplifications to GetName() and AppendTypeName() are in question and can optionally be done if needed.

May 15 2019, 12:17 PM · Restricted Project, Restricted Project

May 14 2019

jankratochvil retitled D61505: Implement .debug_types from 06/06: Implement .debug_types to Implement .debug_types.
May 14 2019, 12:41 PM · Restricted Project
jankratochvil planned changes to D61505: Implement .debug_types.
May 14 2019, 12:41 PM · Restricted Project
jankratochvil removed a child revision for D61504: 05/06: Track CUs and TUs separately: D61505: Implement .debug_types.
May 14 2019, 12:38 PM · Restricted Project
jankratochvil removed a parent revision for D61505: Implement .debug_types: D61504: 05/06: Track CUs and TUs separately.
May 14 2019, 12:38 PM · Restricted Project
jankratochvil added a parent revision for D61505: Implement .debug_types: D61502: Permit cross-CU references.
May 14 2019, 12:38 PM · Restricted Project
jankratochvil removed a parent revision for D61503: 04/06: Track .debug_types vs. .debug_info difference: D61502: Permit cross-CU references.
May 14 2019, 12:38 PM · Restricted Project
jankratochvil edited child revisions for D61502: Permit cross-CU references, added: 1; removed: 1.
May 14 2019, 12:38 PM · Restricted Project, Restricted Project
jankratochvil edited parent revisions for D61502: Permit cross-CU references, added: 1; removed: 1.
May 14 2019, 12:38 PM · Restricted Project, Restricted Project
jankratochvil removed a child revision for D61501: 02/06: Finish renaming CompileUnit->Unit: D61502: Permit cross-CU references.
May 14 2019, 12:38 PM · Restricted Project, Restricted Project
jankratochvil added a child revision for D61908: DWARF: Add ability to reference debug info coming from multiple sections: D61502: Permit cross-CU references.
May 14 2019, 12:38 PM · Restricted Project
jankratochvil updated the diff for D61502: Permit cross-CU references.
May 14 2019, 12:38 PM · Restricted Project, Restricted Project
jankratochvil abandoned D61504: 05/06: Track CUs and TUs separately.

Obsoleted by: D61908

May 14 2019, 12:30 PM · Restricted Project
jankratochvil abandoned D61503: 04/06: Track .debug_types vs. .debug_info difference.

Obsoleted by: D61908

May 14 2019, 12:30 PM · Restricted Project

May 10 2019

jankratochvil added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

If you have simple gdb startup commands then translating them into the lldb way should be straightforward, and the burden of learning how lldb works from the command line for these purposes is just not that great and if you are going to use lldb you should just buck up and browse "lldb --help" a bit... If you have complex gdb command lines, you are going to have to rework them anyway to deal with other differences between lldb and gdb. I don't think mixing the two would add enough value to be worth the uglification.

May 10 2019, 11:42 AM · Restricted Project
jankratochvil added a comment to D61501: 02/06: Finish renaming CompileUnit->Unit.

Thanks for the review, I have pushed it ahead of the rest of the series as it was a bit annoying to keep it updating off-trunk. And then the renaming is a correct cleanup anyway.

May 10 2019, 10:15 AM · Restricted Project, Restricted Project
jankratochvil committed rG605627374e16: Finish renaming CompileUnit -> Unit (authored by jankratochvil).
Finish renaming CompileUnit -> Unit
May 10 2019, 10:14 AM
jankratochvil committed rLLDB360443: Finish renaming CompileUnit -> Unit.
Finish renaming CompileUnit -> Unit
May 10 2019, 10:14 AM
jankratochvil committed rL360443: Finish renaming CompileUnit -> Unit.
Finish renaming CompileUnit -> Unit
May 10 2019, 10:14 AM
jankratochvil closed D61501: 02/06: Finish renaming CompileUnit->Unit.
May 10 2019, 10:14 AM · Restricted Project, Restricted Project