- User Since
- Jul 10 2017, 11:37 AM (143 w, 1 d)
Implemented all the review comments.
Sat, Apr 4
LGTM, thanks for the cleanup.
Fri, Apr 3
I have checked in the really obvious parts as rG80237523193d.
The remainder is left here - although I do not see there more problematic parts now.
Thu, Apr 2
Wed, Apr 1
Mon, Mar 30
Sat, Mar 28
Here is some preview of the style I chose. It is sure regression free.
It is not intended for serious review but any ideas are sure welcome.
I plan to rebase my DWZ patchset on top of it to verify how complete it is.
Wed, Mar 25
The ASan GCC report was valid ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) but that was really just the first/previous version of the patch.
I will try to check why clang ASan does not report it (and also GCC ASan on a minimal reproducer does not report it for me).
Tue, Mar 24
Mon, Mar 23
I do not have the testsuite running with ASAN (it is also failing for me) but I expected to at least run by hand ASAN-built LLDB for the code modified by this patch.
Sun, Mar 22
Have you run the build with address sanitizer?
Fri, Mar 20
Thu, Mar 19
Wed, Mar 18
On Fedora 31 x86_64 with LLDB using python3 I got:
llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '.../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py', traceback: Traceback (most recent call last): File ".../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path exec(compile(data, path, 'exec'), cfg_globals, None) File ".../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py", line 20, in <module> config.lldb_enable_debuginfod = TRUE NameError: name 'TRUE' is not defined make: *** [tools/lldb/test/CMakeFiles/check-lldb-lit.dir/build.make:58: tools/lldb/test/CMakeFiles/check-lldb-lit] Error 2
It helped to change:
- set(Debuginfod_FOUND TRUE) + set(Debuginfod_FOUND 1)
Tue, Mar 17
With the former patch these both skeleton files:
were referencing to this one non-skeleton file:
Surprisingly it does not affect the other test debug-types-basic.test probably because it compiles to .o and then links it. While debug-types-expressions.test compiles directly to an executable.
So fixed that while keeping the direct executable compilation.
Feb 18 2020
Feb 17 2020
Sorry for that DenseMap::insert, I see it is the same as std::map, I should study DenseMap more.
Feb 16 2020
Feb 15 2020
Feb 14 2020
Feb 13 2020
Feb 11 2020
This patch reverts commit 6b2979c12300b90a1e69791d43ee9cff14f4265e
Feb 10 2020
Feb 9 2020
That testcase has been created by D62502.