Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (167 w, 4 d)

Recent Activity

Aug 26 2020

jankratochvil committed rGb20a4e293c3b: [Support] Speedup llvm-dwarfdump 3.9x (authored by jankratochvil).
[Support] Speedup llvm-dwarfdump 3.9x
Aug 26 2020, 1:30 AM
jankratochvil closed D86406: Speedup llvm-dwarfdump 3.9x.
Aug 26 2020, 1:30 AM · Restricted Project

Aug 25 2020

jankratochvil updated the diff for D86406: Speedup llvm-dwarfdump 3.9x.
Aug 25 2020, 11:31 AM · Restricted Project
jankratochvil updated the diff for D86406: Speedup llvm-dwarfdump 3.9x.

Can you change raw_fd_ostream::has_colors to memoize the result of FileDescriptorHasColors(FD) instead?

Aug 25 2020, 9:36 AM · Restricted Project
jankratochvil added a comment to D86406: Speedup llvm-dwarfdump 3.9x.

If I understand the patch correctly, the speedup is gained by caching the mode instead of trying to recompute it every time we call colorsEnabled()?

Aug 25 2020, 12:25 AM · Restricted Project

Aug 24 2020

jankratochvil planned changes to D86406: Speedup llvm-dwarfdump 3.9x.

Also, perhaps this should be done by the stream itself - it seems like the stream knows whether or not it supports colours, so should we not just have the stream ignore attempts to use colours if the underlying thing doesn't support them?

Aug 24 2020, 12:26 AM · Restricted Project

Aug 22 2020

jankratochvil requested review of D86406: Speedup llvm-dwarfdump 3.9x.
Aug 22 2020, 1:17 PM · Restricted Project

Aug 19 2020

jankratochvil added a comment to D85539: [lldb] Extend builder to pass the TRIPLE spec to Make.

It broke the Debian buildbot: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/16095
And also Fedora (although there the commit looks as a different one): http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=10000

Aug 19 2020, 3:16 PM · Restricted Project

Aug 18 2020

jankratochvil committed rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies (authored by jankratochvil).
[lldb] [testsuite] Add split-file for check-lldb dependencies
Aug 18 2020, 9:11 AM
jankratochvil closed D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies.
Aug 18 2020, 9:11 AM · Restricted Project
jankratochvil requested review of D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies.
Aug 18 2020, 8:52 AM · Restricted Project

Aug 6 2020

jankratochvil added a comment to D85100: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD.

It broke Linux buildbots:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/15235/steps/test/logs/stdio
http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/10451/steps/test/logs/stdio

Aug 6 2020, 2:58 AM · Restricted Project, Restricted Project

Aug 2 2020

jankratochvil added a comment to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

The DWARF in the source file appears to be broken, the test fails for me on openSUSE 15.2 x86_64, with errors about DIE references outside of its CU. It fails even if I try to manually compile and debug the file, with Clang git or 9, GCC 7.5 or 9, LLDB git or 9, GDB 9.2.

Aug 2 2020, 1:45 PM · Restricted Project
jankratochvil committed rGe6c2c9a7d151: [lldb] [test] Fix DW_TAG_GNU_call_site-DW_AT_low_pc.s relocation (authored by jankratochvil).
[lldb] [test] Fix DW_TAG_GNU_call_site-DW_AT_low_pc.s relocation
Aug 2 2020, 1:42 PM

Jun 29 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

At this point I'm getting very lost in this patch,

Jun 29 2020, 5:54 AM · Restricted Project

Jun 28 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

The filename should not be checked from SymbolContext::function but rather from SymbolContext::line_entry. As that is cheaper. And when one asks for breakpoint at 1a.h:1 then it is enough to check .debug_line (which needs to be checked anyway) and why to look into .debug_info for the function name etc. at all?
I think there is even a bug due to the Function being involved and not just line_entry:

tail -n99 1b.c 1b.h;clang -o 1b 1b.c -Wall -g;~/redhat/llvm-monorepo2-clangassert/bin/lldb -batch ./1a -o 'breakpoint set -f 1b.h -l 1' 
==> 1b.c <==
static void func(void) {}
int main(void) {
#include "1b.h"
  return 0;
}
==> 1b.h <==
  func();
(lldb) target create "./1a"
Current executable set to '/home/jkratoch/t/1a' (x86_64).
(lldb) breakpoint set -f 1b.h -l 1
Breakpoint 1: no locations (pending).
WARNING:  Unable to resolve breakpoint to any actual locations.

For a practical use case the 1b.h should be rather called 1b.def, there are such files found in many GNU projects - although usually the *.def files are included into data structs and not into function code. But still. This reproducer should be even a part of the testcase for your patch.

Jun 28 2020, 1:59 PM · Restricted Project

Jun 26 2020

jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 26 2020, 3:13 AM · Restricted Project
jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 26 2020, 3:13 AM · Restricted Project

Jun 25 2020

jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 25 2020, 12:29 AM · Restricted Project

Jun 24 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

Just some notes of mine to find out which functions get used in which breakpoint case:

-o 'breakpoint set -f main.c -l 1' -o q
-o 'b main.c:1'     
lldb/source/Commands/CommandObjectBreakpoint.cpp:578 = eSetTypeFileAndLine
lldb/source/Target/Target.cpp:330 = GetInlineStrategy()    
BreakpointSP Target::CreateBreakpoint(const FileSpecList *containingModules,
                                      const FileSpec &file, uint32_t line_no,
  lldb/source/Target/Target.cpp:622
Jun 24 2020, 2:07 PM · Restricted Project
jankratochvil accepted D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

It's not related, at least not directly.

Jun 24 2020, 9:10 AM · Restricted Project

Jun 23 2020

jankratochvil added a comment to D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

I do not understand why the testcase has two epilogues. The UnwindAssembly_x86::AugmentUnwindPlanFromCallSite() code tests only beginning and end of CFI, it does not read anything in between.
The simplified testcase works the same for me: https://people.redhat.com/jkratoch/D82378.patch

Jun 23 2020, 1:58 PM · Restricted Project
jankratochvil added a comment to D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

Now this situation is not actually handled by lldb's "augmenter", so the example somewhat shaky, but it does show that there are gaps in clang/llvm modelling of unwind info.

Jun 23 2020, 10:10 AM · Restricted Project
jankratochvil added a comment to D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

I do not like much this approach but it fixes this case. I would prefer checking DW_AT_producer together with -grecord-gcc-switches.
I was trying GCC and clang and all the IMO relevant options and I can get either no .eh_frame/.debug_frame or an asynchronous one.:

(set -ex;rm -rf udir;mkdir udir;cd udir;rm -f *;for e in -f{,no-}exceptions;do for u in -f{,no-}asynchronous-unwind-tables;do for a in -f{,no-}unwind-tables;do for c in clang gcc;do echo 'int main(void){return 0;}'|$c $e $a $u -o $c$e$u$a -x c -;done;done;done;done;for i in $(sha256sum *|sort|awk '{x[$1]=$2}END{for (y in x) print x[y]}');do nm $i|grep -w main;readelf -wf $i;done) 2>&1|less

So I think current compilers no longer produce non-asynchronous unwind tables (that should be verified in the gcc+clang code which I did not) and a simple compiler version check in DW_AT_producer would be enough (even without checking compilation options).

Jun 23 2020, 7:58 AM · Restricted Project

Jun 15 2020

jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 15 2020, 8:07 AM · Restricted Project

Jun 11 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

I would separate/remove all [nfc] changes from this patch as they complicate it a bit. Such cleaned up patch I have prepared for myself: https://people.redhat.com/jkratoch/D74136-cleanup.patch

Jun 11 2020, 12:40 PM · Restricted Project

Jun 9 2020

jankratochvil committed rG4515d35f5c9e: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC (authored by jankratochvil).
[lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC
Jun 9 2020, 4:54 AM
jankratochvil committed rGfd31e60b8ded: [nfc] [lldb] Reduce GetAttributes's depth parameter usage (authored by jankratochvil).
[nfc] [lldb] Reduce GetAttributes's depth parameter usage
Jun 9 2020, 4:54 AM
jankratochvil closed D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 9 2020, 4:54 AM · Restricted Project
jankratochvil closed D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage.
Jun 9 2020, 4:54 AM · Restricted Project
jankratochvil added inline comments to D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage.
Jun 9 2020, 4:54 AM · Restricted Project
jankratochvil added inline comments to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 9 2020, 4:54 AM · Restricted Project

Jun 8 2020

jankratochvil added inline comments to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 8 2020, 1:18 PM · Restricted Project
jankratochvil updated the diff for D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 8 2020, 1:18 PM · Restricted Project
jankratochvil created D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage.
Jun 8 2020, 1:18 PM · Restricted Project

Jun 7 2020

jankratochvil updated the diff for D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
# This tests that lldb is compatible with DWARF-4 entry values GNU extension
# with DW_TAG_GNU_call_site attributes order as produced by GCC:
# 0x000000b1:     DW_TAG_GNU_call_site
#                   DW_AT_low_pc  (0x000000000040111e)
#                   DW_AT_abstract_origin (0x000000cc "a")
# clang produces the attributes in opposite order:
# 0x00000064:     DW_TAG_GNU_call_site
#                   DW_AT_abstract_origin (0x0000002a "a")
#                   DW_AT_low_pc  (0x0000000000401146)
Jun 7 2020, 5:17 AM · Restricted Project

Jun 6 2020

jankratochvil committed rG8fc1e307f9c4: [lldb] [nfc] Fix comment in testcase DW_TAG_variable-DW_AT_const_value.s (authored by jankratochvil).
[lldb] [nfc] Fix comment in testcase DW_TAG_variable-DW_AT_const_value.s
Jun 6 2020, 2:57 PM
jankratochvil updated the diff for D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

The new -1 value for GetAttributes is a bit ugly. But otherwise either

  • CollectCallEdges would need to reimplement GetAttributes.

or

  • trying to guess which attribute belongs to which DIE from DIEOffsetAtIndex but that is also not nice because it is offset of the DIE's attribute, not offset of the DIE itself.
Jun 6 2020, 2:25 PM · Restricted Project
jankratochvil planned changes to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

It regressed other testcases, I have to check it more.

Jun 6 2020, 1:53 PM · Restricted Project
jankratochvil created D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 6 2020, 12:49 PM · Restricted Project

Jun 5 2020

jankratochvil added a comment to D81119: [lldb] Fix SLEB128 decoding.
lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63
lldb-shell :: SymbolFile/DWARF/DW_TAG_variable-DW_AT_const_value.s
Jun 5 2020, 4:22 AM · Restricted Project
jankratochvil committed rG846909e2ab0b: [lldb] Fix UBSan regression in GetSLEB128 (authored by jankratochvil).
[lldb] Fix UBSan regression in GetSLEB128
Jun 5 2020, 3:17 AM

Jun 4 2020

jankratochvil committed rG7fc6d36d4848: [nfc] [lldb] clang-format #include files order (authored by jankratochvil).
[nfc] [lldb] clang-format #include files order
Jun 4 2020, 11:58 PM
jankratochvil committed rG476f520a0bd2: [lldb] Fix SLEB128 decoding (authored by jankratochvil).
[lldb] Fix SLEB128 decoding
Jun 4 2020, 11:03 AM
jankratochvil closed D81119: [lldb] Fix SLEB128 decoding.
Jun 4 2020, 11:01 AM · Restricted Project
jankratochvil added inline comments to D81119: [lldb] Fix SLEB128 decoding.
Jun 4 2020, 11:00 AM · Restricted Project
jankratochvil added a comment to D81119: [lldb] Fix SLEB128 decoding.

PS: You can still just drop the test if you think that's too much hassle. :)

Jun 4 2020, 11:00 AM · Restricted Project
jankratochvil updated the diff for D81119: [lldb] Fix SLEB128 decoding.

Added unit test, simplified the .s test.

Jun 4 2020, 8:44 AM · Restricted Project
jankratochvil planned changes to D81119: [lldb] Fix SLEB128 decoding.
Jun 4 2020, 7:04 AM · Restricted Project

Jun 3 2020

jankratochvil created D81119: [lldb] Fix SLEB128 decoding.
Jun 3 2020, 2:20 PM · Restricted Project
jankratochvil retitled D81119: [lldb] Fix SLEB128 decoding from Fix SLEB128 decoding to [lldb] Fix SLEB128 decoding.
Jun 3 2020, 2:20 PM · Restricted Project

May 29 2020

jankratochvil added inline comments to D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
May 29 2020, 9:45 AM · Restricted Project

May 9 2020

jankratochvil committed rG68a9356bdea6: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol… (authored by jankratochvil).
[lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol…
May 9 2020, 12:29 AM
jankratochvil closed D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files.
May 9 2020, 12:29 AM · Restricted Project

May 8 2020

jankratochvil created D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files.
May 8 2020, 1:57 PM · Restricted Project

May 4 2020

jankratochvil added inline comments to D78421: Fix out of sync source code/executable when debugging.
May 4 2020, 11:48 AM · Restricted Project

Apr 27 2020

jankratochvil planned changes to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.
Apr 27 2020, 1:27 PM · Restricted Project
jankratochvil updated the diff for D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

This is only to get an idea what I am preparing, not for detailed reading. Maybe it should be split even more? It contains both main_unit addition to callbacks:

 void DebugNamesDWARFIndex::GetGlobalVariables(
-    const DWARFUnit &cu, llvm::function_ref<bool(DWARFDIE die)> callback) {
+    const DWARFUnit &cu,
+    llvm::function_ref<bool(DWARFCompileUnit *main_unit, DWARFDIE die)>
+        callback) {

and also data structure extensions like:

-  typedef llvm::DenseMap<const DWARFDebugInfoEntry *, lldb_private::Type *>
+  typedef llvm::DenseMap<
+      std::pair<DWARFCompileUnit *, const DWARFDebugInfoEntry *>,
+      lldb_private::Type *>
       DIEToTypePtr;
...
-  dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
+  dwarf->GetDIEToType()[die.MainCUtoDIEPair(main_unit)] = type_sp.get();

With some needed infrastructure for MainCUtoDIEPair & co.

Apr 27 2020, 1:27 PM · Restricted Project

Apr 24 2020

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

@labath now with existing callbacks

llvm::function_ref<bool(DWARFDIE die)> callback

I am going to add DWARFCompileUnit *main_unit somewhere. BTW it can be nullptr, for example for DIES from type units. In my WIP patches I was putting it in front (as main_unit sort of contains the die):

llvm::function_ref<bool(DWARFCompileUnit *main_unit, DWARFDIE die)> callback

or do you prefer it added at the end?

llvm::function_ref<bool(DWARFDIE die, DWARFCompileUnit *main_unit)> callback

This applies also to API like:

clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(DWARFCompileUnit *main_unit, const DWARFDIE &die) {

vs..

clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(const DWARFDIE &die, DWARFCompileUnit *main_unit) {

I want to prevent using default parameters:

clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(const DWARFDIE &die, DWARFCompileUnit *main_unit = nullptr) {

as that would easily lead to forgetting to delegate main_unit which would only be discovered during DWZ tests (and only if they test such specific API function).

Apr 24 2020, 5:54 AM · Restricted Project

Apr 22 2020

jankratochvil committed rGd482fe2add95: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE (authored by jankratochvil).
[nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE
Apr 22 2020, 8:39 AM
jankratochvil closed D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 22 2020, 8:39 AM · Restricted Project
jankratochvil added a comment to D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.

Thanks for the review and I have learned a new use case for llvm::function_ref.

Apr 22 2020, 8:38 AM · Restricted Project

Apr 21 2020

jankratochvil added a comment to D75750: [lldb] integrate debuginfod.

The current plan discussed with @kwk is to create the new SymbolServer abstract superclass and some its inherited implementation and move there the appropriate parts of existing lldb/source/Symbol/LocateSymbolFile.cpp. Current SymbolVendor implementations would then iterate new SymbolServers by the existing LocateExecutableSymbolFile function. That may be enough for a patch of its own.

I'll have to see the actual patch for a definitive opinion, but I have to say that a priori I am sceptical of this direction. And yes, that should definitely be a separate patch.

Apr 21 2020, 1:35 AM · Restricted Project
jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 21 2020, 1:35 AM · Restricted Project
jankratochvil added inline comments to D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 21 2020, 1:35 AM · Restricted Project
jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 21 2020, 1:35 AM · Restricted Project

Apr 18 2020

jankratochvil added inline comments to D78421: Fix out of sync source code/executable when debugging.
Apr 18 2020, 4:50 AM · Restricted Project
jankratochvil added a comment to rGacb0b99c8e4f: [lldb][NFC] Modernize lang/cpp/scope test.

I have fixed it up by rG239093f30c34, the original testcase was not dependent on variables order.

Apr 18 2020, 2:40 AM
jankratochvil committed rG239093f30c34: [lldb] [testsuite] Fix a regression of TestCppScope.py (authored by jankratochvil).
[lldb] [testsuite] Fix a regression of TestCppScope.py
Apr 18 2020, 2:08 AM

Apr 17 2020

jankratochvil committed rGeef9cb162889: [lldb] [testsuite] Fix TestFixIts.py on Linux (authored by jankratochvil).
[lldb] [testsuite] Fix TestFixIts.py on Linux
Apr 17 2020, 11:58 PM
jankratochvil added a comment to D75750: [lldb] integrate debuginfod.

The current plan discussed with @kwk is to create the new SymbolServer abstract superclass and some its inherited implementation and move there the appropriate parts of existing lldb/source/Symbol/LocateSymbolFile.cpp. Current SymbolVendor implementations would then iterate new SymbolServers by the existing LocateExecutableSymbolFile function. That may be enough for a patch of its own.

Apr 17 2020, 6:27 AM · Restricted Project

Apr 15 2020

jankratochvil accepted D78242: [lldb/Docs] Add some more info about the test suite layout.
Apr 15 2020, 4:02 PM · Restricted Project
jankratochvil added inline comments to D78242: [lldb/Docs] Add some more info about the test suite layout.
Apr 15 2020, 4:01 PM · Restricted Project
jankratochvil committed rG5e04b5f2fa84: [nfc] [lldb] Introduce DWARF callbacks (fixed-up) (authored by jankratochvil).
[nfc] [lldb] Introduce DWARF callbacks (fixed-up)
Apr 15 2020, 2:56 PM
jankratochvil closed D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 2:56 PM · Restricted Project
jankratochvil added inline comments to D78242: [lldb/Docs] Add some more info about the test suite layout.
Apr 15 2020, 2:55 PM · Restricted Project
jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 1:46 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 1:46 PM · Restricted Project
jankratochvil planned changes to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 7:04 AM · Restricted Project
jankratochvil reopened D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

I had to revert it: rG9289f34390da
It has caused a regression: lang/cpp/accelerator-table/TestCPPAccelerator.py

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/15323/consoleFull
Apr 15 2020, 7:04 AM · Restricted Project
jankratochvil committed rG9289f34390da: Revert "[nfc] [lldb] Introduce DWARF callbacks" (authored by jankratochvil).
Revert "[nfc] [lldb] Introduce DWARF callbacks"
Apr 15 2020, 6:34 AM
jankratochvil added a reverting change for rGbd47c470d13b: [nfc] [lldb] Introduce DWARF callbacks: rG9289f34390da: Revert "[nfc] [lldb] Introduce DWARF callbacks".
Apr 15 2020, 6:33 AM
jankratochvil committed rGbd47c470d13b: [nfc] [lldb] Introduce DWARF callbacks (authored by jankratochvil).
[nfc] [lldb] Introduce DWARF callbacks
Apr 15 2020, 2:09 AM
jankratochvil closed D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 15 2020, 2:08 AM · Restricted Project

Apr 14 2020

jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 14 2020, 10:11 AM · Restricted Project
jankratochvil updated the diff for D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 14 2020, 10:10 AM · Restricted Project
jankratochvil added a comment to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

The normal semantics of callbacks like these is to return true when one wants to continue iterating

Apr 14 2020, 10:10 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 14 2020, 10:10 AM · Restricted Project

Apr 12 2020

jankratochvil added inline comments to D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 12 2020, 4:15 AM · Restricted Project
jankratochvil created D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE.
Apr 12 2020, 3:43 AM · Restricted Project
jankratochvil retitled D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks from [nfc] [lldb] 2/2: Introduce DWARF callbacks to 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 12 2020, 3:43 AM · Restricted Project

Apr 9 2020

jankratochvil committed rG8fbac4e1a2f2: [nfc] [lldb] Unindent code (authored by jankratochvil).
[nfc] [lldb] Unindent code
Apr 9 2020, 1:15 PM
jankratochvil closed D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 9 2020, 1:15 PM · Restricted Project
jankratochvil added a comment to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.

The bool return value on all of these methods, is that here just to implement the fallback mechanism in DebugNamesDWARFIndex?

Apr 9 2020, 5:55 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 9 2020, 5:55 AM · Restricted Project

Apr 8 2020

jankratochvil added inline comments to D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 8 2020, 1:35 AM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 8 2020, 1:35 AM · Restricted Project

Apr 7 2020

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

Having a iterator/callback based api would allow us to minimize the impact of that, as it would only need to happen for the entries that are really used. And /I think/ we could make it interface returns DWARFDies directly, and each index converts to that using the most direct approach available.

Apr 7 2020, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks.
Apr 7 2020, 2:43 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Apr 7 2020, 2:43 PM · Restricted Project