Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (143 w, 1 d)

Recent Activity

Today

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

Having a iterator/callback based api would allow us to minimize the impact of that, as it would only need to happen for the entries that are really used. And /I think/ we could make it interface returns DWARFDies directly, and each index converts to that using the most direct approach available.

Tue, Apr 7, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Tue, Apr 7, 2:43 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Tue, Apr 7, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.
Tue, Apr 7, 2:43 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.

Implemented all the review comments.

Tue, Apr 7, 2:10 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Tue, Apr 7, 2:10 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Tue, Apr 7, 12:31 PM · Restricted Project
jankratochvil added inline comments to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Tue, Apr 7, 12:31 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Tue, Apr 7, 11:56 AM · Restricted Project
jankratochvil added a comment to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.

I can't say I have tried this, but ummm.. why is there a need for a separate iterator class for this equal_range stuff? Couldn't this be implemented via an iterator_pair of the iterators of the underlying container (found via lower/upper_bound) ?

Tue, Apr 7, 9:12 AM · Restricted Project
jankratochvil planned changes to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Tue, Apr 7, 9:12 AM · Restricted Project

Yesterday

jankratochvil added inline comments to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Mon, Apr 6, 1:37 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Mon, Apr 6, 1:37 PM · Restricted Project
jankratochvil planned changes to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Mon, Apr 6, 11:25 AM · Restricted Project
jankratochvil added inline comments to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Mon, Apr 6, 8:06 AM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Mon, Apr 6, 8:06 AM · Restricted Project

Sat, Apr 4

jankratochvil accepted D77376: [lldb][nfc] remove overriden funcs with default impl.

LGTM, thanks for the cleanup.

Sat, Apr 4, 9:00 AM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Sat, Apr 4, 1:25 AM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.
Sat, Apr 4, 1:25 AM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Sat, Apr 4, 1:25 AM · Restricted Project

Fri, Apr 3

jankratochvil committed rGfcab66d5fe53: [lldb] Findtypes -gmodules fix for too many matches (authored by jankratochvil).
[lldb] Findtypes -gmodules fix for too many matches
Fri, Apr 3, 3:44 PM
jankratochvil closed D77336: Findtypes -gmodules fix.
Fri, Apr 3, 3:43 PM · Restricted Project
jankratochvil added inline comments to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Fri, Apr 3, 3:43 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Fri, Apr 3, 3:43 PM · Restricted Project
jankratochvil updated the summary of D77326: 1/2: [nfc] [lldb] Unindent code.
Fri, Apr 3, 1:33 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Fri, Apr 3, 1:33 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.

I have checked in the really obvious parts as rG80237523193d.
The remainder is left here - although I do not see there more problematic parts now.

Fri, Apr 3, 1:33 PM · Restricted Project
jankratochvil committed rG80237523193d: [nfc] [lldb] Unindent code - obvious part (authored by jankratochvil).
[nfc] [lldb] Unindent code - obvious part
Fri, Apr 3, 1:01 PM
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Fri, Apr 3, 11:55 AM · Restricted Project
jankratochvil added inline comments to D77376: [lldb][nfc] remove overriden funcs with default impl.
Fri, Apr 3, 6:24 AM · Restricted Project
jankratochvil accepted D77377: [lldb][nfc] early exit/continue.
Fri, Apr 3, 5:52 AM · Restricted Project
jankratochvil added a comment to D77336: Findtypes -gmodules fix.
In D77336#1959094, @kwk wrote:

Could you explain, why this was done please?

Fri, Apr 3, 2:07 AM · Restricted Project

Thu, Apr 2

jankratochvil retitled D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks from [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks to [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Thu, Apr 2, 2:38 PM · Restricted Project
jankratochvil added inline comments to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Thu, Apr 2, 2:38 PM · Restricted Project
jankratochvil created D77336: Findtypes -gmodules fix.
Thu, Apr 2, 2:38 PM · Restricted Project
jankratochvil updated the diff for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Thu, Apr 2, 2:06 PM · Restricted Project
jankratochvil updated the diff for D77326: 1/2: [nfc] [lldb] Unindent code.
Thu, Apr 2, 2:06 PM · Restricted Project
jankratochvil added inline comments to D77326: 1/2: [nfc] [lldb] Unindent code.
Thu, Apr 2, 2:06 PM · Restricted Project
jankratochvil added inline comments to D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Thu, Apr 2, 12:28 PM · Restricted Project
jankratochvil added a parent revision for D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks: D77326: 1/2: [nfc] [lldb] Unindent code.
Thu, Apr 2, 11:56 AM · Restricted Project
jankratochvil retitled D77326: 1/2: [nfc] [lldb] Unindent code from [nfc] [lldb] Unindent code to 1/2: [nfc] [lldb] Unindent code.
Thu, Apr 2, 11:56 AM · Restricted Project
jankratochvil created D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks.
Thu, Apr 2, 11:56 AM · Restricted Project
jankratochvil created D77326: 1/2: [nfc] [lldb] Unindent code.
Thu, Apr 2, 11:55 AM · Restricted Project

Wed, Apr 1

jankratochvil added a comment to D75750: [lldb] integrate debuginfod.

Another idea for the SymbolServers: be able to specify a source repository (git, svn etc) and hash or revision ID. The symbol server can grab the source from the repo and cache is locally for display.

Wed, Apr 1, 12:30 AM · Restricted Project

Mon, Mar 30

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

The main thing I don't like about the current state is the introduction of user_id_t into the index classes. It forces a bunch of conversions for a flow that really should be simple.

I guess that was to avoid main-cu-ificating the DIERef class?

Mon, Mar 30, 4:50 AM · Restricted Project

Sat, Mar 28

jankratochvil planned changes to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.
Sat, Mar 28, 2:00 PM · Restricted Project
jankratochvil updated the diff for D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

Here is some preview of the style I chose. It is sure regression free.
It is not intended for serious review but any ideas are sure welcome.
I plan to rebase my DWZ patchset on top of it to verify how complete it is.

Sat, Mar 28, 1:59 PM · Restricted Project

Wed, Mar 25

jankratochvil accepted D76569: Convert CommandObjectCommands functions to return StringRefs.

The ASan GCC report was valid ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) but that was really just the first/previous version of the patch.
I will try to check why clang ASan does not report it (and also GCC ASan on a minimal reproducer does not report it for me).

Wed, Mar 25, 3:11 PM · Restricted Project

Tue, Mar 24

jankratochvil added inline comments to D75750: [lldb] integrate debuginfod.
Tue, Mar 24, 3:07 PM · Restricted Project
jankratochvil requested changes to D75750: [lldb] integrate debuginfod.
Tue, Mar 24, 2:34 PM · Restricted Project
jankratochvil added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

I wouldn't be too worried about asan as a StringRef provides the same lifetime guarantees (== none) as a const char *.

Tue, Mar 24, 2:39 AM · Restricted Project

Mon, Mar 23

jankratochvil added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

How do I do that? This is my first PR to llvm, so I am not aware of the tools. Please bear with me.

Mon, Mar 23, 9:14 AM · Restricted Project
jankratochvil added inline comments to D75750: [lldb] integrate debuginfod.
Mon, Mar 23, 8:41 AM · Restricted Project
jankratochvil added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

I do not have the testsuite running with ASAN (it is also failing for me) but I expected to at least run by hand ASAN-built LLDB for the code modified by this patch.

Mon, Mar 23, 4:53 AM · Restricted Project

Sun, Mar 22

jankratochvil added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

Have you run the build with address sanitizer?

Sun, Mar 22, 3:34 PM · Restricted Project

Fri, Mar 20

jankratochvil added inline comments to D75750: [lldb] integrate debuginfod.
Fri, Mar 20, 5:23 AM · Restricted Project

Thu, Mar 19

jankratochvil added inline comments to D75750: [lldb] integrate debuginfod.
Thu, Mar 19, 9:10 AM · Restricted Project
jankratochvil added inline comments to D75750: [lldb] integrate debuginfod.
Thu, Mar 19, 8:37 AM · Restricted Project

Wed, Mar 18

jankratochvil added a comment to D75750: [lldb] integrate debuginfod.

On Fedora 31 x86_64 with LLDB using python3 I got:

llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '.../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py', traceback: Traceback (most recent call last):
  File ".../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path 
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File ".../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py", line 20, in <module>
    config.lldb_enable_debuginfod = TRUE
NameError: name 'TRUE' is not defined
make[3]: *** [tools/lldb/test/CMakeFiles/check-lldb-lit.dir/build.make:58: tools/lldb/test/CMakeFiles/check-lldb-lit] Error 2

It helped to change:

-  set(Debuginfod_FOUND TRUE)
+  set(Debuginfod_FOUND 1)
Wed, Mar 18, 3:46 PM · Restricted Project
jankratochvil committed rG3481062bc688: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles (authored by jankratochvil).
[lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles
Wed, Mar 18, 8:09 AM
jankratochvil closed D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles.
Wed, Mar 18, 8:09 AM · Restricted Project
jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

But I'm not sure that removing GetBaseSymbolFile is the right way to start that, as without it you cannot implement the redirection.

Wed, Mar 18, 8:08 AM · Restricted Project
jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

Yep. It may be interesting to try this out on regular dwo first. Right now, dwo dodges this problem by storing a CompileUnit pointer on both skeleton and split units. If we can make this work without the split unit back pointer, then we can come move closer to how things work in llvm, and also pave the way for the dwz stuff.

Wed, Mar 18, 5:24 AM · Restricted Project

Tue, Mar 17

jankratochvil updated the diff for D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles.

With the former patch these both skeleton files:

tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp4dwo
tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp5dwo

were referencing to this one non-skeleton file:

tools/lldb/test/SymbolFile/DWARF/debug-types-expressions.dwo

Surprisingly it does not affect the other test debug-types-basic.test probably because it compiles to .o and then links it. While debug-types-expressions.test compiles directly to an executable.
So fixed that while keeping the direct executable compilation.

Tue, Mar 17, 2:35 PM · Restricted Project
jankratochvil created D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles.
Tue, Mar 17, 1:29 PM · Restricted Project
jankratochvil updated the summary of D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles.
Tue, Mar 17, 1:29 PM · Restricted Project

Feb 18 2020

jankratochvil committed rGaa3e99dc859f: [lldb] [nfc] Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie() (authored by jankratochvil).
[lldb] [nfc] Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()
Feb 18 2020, 9:12 AM
jankratochvil closed D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie().
Feb 18 2020, 9:12 AM · Restricted Project

Feb 17 2020

jankratochvil updated the diff for D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie().

Sorry for that DenseMap::insert, I see it is the same as std::map, I should study DenseMap more.

Feb 17 2020, 7:50 AM · Restricted Project
jankratochvil committed rG217808887918: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map (authored by jankratochvil).
Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map
Feb 17 2020, 7:38 AM
jankratochvil closed D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map.
Feb 17 2020, 7:37 AM · Restricted Project
jankratochvil added a comment to D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map.

the MainCU is stored in the DIERef, which you now say you want to change.

Feb 17 2020, 3:50 AM · Restricted Project
jankratochvil added a comment to D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map.

In fact, this field used to hold a DIERef until I changed that in D63322.

Feb 17 2020, 2:29 AM · Restricted Project
jankratochvil committed rG516ba158b689: [lldb] [nfc] Simplify user_id_t -> size_t (authored by jankratochvil).
[lldb] [nfc] Simplify user_id_t -> size_t
Feb 17 2020, 1:26 AM
jankratochvil closed D74670: Simplify user_id_t -> size_t.
Feb 17 2020, 1:25 AM · Restricted Project

Feb 16 2020

jankratochvil created D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie().
Feb 16 2020, 6:51 AM · Restricted Project
jankratochvil retitled D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map from Unify DIERef vs. user_id_t to Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map.
Feb 16 2020, 6:48 AM · Restricted Project

Feb 15 2020

jankratochvil created D74670: Simplify user_id_t -> size_t.
Feb 15 2020, 10:01 AM · Restricted Project

Feb 14 2020

jankratochvil created D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map.
Feb 14 2020, 12:48 PM · Restricted Project

Feb 13 2020

jankratochvil added inline comments to D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests..
Feb 13 2020, 10:14 AM · Restricted Project

Feb 11 2020

jankratochvil committed rG98c940bf5158: [NFC] [lldb] Remove unused declaration (authored by jankratochvil).
[NFC] [lldb] Remove unused declaration
Feb 11 2020, 6:01 AM
jankratochvil accepted D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer.

This patch reverts commit 6b2979c12300b90a1e69791d43ee9cff14f4265e

Feb 11 2020, 2:22 AM · Restricted Project

Feb 10 2020

jankratochvil updated subscribers of D74252: Fix+re-enable Assert StackFrame Recognizer on Linux.

@davide Sorry for the revert rG6b2979c12300b90a1e69791d43ee9cff14f4265e - I will find some way to test stuff on OSX, I already made too many OSX breakages recently.

Feb 10 2020, 2:15 PM · Restricted Project
jankratochvil committed rG1a39f1b966a8: [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux (authored by jankratochvil).
[lldb] Fix+re-enable Assert StackFrame Recognizer on Linux
Feb 10 2020, 1:35 AM
jankratochvil closed D74252: Fix+re-enable Assert StackFrame Recognizer on Linux.
Feb 10 2020, 1:35 AM · Restricted Project
jankratochvil added a comment to D74252: Fix+re-enable Assert StackFrame Recognizer on Linux.
In D74252#1866476, @mib wrote:

Has the latest version of this patch landed yet or does it need some extra work ?

Feb 10 2020, 1:35 AM · Restricted Project
jankratochvil committed rGd2e0fee77bc8: [lldb] [doc] Change sample commands prefix from > to $ (authored by jankratochvil).
[lldb] [doc] Change sample commands prefix from > to $
Feb 10 2020, 12:51 AM
jankratochvil closed D74296: [lldb] [doc] Sample commands prefix from > to $.
Feb 10 2020, 12:51 AM · Restricted Project

Feb 9 2020

jankratochvil added a comment to D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ.

From a high-level, this approach looks like it could be viable. However, you have taken this a lot further than I would have expected. What I was expecting to see would be that a bunch of the DWARF internal functions would get an extra argument (be it a CompileUnit, DWARFUnit, or whatever), but I did not expect that this would also appear on the "generic" interfaces. My idea was that the external interface would keep getting just a single user_id_t, but then during the process of decoding that integer into a DWARFDie, we would also produce the additional CompileUnit object.

Feb 9 2020, 2:54 PM · Restricted Project
jankratochvil committed rG9d223a0106d0: [lldb] [doc] Status: Linux: Update the paragraph (authored by jankratochvil).
[lldb] [doc] Status: Linux: Update the paragraph
Feb 9 2020, 9:14 AM
jankratochvil committed rG74857b4260ec: [lldb] [doc] Status: Debugserver (remote debugging) is OK now (authored by jankratochvil).
[lldb] [doc] Status: Debugserver (remote debugging) is OK now
Feb 9 2020, 6:23 AM
jankratochvil created D74296: [lldb] [doc] Sample commands prefix from > to $.
Feb 9 2020, 6:16 AM · Restricted Project
jankratochvil committed rG8b37e1e5ac09: [lldb] [doc] Testing: Fix typos (authored by jankratochvil).
[lldb] [doc] Testing: Fix typos
Feb 9 2020, 6:12 AM
jankratochvil committed rG420a51806850: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir (authored by jankratochvil).
[lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir
Feb 9 2020, 5:54 AM
jankratochvil closed D74295: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir.
Feb 9 2020, 5:53 AM · Restricted Project
jankratochvil added a comment to D74295: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir.

That testcase has been created by D62502.

Feb 9 2020, 4:50 AM · Restricted Project
jankratochvil created D74295: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir.
Feb 9 2020, 4:50 AM · Restricted Project

Feb 8 2020

jankratochvil added a comment to D74252: Fix+re-enable Assert StackFrame Recognizer on Linux.
In D74252#1865504, @mib wrote:

but let's leave symbol as is and add a ConstString alternate_symbol

Feb 8 2020, 4:39 AM · Restricted Project
jankratochvil updated the diff for D74252: Fix+re-enable Assert StackFrame Recognizer on Linux.
Feb 8 2020, 3:21 AM · Restricted Project
jankratochvil added a comment to D74252: Fix+re-enable Assert StackFrame Recognizer on Linux.
In D74252#1865500, @mib wrote:

Knowing that this will be called every time a thread stops, it would be better if we could avoid processing a regex every time we try to recognise a frame.

Feb 8 2020, 2:36 AM · Restricted Project