Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (184 w, 1 d)

Recent Activity

Sun, Jan 3

jankratochvil committed rG6988f7a6f4a7: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33. (authored by jankratochvil).
[compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.
Sun, Jan 3, 6:23 PM
jankratochvil closed D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.
Sun, Jan 3, 6:23 PM · Restricted Project, Restricted Project

Fri, Jan 1

jankratochvil added a comment to D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.

I have rather posted a glibc patch:
{patch} Make _thread_db_sizeof_pthread public for Sanitizers
this patch in a better way

Fri, Jan 1, 2:14 AM · Restricted Project, Restricted Project

Thu, Dec 31

jankratochvil added a comment to D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.

In fact after your rG9a5261efd75530d10ce7a346e8127ba1f00db085 it is no longer a problem. Without this patch it only shows:

Failed Tests (3):
  SanitizerCommon-Unit :: ./Sanitizer-i386-Test/SanitizerLinux.ThreadDescriptorSize
  SanitizerCommon-Unit :: ./Sanitizer-x86_64-Test/SanitizerLinux.ThreadDescriptorSize
  SanitizerCommon-asan-x86_64-Linux :: Linux/getpwnam_r_invalid_user.cpp

I have no idea how is it related. Also I am curious when the testcase can detect the pthread size why the sanitizer does not detect it at runtime? Sorry for not reading all the code.

Thu, Dec 31, 12:27 AM · Restricted Project, Restricted Project

Tue, Dec 29

jankratochvil added a comment to D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.

We have TEST(SanitizerLinux, ThreadDescriptorSize)
Do you know if it fails on your boxes?

Tue, Dec 29, 5:18 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.
Tue, Dec 29, 5:12 AM · Restricted Project, Restricted Project

Dec 16 2020

jankratochvil requested review of D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.
Dec 16 2020, 2:43 AM · Restricted Project, Restricted Project

Dec 10 2020

jankratochvil committed rGb9f0713f73a5: [lldb/Docs] Fix lldb-x86_64-fedora URL as it is still a silent bot (authored by jankratochvil).
[lldb/Docs] Fix lldb-x86_64-fedora URL as it is still a silent bot
Dec 10 2020, 4:52 AM

Nov 30 2020

jankratochvil added a comment to D92223: [lldb] Add support for looking up static const members.

FYI it would not work with GNU C++ 4.4 (2008, RHEL-5) as it used DW_TAG_variable instead of DW_TAG_member. But that is probably not a problem, Red Hat's last supported RHEL for new toolchains is since RHEL-6 and for LLVM even just since RHEL-7:

<0><b>: Abbrev Number: 1 (DW_TAG_compile_unit)
    DW_AT_producer    : GNU C++ 4.1.2 20080704 (Red Hat 4.1.2-55)
    DW_AT_language    : 4      (C++)
    ...
<1><70>: Abbrev Number: 2 (DW_TAG_class_type)
    DW_AT_name        : C
    ...
<2><7a>: Abbrev Number: 3 (DW_TAG_variable)
    DW_AT_name        : i
    DW_AT_decl_file   : 1
    DW_AT_decl_line   : 2
    DW_AT_MIPS_linkage_name: _ZN1C1iE
    DW_AT_type        : <90>
    DW_AT_external    : 1
    DW_AT_accessibility: 3     (private)
    DW_AT_declaration : 1
Nov 30 2020, 6:32 AM · Restricted Project
jankratochvil added a comment to D92223: [lldb] Add support for looking up static const members.

I am not sure if this is the right way to implement this feature. Changing ManualDWARFIndex to provide this additional information is easy enough, but it means that the other index classes will never be able to support this functionality

Nov 30 2020, 4:27 AM · Restricted Project

Nov 14 2020

jankratochvil added a comment to D91388: [TableGen] Add frontend/backend phase timing capability.

http://lab.llvm.org:8014/#/builders/14/builds/1886

[144/5147] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/Main.cpp.o
FAILED: lib/TableGen/CMakeFiles/LLVMTableGen.dir/Main.cpp.o 
/usr/lib64/ccache/c++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/TableGen -I/home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/lib/TableGen -Iinclude -I/home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -O2     -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/TableGen/CMakeFiles/LLVMTableGen.dir/Main.cpp.o -MF lib/TableGen/CMakeFiles/LLVMTableGen.dir/Main.cpp.o.d -o lib/TableGen/CMakeFiles/LLVMTableGen.dir/Main.cpp.o -c /home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/lib/TableGen/Main.cpp
In file included from /home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/include/llvm/TableGen/Error.h:18,
                 from /home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/lib/TableGen/TGParser.h:17,
                 from /home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/lib/TableGen/Main.cpp:18:
/home/buildbot/worker/lldb-x86_64-fedora/llvm-project/llvm/include/llvm/TableGen/Record.h:29:10: fatal error: llvm/Support/timer.h: No such file or directory
   29 | #include "llvm/Support/timer.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Probably already fixed by: Fix build after 54f9ee3

Nov 14 2020, 7:25 AM · Restricted Project

Nov 9 2020

jankratochvil added a comment to rG62e3b2ec1d8e: [lldb][test] - Update test cases after yaml2obj change..

There is still: http://lab.llvm.org:8014/#/builders/14/builds/1582

lldb-api :: functionalities/gdb_remote_client/TestGDBRemoteClient.py
lldb-api :: functionalities/gdb_remote_client/TestGDBRemoteLoad.py
lldb-api :: functionalities/gdb_remote_client/TestThreadSelectionBug.py

But maybe it is unrelated? I did not check it more yet.

Nov 9 2020, 3:50 AM
jankratochvil added a comment to D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU.

Thanks; I see you check very every line even in testcases.

Nov 9 2020, 1:54 AM · Restricted Project
jankratochvil committed rG24f07531a34e: [lldb] Fix DW_AT_decl_file from DW_AT_specification from a different CU (authored by jankratochvil).
[lldb] Fix DW_AT_decl_file from DW_AT_specification from a different CU
Nov 9 2020, 1:53 AM
jankratochvil closed D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU.
Nov 9 2020, 1:53 AM · Restricted Project

Nov 7 2020

jankratochvil requested review of D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU.
Nov 7 2020, 1:34 PM · Restricted Project

Nov 2 2020

jankratochvil abandoned D90464: [nfc] [lldb] Refactor out DWARFUnit::ContainsDIERef.

DWZ is no longer using this. OK, dropped. Thanks for the review.

Nov 2 2020, 8:04 AM · Restricted Project
jankratochvil updated the diff for D90464: [nfc] [lldb] Refactor out DWARFUnit::ContainsDIERef.

It is no longer too much pretty, feel free to drop it if you think so.

Nov 2 2020, 7:47 AM · Restricted Project
jankratochvil planned changes to D90464: [nfc] [lldb] Refactor out DWARFUnit::ContainsDIERef.

I wrote it originally as the function was used at more places. But it no longer is so I just found it as some code cleanup. OK, I will try to update it.

Nov 2 2020, 2:09 AM · Restricted Project

Oct 30 2020

jankratochvil committed rGa136699b2a98: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format (authored by jankratochvil).
[nfc] [lldb] Align `user_id_t` format to the current `DIERef` format
Oct 30 2020, 8:51 AM
jankratochvil closed D90413: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format.
Oct 30 2020, 8:51 AM · Restricted Project
jankratochvil requested review of D90464: [nfc] [lldb] Refactor out DWARFUnit::ContainsDIERef.
Oct 30 2020, 8:07 AM · Restricted Project

Oct 29 2020

jankratochvil requested review of D90413: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format.
Oct 29 2020, 11:44 AM · Restricted Project
jankratochvil committed rG41f2bb232cc0: [nfc] [lldb] Remove excessive parentheses in SymbolFileDWARF::GetUID (authored by jankratochvil).
[nfc] [lldb] Remove excessive parentheses in SymbolFileDWARF::GetUID
Oct 29 2020, 10:02 AM
jankratochvil requested changes to D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt.

This patch no longer applies, it needs a rebase.

Oct 29 2020, 2:47 AM · Restricted Project
jankratochvil added inline comments to D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt.
Oct 29 2020, 2:33 AM · Restricted Project

Oct 26 2020

jankratochvil committed rG7611c5bb42a9: [nfc] [lldb] Refactor DWARFUnit::GetDIE (authored by jankratochvil).
[nfc] [lldb] Refactor DWARFUnit::GetDIE
Oct 26 2020, 3:18 PM
jankratochvil added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

It has regressed buildbots:

SymbolFile/NativePDB/load-pdb.cpp
lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006
lldb-x86_64-debian: http://lab.llvm.org:8011/#/builders/68/builds/782
Oct 26 2020, 11:31 AM · Restricted Project

Oct 21 2020

jankratochvil committed rG7bf066a20f4b: [nfc] [lldb] Fix harmless slicing of DWARFDIE (authored by jankratochvil).
[nfc] [lldb] Fix harmless slicing of DWARFDIE
Oct 21 2020, 6:50 AM
jankratochvil closed D89875: [nfc] [lldb] Fix harmless slicing of DWARFDIE.
Oct 21 2020, 6:50 AM · Restricted Project
jankratochvil requested review of D89875: [nfc] [lldb] Fix harmless slicing of DWARFDIE.
Oct 21 2020, 5:54 AM · Restricted Project

Oct 19 2020

jankratochvil committed rG0e5248be8675: [nfc] [lldb] Move LookupAddress to DWARFCompileUnit (authored by jankratochvil).
[nfc] [lldb] Move LookupAddress to DWARFCompileUnit
Oct 19 2020, 3:45 AM
jankratochvil closed D89646: [nfc] [lldb] Move `LookupAddress` to `DWARFCompileUnit`.
Oct 19 2020, 3:44 AM · Restricted Project, Restricted Project

Oct 18 2020

jankratochvil requested review of D89646: [nfc] [lldb] Move `LookupAddress` to `DWARFCompileUnit`.
Oct 18 2020, 9:53 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D83302: [lldb/DWARF] Don't treat class declarations with children as definitions.

Fixed stale+unused DW_AT_object_pointer+DW_AT_specification by rGfa89f641cf9f.

Oct 18 2020, 8:00 AM · Restricted Project
jankratochvil committed rGfa89f641cf9f: [nfc] [lldb] [testsuite] Fix DW_FORM_ref* in DW_AT_declaration-with-children.s . (authored by jankratochvil).
[nfc] [lldb] [testsuite] Fix DW_FORM_ref* in DW_AT_declaration-with-children.s .
Oct 18 2020, 7:57 AM
jankratochvil committed rG224caaf69b81: [nfc] [lldb] Delete an empty trailing line. (authored by jankratochvil).
[nfc] [lldb] Delete an empty trailing line.
Oct 18 2020, 1:18 AM

Oct 13 2020

jankratochvil accepted D89124: [lldb-server][linux] Add ability to allocate memory.
Oct 13 2020, 9:02 AM · Restricted Project

Oct 12 2020

jankratochvil accepted D89124: [lldb-server][linux] Add ability to allocate memory.
Oct 12 2020, 12:54 PM · Restricted Project
jankratochvil added a comment to D89124: [lldb-server][linux] Add ability to allocate memory.

In file included from /home/jkratoch/redhat/llvm-monorepo/lldb/source/Host/common/NativeProcessProtocol.cpp:9:
/home/jkratoch/redhat/llvm-monorepo/lldb/include/lldb/Host/common/NativeProcessProtocol.h:20:10: fatal error: 'lldb/Utility/UnimplementedError.h' file not found
#include "lldb/Utility/UnimplementedError.h"

Oct 12 2020, 7:27 AM · Restricted Project
jankratochvil committed rG54434dc4dce9: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit (authored by jankratochvil).
[nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit
Oct 12 2020, 4:27 AM
jankratochvil closed D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit.
Oct 12 2020, 4:27 AM · Restricted Project

Oct 9 2020

jankratochvil requested review of D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit.
Oct 9 2020, 2:37 PM · Restricted Project
jankratochvil added inline comments to D89124: [lldb-server][linux] Add ability to allocate memory.
Oct 9 2020, 8:37 AM · Restricted Project

Aug 26 2020

jankratochvil committed rGb20a4e293c3b: [Support] Speedup llvm-dwarfdump 3.9x (authored by jankratochvil).
[Support] Speedup llvm-dwarfdump 3.9x
Aug 26 2020, 1:30 AM
jankratochvil closed D86406: Speedup llvm-dwarfdump 3.9x.
Aug 26 2020, 1:30 AM · Restricted Project

Aug 25 2020

jankratochvil updated the diff for D86406: Speedup llvm-dwarfdump 3.9x.
Aug 25 2020, 11:31 AM · Restricted Project
jankratochvil updated the diff for D86406: Speedup llvm-dwarfdump 3.9x.

Can you change raw_fd_ostream::has_colors to memoize the result of FileDescriptorHasColors(FD) instead?

Aug 25 2020, 9:36 AM · Restricted Project
jankratochvil added a comment to D86406: Speedup llvm-dwarfdump 3.9x.

If I understand the patch correctly, the speedup is gained by caching the mode instead of trying to recompute it every time we call colorsEnabled()?

Aug 25 2020, 12:25 AM · Restricted Project

Aug 24 2020

jankratochvil planned changes to D86406: Speedup llvm-dwarfdump 3.9x.

Also, perhaps this should be done by the stream itself - it seems like the stream knows whether or not it supports colours, so should we not just have the stream ignore attempts to use colours if the underlying thing doesn't support them?

Aug 24 2020, 12:26 AM · Restricted Project

Aug 22 2020

jankratochvil requested review of D86406: Speedup llvm-dwarfdump 3.9x.
Aug 22 2020, 1:17 PM · Restricted Project

Aug 19 2020

jankratochvil added a comment to D85539: [lldb] Extend builder to pass the TRIPLE spec to Make.

It broke the Debian buildbot: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/16095
And also Fedora (although there the commit looks as a different one): http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=10000

Aug 19 2020, 3:16 PM · Restricted Project

Aug 18 2020

jankratochvil committed rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies (authored by jankratochvil).
[lldb] [testsuite] Add split-file for check-lldb dependencies
Aug 18 2020, 9:11 AM
jankratochvil closed D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies.
Aug 18 2020, 9:11 AM · Restricted Project
jankratochvil requested review of D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies.
Aug 18 2020, 8:52 AM · Restricted Project

Aug 6 2020

jankratochvil added a comment to D85100: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD.

It broke Linux buildbots:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/15235/steps/test/logs/stdio
http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/10451/steps/test/logs/stdio

Aug 6 2020, 2:58 AM · Restricted Project, Restricted Project

Aug 2 2020

jankratochvil added a comment to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

The DWARF in the source file appears to be broken, the test fails for me on openSUSE 15.2 x86_64, with errors about DIE references outside of its CU. It fails even if I try to manually compile and debug the file, with Clang git or 9, GCC 7.5 or 9, LLDB git or 9, GDB 9.2.

Aug 2 2020, 1:45 PM · Restricted Project
jankratochvil committed rGe6c2c9a7d151: [lldb] [test] Fix DW_TAG_GNU_call_site-DW_AT_low_pc.s relocation (authored by jankratochvil).
[lldb] [test] Fix DW_TAG_GNU_call_site-DW_AT_low_pc.s relocation
Aug 2 2020, 1:42 PM

Jun 29 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

At this point I'm getting very lost in this patch,

Jun 29 2020, 5:54 AM · Restricted Project

Jun 28 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

The filename should not be checked from SymbolContext::function but rather from SymbolContext::line_entry. As that is cheaper. And when one asks for breakpoint at 1a.h:1 then it is enough to check .debug_line (which needs to be checked anyway) and why to look into .debug_info for the function name etc. at all?
I think there is even a bug due to the Function being involved and not just line_entry:

tail -n99 1b.c 1b.h;clang -o 1b 1b.c -Wall -g;~/redhat/llvm-monorepo2-clangassert/bin/lldb -batch ./1a -o 'breakpoint set -f 1b.h -l 1' 
==> 1b.c <==
static void func(void) {}
int main(void) {
#include "1b.h"
  return 0;
}
==> 1b.h <==
  func();
(lldb) target create "./1a"
Current executable set to '/home/jkratoch/t/1a' (x86_64).
(lldb) breakpoint set -f 1b.h -l 1
Breakpoint 1: no locations (pending).
WARNING:  Unable to resolve breakpoint to any actual locations.

For a practical use case the 1b.h should be rather called 1b.def, there are such files found in many GNU projects - although usually the *.def files are included into data structs and not into function code. But still. This reproducer should be even a part of the testcase for your patch.

Jun 28 2020, 1:59 PM · Restricted Project

Jun 26 2020

jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 26 2020, 3:13 AM · Restricted Project
jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 26 2020, 3:13 AM · Restricted Project

Jun 25 2020

jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 25 2020, 12:29 AM · Restricted Project

Jun 24 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

Just some notes of mine to find out which functions get used in which breakpoint case:

-o 'breakpoint set -f main.c -l 1' -o q
-o 'b main.c:1'     
lldb/source/Commands/CommandObjectBreakpoint.cpp:578 = eSetTypeFileAndLine
lldb/source/Target/Target.cpp:330 = GetInlineStrategy()    
BreakpointSP Target::CreateBreakpoint(const FileSpecList *containingModules,
                                      const FileSpec &file, uint32_t line_no,
  lldb/source/Target/Target.cpp:622
Jun 24 2020, 2:07 PM · Restricted Project
jankratochvil accepted D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

It's not related, at least not directly.

Jun 24 2020, 9:10 AM · Restricted Project

Jun 23 2020

jankratochvil added a comment to D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

I do not understand why the testcase has two epilogues. The UnwindAssembly_x86::AugmentUnwindPlanFromCallSite() code tests only beginning and end of CFI, it does not read anything in between.
The simplified testcase works the same for me: https://people.redhat.com/jkratoch/D82378.patch

Jun 23 2020, 1:58 PM · Restricted Project
jankratochvil added a comment to D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

Now this situation is not actually handled by lldb's "augmenter", so the example somewhat shaky, but it does show that there are gaps in clang/llvm modelling of unwind info.

Jun 23 2020, 10:10 AM · Restricted Project
jankratochvil added a comment to D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented.

I do not like much this approach but it fixes this case. I would prefer checking DW_AT_producer together with -grecord-gcc-switches.
I was trying GCC and clang and all the IMO relevant options and I can get either no .eh_frame/.debug_frame or an asynchronous one.:

(set -ex;rm -rf udir;mkdir udir;cd udir;rm -f *;for e in -f{,no-}exceptions;do for u in -f{,no-}asynchronous-unwind-tables;do for a in -f{,no-}unwind-tables;do for c in clang gcc;do echo 'int main(void){return 0;}'|$c $e $a $u -o $c$e$u$a -x c -;done;done;done;done;for i in $(sha256sum *|sort|awk '{x[$1]=$2}END{for (y in x) print x[y]}');do nm $i|grep -w main;readelf -wf $i;done) 2>&1|less

So I think current compilers no longer produce non-asynchronous unwind tables (that should be verified in the gcc+clang code which I did not) and a simple compiler version check in DW_AT_producer would be enough (even without checking compilation options).

Jun 23 2020, 7:58 AM · Restricted Project

Jun 15 2020

jankratochvil added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 15 2020, 8:07 AM · Restricted Project

Jun 11 2020

jankratochvil added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

I would separate/remove all [nfc] changes from this patch as they complicate it a bit. Such cleaned up patch I have prepared for myself: https://people.redhat.com/jkratoch/D74136-cleanup.patch

Jun 11 2020, 12:40 PM · Restricted Project

Jun 9 2020

jankratochvil committed rG4515d35f5c9e: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC (authored by jankratochvil).
[lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC
Jun 9 2020, 4:54 AM
jankratochvil committed rGfd31e60b8ded: [nfc] [lldb] Reduce GetAttributes's depth parameter usage (authored by jankratochvil).
[nfc] [lldb] Reduce GetAttributes's depth parameter usage
Jun 9 2020, 4:54 AM
jankratochvil closed D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 9 2020, 4:54 AM · Restricted Project
jankratochvil closed D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage.
Jun 9 2020, 4:54 AM · Restricted Project
jankratochvil added inline comments to D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage.
Jun 9 2020, 4:54 AM · Restricted Project
jankratochvil added inline comments to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 9 2020, 4:54 AM · Restricted Project

Jun 8 2020

jankratochvil added inline comments to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 8 2020, 1:18 PM · Restricted Project
jankratochvil updated the diff for D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 8 2020, 1:18 PM · Restricted Project
jankratochvil created D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage.
Jun 8 2020, 1:18 PM · Restricted Project

Jun 7 2020

jankratochvil updated the diff for D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
# This tests that lldb is compatible with DWARF-4 entry values GNU extension
# with DW_TAG_GNU_call_site attributes order as produced by GCC:
# 0x000000b1:     DW_TAG_GNU_call_site
#                   DW_AT_low_pc  (0x000000000040111e)
#                   DW_AT_abstract_origin (0x000000cc "a")
# clang produces the attributes in opposite order:
# 0x00000064:     DW_TAG_GNU_call_site
#                   DW_AT_abstract_origin (0x0000002a "a")
#                   DW_AT_low_pc  (0x0000000000401146)
Jun 7 2020, 5:17 AM · Restricted Project

Jun 6 2020

jankratochvil committed rG8fc1e307f9c4: [lldb] [nfc] Fix comment in testcase DW_TAG_variable-DW_AT_const_value.s (authored by jankratochvil).
[lldb] [nfc] Fix comment in testcase DW_TAG_variable-DW_AT_const_value.s
Jun 6 2020, 2:57 PM
jankratochvil updated the diff for D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

The new -1 value for GetAttributes is a bit ugly. But otherwise either

  • CollectCallEdges would need to reimplement GetAttributes.

or

  • trying to guess which attribute belongs to which DIE from DIEOffsetAtIndex but that is also not nice because it is offset of the DIE's attribute, not offset of the DIE itself.
Jun 6 2020, 2:25 PM · Restricted Project
jankratochvil planned changes to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

It regressed other testcases, I have to check it more.

Jun 6 2020, 1:53 PM · Restricted Project
jankratochvil created D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.
Jun 6 2020, 12:49 PM · Restricted Project

Jun 5 2020

jankratochvil added a comment to D81119: [lldb] Fix SLEB128 decoding.
lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63
lldb-shell :: SymbolFile/DWARF/DW_TAG_variable-DW_AT_const_value.s
Jun 5 2020, 4:22 AM · Restricted Project
jankratochvil committed rG846909e2ab0b: [lldb] Fix UBSan regression in GetSLEB128 (authored by jankratochvil).
[lldb] Fix UBSan regression in GetSLEB128
Jun 5 2020, 3:17 AM

Jun 4 2020

jankratochvil committed rG7fc6d36d4848: [nfc] [lldb] clang-format #include files order (authored by jankratochvil).
[nfc] [lldb] clang-format #include files order
Jun 4 2020, 11:58 PM
jankratochvil committed rG476f520a0bd2: [lldb] Fix SLEB128 decoding (authored by jankratochvil).
[lldb] Fix SLEB128 decoding
Jun 4 2020, 11:03 AM
jankratochvil closed D81119: [lldb] Fix SLEB128 decoding.
Jun 4 2020, 11:01 AM · Restricted Project
jankratochvil added inline comments to D81119: [lldb] Fix SLEB128 decoding.
Jun 4 2020, 11:00 AM · Restricted Project
jankratochvil added a comment to D81119: [lldb] Fix SLEB128 decoding.

PS: You can still just drop the test if you think that's too much hassle. :)

Jun 4 2020, 11:00 AM · Restricted Project
jankratochvil updated the diff for D81119: [lldb] Fix SLEB128 decoding.

Added unit test, simplified the .s test.

Jun 4 2020, 8:44 AM · Restricted Project
jankratochvil planned changes to D81119: [lldb] Fix SLEB128 decoding.
Jun 4 2020, 7:04 AM · Restricted Project

Jun 3 2020

jankratochvil created D81119: [lldb] Fix SLEB128 decoding.
Jun 3 2020, 2:20 PM · Restricted Project
jankratochvil retitled D81119: [lldb] Fix SLEB128 decoding from Fix SLEB128 decoding to [lldb] Fix SLEB128 decoding.
Jun 3 2020, 2:20 PM · Restricted Project

May 29 2020

jankratochvil added inline comments to D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
May 29 2020, 9:45 AM · Restricted Project

May 9 2020

jankratochvil committed rG68a9356bdea6: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol… (authored by jankratochvil).
[lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol…
May 9 2020, 12:29 AM
jankratochvil closed D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files.
May 9 2020, 12:29 AM · Restricted Project

May 8 2020

jankratochvil created D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files.
May 8 2020, 1:57 PM · Restricted Project

May 4 2020

jankratochvil added inline comments to D78421: Fix out of sync source code/executable when debugging.
May 4 2020, 11:48 AM · Restricted Project