Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (131 w, 4 d)

Recent Activity

Thu, Jan 16

jankratochvil planned changes to D71707: clang-tidy: new bugprone-pointer-cast-widening.
Thu, Jan 16, 9:34 AM · Restricted Project, Restricted Project

Wed, Jan 15

jankratochvil added a comment to D71707: clang-tidy: new bugprone-pointer-cast-widening.

I agree that restricting casts to intptr_t is too restrictive.

Wed, Jan 15, 7:54 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D71707: clang-tidy: new bugprone-pointer-cast-widening.
Wed, Jan 15, 7:47 AM · Restricted Project, Restricted Project

Mon, Jan 13

jankratochvil added inline comments to D72595: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jan 13, 12:18 PM · Restricted Project
jankratochvil added a parent revision for D72595: Fix lookup of symbols at the same address with no size vs. size: D63540: Fix lookup of symbols with the same address range but different binding.
Mon, Jan 13, 3:19 AM · Restricted Project
jankratochvil added a child revision for D63540: Fix lookup of symbols with the same address range but different binding: D72595: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jan 13, 3:19 AM · Restricted Project, Restricted Project
jankratochvil planned changes to D72595: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jan 13, 3:19 AM · Restricted Project
jankratochvil created D72595: Fix lookup of symbols at the same address with no size vs. size.
Mon, Jan 13, 3:19 AM · Restricted Project
jankratochvil committed rGbf7225888a99: [lldb] Fix lookup of symbols with the same address range but different binding (authored by jankratochvil).
[lldb] Fix lookup of symbols with the same address range but different binding
Mon, Jan 13, 3:10 AM
jankratochvil closed D63540: Fix lookup of symbols with the same address range but different binding.
Mon, Jan 13, 3:09 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D63540: Fix lookup of symbols with the same address range but different binding.
Mon, Jan 13, 3:09 AM · Restricted Project, Restricted Project

Fri, Jan 10

jankratochvil committed rG2f2f41e12c52: RangeDataVector: Support custom sorting for D63540 (authored by jankratochvil).
RangeDataVector: Support custom sorting for D63540
Fri, Jan 10, 6:17 AM
jankratochvil closed D72460: RangeDataVector: Support custom sorting for D63540.
Fri, Jan 10, 6:17 AM · Restricted Project

Thu, Jan 9

jankratochvil updated the diff for D63540: Fix lookup of symbols with the same address range but different binding.

This patch is now on top of D72460.

Thu, Jan 9, 8:59 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.
  • make the RangeMap constructor take a const Compare & instead of a template pack. The std containers do the same, and I don't see a reason to diverge..
Thu, Jan 9, 8:58 AM · Restricted Project, Restricted Project
jankratochvil added a parent revision for D63540: Fix lookup of symbols with the same address range but different binding: D72460: RangeDataVector: Support custom sorting for D63540.
Thu, Jan 9, 8:49 AM · Restricted Project, Restricted Project
jankratochvil added a child revision for D72460: RangeDataVector: Support custom sorting for D63540: D63540: Fix lookup of symbols with the same address range but different binding.
Thu, Jan 9, 8:49 AM · Restricted Project
jankratochvil created D72460: RangeDataVector: Support custom sorting for D63540.
Thu, Jan 9, 8:49 AM · Restricted Project
jankratochvil added inline comments to D72460: RangeDataVector: Support custom sorting for D63540.
Thu, Jan 9, 8:49 AM · Restricted Project

Wed, Jan 8

jankratochvil planned changes to D63540: Fix lookup of symbols with the same address range but different binding.
Wed, Jan 8, 3:02 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D63540: Fix lookup of symbols with the same address range but different binding.

Found some way.

Wed, Jan 8, 1:56 AM · Restricted Project, Restricted Project

Mon, Jan 6

jankratochvil planned changes to D63540: Fix lookup of symbols with the same address range but different binding.

Passing different sort objects to different sort invocations could cause changes done by one Sort call to be undone by further Symtab additions (and/or trigger assertions in the IsSorted function). It seems to me that the sort order should be a property of the RangeMap object, set when the object is created, similar to how std::map and friends do this thing...

Mon, Jan 6, 8:37 AM · Restricted Project, Restricted Project

Sun, Jan 5

jankratochvil planned changes to D71707: clang-tidy: new bugprone-pointer-cast-widening.
Sun, Jan 5, 2:37 AM · Restricted Project, Restricted Project

Sun, Dec 29

jankratochvil updated the diff for D63540: Fix lookup of symbols with the same address range but different binding.
Sun, Dec 29, 12:06 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

Defining some sort of a preference based on symbol type seems like a good idea, but I don't think this is a good way to implement it. If I read this patch correctly, then this for example means that the "less global" symbols will not be reported through the Symtab::ForEachSymbolContainingFileAddress API, which seems like a bad thing.

Sun, Dec 29, 12:04 PM · Restricted Project, Restricted Project

Thu, Dec 26

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

The difference (with the previous size-non-setting patch) is:

-lldb             <  14> send packet: $Z0,102f0,2#
+lldb             <  14> send packet: $Z0,102f0,4#

That is because GetAddressClass fails to recognized 0x102f0 as a code address:

PASS:
(lldb) p (void)sync()
GetAddressClass:0x102f1
GetAddressClass:0x102f1=(null) ValueIsAddress=1 section_type=1
GetAddressClass:0x96040
GetAddressClass:0x96040=__mmap ValueIsAddress=1 section_type=1
GetAddressClass:0x102f1
GetAddressClass:0x102f1=(null) ValueIsAddress=1 section_type=1
GetAddressClass:0x102f0
GetAddressClass:0x102f0=(null) ValueIsAddress=1 section_type=1
...
Thu, Dec 26, 1:47 PM · Restricted Project, Restricted Project

Sat, Dec 21

jankratochvil abandoned D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows.

This has been already fixed by @labath: https://github.com/llvm/llvm-project/commit/ce3ce9f46404688cc2d95f794799c8f834630905

Sat, Dec 21, 4:41 AM · Restricted Project
jankratochvil added inline comments to D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows.
Sat, Dec 21, 4:23 AM · Restricted Project
jankratochvil created D71797: Fix thread-step-out-ret-addr-check.test PT_GNU_STACK compilation on Windows.
Sat, Dec 21, 4:23 AM · Restricted Project
jankratochvil committed rG4706a60e8a07: [lldb] [testsuite] Fix Linux fail: Unwind/thread-step-out-ret-addr-check.test (authored by jankratochvil).
[lldb] [testsuite] Fix Linux fail: Unwind/thread-step-out-ret-addr-check.test
Sat, Dec 21, 2:33 AM
jankratochvil closed D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`.
Sat, Dec 21, 2:33 AM · Restricted Project
jankratochvil committed rGdf6879ec0227: [lldb] Fix ARM32 inferior calls (authored by jankratochvil).
[lldb] Fix ARM32 inferior calls
Sat, Dec 21, 2:15 AM
jankratochvil closed D71498: Fix ARM32 inferior calls.
Sat, Dec 21, 2:15 AM · Restricted Project
jankratochvil added inline comments to D71498: Fix ARM32 inferior calls.
Sat, Dec 21, 2:15 AM · Restricted Project
jankratochvil added a comment to D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`.

Thanks for the review but is it tested on Darwin? I do not have any.

Sat, Dec 21, 2:15 AM · Restricted Project
jankratochvil requested changes to D71789: [lldb] Refactor thread-step-out-ret-addr-check test to use .data instead of stack variable.

My testing matches the @labath's one. I have updated D71784.

Sat, Dec 21, 1:47 AM · Restricted Project
jankratochvil updated the diff for D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`.

Addressed the review and D71789 and enabled it for Linux again.

Sat, Dec 21, 1:47 AM · Restricted Project

Fri, Dec 20

jankratochvil created D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`.
Fri, Dec 20, 1:25 PM · Restricted Project
jankratochvil added inline comments to D71498: Fix ARM32 inferior calls.
Fri, Dec 20, 11:40 AM · Restricted Project
jankratochvil added inline comments to D71498: Fix ARM32 inferior calls.
Fri, Dec 20, 11:31 AM · Restricted Project
jankratochvil updated the diff for D71498: Fix ARM32 inferior calls.
Fri, Dec 20, 11:31 AM · Restricted Project
jankratochvil abandoned D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498.

I will merge this with D71498.

Fri, Dec 20, 10:09 AM · Restricted Project

Thu, Dec 19

jankratochvil added inline comments to D71707: clang-tidy: new bugprone-pointer-cast-widening.
Thu, Dec 19, 2:33 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D71707: clang-tidy: new bugprone-pointer-cast-widening.
Thu, Dec 19, 2:30 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D71707: clang-tidy: new bugprone-pointer-cast-widening.

Wrote the documentation and Release Notes entry, thanks for the review.

Thu, Dec 19, 12:52 PM · Restricted Project, Restricted Project
jankratochvil planned changes to D71707: clang-tidy: new bugprone-pointer-cast-widening.
Thu, Dec 19, 9:23 AM · Restricted Project, Restricted Project
jankratochvil updated subscribers of D71707: clang-tidy: new bugprone-pointer-cast-widening.
  • disallowing casts to intptr_t seems too restrictive -- I doubt many people are doing that, but I guess this type exists for a reason, and since the type (and it's signedness) is spelled out in the source, it shouldn't be too surprising that sign-extension can happen later
Thu, Dec 19, 9:23 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D71498: Fix ARM32 inferior calls.

In other places you're replacing a reinterpret_cast<addr_t> with two c casts.

Thu, Dec 19, 7:42 AM · Restricted Project
jankratochvil added a comment to D71707: clang-tidy: new bugprone-pointer-cast-widening.

Example output:

PATH="$PWD/bin:$PATH" ~/redhat/llvm-monorepo/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,bugprone-pointer-cast-widening' /home/jkratoch/redhat/llvm-monorepo/lldb/source/
Thu, Dec 19, 7:32 AM · Restricted Project, Restricted Project
jankratochvil created D71707: clang-tidy: new bugprone-pointer-cast-widening.
Thu, Dec 19, 7:32 AM · Restricted Project, Restricted Project

Dec 19 2019

jankratochvil planned changes to D63540: Fix lookup of symbols with the same address range but different binding.

then this for example means that the "less global" symbols will not be reported through the Symtab::ForEachSymbolContainingFileAddress API, which seems like a bad thing.

Dec 19 2019, 3:53 AM · Restricted Project, Restricted Project
jankratochvil planned changes to D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498.
Dec 19 2019, 2:11 AM · Restricted Project
jankratochvil retitled D63540: Fix lookup of symbols with the same address range but different binding from Fix lookup of symbols at the same address with no size vs. size to Fix lookup of symbols with the same address range but different binding.
Dec 19 2019, 12:46 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D63540: Fix lookup of symbols with the same address range but different binding.

Changing the size of symbols turned out to be too invasive. Let's keep it intact.
Rather choose the best symbols from those which have the same address range.
Currently LLDB chooses randomly any symbol from those so make it more deterministic. That should have no negative effect.

Dec 19 2019, 12:39 AM · Restricted Project, Restricted Project

Dec 18 2019

jankratochvil planned changes to D63540: Fix lookup of symbols with the same address range but different binding.
Dec 18 2019, 9:36 AM · Restricted Project, Restricted Project
jankratochvil planned changes to D71498: Fix ARM32 inferior calls.
Dec 18 2019, 9:36 AM · Restricted Project

Dec 16 2019

jankratochvil added a comment to D71498: Fix ARM32 inferior calls.

For the printf style statement, we can't use just one cast to "uintptr_t" because on 32 bit systems it won't be converted to 64 bit.

Dec 16 2019, 11:40 AM · Restricted Project
jankratochvil added a comment to D71498: Fix ARM32 inferior calls.

Could you check symtabs what symbols are located at:

th1/fr0 with pc value of 0x102f0, symbol name is '_start'

vs.

th1/fr0 with pc value of 0xfe52, no symbol/function name is known.

? Or maybe just attached the main executable as _start=0x102f0 is there I hope.

Dec 16 2019, 4:19 AM · Restricted Project
jankratochvil added a comment to D71498: Fix ARM32 inferior calls.

error: Can't run the expression locally: Interpreter doesn't handle one of the expression's opcodes

Dec 16 2019, 3:06 AM · Restricted Project

Dec 14 2019

jankratochvil added a child revision for D71498: Fix ARM32 inferior calls: D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498.
Dec 14 2019, 8:21 AM · Restricted Project
jankratochvil added a parent revision for D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498: D71498: Fix ARM32 inferior calls.
Dec 14 2019, 8:21 AM · Restricted Project
jankratochvil created D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498.
Dec 14 2019, 8:21 AM · Restricted Project

Dec 13 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

@omjavaid Do you still see any regression of this patch after D71498?

Dec 13 2019, 4:58 PM · Restricted Project, Restricted Project
jankratochvil created D71498: Fix ARM32 inferior calls.
Dec 13 2019, 4:49 PM · Restricted Project
jankratochvil added a reviewer for D71498: Fix ARM32 inferior calls: jasonmolenda.
Dec 13 2019, 4:49 PM · Restricted Project

Dec 10 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

@omjavaid FYI the JIT error happens for me on 2019-09-26-raspbian-buster even without this my patch. I will try to debug that.

Dec 10 2019, 5:25 AM · Restricted Project, Restricted Project

Dec 3 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

FYI I am investigating it. I have found 2019-09-26-raspbian-buster.zip really can run in chroot on Fedora 31 armv7hl so I should be able to reproduce it. It is building LLDB now, that takes about 6 hours.

Dec 3 2019, 11:57 AM · Restricted Project, Restricted Project

Nov 26 2019

jankratochvil updated the diff for D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646.

Remove that dodgy new parameter SymbolFileDWARF &dwarf.

Nov 26 2019, 12:59 PM · Restricted Project
jankratochvil planned changes to D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646.
Nov 26 2019, 12:59 PM · Restricted Project

Nov 25 2019

jankratochvil planned changes to D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`.
Nov 25 2019, 9:29 AM · Restricted Project
jankratochvil planned changes to D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646.
Nov 25 2019, 9:29 AM · Restricted Project
jankratochvil planned changes to D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes().
Nov 25 2019, 9:29 AM · Restricted Project

Nov 24 2019

jankratochvil added a child revision for D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`: D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646.
Nov 24 2019, 1:20 PM · Restricted Project
jankratochvil updated the summary of D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`.
Nov 24 2019, 1:20 PM · Restricted Project
jankratochvil added a parent revision for D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646: D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`.
Nov 24 2019, 1:20 PM · Restricted Project
jankratochvil created D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646.
Nov 24 2019, 1:20 PM · Restricted Project
jankratochvil updated the summary of D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes().
Nov 24 2019, 1:20 PM · Restricted Project
jankratochvil added a parent revision for D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`: D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes().
Nov 24 2019, 12:53 PM · Restricted Project
jankratochvil created D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`.
Nov 24 2019, 12:53 PM · Restricted Project
jankratochvil added a child revision for D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes(): D70646: RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`.
Nov 24 2019, 12:53 PM · Restricted Project
jankratochvil created D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes().
Nov 24 2019, 12:44 PM · Restricted Project

Nov 19 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

@omjavaid I guess it depends on some system library - what OS vendor/release do you have the regression reproducible on?
Still not reproducible for me. Trying bfbbf0aba81a84da8b53d4d159d080e77ad8ee70 with applied D70155 and applied/unapplied this D63540 on Fedora 30 armv7l and it has no difference in testsuite (except for the added/removed testcase of this D63540).
In both cases I get these:

Unexpected Passing Tests (5):
    lldb-api :: functionalities/archives/TestBSDArchives.py
    lldb-api :: functionalities/inferior-assert/TestInferiorAssert.py
    lldb-api :: functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py
    lldb-api :: linux/builtin_trap/TestBuiltinTrap.py
    lldb-api :: linux/thread/create_during_instruction_step/TestCreateDuringInstructionStep.py
Failing Tests (103):
    lldb-api :: commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py
    lldb-api :: commands/expression/call-function/TestCallStdStringFunction.py
    lldb-api :: commands/expression/call-function/TestCallStopAndContinue.py
    lldb-api :: commands/expression/call-function/TestCallUserDefinedFunction.py
    lldb-api :: commands/expression/call-overridden-method/TestCallOverriddenMethod.py
    lldb-api :: commands/expression/call-restarts/TestCallThatRestarts.py
    lldb-api :: commands/expression/char/TestExprsChar.py
    lldb-api :: commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py
    lldb-api :: commands/expression/context-object/TestContextObject.py
    lldb-api :: commands/expression/dont_allow_jit/TestAllowJIT.py
    lldb-api :: commands/expression/entry-bp/TestExprEntryBP.py
    lldb-api :: commands/expression/expr-in-syscall/TestExpressionInSyscall.py
    lldb-api :: commands/expression/formatters/TestFormatters.py
    lldb-api :: commands/expression/inline-namespace/TestInlineNamespace.py
    lldb-api :: commands/expression/no-deadlock/TestExprDoesntBlock.py
    lldb-api :: commands/expression/persistent_types/TestNestedPersistentTypes.py
    lldb-api :: commands/expression/persistent_types/TestPersistentTypes.py
    lldb-api :: commands/expression/pr35310/TestExprsBug35310.py
    lldb-api :: commands/expression/radar_9531204/TestPrintfAfterUp.py
    lldb-api :: commands/expression/radar_9673664/TestExprHelpExamples.py
    lldb-api :: commands/expression/rdar44436068/Test128BitsInteger.py
    lldb-api :: commands/expression/static-initializers/TestStaticInitializers.py
    lldb-api :: commands/expression/test/TestExprs.py
    lldb-api :: commands/expression/timeout/TestCallWithTimeout.py
    lldb-api :: commands/expression/unwind_expression/TestUnwindExpression.py
    lldb-api :: commands/expression/xvalue/TestXValuePrinting.py
    lldb-api :: commands/register/register/register_command/TestRegisters.py
    lldb-api :: commands/watchpoints/hello_watchlocation/TestWatchLocation.py
    lldb-api :: commands/watchpoints/multi_watchpoint_slots/TestWatchpointMultipleSlots.py
    lldb-api :: commands/watchpoints/watchpoint_size/TestWatchpointSizes.py
    lldb-api :: functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py
    lldb-api :: functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py
    lldb-api :: functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py
    lldb-api :: functionalities/load_unload/TestLoadUnload.py
    lldb-api :: functionalities/load_using_paths/TestLoadUsingPaths.py
    lldb-api :: functionalities/memory/find/TestMemoryFind.py
    lldb-api :: functionalities/process_group/TestChangeProcessGroup.py
    lldb-api :: functionalities/return-value/TestReturnValue.py
    lldb-api :: functionalities/show_location/TestShowLocationDwarf5.py
    lldb-api :: functionalities/thread/num_threads/TestNumThreads.py
    lldb-api :: lang/c/bitfields/TestBitfields.py
    lldb-api :: lang/c/function_types/TestFunctionTypes.py
    lldb-api :: lang/c/shared_lib/TestSharedLib.py
    lldb-api :: lang/c/strings/TestCStrings.py
    lldb-api :: lang/c/struct_types/TestStructTypes.py
    lldb-api :: lang/cpp/auto/TestCPPAuto.py
    lldb-api :: lang/cpp/call-function/TestCallCPPFunction.py
    lldb-api :: lang/cpp/chained-calls/TestCppChainedCalls.py
    lldb-api :: lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
    lldb-api :: lang/cpp/extern_c/TestExternCSymbols.py
    lldb-api :: lang/cpp/global_operators/TestCppGlobalOperators.py
    lldb-api :: lang/cpp/lambdas/TestLambdas.py
    lldb-api :: lang/cpp/llvm-style/TestLLVMStyle.py
    lldb-api :: lang/cpp/namespace/TestNamespace.py
    lldb-api :: lang/cpp/namespace/TestNamespaceLookup.py
    lldb-api :: lang/cpp/namespace_conflicts/TestNamespaceConflicts.py
    lldb-api :: lang/cpp/namespace_definitions/TestNamespaceDefinitions.py
    lldb-api :: lang/cpp/operators/TestCppOperators.py
    lldb-api :: lang/cpp/overloaded-functions/TestOverloadedFunctions.py
    lldb-api :: lang/cpp/rvalue-references/TestRvalueReferences.py
    lldb-api :: lang/cpp/scope/TestCppScope.py
    lldb-api :: lang/cpp/static_methods/TestCPPStaticMethods.py
    lldb-api :: lang/cpp/symbols/TestSymbols.py
    lldb-api :: lang/cpp/template-function/TestTemplateFunctions.py
    lldb-api :: lang/cpp/template/TestTemplateArgs.py
    lldb-api :: lang/cpp/this/TestCPPThis.py
    lldb-api :: lang/cpp/trivial_abi/TestTrivialABI.py
    lldb-api :: lang/cpp/unicode-literals/TestUnicodeLiterals.py
    lldb-api :: lang/cpp/virtual/TestVirtual.py
    lldb-api :: python_api/thread/TestThreadAPI.py
    lldb-api :: tools/lldb-server/TestLldbGdbServer.py
    lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-PT_INTERP.yaml
    lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-PT_TLS.yaml
    lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-section.yaml
    lldb-shell :: ObjectFile/ELF/PT_LOAD.yaml
    lldb-shell :: ObjectFile/ELF/PT_TLS-overlap-PT_LOAD.yaml
    lldb-shell :: ObjectFile/ELF/minidebuginfo-set-and-hit-breakpoint.test
    lldb-shell :: Reproducer/Functionalities/TestDataFormatter.test
    lldb-shell :: Reproducer/Functionalities/TestImageList.test
    lldb-shell :: Reproducer/Functionalities/TestStepping.test
    lldb-shell :: Reproducer/TestDump.test
    lldb-shell :: Reproducer/TestGDBRemoteRepro.test
    lldb-shell :: Reproducer/TestRelativePath.test
    lldb-shell :: Reproducer/TestReuseDirectory.test
    lldb-shell :: Reproducer/TestSynchronous.test
    lldb-shell :: Reproducer/TestWorkingDir.test
    lldb-shell :: SymbolFile/DWARF/anon_class_w_and_wo_export_symbols.ll
    lldb-shell :: SymbolFile/DWARF/clang-ast-from-dwarf-unamed-and-anon-structs.cpp
    lldb-shell :: SymbolFile/DWARF/debug-types-expressions.test
    lldb-shell :: SymbolFile/NativePDB/ast-functions.cpp
    lldb-shell :: SymbolFile/NativePDB/ast-methods.cpp
    lldb-shell :: SymbolFile/NativePDB/ast-types.cpp
    lldb-shell :: SymbolFile/NativePDB/bitfields.cpp
    lldb-shell :: SymbolFile/NativePDB/break-by-function.cpp
    lldb-shell :: SymbolFile/NativePDB/break-by-line.cpp
    lldb-shell :: SymbolFile/NativePDB/function-types-builtins.cpp
    lldb-shell :: SymbolFile/NativePDB/function-types-classes.cpp
    lldb-shell :: SymbolFile/NativePDB/global-classes.cpp
    lldb-shell :: SymbolFile/NativePDB/globals-bss.cpp
    lldb-shell :: SymbolFile/NativePDB/globals-fundamental.cpp
    lldb-shell :: SymbolFile/NativePDB/nested-types.cpp
    lldb-shell :: SymbolFile/NativePDB/source-list.cpp
    lldb-shell :: SymbolFile/NativePDB/tag-types.cpp
Nov 19 2019, 2:31 AM · Restricted Project, Restricted Project

Nov 15 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

@omjavaid In the end I built a native armv7l-unknown-linux-gnueabihf lldb using:

cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Release  -DLLVM_ENABLE_PROJECTS="lldb;clang;lld"  -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB

Built it from trunk: 16bdcc809c72c639a2888b6b859dca88453e3c28
But it does not stop even in a trivial breakpoint:

$ echo 'int main(){}'|gcc -x c - -g;./bin/lldb -o 'b main' -o r ./a.out
(lldb) target create "./a.out"
Current executable set to '/home/fedora/jankratochvil/jkratoch/redhat/llvm-monorepo-clangassertdyn/a.out' (arm).
(lldb) b main
Breakpoint 1: where = a.out`main + 12 at <stdin>:1:1, address = 0x000103dc
(lldb) r
Process 12146 exited with status = 0 (0x00000000) 
Nov 15 2019, 8:27 AM · Restricted Project, Restricted Project

Nov 14 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

Getting ld.lld: error: failed to open ../../../../bin/clang-10: Cannot allocate memory when trying to build lldb natively on arm32 (the same error happens both for clang and for lldb). Apparently memory is not a problem but the linker runs out of its 32-bit address space.
I am aware of the cross-compiling lldb possibility but I haven't tried that yet. Do you have some simple instructions how to cross-compile lldb for arm32 on x86_64 host?

Nov 14 2019, 2:04 AM · Restricted Project, Restricted Project

Nov 13 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

It is still the same (no arm32 regression) with 16bdcc809c72c639a2888b6b859dca88453e3c28 and this patch reapplied.

Nov 13 2019, 8:18 AM · Restricted Project, Restricted Project
Herald added a reviewer for D51830: Add a way to make scripted breakpoints: jdoerfert.
Nov 13 2019, 8:08 AM · Restricted Project
jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

@omjavaid I do not have the regression reproducible, could you provide more info?
Having on both hosts trunk 54a9b4c02ff57e9847e0c501578e51db6f73d3be having applied your D69904, having reverted your revert (=reapplied) of this my D63540.
Running on Fedora 30 armv7l:

ssh -L 1234:localhost:1234 -L 1235:localhost:1235 arm03-packager00.cloud.fedoraproject.org
~/redhat/llvm-monorepo-clangassert/bin/lldb-server platform --listen "*:1234" --server --min-gdbserver-port 1235 --max-gdbserver-port 1236

On Fedora 30 x86_64:
./bin/lldb-dotest --arch=arm --platform-name=remote-linux --platform-url=connect://localhost:1234 -f TestSourceInfo -v -t

UNSUPPORTED: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-10-arm) :: test_dsym (lldbsuite.test.lldbtest.TestSourceInfo) (test case does not fall in any category of interest for this run) 
PASS: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-10-arm) :: test_dwarf (lldbsuite.test.lldbtest.TestSourceInfo)
PASS: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-10-arm) :: test_dwo (lldbsuite.test.lldbtest.TestSourceInfo)
UNSUPPORTED: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-10-arm) :: test_gmodules (lldbsuite.test.lldbtest.TestSourceInfo) (test case does not fall in any category of interest for this run) 
----------------------------------------------------------------------
Ran 4 tests in 0.802s
RESULT: PASSED (2 passes, 0 failures, 0 errors, 2 skipped, 0 expected failures, 0 unexpected successes)
Nov 13 2019, 6:17 AM · Restricted Project, Restricted Project

Nov 12 2019

jankratochvil accepted D70127: [lldb-vscode] Fix a race in test_extra_launch_commands.

I agree - as there is currently:

self.verify_commands('launchCommands', output, launchCommands)
# Verify the "stopCommands" here
self.continue_to_next_stop()

BTW I did not have problem with this testcase, I had problem with TestVSCode_attach but I never finished that patch: https://people.redhat.com/jkratoch/TestVSCode_attach.patch

Nov 12 2019, 9:23 AM · Restricted Project

Nov 10 2019

jankratochvil added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

I am going to investigate it this week. Feel free to revert it but some such patch is definitely needed for all recent Fedoras, RHEL-8 and CentOS-8 (due to annobin on all those).

Nov 10 2019, 11:17 AM · Restricted Project, Restricted Project

Nov 7 2019

jankratochvil committed rG44f43461c018: [lldb] Comment typo fix (authored by jankratochvil).
[lldb] Comment typo fix
Nov 7 2019, 8:55 AM

Nov 1 2019

jankratochvil requested changes to D67227: [lldb] Extend and document TestIRInterpreter.py.

On Fedora 31 x86_64 (that is with python3-3.7.4-5.fc31.x86_64) I get:

FAIL: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64) :: test_ir_interpreter_int_ops (TestIRInterpreter.IRInterpreterTestCase)
PASS: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64) :: test_type_conversions (TestIRInterpreter.IRInterpreterTestCase)
======================================================================
ERROR: test_ir_interpreter_int_ops (TestIRInterpreter.IRInterpreterTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 112, in wrapper
    func(*args, **kwargs)
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 112, in wrapper
    func(*args, **kwargs)
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 112, in wrapper
    func(*args, **kwargs)
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py", line 130, in test_ir_interpreter_int_ops
    if not op.can_handle_operands(var1, var2):
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py", line 71, in can_handle_operands
    if rhs.value <= 0 or rhs.value >= 32:
TypeError: '<=' not supported between instances of 'c_uint' and 'int'
Config=x86_64-/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10
----------------------------------------------------------------------
Nov 1 2019, 3:41 AM · Restricted Project

Oct 29 2019

jankratochvil accepted D69555: [zorg] Fix LLDBCmakeBuildFactory.

It does run now, I did not test it with a slave.

Oct 29 2019, 6:34 AM
jankratochvil requested changes to D69555: [zorg] Fix LLDBCmakeBuildFactory.
2019-10-29 11:38:04+0100 [-] error while parsing config file
2019-10-29 11:38:04+0100 [-] Unhandled Error
	Traceback (most recent call last):
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 197, in loadTheConfigFile
	    d = self.loadConfig(f)
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 579, in loadConfig
	    d.addCallback(do_load)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 322, in addCallback
	    callbackKeywords=kw)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 311, in addCallbacks
	    self._runCallbacks()
	--- <exception caught here> ---
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
	    current.result = callback(current.result, *args, **kw)
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 226, in do_load
	    exec f in localDict
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/master.cfg", line 83, in <module>
	    c['builders'] = builders = list(config.builders.get_builders())
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 1456, in get_builders
	    for b in _get_lldb_builders():
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 829, in _get_lldb_builders
	    '-DLLVM_LIT_ARGS="-v"'])},
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/builders/LLDBBuilder.py", line 129, in getLLDBCMakeBuildFactory
	    doStepIf=FileDoesNotExist(
	exceptions.NameError: global name 'FileDoesNotExist' is not defined
	
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/master.cfg", line 83, in <module>
	    c['builders'] = builders = list(config.builders.get_builders())
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 1456, in get_builders
	    for b in _get_lldb_builders():
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 829, in _get_lldb_builders
	    '-DLLVM_LIT_ARGS="-v"'])},
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/builders/LLDBBuilder.py", line 129, in getLLDBCMakeBuildFactory
	    doStepIf=FileDoesNotExist(
	exceptions.NameError: global name 'FileDoesNotExist' is not defined
Oct 29 2019, 3:46 AM

Oct 24 2019

jankratochvil accepted D69341: [zorg] Port LLDB cmake build factory to git.
Oct 24 2019, 9:34 AM
jankratochvil added inline comments to D69341: [zorg] Port LLDB cmake build factory to git.
Oct 24 2019, 3:54 AM

Oct 23 2019

jankratochvil added a comment to D69341: [zorg] Port LLDB cmake build factory to git.

I was using these 3 patches for buildbot-0.8.5 (and one for zorg) to get the master running. But sure there is still some configuration afterwards:
https://people.redhat.com/jkratoch/buildbot-0.8.5-fix.patch
https://people.redhat.com/jkratoch/buildbot-0.8.5-fix2.patch
https://people.redhat.com/jkratoch/buildbot-0.8.5-fix3.patch
https://people.redhat.com/jkratoch/zorg-dummy.patch

Oct 23 2019, 12:42 PM
jankratochvil added a comment to D69341: [zorg] Port LLDB cmake build factory to git.

After the @sivachandra 's fix I get:

2019-10-23 21:28:24+0200 [-] LLVMGitPoller: using workdir '/quad/home/buildbot/zorg-git/buildbot/osuosl/master/gitpoller-workdir'
2019-10-23 21:28:24+0200 [-] LLVMGitPoller: initializing working dir from http://git.lab.llvm.org/llvm/llvm-project.git
2019-10-23 21:28:24+0200 [-] configuration update complete
2019-10-23 21:28:25+0200 [-] while initializing LLVMGitPoller repository
	Traceback (most recent call last):
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/_baseprocess.py", line 64, in maybeCallProcessEnded
	    proto.processEnded(Failure(reason))
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/utils.py", line 163, in processEnded
	    self.deferred.callback((out, err, code))
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 460, in callback
	    self._startRunCallbacks(result)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 568, in _startRunCallbacks
	    self._runCallbacks()
	--- <exception caught here> ---
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
	    current.result = callback(current.result, *args, **kw)
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/changes/llvmgitpoller.py", line 419, in _convert_nonzero_to_failure
	    raise EnvironmentError('command failed with exit code %d: %s' % (code, stderr))
	exceptions.EnvironmentError: command failed with exit code 128: fatal: unable to access 'http://git.lab.llvm.org/llvm/llvm-project.git/': Could not resolve host: git.lab.llvm.org
Oct 23 2019, 12:32 PM
jankratochvil added a comment to D69341: [zorg] Port LLDB cmake build factory to git.

I could pack some patched buildbot-0.8.5 and patched zorg-git running on Fedora 30 (and its Python version) so that you can run it yourself. But I am also fine to just testing it.

Oct 23 2019, 11:38 AM
jankratochvil added a comment to D69341: [zorg] Port LLDB cmake build factory to git.
2019-10-23 20:34:53+0200 [-] error while parsing config file
2019-10-23 20:34:53+0200 [-] Unhandled Error
	Traceback (most recent call last):
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 197, in loadTheConfigFile
	    d = self.loadConfig(f)
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 579, in loadConfig
	    d.addCallback(do_load)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 322, in addCallback
	    callbackKeywords=kw)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 311, in addCallbacks
	    self._runCallbacks()
	--- <exception caught here> ---
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
	    current.result = callback(current.result, *args, **kw)
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 226, in do_load
	    exec f in localDict
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/master.cfg", line 83, in <module>
	    c['builders'] = builders = list(config.builders.get_builders())
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 1444, in get_builders
	    for b in _get_lldb_builders():
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 817, in _get_lldb_builders
	    '-DLLVM_LIT_ARGS="-v"'])},
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/builders/LLDBBuilder.py", line 110, in getLLDBCMakeBuildFactory
	    "cmake", "-G", "Ninja", "../" + self.monorepo_dir,
	exceptions.NameError: global name 'self' is not defined
Oct 23 2019, 11:36 AM
jankratochvil added a comment to D69341: [zorg] Port LLDB cmake build factory to git.

FYI my local buildbot master errors out this way:

2019-10-23 16:10:12+0200 [-] error while parsing config file
2019-10-23 16:10:12+0200 [-] Unhandled Error
	Traceback (most recent call last):
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 197, in loadTheConfigFile
	    d = self.loadConfig(f)
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 579, in loadConfig
	    d.addCallback(do_load)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 322, in addCallback
	    callbackKeywords=kw)
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 311, in addCallbacks
	    self._runCallbacks()
	--- <exception caught here> ---
	  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
	    current.result = callback(current.result, *args, **kw)
	  File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py", line 226, in do_load
	    exec f in localDict
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/master.cfg", line 83, in <module>
	    c['builders'] = builders = list(config.builders.get_builders())
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 1444, in get_builders
	    for b in _get_lldb_builders():
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 817, in _get_lldb_builders
	    '-DLLVM_LIT_ARGS="-v"'])},
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/builders/LLDBBuilder.py", line 77, in getLLDBCMakeBuildFactory
	    f.addGetSourcecodeSteps()
	exceptions.AttributeError: BuildFactory instance has no attribute 'addGetSourcecodeSteps'
	
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/master.cfg", line 83, in <module>
	    c['builders'] = builders = list(config.builders.get_builders())
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 1444, in get_builders
	    for b in _get_lldb_builders():
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/config/builders.py", line 817, in _get_lldb_builders
	    '-DLLVM_LIT_ARGS="-v"'])},
	  File "/quad/home/buildbot/zorg-git/buildbot/osuosl/master/zorg/buildbot/builders/LLDBBuilder.py", line 77, in getLLDBCMakeBuildFactory
	    f.addGetSourcecodeSteps()
	exceptions.AttributeError: BuildFactory instance has no attribute 'addGetSourcecodeSteps'
Oct 23 2019, 7:12 AM