Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (205 w, 3 d)

Recent Activity

Today

jankratochvil updated the diff for D104271: llvm-dwarfdump: Print warnings on invalid DWARF.
Thu, Jun 17, 2:30 PM · Restricted Project
jankratochvil added inline comments to D104271: llvm-dwarfdump: Print warnings on invalid DWARF.
Thu, Jun 17, 2:26 PM · Restricted Project
jankratochvil updated the diff for D104271: llvm-dwarfdump: Print warnings on invalid DWARF.
Thu, Jun 17, 2:25 PM · Restricted Project
jankratochvil added a comment to D104271: llvm-dwarfdump: Print warnings on invalid DWARF.

To satisfy all the required detailed reporting I had to extend the patch far more than I originally inteded. Is it OK this way?

Thu, Jun 17, 2:24 PM · Restricted Project
jankratochvil added inline comments to D104444: [lldb] Fix complex integer type parsing for GCC.
Thu, Jun 17, 11:03 AM · Restricted Project
jankratochvil accepted D104444: [lldb] Fix complex integer type parsing for GCC.

FYI GDB does not support these complex types.
GCC discusses it as PR debug/93988.

Thu, Jun 17, 8:28 AM · Restricted Project

Tue, Jun 15

jankratochvil committed rGfffb97509511: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite… (authored by jankratochvil).
[lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite…
Tue, Jun 15, 2:22 AM
jankratochvil closed D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.
Tue, Jun 15, 2:21 AM · Restricted Project
jankratochvil added a comment to D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.
  • We should hide the deleter if it's stateless (default_delete or a user-specified deleter that is empty) as the less verbose output is more useful for command line users.
Tue, Jun 15, 2:16 AM · Restricted Project
jankratochvil requested review of D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.
Tue, Jun 15, 1:33 AM · Restricted Project
jankratochvil reclaimed D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.
Tue, Jun 15, 1:33 AM · Restricted Project
jankratochvil planned changes to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
Tue, Jun 15, 12:56 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil added a comment to D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.

(Technically that would hide the deleter if the user specifies a default-deleter that just happens to be compatible, but that seems like an obscure corner case so this seems "good enough").

Tue, Jun 15, 12:54 AM · Restricted Project
jankratochvil abandoned D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.

So I think you can check-in your patch. I would just copy-paste it.

Tue, Jun 15, 12:51 AM · Restricted Project
jankratochvil requested review of D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.
Tue, Jun 15, 12:12 AM · Restricted Project

Mon, Jun 14

jankratochvil requested review of D104271: llvm-dwarfdump: Print warnings on invalid DWARF.
Mon, Jun 14, 3:03 PM · Restricted Project

Thu, Jun 10

jankratochvil requested review of D104014: [ocaml] [cmake] Fix make install error due to missing ocaml_doc.
Thu, Jun 10, 2:05 AM · Restricted Project

Wed, Jun 9

jankratochvil updated the diff for D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

This patch now requires: D101236, D103910 and D103966.

Wed, Jun 9, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil requested review of D103966: [llvm] Add new DI Flag IsZeroSize for D101237 [[no_unique_address]].
Wed, Jun 9, 8:00 AM · Restricted Project
jankratochvil added inline comments to D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Wed, Jun 9, 7:38 AM · Restricted Project
jankratochvil updated the diff for D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Wed, Jun 9, 7:37 AM · Restricted Project
jankratochvil reopened D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Wed, Jun 9, 7:04 AM · Restricted Project
jankratochvil updated the diff for D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.

@jberdine I had to update the OCaml bindings as otherwise a buildbot failed.

/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c: In function ‘map_DIFlag’:
/b/1/openmp-clang-x86_64-linux-debian/llvm.build/bindings/ocaml/debuginfo/debuginfo_ocaml.c:104:12: error: ‘LLVMDIFlagReserved’ undeclared (first use in this function); did you mean
‘i_DIFlagReserved’?
     return LLVMDIFlagReserved;
            ^~~~~~~~~~~~~~~~~~
            i_DIFlagReserved

I have fixed it based on a local build with OCaml (Fedora 34 x86_64). This is not a full OCaml sync with llvm/include/llvm/IR/DebugInfoFlags.def, just the part required to sync llvm/include/llvm-c/DebugInfo.h.
@jberdine Are you fine with this change?

Wed, Jun 9, 7:04 AM · Restricted Project
jankratochvil updated the summary of D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Wed, Jun 9, 7:00 AM · Restricted Project
jankratochvil added a reverting change for rG093750dd0be6: [llvm] Sync DebugInfo.h with DebugInfoFlags.def: rG09ac4eca6650: Revert "[llvm] Sync DebugInfo.h with DebugInfoFlags.def".
Wed, Jun 9, 1:40 AM
jankratochvil committed rG09ac4eca6650: Revert "[llvm] Sync DebugInfo.h with DebugInfoFlags.def" (authored by jankratochvil).
Revert "[llvm] Sync DebugInfo.h with DebugInfoFlags.def"
Wed, Jun 9, 1:40 AM
jankratochvil added a reverting change for D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def: rG09ac4eca6650: Revert "[llvm] Sync DebugInfo.h with DebugInfoFlags.def".
Wed, Jun 9, 1:40 AM · Restricted Project
jankratochvil committed rG093750dd0be6: [llvm] Sync DebugInfo.h with DebugInfoFlags.def (authored by jankratochvil).
[llvm] Sync DebugInfo.h with DebugInfoFlags.def
Wed, Jun 9, 1:13 AM
jankratochvil closed D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Wed, Jun 9, 1:13 AM · Restricted Project

Tue, Jun 8

jankratochvil updated subscribers of D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Tue, Jun 8, 12:07 PM · Restricted Project
jankratochvil updated the summary of D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Tue, Jun 8, 9:41 AM · Restricted Project
jankratochvil added inline comments to D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Tue, Jun 8, 9:39 AM · Restricted Project
jankratochvil requested review of D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Tue, Jun 8, 9:38 AM · Restricted Project

Mon, Jun 7

jankratochvil added a comment to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

[Dwarf-Discuss] How to map [[no_unique_address]] into DWARF: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2021-June/004825.html

Mon, Jun 7, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil added inline comments to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
Mon, Jun 7, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil updated the diff for D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

DW_AT_byte_size 0 implementation as suggested by @teemperor.

Mon, Jun 7, 10:53 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 31

jankratochvil accepted D103390: [lldb] Remove SBCommandReturnObject::ref.

I agree it should not be permitted to return the internal object from SB API. And if it still compiles after moving to private: then why not.

Mon, May 31, 1:55 AM · Restricted Project

Mon, May 24

jankratochvil updated the diff for D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
Mon, May 24, 12:45 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
cat >1.cpp <<EOH
template <typename T> struct DWrapper {};
typedef DWrapper<void> DW;
struct B {
  DW spd;
} b;
struct E {
  B &b_ref = b;
  static DW f() { return {}; }
} e;
EOH
$ (set -ex;./bin/clang -c -o 1.o 1.cpp -Wall -g;./bin/lldb -b ./1.o -o 'p E' -o 'p e')
(lldb) p E
(lldb) p e
lldb: .../clang/lib/AST/Decl.cpp:4188: bool clang::FieldDecl::isZeroSize(const clang::ASTContext &) const: Assertion `isInvalidDecl() && "valid field has incomplete type"' failed.

So importing just the type E is insufficient but I somehow cannot import the variable e:

  auto *FromE = FirstDeclMatcher<VarDecl>().match(FromTU, varDecl(hasName("e")));
...
  // ASTTests: .../llvm/include/llvm/Support/Casting.h:269: typename cast_retty<X, Y *>::ret_type llvm::cast(Y *) [X = clang::DeclContext, Y = clang::Decl]: Assertion `isa<X>(Val) && "cast<Ty>() argument of incompatible type!"' failed.
  llvm::Error Err = findFromTU(FromE)->Importer->ImportDefinition(FromE);
Mon, May 24, 12:45 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.

Update of the testcase but it still does not reproduce the LLDB problem.

Mon, May 24, 12:33 PM · Restricted Project, Restricted Project
jankratochvil added inline comments to D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
Mon, May 24, 12:19 AM · Restricted Project, Restricted Project

Sun, May 23

jankratochvil updated the diff for D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
Sun, May 23, 11:24 PM · Restricted Project, Restricted Project

Thu, May 20

jankratochvil committed rG6d19c84cd903: [lldb] Improve invalid DWARF DW_AT_ranges error reporting (authored by jankratochvil).
[lldb] Improve invalid DWARF DW_AT_ranges error reporting
Thu, May 20, 12:37 PM
jankratochvil closed D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting.
Thu, May 20, 12:37 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting.
Thu, May 20, 11:34 AM · Restricted Project, Restricted Project
jankratochvil planned changes to D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting.
Thu, May 20, 11:32 AM · Restricted Project, Restricted Project
jankratochvil requested review of D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting.

Is the message format OK now?

Thu, May 20, 11:21 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting.
Thu, May 20, 11:20 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Thu, May 20, 9:12 AM · Restricted Project
jankratochvil requested review of D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting.
Thu, May 20, 9:12 AM · Restricted Project, Restricted Project

Wed, May 19

jankratochvil retitled D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints from [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints to [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints.
Wed, May 19, 7:57 AM · Restricted Project
jankratochvil planned changes to D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints.

Is there any command we can run to directly get the number of h/w watchpoints?

Wed, May 19, 7:56 AM · Restricted Project
jankratochvil added a reviewer for D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints: Restricted Project.
Wed, May 19, 7:06 AM · Restricted Project
jankratochvil added a reviewer for D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints: jhibbits.
Wed, May 19, 7:06 AM · Restricted Project
jankratochvil added a comment to D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).

No objections from me. Anyone else?

Wed, May 19, 7:01 AM · Restricted Project
jankratochvil committed rGd1310817194a: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base… (authored by jankratochvil).
[lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base…
Wed, May 19, 6:58 AM
jankratochvil committed rG9dd861a4f539: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using… (authored by jankratochvil).
[nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using…
Wed, May 19, 6:58 AM
jankratochvil closed D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Wed, May 19, 6:57 AM · Restricted Project
jankratochvil closed D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Wed, May 19, 6:57 AM · Restricted Project

May 17 2021

jankratochvil added a comment to D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).

ping#2

May 17 2021, 7:24 AM · Restricted Project

May 10 2021

jankratochvil updated the diff for D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints.
May 10 2021, 1:31 AM · Restricted Project

May 9 2021

jankratochvil planned changes to D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints.

I forgot it should be also checking it is PowerPC.

May 9 2021, 11:39 PM · Restricted Project
jankratochvil requested review of D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints.
May 9 2021, 4:11 PM · Restricted Project

May 6 2021

jankratochvil planned changes to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
May 6 2021, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil reclaimed D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

Reopening as D101950 may take some time.

May 6 2021, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil planned changes to D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
May 6 2021, 8:31 AM · Restricted Project, Restricted Project
jankratochvil reclaimed D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
May 6 2021, 8:31 AM · Restricted Project, Restricted Project
jankratochvil abandoned D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

IIUC it will get replaced by D101950.
I will just provide some testcase for this case if not already contained therein.

May 6 2021, 8:28 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil abandoned D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.

IIUC it will get replaced by D101950.

May 6 2021, 8:27 AM · Restricted Project, Restricted Project

May 2 2021

jankratochvil added a comment to D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.

You can create a similar descendant class, but with the MinimalImport flag set to true. Then you could call ImportDefinition subsequently after an Import call. Perhaps that could trigger your assertion.

May 2 2021, 10:54 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
May 2 2021, 10:51 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D92223: [lldb] Add support for looking up static const members.

The considered .debug_names index update would need to make .debug_names working in the first place - as it does not work now: D99850
So maybe the manual DIE traversal without updating the index and without the regex capability is OK but I do not want to give the agreement myself.

May 2 2021, 6:43 AM · Restricted Project
jankratochvil removed a reviewer for D92223: [lldb] Add support for looking up static const members: jankratochvil.
May 2 2021, 6:40 AM · Restricted Project

Apr 26 2021

jankratochvil planned changes to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

AFAICT this will change the answer to basic questions such as what size a struct is and this will likely lead to confusion from our users who will expect the answers in expression parsing to match what they are seeing elsewhere e.g.:

Apr 26 2021, 9:51 PM · Restricted Project, Restricted Project, Restricted Project
jankratochvil planned changes to D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.

Not sure what the backtrace is for the clang::FieldDecl::isZeroSize crash but what might relevant:

Apr 26 2021, 5:51 AM · Restricted Project, Restricted Project

Apr 25 2021

jankratochvil updated the diff for D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
Apr 25 2021, 2:19 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

grep tells me that attribute also influences a bunch of other things in subtle ways (It seems to potentially influence ABIs and Obj-C encodings?) and we don't really know what other things this might influence in the future. So I have the suspicion that putting that attr on all record fields might break something in a subtle way.

Apr 25 2021, 1:48 AM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2021

jankratochvil added a comment to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

Given that no_unique_address changes the layout of data structures ( https://clang.llvm.org/docs/AttributeReference.html#no-unique-address ) adding it to a member that doesn't actually have it specified I believe would break layout of structures

Apr 24 2021, 4:30 PM · Restricted Project, Restricted Project, Restricted Project
jankratochvil added inline comments to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
Apr 24 2021, 9:47 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil updated the summary of D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
Apr 24 2021, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil updated the summary of D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
Apr 24 2021, 9:38 AM · Restricted Project, Restricted Project
jankratochvil requested review of D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.
Apr 24 2021, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
jankratochvil requested review of D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB.
Apr 24 2021, 9:27 AM · Restricted Project, Restricted Project

Apr 23 2021

jankratochvil planned changes to D96239: [lldb] DWZ 4/9: DIERef support.
Apr 23 2021, 12:52 AM · Restricted Project
jankratochvil planned changes to D96240: [lldb] DWZ 5/9: Main functionality.
Apr 23 2021, 12:51 AM · Restricted Project
jankratochvil planned changes to D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs.

I would be fine with DWARFDie getting bigger to 24B.

Apr 23 2021, 12:50 AM · Restricted Project

Apr 22 2021

jankratochvil updated the diff for D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs.

Just a rebase on top of trunk.

Apr 22 2021, 2:53 PM · Restricted Project
jankratochvil added a comment to D91679: [trace][intel-pt] Implement trace start and trace stop.

Checked in a regression fix: rG18a85276426b9604a9ceca8c528b694964dd8d7c

Apr 22 2021, 1:32 PM · Restricted Project
jankratochvil added a comment to D100340: [lldb-vscode] Add postRunCommands.

The regression was due to the help process trace command which surprisingly ends up in GDBRemoteCommunicationClient::SendTraceSupported which was crashing on libipt-enabled builds. Fixed by: rG18a85276426b9604a9ceca8c528b694964dd8d7c

Apr 22 2021, 1:31 PM · Restricted Project
jankratochvil committed rG18a85276426b: [trace][intel-pt] Fix a crash on unconsumed Expected's Error (authored by jankratochvil).
[trace][intel-pt] Fix a crash on unconsumed Expected's Error
Apr 22 2021, 1:27 PM
jankratochvil accepted D101056: [lldb] Let dotest check for the `cassert` header instead of `algorithm` for libc++ check.

The detection still works fine with libcxx-devel-11.0.0-1.fc33.x86_64.

Apr 22 2021, 5:43 AM · Restricted Project
jankratochvil added a comment to D100340: [lldb-vscode] Add postRunCommands.

It has caused a regression for Fedora buildbot (which is so far a silent one):
https://lab.llvm.org/staging/#/builders/16/builds/4936

Failed Tests (2):
  lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py
  lldb-api :: tools/lldb-vscode/launch/TestVSCode_launch.py

I will check it more.

Apr 22 2021, 12:33 AM · Restricted Project

Apr 21 2021

jankratochvil added a comment to D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs.

(similar idea)

Apr 21 2021, 2:14 PM · Restricted Project
jankratochvil added a comment to D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs.

That's sure fine, thanks for the reply. Great there is at least the plan to review it in the future. I understand you are busy.

Apr 21 2021, 8:13 AM · Restricted Project

Apr 19 2021

jankratochvil added a comment to D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs.

Ping, it would be nice to know if there is some plan/schedule for patch review of this series. I understand it is all voluntary, thanks.

Apr 19 2021, 12:30 AM · Restricted Project

Apr 10 2021

jankratochvil added a comment to D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).

Sorry for the ping but is there anything left to clarify or fix?

Apr 10 2021, 8:21 AM · Restricted Project

Apr 7 2021

jankratochvil added a comment to D99900: [llvm] [testsuite] Fix invalid DW_AT_location DWARF expression in unattached-global.ll.

@aprantl @JDevlieghere do you folks want to update the verifier in any way to make this sort of thing invalid?

Apr 7 2021, 1:21 PM · Restricted Project

Apr 5 2021

jankratochvil planned changes to D99850: [WIP/RFC] lld LTO drops variables in namespaces from .debug_names.
Apr 5 2021, 2:41 PM · Restricted Project
jankratochvil requested review of D99900: [llvm] [testsuite] Fix invalid DW_AT_location DWARF expression in unattached-global.ll.
Apr 5 2021, 2:41 PM · Restricted Project

Apr 4 2021

jankratochvil updated the diff for D99850: [WIP/RFC] lld LTO drops variables in namespaces from .debug_names.
Apr 4 2021, 3:29 PM · Restricted Project