Page MenuHomePhabricator
People jankratochvil

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (307 w, 5 d)

Recent Activity
View All

Jan 12 2023

jankratochvil abandoned D71707: clang-tidy: new bugprone-pointer-cast-widening.

Thanks for the reminder, I have todolisted it now for myself but for now I am abandoning it as I cannot promise anything.

Jan 12 2023, 10:00 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

Herald added a project to D62732: [RISCV] Add SystemV ABI: Restricted Project.
May 6 2022, 1:48 PM · Restricted Project, Restricted Project

Oct 25 2021

jankratochvil committed rZORG660fa27e1272: [zorg] Remove lldb-x86_64-fedora (authored by jankratochvil).
[zorg] Remove lldb-x86_64-fedora
Oct 25 2021, 12:43 PM
jankratochvil closed D112375: [zorg] Remove lldb-x86_64-fedora.
Oct 25 2021, 12:43 PM · Restricted Project
jankratochvil retitled D112375: [zorg] Remove lldb-x86_64-fedora from [zorg] lldb-x86_64-fedora to [zorg] Remove lldb-x86_64-fedora.
Oct 25 2021, 12:42 PM · Restricted Project

Oct 24 2021

jankratochvil requested review of D112375: [zorg] Remove lldb-x86_64-fedora.
Oct 24 2021, 1:11 AM · Restricted Project

Oct 14 2021

jankratochvil planned changes to D103966: [llvm] Add new DI Flag IsZeroSize for D101237 [[no_unique_address]].
Oct 14 2021, 8:48 AM · Restricted Project

Sep 27 2021

jankratochvil abandoned D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96242: [lldb] DWZ 16/17: New testcases.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96241: [lldb] DWZ 15/17: New testsuite category 'dwz'.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D98826: [lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96240: [lldb] DWZ 13/17: Main functionality.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96239: [lldb] DWZ 12/17: DIERef support.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96238: [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96237: [lldb] DWZ 10/17: More support for .gnu_debugaltlink.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs.

I will be no longer involved with this patchset.

Sep 27 2021, 9:34 AM · Restricted Project
jankratochvil abandoned D110404: [nfc] [lldb] DWZ 08/17: Use DIERef for DIEToClangType m_forward_decl_die_to_clang_type and GetForwardDeclDieToClangType().

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110403: [nfc] [lldb] DWZ 07/17: Use DIERef for DIEToVariableSP m_die_to_variable_sp and GetDIEToVariable().

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110402: [nfc] [lldb] DWZ 06/17: Use DIERef for DIEToTypePtr m_die_to_type and GetDIEToType().

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110401: [nfc] [lldb] DWZ 05/17: Use DIERef for DIEToDeclMap m_die_to_decl.

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110400: [nfc] [lldb] DWZ 04/17: Use DIERef for DIEToModuleMap m_die_to_module.

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110399: [nfc] [lldb] DWZ 03/17: Use DIERef for DIEToDeclContextMap m_die_to_decl_ctx.

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap.

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil abandoned D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToDIEMap m_decl_ctx_to_die.

I will be no longer involved with this patchset.

Sep 27 2021, 9:33 AM · Restricted Project
jankratochvil retitled D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs from [lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs to [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs.
Sep 27 2021, 2:53 AM · Restricted Project
jankratochvil retitled D96238: [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles from [nfc] [lldb] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles to [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles.
Sep 27 2021, 2:52 AM · Restricted Project
jankratochvil retitled D96238: [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles from [lldb] [nfc] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles to [nfc] [lldb] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles.
Sep 27 2021, 2:39 AM · Restricted Project

Sep 24 2021

jankratochvil updated the summary of D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap.
Sep 24 2021, 2:43 PM · Restricted Project
jankratochvil requested review of D110404: [nfc] [lldb] DWZ 08/17: Use DIERef for DIEToClangType m_forward_decl_die_to_clang_type and GetForwardDeclDieToClangType().
Sep 24 2021, 3:17 AM · Restricted Project
jankratochvil requested review of D110403: [nfc] [lldb] DWZ 07/17: Use DIERef for DIEToVariableSP m_die_to_variable_sp and GetDIEToVariable().
Sep 24 2021, 3:15 AM · Restricted Project
jankratochvil requested review of D110402: [nfc] [lldb] DWZ 06/17: Use DIERef for DIEToTypePtr m_die_to_type and GetDIEToType().
Sep 24 2021, 3:14 AM · Restricted Project
jankratochvil requested review of D110401: [nfc] [lldb] DWZ 05/17: Use DIERef for DIEToDeclMap m_die_to_decl.
Sep 24 2021, 3:12 AM · Restricted Project
jankratochvil requested review of D110400: [nfc] [lldb] DWZ 04/17: Use DIERef for DIEToModuleMap m_die_to_module.
Sep 24 2021, 3:11 AM · Restricted Project
jankratochvil requested review of D110399: [nfc] [lldb] DWZ 03/17: Use DIERef for DIEToDeclContextMap m_die_to_decl_ctx.
Sep 24 2021, 3:09 AM · Restricted Project
jankratochvil retitled D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToDIEMap m_decl_ctx_to_die from [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToFileDIERefMap m_decl_ctx_to_filedieref to [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToDIEMap m_decl_ctx_to_die.
Sep 24 2021, 3:07 AM · Restricted Project
jankratochvil requested review of D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap.
Sep 24 2021, 3:05 AM · Restricted Project
jankratochvil requested review of D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToDIEMap m_decl_ctx_to_die.
Sep 24 2021, 3:03 AM · Restricted Project
jankratochvil updated the diff for D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files.

My question about upstreaming of this patchset.

Sep 24 2021, 3:00 AM · Restricted Project
jankratochvil updated the diff for D96242: [lldb] DWZ 16/17: New testcases.

My question about upstreaming of this patchset.

Sep 24 2021, 2:59 AM · Restricted Project
jankratochvil updated the diff for D96241: [lldb] DWZ 15/17: New testsuite category 'dwz'.

My question about upstreaming of this patchset.

Sep 24 2021, 2:59 AM · Restricted Project
jankratochvil updated the diff for D98826: [lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols.

My question about upstreaming of this patchset.

Sep 24 2021, 2:58 AM · Restricted Project
jankratochvil updated the diff for D96240: [lldb] DWZ 13/17: Main functionality.

My question about upstreaming of this patchset.

Sep 24 2021, 2:57 AM · Restricted Project
jankratochvil updated the diff for D96239: [lldb] DWZ 12/17: DIERef support.

My question about upstreaming of this patchset.

Sep 24 2021, 2:56 AM · Restricted Project
jankratochvil updated the diff for D96238: [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles.

My question about upstreaming of this patchset.

Sep 24 2021, 2:56 AM · Restricted Project
jankratochvil updated the diff for D96237: [lldb] DWZ 10/17: More support for .gnu_debugaltlink.

My question about upstreaming of this patchset.

Sep 24 2021, 2:55 AM · Restricted Project
jankratochvil updated the diff for D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs.
Sep 24 2021, 2:53 AM · Restricted Project
jankratochvil added a comment to D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs.
Sep 24 2021, 2:52 AM · Restricted Project
jankratochvil updated the summary of D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs.
Sep 24 2021, 2:49 AM · Restricted Project

Sep 17 2021

jankratochvil committed rGe93baded3957: [nfc] [lldb] Remove unused DIEPointerSet, DeclToDIEMap and m_decl_to_die (authored by jankratochvil).
[nfc] [lldb] Remove unused DIEPointerSet, DeclToDIEMap and m_decl_to_die
Sep 17 2021, 12:53 PM

Sep 12 2021

jankratochvil committed rGff94f6024082: [lldb] [testsuite] Fix false failures on "\n" regex match (authored by jankratochvil).
[lldb] [testsuite] Fix false failures on "\n" regex match
Sep 12 2021, 10:38 PM

Sep 3 2021

jankratochvil added a comment to D107521: [lldb/Plugins] Introduce Scripted Interface Factory.

It broke Fedora 34 x86_64 buildbot (using gcc) lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 - the build fails:
https://lab.llvm.org/staging/#/builders/16/builds/10450

Sep 3 2021, 1:12 PM · Restricted Project

Sep 2 2021

jankratochvil added a comment to D108351: [lldb server] Tidy up LLDB server return codes and associated tests.

The new test is failing on all Linux buildbots such as:
lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16
lldb-x86_64-debian = https://lab.llvm.org/buildbot/#/builders/68
https://lab.llvm.org/buildbot/#/builders?tags=lldb

Sep 2 2021, 6:24 AM · Restricted Project

Aug 27 2021

jankratochvil accepted D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file.
Aug 27 2021, 1:26 PM · Restricted Project

Aug 17 2021

jankratochvil retitled D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) from [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) to [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 17 2021, 1:21 PM · Restricted Project, Restricted Project
jankratochvil committed rGe21a21a977b4: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base… (authored by jankratochvil).
[lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base…
Aug 17 2021, 1:19 PM
jankratochvil closed D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 17 2021, 1:19 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
In D106466#2947710, @dblaikie wrote:

I assume there's already test coverage for rnglistx in debug_info.dwo/split unit? (because in that case there's no rnglists_base, but rnglistx is usable)

Aug 17 2021, 12:38 PM · Restricted Project, Restricted Project

Aug 16 2021

jankratochvil updated the diff for D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 16 2021, 11:24 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
In D107470#2946689, @ikudrin wrote:

DWARFDebugInfo.TestRnglistsAddressSize, DWARFListTableHeader.AddressSize64Offset, and DWARFListTableHeader.AddressSize32Offset pass without applying the patch. Why adding them?

Aug 16 2021, 11:24 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).

@dblaikie do you think it is OK for check-in now?

Aug 16 2021, 10:57 AM · Restricted Project, Restricted Project

Aug 14 2021

jankratochvil abandoned D106465: 1/3: [llvm] Refactorization for fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).

With the new variant of D106466 this refactorization is no longer needed.
Thanks for the review, unfortunately I do not think it makes sense on its own (but I can check it in if you think so).

Aug 14 2021, 1:17 PM · Restricted Project
jankratochvil added a comment to D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
In D106466#2939551, @ikudrin wrote:
In D106466#2926185, @jankratochvil wrote:

One needs to set at least AddrSize and OffsetEntryCount as callers do use it.

Could you please point me to that usage? I am not that familiar with the LLDB code.

Aug 14 2021, 1:15 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 14 2021, 1:11 PM · Restricted Project, Restricted Project
jankratochvil added inline comments to D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 14 2021, 1:10 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 14 2021, 1:08 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 14 2021, 1:06 PM · Restricted Project, Restricted Project

Aug 12 2021

jankratochvil added inline comments to D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 12 2021, 9:22 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 12 2021, 9:11 AM · Restricted Project, Restricted Project

Aug 11 2021

jankratochvil planned changes to D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 11 2021, 8:25 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file.
Aug 11 2021, 7:45 AM · Restricted Project

Aug 10 2021

jankratochvil committed rGf3932b9a0b0b: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using . (authored by jankratochvil).
[nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .
Aug 10 2021, 11:43 AM
jankratochvil closed D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names.
Aug 10 2021, 11:43 AM · Restricted Project

Aug 9 2021

jankratochvil added a comment to D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names.

Thanks for checking it but ...

Aug 9 2021, 4:57 AM · Restricted Project

Aug 6 2021

jankratochvil updated the diff for D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names.
In D107659#2931836, @clayborg wrote:

Can we not just grab the skeleton unit when/if needed instead of asserting in many places?

Aug 6 2021, 12:03 PM · Restricted Project
jankratochvil accepted D106270: [DWARF5] Fix offset check when using .debug_names.

LGTM

Aug 6 2021, 10:45 AM · Restricted Project
jankratochvil requested review of D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names.
Aug 6 2021, 10:43 AM · Restricted Project

Aug 4 2021

jankratochvil committed rG14f443030c1a: [nfc] [lldb] Prevent needless copies of DataExtractor (authored by jankratochvil).
[nfc] [lldb] Prevent needless copies of DataExtractor
Aug 4 2021, 11:36 AM
jankratochvil closed D107485: [nfc] [lldb] Prevent needless copies of DataExtractor.
Aug 4 2021, 11:36 AM · Restricted Project
jankratochvil updated the diff for D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 4 2021, 11:04 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
In D106466#2922549, @ikudrin wrote:

As far as I understand it, you need a specially constructed llvm::DWARFDebugRnglistTable object so that DWARFUnit::FindRnglistFromOffset() can call its findList() method and get a list of records located at a specific offset.

Aug 4 2021, 11:03 AM · Restricted Project, Restricted Project
jankratochvil requested review of D107485: [nfc] [lldb] Prevent needless copies of DataExtractor.
Aug 4 2021, 10:51 AM · Restricted Project
jankratochvil retitled D106465: 1/3: [llvm] Refactorization for fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) from [llvm] 1/2: Refactorization for fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) to 1/3: [llvm] Refactorization for fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 4 2021, 10:40 AM · Restricted Project
jankratochvil retitled D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) from [llvm+lldb] 4/4: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) to 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 4 2021, 10:39 AM · Restricted Project, Restricted Project
jankratochvil retitled D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor from 2/4: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor to 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 4 2021, 10:39 AM · Restricted Project, Restricted Project
jankratochvil retitled D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) from [llvm+lldb] 2/2: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC) to [llvm+lldb] 4/4: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC).
Aug 4 2021, 8:34 AM · Restricted Project, Restricted Project
jankratochvil requested review of D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor.
Aug 4 2021, 8:33 AM · Restricted Project, Restricted Project

Aug 2 2021

jankratochvil added a reviewer for D106466: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC): ikudrin.
Aug 2 2021, 1:43 PM · Restricted Project, Restricted Project
jankratochvil committed rG437e37dd5539: [nfc] [lldb] Support moving support files instead of copy (authored by Eric).
[nfc] [lldb] Support moving support files instead of copy
Aug 2 2021, 12:43 PM
jankratochvil closed D107165: Support moving support files instead of copy.
Aug 2 2021, 12:43 PM · Restricted Project
jankratochvil committed rGea9706626ce3: [test] [lldb] Use filename instead of index in test (authored by Eric).
[test] [lldb] Use filename instead of index in test
Aug 2 2021, 12:13 PM
jankratochvil closed D107300: Use filename instead of index in test.
Aug 2 2021, 12:13 PM · Restricted Project
jankratochvil accepted D107300: Use filename instead of index in test.

s/if symbols for start.S or similar are included before the symbols for the file./if start.S has its own DWARF CompileUnit or similar are included before the DWARF CompileUnit for the file./

Aug 2 2021, 11:06 AM · Restricted Project

Aug 1 2021

jankratochvil accepted D107161: [lldb] Fix lookup of .debug_loclists with split-dwarf.

LGTM with some those adjustments.

Aug 1 2021, 11:34 AM · Restricted Project

Jul 31 2021

jankratochvil committed rG6ef6616e07f5: [nfc] [lldb] Removed unused DWARFDebugInfo::GetDIEForDIEOffset (authored by jankratochvil).
[nfc] [lldb] Removed unused DWARFDebugInfo::GetDIEForDIEOffset
Jul 31 2021, 3:38 PM
jankratochvil accepted D107165: Support moving support files instead of copy.

LGTM

Jul 31 2021, 7:55 AM · Restricted Project
jankratochvil added a comment to D100299: Be lazier about loading .dwo files.
In D100299#2917768, @stella.stamenova wrote:

This also fails on the Windows lldb bot:

Jul 31 2021, 1:53 AM · Restricted Project
jankratochvil committed rGfb09f365ae28: [lldb] [DWARF-5] Be lazier about loading .dwo files (authored by Eric).
[lldb] [DWARF-5] Be lazier about loading .dwo files
Jul 31 2021, 1:46 AM

Jul 30 2021

jankratochvil added a comment to D100299: Be lazier about loading .dwo files.
In D100299#2917467, @Eric wrote:

Is arm hardware necessary to test this,

Jul 30 2021, 2:30 PM · Restricted Project
jankratochvil committed rG8dfd6cae9bd6: [lldb] [DWARF-5] Be lazier about loading .dwo files (authored by Eric).
[lldb] [DWARF-5] Be lazier about loading .dwo files
Jul 30 2021, 2:17 PM
jankratochvil added a comment to D100299: Be lazier about loading .dwo files.
In D100299#2917250, @Eric wrote:

Would it make sense to turn the split-optimized test back into an x86 only test, or just leave it out of the change as it's not actually testing a code path that this changed?

Jul 30 2021, 11:47 AM · Restricted Project