Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (114 w, 4 d)

Recent Activity

Yesterday

jankratochvil added a comment to D66398: 2/2: Fix `TestDataFormatterStdList` regression.

"jankratochvil added a reverting change" - that is not true, Differential got somehow confused by the commit text there talking about this patch.

Fri, Sep 20, 1:35 PM · Restricted Project, Restricted Project
jankratochvil committed rGce7cfbccc63b: [lldb] Process formatters in reverse-chronological order (authored by jankratochvil).
[lldb] Process formatters in reverse-chronological order
Fri, Sep 20, 1:20 PM
jankratochvil added a reverting change for D66398: 2/2: Fix `TestDataFormatterStdList` regression: rGce7cfbccc63b: [lldb] Process formatters in reverse-chronological order.
Fri, Sep 20, 1:20 PM · Restricted Project, Restricted Project
jankratochvil added a reverting change for D66398: 2/2: Fix `TestDataFormatterStdList` regression: rLLDB372424: [lldb] Process formatters in reverse-chronological order.
Fri, Sep 20, 1:18 PM · Restricted Project, Restricted Project
jankratochvil committed rL372424: [lldb] Process formatters in reverse-chronological order.
[lldb] Process formatters in reverse-chronological order
Fri, Sep 20, 1:18 PM
jankratochvil added a reverting change for D66398: 2/2: Fix `TestDataFormatterStdList` regression: rL372424: [lldb] Process formatters in reverse-chronological order.
Fri, Sep 20, 1:18 PM · Restricted Project, Restricted Project
jankratochvil closed D66654: 2/2: Process formatters in reverse-chronological order.
Fri, Sep 20, 1:18 PM · Restricted Project, Restricted Project

Wed, Sep 18

jankratochvil added a comment to D67589: Fix crash on SBCommandReturnObject & assignment.

We are making all efforts to vend a stable C++ API.

Wed, Sep 18, 3:07 PM · Restricted Project
jankratochvil updated the diff for D67589: Fix crash on SBCommandReturnObject & assignment.
Wed, Sep 18, 5:23 AM · Restricted Project
jankratochvil added a comment to D67589: Fix crash on SBCommandReturnObject & assignment.

We couldn't use PointerIntPair due to the our abi stability promise (http://lldb.llvm.org/resources/sbapi.html).

Wed, Sep 18, 5:18 AM · Restricted Project

Tue, Sep 17

jankratochvil added inline comments to D67589: Fix crash on SBCommandReturnObject & assignment.
Tue, Sep 17, 8:10 AM · Restricted Project
jankratochvil updated the diff for D67589: Fix crash on SBCommandReturnObject & assignment.
Tue, Sep 17, 8:05 AM · Restricted Project
jankratochvil added a comment to D67589: Fix crash on SBCommandReturnObject & assignment.

I agree that this approach isn't nice, but probably there isn't a nice approach to this at this point. One possibility you could consider is storing a shared_ptr<CommandRO> inside SBCommandRO and encoding the ownership into the deleter of the shared_ptr (regular deleter => owned, noop deleter => unowned).

Tue, Sep 17, 8:01 AM · Restricted Project

Sat, Sep 14

jankratochvil created D67589: Fix crash on SBCommandReturnObject & assignment.
Sat, Sep 14, 2:10 PM · Restricted Project
jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.
Sat, Sep 14, 8:53 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D66654: 2/2: Process formatters in reverse-chronological order.
Sat, Sep 14, 8:53 AM · Restricted Project, Restricted Project
jankratochvil committed rG9060643380b3: [lldb] Code cleanup: FormattersContainer.h: Use range-based for loops. (authored by jankratochvil).
[lldb] Code cleanup: FormattersContainer.h: Use range-based for loops.
Sat, Sep 14, 8:48 AM
jankratochvil committed rL371922: [lldb] Code cleanup: FormattersContainer.h: Use range-based for loops..
[lldb] Code cleanup: FormattersContainer.h: Use range-based for loops.
Sat, Sep 14, 8:45 AM

Fri, Sep 6

jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.

I have tried the MapVector with RegularExpressionSP as its key as suggested by @labath but that would be even more code than the std::list I provided here, both for its custom shared-pointer sorting and for its EmptyKey+TombstoneKey if we should not put std::map there.
So I returned back to a single std::vector as originally suggested by @labath and after fixing missing Delete in the Add implementation for vector it I think that may be a good compromise from all the variants.

Fri, Sep 6, 11:37 AM · Restricted Project, Restricted Project
jankratochvil committed rGb1dcbf1b1647: [lldb] Small optimization of FormatMap::Delete and FormatMap::Get (authored by jankratochvil).
[lldb] Small optimization of FormatMap::Delete and FormatMap::Get
Fri, Sep 6, 10:53 AM
jankratochvil committed rL371234: [lldb] Small optimization of FormatMap::Delete and FormatMap::Get.
[lldb] Small optimization of FormatMap::Delete and FormatMap::Get
Fri, Sep 6, 10:51 AM

Wed, Sep 4

jankratochvil committed rG5aa1d81969fb: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue (authored by jankratochvil).
Code cleanup: Change FormattersContainer::KeyType from SP to rvalue
Wed, Sep 4, 2:47 AM
jankratochvil committed rL370863: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue.
Code cleanup: Change FormattersContainer::KeyType from SP to rvalue
Wed, Sep 4, 2:47 AM
jankratochvil closed D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue.
Wed, Sep 4, 2:47 AM · Restricted Project, Restricted Project

Tue, Sep 3

jankratochvil created D67099: [zorg] [LLDB] Add lldb-s390x-fedora, lldb-ppc64le-fedora.
Tue, Sep 3, 7:26 AM · Restricted Project

Mon, Sep 2

jankratochvil added a comment to D66654: 2/2: Process formatters in reverse-chronological order.

The most common operations are lookup (which are linear in any case),

Mon, Sep 2, 6:50 AM · Restricted Project, Restricted Project
jankratochvil accepted D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test.
Mon, Sep 2, 5:39 AM · Restricted Project
jankratochvil committed rL370646: Request commit access for jankratochvil.
Request commit access for jankratochvil
Mon, Sep 2, 4:58 AM

Sun, Sep 1

jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Sep 1, 11:11 AM · Restricted Project, Restricted Project
jankratochvil added a child revision for D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue: D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Sep 1, 8:33 AM · Restricted Project, Restricted Project
jankratochvil added a parent revision for D66654: 2/2: Process formatters in reverse-chronological order: D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue.
Sun, Sep 1, 8:33 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.

Personally, I'd go for the registration order,

Sun, Sep 1, 8:33 AM · Restricted Project, Restricted Project
jankratochvil added a reverting change for D66398: 2/2: Fix `TestDataFormatterStdList` regression: D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Sep 1, 8:33 AM · Restricted Project, Restricted Project
jankratochvil created D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue.
Sun, Sep 1, 8:21 AM · Restricted Project, Restricted Project
jankratochvil committed rG5341193537d8: [lldb] Small optimization of FormatMap::Delete (authored by jankratochvil).
[lldb] Small optimization of FormatMap::Delete
Sun, Sep 1, 8:13 AM
jankratochvil committed rL370612: [lldb] Small optimization of FormatMap::Delete.
[lldb] Small optimization of FormatMap::Delete
Sun, Sep 1, 8:07 AM

Fri, Aug 30

jankratochvil updated subscribers of D62179: [llvm-readelf] - Allow dumping of the .dynamic section even if there is no PT_DYNAMIC header..

There is a regression - after this patch - at least after its later commit:

commit 8ac7b2d07bd6042afe0e8618ca8682d7663f4be8
Author: George Rimar <grimar@accesssoftek.com>
Date:   Wed May 29 10:31:46 2019 +0000
    [llvm-readelf] - Allow dumping of the .dynamic section even if there is no PT_DYNAMIC header.
    Differential revision: https://reviews.llvm.org/D62179
    llvm-svn: 361943

llvm-readobj cannot print .dynsym of executable without Program Headers. GNU readelf can print it fine. We have found it with @kwk because of some unrelated bug in obj2yaml/`yaml2obj' dropping Program Headers.
On 64-bit Linux one can create a test binary with:

cp -p /bin/bash /tmp/bashtest;dd if=/dev/zero of=/tmp/bashtest bs=1 count=2 seek=$[0x38] conv=notrunc

llvm-readobj -dyn-symbols formerly printed for example:

Symbol {
  Name: tilde_expand_word (11424)
  Value: 0xDBE60

while now it prints only:

warning: Unable to parse DT_GNU_HASH: Virtual address is not in any segment
warning: Unable to parse DT_STRTAB: Virtual address is not in any segment
warning: Unable to parse DT_SYMTAB: Virtual address is not in any segment
warning: Unable to parse DT_JMPREL: Virtual address is not in any segment
warning: Unable to parse DT_RELA: Virtual address is not in any segment
File: /tmp/bashtest
Format: ELF64-x86-64
Arch: x86_64
AddressSize: 64bit 
LoadName:
DynamicSymbols [
]
Fri, Aug 30, 9:19 AM · Restricted Project
jankratochvil added a comment to rL370054: Stabilize TestIOHandlerCompletion.

Solved by @labath, I had leftover *.pyc file in ./lldb/third_party/Python/module/pexpect-2.4/, it started working after deleting it.

Fri, Aug 30, 4:28 AM
jankratochvil added a comment to rL370054: Stabilize TestIOHandlerCompletion.

On my development system Fedora 30 x86_64 this commit did regress:

Command invoked: /home/jkratoch/redhat/llvm-monorepo/lldb/test/dotest.py -q --arch=x86_64 -s /home/jkratoch/redhat/llvm-monorepo-clangassert/lldb-test-traces --build-dir /home/jkratoch/redhat/llvm-monorepo-clangassert/lldb-test-build.noindex -S nm -u CXXFLAGS -u CFLAGS --executable /home/jkratoch/redhat/llvm-monorepo-clangassert/./bin/lldb --dsymutil /home/jkratoch/redhat/llvm-monorepo-clangassert/./bin/dsymutil --filecheck /home/jkratoch/redhat/llvm-monorepo-clangassert/./bin/FileCheck -C /home/jkratoch/redhat/llvm-monorepo-clangassert/./bin/clang --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy -p TestIOHandlerCompletion
Exception AttributeError: "'spawn' object has no attribute 'closed'" in <bound method spawn.__del__ of <pexpect.spawn object at 0x7fdf70605d10>> ignored
FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-10-x86_64) :: test_completion (TestIOHandlerCompletion.IOHandlerCompletionTest)
======================================================================
ERROR: test_completion (TestIOHandlerCompletion.IOHandlerCompletionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 111, in wrapper
    func(*args, **kwargs)
  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/iohandler/completion/TestIOHandlerCompletion.py", line 42, in test_completion
    dimensions=(100, 500))
TypeError: __init__() got an unexpected keyword argument 'dimensions'
Config=x86_64-/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-10
----------------------------------------------------------------------

It is accessing only these files:

22656 stat("/home/jkratoch/redhat/llvm-monorepo/lldb/third_party/Python/module/pexpect-2.4", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
22656 stat("/home/jkratoch/redhat/llvm-monorepo/lldb/third_party/Python/module/pexpect-4.6", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
22656 stat("/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/lldbpexpect.pyc", {st_mode=S_IFREG|0644, st_size=2741, ...}) = 0
22656 stat("/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/lldbpexpect.py", {st_mode=S_IFREG|0644, st_size=2737, ...}) = 0
22656 openat(AT_FDCWD, "/home/jkratoch/redhat/llvm-monorepo/lldb/third_party/Python/module/pexpect-2.4/pexpect.pyc", O_RDONLY) = 4

No matter whether I have python2-pexpect-4.6-3.fc30.noarch installed or not. Surprisingly on my buildbot it PASSes the test.
As a Python expect don't you have an idea? :-)

Fri, Aug 30, 4:06 AM

Tue, Aug 27

jankratochvil planned changes to D66654: 2/2: Process formatters in reverse-chronological order.
Tue, Aug 27, 5:10 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D66744: NativeProcessLinux: Remove some register context boilerplate.

But then there is NativeRegisterContextLinux_x86_64::GetFPRBuffer(). Which is never used so maybe together with NativeRegisterContextLinux_x86_64::GetFPRSize() they could be just assert(0);. It can be also considered as a different cleanup patch.

Hm.. I didn't notice that. I'll put that in separately. Ideally, I'd say these functions should be used, but that may require more cleanups in the x86 register context, such as detecting the register type earlier on instead of just when the operations fail.

Tue, Aug 27, 3:47 AM · Restricted Project
jankratochvil accepted D66744: NativeProcessLinux: Remove some register context boilerplate.
Tue, Aug 27, 1:54 AM · Restricted Project
jankratochvil added a comment to D66744: NativeProcessLinux: Remove some register context boilerplate.

{Read,Write}[GF]PR now no longer check whether the supplied buffers are null, because they never are

Tue, Aug 27, 1:54 AM · Restricted Project

Mon, Aug 26

jankratochvil added a comment to D66654: 2/2: Process formatters in reverse-chronological order.

What about having the first one that matched being the one that is used and avoid errors all together?

Mon, Aug 26, 1:01 PM · Restricted Project, Restricted Project

Sun, Aug 25

jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.

Testcase for the regex sanity check is failing - ValueObject::m_error remains set even after type summary clear. ValueObject::UpdateValueIfNeeded will find did_change_formats==true but it does not help it. I think there is some bug in ValueObject updating but maybe that setting of ValueObject::m_error is a wrong idea.

runCmd: type summary clear
output:
Sun, Aug 25, 11:14 PM · Restricted Project, Restricted Project
jankratochvil planned changes to D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Aug 25, 1:42 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Aug 25, 10:38 AM · Restricted Project, Restricted Project
jankratochvil updated the summary of D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Aug 25, 10:18 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66654: 2/2: Process formatters in reverse-chronological order.
Sun, Aug 25, 10:18 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D66654: 2/2: Process formatters in reverse-chronological order.

How much work would it be to return an llvm::Expected<bool> from Get_Impl? I'd really prefer that over the current approach.

Sun, Aug 25, 10:16 AM · Restricted Project, Restricted Project

Fri, Aug 23

jankratochvil planned changes to D66654: 2/2: Process formatters in reverse-chronological order.
Fri, Aug 23, 10:16 AM · Restricted Project, Restricted Project
jankratochvil created D66654: 2/2: Process formatters in reverse-chronological order.
Fri, Aug 23, 8:00 AM · Restricted Project, Restricted Project

Aug 22 2019

jankratochvil added a comment to D66398: 2/2: Fix `TestDataFormatterStdList` regression.

because these kinds of regular are horrid.

Aug 22 2019, 7:42 AM · Restricted Project, Restricted Project
jankratochvil committed rGb17d6c52fd4e: [lldb] Fix `TestDataFormatterStdList` regression (authored by jankratochvil).
[lldb] Fix `TestDataFormatterStdList` regression
Aug 22 2019, 7:30 AM
jankratochvil committed rL369655: [lldb] Fix `TestDataFormatterStdList` regression.
[lldb] Fix `TestDataFormatterStdList` regression
Aug 22 2019, 7:30 AM
jankratochvil closed D66398: 2/2: Fix `TestDataFormatterStdList` regression.
Aug 22 2019, 7:30 AM · Restricted Project, Restricted Project
jankratochvil requested review of D66398: 2/2: Fix `TestDataFormatterStdList` regression.
Aug 22 2019, 4:52 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66398: 2/2: Fix `TestDataFormatterStdList` regression.

It just makes now the regexes unambiguous.

Aug 22 2019, 4:52 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D66398: 2/2: Fix `TestDataFormatterStdList` regression.

Since it seems that there is a need for disambiguation (libc++ can be configured to have any name for the inline namespace, so there's no way to make its regex not match the libstdc++ one),

Aug 22 2019, 4:52 AM · Restricted Project, Restricted Project

Aug 20 2019

jankratochvil committed rG1c56d3df1956: [lldb] Use the new Regex::isValid() with no parameter (authored by jankratochvil).
[lldb] Use the new Regex::isValid() with no parameter
Aug 20 2019, 9:16 AM
jankratochvil committed rG95b5f42de814: [clang] Use the new Regex::isValid() with no parameter (authored by jankratochvil).
[clang] Use the new Regex::isValid() with no parameter
Aug 20 2019, 9:08 AM
jankratochvil committed rL369398: [lldb] Use the new Regex::isValid() with no parameter.
[lldb] Use the new Regex::isValid() with no parameter
Aug 20 2019, 9:08 AM
jankratochvil committed rL369397: [clang] Use the new Regex::isValid() with no parameter.
[clang] Use the new Regex::isValid() with no parameter
Aug 20 2019, 9:06 AM
jankratochvil committed rGed602ef4804e: Regex: Add isValid() with no parameter (authored by jankratochvil).
Regex: Add isValid() with no parameter
Aug 20 2019, 9:06 AM
jankratochvil committed rL369396: Regex: Add isValid() with no parameter.
Regex: Add isValid() with no parameter
Aug 20 2019, 9:06 AM
jankratochvil closed D66463: Regex: +isValid() with no parameter.
Aug 20 2019, 9:06 AM · Restricted Project
jankratochvil added inline comments to D66464: Regex: +regex string lifetime comment.
Aug 20 2019, 6:27 AM · Restricted Project
jankratochvil committed rG50fdaaf5b884: Regex: +regex string lifetime comment (authored by jankratochvil).
Regex: +regex string lifetime comment
Aug 20 2019, 6:25 AM
jankratochvil committed rL369383: Regex: +regex string lifetime comment.
Regex: +regex string lifetime comment
Aug 20 2019, 6:24 AM
jankratochvil closed D66464: Regex: +regex string lifetime comment.
Aug 20 2019, 6:24 AM · Restricted Project
jankratochvil created D66464: Regex: +regex string lifetime comment.
Aug 20 2019, 3:16 AM · Restricted Project
jankratochvil added reviewers for D66463: Regex: +isValid() with no parameter: dblaikie, eliben.
Aug 20 2019, 3:10 AM · Restricted Project
jankratochvil created D66463: Regex: +isValid() with no parameter.
Aug 20 2019, 3:07 AM · Restricted Project
jankratochvil committed rGf9d90bc5f690: [lldb] D66174 `RegularExpression` cleanup (authored by jankratochvil).
[lldb] D66174 `RegularExpression` cleanup
Aug 20 2019, 2:24 AM
jankratochvil added a comment to D66392: 1/2: D66174 `RegularExpression` cleanup.

Thanks for the review, I hope my updates for the check-in are fine.

Aug 20 2019, 2:24 AM · Restricted Project, Restricted Project
jankratochvil committed rL369352: [lldb] D66174 `RegularExpression` cleanup.
[lldb] D66174 `RegularExpression` cleanup
Aug 20 2019, 2:24 AM
jankratochvil closed D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 20 2019, 2:24 AM · Restricted Project, Restricted Project
jankratochvil added inline comments to D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 20 2019, 2:18 AM · Restricted Project, Restricted Project

Aug 19 2019

jankratochvil added a comment to D66398: 2/2: Fix `TestDataFormatterStdList` regression.

From IRC:
In fact the whole patch is a oneliner (+operator< for RegularExpression.h):

-  typedef FormattersContainer<lldb::RegularExpressionSP, FormatterImpl> RegexMatchContainer;
+  typedef FormattersContainer<RegularExpression, FormatterImpl> RegexMatchContainer;

The rest of the patch is just a mechanical update to make it compile again.
It was my mistake when trying to fix the TestDataFormatterStdList regression that it looked to me the new RegularExpression must be broken (its lifetime). In the end it was not broken. But along the way I have removed its IMO-excessive Compile() method as I am trying to push this API change as a cleanup in D66392. If there is disagreement I will rework this patch D66398 to use the former RegularExpression API using Compile(). If there is disagreement even with that I can drop it all and just make a new comparison function for lldb::RegularExpressionSP.

Aug 19 2019, 7:56 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66392: 1/2: D66174 `RegularExpression` cleanup.

(comment typo fixed)

Aug 19 2019, 7:45 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D66392: 1/2: D66174 `RegularExpression` cleanup.

I am aware the llvm/ part of this patch needs an extra approval and this is why @JDevlieghere had there that:

std::string discarded;
return m_regex.isValid(discarded);

Is it complicated to get the llvm/ extension approved? I can quickly drop any parts of this patch not considered as feasible.

Aug 19 2019, 7:41 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66398: 2/2: Fix `TestDataFormatterStdList` regression.
Aug 19 2019, 7:34 AM · Restricted Project, Restricted Project
jankratochvil updated the summary of D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 19 2019, 7:34 AM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66392: 1/2: D66174 `RegularExpression` cleanup.
  • Thanks for removing the stale inheritance! (LGTM)
Aug 19 2019, 7:34 AM · Restricted Project, Restricted Project
jankratochvil committed rG0697bcd12761: [lldb] Remove unused inheritance in RegularExpression (authored by jankratochvil).
[lldb] Remove unused inheritance in RegularExpression
Aug 19 2019, 12:08 AM
jankratochvil committed rL369235: [lldb] Remove unused inheritance in RegularExpression.
[lldb] Remove unused inheritance in RegularExpression
Aug 19 2019, 12:06 AM

Aug 18 2019

jankratochvil added a child revision for D66392: 1/2: D66174 `RegularExpression` cleanup: D66398: 2/2: Fix `TestDataFormatterStdList` regression.
Aug 18 2019, 1:22 PM · Restricted Project, Restricted Project
jankratochvil added a parent revision for D66398: 2/2: Fix `TestDataFormatterStdList` regression: D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 18 2019, 1:22 PM · Restricted Project, Restricted Project
jankratochvil retitled D66392: 1/2: D66174 `RegularExpression` cleanup from D66174 `RegularExpression` follow-up/cleanup to 1/2: D66174 `RegularExpression` follow-up/cleanup.
Aug 18 2019, 1:22 PM · Restricted Project, Restricted Project
jankratochvil created D66398: 2/2: Fix `TestDataFormatterStdList` regression.
Aug 18 2019, 1:22 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 18 2019, 1:22 PM · Restricted Project, Restricted Project
jankratochvil planned changes to D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 18 2019, 12:55 PM · Restricted Project, Restricted Project
jankratochvil updated the diff for D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 18 2019, 9:45 AM · Restricted Project, Restricted Project
jankratochvil updated the summary of D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 18 2019, 9:33 AM · Restricted Project, Restricted Project
jankratochvil created D66392: 1/2: D66174 `RegularExpression` cleanup.
Aug 18 2019, 9:19 AM · Restricted Project, Restricted Project

Aug 17 2019

jankratochvil added a comment to D66370: [dotest] Add a dotest flag `--force-dwarf` to override the tested DWARF version..

For DWARF >= 4 it also matters for testing whether one is using -fdebug-types-section or not.

Aug 17 2019, 1:49 PM · Restricted Project, Restricted Project

Aug 9 2019

jankratochvil abandoned D63868: Unify+fix remote XML libraries handling with the legacy one.

OK, right, closing it - I no longer see any functionality problem. Maybe one could do some more code refactorization but I do not have time for that now anyway.

Aug 9 2019, 1:55 AM · Restricted Project

Aug 5 2019

jankratochvil accepted D65561: SymbolVendorELF: Perform build-id lookup even without a debug link.
Aug 5 2019, 3:05 AM · Restricted Project
jankratochvil added a comment to D65561: SymbolVendorELF: Perform build-id lookup even without a debug link.

That would seem to at odds with your " .gnu_debuglink is considered as a flag" assertion, but I am not sure how you came to believe that.

Aug 5 2019, 12:52 AM · Restricted Project

Aug 4 2019

jankratochvil accepted D65560: ObjectFile[ELF]: Refactor gnu_debuglink interface.

Yes, it looks to me as a nice simplification on its own. Just eyeballed.

Aug 4 2019, 1:59 PM · Restricted Project