Page MenuHomePhabricator

jankratochvil (Jan Kratochvil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 11:37 AM (97 w, 6 d)

Recent Activity

Thu, May 23

jankratochvil added a comment to D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

returning lldb::thread_result_t() is probably the best thing to do here...

Thu, May 23, 6:47 AM · Restricted Project
jankratochvil committed rG19a3c307310f: Simplify `GetName`+`AppendTypeName` by `DWARFDIE` (authored by jankratochvil).
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
Thu, May 23, 12:59 AM
jankratochvil committed rL361463: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
Thu, May 23, 12:59 AM
jankratochvil committed rLLDB361463: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
Thu, May 23, 12:59 AM
jankratochvil closed D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Thu, May 23, 12:59 AM · Restricted Project

Wed, May 22

jankratochvil updated the diff for D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.

I have moved it to DWARFDIE.cpp. I agree that it is probably all irrelevant after moving to the LLVM DWARF/ part. I have also removed return type as (1) it was wrong in one case and (2) no existing caller used the return type. I also refactored the deep nesting noted by @JDevlieghere.
I can also remove all the dumping code instead upon request, @labath.

Wed, May 22, 8:59 AM · Restricted Project
jankratochvil requested changes to D62243: Added a dot at the end of comment.

When committing it, there are two more comments without dot in this file.

Wed, May 22, 4:19 AM · Restricted Project

Tue, May 21

jankratochvil updated the diff for D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Tue, May 21, 12:20 PM · Restricted Project
jankratochvil added inline comments to D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Tue, May 21, 12:20 PM · Restricted Project
jankratochvil created D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`.
Tue, May 21, 11:08 AM · Restricted Project
jankratochvil committed rGb7a19321442a: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *` (authored by jankratochvil).
Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
Tue, May 21, 10:37 AM
jankratochvil committed rLLDB361277: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
Tue, May 21, 10:37 AM
jankratochvil committed rL361277: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`
Tue, May 21, 10:37 AM
jankratochvil closed D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Tue, May 21, 10:36 AM · Restricted Project, Restricted Project
jankratochvil committed rL361247: builder lldb-x86_64-fedora: more verbosity.
builder lldb-x86_64-fedora: more verbosity
Tue, May 21, 4:55 AM
jankratochvil closed D62182: builder lldb-x86_64-fedora: more verbosity.
Tue, May 21, 4:55 AM · Restricted Project
jankratochvil accepted D62182: builder lldb-x86_64-fedora: more verbosity.

As this change is local to our lldb-x86_64-fedora (which is even still silent) it is good to go.

Tue, May 21, 4:39 AM · Restricted Project

Mon, May 20

jankratochvil abandoned D61505: Implement .debug_types.

It should be obsoleted by D62073 and future @labath patches.

Mon, May 20, 2:21 AM · Restricted Project

Thu, May 16

jankratochvil updated the diff for D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Thu, May 16, 8:29 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.

Seems like a nice cleanup. Given that code code already assumed that the DWARFUnit can't be null, I'd just delete the null checks..

Thu, May 16, 8:27 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D62008: DWARF: Introduce DWARFTypeUnit class.

On Fedora 29 x86_64 I get:

Thu, May 16, 7:48 AM · Restricted Project
jankratochvil added inline comments to D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Thu, May 16, 7:39 AM · Restricted Project, Restricted Project
jankratochvil created D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`.
Thu, May 16, 7:36 AM · Restricted Project, Restricted Project

Wed, May 15

jankratochvil committed rGe8a039d62c7e: Permit cross-CU references (authored by jankratochvil).
Permit cross-CU references
Wed, May 15, 12:20 PM
jankratochvil committed rLLDB360795: Permit cross-CU references.
Permit cross-CU references
Wed, May 15, 12:20 PM
jankratochvil committed rL360795: Permit cross-CU references.
Permit cross-CU references
Wed, May 15, 12:20 PM
jankratochvil closed D61502: Permit cross-CU references.
Wed, May 15, 12:20 PM · Restricted Project, Restricted Project
jankratochvil added a comment to D61502: Permit cross-CU references.

Just a few simplifications to GetName() and AppendTypeName() are in question and can optionally be done if needed.

Wed, May 15, 12:17 PM · Restricted Project, Restricted Project

Tue, May 14

jankratochvil retitled D61505: Implement .debug_types from 06/06: Implement .debug_types to Implement .debug_types.
Tue, May 14, 12:41 PM · Restricted Project
jankratochvil planned changes to D61505: Implement .debug_types.
Tue, May 14, 12:41 PM · Restricted Project
jankratochvil removed a child revision for D61504: 05/06: Track CUs and TUs separately: D61505: Implement .debug_types.
Tue, May 14, 12:38 PM · Restricted Project
jankratochvil removed a parent revision for D61505: Implement .debug_types: D61504: 05/06: Track CUs and TUs separately.
Tue, May 14, 12:38 PM · Restricted Project
jankratochvil added a parent revision for D61505: Implement .debug_types: D61502: Permit cross-CU references.
Tue, May 14, 12:38 PM · Restricted Project
jankratochvil removed a parent revision for D61503: 04/06: Track .debug_types vs. .debug_info difference: D61502: Permit cross-CU references.
Tue, May 14, 12:38 PM · Restricted Project
jankratochvil edited child revisions for D61502: Permit cross-CU references, added: 1; removed: 1.
Tue, May 14, 12:38 PM · Restricted Project, Restricted Project
jankratochvil edited parent revisions for D61502: Permit cross-CU references, added: 1; removed: 1.
Tue, May 14, 12:38 PM · Restricted Project, Restricted Project
jankratochvil removed a child revision for D61501: 02/06: Finish renaming CompileUnit->Unit: D61502: Permit cross-CU references.
Tue, May 14, 12:38 PM · Restricted Project, Restricted Project
jankratochvil added a child revision for D61908: DWARF: Add ability to reference debug info coming from multiple sections: D61502: Permit cross-CU references.
Tue, May 14, 12:38 PM · Restricted Project
jankratochvil updated the diff for D61502: Permit cross-CU references.
Tue, May 14, 12:38 PM · Restricted Project, Restricted Project
jankratochvil abandoned D61504: 05/06: Track CUs and TUs separately.

Obsoleted by: D61908

Tue, May 14, 12:30 PM · Restricted Project
jankratochvil abandoned D61503: 04/06: Track .debug_types vs. .debug_info difference.

Obsoleted by: D61908

Tue, May 14, 12:30 PM · Restricted Project

Fri, May 10

jankratochvil added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

If you have simple gdb startup commands then translating them into the lldb way should be straightforward, and the burden of learning how lldb works from the command line for these purposes is just not that great and if you are going to use lldb you should just buck up and browse "lldb --help" a bit... If you have complex gdb command lines, you are going to have to rework them anyway to deal with other differences between lldb and gdb. I don't think mixing the two would add enough value to be worth the uglification.

Fri, May 10, 11:42 AM · Restricted Project
jankratochvil added a comment to D61501: 02/06: Finish renaming CompileUnit->Unit.

Thanks for the review, I have pushed it ahead of the rest of the series as it was a bit annoying to keep it updating off-trunk. And then the renaming is a correct cleanup anyway.

Fri, May 10, 10:15 AM · Restricted Project, Restricted Project
jankratochvil committed rG605627374e16: Finish renaming CompileUnit -> Unit (authored by jankratochvil).
Finish renaming CompileUnit -> Unit
Fri, May 10, 10:14 AM
jankratochvil committed rLLDB360443: Finish renaming CompileUnit -> Unit.
Finish renaming CompileUnit -> Unit
Fri, May 10, 10:14 AM
jankratochvil committed rL360443: Finish renaming CompileUnit -> Unit.
Finish renaming CompileUnit -> Unit
Fri, May 10, 10:14 AM
jankratochvil closed D61501: 02/06: Finish renaming CompileUnit->Unit.
Fri, May 10, 10:14 AM · Restricted Project, Restricted Project

Thu, May 9

jankratochvil added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

We don't have single dash flags with multiple characters in LLDB

Thu, May 9, 11:43 AM · Restricted Project

Mon, May 6

jankratochvil committed rG4ce1c3c3ff65: Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset (authored by jankratochvil).
Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset
Mon, May 6, 5:00 AM
jankratochvil committed rLLDB360038: Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset.
Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset
Mon, May 6, 5:00 AM
jankratochvil committed rL360038: Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset.
Merge GetCompileUnitAtOffset + GetCompileUnitContainingDIEOffset
Mon, May 6, 5:00 AM
jankratochvil closed D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset.
Mon, May 6, 5:00 AM · Restricted Project, Restricted Project

Sat, May 4

jankratochvil updated the diff for D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset.

What you could do instead is have a single function which returns the CU if it is in the range cu.GetOffset() <= input < cu.GetNextUnitOffset(), then the wrapper functions could just perform a more stricter check on the returned cu (I.e. no templates or callbacks).

Sat, May 4, 2:11 PM · Restricted Project, Restricted Project

Fri, May 3

jankratochvil added a child revision for D61504: 05/06: Track CUs and TUs separately: D61505: Implement .debug_types.
Fri, May 3, 6:45 AM · Restricted Project
jankratochvil added a parent revision for D61505: Implement .debug_types: D61504: 05/06: Track CUs and TUs separately.
Fri, May 3, 6:45 AM · Restricted Project
jankratochvil created D61505: Implement .debug_types.
Fri, May 3, 6:45 AM · Restricted Project
jankratochvil added a parent revision for D61504: 05/06: Track CUs and TUs separately: D61503: 04/06: Track .debug_types vs. .debug_info difference.
Fri, May 3, 6:42 AM · Restricted Project
jankratochvil added a child revision for D61503: 04/06: Track .debug_types vs. .debug_info difference: D61504: 05/06: Track CUs and TUs separately.
Fri, May 3, 6:42 AM · Restricted Project
jankratochvil created D61504: 05/06: Track CUs and TUs separately.
Fri, May 3, 6:42 AM · Restricted Project
jankratochvil added a parent revision for D61503: 04/06: Track .debug_types vs. .debug_info difference: D61502: Permit cross-CU references.
Fri, May 3, 6:41 AM · Restricted Project
jankratochvil added a child revision for D61502: Permit cross-CU references: D61503: 04/06: Track .debug_types vs. .debug_info difference.
Fri, May 3, 6:41 AM · Restricted Project, Restricted Project
jankratochvil created D61503: 04/06: Track .debug_types vs. .debug_info difference.
Fri, May 3, 6:40 AM · Restricted Project
jankratochvil added a parent revision for D61502: Permit cross-CU references: D61501: 02/06: Finish renaming CompileUnit->Unit.
Fri, May 3, 6:32 AM · Restricted Project, Restricted Project
jankratochvil added a child revision for D61501: 02/06: Finish renaming CompileUnit->Unit: D61502: Permit cross-CU references.
Fri, May 3, 6:32 AM · Restricted Project, Restricted Project
jankratochvil created D61502: Permit cross-CU references.
Fri, May 3, 6:32 AM · Restricted Project, Restricted Project
jankratochvil added a parent revision for D61501: 02/06: Finish renaming CompileUnit->Unit: D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset.
Fri, May 3, 6:23 AM · Restricted Project, Restricted Project
jankratochvil added a child revision for D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset: D61501: 02/06: Finish renaming CompileUnit->Unit.
Fri, May 3, 6:23 AM · Restricted Project, Restricted Project
jankratochvil created D61501: 02/06: Finish renaming CompileUnit->Unit.
Fri, May 3, 6:20 AM · Restricted Project, Restricted Project
jankratochvil created D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset.
Fri, May 3, 6:15 AM · Restricted Project, Restricted Project

Apr 4 2019

jankratochvil committed rGd0157b3b077d: Add dropped ManualDWARFIndex assert() (authored by jankratochvil).
Add dropped ManualDWARFIndex assert()
Apr 4 2019, 2:27 AM
jankratochvil committed rL357678: Add dropped ManualDWARFIndex assert().
Add dropped ManualDWARFIndex assert()
Apr 4 2019, 2:22 AM
jankratochvil committed rLLDB357678: Add dropped ManualDWARFIndex assert().
Add dropped ManualDWARFIndex assert()
Apr 4 2019, 2:22 AM
jankratochvil closed D60254: Add dropped ManualDWARFIndex assert().
Apr 4 2019, 2:22 AM · Restricted Project
jankratochvil added a comment to D60254: Add dropped ManualDWARFIndex assert().

Maybe I will have to update GetBaseCompileUnit, maybe not. But as I find the assert useful (for -fdebug-types-section -gsplit-dwarf) going to add back the assertion. Thanks for the reply.

Apr 4 2019, 2:21 AM · Restricted Project
jankratochvil created D60254: Add dropped ManualDWARFIndex assert().
Apr 4 2019, 12:50 AM · Restricted Project

Mar 29 2019

jankratochvil accepted D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors.

LGTM and it has fixed for me on Kaby Lake Refresh (i7-8650U):

lldb-Suite :: functionalities/register/register_command/TestRegisters.py
lldb-Suite :: tools/lldb-server/TestGdbRemoteRegisterState.py
Mar 29 2019, 8:43 AM · Restricted Project

Mar 12 2019

jankratochvil added inline comments to D59235: Remove Support for DWARF64.
Mar 12 2019, 10:32 AM · Restricted Project
jankratochvil added inline comments to D59235: Remove Support for DWARF64.
Mar 12 2019, 8:10 AM · Restricted Project

Mar 11 2019

jankratochvil planned changes to D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation).
Mar 11 2019, 12:15 PM · Restricted Project
jankratochvil planned changes to D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation).
Mar 11 2019, 12:15 PM · Restricted Project

Mar 10 2019

jankratochvil updated the summary of D59090: Fix LIT %clang_cpp description.
Mar 10 2019, 12:45 PM · Restricted Project

Mar 7 2019

jankratochvil committed rG8a4efd215385: Fix TestDataFormatter.test uninitialized variable (authored by jankratochvil).
Fix TestDataFormatter.test uninitialized variable
Mar 7 2019, 9:39 AM
jankratochvil committed rLLDB355611: Fix TestDataFormatter.test uninitialized variable.
Fix TestDataFormatter.test uninitialized variable
Mar 7 2019, 9:38 AM
jankratochvil committed rL355611: Fix TestDataFormatter.test uninitialized variable.
Fix TestDataFormatter.test uninitialized variable
Mar 7 2019, 9:38 AM
jankratochvil closed D59088: Fix TestDataFormatter.test uninitialized variable.
Mar 7 2019, 9:38 AM · Restricted Project, Restricted Project
jankratochvil added a comment to D55626: [Reproducers] Add tests for functionality.

There is also failing TestImagineList on my Fedora buildbot:

++ : 'RUN: at line 19'
++ cat /home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.txt
++ /home/jkratoch/redhat/llvm-monorepo-clangassert/bin/FileCheck /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Functionalities/TestImagineList.test
/home/jkratoch/redhat/llvm-monorepo/lldb/lit/Reproducer/Functionalities/TestImagineList.test:24:10: error: CHECK: expected string not found in input
# CHECK: [ 1] [[ONE:.*]]
         ^
<stdin>:11:1: note: scanning from here
(lldb) reproducer generate
^
<stdin>:16:22: note: possible intended match here
(lldb) # LLDB init file for the LIT tests.
                     ^

The output is missing [ 1], unaware why it should be required and what is there probably on OSX:

CAPTURE
(lldb) command source -s 0 '/quad/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'
Executing commands in '/quad/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'.
(lldb) # LLDB init file for the LIT tests.
(lldb) settings set symbols.enable-external-lookup false
(lldb) settings set interpreter.echo-comment-commands false
(lldb) target create "/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.out"
Current executable set to '/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.out' (x86_64).
(lldb) image list
[  0] 39FC470D 0x0000000000400000 /home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.out 
(lldb) reproducer generate
Reproducer written to '/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.repro'
REPLAY
(lldb) command source -s 0 '/quad/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'
Executing commands in '/quad/home/jkratoch/redhat/llvm-monorepo/lldb/lit/lit-lldb-init'.
(lldb) # LLDB init file for the LIT tests.
(lldb) settings set symbols.enable-external-lookup false
(lldb) settings set interpreter.echo-comment-commands false
(lldb) target create "/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.out"
Current executable set to '/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.out' (x86_64).
(lldb) image list
[  0] 39FC470D 0x0000000000400000 /home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/lit/Reproducer/Functionalities/Output/TestImagineList.test.tmp.out 
(lldb) reproducer generate
Mar 7 2019, 4:05 AM · Restricted Project, Restricted Project
jankratochvil created D59090: Fix LIT %clang_cpp description.
Mar 7 2019, 3:56 AM · Restricted Project
jankratochvil created D59088: Fix TestDataFormatter.test uninitialized variable.
Mar 7 2019, 3:50 AM · Restricted Project, Restricted Project

Mar 6 2019

jankratochvil added a comment to D58962: Sanity check --max-gdbserver-port.

This caused a failure on the Windows bot:

Mar 6 2019, 7:42 PM · Restricted Project
jankratochvil committed rG67fb9b4a315b: Skip TestGdbserverPort.test on Windows (authored by jankratochvil).
Skip TestGdbserverPort.test on Windows
Mar 6 2019, 7:41 PM
jankratochvil committed rLLDB355579: Skip TestGdbserverPort.test on Windows.
Skip TestGdbserverPort.test on Windows
Mar 6 2019, 7:40 PM
jankratochvil committed rL355579: Skip TestGdbserverPort.test on Windows.
Skip TestGdbserverPort.test on Windows
Mar 6 2019, 7:40 PM
jankratochvil added a comment to D58962: Sanity check --max-gdbserver-port.

There's a tools folder (lit/tools) where this would fit. It's lowercase, possibly to match llvm's test/tools directory?

Mar 6 2019, 1:55 PM · Restricted Project
jankratochvil committed rG94b1ff72f57a: Sanity check --max-gdbserver-port (authored by jankratochvil).
Sanity check --max-gdbserver-port
Mar 6 2019, 1:53 PM
jankratochvil committed rL355554: Sanity check --max-gdbserver-port.
Sanity check --max-gdbserver-port
Mar 6 2019, 1:53 PM
jankratochvil committed rLLDB355554: Sanity check --max-gdbserver-port.
Sanity check --max-gdbserver-port
Mar 6 2019, 1:53 PM
jankratochvil closed D58962: Sanity check --max-gdbserver-port.
Mar 6 2019, 1:53 PM · Restricted Project
jankratochvil added a comment to D58962: Sanity check --max-gdbserver-port.

I'd consider moving the test to lit/lldb-server (new folder)

Mar 6 2019, 3:41 AM · Restricted Project

Mar 5 2019

jankratochvil updated the diff for D58962: Sanity check --max-gdbserver-port.
Mar 5 2019, 8:59 AM · Restricted Project
jankratochvil updated the diff for D58962: Sanity check --max-gdbserver-port.

There is no not as lldb-server still had+has exit code 0 during this error.
I have no idea what to put to the FIXME string there. Failure (with old lldb-server) looks as:

FAIL: LLDB :: Driver/TestGdbserverPort.test (8 of 1551)
******************** TEST 'LLDB :: Driver/TestGdbserverPort.test' FAILED ********************
Script:
--
: 'RUN: at line 1';   /home/jkratoch/redhat/llvm-monorepo-clangassert/bin/lldb-server platform p --server --listen :1234 --min-gdbserver-port 1234 --max-gdbserver-port 1234 2>&1 | /home/jkratoch/redhat/llvm-monorepo-clangassert/bin/FileCheck /home/jkratoch/redhat/llvm-monorepo/lldb/lit/Driver/TestGdbserverPort.test
--
Exit Code: 1
Mar 5 2019, 8:28 AM · Restricted Project