This is an archive of the discontinued LLVM Phabricator instance.

Differential D96933

[DAG] Do not replace bf16 types in replaceStoreOfFPConstant()
AcceptedPublic

Authored by asmith on Feb 17 2021, 8:42 PM.

Details

Reviewers
stuij

Diff Detail

Event Timeline

asmith created this revision.Feb 17 2021, 8:42 PM
Herald added subscribers: ecnelises, hiraditya. · View Herald TranscriptFeb 17 2021, 8:42 PM
asmith requested review of this revision.Feb 17 2021, 8:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 8:42 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
asmith retitled this revision from [DAGCombiner] Missing bf16 type to [DAG] Do not replace bf16 types in replaceStoreOfFPConstant().Feb 17 2021, 8:47 PM
asmith added a reviewer: stuij.
Harbormaster completed remote builds in B89665: Diff 324513.Feb 17 2021, 10:21 PM
stuij accepted this revision.Feb 22 2021, 4:31 PM

LGTM

This revision is now accepted and ready to land.Feb 22 2021, 4:31 PM

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
1 line

Diff 324513

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 17,424 Lines • ▼ Show 20 LinesSDValue DAGCombiner::replaceStoreOfFPConstant(StoreSDNode *ST) {
// processor operation but an i64 (which is not legal) requires two. So the // processor operation but an i64 (which is not legal) requires two. So the
// transform should not be done in this case. // transform should not be done in this case.
SDValue Tmp; SDValue Tmp;
switch (CFP->getSimpleValueType(0).SimpleTy) { switch (CFP->getSimpleValueType(0).SimpleTy) {
default: default:
llvm_unreachable("Unknown FP type"); llvm_unreachable("Unknown FP type");
case MVT::f16: // We don't do this for these yet. case MVT::f16: // We don't do this for these yet.
case MVT::bf16:
case MVT::f80: case MVT::f80:
case MVT::f128: case MVT::f128:
case MVT::ppcf128: case MVT::ppcf128:
return SDValue(); return SDValue();
case MVT::f32: case MVT::f32:
if ((isTypeLegal(MVT::i32) && !LegalOperations && ST->isSimple()) || if ((isTypeLegal(MVT::i32) && !LegalOperations && ST->isSimple()) ||
TLI.isOperationLegalOrCustom(ISD::STORE, MVT::i32)) { TLI.isOperationLegalOrCustom(ISD::STORE, MVT::i32)) {
; ;
▲ Show 20 Lines • Show All 5,307 Lines • Show Last 20 Lines