Page MenuHomePhabricator

asmith (Aaron Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2017, 3:16 PM (89 w, 4 d)

Recent Activity

Wed, Jul 17

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

I believe this address all the comments.

Wed, Jul 17, 9:10 PM · Restricted Project

Tue, Jul 9

asmith committed rG6858f337a833: Revert accidental change to file (authored by asmith).
Revert accidental change to file
Tue, Jul 9, 8:42 PM
asmith committed rL365593: Revert accidental change to file.
Revert accidental change to file
Tue, Jul 9, 8:42 PM
asmith committed rG053eb3565190: Try again to move common functionality from ProcessWindows into ProcessDebugger (authored by asmith).
Try again to move common functionality from ProcessWindows into ProcessDebugger
Tue, Jul 9, 8:37 PM
asmith added a reverting change for rGed499a36b67c: Revert "Move common functionality from processwindows into processdebugger": rG053eb3565190: Try again to move common functionality from ProcessWindows into ProcessDebugger.
Tue, Jul 9, 8:37 PM
asmith committed rL365592: Try again to move common functionality from ProcessWindows into ProcessDebugger.
Try again to move common functionality from ProcessWindows into ProcessDebugger
Tue, Jul 9, 8:37 PM

Tue, Jul 2

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

removed the redundant null checks
added GetThreadHandle to simplify code

Tue, Jul 2, 2:45 PM · Restricted Project

Sun, Jun 30

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

Add a define for STATUS_WX86_BREAKPOINT.

Sun, Jun 30, 1:39 PM · Restricted Project
asmith added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Sun, Jun 30, 1:38 PM · Restricted Project

Fri, Jun 28

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

removed the "clang-format off" in a few places

Fri, Jun 28, 12:28 AM · Restricted Project

Mon, Jun 24

asmith committed rG9c01eaff6aa3: Move common functionality from processwindows into processdebugger (authored by asmith).
Move common functionality from processwindows into processdebugger
Mon, Jun 24, 10:45 AM
asmith committed rL364210: Move common functionality from processwindows into processdebugger.
Move common functionality from processwindows into processdebugger
Mon, Jun 24, 10:45 AM
asmith closed D63166: Move common functionality from processwindows into processdebugger.
Mon, Jun 24, 10:45 AM · Restricted Project

Sun, Jun 23

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Sun, Jun 23, 4:19 PM · Restricted Project

Jun 17 2019

asmith updated the diff for D63166: Move common functionality from processwindows into processdebugger.
Jun 17 2019, 1:56 PM · Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

Fix caps for WoW64

Jun 17 2019, 1:47 PM · Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

Address reviewers comments

Jun 17 2019, 1:24 PM · Restricted Project

Jun 11 2019

asmith added reviewers for D63166: Move common functionality from processwindows into processdebugger: jfb, clayborg.
Jun 11 2019, 1:50 PM · Restricted Project
asmith added reviewers for D63165: Initial support for native debugging of x86/x64 Windows processes: jfb, clayborg.
Jun 11 2019, 1:50 PM · Restricted Project
asmith created D63166: Move common functionality from processwindows into processdebugger.
Jun 11 2019, 1:50 PM · Restricted Project
asmith created D63165: Initial support for native debugging of x86/x64 Windows processes.
Jun 11 2019, 1:45 PM · Restricted Project

May 18 2019

asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
May 18 2019, 5:03 PM · Restricted Project

May 14 2019

asmith updated the diff for D61686: Enable lldb-server on Windows.
May 14 2019, 9:51 PM · Restricted Project
asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
May 14 2019, 9:43 PM · Restricted Project

May 8 2019

asmith updated the diff for D61686: Enable lldb-server on Windows.
May 8 2019, 8:51 AM · Restricted Project
asmith created D61687: Update Python tests for lldb-server on Windows.
May 8 2019, 8:45 AM · Restricted Project
asmith created D61686: Enable lldb-server on Windows.
May 8 2019, 8:42 AM · Restricted Project

Apr 29 2019

asmith committed rGb8d03935e9b8: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID() (authored by asmith).
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Apr 29 2019, 6:40 PM
asmith committed rLLDB359528: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Apr 29 2019, 6:39 PM
asmith committed rL359528: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Apr 29 2019, 6:39 PM
asmith closed D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 29 2019, 6:39 PM · Restricted Project
asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 29 2019, 6:38 PM · Restricted Project

Apr 26 2019

asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 26 2019, 9:53 AM · Restricted Project

Apr 16 2019

asmith committed rGb8ec7eee8118: Clear the output string passed to GetHostName() (authored by asmith).
Clear the output string passed to GetHostName()
Apr 16 2019, 8:13 PM
asmith committed rL358550: Clear the output string passed to GetHostName().
Clear the output string passed to GetHostName()
Apr 16 2019, 8:13 PM
asmith committed rLLDB358550: Clear the output string passed to GetHostName().
Clear the output string passed to GetHostName()
Apr 16 2019, 8:13 PM
asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 16 2019, 7:02 PM · Restricted Project

Apr 15 2019

asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 15 2019, 6:01 PM · Restricted Project

Apr 12 2019

asmith committed rG4b0931bc177b: [lldb-server] Update tests to use std::thread/mutex for all platforms (authored by asmith).
[lldb-server] Update tests to use std::thread/mutex for all platforms
Apr 12 2019, 12:50 AM
asmith committed rLLDB358265: [lldb-server] Update tests to use std::thread/mutex for all platforms.
[lldb-server] Update tests to use std::thread/mutex for all platforms
Apr 12 2019, 12:50 AM
asmith committed rL358265: [lldb-server] Update tests to use std::thread/mutex for all platforms.
[lldb-server] Update tests to use std::thread/mutex for all platforms
Apr 12 2019, 12:50 AM
asmith closed D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 12 2019, 12:49 AM · Restricted Project

Apr 11 2019

asmith added inline comments to D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 11 2019, 7:53 PM · Restricted Project
asmith added inline comments to D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 11 2019, 2:24 PM · Restricted Project
asmith updated the diff for D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.

Address reviewer comments

Apr 11 2019, 2:00 PM · Restricted Project
asmith added a comment to D59348: [DebugInfo] Combine Trivial and NonTrivial flags.

Confirming the nontrivial flag was not in the llvm 8 release.

Apr 11 2019, 1:40 PM · Restricted Project
asmith committed rG994023a3f191: [DebugInfo] Combine Trivial and NonTrivial flags (authored by asmith).
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:24 PM
asmith committed rGfa7745be7a98: [DebugInfo] Combine Trivial and NonTrivial flags (authored by asmith).
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:24 PM
asmith committed rL358220: [DebugInfo] Combine Trivial and NonTrivial flags.
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:23 PM
asmith closed D59348: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 11 2019, 1:23 PM · Restricted Project
asmith committed rC358219: [DebugInfo] Combine Trivial and NonTrivial flags.
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:23 PM
asmith committed rL358219: [DebugInfo] Combine Trivial and NonTrivial flags.
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:23 PM
asmith closed D59347: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 11 2019, 1:23 PM · Restricted Project, Restricted Project

Apr 10 2019

asmith updated the diff for D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 10 2019, 12:40 AM
asmith retitled D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms from [lldb-server] Use std::thread/mutex for all platforms to [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 10 2019, 12:33 AM · Restricted Project

Apr 9 2019

asmith created D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 9 2019, 10:40 PM · Restricted Project
asmith added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 10:40 PM
asmith added a comment to D59347: [DebugInfo] Combine Trivial and NonTrivial flags.

This should be ready to commit

Apr 9 2019, 10:31 PM · Restricted Project, Restricted Project
asmith committed rGf8a74c18ec88: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket… (authored by asmith).
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket…
Apr 9 2019, 9:56 PM
asmith committed rLLDB358044: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket….
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket…
Apr 9 2019, 9:55 PM
asmith committed rL358044: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket….
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket…
Apr 9 2019, 9:55 PM
asmith closed D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup.
Apr 9 2019, 9:55 PM · Restricted Project
asmith updated the diff for D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup.

Addressed the review comments

Apr 9 2019, 9:53 PM · Restricted Project
asmith added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 12:57 PM
asmith added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 12:52 PM
Herald updated subscribers of D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 12:48 PM
asmith updated the diff for D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 12:35 PM

Apr 8 2019

asmith updated the diff for D59348: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 8 2019, 11:51 PM · Restricted Project
asmith updated the diff for D59347: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 8 2019, 11:43 PM · Restricted Project, Restricted Project
asmith added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 8 2019, 11:39 PM
asmith created D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup.
Apr 8 2019, 11:39 PM · Restricted Project

Apr 2 2019

asmith added a comment to D56233: [lldb-server] Add initial support for lldb-server on Windows.

Committed a few NFC changes

Apr 2 2019, 10:14 AM
asmith committed rG41a7950cfb15: [lldb-server] Use llgs namespace to avoid conflicts with Win32 API (authored by asmith).
[lldb-server] Use llgs namespace to avoid conflicts with Win32 API
Apr 2 2019, 10:10 AM
asmith committed rL357496: [lldb-server] Use llgs namespace to avoid conflicts with Win32 API.
[lldb-server] Use llgs namespace to avoid conflicts with Win32 API
Apr 2 2019, 10:10 AM
asmith committed rLLDB357496: [lldb-server] Use llgs namespace to avoid conflicts with Win32 API.
[lldb-server] Use llgs namespace to avoid conflicts with Win32 API
Apr 2 2019, 10:10 AM
asmith committed rGb622809b2df1: Fix typo; NFC (authored by asmith).
Fix typo; NFC
Apr 2 2019, 10:01 AM
asmith committed rL357495: Fix typo; NFC.
Fix typo; NFC
Apr 2 2019, 10:01 AM
asmith committed rLLDB357495: Fix typo; NFC.
Fix typo; NFC
Apr 2 2019, 10:01 AM
asmith retitled D56233: [lldb-server] Add initial support for lldb-server on Windows from [lldb-server] Add initial support for building lldb-server on Windows to [lldb-server] Add initial support for lldb-server on Windows.
Apr 2 2019, 12:03 AM

Apr 1 2019

asmith updated the diff for D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 1 2019, 11:58 PM
asmith updated the diff for D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 1 2019, 9:27 PM

Mar 27 2019

asmith added a reviewer for D59347: [DebugInfo] Combine Trivial and NonTrivial flags: Hui.
Mar 27 2019, 11:37 AM · Restricted Project, Restricted Project

Mar 26 2019

asmith added a comment to D59347: [DebugInfo] Combine Trivial and NonTrivial flags.

Okay if we change the flag then I believe the tests under llvm/tests/lib/DebugInfo/CodeView must be updated. If we use NonTrivial all the existing tests work as expected.

Mar 26 2019, 2:34 PM · Restricted Project, Restricted Project

Mar 25 2019

asmith added a comment to D59347: [DebugInfo] Combine Trivial and NonTrivial flags.

Either way. It was fewer changes to use FlagNonTrivial. Which flag do people want to keep?

Mar 25 2019, 7:38 PM · Restricted Project, Restricted Project

Mar 14 2019

asmith updated the diff for D59348: [DebugInfo] Combine Trivial and NonTrivial flags.

Updated the C API to match

Mar 14 2019, 12:36 PM · Restricted Project

Mar 13 2019

asmith created D59348: [DebugInfo] Combine Trivial and NonTrivial flags.
Mar 13 2019, 10:28 PM · Restricted Project
asmith created D59347: [DebugInfo] Combine Trivial and NonTrivial flags.
Mar 13 2019, 10:22 PM · Restricted Project, Restricted Project

Mar 11 2019

asmith committed rGe8475f78e263: [DebugInfo] Add test cases for FlagNonTrivial (authored by asmith).
[DebugInfo] Add test cases for FlagNonTrivial
Mar 11 2019, 7:00 PM
asmith committed rL355890: [DebugInfo] Add test cases for FlagNonTrivial.
[DebugInfo] Add test cases for FlagNonTrivial
Mar 11 2019, 6:59 PM
asmith committed rC355890: [DebugInfo] Add test cases for FlagNonTrivial.
[DebugInfo] Add test cases for FlagNonTrivial
Mar 11 2019, 6:59 PM
asmith closed D59010: [DebugInfo] Add test cases for FlagNonTrivial.
Mar 11 2019, 6:59 PM · Restricted Project, Restricted Project
asmith added a comment to D59010: [DebugInfo] Add test cases for FlagNonTrivial.

Any additional comments on the tests?

Mar 11 2019, 5:23 PM · Restricted Project, Restricted Project

Mar 6 2019

asmith updated the diff for D59010: [DebugInfo] Add test cases for FlagNonTrivial.
Mar 6 2019, 2:14 PM · Restricted Project, Restricted Project

Mar 5 2019

asmith created D59010: [DebugInfo] Add test cases for FlagNonTrivial.
Mar 5 2019, 6:59 PM · Restricted Project, Restricted Project

Feb 25 2019

asmith committed rGf0d2733e5032: [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial (authored by asmith).
[CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial
Feb 25 2019, 7:50 PM
asmith committed rC354843: [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial.
[CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial
Feb 25 2019, 7:49 PM
asmith committed rL354843: [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial.
[CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial
Feb 25 2019, 7:49 PM
asmith committed rG1d5f8632d709: [CodeView] Emit HasConstructorOrDestructor class option for non-trivial… (authored by asmith).
[CodeView] Emit HasConstructorOrDestructor class option for non-trivial…
Feb 25 2019, 7:25 PM
asmith committed rL354841: [CodeView] Emit HasConstructorOrDestructor class option for non-trivial….
[CodeView] Emit HasConstructorOrDestructor class option for non-trivial…
Feb 25 2019, 7:23 PM
asmith closed D44406: [CodeView] Emit HasConstructorOrDestructor class option for non-trivial constructors.
Feb 25 2019, 7:23 PM · Restricted Project