Page MenuHomePhabricator

asmith (Aaron Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2017, 3:16 PM (98 w, 1 d)

Recent Activity

Yesterday

asmith added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Any comments from the llvm-objcopy community?

Thu, Sep 19, 10:39 PM · Restricted Project

Tue, Sep 17

asmith created D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.
Tue, Sep 17, 8:44 PM · Restricted Project

Aug 15 2019

asmith committed rG5032c6ea0803: [lldb-server] Disable a test on Windows until it can be fixed (authored by asmith).
[lldb-server] Disable a test on Windows until it can be fixed
Aug 15 2019, 8:51 PM
asmith committed rL369083: [lldb-server] Disable a test on Windows until it can be fixed.
[lldb-server] Disable a test on Windows until it can be fixed
Aug 15 2019, 8:51 PM

Aug 14 2019

asmith committed rG86649980464e: Add missing NativeProcessFactory for lldb-server on Windows (authored by asmith).
Add missing NativeProcessFactory for lldb-server on Windows
Aug 14 2019, 9:41 AM
asmith committed rL368872: Add missing NativeProcessFactory for lldb-server on Windows.
Add missing NativeProcessFactory for lldb-server on Windows
Aug 14 2019, 9:41 AM
asmith abandoned D56233: [lldb-server] Add initial support for lldb-server on Windows.

This was split into separate patches and committed. No longer need this review.

Aug 14 2019, 7:04 AM
asmith committed rG03eacbd489d0: Add missing SetID method to fix Windows build (authored by asmith).
Add missing SetID method to fix Windows build
Aug 14 2019, 6:52 AM
asmith committed rL368852: Add missing SetID method to fix Windows build.
Add missing SetID method to fix Windows build
Aug 14 2019, 6:49 AM

Aug 13 2019

asmith committed rG2a39024ac822: Update Python tests for lldb-server on Windows (authored by asmith).
Update Python tests for lldb-server on Windows
Aug 13 2019, 5:15 PM
asmith committed rL368776: Update Python tests for lldb-server on Windows.
Update Python tests for lldb-server on Windows
Aug 13 2019, 5:15 PM
asmith closed D61687: Update Python tests for lldb-server on Windows.
Aug 13 2019, 5:15 PM · Restricted Project, Restricted Project
asmith added a comment to D61687: Update Python tests for lldb-server on Windows.

Any more comments on the tests for Windows?

Aug 13 2019, 5:01 PM · Restricted Project, Restricted Project
asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
Aug 13 2019, 5:01 PM · Restricted Project, Restricted Project
asmith committed rG216944ee035a: Enable lldb-server on Windows (authored by asmith).
Enable lldb-server on Windows
Aug 13 2019, 4:53 PM
asmith committed rL368774: Enable lldb-server on Windows.
Enable lldb-server on Windows
Aug 13 2019, 4:50 PM
asmith closed D61686: Enable lldb-server on Windows.
Aug 13 2019, 4:49 PM · Restricted Project
asmith updated the diff for D61686: Enable lldb-server on Windows.
Aug 13 2019, 4:49 PM · Restricted Project
asmith committed rG5146a9ea5d8d: Initial support for native debugging of x86/x64 Windows processes (authored by asmith).
Initial support for native debugging of x86/x64 Windows processes
Aug 13 2019, 3:18 PM
asmith committed rL368759: Initial support for native debugging of x86/x64 Windows processes.
Initial support for native debugging of x86/x64 Windows processes
Aug 13 2019, 3:18 PM
asmith closed D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 3:18 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 3:17 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 3:04 PM · Restricted Project, Restricted Project
asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

This is done.

Aug 13 2019, 1:33 AM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 1:33 AM · Restricted Project, Restricted Project

Aug 11 2019

asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

Any last comments before this is committed?

Aug 11 2019, 4:50 PM · Restricted Project, Restricted Project

Aug 6 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 6 2019, 7:02 PM · Restricted Project, Restricted Project
asmith added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

Do you need some help fixing the build?

Aug 6 2019, 6:43 AM · Restricted Project, Restricted Project

Aug 2 2019

asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

I can make the one simplification but Im not sure what you are asking as far as the refactoring. Provide an example and I will try to accommodate your request. I'm not going to be able to spend much more time on lldb patches though.

Aug 2 2019, 2:30 AM · Restricted Project, Restricted Project
asmith added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 2 2019, 12:12 AM · Restricted Project, Restricted Project

Jul 30 2019

asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

I don't see anything else to address in this review. Comments?

Jul 30 2019, 5:10 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Jul 30 2019, 5:05 PM · Restricted Project, Restricted Project

Jul 29 2019

asmith added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub.

Jul 29 2019, 9:23 PM · Restricted Project, Restricted Project
asmith added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Jul 29 2019, 6:12 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
  • Undo the change to the test client
  • Remove changes for threads
  • Invalidate module cache on loading/unloading DLLs
Jul 29 2019, 6:04 PM · Restricted Project, Restricted Project
asmith added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

I think this change has introduced a dependence on x64.

Jul 29 2019, 5:38 PM · Restricted Project, Restricted Project

Jul 17 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

I believe this address all the comments.

Jul 17 2019, 9:10 PM · Restricted Project, Restricted Project

Jul 9 2019

asmith committed rG6858f337a833: Revert accidental change to file (authored by asmith).
Revert accidental change to file
Jul 9 2019, 8:42 PM
asmith committed rL365593: Revert accidental change to file.
Revert accidental change to file
Jul 9 2019, 8:42 PM
asmith committed rG053eb3565190: Try again to move common functionality from ProcessWindows into ProcessDebugger (authored by asmith).
Try again to move common functionality from ProcessWindows into ProcessDebugger
Jul 9 2019, 8:37 PM
asmith added a reverting change for rGed499a36b67c: Revert "Move common functionality from processwindows into processdebugger": rG053eb3565190: Try again to move common functionality from ProcessWindows into ProcessDebugger.
Jul 9 2019, 8:37 PM
asmith committed rL365592: Try again to move common functionality from ProcessWindows into ProcessDebugger.
Try again to move common functionality from ProcessWindows into ProcessDebugger
Jul 9 2019, 8:37 PM

Jul 2 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

removed the redundant null checks
added GetThreadHandle to simplify code

Jul 2 2019, 2:45 PM · Restricted Project, Restricted Project

Jun 30 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

Add a define for STATUS_WX86_BREAKPOINT.

Jun 30 2019, 1:39 PM · Restricted Project, Restricted Project
asmith added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Jun 30 2019, 1:38 PM · Restricted Project, Restricted Project

Jun 28 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

removed the "clang-format off" in a few places

Jun 28 2019, 12:28 AM · Restricted Project, Restricted Project

Jun 24 2019

asmith committed rG9c01eaff6aa3: Move common functionality from processwindows into processdebugger (authored by asmith).
Move common functionality from processwindows into processdebugger
Jun 24 2019, 10:45 AM
asmith committed rL364210: Move common functionality from processwindows into processdebugger.
Move common functionality from processwindows into processdebugger
Jun 24 2019, 10:45 AM
asmith closed D63166: Move common functionality from processwindows into processdebugger.
Jun 24 2019, 10:45 AM · Restricted Project

Jun 23 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Jun 23 2019, 4:19 PM · Restricted Project, Restricted Project

Jun 17 2019

asmith updated the diff for D63166: Move common functionality from processwindows into processdebugger.
Jun 17 2019, 1:56 PM · Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

Fix caps for WoW64

Jun 17 2019, 1:47 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.

Address reviewers comments

Jun 17 2019, 1:24 PM · Restricted Project, Restricted Project

Jun 11 2019

asmith added reviewers for D63166: Move common functionality from processwindows into processdebugger: jfb, clayborg.
Jun 11 2019, 1:50 PM · Restricted Project
asmith added reviewers for D63165: Initial support for native debugging of x86/x64 Windows processes: jfb, clayborg.
Jun 11 2019, 1:50 PM · Restricted Project, Restricted Project
asmith created D63166: Move common functionality from processwindows into processdebugger.
Jun 11 2019, 1:50 PM · Restricted Project
asmith created D63165: Initial support for native debugging of x86/x64 Windows processes.
Jun 11 2019, 1:45 PM · Restricted Project, Restricted Project

May 18 2019

asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
May 18 2019, 5:03 PM · Restricted Project, Restricted Project

May 14 2019

asmith updated the diff for D61686: Enable lldb-server on Windows.
May 14 2019, 9:51 PM · Restricted Project
asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
May 14 2019, 9:43 PM · Restricted Project, Restricted Project

May 8 2019

asmith updated the diff for D61686: Enable lldb-server on Windows.
May 8 2019, 8:51 AM · Restricted Project
asmith created D61687: Update Python tests for lldb-server on Windows.
May 8 2019, 8:45 AM · Restricted Project, Restricted Project
asmith created D61686: Enable lldb-server on Windows.
May 8 2019, 8:42 AM · Restricted Project

Apr 29 2019

asmith committed rGb8d03935e9b8: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID() (authored by asmith).
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Apr 29 2019, 6:40 PM
asmith committed rLLDB359528: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Apr 29 2019, 6:39 PM
asmith committed rL359528: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Apr 29 2019, 6:39 PM
asmith closed D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 29 2019, 6:39 PM · Restricted Project
asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 29 2019, 6:38 PM · Restricted Project

Apr 26 2019

asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 26 2019, 9:53 AM · Restricted Project

Apr 16 2019

asmith committed rGb8ec7eee8118: Clear the output string passed to GetHostName() (authored by asmith).
Clear the output string passed to GetHostName()
Apr 16 2019, 8:13 PM
asmith committed rL358550: Clear the output string passed to GetHostName().
Clear the output string passed to GetHostName()
Apr 16 2019, 8:13 PM
asmith committed rLLDB358550: Clear the output string passed to GetHostName().
Clear the output string passed to GetHostName()
Apr 16 2019, 8:13 PM
asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 16 2019, 7:02 PM · Restricted Project

Apr 15 2019

asmith updated the diff for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Apr 15 2019, 6:01 PM · Restricted Project

Apr 12 2019

asmith committed rG4b0931bc177b: [lldb-server] Update tests to use std::thread/mutex for all platforms (authored by asmith).
[lldb-server] Update tests to use std::thread/mutex for all platforms
Apr 12 2019, 12:50 AM
asmith committed rLLDB358265: [lldb-server] Update tests to use std::thread/mutex for all platforms.
[lldb-server] Update tests to use std::thread/mutex for all platforms
Apr 12 2019, 12:50 AM
asmith committed rL358265: [lldb-server] Update tests to use std::thread/mutex for all platforms.
[lldb-server] Update tests to use std::thread/mutex for all platforms
Apr 12 2019, 12:50 AM
asmith closed D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 12 2019, 12:49 AM · Restricted Project

Apr 11 2019

asmith added inline comments to D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 11 2019, 7:53 PM · Restricted Project
asmith added inline comments to D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 11 2019, 2:24 PM · Restricted Project
asmith updated the diff for D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.

Address reviewer comments

Apr 11 2019, 2:00 PM · Restricted Project
asmith added a comment to D59348: [DebugInfo] Combine Trivial and NonTrivial flags.

Confirming the nontrivial flag was not in the llvm 8 release.

Apr 11 2019, 1:40 PM · Restricted Project
asmith committed rG994023a3f191: [DebugInfo] Combine Trivial and NonTrivial flags (authored by asmith).
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:24 PM
asmith committed rGfa7745be7a98: [DebugInfo] Combine Trivial and NonTrivial flags (authored by asmith).
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:24 PM
asmith committed rL358220: [DebugInfo] Combine Trivial and NonTrivial flags.
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:23 PM
asmith closed D59348: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 11 2019, 1:23 PM · Restricted Project
asmith committed rC358219: [DebugInfo] Combine Trivial and NonTrivial flags.
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:23 PM
asmith committed rL358219: [DebugInfo] Combine Trivial and NonTrivial flags.
[DebugInfo] Combine Trivial and NonTrivial flags
Apr 11 2019, 1:23 PM
asmith closed D59347: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 11 2019, 1:23 PM · Restricted Project, Restricted Project

Apr 10 2019

asmith updated the diff for D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 10 2019, 12:40 AM
asmith retitled D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms from [lldb-server] Use std::thread/mutex for all platforms to [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 10 2019, 12:33 AM · Restricted Project

Apr 9 2019

asmith created D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.
Apr 9 2019, 10:40 PM · Restricted Project
asmith added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 10:40 PM
asmith added a comment to D59347: [DebugInfo] Combine Trivial and NonTrivial flags.

This should be ready to commit

Apr 9 2019, 10:31 PM · Restricted Project, Restricted Project
asmith committed rGf8a74c18ec88: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket… (authored by asmith).
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket…
Apr 9 2019, 9:56 PM
asmith committed rLLDB358044: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket….
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket…
Apr 9 2019, 9:55 PM
asmith committed rL358044: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket….
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket…
Apr 9 2019, 9:55 PM
asmith closed D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup.
Apr 9 2019, 9:55 PM · Restricted Project
asmith updated the diff for D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup.

Addressed the review comments

Apr 9 2019, 9:53 PM · Restricted Project
asmith added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Apr 9 2019, 12:57 PM