The kind mapper provides a portable mechanism to map Fortran type KIND values independent of the front-end to their corresponding MLIR and LLVM types.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
flang/include/flang/Optimizer/Support/KindMapping.h | ||
---|---|---|
58 | There is an implicit size and ordering expectation for defs that seems quite subtle and deserve documentation here. I also don't see a test which exercise this extra parameter? | |
flang/lib/Optimizer/Support/KindMapping.cpp | ||
154 | somehow unrelated to this patch, but the reference here is unusual, is this needed/useful? | |
189 | Seems like the constructor can fail here, should this be a factory function returning an optional then? | |
268 | Nit: if(defs.empty()) |
flang/lib/Optimizer/Support/KindMapping.cpp | ||
---|---|---|
189 | LG! |
There is an implicit size and ordering expectation for defs that seems quite subtle and deserve documentation here.
I also don't see a test which exercise this extra parameter?